[jira] [Commented] (CURATOR-33) Recursive Node Cache

2014-07-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074128#comment-14074128 ] ASF GitHub Bot commented on CURATOR-33: --- Github user cammckenzie commented on the pu

[GitHub] curator pull request: CURATOR-33 recursive TreeCache recipe

2014-07-24 Thread cammckenzie
Github user cammckenzie commented on the pull request: https://github.com/apache/curator/pull/17#issuecomment-50111927 Overall, looks really good. I've made a few minor comments. My only other comment would be that it would be nice to see some more unit tests specific to a multi level

[jira] [Commented] (CURATOR-33) Recursive Node Cache

2014-07-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074120#comment-14074120 ] ASF GitHub Bot commented on CURATOR-33: --- Github user cammckenzie commented on a diff

[GitHub] curator pull request: CURATOR-33 recursive TreeCache recipe

2014-07-24 Thread cammckenzie
Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/17#discussion_r15387439 --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCache.java --- @@ -0,0 +1,600 @@ +/** + * Licensed to the

[jira] [Commented] (CURATOR-33) Recursive Node Cache

2014-07-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074111#comment-14074111 ] ASF GitHub Bot commented on CURATOR-33: --- Github user cammckenzie commented on a diff

[GitHub] curator pull request: CURATOR-33 recursive TreeCache recipe

2014-07-24 Thread cammckenzie
Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/17#discussion_r15387221 --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCache.java --- @@ -0,0 +1,608 @@ +/** + * Licensed to the

[jira] [Commented] (CURATOR-33) Recursive Node Cache

2014-07-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074110#comment-14074110 ] ASF GitHub Bot commented on CURATOR-33: --- Github user cammckenzie commented on a diff

[GitHub] curator pull request: CURATOR-33 recursive TreeCache recipe

2014-07-24 Thread cammckenzie
Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/17#discussion_r15387199 --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCache.java --- @@ -0,0 +1,608 @@ +/** + * Licensed to the

[jira] [Commented] (CURATOR-33) Recursive Node Cache

2014-07-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074105#comment-14074105 ] ASF GitHub Bot commented on CURATOR-33: --- Github user cammckenzie commented on a diff

[GitHub] curator pull request: CURATOR-33 recursive TreeCache recipe

2014-07-24 Thread cammckenzie
Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/17#discussion_r15387161 --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCache.java --- @@ -0,0 +1,608 @@ +/** + * Licensed to the

[jira] [Commented] (CURATOR-33) Recursive Node Cache

2014-07-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074101#comment-14074101 ] ASF GitHub Bot commented on CURATOR-33: --- Github user cammckenzie commented on the pu

[GitHub] curator pull request: CURATOR-33 recursive TreeCache recipe

2014-07-24 Thread cammckenzie
Github user cammckenzie commented on the pull request: https://github.com/apache/curator/pull/17#issuecomment-50110235 Tests are all good for me now, will have a look at the code now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-24 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073942#comment-14073942 ] Scott Blum commented on CURATOR-126: Another think we could do is convert the backgro

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-24 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073260#comment-14073260 ] Jordan Zimmerman commented on CURATOR-126: -- A possible solution is to expose a m

[jira] [Created] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-24 Thread Scott Blum (JIRA)
Scott Blum created CURATOR-126: -- Summary: IllegalStateException in performBackgroundOperation during close Key: CURATOR-126 URL: https://issues.apache.org/jira/browse/CURATOR-126 Project: Apache Curator

[jira] [Commented] (CURATOR-33) Recursive Node Cache

2014-07-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073064#comment-14073064 ] ASF GitHub Bot commented on CURATOR-33: --- Github user dragonsinth commented on the pu

[GitHub] curator pull request: CURATOR-33 recursive TreeCache recipe

2014-07-24 Thread dragonsinth
Github user dragonsinth commented on the pull request: https://github.com/apache/curator/pull/17#issuecomment-49991637 Thanks guys, I was able to repro under 1.7 (I don't have 1.6 on OSX to test against). Interestingly, it looks like the order in which `event.getChildren()` names app