[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541412#comment-14541412
]
ASF GitHub Bot commented on CURATOR-215:
Github user madrob commented on the pull
Github user madrob commented on the pull request:
https://github.com/apache/curator/pull/77#issuecomment-101523984
I don't think you addressed the floating TODO, and `forOperation` should
take `List` instead of `List`. Other than those
minor issues, the rest of this looks good. Thanks
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540966#comment-14540966
]
ASF GitHub Bot commented on CURATOR-215:
Github user Randgalt commented on the pu
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/77#issuecomment-101455486
Anything else before I merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
[
https://issues.apache.org/jira/browse/CURATOR-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540899#comment-14540899
]
Scott Blum commented on CURATOR-218:
I can't repro this on master, I've run it severa
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540682#comment-14540682
]
ASF GitHub Bot commented on CURATOR-215:
Github user madrob commented on the pull
Github user madrob commented on the pull request:
https://github.com/apache/curator/pull/77#issuecomment-101414994
Another thing that is unclear is whether the `TransactionOp` are reusable
or if they are one-shot.
---
If your project is set up for it, you can reply to this email and
Github user madrob commented on the pull request:
https://github.com/apache/curator/pull/77#issuecomment-101413729
TestCompressionInTransaction uses the old APIs. A test with the new APIs
would be good to check for regressions.
Also, I think something weird happened during the
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540667#comment-14540667
]
ASF GitHub Bot commented on CURATOR-215:
Github user madrob commented on the pull
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540561#comment-14540561
]
ASF GitHub Bot commented on CURATOR-215:
Github user Randgalt commented on the pu
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/77#issuecomment-101395257
That's a good idea - will do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540556#comment-14540556
]
ASF GitHub Bot commented on CURATOR-215:
Github user madrob commented on the pull
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540554#comment-14540554
]
ASF GitHub Bot commented on CURATOR-215:
Github user madrob commented on a diff i
Github user madrob commented on the pull request:
https://github.com/apache/curator/pull/77#issuecomment-101394950
Can you add a class to curator-examples that demonstrates how to use this
new API?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user madrob commented on a diff in the pull request:
https://github.com/apache/curator/pull/77#discussion_r30171284
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/api/transaction/CuratorMultiTransactionMain.java
---
@@ -0,0 +1,45 @@
+/**
+ *
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540542#comment-14540542
]
ASF GitHub Bot commented on CURATOR-215:
Github user Randgalt commented on a diff
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/77#discussion_r30170696
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/ExtractingCuratorOp.java
---
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the A
Github user madrob commented on a diff in the pull request:
https://github.com/apache/curator/pull/77#discussion_r30170525
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/ExtractingCuratorOp.java
---
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apa
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540538#comment-14540538
]
ASF GitHub Bot commented on CURATOR-215:
Github user madrob commented on a diff i
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540510#comment-14540510
]
ASF GitHub Bot commented on CURATOR-215:
Github user Randgalt commented on a diff
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/77#discussion_r30169301
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/ExtractingCuratorOp.java
---
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the A
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/77#discussion_r30166279
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorMultiTransactionImpl.java
---
@@ -0,0 +1,166 @@
+/**
+ * Licensed
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540436#comment-14540436
]
ASF GitHub Bot commented on CURATOR-215:
Github user Randgalt commented on a diff
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540439#comment-14540439
]
ASF GitHub Bot commented on CURATOR-215:
Github user Randgalt commented on a diff
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/77#discussion_r30166387
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/SetDataBuilderImpl.java
---
@@ -246,7 +243,7 @@ public Stat forPath(String path,
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/77#discussion_r30166320
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorTransactionImpl.java
---
@@ -188,19 +169,45 @@ private CuratorTransaction
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540433#comment-14540433
]
ASF GitHub Bot commented on CURATOR-215:
Github user Randgalt commented on a diff
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540435#comment-14540435
]
ASF GitHub Bot commented on CURATOR-215:
Github user Randgalt commented on a diff
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/77#discussion_r30166221
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/api/transaction/CuratorMultiTransactionMain.java
---
@@ -0,0 +1,45 @@
+/**
+
[
https://issues.apache.org/jira/browse/CURATOR-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Scott Blum closed CURATOR-145.
--
> TreeCache should implement maxDepth
> ---
>
> Key: CURATO
[
https://issues.apache.org/jira/browse/CURATOR-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Scott Blum resolved CURATOR-145.
Resolution: Fixed
Fix Version/s: 2.7.0
Assignee: Scott Blum
> TreeCache should impl
GitHub user madrob opened a pull request:
https://github.com/apache/curator/pull/78
CURATOR-219 Catch Exceptions, not Throwables
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madrob/curator CURATOR-219
Alternatively you can re
[
https://issues.apache.org/jira/browse/CURATOR-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540273#comment-14540273
]
ASF GitHub Bot commented on CURATOR-219:
GitHub user madrob opened a pull request
Mike Drob created CURATOR-219:
-
Summary: Avoid use of Throwable
Key: CURATOR-219
URL: https://issues.apache.org/jira/browse/CURATOR-219
Project: Apache Curator
Issue Type: Bug
Reporte
[
https://issues.apache.org/jira/browse/CURATOR-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540247#comment-14540247
]
Mike Drob commented on CURATOR-145:
---
Looks like 2.7.0
I don't have permissions to edit
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540232#comment-14540232
]
ASF GitHub Bot commented on CURATOR-215:
Github user madrob commented on a diff i
Github user madrob commented on a diff in the pull request:
https://github.com/apache/curator/pull/77#discussion_r30155941
--- Diff: curator-framework/src/site/confluence/index.confluence ---
@@ -42,11 +42,16 @@ h3. Methods
|getData()|Begins an operation to get a ZNode's data.
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540228#comment-14540228
]
ASF GitHub Bot commented on CURATOR-215:
Github user madrob commented on a diff i
Github user madrob commented on a diff in the pull request:
https://github.com/apache/curator/pull/77#discussion_r30155876
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/SetDataBuilderImpl.java
---
@@ -246,7 +243,7 @@ public Stat forPath(String path, b
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540224#comment-14540224
]
ASF GitHub Bot commented on CURATOR-215:
Github user madrob commented on a diff i
Github user madrob commented on a diff in the pull request:
https://github.com/apache/curator/pull/77#discussion_r30155773
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/ExtractingCuratorOp.java
---
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apa
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540215#comment-14540215
]
ASF GitHub Bot commented on CURATOR-215:
Github user madrob commented on a diff i
Github user madrob commented on a diff in the pull request:
https://github.com/apache/curator/pull/77#discussion_r30155605
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorTransactionImpl.java
---
@@ -188,19 +169,45 @@ private CuratorTransactionRe
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540214#comment-14540214
]
ASF GitHub Bot commented on CURATOR-215:
Github user madrob commented on a diff i
Github user madrob commented on a diff in the pull request:
https://github.com/apache/curator/pull/77#discussion_r30155545
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/api/transaction/CuratorMultiTransactionMain.java
---
@@ -0,0 +1,45 @@
+/**
+ *
[
https://issues.apache.org/jira/browse/CURATOR-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540207#comment-14540207
]
Scott Blum commented on CURATOR-145:
Definitely closed, merged it last October. See
Actually, a few things came up, a couple of hours would be appreciated.
On Tue, May 12, 2015 at 11:00 AM, Mike Drob wrote:
> I'll take a look, please give me an hour or so.
>
> On Tue, May 12, 2015 at 10:58 AM, Jordan Zimmerman <
> jor...@jordanzimmerman.com> wrote:
>
>> Any comments on the new
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540115#comment-14540115
]
ASF GitHub Bot commented on CURATOR-215:
Github user madrob commented on a diff i
Github user madrob commented on a diff in the pull request:
https://github.com/apache/curator/pull/77#discussion_r30150375
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorMultiTransactionImpl.java
---
@@ -0,0 +1,166 @@
+/**
+ * Licensed t
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540112#comment-14540112
]
ASF GitHub Bot commented on CURATOR-215:
Github user Randgalt commented on a diff
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/77#discussion_r30150106
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/api/transaction/CuratorMultiTransactionMain.java
---
@@ -0,0 +1,45 @@
+/**
+
[
https://issues.apache.org/jira/browse/CURATOR-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540110#comment-14540110
]
ASF GitHub Bot commented on CURATOR-215:
Github user madrob commented on a diff i
Github user madrob commented on a diff in the pull request:
https://github.com/apache/curator/pull/77#discussion_r30149971
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/api/transaction/CuratorMultiTransactionMain.java
---
@@ -0,0 +1,45 @@
+/**
+ *
I'll take a look, please give me an hour or so.
On Tue, May 12, 2015 at 10:58 AM, Jordan Zimmerman <
jor...@jordanzimmerman.com> wrote:
> Any comments on the new transaction APIs? I’m going to merge if I don’t
> hear from anyone.
>
> -Jordan
>
> https://github.com/apache/curator/pull/77
>
>
>
Any comments on the new transaction APIs? I’m going to merge if I don’t hear
from anyone.
-Jordan
https://github.com/apache/curator/pull/77
[
https://issues.apache.org/jira/browse/CURATOR-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540053#comment-14540053
]
Mike Drob commented on CURATOR-205:
---
[~sfingram] - If you can open a pull request on Gi
[
https://issues.apache.org/jira/browse/CURATOR-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540060#comment-14540060
]
Mike Drob commented on CURATOR-145:
---
[~dragonsinth] - what version was this fixed in? I
[
https://issues.apache.org/jira/browse/CURATOR-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540046#comment-14540046
]
Mike Drob commented on CURATOR-146:
---
I think this is taken care of by CURATOR-164.
> d
[
https://issues.apache.org/jira/browse/CURATOR-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan Zimmerman updated CURATOR-218:
-
Assignee: Scott Blum
> TreeCache initialization problem with non existant root path
> ---
[
https://issues.apache.org/jira/browse/CURATOR-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539847#comment-14539847
]
ASF GitHub Bot commented on CURATOR-160:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/CURATOR-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan Zimmerman resolved CURATOR-160.
--
Resolution: Fixed
> Support Dynamic Reconfig
>
>
>
Github user asfgit closed the pull request at:
https://github.com/apache/curator/pull/76
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Hey Jordan,
I gave a glimpse at it.
The only thing that I don't like is the renaming of Memberable to Addable,
but this is purely subjective so I don't really mind.
I'd say let's merge it so that we can move forward with the 3.x branch
--
*Ioannis Canellos*
*Blog: http://iocanel.blogspot.co
[
https://issues.apache.org/jira/browse/CURATOR-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Samuel García Martínez updated CURATOR-218:
---
Attachment: failing_test.txt
I've attached the failing test output log
> Tre
[
https://issues.apache.org/jira/browse/CURATOR-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Samuel García Martínez updated CURATOR-218:
---
Environment:
host: AWS EC2 t2.medium type
uname -a = Linux bamboo-agent 3.13
Samuel García Martínez created CURATOR-218:
--
Summary: TreeCache initialization problem with non existant root
path
Key: CURATOR-218
URL: https://issues.apache.org/jira/browse/CURATOR-218
Proj
66 matches
Mail list logo
