Re: CURATOR-217?

Thanks Scott, Done, would you mind checking the origin/CURATOR-167 to make sure that I haven't done anything wrong! I have done a git pull on a different machine and it seems to be ok. cheers On Tue, Aug 25, 2015 at 1:49 PM, Scott Blum wrote: > You just force push your branch. > > If it's your f

Re: CURATOR-217?

You just force push your branch. If it's your feature branch, and you know you have it in a good state locally, you can just force push the remote branch into the same state. You'd never want to do that to master, a release branch, or someone else's branch. On Aug 24, 2015 11:15 PM, "Cameron McKe

Re: CURATOR-217?

Thanks Mike, That was a good description. The CURATOR-167 branch is definitely there as it's been a pull request for the last few months. So, I'll await your thoughts in the morning. Alternatively, I can just merge master instead of rebasing it. On Tue, Aug 25, 2015 at 1:00 PM, Mike Drob wrote:

Re: CURATOR-217?

Yea, that's the big downside with rebasing, is that remotes don't exactly keep up with the history. I'm going to try to explain this as best as I can, but usually I point people towards this excellent "Git for Ages 4 and Up" video https://www.youtube.com/watch?v=1ffBJ4sVUb4 - he talks about rebases

Re: CURATOR-217?

I just tried this and obviously I'm doing something wrong. git checkout CURATOR-167 git pull git rebase -i origin/master #This gives me a dialog with one commit with pick Save and exit #This gives a merge conflict and leaves me in a detached head state (I presume this is ok). Fix up the merge con

[jira] [Commented] (CURATOR-167) All registered watchers should be cleared on close

[ https://issues.apache.org/jira/browse/CURATOR-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710231#comment-14710231 ] Scott Blum commented on CURATOR-167: Nevermind, just saw your branch. Cool! > All r

[jira] [Commented] (CURATOR-167) All registered watchers should be cleared on close

[ https://issues.apache.org/jira/browse/CURATOR-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710230#comment-14710230 ] Scott Blum commented on CURATOR-167: Gotcha. Does that mean there's a tactical fix t

[jira] [Commented] (CURATOR-248) Introduce pluggable error handlers

[ https://issues.apache.org/jira/browse/CURATOR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710208#comment-14710208 ] ASF GitHub Bot commented on CURATOR-248: Github user Randgalt commented on the pu

[GitHub] curator pull request: [CURATOR-248] Introduce pluggable error hand...

Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/98#issuecomment-134404404 This is now feature complete. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

Re: CURATOR-217?

Thanks Mike, Will give it a spin today some time. cheers On Tue, Aug 25, 2015 at 8:36 AM, Mike Drob wrote: > if you're going to tray that, here's what you want to do (assuming command > line) > > git checkout CURATOR-167 # start with the branch that you are changing > git rebase -i master # reba

Re: CURATOR-217?

if you're going to tray that, here's what you want to do (assuming command line) git checkout CURATOR-167 # start with the branch that you are changing git rebase -i master # rebase the current branch on top of the given branch On Mon, Aug 24, 2015 at 5:07 PM, Cameron McKenzie wrote: > Scott, >

Re: CURATOR-217?

Scott, I've been using a similar approach to Jordan given that's what I'm used to, but I'm happy to try your approach. I'm going to try and fix up CURATOR-167 as it will no longer cleanly merge (it's been sitting there a while). So, I should rebase master into the CURATOR-167 branch? cheers On Tue

[jira] [Commented] (CURATOR-167) All registered watchers should be cleared on close

[ https://issues.apache.org/jira/browse/CURATOR-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710139#comment-14710139 ] Cameron McKenzie commented on CURATOR-167: -- [~dragonsinth] CURATOR-105 was raise

[jira] [Commented] (CURATOR-214) Support new create() APIs

[ https://issues.apache.org/jira/browse/CURATOR-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710136#comment-14710136 ] ASF GitHub Bot commented on CURATOR-214: Github user Randgalt commented on the pu

[GitHub] curator pull request: CURATOR-214 - Implemented new ZK API to allo...

Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/96#issuecomment-134392688 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[jira] [Commented] (CURATOR-167) All registered watchers should be cleared on close

[ https://issues.apache.org/jira/browse/CURATOR-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710132#comment-14710132 ] Scott Blum commented on CURATOR-167: Sorry for being dumb, can someone give me the sh

[jira] [Commented] (CURATOR-214) Support new create() APIs

[ https://issues.apache.org/jira/browse/CURATOR-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710096#comment-14710096 ] ASF GitHub Bot commented on CURATOR-214: Github user cammckenzie commented on a d

[jira] [Updated] (CURATOR-233) Bug in double barrier

[ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated CURATOR-233: -- Fix Version/s: (was: awaiting-response) 2.9.0 [~Lianro] - Please check out my pu

[GitHub] curator pull request: CURATOR-214 - Implemented new ZK API to allo...

Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/96#discussion_r37807339 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java --- @@ -520,12 +539,127 @@ public void processResult(i

[jira] [Commented] (CURATOR-233) Bug in double barrier

[ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710088#comment-14710088 ] ASF GitHub Bot commented on CURATOR-233: GitHub user madrob opened a pull request

[GitHub] curator pull request: CURATOR-233 Fix DistributedDoubleBarrier::le...

GitHub user madrob opened a pull request: https://github.com/apache/curator/pull/99 CURATOR-233 Fix DistributedDoubleBarrier::leave DDB::leave would not respect the wait time parameters correctly, and would sometimes return true, even though not all clients had left the barri

[jira] [Assigned] (CURATOR-233) Bug in double barrier

[ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned CURATOR-233: - Assignee: Mike Drob > Bug in double barrier > - > > Key: CUR

[jira] [Closed] (CURATOR-249) Update all Curator recipes to use new pluggable Error Handler

[ https://issues.apache.org/jira/browse/CURATOR-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman closed CURATOR-249. Resolution: Not A Problem It turns out that there are only a few places where this applies

[jira] [Assigned] (CURATOR-248) Introduce pluggable error handlers

[ https://issues.apache.org/jira/browse/CURATOR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman reassigned CURATOR-248: Assignee: Jordan Zimmerman > Introduce pluggable error handlers >

[jira] [Commented] (CURATOR-249) Update all Curator recipes to use new pluggable Error Handler

[ https://issues.apache.org/jira/browse/CURATOR-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709727#comment-14709727 ] Jordan Zimmerman commented on CURATOR-249: -- NOTE: CURATOR-248 applied the error

No takers on CURATOR-248?

I don’t mind doing it. So, speak now or I’ll do it. -Jordan

[jira] [Commented] (CURATOR-233) Bug in double barrier

[ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709692#comment-14709692 ] Mike Drob commented on CURATOR-233: --- Ah, I think I see what you are saying. I did not r

[jira] [Commented] (CURATOR-248) Introduce pluggable error handlers

[ https://issues.apache.org/jira/browse/CURATOR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709675#comment-14709675 ] ASF GitHub Bot commented on CURATOR-248: GitHub user Randgalt opened a pull reque

[GitHub] curator pull request: [CURATOR-248] Introduce pluggable error hand...

GitHub user Randgalt opened a pull request: https://github.com/apache/curator/pull/98 [CURATOR-248] Introduce pluggable error handlers You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/curator CURATOR-248 Alternatively you

Re: CURATOR-217?

LOL! So sorry to hear that. Yeah, it's definitely possible to mess things up badly. If I'm doing something particularly risky, I'll just "git branch original" before I start, so as to leave a branch pointer at my start point as a safe recovery if it goes south. I also use gitk to visualize some

Re: CURATOR-217?

I’ll admit that rebase terrifies me. I’ve f’d up several projects with it so I can’t even type the letters without breaking into a sweat. "git rebase -i” is a lot safer, though. Here’s what I’ve been doing - let me know if it’s OK. For branches that are off of CURATOR-3.0, I never merge master.

[jira] [Comment Edited] (CURATOR-233) Bug in double barrier

[ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709562#comment-14709562 ] J D edited comment on CURATOR-233 at 8/24/15 4:34 PM: -- Hi Mike, Tha

Re: CURATOR-217?

Correct. When I say "main" branch vs. "feature" branch I just mean the stable branch everyone is working against (3.0 or master) vs. a feature branch where you're actively working. You'll get to a point in development where you'll think "Hey, there are changes on the main branch I'm working again

[jira] [Comment Edited] (CURATOR-233) Bug in double barrier

[ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709562#comment-14709562 ] J D edited comment on CURATOR-233 at 8/24/15 4:30 PM: -- Hi Mike, Tha

[jira] [Comment Edited] (CURATOR-233) Bug in double barrier

[ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709562#comment-14709562 ] J D edited comment on CURATOR-233 at 8/24/15 4:29 PM: -- Hi Mike, Tha

[jira] [Closed] (CURATOR-213) Support HostProvider

[ https://issues.apache.org/jira/browse/CURATOR-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman closed CURATOR-213. Resolution: Invalid It turns out this is an internal-only class for now. > Support HostPro

[jira] [Resolved] (CURATOR-217) Use new Watcher Removal APIs in Curator Recipes

[ https://issues.apache.org/jira/browse/CURATOR-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman resolved CURATOR-217. -- Resolution: Fixed > Use new Watcher Removal APIs in Curator Recipes > -

[jira] [Resolved] (CURATOR-161) Support Watcher Removal

[ https://issues.apache.org/jira/browse/CURATOR-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman resolved CURATOR-161. -- Resolution: Fixed > Support Watcher Removal > --- > >

[jira] [Commented] (CURATOR-233) Bug in double barrier

[ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709562#comment-14709562 ] J D commented on CURATOR-233: - Hi Mike, Thanks for looking at this issue. 1. Test case abov

Re: CURATOR-217?

Can you explain this in detail? For me, I have some features that are 3.0.0 based so I’m treating CURATOR-3.0 as a kind of master. The true “master” is Curator 2.x only, right? -Jordan On August 24, 2015 at 11:10:08 AM, Scott Blum (dragonsi...@apache.org) wrote: BTW: I noticed a couple of ne

Re: CURATOR-217?

BTW: I noticed a couple of new commits (ba4b5d8cb1f9733d3901b0b619528454d3dbf8c8 & 2343daf29388566b0efa0b0a2ad21574fb534a27) where 3.0 is getting merged into feature branches. Almost every project I've been on we don't tend to do that as it leads to confusing history (this isn't just aesthetic, it

Re: CURATOR-217?

Yeah, 217 & 161 were the first two big things in 3.0. On Mon, Aug 24, 2015 at 9:53 AM, Jordan Zimmerman < jor...@jordanzimmerman.com> wrote: > OK - Also, is CURATOR-161 complete? The issue is still open in Jira. > > > > On August 24, 2015 at 12:47:21 AM, Cameron McKenzie ( > mckenzie@gmail.co

[jira] [Commented] (CURATOR-217) Use new Watcher Removal APIs in Curator Recipes

[ https://issues.apache.org/jira/browse/CURATOR-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709491#comment-14709491 ] Jordan Zimmerman commented on CURATOR-217: -- I'm trying to figure this out. I thi

Re: [DISCUSS] Releasing Curator 2.9

+1 - I think it’s ready once your list is complete -JZ On August 24, 2015 at 10:47:28 AM, Mike Drob (mad...@cloudera.com) wrote: Devs, First, a big thanks to Jordan for fixing the two test failures that we've been seeing. I'm going to try and get Curator 2.9 ready for release. There is

[jira] [Commented] (CURATOR-217) Use new Watcher Removal APIs in Curator Recipes

[ https://issues.apache.org/jira/browse/CURATOR-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709486#comment-14709486 ] Mike Drob commented on CURATOR-217: --- The PR is closed, was this merged in? Can the issu

[DISCUSS] Releasing Curator 2.9

Devs, First, a big thanks to Jordan for fixing the two test failures that we've been seeing. I'm going to try and get Curator 2.9 ready for release. There is one remaining issue open - CURATOR-167 Once that is resolved, I'm going to run through

[jira] [Resolved] (CURATOR-234) Add test logging back to modules

[ https://issues.apache.org/jira/browse/CURATOR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved CURATOR-234. --- Resolution: Fixed Added test logging to curator-x modules and verified output manually. > Add test l

[jira] [Commented] (CURATOR-167) All registered watchers should be cleared on close

[ https://issues.apache.org/jira/browse/CURATOR-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709477#comment-14709477 ] Jordan Zimmerman commented on CURATOR-167: -- CURATOR-217 > All registered watche

[jira] [Commented] (CURATOR-167) All registered watchers should be cleared on close

[ https://issues.apache.org/jira/browse/CURATOR-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709470#comment-14709470 ] Mike Drob commented on CURATOR-167: --- [~cammckenzie] - Can you make sure that the PR is

[jira] [Commented] (CURATOR-167) All registered watchers should be cleared on close

[ https://issues.apache.org/jira/browse/CURATOR-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709450#comment-14709450 ] Jordan Zimmerman commented on CURATOR-167: -- +1 on that. > All registered watch

[jira] [Updated] (CURATOR-233) Bug in double barrier

[ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated CURATOR-233: -- Fix Version/s: (was: 2.9.0) awaiting-response > Bug in double barrier >

[jira] [Commented] (CURATOR-233) Bug in double barrier

[ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709379#comment-14709379 ] Mike Drob commented on CURATOR-233: --- Hi Lianro. I tried to convert your example into a

[jira] [Commented] (CURATOR-214) Support new create() APIs

[ https://issues.apache.org/jira/browse/CURATOR-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709336#comment-14709336 ] ASF GitHub Bot commented on CURATOR-214: Github user Randgalt commented on a diff

[GitHub] curator pull request: CURATOR-214 - Implemented new ZK API to allo...

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/96#discussion_r37753815 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java --- @@ -520,12 +539,127 @@ public void processResult(int

Re: CURATOR-217?

OK - Also, is CURATOR-161 complete? The issue is still open in Jira. On August 24, 2015 at 12:47:21 AM, Cameron McKenzie (mckenzie@gmail.com) wrote: Yes, I merged it in last week some time. On Mon, Aug 24, 2015 at 3:25 PM, Jordan Zimmerman < jor...@jordanzimmerman.com> wrote: > Scott,

[jira] [Commented] (CURATOR-252) TestLeaderSelectorEdges::createProtectedNodeInBackgroundTest failed

[ https://issues.apache.org/jira/browse/CURATOR-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709291#comment-14709291 ] Jordan Zimmerman commented on CURATOR-252: -- That's the genesis of the Timing cla

[jira] [Commented] (CURATOR-252) TestLeaderSelectorEdges::createProtectedNodeInBackgroundTest failed

[ https://issues.apache.org/jira/browse/CURATOR-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709289#comment-14709289 ] Mike Drob commented on CURATOR-252: --- When there are timing related failures, then we ca

[jira] [Commented] (CURATOR-252) TestLeaderSelectorEdges::createProtectedNodeInBackgroundTest failed

[ https://issues.apache.org/jira/browse/CURATOR-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709255#comment-14709255 ] Jordan Zimmerman commented on CURATOR-252: -- The tests are, in general, flakey du

[jira] [Updated] (CURATOR-252) TestLeaderSelectorEdges::createProtectedNodeInBackgroundTest failed

[ https://issues.apache.org/jira/browse/CURATOR-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated CURATOR-252: - Fix Version/s: (was: 2.9.0) > TestLeaderSelectorEdges::createProtectedNodeInBackgroun

[jira] [Resolved] (CURATOR-242) TestDistributedQueue.testCustomExecutor() is failing

[ https://issues.apache.org/jira/browse/CURATOR-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman resolved CURATOR-242. -- Resolution: Cannot Reproduce The job has subsequently passed. The tests are, in general

[jira] [Commented] (CURATOR-218) Race condition in client.blockUntilConnected()

[ https://issues.apache.org/jira/browse/CURATOR-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709165#comment-14709165 ] ASF GitHub Bot commented on CURATOR-218: Github user madrob closed the pull reque

[jira] [Resolved] (CURATOR-218) Race condition in client.blockUntilConnected()

[ https://issues.apache.org/jira/browse/CURATOR-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved CURATOR-218. --- Resolution: Fixed Assignee: Mike Drob (was: Jordan Zimmerman) Ran into this issue again when b

[jira] [Commented] (CURATOR-218) Race condition in client.blockUntilConnected()

[ https://issues.apache.org/jira/browse/CURATOR-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709164#comment-14709164 ] ASF GitHub Bot commented on CURATOR-218: Github user madrob commented on the pull

[GitHub] curator pull request: CURATOR-218 Reorder ConnectionState process ...

Github user madrob closed the pull request at: https://github.com/apache/curator/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] curator pull request: CURATOR-218 Reorder ConnectionState process ...

Github user madrob commented on the pull request: https://github.com/apache/curator/pull/88#issuecomment-134171096 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled