[jira] [Commented] (CURATOR-460) Timed tolerance for connection suspended leads to simultaneous leaders

2018-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427987#comment-16427987 ] ASF GitHub Bot commented on CURATOR-460: Github user cammckenzie commented on the issue:

[GitHub] curator issue #262: [CURATOR-460] Timed tolerance for connection suspended l...

2018-04-05 Thread cammckenzie
Github user cammckenzie commented on the issue: https://github.com/apache/curator/pull/262 The changes look good to me, thanks @arrodrigues @Randgalt , I think the approach you're suggesting for setting up the default session timeout stuff looks OK. I thought that the

[jira] [Commented] (CURATOR-460) Timed tolerance for connection suspended leads to simultaneous leaders

2018-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427894#comment-16427894 ] ASF GitHub Bot commented on CURATOR-460: Github user arrodrigues commented on a diff in the pull

[jira] [Commented] (CURATOR-460) Timed tolerance for connection suspended leads to simultaneous leaders

2018-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427888#comment-16427888 ] ASF GitHub Bot commented on CURATOR-460: Github user arrodrigues commented on a diff in the pull

[GitHub] curator pull request #262: [CURATOR-460] Timed tolerance for connection susp...

2018-04-05 Thread arrodrigues
Github user arrodrigues commented on a diff in the pull request: https://github.com/apache/curator/pull/262#discussion_r179653281 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateManager.java --- @@ -340,4 +338,12 @@ private void

[GitHub] curator pull request #262: [CURATOR-460] Timed tolerance for connection susp...

2018-04-05 Thread arrodrigues
Github user arrodrigues commented on a diff in the pull request: https://github.com/apache/curator/pull/262#discussion_r179652355 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateManager.java --- @@ -340,4 +338,12 @@ private void

[jira] [Commented] (CURATOR-460) Timed tolerance for connection suspended leads to simultaneous leaders

2018-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427881#comment-16427881 ] ASF GitHub Bot commented on CURATOR-460: Github user arrodrigues commented on a diff in the pull

[GitHub] curator pull request #262: [CURATOR-460] Timed tolerance for connection susp...

2018-04-05 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/262#discussion_r179651175 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateManager.java --- @@ -340,4 +338,12 @@ private void

[jira] [Commented] (CURATOR-460) Timed tolerance for connection suspended leads to simultaneous leaders

2018-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427875#comment-16427875 ] ASF GitHub Bot commented on CURATOR-460: Github user Randgalt commented on a diff in the pull

[jira] [Commented] (CURATOR-460) Timed tolerance for connection suspended leads to simultaneous leaders

2018-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427872#comment-16427872 ] ASF GitHub Bot commented on CURATOR-460: Github user arrodrigues commented on a diff in the pull

[GitHub] curator pull request #262: [CURATOR-460] Timed tolerance for connection susp...

2018-04-05 Thread arrodrigues
Github user arrodrigues commented on a diff in the pull request: https://github.com/apache/curator/pull/262#discussion_r179650717 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateManager.java --- @@ -251,9 +251,15 @@ private void

[jira] [Commented] (CURATOR-460) Timed tolerance for connection suspended leads to simultaneous leaders

2018-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426654#comment-16426654 ] ASF GitHub Bot commented on CURATOR-460: Github user Randgalt commented on the issue:

[GitHub] curator issue #262: [CURATOR-460] Timed tolerance for connection suspended l...

2018-04-05 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/curator/pull/262 I'm thinking we change `StandardConnectionHandlingPolicy`. It should be 33 though right? By the time we get the Disconnected 2/3 of a session have elapsed. However, this could affect

[jira] [Commented] (CURATOR-460) Timed tolerance for connection suspended leads to simultaneous leaders

2018-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426645#comment-16426645 ] ASF GitHub Bot commented on CURATOR-460: Github user Randgalt commented on a diff in the pull

[GitHub] curator pull request #262: [CURATOR-460] Timed tolerance for connection susp...

2018-04-05 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/262#discussion_r179396466 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateManager.java --- @@ -251,9 +251,15 @@ private void