Re: [DISCUSS] Apply a consistent code style to our codebase

2023-05-27 Thread Kezhu Wang
Hi tison, > Curator's libs supports Java 8 for backward compatibility. It's not required for development. I suggest we don't lock ourselves in Java 8 when developing. Previously, I was worried about potential linkage problems(e.g. compile to source level java 8 but linked to sdks above 8). But af

Re: [DISCUSS] Apply a consistent code style to our codebase

2023-05-22 Thread tison
Hi Kezhu, Thanks for looking into this proposal! Comments inline > Both spotless and palantir do not support java 8. Possible minimum java 11. I don't have java 9 and java 10 installed. Curator's libs supports Java 8 for backward compatibility. It's not required for development. I suggest we don

Re: [DISCUSS] Apply a consistent code style to our codebase

2023-05-21 Thread Kezhu Wang
+1 in general. I like the `apply` part. I tried to follow styles from files, but apparently I am not able to confirm that before every prs. My eyes may be sensitive to inconsistent style in intra-function or intra-codeblock. But beyond that, it totally depends on my memories which are somewhat and