[GitHub] Randgalt commented on issue #303: [CURATOR-498] Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch

2019-02-07 Thread GitBox
Randgalt commented on issue #303: [CURATOR-498] Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch URL: https://github.com/apache/curator/pull/303#issuecomment-461557460 @cammckenzie what do you think? Can I merge this? ---

[GitHub] Randgalt commented on a change in pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator

2019-02-07 Thread GitBox
Randgalt commented on a change in pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator URL: https://github.com/apache/curator/pull/304#discussion_r254801927 ## File path: curator-framework/src/main/java/org/apache/curator/framework/state/Circu

[GitHub] Randgalt commented on a change in pull request #300: CURATOR-499 Allow creating sequential nodes with an empty name

2019-02-07 Thread GitBox
Randgalt commented on a change in pull request #300: CURATOR-499 Allow creating sequential nodes with an empty name URL: https://github.com/apache/curator/pull/300#discussion_r254872956 ## File path: curator-client/src/test/java/org/apache/curator/utils/TestZKPaths.java ##

[GitHub] Randgalt removed a comment on issue #300: CURATOR-499 Allow creating sequential nodes with an empty name

2019-02-07 Thread GitBox
Randgalt removed a comment on issue #300: CURATOR-499 Allow creating sequential nodes with an empty name URL: https://github.com/apache/curator/pull/300#issuecomment-459205238 I'm +1 on this change but do you mind writing more tests in `TestZKPaths`? I'd like to see more complete coverage

[GitHub] cammckenzie commented on issue #303: [CURATOR-498] Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch

2019-02-11 Thread GitBox
cammckenzie commented on issue #303: [CURATOR-498] Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch URL: https://github.com/apache/curator/pull/303#issuecomment-462250561 I think the changes are OK. I'm still having issues wit

[GitHub] asfgit merged pull request #303: [CURATOR-498] Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch

2019-02-11 Thread GitBox
asfgit merged pull request #303: [CURATOR-498] Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch URL: https://github.com/apache/curator/pull/303 This is an auto

[GitHub] yuri-tceretian commented on a change in pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator

2019-02-12 Thread GitBox
yuri-tceretian commented on a change in pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator URL: https://github.com/apache/curator/pull/304#discussion_r256184202 ## File path: curator-framework/src/main/java/org/apache/curator/framework/state

[GitHub] Randgalt commented on a change in pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator

2019-02-12 Thread GitBox
Randgalt commented on a change in pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator URL: https://github.com/apache/curator/pull/304#discussion_r256187057 ## File path: curator-framework/src/main/java/org/apache/curator/framework/state/Circu

[GitHub] yuri-tceretian commented on a change in pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator

2019-02-12 Thread GitBox
yuri-tceretian commented on a change in pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator URL: https://github.com/apache/curator/pull/304#discussion_r256187979 ## File path: curator-framework/src/main/java/org/apache/curator/framework/state

[GitHub] yuri-tceretian commented on a change in pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator

2019-02-12 Thread GitBox
yuri-tceretian commented on a change in pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator URL: https://github.com/apache/curator/pull/304#discussion_r256187979 ## File path: curator-framework/src/main/java/org/apache/curator/framework/state

[GitHub] yuri-tceretian commented on a change in pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator

2019-02-12 Thread GitBox
yuri-tceretian commented on a change in pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator URL: https://github.com/apache/curator/pull/304#discussion_r256187979 ## File path: curator-framework/src/main/java/org/apache/curator/framework/state

[GitHub] Randgalt commented on a change in pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator

2019-02-12 Thread GitBox
Randgalt commented on a change in pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator URL: https://github.com/apache/curator/pull/304#discussion_r256244084 ## File path: curator-framework/src/main/java/org/apache/curator/framework/state/Circu

[GitHub] Randgalt commented on a change in pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator

2019-02-12 Thread GitBox
Randgalt commented on a change in pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator URL: https://github.com/apache/curator/pull/304#discussion_r256244084 ## File path: curator-framework/src/main/java/org/apache/curator/framework/state/Circu

[GitHub] yuri-tceretian commented on issue #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator

2019-02-13 Thread GitBox
yuri-tceretian commented on issue #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator URL: https://github.com/apache/curator/pull/304#issuecomment-463249550 > I could make the CircuitBreaker itself configurable. I think another circuit breaker would be bett

[GitHub] asfgit merged pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator

2019-02-13 Thread GitBox
asfgit merged pull request #304: [CURATOR-505] WIP - Circuit breaking connection state listener decorator URL: https://github.com/apache/curator/pull/304 This is an automated message from the Apache Git Service. To respond t

[GitHub] mikhailvaliev commented on issue #280: CURATOR-481 Remove jackson-mapper-asl-version and update jackson

2019-02-18 Thread GitBox
mikhailvaliev commented on issue #280: CURATOR-481 Remove jackson-mapper-asl-version and update jackson URL: https://github.com/apache/curator/pull/280#issuecomment-464627810 so you guys are merging this or what? This is an a

[GitHub] cammckenzie commented on issue #280: CURATOR-481 Remove jackson-mapper-asl-version and update jackson

2019-02-19 Thread GitBox
cammckenzie commented on issue #280: CURATOR-481 Remove jackson-mapper-asl-version and update jackson URL: https://github.com/apache/curator/pull/280#issuecomment-465313054 I'm not sure. I am not familiar with this area of the code base, and while the change seems fairly benign, my concern

[GitHub] TisonKun commented on issue #303: [CURATOR-498] Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch

2019-02-21 Thread GitBox
TisonKun commented on issue #303: [CURATOR-498] Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch URL: https://github.com/apache/curator/pull/303#issuecomment-466068928 @Randgalt does Curator 2.x suffer this issue and if so, wi

[GitHub] Randgalt commented on issue #303: [CURATOR-498] Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch

2019-02-21 Thread GitBox
Randgalt commented on issue #303: [CURATOR-498] Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch URL: https://github.com/apache/curator/pull/303#issuecomment-466118760 > does Curator 2.x suffer this issue and if so, will we ma

[GitHub] Randgalt commented on issue #301: [CURATOR-503] Update dependencies in January 2019

2019-03-02 Thread GitBox
Randgalt commented on issue #301: [CURATOR-503] Update dependencies in January 2019 URL: https://github.com/apache/curator/pull/301#issuecomment-468987166 FYI - Guava has been broken into multiple JARs it seems. I had to update the Guava shading we do. https://github.com/apache/curator/co

[GitHub] [curator] asfgit merged pull request #301: [CURATOR-503] Update dependencies in January 2019

2019-03-03 Thread GitBox
asfgit merged pull request #301: [CURATOR-503] Update dependencies in January 2019 URL: https://github.com/apache/curator/pull/301 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [curator] Randgalt commented on a change in pull request #300: CURATOR-499 Allow creating sequential nodes with an empty name

2019-03-03 Thread GitBox
Randgalt commented on a change in pull request #300: CURATOR-499 Allow creating sequential nodes with an empty name URL: https://github.com/apache/curator/pull/300#discussion_r261870873 ## File path: curator-client/src/test/java/org/apache/curator/utils/TestZKPaths.java ##

[GitHub] [curator] asfgit merged pull request #280: CURATOR-481 Remove jackson-mapper-asl-version and update jackson

2019-03-03 Thread GitBox
asfgit merged pull request #280: CURATOR-481 Remove jackson-mapper-asl-version and update jackson URL: https://github.com/apache/curator/pull/280 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [curator] marquiswang commented on a change in pull request #300: CURATOR-499 Allow creating sequential nodes with an empty name

2019-03-03 Thread GitBox
marquiswang commented on a change in pull request #300: CURATOR-499 Allow creating sequential nodes with an empty name URL: https://github.com/apache/curator/pull/300#discussion_r261882513 ## File path: curator-client/src/test/java/org/apache/curator/utils/TestZKPaths.java ###

[GitHub] [curator] Randgalt merged pull request #259: changed phase of maven-license-plugin to validate

2019-03-03 Thread GitBox
Randgalt merged pull request #259: changed phase of maven-license-plugin to validate URL: https://github.com/apache/curator/pull/259 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [curator] BELUGABEHR opened a new pull request #305: CURATOR-511: Add toString to ZKPaths PathAndNode

2019-03-21 Thread GitBox
BELUGABEHR opened a new pull request #305: CURATOR-511: Add toString to ZKPaths PathAndNode URL: https://github.com/apache/curator/pull/305 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [curator] Randgalt commented on a change in pull request #305: CURATOR-511: Add toString to ZKPaths PathAndNode

2019-03-21 Thread GitBox
Randgalt commented on a change in pull request #305: CURATOR-511: Add toString to ZKPaths PathAndNode URL: https://github.com/apache/curator/pull/305#discussion_r268012253 ## File path: curator-client/src/main/java/org/apache/curator/utils/ZKPaths.java ## @@ -154,6 +154,12

[GitHub] [curator] Randgalt commented on issue #305: CURATOR-511: Add toString to ZKPaths PathAndNode

2019-03-21 Thread GitBox
Randgalt commented on issue #305: CURATOR-511: Add toString to ZKPaths PathAndNode URL: https://github.com/apache/curator/pull/305#issuecomment-475461299 While we're at it maybe we should add `hashCode()` and `equals`? This i

[GitHub] [curator] BELUGABEHR commented on a change in pull request #305: CURATOR-511: Add toString to ZKPaths PathAndNode

2019-03-21 Thread GitBox
BELUGABEHR commented on a change in pull request #305: CURATOR-511: Add toString to ZKPaths PathAndNode URL: https://github.com/apache/curator/pull/305#discussion_r268013178 ## File path: curator-client/src/main/java/org/apache/curator/utils/ZKPaths.java ## @@ -154,6 +154,

[GitHub] [curator] BELUGABEHR commented on issue #305: CURATOR-511: Add toString to ZKPaths PathAndNode

2019-03-21 Thread GitBox
BELUGABEHR commented on issue #305: CURATOR-511: Add toString to ZKPaths PathAndNode URL: https://github.com/apache/curator/pull/305#issuecomment-475465198 @Randgalt Thank you for your time, feedback, and interest. I have pushed a new updated with hashcode and equals. --

[GitHub] [curator] Randgalt merged pull request #305: CURATOR-511: Add toString to ZKPaths PathAndNode

2019-03-22 Thread GitBox
Randgalt merged pull request #305: CURATOR-511: Add toString to ZKPaths PathAndNode URL: https://github.com/apache/curator/pull/305 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [curator] BELUGABEHR opened a new pull request #306: CURATOR-512: Utilize NIO StandardCharsets

2019-03-22 Thread GitBox
BELUGABEHR opened a new pull request #306: CURATOR-512: Utilize NIO StandardCharsets URL: https://github.com/apache/curator/pull/306 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [curator] Randgalt commented on issue #306: CURATOR-512: Utilize NIO StandardCharsets

2019-03-22 Thread GitBox
Randgalt commented on issue #306: CURATOR-512: Utilize NIO StandardCharsets URL: https://github.com/apache/curator/pull/306#issuecomment-475630686 Good idea now that we're Java 8 This is an automated message from the Apach

[GitHub] [curator] BELUGABEHR opened a new pull request #307: CURATOR-514: Utilize ThreadLocalRandom In QueueSharder

2019-03-22 Thread GitBox
BELUGABEHR opened a new pull request #307: CURATOR-514: Utilize ThreadLocalRandom In QueueSharder URL: https://github.com/apache/curator/pull/307 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [curator] BELUGABEHR opened a new pull request #308: CURATOR-515: Remove use of deprecated Throwables method

2019-03-25 Thread GitBox
BELUGABEHR opened a new pull request #308: CURATOR-515: Remove use of deprecated Throwables method URL: https://github.com/apache/curator/pull/308 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [curator] BELUGABEHR opened a new pull request #309: CURATOR-516: Remove Deprecated newSetFromMap

2019-03-25 Thread GitBox
BELUGABEHR opened a new pull request #309: CURATOR-516: Remove Deprecated newSetFromMap URL: https://github.com/apache/curator/pull/309 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [curator] TisonKun opened a new pull request #310: Mark final field in OperationTree

2019-04-08 Thread GitBox
TisonKun opened a new pull request #310: Mark final field in OperationTree URL: https://github.com/apache/curator/pull/310 straight forward cc @Randgalt This is an automated message from the Apache Git Service. To resp

[GitHub] [curator] BELUGABEHR commented on issue #309: CURATOR-516: Remove Deprecated newSetFromMap

2019-04-13 Thread GitBox
BELUGABEHR commented on issue #309: CURATOR-516: Remove Deprecated newSetFromMap URL: https://github.com/apache/curator/pull/309#issuecomment-482821008 Hello @Randgalt. You were able to help me with a previous Curator PR. Can I get your help once more? Thanks.

[GitHub] [curator] JiriOndrusek opened a new pull request #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too

2019-05-13 Thread GitBox
JiriOndrusek opened a new pull request #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too URL: https://github.com/apache/curator/pull/311 Issue: https://issues.apache.org/jira/browse/CURATOR-429 Curator 4.0 supports ZooKeeper 3.4.x (https://curator.apac

[GitHub] [curator] oscerd commented on issue #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too

2019-05-13 Thread GitBox
oscerd commented on issue #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too URL: https://github.com/apache/curator/pull/311#issuecomment-491764812 Thanks @JiriOndrusek This is an automated mess

[GitHub] [curator] shayshim commented on a change in pull request #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too

2019-05-13 Thread GitBox
shayshim commented on a change in pull request #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too URL: https://github.com/apache/curator/pull/311#discussion_r283473432 ## File path: curator-client/pom.xml ## @@ -36,7 +36,7 @@

[GitHub] [curator] shayshim commented on a change in pull request #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too

2019-05-13 Thread GitBox
shayshim commented on a change in pull request #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too URL: https://github.com/apache/curator/pull/311#discussion_r283473432 ## File path: curator-client/pom.xml ## @@ -36,7 +36,7 @@

[GitHub] [curator] oscerd commented on issue #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too

2019-05-13 Thread GitBox
oscerd commented on issue #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too URL: https://github.com/apache/curator/pull/311#issuecomment-491934083 Without applying a version range the result is that curator will work only with zookeeper 3.5, because this the

[GitHub] [curator] oscerd edited a comment on issue #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too

2019-05-13 Thread GitBox
oscerd edited a comment on issue #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too URL: https://github.com/apache/curator/pull/311#issuecomment-491934083 Without applying a version range the result is that curator will work only with zookeeper 3.5, because th

[GitHub] [curator] shayshim commented on issue #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too

2019-05-13 Thread GitBox
shayshim commented on issue #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too URL: https://github.com/apache/curator/pull/311#issuecomment-491956115 Thank you @oscerd, could you explain what do you mean by "Without applying a version range the result is that

[GitHub] [curator] shayshim merged pull request #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too

2019-05-13 Thread GitBox
shayshim merged pull request #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too URL: https://github.com/apache/curator/pull/311 This is an automated message from the Apache Git Service. To respo

[GitHub] [curator] grgrzybek commented on issue #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too

2019-05-13 Thread GitBox
grgrzybek commented on issue #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too URL: https://github.com/apache/curator/pull/311#issuecomment-492081621 @shayshim OSGi is generally very confusing runtime/technology to enforce the most sane and obvious rules that

[GitHub] [curator] oscerd commented on issue #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too

2019-05-13 Thread GitBox
oscerd commented on issue #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too URL: https://github.com/apache/curator/pull/311#issuecomment-492092017 Quote @grgrzybek This is an automated message

[GitHub] [curator] shayshim commented on issue #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too

2019-05-13 Thread GitBox
shayshim commented on issue #311: [CURATOR-429] Make Curator 4.x compatible with Zookeeper 3.4.x in OSGi too URL: https://github.com/apache/curator/pull/311#issuecomment-492093968 @grgrzybek @oscerd thanks! This is an automa

[GitHub] [curator] pacomendes opened a new pull request #312: Compilation on jdk11 for release 8

2019-05-21 Thread GitBox
pacomendes opened a new pull request #312: Compilation on jdk11 for release 8 URL: https://github.com/apache/curator/pull/312 Hi, we're migrating to JDK11 and came across this potential issue. I see from the manifest that 4.2.0 is built on jdk11: ``` Build-Jdk: 11.0.2 Built-B

[GitHub] [curator] pacomendes commented on issue #312: Compilation on jdk11 for release 8

2019-05-21 Thread GitBox
pacomendes commented on issue #312: Compilation on jdk11 for release 8 URL: https://github.com/apache/curator/pull/312#issuecomment-494412828 `org.apache.curator.framework.imps.TestCompression` fails when compiled on jdk11 and run on jdk8 ---

[GitHub] [curator] pacomendes removed a comment on issue #312: Compilation on jdk11 for release 8

2019-05-21 Thread GitBox
pacomendes removed a comment on issue #312: Compilation on jdk11 for release 8 URL: https://github.com/apache/curator/pull/312#issuecomment-494412828 `org.apache.curator.framework.imps.TestCompression` fails when compiled on jdk11 and run on jdk8 ---

[GitHub] [curator] pacomendes commented on a change in pull request #312: Compilation on jdk11 for release 8

2019-05-21 Thread GitBox
pacomendes commented on a change in pull request #312: Compilation on jdk11 for release 8 URL: https://github.com/apache/curator/pull/312#discussion_r286087717 ## File path: pom.xml ## @@ -668,6 +669,7 @@ org.apache.maven.plugins maven-com

[GitHub] [curator] Randgalt commented on issue #312: Compilation on jdk11 for release 8

2019-05-22 Thread GitBox
Randgalt commented on issue #312: Compilation on jdk11 for release 8 URL: https://github.com/apache/curator/pull/312#issuecomment-494827890 Please create an issue in our Jira. All PRs must be for a Jira issue. See here: https://cwiki.apache.org/confluence/display/CURATOR/Submitting+Pull+Re

[GitHub] [curator] pacomendes commented on issue #312: Compilation on jdk11 for release 8

2019-05-22 Thread GitBox
pacomendes commented on issue #312: Compilation on jdk11 for release 8 URL: https://github.com/apache/curator/pull/312#issuecomment-494838104 Thanks @Randgalt Closing this PR, will create an issue. This is an automated message

[GitHub] [curator] pacomendes closed pull request #312: Compilation on jdk11 for release 8

2019-05-22 Thread GitBox
pacomendes closed pull request #312: Compilation on jdk11 for release 8 URL: https://github.com/apache/curator/pull/312 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [curator] pacomendes opened a new pull request #312: Compilation on jdk11 for release 8

2019-05-22 Thread GitBox
pacomendes opened a new pull request #312: Compilation on jdk11 for release 8 URL: https://github.com/apache/curator/pull/312 Hi, we're migrating to JDK11 and came across this potential issue. I see from the manifest that 4.2.0 is built on jdk11: ``` Build-Jdk: 11.0.2 Built-B

[GitHub] [curator] Randgalt commented on issue #312: Compilation on jdk11 for release 8

2019-05-22 Thread GitBox
Randgalt commented on issue #312: Compilation on jdk11 for release 8 URL: https://github.com/apache/curator/pull/312#issuecomment-494842790 The manifest for the JAR at Maven central does show that. I'm not sure why. The classfile version is still 52 (Java 8) I just checked with javap

[GitHub] [curator] pacomendes commented on issue #312: Compilation on jdk11 for release 8

2019-05-22 Thread GitBox
pacomendes commented on issue #312: Compilation on jdk11 for release 8 URL: https://github.com/apache/curator/pull/312#issuecomment-494850625 I created https://issues.apache.org/jira/browse/CURATOR-523 If you build on JDK 11.0.2 using --source 1.8 and --target 1.8 options, the classf

[GitHub] [curator] shayshim commented on issue #312: Compilation on jdk11 for release 8

2019-05-26 Thread GitBox
shayshim commented on issue #312: Compilation on jdk11 for release 8 URL: https://github.com/apache/curator/pull/312#issuecomment-496023799 @Randgalt Do we currently have any reason to build using JDK 11 (or any greater than 8)? If not, and we rebuild 4.2.0 with latest JDK 8 - I think we

[GitHub] [curator] pacomendes commented on issue #312: Compilation on jdk11 for release 8

2019-05-27 Thread GitBox
pacomendes commented on issue #312: Compilation on jdk11 for release 8 URL: https://github.com/apache/curator/pull/312#issuecomment-496120227 If you've already been building and published release artifacts using JDK 11, I think it's sensible to just include the `--release` flag for future

[GitHub] [curator] pacomendes edited a comment on issue #312: Compilation on jdk11 for release 8

2019-05-27 Thread GitBox
pacomendes edited a comment on issue #312: Compilation on jdk11 for release 8 URL: https://github.com/apache/curator/pull/312#issuecomment-496120227 @shayshim @Randgalt If you've already been building and published release artifacts using JDK 11, I think it's sensible to just include the `

[GitHub] [curator] pacomendes opened a new pull request #313: Build on jdk Set release target to 8 for jdk11 compiler

2019-05-27 Thread GitBox
pacomendes opened a new pull request #313: Build on jdk Set release target to 8 for jdk11 compiler URL: https://github.com/apache/curator/pull/313 Test running ci build on openjdk11 with release 8 This is an automated message

[GitHub] [curator] pacomendes commented on issue #312: Compilation on jdk11 for release 8

2019-05-27 Thread GitBox
pacomendes commented on issue #312: Compilation on jdk11 for release 8 URL: https://github.com/apache/curator/pull/312#issuecomment-496164458 Created PR #313 This is an automated message from the Apache Git Service. To respon

[GitHub] [curator] aseychell opened a new pull request #314: Update zookeeper to 3.5.5 stable version

2019-05-28 Thread GitBox
aseychell opened a new pull request #314: Update zookeeper to 3.5.5 stable version URL: https://github.com/apache/curator/pull/314 Zookeeper is now at a stable version 3.5.5 so there is no longer the need to depend on beta version --

[GitHub] [curator] emretetik96 opened a new pull request #315: [CURATOR-530] Documentation on InterProcessSemaphoreMutex is misleading

2019-07-03 Thread GitBox
emretetik96 opened a new pull request #315: [CURATOR-530] Documentation on InterProcessSemaphoreMutex is misleading URL: https://github.com/apache/curator/pull/315 This is an automated message from the Apache Git Service. To

[GitHub] [curator] shayshim commented on a change in pull request #315: [CURATOR-530] Documentation on InterProcessSemaphoreMutex is misleading

2019-07-10 Thread GitBox
shayshim commented on a change in pull request #315: [CURATOR-530] Documentation on InterProcessSemaphoreMutex is misleading URL: https://github.com/apache/curator/pull/315#discussion_r302164352 ## File path: curator-recipes/src/main/java/org/apache/curator/framework/recipes/locks/

[GitHub] [curator] shayshim commented on a change in pull request #315: [CURATOR-530] Documentation on InterProcessSemaphoreMutex is misleading

2019-07-10 Thread GitBox
shayshim commented on a change in pull request #315: [CURATOR-530] Documentation on InterProcessSemaphoreMutex is misleading URL: https://github.com/apache/curator/pull/315#discussion_r302164607 ## File path: curator-recipes/src/main/java/org/apache/curator/framework/recipes/locks/

[GitHub] [curator] emretetik96 commented on a change in pull request #315: [CURATOR-530] Documentation on InterProcessSemaphoreMutex is misleading

2019-07-11 Thread GitBox
emretetik96 commented on a change in pull request #315: [CURATOR-530] Documentation on InterProcessSemaphoreMutex is misleading URL: https://github.com/apache/curator/pull/315#discussion_r302702604 ## File path: curator-recipes/src/main/java/org/apache/curator/framework/recipes/loc

[GitHub] [curator] emretetik96 commented on a change in pull request #315: [CURATOR-530] Documentation on InterProcessSemaphoreMutex is misleading

2019-07-11 Thread GitBox
emretetik96 commented on a change in pull request #315: [CURATOR-530] Documentation on InterProcessSemaphoreMutex is misleading URL: https://github.com/apache/curator/pull/315#discussion_r302707796 ## File path: curator-recipes/src/main/java/org/apache/curator/framework/recipes/loc

[GitHub] [curator] shayshim commented on a change in pull request #315: [CURATOR-530] Documentation on InterProcessSemaphoreMutex is misleading

2019-07-11 Thread GitBox
shayshim commented on a change in pull request #315: [CURATOR-530] Documentation on InterProcessSemaphoreMutex is misleading URL: https://github.com/apache/curator/pull/315#discussion_r302708567 ## File path: curator-recipes/src/main/java/org/apache/curator/framework/recipes/locks/

[GitHub] [curator] shayshim merged pull request #315: [CURATOR-530] Documentation on InterProcessSemaphoreMutex is misleading

2019-07-12 Thread GitBox
shayshim merged pull request #315: [CURATOR-530] Documentation on InterProcessSemaphoreMutex is misleading URL: https://github.com/apache/curator/pull/315 This is an automated message from the Apache Git Service. To respond

[GitHub] [curator] bobningx opened a new pull request #316: CURATOR-528:change mail-lists.html to mailing-lists.html

2019-07-13 Thread GitBox
bobningx opened a new pull request #316: CURATOR-528:change mail-lists.html to mailing-lists.html URL: https://github.com/apache/curator/pull/316 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [curator] bobningx closed pull request #316: CURATOR-528:change mail-lists.html to mailing-lists.html

2019-07-13 Thread GitBox
bobningx closed pull request #316: CURATOR-528:change mail-lists.html to mailing-lists.html URL: https://github.com/apache/curator/pull/316 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [curator] bobningx commented on issue #316: CURATOR-528:change mail-lists.html to mailing-lists.html

2019-07-13 Thread GitBox
bobningx commented on issue #316: CURATOR-528:change mail-lists.html to mailing-lists.html URL: https://github.com/apache/curator/pull/316#issuecomment-511176177 Because this pull request cannot completely solved the issue, so I close it. ---

[GitHub] [curator] shayshim opened a new pull request #317: fix mailing list issues

2019-07-14 Thread GitBox
shayshim opened a new pull request #317: fix mailing list issues URL: https://github.com/apache/curator/pull/317 1. fix mailing-lists.html buttons to have mailto prefix 2. fix doap.rdf to refer correctly to mailing-lists.html --

[GitHub] [curator] shayshim merged pull request #317: fix mailing list issues

2019-07-15 Thread GitBox
shayshim merged pull request #317: fix mailing list issues URL: https://github.com/apache/curator/pull/317 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [curator] tswstarplanet opened a new pull request #318: delete useless do-while loop

2019-07-16 Thread GitBox
tswstarplanet opened a new pull request #318: delete useless do-while loop URL: https://github.com/apache/curator/pull/318 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [curator] bobningx commented on issue #318: delete useless do-while loop

2019-07-16 Thread GitBox
bobningx commented on issue #318: delete useless do-while loop URL: https://github.com/apache/curator/pull/318#issuecomment-512093114 Yeah, this is a minor improvement. The while condition is always false. In other files, there are still some minor improvements like this. ---

[GitHub] [curator] tswstarplanet commented on issue #318: delete useless do-while loop

2019-07-16 Thread GitBox
tswstarplanet commented on issue #318: delete useless do-while loop URL: https://github.com/apache/curator/pull/318#issuecomment-512116277 I don't know why the ci-check failed This is an automated message from the Apache Git S

[GitHub] [curator] TisonKun closed pull request #310: Code improvement in OperationTrace

2019-07-25 Thread GitBox
TisonKun closed pull request #310: Code improvement in OperationTrace URL: https://github.com/apache/curator/pull/310 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [curator] eolivelli opened a new pull request #319: Switch to OpenJDK 8 and 11

2019-07-28 Thread GitBox
eolivelli opened a new pull request #319: Switch to OpenJDK 8 and 11 URL: https://github.com/apache/curator/pull/319 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [curator] eolivelli commented on issue #319: Switch to OpenJDK 8 and 11

2019-07-28 Thread GitBox
eolivelli commented on issue #319: Switch to OpenJDK 8 and 11 URL: https://github.com/apache/curator/pull/319#issuecomment-515768753 There is a log of spammy logs: ``` [INFO] --- clirr-maven-plugin:2.8:check (default) @ curator-client --- [INFO] artifact org.apache.curator:curat

[GitHub] [curator] Randgalt opened a new pull request #320: [CURATOR-533] - introduced circuit breaking behavior

2019-07-28 Thread GitBox
Randgalt opened a new pull request #320: [CURATOR-533] - introduced circuit breaking behavior URL: https://github.com/apache/curator/pull/320 CURATOR-505 introduced circuit breaking behavior via CircuitBreakingConnectionStateListener and ConnectionStateListenerDecorator. Elastic has been

[GitHub] [curator] eolivelli commented on issue #319: Switch to OpenJDK 8 and 11

2019-07-28 Thread GitBox
eolivelli commented on issue #319: Switch to OpenJDK 8 and 11 URL: https://github.com/apache/curator/pull/319#issuecomment-515778890 @Randgalt build failed with a failed testbut at least now it is working. I have added jdk11 that nowadays it better to have on a CI pipeline and I have tur

[GitHub] [curator] asfgit merged pull request #319: [CURATOR-534] Switch to OpenJDK 8 and 11

2019-07-28 Thread GitBox
asfgit merged pull request #319: [CURATOR-534] Switch to OpenJDK 8 and 11 URL: https://github.com/apache/curator/pull/319 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [curator] Randgalt commented on issue #319: [CURATOR-534] Switch to OpenJDK 8 and 11

2019-07-28 Thread GitBox
Randgalt commented on issue #319: [CURATOR-534] Switch to OpenJDK 8 and 11 URL: https://github.com/apache/curator/pull/319#issuecomment-515779812 Thank you! This is an automated message from the Apache Git Service. To respond

[GitHub] [curator] asdf2014 commented on issue #313: Build on jdk Set release target to 8 for jdk11 compiler

2019-07-31 Thread GitBox
asdf2014 commented on issue #313: Build on jdk Set release target to 8 for jdk11 compiler URL: https://github.com/apache/curator/pull/313#issuecomment-516854787 ping @Randgalt @leventov This is an automated message from the

[GitHub] [curator] leventov commented on a change in pull request #313: Build on jdk Set release target to 8 for jdk11 compiler

2019-07-31 Thread GitBox
leventov commented on a change in pull request #313: Build on jdk Set release target to 8 for jdk11 compiler URL: https://github.com/apache/curator/pull/313#discussion_r309377582 ## File path: .travis.yml ## @@ -1,3 +1,3 @@ language: java jdk: - - oraclejdk8 + - openjd

[GitHub] [curator] asdf2014 commented on a change in pull request #313: Build on jdk Set release target to 8 for jdk11 compiler

2019-07-31 Thread GitBox
asdf2014 commented on a change in pull request #313: Build on jdk Set release target to 8 for jdk11 compiler URL: https://github.com/apache/curator/pull/313#discussion_r309542189 ## File path: .travis.yml ## @@ -1,3 +1,3 @@ language: java jdk: - - oraclejdk8 + - openjd

[GitHub] [curator] pacomendes commented on a change in pull request #313: Build on jdk Set release target to 8 for jdk11 compiler

2019-08-01 Thread GitBox
pacomendes commented on a change in pull request #313: Build on jdk Set release target to 8 for jdk11 compiler URL: https://github.com/apache/curator/pull/313#discussion_r309649460 ## File path: .travis.yml ## @@ -1,3 +1,3 @@ language: java jdk: - - oraclejdk8 + - open

[GitHub] [curator] asdf2014 opened a new pull request #321: CURATOR-523: Fix ByteBuffer's compatibility issues

2019-08-01 Thread GitBox
asdf2014 opened a new pull request #321: CURATOR-523: Fix ByteBuffer's compatibility issues URL: https://github.com/apache/curator/pull/321 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [curator] asdf2014 commented on a change in pull request #313: Build on jdk Set release target to 8 for jdk11 compiler

2019-08-01 Thread GitBox
asdf2014 commented on a change in pull request #313: Build on jdk Set release target to 8 for jdk11 compiler URL: https://github.com/apache/curator/pull/313#discussion_r309659541 ## File path: .travis.yml ## @@ -1,3 +1,3 @@ language: java jdk: - - oraclejdk8 + - openjd

[GitHub] [curator] asdf2014 commented on issue #321: CURATOR-523: Fix ByteBuffer's compatibility issues

2019-08-01 Thread GitBox
asdf2014 commented on issue #321: CURATOR-523: Fix ByteBuffer's compatibility issues URL: https://github.com/apache/curator/pull/321#issuecomment-517289236 @leventov @Randgalt @pacomendes PTAL This is an automated message fro

[GitHub] [curator] pacomendes commented on issue #321: CURATOR-523: Fix ByteBuffer's compatibility issues

2019-08-01 Thread GitBox
pacomendes commented on issue #321: CURATOR-523: Fix ByteBuffer's compatibility issues URL: https://github.com/apache/curator/pull/321#issuecomment-517427214 Thanks, LGTM This is an automated message from the Apache Git Servi

[GitHub] [curator] leventov commented on issue #321: CURATOR-523: Fix ByteBuffer's compatibility issues

2019-08-02 Thread GitBox
leventov commented on issue #321: CURATOR-523: Fix ByteBuffer's compatibility issues URL: https://github.com/apache/curator/pull/321#issuecomment-517768249 LGTM, although I don't see how the diff relates to the title of the PR. --

[GitHub] [curator] asdf2014 commented on issue #321: CURATOR-523: Fix ByteBuffer's compatibility issues

2019-08-02 Thread GitBox
asdf2014 commented on issue #321: CURATOR-523: Fix ByteBuffer's compatibility issues URL: https://github.com/apache/curator/pull/321#issuecomment-517790671 @pacomendes @leventov Thank you for your comments. This title is mainly used to indicate that the underlying purpose of this PR is to

[GitHub] [curator] shayshim commented on a change in pull request #320: [CURATOR-533] - improve circuit breaking behavior

2019-08-03 Thread GitBox
shayshim commented on a change in pull request #320: [CURATOR-533] - improve circuit breaking behavior URL: https://github.com/apache/curator/pull/320#discussion_r310363023 ## File path: curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateListener.java

[GitHub] [curator] shayshim commented on a change in pull request #320: [CURATOR-533] - improve circuit breaking behavior

2019-08-03 Thread GitBox
shayshim commented on a change in pull request #320: [CURATOR-533] - improve circuit breaking behavior URL: https://github.com/apache/curator/pull/320#discussion_r310363034 ## File path: curator-framework/src/main/java/org/apache/curator/framework/state/CircuitBreakingManager.java

[GitHub] [curator] shayshim commented on a change in pull request #320: [CURATOR-533] - improve circuit breaking behavior

2019-08-03 Thread GitBox
shayshim commented on a change in pull request #320: [CURATOR-533] - improve circuit breaking behavior URL: https://github.com/apache/curator/pull/320#discussion_r310363954 ## File path: curator-recipes/src/test/java/org/apache/curator/framework/recipes/leader/TestLeaderLatch.java

  1   2   3   4   5   6   7   8   9   10   >