[GitHub] johnament commented on issue #353: [CXF-7579] More config impl.

2017-12-16 Thread GitBox
johnament commented on issue #353: [CXF-7579] More config impl. URL: https://github.com/apache/cxf/pull/353#issuecomment-352185315 @andymc12 I'm going to bring my branch into the repo shortly. What were your thoughts on how to handle the interface validation? There is nothing in CXF tod

[GitHub] andymc12 commented on issue #353: [CXF-7579] More config impl.

2017-12-16 Thread GitBox
andymc12 commented on issue #353: [CXF-7579] More config impl. URL: https://github.com/apache/cxf/pull/353#issuecomment-352194539 @johnament > What were your thoughts on how to handle the interface validation? My thought was that we would add some validation code in the `CxfTypeS

Default Priority for built in providers

2017-12-16 Thread John D. Ament
The JAX-RS spec mandates a certain number of providers by default. I'm noticing that when these providers are added, they're added without any priority. Andy mentioned to me that they should be added with the priority of USER + 1, but the actual resolved priority I'm seeing is USER. Granted, thi

[GitHub] johnament closed pull request #353: [CXF-7579] More config impl.

2017-12-16 Thread GitBox
johnament closed pull request #353: [CXF-7579] More config impl. URL: https://github.com/apache/cxf/pull/353 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

[GitHub] johnament commented on issue #353: [CXF-7579] More config impl.

2017-12-16 Thread GitBox
johnament commented on issue #353: [CXF-7579] More config impl. URL: https://github.com/apache/cxf/pull/353#issuecomment-352204373 @andymc12 FYI, if you want to take a look ``` java.lang.IllegalStateException: The entity is not backed by an input stream, entity class is : java.la

Re: Default Priority for built in providers

2017-12-16 Thread Romain Manni-Bucau
Hi John, It should already be the case but in another manner: with the bus flag. I'm not sure client code got it anytime but rather than using a random number (you never know if user code uses USER+xxx for its own fallbacks) then using the bus - https://github.com/apache/cxf/blob/master/rt/fronten

Re: Default Priority for built in providers

2017-12-16 Thread Andy McCright
I don’t have the code in front of me, but I remember that for JAX-RS providers there was a check for a “user”/“custom” boolean - the built-in providers are false, user providers (regardless of priority) are true. That boolean is checked before the ‘@Priority’ annotation. With the new emphasis on u

Re: Default Priority for built in providers

2017-12-16 Thread Romain Manni-Bucau
Le 16 déc. 2017 20:28, "Andy McCright" a écrit : I don’t have the code in front of me, but I remember that for JAX-RS providers there was a check for a “user”/“custom” boolean - the built-in providers are false, user providers (regardless of priority) are true. That boolean is checked before the

Re: Default Priority for built in providers

2017-12-16 Thread Andy McCright
True - we would also need to add default priority to the user-specified providers (‘Priorities.USER’). On Sat, Dec 16, 2017 at 2:08 PM Romain Manni-Bucau wrote: > Le 16 déc. 2017 20:28, "Andy McCright" a > écrit : > > I don’t have the code in front of me, but I remember that for JAX-RS > provid