Re: Copied classes in cxf-rt-management.jar with JDK11

2022-04-21 Thread Jim Ma
Thanks Freeman. I updated my PRs to remove this profile completely from CXF 3.4.x to 4.x. Please review. On Thu, Apr 21, 2022 at 9:45 PM Freeman Fang wrote: > Hi Jim, > > I took another look, we actually don't need JVM option > --add-exports java.rmi/sun.rmi.registry=ALL-UNNAMED > to build

Re: Copied classes in cxf-rt-management.jar with JDK11

2022-04-21 Thread Freeman Fang
Hi Jim, I took another look, we actually don't need JVM option --add-exports java.rmi/sun.rmi.registry=ALL-UNNAMED to build CXF management module with JDK 9+, because CXF management module now doesn't use JDK internal API sun.rmi.registry anymore(CXF-8250 made this change). So we don't need it

Re: Copied classes in cxf-rt-management.jar with JDK11

2022-04-21 Thread Jim Ma
I think we can remove this profile from 3.4.x and 3.5.x too. There is no reason we should still keep this, right ? I tried to build 3.4.x/3.5.x with jdk11, and the Export-Package entry in META-INF is generated as expected. On Thu, Apr 21, 2022 at 10:25 AM Freeman Fang wrote: > Hi Jim, > > I

Re: Copied classes in cxf-rt-management.jar with JDK11

2022-04-20 Thread Freeman Fang
Hi Jim, I mean remove it from CXF 4.x which is JDK11 minimum. Freeman On Wed, Apr 20, 2022 at 8:45 PM Jim Ma wrote: > Hi Freeman, > Are you saying we can remove this java9-plus profile completely from 3.4.x > to 4.x? > > Cheers, > Jim > > On Wed, Apr 20, 2022 at 10:45 PM Freeman Fang >

Re: Copied classes in cxf-rt-management.jar with JDK11

2022-04-20 Thread Jim Ma
Hi Freeman, Are you saying we can remove this java9-plus profile completely from 3.4.x to 4.x? Cheers, Jim On Wed, Apr 20, 2022 at 10:45 PM Freeman Fang wrote: > Hi Jim, > > Without it, on JDK11 we will see META-INF.versions.11 from the export > package part, and we don't want it. And this

Re: Copied classes in cxf-rt-management.jar with JDK11

2022-04-20 Thread Freeman Fang
Hi Jim, Without it, on JDK11 we will see META-INF.versions.11 from the export package part, and we don't want it. And this META-INF.versions.11 thing is from the maven-compiler-plugin in java9-plus profile. The expected Export-Package should be like Export-Package:

Re: Copied classes in cxf-rt-management.jar with JDK11

2022-04-19 Thread Jim Ma
Hi Freeman, Do you know why we don't require this with JDK8 and only for JDK9 and plus ? I see the Export package info in META-INF built with JDK11 without this configuration already has this export package entry : Export-Package: org.apache.cxf.tracing;version="3.5.3",org.apache.cxf.

Re: Copied classes in cxf-rt-management.jar with JDK11

2022-04-19 Thread Freeman Fang
Hi Jim, Please change the rt/management/pom.xml like this. NONE - org.apache.cxf.management*,org.apache.cxf.tracing* + + org.apache.cxf.management.counters, + org.apache.cxf.management.interceptor, +

Re: Copied classes in cxf-rt-management.jar with JDK11

2022-04-18 Thread Jim Ma
Thanks Andriy. Jira is filled :https://issues.apache.org/jira/browse/CXF-8695 and PRs are sent. On Sun, Apr 17, 2022 at 9:28 AM Andriy Redko wrote: > Hey Jim, > > This is interesting, I believe it is not needed, only some compiler args > need > tailoring (for JDK-11) but the classes should not

Re: Copied classes in cxf-rt-management.jar with JDK11

2022-04-16 Thread Andriy Redko
Hey Jim, This is interesting, I believe it is not needed, only some compiler args need tailoring (for JDK-11) but the classes should not be copied to versions/11. Thanks! Best Regards, Andriy Redko JM> When building cxf-rt-management 3.5.1 with JDK11, some api classes are JM> copied to the

Copied classes in cxf-rt-management.jar with JDK11

2022-04-13 Thread Jim Ma
When building cxf-rt-management 3.5.1 with JDK11, some api classes are copied to the jar file. It looks like these classes are copied by the maven-bundle-plugin from java9-plus profile : *java9-plus[9,) org.apache.felix