Re: [VOTE] Apache Daffodil VS Code Extension 1.3.1-rc1

2023-08-25 Thread Mike Beckerle
This is the issue. I have created PCAP and EthernetIP for Daffodil 3.5.0 and it is working now. On Fri, Aug 25, 2023 at 2:17 PM Mike Beckerle wrote: > Ah. 1.3.1 is Daffodil 3.5.0. That's quite possibly the explanation. I > will report back. > > On Fri, Aug 25, 2023 at 11:50 AM Shane Dell

Re: [VOTE] Apache Daffodil VS Code Extension 1.3.1-rc1

2023-08-25 Thread Steve Lawrence
It's fine to put the release notes in the wiki page. I think the main thing ASF really cares about is there links to download artifacts and keys/checksums on the site page. An abridged version of release notes and/or a link to the more detailed documentation on that page doesn't seem

Re: [VOTE] Apache Daffodil VS Code Extension 1.3.1-rc1

2023-08-25 Thread Steve Lawrence
Sorry, I missed that. I've given it a +1, though in the future you don't need +1's to merge site changes. It's up to the discretion of committers whether or not they need review. And since these are usually reviewed as part of release and not really public until after the release, it's fine to

Re: [VOTE] Apache Daffodil VS Code Extension 1.3.1-rc1

2023-08-25 Thread Adam Rosien
Oh, I didn't know about these release notes! I wish they were part of the extension repo also, tbh. I can see why they are published on the Daffodil site, but I would also like them incorporated or referenced in the docs, which are currently hosted on the extension GitHub wiki. On Fri, Aug 25,

Re: [VOTE] Apache Daffodil VS Code Extension 1.3.1-rc1

2023-08-25 Thread Shane Dell
I have a PR out on the daffodil-site repo, https://github.com/apache/daffodil-site/pull/118, for adding the 1.3.1 release page. Not sure if that is what you were referring to or not Steve. I do say it upgrades to Daffodil 3.5.0, but I can add the link to the release information that Steve

Re: [VOTE] Apache Daffodil VS Code Extension 1.3.1-rc1

2023-08-25 Thread Adam Rosien
We currently have https://github.com/apache/daffodil-vscode/wiki/Apache-Daffodil%E2%84%A2-Extension-for-Visual-Studio-Code:-v1.3.1, and I will add the notes about Daffodil 3.5.0. Thanks! .. Adam On Fri, Aug 25, 2023 at 10:57 AM Steve Lawrence wrote: > For a little more detail, one of the

Re: [VOTE] Apache Daffodil VS Code Extension 1.3.1-rc1

2023-08-25 Thread Mike Beckerle
Ah. 1.3.1 is Daffodil 3.5.0. That's quite possibly the explanation. I will report back. On Fri, Aug 25, 2023 at 11:50 AM Shane Dell wrote: > Mike, > > I see this same issue but my question is were the schemas updated to > support the latest > version of Daffodil? That is the only thing I could

Re: [VOTE] Apache Daffodil VS Code Extension 1.3.1-rc1

2023-08-25 Thread Steve Lawrence
For a little more detail, one of the backwards incompatible changes made in 3.5.0 was a few package renames to better support OSGI. This required that the META-INF/services file in the ethernetIP had to be renamed from org.apache.daffodil.layers.LayerCompiler to

Re: [VOTE] Apache Daffodil VS Code Extension 1.3.1-rc1

2023-08-25 Thread Adam Rosien
I suspect the dfdl-ethernetip-1.2.0.jar your launch.json is pointing to was built at the 1.2.0 git tag, and that jar file isn't compatible with Daffodil 3.5.0. (Tag 1.2.0 uses Daffodil 3.2.1.) If you do a `sbt package` and point your launch.json to the jar file under the target directory, the

Re: [VOTE] Apache Daffodil VS Code Extension 1.3.1-rc1

2023-08-25 Thread Shane Dell
Mike, I see this same issue but my question is were the schemas updated to support the latest version of Daffodil? That is the only thing I could think of that breaks the schemas. I cloned a fresh instance of the PCP schema and I am getting errors trying to run a `sbt clean install`, so I

Re: [VOTE] Apache Daffodil VS Code Extension 1.3.1-rc1

2023-08-25 Thread Adam Rosien
I see the same problem and will file an issue. I don't have any quick ideas why it is happening. .. Adam On Fri, Aug 25, 2023 at 7:45 AM Mike Beckerle wrote: > Not voting yet, because I am perhaps doing something simple wrong. > > I am getting nowhere fast: > > I am debugging PCAP with the

Re: [VOTE] Apache Daffodil VS Code Extension 1.3.1-rc1

2023-08-25 Thread Mike Beckerle
Not voting yet, because I am perhaps doing something simple wrong. I am getting nowhere fast: I am debugging PCAP with the ethernetIP dependency. From a terminal,'sbt clean test' works and all tests pass. This also populates lib_managed which is where the ethernetIP jar is found for the debug