Re: trailing comma 'always' scalafmt considered too ugly to survive

2024-03-01 Thread Mike Beckerle
I've actually seen this coding style for the same reason: val x = Seq( // format: off 1 ,2 ,3 ) // format: on Tolerating or as we have now, requiring dangling commas everywhere feels like a bad trade off when a simple trick like this also works. On Fri, Mar 1, 2024 at 5:53 PM Steve Lawr

Re: trailing comma 'always' scalafmt considered too ugly to survive

2024-03-01 Thread Steve Lawrence
I don't know if it's a very very good reason, but I think the main benefit is making diffs more clear when adding to a list. Without trailing commas you get a diff like this: Seq( 1, - 2 + 2, + 3 ) But with trailing commas the diff is this: Seq( 1, 2, + 3, ) I

trailing comma 'always' scalafmt considered too ugly to survive

2024-03-01 Thread Mike Beckerle
Why oh why did we ever do this? Is anyone very attached to this dangling comma stuff in our current scalafmt rules? I am at this point, vehemently opposed to this code style, and very much want us to switch back to not allowing dangling commas. I've spent hundreds of hours now working this code