Re: Fw: [SonarCloud] incubator-daffodil: 1 new issue (new debt: 5min)

2020-10-29 Thread John Wass
I had dead code about 95% complete and some work on another round of unused (maybe locals) back in June, but the branch will be stale now. Scalafix helps greatly with these tasks but it is still a bit of work. Will take a look and see where that was once this validators stuff is wrapped up. On

Re: Fw: [SonarCloud] incubator-daffodil: 1 new issue (new debt: 5min)

2020-10-26 Thread Steve Lawrence
We removed a bunch of warnings a while ago when adding Scala 2.12 support: https://issues.apache.org/jira/browse/DAFFODIL-2145 I suspect it's just a decent amount of work to reenable these warnings and fix whatever is broke. Something that definitely needs to be done, it's just been relatively lo

Fw: [SonarCloud] incubator-daffodil: 1 new issue (new debt: 5min)

2020-10-26 Thread Beckerle, Mike
So I got this from sonarcloud. It identifies an unused variable for sure. Doesn't help me understand who or why it got into testing. Question: shouldn't our scala compiler settings be giving us a warning about this, and aren't warnings fatal per our current practices? I wouldn't expect we'd nee