Re: codecov - annotation to suppress false positives?

2021-04-27 Thread Beckerle, Mike
bject: codecov - annotation to suppress false positives? I think you'd want "informational" mode, not "only_pulls". It looks like the latter might lose the information from merged commits: only_pulls Only post a status to pull requests, defaults to false. If

Re: codecov - annotation to suppress false positives?

2021-04-27 Thread Beckerle, Mike
dev@daffodil.apache.org Subject: EXT: Re: codecov - annotation to suppress false positives? Thanks! Related to codecov, does anyone have any thoughts on changing codecov.io settings so the GitHub actions are only in the "informational" mode: https://docs.codecov.io/docs/commit-statu

codecov - annotation to suppress false positives?

2021-04-27 Thread Interrante, John A (GE Research, US)
ps://issues.apache.org/jira/browse/DAFFODIL-2509 > about adding these coverage exceptions uniformly for all the Assert.xyzzy > where it is applicable. > > From: Steve Lawrence > Sent: Tuesday, April 27, 2021 12:45 PM > To: dev@daffodil.apache.org

Re: codecov - annotation to suppress false positives?

2021-04-27 Thread Steve Lawrence
t; about adding these coverage exceptions uniformly for all the Assert.xyzzy > where it is applicable. > > From: Steve Lawrence > Sent: Tuesday, April 27, 2021 12:45 PM > To: dev@daffodil.apache.org > Subject: Re: codecov - annotation to suppres

Re: codecov - annotation to suppress false positives?

2021-04-27 Thread Beckerle, Mike
: codecov - annotation to suppress false positives? We use the sbt-scoverage plugin for generating coverage measurements before sending them to codecov.io for display. It looks like this does have a way exclude packages and sections of code: https://github.com/scoverage/sbt-scoverage#exclude-classes

Re: codecov - annotation to suppress false positives?

2021-04-27 Thread Steve Lawrence
We use the sbt-scoverage plugin for generating coverage measurements before sending them to codecov.io for display. It looks like this does have a way exclude packages and sections of code: https://github.com/scoverage/sbt-scoverage#exclude-classes-and-packages So we could maybe do something like

codecov - annotation to suppress false positives?

2021-04-27 Thread Beckerle, Mike
We have assertions like: foo match { ... real cases case thingy => Assert.invariantFailed(".msg...") } The same thing can happen with if-then-else logic obviously where you make a decision, and some paths through the logic can't occur. These always get marked as non-covered, because b