Re: [PR] Add package docs and readme [datasketches-go]

2024-01-05 Thread via GitHub
AlexanderSaydakov merged PR #10: URL: https://github.com/apache/datasketches-go/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

Re: [PR] Generic Frequency Item Sketch [datasketches-go]

2024-01-05 Thread via GitHub
AlexanderSaydakov merged PR #9: URL: https://github.com/apache/datasketches-go/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@da

Re: [PR] Add package docs and readme [datasketches-go]

2024-01-05 Thread via GitHub
freakyzoidberg commented on PR #10: URL: https://github.com/apache/datasketches-go/pull/10#issuecomment-1879280458 (may want to merge https://github.com/apache/datasketches-go/pull/9 before - this branch is based on top of it) -- This is an automated message from the Apache Git Service. T

[PR] Add package docs and readme [datasketches-go]

2024-01-05 Thread via GitHub
freakyzoidberg opened a new pull request, #10: URL: https://github.com/apache/datasketches-go/pull/10 Add documentation and readme to top level and subpackages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Remove outdated study [datasketches-website]

2024-01-05 Thread via GitHub
AlexanderSaydakov commented on PR #157: URL: https://github.com/apache/datasketches-website/pull/157#issuecomment-1879264163 @PavelVesely you may want to comment here: https://github.com/apache/datasketches-cpp/issues/416 -- This is an automated message from the Apache Git Service. To

Re: [PR] Remove outdated study [datasketches-website]

2024-01-05 Thread via GitHub
PavelVesely commented on PR #157: URL: https://github.com/apache/datasketches-website/pull/157#issuecomment-1879258758 As for t-digest vs. KLL or ReqSketch comparison, we have [a paper](https://arxiv.org/abs/2102.09299) with Graham and people from Splunk. I think t-digest was not updated m

Re: [PR] Remove outdated study [datasketches-website]

2024-01-05 Thread via GitHub
AlexanderSaydakov merged PR #157: URL: https://github.com/apache/datasketches-website/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[PR] Remove outdated study [datasketches-website]

2024-01-05 Thread via GitHub
AlexanderSaydakov opened a new pull request, #157: URL: https://github.com/apache/datasketches-website/pull/157 This study is not relevant anymore. t-Digest code improved since then, and comparing with KLL was not the best idea. Now we have REQ sketch, which seems to be a better candidate f

[I] Improve documentation [datasketches-python]

2024-01-05 Thread via GitHub
jmalkin opened a new issue, #25: URL: https://github.com/apache/datasketches-python/issues/25 Most/all our methods have docstrings, but @leerho commented to me at some point that we don't have the larger class descriptions anywhere. We obviously need to fix that. Since docstrings at

Re: [I] nanobind vs pybind11 [datasketches-python]

2024-01-05 Thread via GitHub
jmalkin commented on issue #20: URL: https://github.com/apache/datasketches-python/issues/20#issuecomment-1879173287 With #24 , we are now officially on Nanobind -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [E] [VOTE] Release Apache DataSketches-cpp 5.0.2-rc1

2024-01-05 Thread Alexander Saydakov
+1 - looked at the very simple change since 5.0.1 - checked GPG signature and SHA512 sum - "cmake", "make" and "make test" successful On Fri, Jan 5, 2024 at 6:28 AM Charlie Dickens wrote: > +1 > > Checked signing keys and shasum > built and ran unit tests that all passed on mac os 13.6.3 > > >

Re: [I] nanobind vs pybind11 [datasketches-python]

2024-01-05 Thread via GitHub
jmalkin closed issue #20: nanobind vs pybind11 URL: https://github.com/apache/datasketches-python/issues/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Switch to nanobind [datasketches-python]

2024-01-05 Thread via GitHub
jmalkin merged PR #24: URL: https://github.com/apache/datasketches-python/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@datask

[PR] Switch to nanobind [datasketches-python]

2024-01-05 Thread via GitHub
jmalkin opened a new pull request, #24: URL: https://github.com/apache/datasketches-python/pull/24 Previous PR was from my fork of the repo into a branch here. This is for the final move to main. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Move to nanobind [datasketches-python]

2024-01-05 Thread via GitHub
jmalkin commented on PR #23: URL: https://github.com/apache/datasketches-python/pull/23#issuecomment-1879129894 @c-dickens I addressed the 50% degradation in density, and after trying a bunch of stuff in vector_of_kll it's, well, still a small drop in performance. But certainly for our cla

Re: [PR] Move to nanobind [datasketches-python]

2024-01-05 Thread via GitHub
jmalkin merged PR #23: URL: https://github.com/apache/datasketches-python/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@datask

Re: [E] [VOTE] Release Apache DataSketches-cpp 5.0.2-rc1

2024-01-05 Thread Charlie Dickens
+1 Checked signing keys and shasum built and ran unit tests that all passed on mac os 13.6.3 On Fri, 5 Jan 2024 at 00:10, Jon Malkin wrote: > Hello Apache DataSketches PMC and Community, > > > This is a call for vote to release Apache DataSketches-cpp candidate > version 5.0.2-rc1 > > > This i

Re: [PR] Move to nanobind [datasketches-python]

2024-01-05 Thread via GitHub
c-dickens commented on PR #23: URL: https://github.com/apache/datasketches-python/pull/23#issuecomment-1878537519 Just to make sure I understand this correctly: the timings reported above significantly better than those initially reported for nanobind? If we thought the performance was mix