Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread Mark Struberg
Try to use Unmanaged e.g for injecting into unit test instances ;) > Am 25.09.2016 um 20:57 schrieb John D. Ament : > > On Sun, Sep 25, 2016 at 12:30 PM Mark Struberg > wrote: > >>> Basically, one sticking target I see continually is BeanManagerProvider. >> We already use CDI.current() internal

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread Mark Struberg
Reflection calls are not much slower anymore since java6. > Am 25.09.2016 um 20:57 schrieb John D. Ament : > > On Sun, Sep 25, 2016 at 12:30 PM Mark Struberg > wrote: > >>> Basically, one sticking target I see continually is BeanManagerProvider. >> We already use CDI.current() internally if it

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread Gerhard Petracek
-1 for a cdi2 module (we can't improve our api in such a case - e.g. for a better user-experience in combination with java8+) +1 for a branch for supporting cdi 1.0+ (= current master) + keeping it compatible with new spec.-revisions as long as possible/useful. +1 for moving to ds2 in our master (

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread Romain Manni-Bucau
2016-09-25 21:44 GMT+02:00 John D. Ament : > On Sun, Sep 25, 2016 at 3:16 PM Romain Manni-Bucau > wrote: > > > Le 25 sept. 2016 21:10, "John D. Ament" a écrit > : > > > > > > On Sun, Sep 25, 2016 at 3:07 PM Romain Manni-Bucau < > > rmannibu...@gmail.com> > > > wrote: > > > > > > > Le 25 sept. 20

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread John D. Ament
On Sun, Sep 25, 2016 at 3:16 PM Romain Manni-Bucau wrote: > Le 25 sept. 2016 21:10, "John D. Ament" a écrit : > > > > On Sun, Sep 25, 2016 at 3:07 PM Romain Manni-Bucau < > rmannibu...@gmail.com> > > wrote: > > > > > Le 25 sept. 2016 20:57, "John D. Ament" a > écrit > : > > > > > > > > On Sun,

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread Romain Manni-Bucau
Le 25 sept. 2016 21:10, "John D. Ament" a écrit : > > On Sun, Sep 25, 2016 at 3:07 PM Romain Manni-Bucau > wrote: > > > Le 25 sept. 2016 20:57, "John D. Ament" a écrit : > > > > > > On Sun, Sep 25, 2016 at 12:30 PM Mark Struberg > > > > > wrote: > > > > > > > > Basically, one sticking target I

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread John D. Ament
On Sun, Sep 25, 2016 at 3:07 PM Romain Manni-Bucau wrote: > Le 25 sept. 2016 20:57, "John D. Ament" a écrit : > > > > On Sun, Sep 25, 2016 at 12:30 PM Mark Struberg > > > wrote: > > > > > > Basically, one sticking target I see continually is > BeanManagerProvider. > > > We already use CDI.curre

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread Romain Manni-Bucau
Le 25 sept. 2016 20:57, "John D. Ament" a écrit : > > On Sun, Sep 25, 2016 at 12:30 PM Mark Struberg > wrote: > > > > Basically, one sticking target I see continually is BeanManagerProvider. > > We already use CDI.current() internally if it is available (via > > reflection). > > So no need to upg

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread John D. Ament
On Sun, Sep 25, 2016 at 12:30 PM Mark Struberg wrote: > > Basically, one sticking target I see continually is BeanManagerProvider. > We already use CDI.current() internally if it is available (via > reflection). > So no need to upgrade it just for this feature. > Reflection is inherently slower

[jira] [Resolved] (DELTASPIKE-1206) support for CDI 2.0 feature

2016-09-25 Thread Mark Struberg (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg resolved DELTASPIKE-1206. --- Resolution: Fixed > support for CDI 2.0 feature > --

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread Mark Struberg
We should keep BeanManagerProvider etc around anyway. We could probably mark them as @deprecated. But that's it. Most EE apps in production are still running on EE6 today. That's the sad truth :( There is imo also no technical need to get rid of BMP. LieGrue, strub > On Sunday, 25 Septemb

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread Mark Struberg
> Basically, one sticking target I see continually is BeanManagerProvider. We already use CDI.current() internally if it is available (via reflection). So no need to upgrade it just for this feature. > but its because we didn't make a DS version > that was CDI 1.1+ compatible. Nope, ALL our ver

[jira] [Commented] (DELTASPIKE-1206) support for CDI 2.0 feature

2016-09-25 Thread Romain Manni-Bucau (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15521041#comment-15521041 ] Romain Manni-Bucau commented on DELTASPIKE-1206: @struberg there was

[jira] [Commented] (DELTASPIKE-1206) support for CDI 2.0 feature

2016-09-25 Thread Mark Struberg (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15521038#comment-15521038 ] Mark Struberg commented on DELTASPIKE-1206: --- Nope will NOT break anything!

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread Romain Manni-Bucau
2016-09-25 17:54 GMT+02:00 John D. Ament : > On Sun, Sep 25, 2016 at 11:49 AM Romain Manni-Bucau > > wrote: > > > 2016-09-25 17:40 GMT+02:00 John D. Ament : > > > > > On Sun, Sep 25, 2016 at 11:37 AM Romain Manni-Bucau < > > rmannibu...@gmail.com > > > > > > > wrote: > > > > > > > 2016-09-25 17:3

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread John D. Ament
On Sun, Sep 25, 2016 at 11:49 AM Romain Manni-Bucau wrote: > 2016-09-25 17:40 GMT+02:00 John D. Ament : > > > On Sun, Sep 25, 2016 at 11:37 AM Romain Manni-Bucau < > rmannibu...@gmail.com > > > > > wrote: > > > > > 2016-09-25 17:33 GMT+02:00 Thomas Andraschko < > > andraschko.tho...@gmail.com > >

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread John D. Ament
On Sun, Sep 25, 2016 at 11:44 AM Romain Manni-Bucau wrote: > 2016-09-25 17:42 GMT+02:00 John D. Ament : > > > On Sun, Sep 25, 2016 at 11:40 AM Romain Manni-Bucau < > rmannibu...@gmail.com > > > > > wrote: > > > > > 2016-09-25 17:37 GMT+02:00 John D. Ament : > > > > > > > On Sun, Sep 25, 2016 at 1

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread Romain Manni-Bucau
2016-09-25 17:40 GMT+02:00 John D. Ament : > On Sun, Sep 25, 2016 at 11:37 AM Romain Manni-Bucau > > wrote: > > > 2016-09-25 17:33 GMT+02:00 Thomas Andraschko < > andraschko.tho...@gmail.com > > >: > > > > > not sure if a cdi2-module is enough > > > we should also get rid of some of our api's whi

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread Romain Manni-Bucau
2016-09-25 17:42 GMT+02:00 John D. Ament : > On Sun, Sep 25, 2016 at 11:40 AM Romain Manni-Bucau > > wrote: > > > 2016-09-25 17:37 GMT+02:00 John D. Ament : > > > > > On Sun, Sep 25, 2016 at 11:34 AM Thomas Andraschko < > > > andraschko.tho...@gmail.com> wrote: > > > > > > > not sure if a cdi2-mo

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread John D. Ament
On Sun, Sep 25, 2016 at 11:40 AM Romain Manni-Bucau wrote: > 2016-09-25 17:37 GMT+02:00 John D. Ament : > > > On Sun, Sep 25, 2016 at 11:34 AM Thomas Andraschko < > > andraschko.tho...@gmail.com> wrote: > > > > > not sure if a cdi2-module is enough > > > we should also get rid of some of our api'

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread Romain Manni-Bucau
2016-09-25 17:37 GMT+02:00 John D. Ament : > On Sun, Sep 25, 2016 at 11:34 AM Thomas Andraschko < > andraschko.tho...@gmail.com> wrote: > > > not sure if a cdi2-module is enough > > we should also get rid of some of our api's which are in CDI 2.0 now > > > > Yes. I agree. Basically, one sticking

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread John D. Ament
On Sun, Sep 25, 2016 at 11:37 AM Romain Manni-Bucau wrote: > 2016-09-25 17:33 GMT+02:00 Thomas Andraschko >: > > > not sure if a cdi2-module is enough > > we should also get rid of some of our api's which are in CDI 2.0 now > > > > we can switch them of on CDI 2 while we still maintain it on CDI

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread Romain Manni-Bucau
2016-09-25 17:33 GMT+02:00 Thomas Andraschko : > not sure if a cdi2-module is enough > we should also get rid of some of our api's which are in CDI 2.0 now > we can switch them of on CDI 2 while we still maintain it on CDI 1.0, that said not sure we should switch them off, all are not really stan

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread John D. Ament
On Sun, Sep 25, 2016 at 11:34 AM Thomas Andraschko < andraschko.tho...@gmail.com> wrote: > not sure if a cdi2-module is enough > we should also get rid of some of our api's which are in CDI 2.0 now > Yes. I agree. Basically, one sticking target I see continually is BeanManagerProvider. Maybe w

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread Thomas Andraschko
not sure if a cdi2-module is enough we should also get rid of some of our api's which are in CDI 2.0 now 2016-09-25 17:28 GMT+02:00 Romain Manni-Bucau : > 2016-09-25 17:22 GMT+02:00 John D. Ament : > > > Hey guys, > > > > Since its inception, DeltaSpike has targeted Java EE 6 and lower, and as >

Re: [DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread Romain Manni-Bucau
2016-09-25 17:22 GMT+02:00 John D. Ament : > Hey guys, > > Since its inception, DeltaSpike has targeted Java EE 6 and lower, and as a > result the CDI 1.0 runtime. We have maintained a pretty backwards > compatible code base for 5 years now. > > CDI 2.0 is going to wrap up in January, if current

[DISCUSS] Start a branch for DS 2.0?

2016-09-25 Thread John D. Ament
Hey guys, Since its inception, DeltaSpike has targeted Java EE 6 and lower, and as a result the CDI 1.0 runtime. We have maintained a pretty backwards compatible code base for 5 years now. CDI 2.0 is going to wrap up in January, if current schedules align correctly. I'd like to propose that we

[jira] [Updated] (DELTASPIKE-1206) support for CDI 2.0 feature

2016-09-25 Thread John D. Ament (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John D. Ament updated DELTASPIKE-1206: -- Issue Type: Test (was: Bug) > support for CDI 2.0 feature > -

[jira] [Commented] (DELTASPIKE-1206) support for CDI 2.0 feature

2016-09-25 Thread Thomas Andraschko (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15520968#comment-15520968 ] Thomas Andraschko commented on DELTASPIKE-1206: --- yup, CDI 2.0 -> DS 2.0

[jira] [Commented] (DELTASPIKE-1206) support for CDI 2.0 feature

2016-09-25 Thread Romain Manni-Bucau (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15520966#comment-15520966 ] Romain Manni-Bucau commented on DELTASPIKE-1206: Will be broken to se

[jira] [Comment Edited] (DELTASPIKE-1206) support for CDI 2.0 feature

2016-09-25 Thread John D. Ament (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15520961#comment-15520961 ] John D. Ament edited comment on DELTASPIKE-1206 at 9/25/16 3:12 PM: ---

[jira] [Commented] (DELTASPIKE-1206) support for CDI 2.0 feature

2016-09-25 Thread John D. Ament (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15520961#comment-15520961 ] John D. Ament commented on DELTASPIKE-1206: --- Good idea Mark. However, what

[jira] [Created] (DELTASPIKE-1206) support for CDI 2.0 feature

2016-09-25 Thread Mark Struberg (JIRA)
Mark Struberg created DELTASPIKE-1206: - Summary: support for CDI 2.0 feature Key: DELTASPIKE-1206 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1206 Project: DeltaSpike Issue Typ