Re: [Txn branch] Question about the WAL

2012-03-14 Thread Selcuk AYA
Lets continue the discussion here. I got this email at my 6AM. I was planning to take a look at the code and refresh my memory before replying and I can do that while I am at home only. That is why it took some time to reply. Next time please allow me sometime to reply to your emails. First thing

Re: svn commit: r1300690 - in /directory/apacheds/branches/apacheds-txns: core-api/src/main/java/org/apache/directory/server/core/api/log/ core-api/src/main/java/org/apache/directory/server/core/api/t

2012-03-14 Thread Emmanuel Lécharny
Some more clarifications about the changes : when we write a LogEdit, we have two cases : 1) we write a ChangeDataContainer 2) we write a Transaction state In the first case, we serialize the data in the log( LogEdit, sync) method using the current transaction logRecord, then we call the log(

Re: svn commit: r1300690 - in /directory/apacheds/branches/apacheds-txns: core-api/src/main/java/org/apache/directory/server/core/api/log/ core-api/src/main/java/org/apache/directory/server/core/api/t

2012-03-14 Thread Emmanuel Lécharny
Le 3/14/12 11:56 PM, Selcuk AYA a écrit : On Wed, Mar 14, 2012 at 3:51 PM, Emmanuel Lécharny wrote: Le 3/14/12 11:32 PM, Selcuk AYA a écrit : On Wed, Mar 14, 2012 at 3:23 PM, Emmanuel Lécharny wrote: Le 3/14/12 10:52 PM, Selcuk AYA a écrit : HI All, Sorry for the earlier email. I think I

Re: svn commit: r1300690 - in /directory/apacheds/branches/apacheds-txns: core-api/src/main/java/org/apache/directory/server/core/api/log/ core-api/src/main/java/org/apache/directory/server/core/api/t

2012-03-14 Thread Selcuk AYA
On Wed, Mar 14, 2012 at 3:51 PM, Emmanuel Lécharny wrote: > Le 3/14/12 11:32 PM, Selcuk AYA a écrit : > >> On Wed, Mar 14, 2012 at 3:23 PM, Emmanuel Lécharny >>  wrote: >>> >>> Le 3/14/12 10:52 PM, Selcuk AYA a écrit : >>> HI All, Sorry for the earlier email. I think I owe some explainat

Re: svn commit: r1300690 - in /directory/apacheds/branches/apacheds-txns: core-api/src/main/java/org/apache/directory/server/core/api/log/ core-api/src/main/java/org/apache/directory/server/core/api/t

2012-03-14 Thread Emmanuel Lécharny
Le 3/14/12 11:32 PM, Selcuk AYA a écrit : On Wed, Mar 14, 2012 at 3:23 PM, Emmanuel Lécharny wrote: Le 3/14/12 10:52 PM, Selcuk AYA a écrit : HI All, Sorry for the earlier email. I think I owe some explaination on my part. The reason for my request is purely technical, does not aim at oss spi

Re: svn commit: r1300690 - in /directory/apacheds/branches/apacheds-txns: core-api/src/main/java/org/apache/directory/server/core/api/log/ core-api/src/main/java/org/apache/directory/server/core/api/t

2012-03-14 Thread Selcuk AYA
On Wed, Mar 14, 2012 at 3:23 PM, Emmanuel Lécharny wrote: > Le 3/14/12 10:52 PM, Selcuk AYA a écrit : > >> HI All, >> Sorry for the earlier email. I think I owe some explaination on my >> part. The reason for my request is purely technical, does not aim at >> oss spirit or any other spirit for tha

Re: svn commit: r1300690 - in /directory/apacheds/branches/apacheds-txns: core-api/src/main/java/org/apache/directory/server/core/api/log/ core-api/src/main/java/org/apache/directory/server/core/api/t

2012-03-14 Thread Emmanuel Lécharny
Le 3/14/12 10:52 PM, Selcuk AYA a écrit : HI All, Sorry for the earlier email. I think I owe some explaination on my part. The reason for my request is purely technical, does not aim at oss spirit or any other spirit for that matter: * There are quite a number of files the txn branch is touching.

Re: svn commit: r1300690 - in /directory/apacheds/branches/apacheds-txns: core-api/src/main/java/org/apache/directory/server/core/api/log/ core-api/src/main/java/org/apache/directory/server/core/api/t

2012-03-14 Thread Emmanuel Lécharny
Le 3/14/12 10:48 PM, Alex Karasulu a écrit : On Wed, Mar 14, 2012 at 10:41 PM, Kiran Ayyagariwrote: Selcuk, I have seen you asking several times on this list for reverting commits, this seems to be a bit derogatory in OSS spirit and team work. It can certainly be misinterpreted this

Re: svn commit: r1300690 - in /directory/apacheds/branches/apacheds-txns: core-api/src/main/java/org/apache/directory/server/core/api/log/ core-api/src/main/java/org/apache/directory/server/core/api/t

2012-03-14 Thread Selcuk AYA
HI All, Sorry for the earlier email. I think I owe some explaination on my part. The reason for my request is purely technical, does not aim at oss spirit or any other spirit for that matter: * There are quite a number of files the txn branch is touching. * There is no file ownership or review proc

Re: svn commit: r1300690 - in /directory/apacheds/branches/apacheds-txns: core-api/src/main/java/org/apache/directory/server/core/api/log/ core-api/src/main/java/org/apache/directory/server/core/api/t

2012-03-14 Thread Alex Karasulu
On Wed, Mar 14, 2012 at 10:41 PM, Kiran Ayyagari wrote: > Selcuk, > >I have seen you asking several times on this list for reverting commits, >this seems to be a bit derogatory in OSS spirit and team work. > It can certainly be misinterpreted this way. I think we just need more communicat

Re: svn commit: r1300690 - in /directory/apacheds/branches/apacheds-txns: core-api/src/main/java/org/apache/directory/server/core/api/log/ core-api/src/main/java/org/apache/directory/server/core/api/t

2012-03-14 Thread Kiran Ayyagari
Selcuk, I have seen you asking several times on this list for reverting commits, this seems to be a bit derogatory in OSS spirit and team work. Go ahead and make your changes on top of these if you wish to apply your fix, commits need not be reverted for this. On Thu, Mar 15, 2012

Re: svn commit: r1300690 - in /directory/apacheds/branches/apacheds-txns: core-api/src/main/java/org/apache/directory/server/core/api/log/ core-api/src/main/java/org/apache/directory/server/core/api/t

2012-03-14 Thread Selcuk AYA
please revert this commit. On Wed, Mar 14, 2012 at 12:06 PM, wrote: > Author: elecharny > Date: Wed Mar 14 19:06:17 2012 > New Revision: 1300690 > > URL: http://svn.apache.org/viewvc?rev=1300690&view=rev > Log: > o Added a type for LogEdit stored into UserLogRecord, in order to be able to > rea

Re: [Txn branch] Question about the WAL

2012-03-14 Thread Selcuk AYA
We already have code to read log records and we do not need a type in log edits. We do not call this yet as we do not do crash recovery yet. I saw you already committed some changes for this without waiting for a reply. Please revert your latest commit. thanks Selcuk On Wed, Mar 14, 2012 at 6:10

[Txn branch] Question about the WAL

2012-03-14 Thread Emmanuel Lécharny
Hi, as i'm reviewing the way we manage the WAL (Write Ahead Log), I have a few questions : 1) UserLogRecord It's a data structure encapsulating an opaque byte[] containing a serialized form of a record. We have two length, the serialized data length, and the buffer length (which might be wi