Re: [Studio] Cleanup...

2015-07-29 Thread Emmanuel Lécharny
Le 28/07/15 19:54, Emmanuel Lécharny a écrit : Beside checkstyle we should also add PMD check, you already started to cleanup some issues. PMD is a bit a PITA. There are many so called violations that are just plain BS, and many others that are going to push us to rewrite the whole code...

[Studio] Cleanup...

2015-07-28 Thread Emmanuel Lécharny
Hi guys, yesterday, I went through the code looking for places where 'instanceof' was used. I found two typical improvements that could be applied : o useless check on x != null like in : if ( ( x != null ) ( x instanceof X ) ) o useless check of x == null like in : if ( ( x == null ) || !( x

Re: [Studio] Cleanup...

2015-07-28 Thread Stefan Seelmann
On 07/28/2015 10:28 AM, Emmanuel Lécharny wrote: Hi guys, yesterday, I went through the code looking for places where 'instanceof' was used. I found two typical improvements that could be applied : o useless check on x != null like in : if ( ( x != null ) ( x instanceof X ) ) o useless

Re: [Studio] Cleanup...

2015-07-28 Thread Emmanuel Lécharny
Le 28/07/15 18:35, Stefan Seelmann a écrit : On 07/28/2015 10:28 AM, Emmanuel Lécharny wrote: At this point, I think that adding checkstyle in Studio would most certainly be a nit of a pain (I suspect that we will get thousands of failures ;-) but this might be good to have. Stefan did a