Re: [PR] Move attribute and etag logic into Repository [directory-scimple]

2023-11-29 Thread via GitHub
bdemers commented on code in PR #411: URL: https://github.com/apache/directory-scimple/pull/411#discussion_r1409472656 ## scim-core/src/test/java/org/apache/directory/scim/core/repository/PatchGeneratorTest.java: ## Review Comment: Created #427 -- This is an automated

Re: [PR] [SCIMPLE-93] Set type=reference, when referenceTypes are set [directory-scimple]

2023-11-29 Thread via GitHub
tm-drtina commented on PR #425: URL: https://github.com/apache/directory-scimple/pull/425#issuecomment-1832147195 I saw there were some tests for schema:

[I] Add ScimGroup tests for PatchGenerator, (previously)UpdateRequest [directory-scimple]

2023-11-29 Thread via GitHub
bdemers opened a new issue, #427: URL: https://github.com/apache/directory-scimple/issues/427 There are a couple gaps in the test coverage for `PatchGenerator`, specifically in the area of generating diffs for collections. Add tests common for ScimGroup patch operations:

Re: [PR] Move attribute and etag logic into Repository [directory-scimple]

2023-11-29 Thread via GitHub
bdemers commented on PR #411: URL: https://github.com/apache/directory-scimple/pull/411#issuecomment-1832194061 @joshuapsteele All the reviews here are great! I just cleaned up the git history a little, I'll merge it once CI passes! -- This is an automated message from the Apache Git

Re: [PR] [SCIMPLE-93] Set type=reference, when referenceTypes are set [directory-scimple]

2023-11-29 Thread via GitHub
bdemers commented on PR #425: URL: https://github.com/apache/directory-scimple/pull/425#issuecomment-1832116765 This is great! Thanks @tm-drtina! Any ideas for a test or two? If you don't have time to implement them, that's understandable, but a little pseudo code, will help too!

[PR] Bump actions/setup-java from 3 to 4 [directory-scimple]

2023-11-29 Thread via GitHub
dependabot[bot] opened a new pull request, #428: URL: https://github.com/apache/directory-scimple/pull/428 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3 to 4. Release notes Sourced from https://github.com/actions/setup-java/releases;>actions/setup-java's

[jira] [Resolved] (FC-328) Role Constraint validations broken

2023-11-29 Thread Shawn McKinney (Jira)
[ https://issues.apache.org/jira/browse/FC-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn McKinney resolved FC-328. --- Resolution: Fixed added check to AdminMgr.addRoleConstraint > Role Constraint validations broken >

[jira] [Updated] (DIRKRB-767) data race when multi KrbClients visit KdcServer

2023-11-29 Thread Colm O hEigeartaigh (Jira)
[ https://issues.apache.org/jira/browse/DIRKRB-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated DIRKRB-767: --- Fix Version/s: 2.1.0 > data race when multi KrbClients visit KdcServer >

Re: [PR] DIRKRB-767 - Some minor thread safety changes to PkinitPreauth [directory-kerby]

2023-11-29 Thread via GitHub
coheigea merged PR #288: URL: https://github.com/apache/directory-kerby/pull/288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (DIRKRB-767) data race when multi KrbClients visit KdcServer

2023-11-29 Thread Colm O hEigeartaigh (Jira)
[ https://issues.apache.org/jira/browse/DIRKRB-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh resolved DIRKRB-767. Resolution: Fixed > data race when multi KrbClients visit KdcServer >

[jira] [Assigned] (DIRKRB-767) data race when multi KrbClients visit KdcServer

2023-11-29 Thread Colm O hEigeartaigh (Jira)
[ https://issues.apache.org/jira/browse/DIRKRB-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh reassigned DIRKRB-767: -- Assignee: Colm O hEigeartaigh > data race when multi KrbClients visit

[jira] [Commented] (DIRKRB-767) data race when multi KrbClients visit KdcServer

2023-11-29 Thread Colm O hEigeartaigh (Jira)
[ https://issues.apache.org/jira/browse/DIRKRB-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791009#comment-17791009 ] Colm O hEigeartaigh commented on DIRKRB-767: Hi, I've found some time to take a look. I

[jira] [Updated] (DIRKRB-767) data race when multi KrbClients visit KdcServer

2023-11-29 Thread Colm O hEigeartaigh (Jira)
[ https://issues.apache.org/jira/browse/DIRKRB-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated DIRKRB-767: --- Priority: Minor (was: Critical) > data race when multi KrbClients visit KdcServer >

[PR] DIRKRB-767 - Some minor thread safety changes to PkinitPreauth [directory-kerby]

2023-11-29 Thread via GitHub
coheigea opened a new pull request, #288: URL: https://github.com/apache/directory-kerby/pull/288 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To