Re: [Proposal] Alert Plugin Design

2020-08-14 Thread JUN GAO
Thank you for your participation in the discussio. I think alert server is not only a alert server but also a message notification service. All message should send by it. The job of Worker node is run the task , so add the email config to work is not a good idea. For example , if we add a new job

Re: [Proposal] Alert Plugin Design

2020-07-23 Thread Hemin Wen
I suggest, The sql node internally realizes the function of sending mail, instead of calling the mail alert plug-in. Plugin is optional, some users may not need the email alert plugin. E.g we. So, It is recommended to extract util methods( MailUtils ), and, mail config move to worker.properties.

Re: [Proposal] Alert Plugin Design

2020-07-20 Thread JUN GAO
Hi all . In this feature, we will put the function of sending email into the alert email plugin. But I found that SqlTask directly calls the code for sending emails. As a result, after the email function was moved to the dolphinscheduler-alert-email module, SqlTask could no longer call the email c

Re: [Proposal] Alert Plugin Design

2020-07-14 Thread JUN GAO
ue about this subtask. >>  Thx a lot. >> >> >> Best, >> Yichao Yang >> >> >> -- Original -- >> From: JUN GAO > Date: Wed,Jul 15,2020 0:58 PM >> To: dev > > >> Subject: Re: [Proposal] Alert Plugin

Re: [Proposal] Alert Plugin Design

2020-07-14 Thread JUN GAO
t; From: JUN GAO Date: Wed,Jul 15,2020 0:58 PM > To: dev Subject: Re: [Proposal] Alert Plugin Design > > > > Hi all. > > I created a branch > > https://github.com/apache/incubator-dolphinscheduler/tree/alert_plugin_design > for > this feature. > > The issu

Re: [Proposal] Alert Plugin Design

2020-07-14 Thread Yichao Yang
Hi, I am interested in 2, I will create an issue about this subtask.  Thx a lot. Best, Yichao Yang -- Original -- From: JUN GAO https://github.com/apache/incubator-dolphinscheduler/tree/alert_plugin_design for this feature. The issue about this feature is https:

Re: [Proposal] Alert Plugin Design

2020-07-14 Thread JUN GAO
t >>>>> details Wait, form-create link address: http://form-create.com/ >>>>> >>>>> >>>>> >>>>> >>>>> DolphinScheduler(Incubator) committer >>>>> Caibiao Xiang 向偲彪 >>>>> 790061...@

Re: [Proposal] Alert Plugin Design

2020-07-09 Thread JUN GAO
details Wait, form-create link address: http://form-create.com/ >>>> >>>> >>>> >>>> >>>> DolphinScheduler(Incubator) committer >>>> Caibiao Xiang 向偲彪 >>>> 790061...@qq.com >>>> >>>> >>>>

Re: [Proposal] Alert Plugin Design

2020-07-09 Thread JUN GAO
nally feels is better compatible with the page style, and the document >>> details Wait, form-create link address: http://form-create.com/ >>> >>> >>> >>> >>> DolphinScheduler(Incubator) committer >>> Caibiao Xiang 向偲彪 >>> 79006

Re: [Proposal] Alert Plugin Design

2020-06-29 Thread JUN GAO
>> >> >> DolphinScheduler(Incubator) committer >> Caibiao Xiang 向偲彪 >> 790061...@qq.com >> >> >> -- 原始邮件 ------ >> 发件人: "JUN GAO"> 发送时间: 2020年6月24日(星期三) 下午4:33 >> 收件人: "dev"> >>

Re: [Proposal] Alert Plugin Design

2020-06-28 Thread JUN GAO
biao Xiang 向偲彪 > 790061...@qq.com > > > -- 原始邮件 -- > 发件人: "JUN GAO" 发送时间: 2020年6月24日(星期三) 下午4:33 > 收件人: "dev" > 主题: [Proposal] Alert Plugin Design > > > > Hi All, This is a part of the [Proposal] DolphinScheduler Plugin Des

Re: [Proposal] Alert Plugin Design

2020-06-28 Thread JUN GAO
ot;JUN GAO" 发送时间: 2020年6月24日(星期三) 下午4:33 > 收件人: "dev" > 主题: [Proposal] Alert Plugin Design > > > > Hi All, This is a part of the [Proposal] DolphinScheduler Plugin Design > https://github.com/apache/incubator-dolphinscheduler/issues/2869 > > Welcome all partn

??????[Proposal] Alert Plugin Design

2020-06-27 Thread xingchun.chen
It's very good?? --  -- ??: "JUN GAO"https://github.com/apache/incubator-dolphinscheduler/issues/2869 Welcome all partners who are interested in this issue to participate in the discussion and development contribution Summary designPlugin definiti

??????[Proposal] Alert Plugin Design

2020-06-27 Thread ??????
Regarding plug-inization, the front-end can use form-create, which supports json format data, but the UI only supports iview and element-ui, and the existing ans-ui needs to be replaced. The form-create that personally feels is better compatible with the page style, and the document details Wait

Re: 回复:[Proposal] Alert Plugin Design

2020-06-26 Thread wu shaoj
Good suggestion On 2020/6/27, 12:21, "Yichao Yang" <1048262...@qq.com> wrote: Hi by using Apache Freemarker. I've read the code of your plugin part, and is it possible to combine the default template and the configurable template by using Apache Freemarker? The advantage of this i

??????[Proposal] Alert Plugin Design

2020-06-26 Thread Yichao Yang
Hi by using Apache Freemarker. I've read the code of your plugin part, and is it possible to combine the default template and the configurable template by using Apache Freemarker? The advantage of this is user can choose the default template, and also can write their customized template for the

Re: [Proposal] Alert Plugin Design

2020-06-26 Thread wu shaoj
@JUN GAO ,I think changqun.xu is right, using different alert type according to task priority is a good pratice On 2020/6/24, 17:58, "changqun.xu" wrote: Hi JUN GAO It’s a very good design, and I’d like want a feature to use different alert type according to different task priori

Re: [Proposal] Alert Plugin Design

2020-06-24 Thread JUN GAO
Hi, @许昌群 I agree with you, But now DS only support alert for workflow instance can not support alert for task. So we can only config different alert group for workflow instance. changqun.xu 于2020年6月24日周三 下午5:58写道: > > Hi JUN GAO > > It’s a very good design, and I’d like want a feature to use d

Re: [Proposal] Alert Plugin Design

2020-06-24 Thread changqun.xu
Hi JUN GAO It’s a very good design, and I’d like want a feature to use different alert type according to different task priority, for example ‘Middle task’ use email to send alarms, ‘High task’ use dingding … Glad to have more communication, thanks. > 在 2020年6月24日,16:33,JUN GAO 写道: > > Hi

[Proposal] Alert Plugin Design

2020-06-24 Thread JUN GAO
Hi All, This is a part of the [Proposal] DolphinScheduler Plugin Design https://github.com/apache/incubator-dolphinscheduler/issues/2869 Welcome all partners who are interested in this issue to participate in the discussion and development contribution Summary designPlugin definition & plugin in