[dpdk-dev] [PATCHv2 5/5] acl: add doxygen configuration and start page

2014-05-28 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- doc/doxy-api-index.md |3 ++- doc/doxy-api.conf |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/doxy-api-index.md b/doc/doxy-api-index.md index 2825c08..5e4cea9 100644 --- a/doc/doxy-api-index.md +++

[dpdk-dev] [PATCHv2 4/5] acl: New sample l3fwd-acl.

2014-05-28 Thread Konstantin Ananyev
Demonstrates the use of the ACL library in the DPDK application to implement packet classification and L3 forwarding. Signed-off-by: Konstantin Ananyev --- examples/Makefile |1 + examples/l3fwd-acl/Makefile | 56 ++ examples/l3fwd-acl/main.c | 2048

[dpdk-dev] [PATCHv2 3/5] acl: New test-acl application.

2014-05-28 Thread Konstantin Ananyev
Introduce test-acl: Usage example and main test application for the ACL library. Provides IPv4/IPv6 5-tuple classification. Signed-off-by: Konstantin Ananyev --- app/Makefile |1 + app/test-acl/Makefile | 45 +++ app/test-acl/main.c | 1029

[dpdk-dev] [PATCHv2 2/5] acl: update UT to reflect latest changes in the librte_acl.

2014-05-28 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- app/test/test_acl.c | 128 ++- 1 files changed, 85 insertions(+), 43 deletions(-) diff --git a/app/test/test_acl.c b/app/test/test_acl.c index 790cdf3..c171eac 100644 --- a/app/test/test_acl.c +++

[dpdk-dev] [PATCHv2 1/5] acl: Add ACL library (librte_acl) into DPDK.

2014-05-28 Thread Konstantin Ananyev
The ACL library is used to perform an N-tuple search over a set of rules with multiple categories and find the best match for each category. Signed-off-by: Konstantin Ananyev --- config/common_linuxapp |6 + lib/librte_acl/Makefile | 60 + lib/librte_acl/acl.h

[dpdk-dev] [PATCHv2 0/5] ACL library

2014-05-28 Thread Konstantin Ananyev
The ACL library is used to perform an N-tuple search over a set of rules with multiple categories and find the best match (highest priority) for each category. This code was previously released under a proprietary license, but is now being released under a BSD license to allow its integration

[dpdk-dev] [PATCH 13/13] examples: overhaul of ip_reassembly app

2014-05-28 Thread Anatoly Burakov
New stuff: * Support for regular traffic as well as IPv4 and IPv6 * Simplified config * Routing table printed out on start * Uses LPM/LPM6 for lookup * Unmatched traffic is sent to the originating port Signed-off-by: Anatoly Burakov --- examples/ip_reassembly/Makefile |1 -

[dpdk-dev] [PATCH 12/13] ip_frag: add support for IPv6 reassembly

2014-05-28 Thread Anatoly Burakov
Mostly a copy-paste of IPv4, with a few caveats. Only supported packets are those in which fragment extension header is just after the IPv6 header. Signed-off-by: Anatoly Burakov --- lib/librte_ip_frag/Makefile | 1 + lib/librte_ip_frag/ip_frag_common.h | 25 +++-

[dpdk-dev] [PATCH 11/13] example: overhaul of ip_fragmentation example app

2014-05-28 Thread Anatoly Burakov
New stuff: * Support for regular traffic as well as IPv4 and IPv6 * Simplified config * Routing table printed out on start * Uses LPM/LPM6 for lookup * Unmatched traffic is sent to the originating port Signed-off-by: Anatoly Burakov --- examples/ip_fragmentation/main.c | 547

[dpdk-dev] [PATCH 10/13] examples: renamed ipv4_frag example app to ip_fragmentation

2014-05-28 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- examples/{ipv4_frag => ip_fragmentation}/Makefile | 2 +- examples/{ipv4_frag => ip_fragmentation}/main.c | 0 examples/{ipv4_frag => ip_fragmentation}/main.h | 0 3 files changed, 1 insertion(+), 1 deletion(-) rename examples/{ipv4_frag =>

[dpdk-dev] [PATCH 09/13] ip_frag: added IPv6 fragmentation support

2014-05-28 Thread Anatoly Burakov
Mostly a copy-paste of IPv4. Signed-off-by: Anatoly Burakov --- lib/librte_ip_frag/Makefile | 1 + lib/librte_ip_frag/rte_ip_frag.h| 27 lib/librte_ip_frag/rte_ipv6_fragmentation.c | 219 3 files changed, 247 insertions(+) create

[dpdk-dev] [PATCH 08/13] ip_frag: renamed ipv4 frag function

2014-05-28 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- examples/ipv4_frag/main.c | 2 +- lib/librte_ip_frag/rte_ip_frag.h| 2 +- lib/librte_ip_frag/rte_ipv4_fragmentation.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/ipv4_frag/main.c

[dpdk-dev] [PATCH 07/13] ip_frag: refactored reassembly code and made it a proper library

2014-05-28 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- config/common_bsdapp | 2 + config/common_linuxapp | 2 + examples/ip_reassembly/main.c| 24 +- lib/librte_ip_frag/Makefile | 6 +- lib/librte_ip_frag/ip_frag_common.h | 134 +-

[dpdk-dev] [PATCH 06/13] ip_frag: renaming structures in fragmentation table to be more generic

2014-05-28 Thread Anatoly Burakov
Technically, fragmentation table can work for both IPv4 and IPv6 packets, so we're renaming everything to be generic enough to make sense in IPv6 context. Signed-off-by: Anatoly Burakov --- examples/ip_reassembly/main.c | 16 ++--- lib/librte_ip_frag/ip_frag_common.h | 2 +

[dpdk-dev] [PATCH 05/13] ip_frag: removed unneeded check and macro

2014-05-28 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- lib/librte_ip_frag/rte_ipv4_fragmentation.c | 9 - 1 file changed, 9 deletions(-) diff --git a/lib/librte_ip_frag/rte_ipv4_fragmentation.c b/lib/librte_ip_frag/rte_ipv4_fragmentation.c index 46ed583..6e5feb6 100644 ---

[dpdk-dev] [PATCH 04/13] ip_frag: new internal common header

2014-05-28 Thread Anatoly Burakov
Moved out debug log macros into common, as reassembly code will later need them as well. Signed-off-by: Anatoly Burakov --- lib/librte_ip_frag/ip_frag_common.h | 52 + lib/librte_ip_frag/rte_ipv4_fragmentation.c | 20 ++- 2 files changed, 55

[dpdk-dev] [PATCH 03/13] Fixing issues reported by checkpatch

2014-05-28 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- lib/librte_ip_frag/rte_ipv4_fragmentation.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/lib/librte_ip_frag/rte_ipv4_fragmentation.c b/lib/librte_ip_frag/rte_ipv4_fragmentation.c index 2d33a7b..5f67417 100644

[dpdk-dev] [PATCH 02/13] Refactored IPv4 fragmentation into a proper library

2014-05-28 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- examples/ipv4_frag/main.c | 11 ++ lib/librte_ip_frag/Makefile | 9 ++ lib/librte_ip_frag/rte_ip_frag.h| 186 +- lib/librte_ip_frag/rte_ipv4_fragmentation.c | 239

[dpdk-dev] [PATCH 01/13] ip_frag: Moving fragmentation/reassembly headers into a separate library

2014-05-28 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- config/common_bsdapp | 5 +++ config/common_linuxapp | 5 +++ examples/ip_reassembly/main.c | 2 +- examples/ipv4_frag/main.c | 2 +- lib/Makefile

[dpdk-dev] [PATCH 00/13] *** SUBJECT HERE ***

2014-05-28 Thread Anatoly Burakov
*** BLURB HERE *** Anatoly Burakov (13): ip_frag: Moving fragmentation/reassembly headers into a separate library Refactored IPv4 fragmentation into a proper library Fixing issues reported by checkpatch ip_frag: new internal common header ip_frag: removed unneeded check and macro

[dpdk-dev] [PATCH 00/13] *** SUBJECT HERE ***

2014-05-28 Thread Burakov, Anatoly
Sorry, for some reason two cover letters were sent > Subject: [PATCH 00/13] *** SUBJECT HERE *** > > *** BLURB HERE *** Best regards, Anatoly Burakov DPDK SW Engineer

[dpdk-dev] [PATCH 1/4] Link Bonding Library

2014-05-28 Thread Shaw, Jeffrey B
Hi Declan, I'm worried about one thing in "bond_ethdev_tx_broadcast()" related to freeing of the broadcasted packets. > +static uint16_t > +bond_ethdev_tx_broadcast(void *queue, struct rte_mbuf **bufs, uint16_t > nb_pkts) > +{ > + struct bond_dev_private *internals; > + struct

[dpdk-dev] [PATCH 4/4] Add Link Bonding Library to Doxygen

2014-05-28 Thread declan.dohe...@intel.com
From: Declan Doherty Signed-off-by: Declan Doherty --- doc/doxy-api-index.md | 1 + doc/doxy-api.conf | 1 + 2 files changed, 2 insertions(+) diff --git a/doc/doxy-api-index.md b/doc/doxy-api-index.md index 2825c08..2206c68 100644 --- a/doc/doxy-api-index.md +++

[dpdk-dev] [PATCH 3/4] Link bonding integration into testpmd

2014-05-28 Thread declan.dohe...@intel.com
From: Declan Doherty Adding link bonding support to testpmd. - Includes the ability to create new bonded devices. - Add /remove bonding slave devices. - Interogate bonded device stats/configuration - Change bonding modes and select balance transmit

[dpdk-dev] [PATCH 2/4] Link bonding unit tests

2014-05-28 Thread declan.dohe...@intel.com
From: Declan Doherty Link bonding unit tests, including code to generate packet bursts for testing rx and tx functionality of bonded device and a virtual/stubbed out ethdev for use as slave ethdev in testing Signed-off-by: Declan Doherty --- app/test/Makefile

[dpdk-dev] [PATCH 1/4] Link Bonding Library

2014-05-28 Thread declan.dohe...@intel.com
From: Declan Doherty Link Bonding Library (lib/librte_bond) initial release with support for Mode 0 - Round Robin Mode 1 - Active Backup Mode 2 - Balance -> Supports 3 transmit polices (layer 2, layer 2+3, layer Mode 3 - Broadcast Signed-off-by:

[dpdk-dev] [PATCH 0/4] Link Bonding Library

2014-05-28 Thread declan.dohe...@intel.com
From: Declan Doherty Initial release of Link Bonding Library (lib/librte_bond) with support for bonding modes : 0 - Round Robin 1 - Active Backup 2 - Balance l2 / l23 / l34 3 - Broadcast patches split: 1 - library + makefile changes 2 - Unit test suite,

[dpdk-dev] Intel I350 fails to work with DPDK

2014-05-28 Thread sabu kurian
Hai bruce, Thanks for the reply. I even tried that before. Having a burst size of 64 or 128 simply fails. The card would send out a few packets (some 400 packets of 74 byte size) and then freeze. For my application... I'm trying to generate the peak traffic possible with the link speed and the

[dpdk-dev] [PATCH v3 0/3] Support zero copy RX/TX in user space vhost

2014-05-28 Thread Thomas Monjalon
2014-05-28 16:06, Ouyang Changchun: > This patch v3 fixes some errors and warnings reported by checkpatch.pl, > please ignore previous 2 patches: patch v1 and patch v2, only apply this v3 > patch for zero copy RX/TX in user space vhost. > > This patch series support user space vhost zero copy. It

[dpdk-dev] [PATCH v3 3/3] examples/vhost: Support user space vhost zero copy

2014-05-28 Thread Ouyang Changchun
Please ignore previous patch v1 and v2, only need this patch v3 for us vhost zero copy. This patch supports user space vhost zero copy. It removes packets copying between host and guest in RX/TX. It introduces an extra ring to store the detached mbufs. At initialization stage all mbufs will

[dpdk-dev] [PATCH v3 2/3] ixgbe: Implement queue start and stop functionality in IXGBE PMD

2014-05-28 Thread Ouyang Changchun
Please ignore previous patch v1 and v2, only need this patch v3 for the queue start and stop functionality. This patch implements queue start and stop functionality in IXGBE PMD; it also enable hardware loopback for VMDQ mode in IXGBE PMD. Signed-off-by: Ouyang Changchun Tested-by: Waterman

[dpdk-dev] [PATCH v3 0/3] Support zero copy RX/TX in user space vhost

2014-05-28 Thread Ouyang Changchun
This patch v3 fixes some errors and warnings reported by checkpatch.pl, please ignore previous 2 patches: patch v1 and patch v2, only apply this v3 patch for zero copy RX/TX in user space vhost. This patch series support user space vhost zero copy. It removes packets copying between host and

[dpdk-dev] [PATCH] fix for eth_pcap_tx() can cause mbuf corruption

2014-05-28 Thread Konstantin Ananyev
If pcap_sendpacket() fails, then eth_pcap_tx shouldn't silently free that mbuf and continue. Signed-off-by: Konstantin Ananyev --- lib/librte_pmd_pcap/rte_eth_pcap.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c

[dpdk-dev] [PATCH v2 13/16] Removed PCI ID table from igb_uio

2014-05-28 Thread Thomas Monjalon
2014-05-23 00:10, Antti Kantee: > On 22/05/14 13:13, Thomas Monjalon wrote: > > 2014-05-19 16:51, Anatoly Burakov: > >> Note that since igb_uio no longer has a PCI ID list, it can now be > >> bound to any device, not just those explicitly supported by DPDK. In > >> other words, it now behaves

[dpdk-dev] [PATCH v3 20/20] setup script: adding support for VFIO to setup.sh

2014-05-28 Thread Anatoly Burakov
Support for loading/unloading VFIO drivers, binding/unbinding devices to/from VFIO, also setting up correct userspace permissions. Signed-off-by: Anatoly Burakov --- tools/setup.sh | 156 +++-- 1 file changed, 141 insertions(+), 15

[dpdk-dev] [PATCH v3 19/20] binding script: Renamed igb_uio_bind to dpdk_nic_bind

2014-05-28 Thread Anatoly Burakov
Renaming the igb_uio_bind script to dpdk_nic_bind to have a generic name since we're now supporting two drivers. Signed-off-by: Anatoly Burakov --- tools/{igb_uio_bind.py => dpdk_nic_bind.py} | 47 - tools/setup.sh | 16 +- 2

[dpdk-dev] [PATCH v3 18/20] igb_uio: Removed PCI ID table from igb_uio

2014-05-28 Thread Anatoly Burakov
Removing PCI ID list to make igb_uio more similar to a generic driver like vfio-pci or pci_uio_generic. This is done to make it easier for the binding script to support multiple drivers. Note that since igb_uio no longer has a PCI ID list, it can now be bound to any device, not just those

[dpdk-dev] [PATCH v3 17/20] test app: adding unit tests for VFIO EAL command-line parameter

2014-05-28 Thread Anatoly Burakov
Adding unit tests for VFIO interrupt type command-line parameter. We don't know if VFIO is compiled (eal_vfio.h header is internal to Linuxapp EAL), so we check this flag regardless. Signed-off-by: Anatoly Burakov --- app/test/test_eal_flags.c | 36 1 file

[dpdk-dev] [PATCH v3 15/20] eal: added support for selecting VFIO interrupt type from EAL command-line

2014-05-28 Thread Anatoly Burakov
Unlike igb_uio, VFIO interrupt type is not set by kernel module parameters but is set up via ioctl() calls at runtime. This warrants a new EAL command-line parameter. It will have no effect if VFIO is not compiled, but will set VFIO interrupt type to either "legacy", "msi" or "msix" if VFIO

[dpdk-dev] [PATCH v3 14/20] pci: enable VFIO device binding

2014-05-28 Thread Anatoly Burakov
Add support for binding VFIO devices if RTE_PCI_DRV_NEED_MAPPING is set for this driver. Try VFIO first, if not mapped then try IGB_UIO too. Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_pci.c | 42 --- 1 file changed, 39 insertions(+), 3

[dpdk-dev] [PATCH v3 13/20] vfio: add multiprocess support.

2014-05-28 Thread Anatoly Burakov
Since VFIO cannot be used to map the same device twice, secondary processes receive the device/group fd's by means of communicating over a local socket. Only group and container fd's should be sent, as device fd's can be obtained via ioctl() calls' on the group fd. For multiprocess, VFIO

[dpdk-dev] [PATCH v3 12/20] vfio: create mapping code for VFIO

2014-05-28 Thread Anatoly Burakov
Adding code to support VFIO mapping (primary processes only). Most of the things are done via ioctl() calls on either /dev/vfio/vfio (the container) or a /dev/vfio/$GROUP_NR (IOMMU group). In a nutshell, the code does the following: 1. creates a VFIO container (an entity that allows sharing IOMMU

[dpdk-dev] [PATCH v3 11/20] eal: remove -Wno-return-type for non-existent eal_hpet.c

2014-05-28 Thread Anatoly Burakov
eal_hpet.c was renamed to eal_timer.c and, thanks to code changes, does not need the -Wno-return-type any more. Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/Makefile

[dpdk-dev] [PATCH v3 10/20] interrupts: Add support for VFIO interrupts

2014-05-28 Thread Anatoly Burakov
Creating code to handle VFIO interrupts in EAL interrupts (supports all types of interrupts). Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 285 - .../linuxapp/eal/include/exec-env/rte_interrupts.h | 4 + 2 files changed, 284

[dpdk-dev] [PATCH v3 09/20] vfio: add VFIO header

2014-05-28 Thread Anatoly Burakov
Adding a header that will determine if VFIO support should be compiled in. If VFIO is enabled in config (and it's enabled by default), then the header will also check for kernel version. If VFIO is enabled in config and if the kernel version is 3.6+, then VFIO_PRESENT will be defined. This is the

[dpdk-dev] [PATCH v3 08/20] vfio: add support for VFIO in Linuxapp targets

2014-05-28 Thread Anatoly Burakov
Add VFIO compilation option to all configs. Signed-off-by: Anatoly Burakov --- config/defconfig_i686-default-linuxapp-gcc | 1 + config/defconfig_i686-default-linuxapp-icc | 1 + config/defconfig_x86_64-default-linuxapp-gcc | 1 + config/defconfig_x86_64-default-linuxapp-icc | 1 + 4 files

[dpdk-dev] [PATCH v3 07/20] igb_uio: Moved interrupt type out of igb_uio

2014-05-28 Thread Anatoly Burakov
Moving interrupt type enum out of igb_uio and renaming it to be more generic. Such a strange header naming and separation is done mostly to make coming virtio patches easier to port to dpdk.org tree. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/Makefile | 1 +

[dpdk-dev] [PATCH v3 06/20] igb_uio: make igb_uio compilation optional

2014-05-28 Thread Anatoly Burakov
Currently, igb_uio is always compiled. Some Linux distributions may not want to include igb_uio with DPDK, so we need to make sure that igb_uio compilation can be optional. Signed-off-by: Anatoly Burakov --- config/defconfig_i686-default-linuxapp-gcc | 1 +

[dpdk-dev] [PATCH v3 05/20] pci: Rename RTE_PCI_DRV_NEED_IGB_UIO to RTE_PCI_DRV_NEED_MAPPING

2014-05-28 Thread Anatoly Burakov
Rename the RTE_PCI_DRV_NEED_IGB_UIO to be more generic. Signed-off-by: Anatoly Burakov --- app/test/test_pci.c | 4 ++-- lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +- lib/librte_eal/common/include/rte_pci.h | 4 ++-- lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +-

[dpdk-dev] [PATCH v3 04/20] pci: distinguish between legitimate failures and non-fatal errors

2014-05-28 Thread Anatoly Burakov
Currently, EAL does not distinguish between actual failures and expected initialization errors. E.g. sometimes the driver fails to initialize because it was not supposed to be initialized in the first place, such as device not being managed by said driver. This patch makes EAL fail on actual

[dpdk-dev] [PATCH v3 03/20] pci: fixing errors in a previous commit found by checkpatch

2014-05-28 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c index 61f09cc..ae4e716 100644 ---

[dpdk-dev] [PATCH v3 02/20] pci: move uio mapping code to a separate file

2014-05-28 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/Makefile | 1 + lib/librte_eal/linuxapp/eal/eal_pci.c | 403 + lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 403 +

[dpdk-dev] [PATCH v3 01/20] pci: move open() out of pci_map_resource, rename structs

2014-05-28 Thread Anatoly Burakov
Separating mapping code and calls to open. This is a preparatory work for VFIO patch since it'll need to map BARs too but it doesn't use path in mapped_pci_resource. Also, renaming structs to be more generic. Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_pci.c | 125

[dpdk-dev] [PATCH v2 3/3] testpmd: Add commands to test link up and down of PMD

2014-05-28 Thread Ouyang Changchun
Please ignore previous patch v1, and just apply this patch v2. This patch adds commands to test the functionality of setting link up and down of PMD in testpmd. Signed-off-by: Ouyang Changchun --- app/test-pmd/cmdline.c | 81 ++

[dpdk-dev] [PATCH v2 2/3] ixgbe: Implement the functionality of setting link up and down in IXGBE PMD

2014-05-28 Thread Ouyang Changchun
Please ignore the previous v1 patch, just apply this v2 patch. This patch implements the functionality of setting link up and down in IXGBE PMD. It is implemented by enabling or disabling TX laser. Signed-off-by: Ouyang Changchun --- lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 63

[dpdk-dev] [PATCH v2 1/3] ether: Add API to support set link up and link down

2014-05-28 Thread Ouyang Changchun
Please ignore previous v1 patch, just use this v2 patch. This patch adds API to support the functionality of setting link up and down. It can be used to repeatedly stop and restart RX/TX of a port without re-allocating resources for the port and re-configuring the port. Signed-off-by: Ouyang

[dpdk-dev] [PATCH v2 0/3] Support setting link up and link down

2014-05-28 Thread Ouyang Changchun
Please ignore the previous patch series with subject: "Support administrative link up and link down" This v2 patch series will replace the previous patch series. This patch series contain the following 3 items: 1. Add API to support setting link up and down, it can be used to repeatedly stop

[dpdk-dev] Intel I350 fails to work with DPDK

2014-05-28 Thread sabu kurian
I have asked a similar question before, no one replied though. I'm crafting my own packets in mbuf's (74 byte packets all) and sending it using ret = rte_eth_tx_burst(port_ids[lcore_id], 0, m_pool,burst_size); When burst_size is 1, it does work. Work in the sense the NIC will continue with

[dpdk-dev] DPDK Latency Issue

2014-05-28 Thread Jun Han
Hi all, I realized I made a mistake on my previous post. Please note the changes below. "While I vary the MAX_BURST_SIZE (1, 8, 16, 32, 64, and 128) and fix BURST_TX_DRAIN_US=100 usec, I see a low average latency when sending a burst of packets greater than the MAX_BURST_SIZE. For example, when

[dpdk-dev] [PATCH v2 13/16] Removed PCI ID table from igb_uio

2014-05-28 Thread Antti Kantee
On 28/05/14 13:45, Thomas Monjalon wrote: > So maybe it's possible to improve uio_pci_generic in order to replace igb_uio. > If someone wants to work on it, it's possible to stage uio_pci_generic in > dpdk.org in order to make it ready for kernel.org. Back when researching MSI + uio_pci_generic,

[dpdk-dev] [PATCH v2 0/3] Support setting link up and link down

2014-05-28 Thread Ivan Boule
On 05/28/2014 09:14 AM, Ouyang Changchun wrote: > Please ignore the previous patch series with subject: "Support administrative > link up and link down" > This v2 patch series will replace the previous patch series. > > This patch series contain the following 3 items: > 1. Add API to support

[dpdk-dev] [PATCH 04/29] mbuf: added offset of packet meta-data in the packet buffer just after mbuf

2014-05-28 Thread Ivan Boule
Hi Cristian, Currently, the DPDK framework does not make any assumption on the actual layout of a mbuf. More precisely, the DPDK does not impose any constraint on the actual location of additional metadata, if any, or on the actual location and size of its associated payload data buffer. This is

[dpdk-dev] [PATCH 0/4] Link Bonding Library

2014-05-28 Thread Neil Horman
On Wed, May 28, 2014 at 04:32:00PM +0100, declan.doherty at intel.com wrote: > From: Declan Doherty > > Initial release of Link Bonding Library (lib/librte_bond) with support for > bonding modes : > 0 - Round Robin > 1 - Active Backup > 2 - Balance l2 / l23 / l34 > 3 - Broadcast > Why

[dpdk-dev] [PATCH] mk: fix link with gcc

2014-05-28 Thread Olivier MATZ
Hi Thomas, On 05/27/2014 02:55 PM, Thomas Monjalon wrote: > Some linker options were not prefixed by -Wl, when using gcc: > -z muldefs > -melf_i386 (32-bit config) > > Using macro linkerprefix is fixing it. > > Signed-off-by: Thomas Monjalon The patch looks correct, but from the

[dpdk-dev] [PATCH v2 10/16] Added support for selecting VFIO interrupt type from EAL command-line

2014-05-28 Thread Thomas Monjalon
2014-05-28 10:35, Burakov, Anatoly: > Hi Thomas, > > > > + } > > > > > > else if (!strcmp(lgopts[option_index].name, > > > > OPT_CREATE_UIO_DEV)) > > > > another code style issue reported by checkpatch.pl ;) > > > > But it should be fixed by removing this

[dpdk-dev] [PATCH] cpu_layout.py: adjust output format to align

2014-05-28 Thread Thomas Monjalon
Hi, 2014-05-28 11:02, Shannon Zhao: > I have checked my patch. It doesn't apply correctly when "core id" is > greater than 2 characters. > > Following is my revised patch. It's based on the maximum length of the "core > id" and "processor" to adjust the alignment length. Thank you for reworking

[dpdk-dev] Intel I350 fails to work with DPDK

2014-05-28 Thread Richardson, Bruce
> From: sabu kurian [mailto:sabu2kurian at gmail.com] > Sent: Wednesday, May 28, 2014 11:54 AM > To: Richardson, Bruce > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] Intel I350 fails to work with DPDK > > Hai bruce, > Thanks for the reply. > I even tried that before. Having a burst size of 64

[dpdk-dev] [PATCH] cpu_layout.py: adjust output format to align

2014-05-28 Thread Shannon Zhao
Hi Thomas, Thanks for your reply. I have checked my patch. It doesn't apply correctly when "core id" is greater than 2 characters. Following is my revised patch. It's based on the maximum length of the "core id" and "processor" to adjust the alignment length. Bug: when "core id" is greater

[dpdk-dev] Intel I350 fails to work with DPDK

2014-05-28 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of sabu kurian > Sent: Wednesday, May 28, 2014 10:42 AM > To: dev at dpdk.org > Subject: [dpdk-dev] Intel I350 fails to work with DPDK > > I have asked a similar question before, no one replied though. > > I'm

[dpdk-dev] [PATCH] mk: fix link with gcc

2014-05-28 Thread Neil Horman
On Tue, May 27, 2014 at 02:55:16PM +0200, Thomas Monjalon wrote: > Some linker options were not prefixed by -Wl, when using gcc: > -z muldefs > -melf_i386 (32-bit config) > > Using macro linkerprefix is fixing it. > > Signed-off-by: Thomas Monjalon > --- > mk/rte.lib.mk | 6 --

[dpdk-dev] Please any one who can help me with librte_sched

2014-05-28 Thread Dumitrescu, Cristian
Hi Ariel, I think you put your finger precisely on the problem associated with your approach: you have to iterate through all the queues and free up the packets, which takes a lot of time. Obviously this is not done by the rte_sched API. Maybe a limited workaround for this approach would be to

[dpdk-dev] [PATCH RFC 03/11] mbuf: remove rte_ctrlmbuf

2014-05-28 Thread Ananyev, Konstantin
Hi, >The only win from this is to save the byte for the type field. >Yes bits here are precious. >Does external application mix control and data mbuf's in the same ring? >The stuff in the tree only uses type field for debug validation/sanity >checks. >Since it is only one bit, maybe you can

[dpdk-dev] [PATCH v2 13/16] Removed PCI ID table from igb_uio

2014-05-28 Thread Stephen Hemminger
On Wed, 28 May 2014 15:45:02 +0200 Thomas Monjalon wrote: > 2014-05-23 00:10, Antti Kantee: > > On 22/05/14 13:13, Thomas Monjalon wrote: > > > 2014-05-19 16:51, Anatoly Burakov: > > >> Note that since igb_uio no longer has a PCI ID list, it can now be > > >> bound to any device, not just those

[dpdk-dev] [PATCH 0/2] L3FWD sample optimisation

2014-05-28 Thread Ananyev, Konstantin
Hi Thomas, >As you are doing optimizations, it's important to know the performance gain. >It could help to mitigate future reworks. >So please, could you provide some benchmarking numbers in the commit log? Some performance data below. Also, forgot to mention that new code path can be switched

[dpdk-dev] [PATCH 0/4] New library: rte_distributor

2014-05-28 Thread Richardson, Bruce
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, May 27, 2014 11:33 PM > To: Richardson, Bruce > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/4] New library: rte_distributor > > Hi Bruce, > > As for rte_acl, I have some

[dpdk-dev] Please any one who can help me with librte_sched

2014-05-28 Thread Ariel Rodriguez
Ok i can do that... but still is there a way to ask to the rte_sched_port something like is_empty ... Or simply if the dequeue function return 0 packets retrieved from the old port structure running in other core, Can i assume that port is empty with that? Regards Ariel. On May 28, 2014 7:10

[dpdk-dev] PMD for Cisco VIC Ethernet NIC - Request for guidelines for submission

2014-05-28 Thread Sujith Sankar (ssujith)
Hi all, We have been working on development of poll-mode driver for Cisco VIC Ethernet NIC and integration of it with DPDK. We would like to submit this poll-mode driver (ENIC PMD) to the DPDK community so that it could be part of the DPDK tree. Could someone please provide the guidelines and

[dpdk-dev] [PATCH 0/3] Support administrative link up and link down

2014-05-28 Thread Ouyang, Changchun
Hi Ivan, Thanks very much for your detailed response for this issue, I think your recommendation makes sense, and I will update the naming and re-send a patch for link-up and link-down. Best regards, Changchun -Original Message- From: Ivan Boule [mailto:ivan.bo...@6wind.com] Sent:

[dpdk-dev] [PATCH v2 0/4] NIC filters support for generic filter

2014-05-28 Thread Thomas Monjalon
Hi Jingjing, 2014-05-24 09:37, Jingjing Wu: > A generic filter mechanism for handling special packet is required. > It will allow filters to be set in HW when available so that specific > packet may be filtered by NICs to specific descriptor queues for > processing. Currently only Flow Director

[dpdk-dev] [PATCH v2 0/4] NIC filters support for generic filter

2014-05-28 Thread Wu, Jingjing
Hi, Thomas The generic you said may be different from I mentioned in last mail. You are discussing whether the APIs provide for NIC filters is generic or not. About that we can use same API for a type of filter. For example, if we want to configure ethertype filter, we can use the same API, no

[dpdk-dev] [PATCH 0/3] ixgbe: Add L2 Ethertype, SYN and Five tuple queue filters

2014-05-28 Thread Thomas Monjalon
Hi Vladimir, Seems like hardware filtering becomes useful these days :) 2014-05-19 19:51, Vladimir Medvedkin: > This patchset adds in addition to the Flow Director filters L2 Ethertype, > SYN and Five tuple queue filters to route packets according to ethertype, > l4 proto, source/destination

[dpdk-dev] [PATCH v2 0/3] Support zero copy RX/TX in user space vhost

2014-05-28 Thread Thomas Monjalon
Hi, checkpatch.pl is reporting some errors and I think some of them should avoided. Please check it. Thanks -- Thomas

[dpdk-dev] [PATCH v2 0/3] Support zero copy RX/TX in user space vhost

2014-05-28 Thread Ouyang, Changchun
Yes I will send out a patch v3 to replace the patch v2. Thanks Changchun -Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Wednesday, May 28, 2014 7:02 AM To: Ouyang, Changchun Cc: dev at dpdk.org Subject: Re: [PATCH v2 0/3] Support zero copy RX/TX in user

[dpdk-dev] [PATCH v2 0/4] NIC filters support for generic filter

2014-05-28 Thread Wu, Jingjing
Hi, Thomas This patch is mainly about multiple NIC filters implement. It has close relationship with NICs. As the patch says: NIC filters list below are implemented in this patchset: ethertype filter, syn filter, 2tuple filter and flex filter for 82580 and i350 ethertype

[dpdk-dev] [PATCH v2 1/3] ether: Add API to support setting TX rate for queue and VF

2014-05-28 Thread Thomas Monjalon
Hi Changchun, 2014-05-26 15:45, Ouyang Changchun: > /** > + * Set the rate limitation for a queue on an Ethernet device. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param queue_idx > + * The queue id. > + * @param tx_rate > + * The tx rate allocated

[dpdk-dev] [PATCH 0/4] New library: rte_distributor

2014-05-28 Thread Thomas Monjalon
Hi Bruce, As for rte_acl, I have some formatting comments. 2014-05-20 11:00, Bruce Richardson: > This adds a new library to the Intel DPDK whereby a set of packets can be > distributed one-at-a-time to a set of worker cores, with dynamic load > balancing being done between those workers. Flows

[dpdk-dev] [PATCH 1/4] acl: Add ACL library (librte_acl) into DPDK.

2014-05-28 Thread Thomas Monjalon
Hi Konstantin, Glad to see this new library coming in. 2014-05-22 21:48, Konstantin Ananyev: > The ACL library is used to perform an N-tuple search over a set of rules > with multiple categories and find the best match for each category. > > Signed-off-by: Konstantin Ananyev > --- >