[dpdk-dev] PCIid 0x0436

2014-06-20 Thread Gooch, Stephen
Thanks for the answer off line. 0x0436 is the DID not handled by the OS network driver. I incorrectly read the Cave Creek document. - Stephen From: Gooch, Stephen Sent: Friday, June 20, 2014 3:40 PM To: dev at dpdk.org Subject: PCIid 0x0436 Hello, Cave Creek has PCI id of 0x0436 for port0

[dpdk-dev] PCIid 0x0436

2014-06-20 Thread Gooch, Stephen
Hello, Cave Creek has PCI id of 0x0436 for port0 and 0x0438 for port1. However only 0x0438 is listed in rte_pci_dev_ids.h. Why is 0x0436 not listed? Best Regards - Stephen

[dpdk-dev] [PATCH 6/6] i40e: VF to support VLAN strip and pvid set/clear

2014-06-20 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" VF driver add support to configure vlan offload and pvid set/clear when host driver is DPDK. For Linux driver, it's not supported yet since it doesn't support from host side. Signed-off-by: Chen Jing D(Mark) Acked-by: Helin Zhang Acked-by: Cunming Liang Acked-by: Jin

[dpdk-dev] [PATCH 5/6] i40e: PF host driver to support VF vlan offload and set pvid

2014-06-20 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" PF driver add 2 commands, data structures and corresponding message handling functions to support VF doing VLAN offload and set/clear pvid operation. Signed-off-by: Chen Jing D(Mark) Acked-by: Helin Zhang Acked-by: Cunming Liang Acked-by: Jingjing Wu --- lib/librte

[dpdk-dev] [PATCH 4/6] i40e: make change to vlan_strip and vlan_set_pvid function

2014-06-20 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Change original 2 functions to common ones that can take effect on both VF and PF VSIs. Signed-off-by: Chen Jing D(Mark) Acked-by: Helin Zhang Acked-by: Cunming Liang Acked-by: Jingjing Wu --- lib/librte_pmd_i40e/i40e_ethdev.c | 141 ++-

[dpdk-dev] [PATCH 3/6] i40e: Add sanity check in pf host driver

2014-06-20 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add sanity check in message handling functions on the request buffer pointer from VF. Signed-off-by: Chen Jing D(Mark) Acked-by: Helin Zhang Acked-by: Cunming Liang Acked-by: Jingjing Wu --- lib/librte_pmd_i40e/i40e_pf.c | 23 ++- 1 files chan

[dpdk-dev] [PATCH 2/6] i40e: Add permenant mac address into mac list

2014-06-20 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" In old firmware versions, the default mac vlan filter setting is not the one that we expected, so we'll try to remove it and add new one to change default setting. After firmware updated, it change default setting to the one that we expected and don't allow to remove the

[dpdk-dev] [PATCH 1/6] i40e: destroy MSIX pool when device is closed

2014-06-20 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Free MSIX pool resource in function i40e_dev_close. Signed-off-by: Chen Jing D(Mark) Acked-by: Helin Zhang Acked-by: Cunming Liang Acked-by: Jingjing Wu --- lib/librte_pmd_i40e/i40e_ethdev.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/l

[dpdk-dev] [PATCH 0/6] Support i40e VF vlan offload and pvid config

2014-06-20 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" The patch includes the changes in pf, pf host and vf driver for i40e to support VF vlan strip and pvid set/clear. In the meanwhile, make several minor changes to do sanity check and bug fixes. Chen Jing D(Mark) (6): i40e: destroy MSIX pool when device is closed i4

[dpdk-dev] [PATCH] distributor: split get_pkt into request and poll

2014-06-20 Thread Thomas Monjalon
> > Take the existing get_pkt API and split out the parts for requesting a new > > packet from the part to poll for arrival of a new packet. These individual > > functions can then be used independently of the get function, which still acts > > as before. > > > > The split functions for request a

[dpdk-dev] Invitation to connect on LinkedIn

2014-06-20 Thread R Keith Beal (N1ZT)
LinkedIn I'd like to add you to my professional network on LinkedIn. - R Keith R Keith Beal (N1ZT) Distinguished Engineer, Visionary, Mentor, Peer, Pupil and Friend Orange County, California Area Confirm that you know R Keith Beal (N1ZT): https://www.linkedin.com/e/-c8m5yk-hwnqtn

[dpdk-dev] [PATCH v3] EAL: fix usage of printf-like functions

2014-06-20 Thread Stephen Hemminger
On Sat, 21 Jun 2014 00:34:30 +0100 Bruce Richardson wrote: > + (int)(strnlen(buf, sizeof(buf)) - sizeof("_config")), minor nit, paren not needed here (int)strnlen(buf, sizeof...) better yet change rte_snprintf() to take a size_t to make it compatiable

[dpdk-dev] [PATCH 10/10] rte_acl: make acl tailq fully local

2014-06-20 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- lib/librte_acl/acl.h | 1 - lib/librte_acl/rte_acl.c | 74 +++- 2 files changed, 60 insertions(+), 15 deletions(-) diff --git a/lib/librte_acl/acl.h b/lib/librte_acl/acl.h index e6d7985..b9d63fd 100644 --- a/lib

[dpdk-dev] [PATCH 09/10] rte_lpm6: make lpm6 tailq fully local

2014-06-20 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- lib/librte_lpm/rte_lpm6.c | 62 ++- 1 file changed, 51 insertions(+), 11 deletions(-) diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c index 32690cb..8072534 100644 --- a/lib/librte_lpm/rte_lpm6.c +

[dpdk-dev] [PATCH 08/10] rte_lpm: make lpm tailq fully local

2014-06-20 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- lib/librte_lpm/rte_lpm.c | 65 lib/librte_lpm/rte_lpm.h | 2 -- 2 files changed, 54 insertions(+), 13 deletions(-) diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c index 35209c3..1ee4e96 100644

[dpdk-dev] [PATCH 07/10] rte_mempool: make mempool tailq fully local

2014-06-20 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- lib/librte_mempool/Makefile | 3 ++- lib/librte_mempool/rte_mempool.c | 37 - lib/librte_mempool/rte_mempool.h | 2 -- 3 files changed, 30 insertions(+), 12 deletions(-) diff --git a/lib/librte_mempool/Makefile b/lib/

[dpdk-dev] [PATCH 06/10] rte_fbk_hash: make rte_fbk_hash tailq fully local

2014-06-20 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- lib/librte_hash/rte_fbk_hash.c | 73 ++ lib/librte_hash/rte_fbk_hash.h | 3 -- 2 files changed, 59 insertions(+), 17 deletions(-) diff --git a/lib/librte_hash/rte_fbk_hash.c b/lib/librte_hash/rte_fbk_hash.c index 4d6755

[dpdk-dev] [PATCH 05/10] rte_hash: make rte_hash tailq fully local

2014-06-20 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- lib/librte_hash/rte_hash.c | 61 +++--- lib/librte_hash/rte_hash.h | 2 -- 2 files changed, 52 insertions(+), 11 deletions(-) diff --git a/lib/librte_hash/rte_hash.c b/lib/librte_hash/rte_hash.c index d4221a8..eea5c01 1

[dpdk-dev] [PATCH 04/10] rte_ring: make ring tailq fully local

2014-06-20 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_ivshmem.c | 17 ++-- lib/librte_ring/Makefile | 4 ++-- lib/librte_ring/rte_ring.c| 33 +++ lib/librte_ring/rte_ring.h| 2 -- 4 files chan

[dpdk-dev] [PATCH 03/10] rte_tailq: change rte_dummy to rte_tailq_entry, add data pointer

2014-06-20 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- app/test/test_tailq.c | 33 --- lib/librte_eal/common/eal_common_tailqs.c | 2 +- lib/librte_eal/common/include/rte_tailq.h | 9 + 3 files changed, 23 insertions(+), 21 deletions(-) diff --git a/app/tes

[dpdk-dev] [PATCH 02/10] eal: use --base-virtaddr for mapping rte_config as well

2014-06-20 Thread Anatoly Burakov
Use --base-virtaddr to set the address of rte_config file along with start address of the hugepages. Since the user would likely expect the hugepages to be starting at the specified address, the specified address will likely be rounded to either 2M or 1G. So, in order to not waste space, we subtrac

[dpdk-dev] [PATCH 01/10] eal: map shared config into exact same address as primary process

2014-06-20 Thread Anatoly Burakov
Shared config is shared across primary and secondary processes. However,when using rte_malloc, the malloc elements keep references to the heap inside themselves. This heap reference might not be referencing a local heap because the heap reference points to the heap of whatever process has allocated

[dpdk-dev] [PATCH 00/10] Make DPDK tailqs fully local

2014-06-20 Thread Anatoly Burakov
This issue was reported by OVS-DPDK project, and the fix should go to upstream DPDK. This is not memnic-related - this is to do with DPDK's rte_ivshmem library. Every DPDK data structure has a corresponding TAILQ reserved for it in the runtime config file. Those TAILQs are fully local to the proce

[dpdk-dev] [PATCH 7/7] app/testpmd: rework for displaying different size of RX descriptors

2014-06-20 Thread Thomas Monjalon
2014-06-20 14:14, Helin Zhang: > i40e supports 16 and 32 bytes RX descriptors which can be configured. > It needs to check the driver type and the configuration to determine > if 16 or 32 bytes RX descriptors is being used, for reading and > displaying the different sizes of RX descriptors. [...] >

[dpdk-dev] [PATCH 6/7] i40evf: fix for copying wrong size of link info, and remove an useless function

2014-06-20 Thread Thomas Monjalon
2014-06-20 14:14, Helin Zhang: > Delete the inline function which is not used at this moment. > Fix the bug of copying wrong size of link info in function of > i40evf_get_link_status(). There are 2 patches here. Please split. > static inline int > -i40evf_dev_atomic_read_link_status(struct rte_e

[dpdk-dev] [PATCH 3/7] i40e: ignore the failure of updating default filter settings

2014-06-20 Thread Thomas Monjalon
2014-06-20 14:14, Helin Zhang: > The failure of updating the default filter setting should be > ignored. The updating is to change the default vlan filter > behaviours configured by firmware to expected. > The failure happens on the firmware version of 4.2.2, > while doesn't happen on previous vers

[dpdk-dev] [PATCH 2/7] i40evf: support configuring crc stripping hw offload

2014-06-20 Thread Thomas Monjalon
Hi Helin, 2014-06-20 14:14, Helin Zhang: > In VF driver, crc stripping hw offload is enabled or not, according > to the configurations in config file. > > Signed-off-by: Helin Zhang > Acked-by: Cunming Liang > Acked-by: Jing Chen [...] > static int > -i40evf_dev_configure(__rte_unused struct

[dpdk-dev] [PATCH 1/2] virtio: checkpatch cleanups

2014-06-20 Thread Thomas Monjalon
2014-06-20 13:34, Carew, Alan: > Acked-by: Alan Carew This patch is already applied: http://dpdk.org/browse/dpdk/commit/?id=14337d0b7a1 Please, when acknowledging patches without comment, it's better to remove its content and keep only logs. Thanks, acknowledgements are really apprecia

[dpdk-dev] [PATCH 0/6] Support i40e VF vlan offload and pvid config

2014-06-20 Thread Thomas Monjalon
2014-06-20 18:24, Chen Jing D: > The patch includes the changes in pf, pf host and vf driver for i40e to > support VF vlan strip and pvid set/clear. In the meanwhile, make several > minor changes to do sanity check and bug fixes. Applied for version 1.7.0. Thanks -- Thomas

[dpdk-dev] [PATCH] ethdev: read link state interrupt without link_update service

2014-06-20 Thread Thomas Monjalon
It is now possible to read link status updated by interrupt without having manual link_update() service provided by the PMD. Indeed link_update() is useless in interrupt case. Signed-off-by: Thomas Monjalon --- lib/librte_ether/rte_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

[dpdk-dev] [PATCH v2] rte_ethdev: add link support flag

2014-06-20 Thread Thomas Monjalon
Hi Stephen, 2014-06-19 15:12, Stephen Hemminger: > Only some devices support the link state interrupt configuration option. > Link state control does not work in virtual drivers > (virtio, vmxnet3, igbvf, and ixgbevf). Instead of having the application > try and guess whether it will work or not p

[dpdk-dev] mmap() hint address

2014-06-20 Thread Burakov, Anatoly
Hi Stephen, You may want to look at the local tailqs patchset I've made. This may fix your issues as well. http://dpdk.org/ml/archives/dev/2014-June/003573.html I'm planning to respin a v4 of it, with an addition of using --base-virtaddr flag to also control where rte_config is mapped as well

[dpdk-dev] mmap() hint address

2014-06-20 Thread Gooch, Stephen
Hello, One item I should have included is this device is running 32-bit 2.6.27, quite old, and sharing 4GB of RAM with a number of applications. We were able to find the issue. In the failure case vDSO is mapped lower (toward [heap]) than normal. As a result , .rte_config was mapped into th

[dpdk-dev] [PATCH 7/7] app/testpmd: rework for displaying different size of RX descriptors

2014-06-20 Thread Helin Zhang
i40e supports 16 and 32 bytes RX descriptors which can be configured. It needs to check the driver type and the configuration to determine if 16 or 32 bytes RX descriptors is being used, for reading and displaying the different sizes of RX descriptors. Signed-off-by: Helin Zhang Acked-by: Cunming

[dpdk-dev] [PATCH 6/7] i40evf: fix for copying wrong size of link info, and remove an useless function

2014-06-20 Thread Helin Zhang
Delete the inline function which is not used at this moment. Fix the bug of copying wrong size of link info in function of i40evf_get_link_status(). Signed-off-by: Helin Zhang Acked-by: Cunming Liang Acked-by: Jing Chen --- lib/librte_pmd_i40e/i40e_ethdev_vf.c | 16 +--- 1 file cha

[dpdk-dev] [PATCH 5/7] i40e: double vlan should be specifically disabled by default

2014-06-20 Thread Helin Zhang
Double vlan should be specifically disabled by default during port initialization which is expected. Signed-off-by: Helin Zhang Acked-by: Cunming Liang Acked-by: Jing Chen --- lib/librte_pmd_i40e/i40e_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_pmd_i40e/i40e_ethd

[dpdk-dev] [PATCH 4/7] i40e: fix for updating the hash lookup table of PF RSS

2014-06-20 Thread Helin Zhang
The bit shifting were written wrongly in '0x1 < j', the correct one should be '0x1 << j'. Signed-off-by: Helin Zhang Acked-by: Cunming Liang Acked-by: Jing Chen --- lib/librte_pmd_i40e/i40e_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_pmd_i40e/i40e_et

[dpdk-dev] [PATCH 3/7] i40e: ignore the failure of updating default filter settings

2014-06-20 Thread Helin Zhang
The failure of updating the default filter setting should be ignored. The updating is to change the default vlan filter behaviours configured by firmware to expected. The failure happens on the firmware version of 4.2.2, while doesn't happen on previous versions, as the default settings of firmware

[dpdk-dev] [PATCH 2/7] i40evf: support configuring crc stripping hw offload

2014-06-20 Thread Helin Zhang
In VF driver, crc stripping hw offload is enabled or not, according to the configurations in config file. Signed-off-by: Helin Zhang Acked-by: Cunming Liang Acked-by: Jing Chen --- lib/librte_pmd_i40e/i40e_ethdev_vf.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff

[dpdk-dev] [PATCH 1/7] i40e: fix for getting correct RSS hash result

2014-06-20 Thread Helin Zhang
It wrongly gets the RSS hash result from the RX descriptor which has been modified for receiving new packet. The fix is to get the RSS hash result from the buffer which saves the RX descriptor. Signed-off-by: Helin Zhang Acked-by: Cunming Liang Acked-by: Jing Chen --- lib/librte_pmd_i40e/i40e_

[dpdk-dev] [PATCH 0/7] enhancements for i40e

2014-06-20 Thread Helin Zhang
These patches are enhancements for i40e or relevant. In detail, they include: * fix for getting correct RSS hash result in i40e RX functions. * support crc stripping hw offload in VF driver. * ignore the failure of updating default filter setting. * fix for updating the hash lookup table of PF

[dpdk-dev] [PATCH 0/8] virtio driver phase 2

2014-06-20 Thread Carew, Alan
Acked-by: Alan Carew Over eager mail filter attacked 7/8. > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger > Sent: Saturday, June 14, 2014 2:06 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 0/8] virtio driver phase 2 > > This is se

[dpdk-dev] [PATCH 1/2] virtio: checkpatch cleanups

2014-06-20 Thread Carew, Alan
Acked-by: Alan Carew > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger > Sent: Friday, June 13, 2014 2:33 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] virtio: checkpatch cleanups > > > This fixes style problems reported by che

[dpdk-dev] Random mbuf corruption

2014-06-20 Thread Paul Barrette
On 06/20/2014 07:20 AM, Stefan Baranoff wrote: > All, > > We are seeing 'random' memory corruption in mbufs coming from the ixgbe UIO > driver and I am looking for some pointers on debugging it. Our software was > running flawlessly for weeks at a time on our old Westmere systems (CentOS > 6.4) bu

[dpdk-dev] [PATCH] distributor: split get_pkt into request and poll

2014-06-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, June 19, 2014 10:13 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] distributor: split get_pkt into request and poll > > Take the existing get_pkt API and split out the

[dpdk-dev] [PATCH v2] EAL: fix usage of printf-like functions

2014-06-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, June 19, 2014 7:22 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2] EAL: fix usage of printf-like functions > > Mark the rte_log, cmdline_printf and rte_snprintf fun

[dpdk-dev] Random mbuf corruption

2014-06-20 Thread Stefan Baranoff
All, We are seeing 'random' memory corruption in mbufs coming from the ixgbe UIO driver and I am looking for some pointers on debugging it. Our software was running flawlessly for weeks at a time on our old Westmere systems (CentOS 6.4) but since moving to a new Sandy Bridge v2 server (also CentOS

[dpdk-dev] [PATCH 0/7] enhancements for i40e

2014-06-20 Thread Zhang, Helin
-Original Message- From: Zhang, Helin Sent: Friday, June 20, 2014 2:15 PM To: dev at dpdk.org Cc: Zhang, Helin Subject: [PATCH 0/7] enhancements for i40e These patches are enhancements for i40e or relevant. In detail, they include: * fix for getting correct RSS hash result in i40e RX fun

[dpdk-dev] [PATCH v2] kni: fix compile errors on Oracle Linux6.4 and RHEL6.5

2014-06-20 Thread Zhang, Helin
Hi Thomas No special reason to avoid using '#define'. I think both are OK. But inline function can provide more type checks for the input/output parameters. Also inline functions with even only one line code can be seen a lot in that file. So I assume that it is not mandatory to use '#define'