2014-10-27 13:21, Matthew Hall:
> On Mon, Oct 27, 2014 at 03:13:39PM +0100, Thomas Monjalon wrote:
> > You didn't answer to my previous comment on this.
> > I think these definitions are useless. 64 is 64.
>
> Putting labels on the constants gives meaning to them as well as a numeric
> value. Not
Poke!
Can anybody advice about this question ?
Kevin
On Fri, Oct 24, 2014 at 12:54 PM, Kevin Wilson wrote:
> Hi,
>
> I am looking in the file hierarchy of dpdk, and I see that under
> /dpdk-1.7.1/lib/librte_eal/linuxapp/kni/ethtool
> we have:
> igb ixgbe README
>
> My question is: why the igb a
2014-10-22 09:01, Jingjing Wu:
> +/**
> + * A structure used to define the input for IPV4 UDP flow
> + */
> +struct rte_eth_udpv4_flow {
> + uint32_t src_ip; /**< IPv4 source address to match. */
> + uint32_t dst_ip; /**< IPv4 destination address to match. */
> + uint16_t src_
Shivapriya?
It is still ongoing as we need to run it on different Xeon server
platform like SandyBridge and IvyBridge, will post summary result
here once it is ready.
-Danny
From: Shivapriya Hiremath [mailto:shivpr...@gmail.com]
Sent: Tuesday, October 28, 2014 1:28 AM
To: Zhou, Danny
Cc: dev at
2014-10-22 09:01, Jingjing Wu:
> The patch set supports flow director on fortville.
> It includes:
> - set up/tear down fortville resources to support flow director, such as
> queue and vsi.
> - support operation to add or delete 8 flow types of the flow director
> filters, they are ipv4, tcpv4
2014-10-27 14:34, Liu, Jijiang:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > I think there is also a wording error: you are writing VxLAN with x
> > lowercase but
> > standard is writing it all uppercase: VXLAN. Do you agree?
> Virtual eXtensible Local Area Network (VXLAN)
>
> From: Liang, Cunming
> Sent: Monday, October 27, 2014 1:20 AM
> To: dev at dpdk.org
> Cc: nhorman at tuxdriver.com; Ananyev, Konstantin; Richardson, Bruce; De Lara
> Guarch, Pablo; Liang, Cunming
> Subject: [PATCH v6 3/3] ethdev: fix wrong error return refere to API
> definition
>
> Per defin
2014-10-22 19:53, Helin Zhang:
> +#define RTE_BIT_WIDTH_64 (CHAR_BIT * sizeof(uint64_t))
How can it be different of 64?
Using 64 would be simpler to understand than RTE_BIT_WIDTH_64.
> + uint8_t reta[RTE_BIT_WIDTH_64]; /**< 64 redirection table entries. */
Even your comment is saying that it
2014-10-22 19:53, Helin Zhang:
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -430,6 +430,9 @@ struct rte_eth_rss_conf {
> /* Definitions used for redirection table entry size */
> #define ETH_RSS_RETA_NUM_ENTRIES 128
> #define ETH_RSS_RETA_MAX_QUEUE 16
> +#de
2014-10-27 02:41, Zhang, Helin:
> > The patch set supports VxLAN on Fortville based on latest rte_mbuf
> > structure.
> >
> > It includes:
> > - Support VxLAN packet identification by configuring UDP tunneling port.
> > - Support VxLAN packet filters. It uses MAC and VLAN to point
> >to a q
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Monday, October 27, 2014 9:46 PM
> To: Liu, Jijiang
> Cc: dev at dpdk.org; Zhang, Helin
> Subject: Re: [dpdk-dev] [PATCH v8 00/10] Support VxLAN on Fortville
>
> 2014-10-27 02:41, Zhang, Helin:
> >
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Monday, October 27, 2014 4:46 PM
> To: Ouyang, Changchun
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] vhost: Check descriptor number for vector
> Rx
>
> 2014-10-25 00:48, Ouyan
On Mon, Oct 27, 2014 at 03:13:39PM +0100, Thomas Monjalon wrote:
> You didn't answer to my previous comment on this.
> I think these definitions are useless. 64 is 64.
Putting labels on the constants gives meaning to them as well as a numeric
value. Not doing so is an antipattern referred to as "
This patch specifies rx_mode as 0 for 2 samples: vmdq and vhost-xen
because the multicast feature is not available currently for both samples.
Signed-off-by: Changchun Ouyang
---
examples/vhost_xen/main.c | 1 +
examples/vmdq/main.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/exam
This patch adds new API in virtio for supporting promiscuous and allmulticast
enabling and disabling.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 98 ++-
1 file changed, 97 insertions(+), 1 deletion(-)
diff --git a/lib/librte_pmd_
This patch is to let vhost receive and forward multicast and broadcast packets,
add promiscuous option into command line; and set VMDQ RX mode as:
ETH_VMDQ_ACCEPT_BROADCAST|ETH_VMDQ_ACCEPT_MULTICAST if promisc mode is on.
Signed-off-by: Changchun Ouyang
---
examples/vhost/main.c | 25 +++
This patch set VM offload register according to VMDQ config for e1000
PMD to support multicast and broadcast packets.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_e1000/igb_rxtx.c | 20
1 file changed, 20 insertions(+)
diff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/li
This patch adds new field of rx mode in VMDQ config; and set the register
PFVML2FLT
for IXGBE PMD, this makes VMDQ receive multicast and broadcast packets.
Signed-off-by: Changchun Ouyang
---
lib/librte_ether/rte_ethdev.h | 1 +
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 16
2 fi
- V1 change:
This patch series support multicast feature in virtio and vhost.
The vhost backend enables the promiscuous mode and config
ETH_VMDQ_ACCEPT_BROADCAST
and ETH_VMDQ_ACCEPT_MULTICAST in VMDQ offload register to receive the multicast
and broadcast packets.
The virtio frontend provides th
- V1 change:
This patch series support multicast feature in virtio and vhost.
The vhost backend enables the promiscuous mode and config
ETH_VMDQ_ACCEPT_BROADCAST
and ETH_VMDQ_ACCEPT_MULTICAST in VMDQ offload register to receive the multicast
and broadcast packets.
The virtio frontend provides th
- V1 change:
This patch series support multicast feature in virtio and vhost.
The vhost backend enables the promiscuous mode and config
ETH_VMDQ_ACCEPT_BROADCAST
and ETH_VMDQ_ACCEPT_MULTICAST in VMDQ offload register to receive the multicast
and broadcast packets.
The virtio frontend provides th
Hi Danny,
Your reply was very helpful in understanding the impact. Can you please
tell us if you saw any performance impact to DPDK when iommu=on ?
-Shivapriya
On Wed, Oct 22, 2014 at 8:21 AM, Zhou, Danny wrote:
> Echo Cunming and we did not see obvious performance impact when iommu = pt
> is
Hello Alan,
On 10/20/2014 05:26 PM, Carew, Alan wrote:
> A comment on my own patch.
>
> Making the size of result_buf consistent across each OS and keeping it as
> large
> as the Linux BUFSIZ(8192) doesn't really address the core issue.
>
> In the event that a user of librte_cmdline creates a c
Add test cases in testpmd to test VxLAN Tx Checksum offload, which include
- IPv4 and IPv6 packet
- outer L3, inner L3 and L4 checksum offload for Tx side.
Signed-off-by: Jijiang Liu
---
app/test-pmd/cmdline.c | 13 ++-
app/test-pmd/config.c |6 +-
app/test-pmd/csumonly.c | 194 +
Support VxLAN Tx checksum offload, which include
- outer L3(IP) checksum offload
- inner L3(IP) checksum offload
- inner L4(UDP, TCP and SCTP) checksum offload
Signed-off-by: Jijiang Liu
---
lib/librte_mbuf/rte_mbuf.h |1 +
lib/librte_pmd_i40e/i40e_rxtx.c | 46 ++
Add the "tunnel_filter" command in testpmd to test the API of VxLAN packet
filter.
Signed-off-by: Jijiang Liu
---
app/test-pmd/cmdline.c | 150
1 files changed, 150 insertions(+), 0 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pm
The filter types supported are listed below for VxLAN:
1. Inner MAC and Inner VLAN ID.
2. Inner MAC address, inner VLAN ID and tenant ID.
3. Inner MAC and tenant ID.
4. Inner MAC address.
5. Outer MAC address, tenant ID and inner MAC address.
Signed-off-by: Jijiang Liu
---
lib/lib
Add definations of the data structures of tunneling packet filter in the
rte_eth_ctrl.h file.
Signed-off-by: Jijiang Liu
---
lib/librte_ether/rte_eth_ctrl.h | 49 +++
1 files changed, 49 insertions(+), 0 deletions(-)
diff --git a/lib/librte_ether/rte_eth_c
Add two commands to test VxLAN packet identification.
The test steps are as follows:
1> use commands to add/delete VxLAN UDP port.
2> use rxonly mode to receive VxLAN packet.
Signed-off-by: Jijiang Liu
---
app/test-pmd/cmdline.c | 65
app/test
Implement the configuration API of VxLAN destination UDP port in
librte_pmd_i40e,
and add new Rx offload flags for supporting VXLAN packet offload.
Signed-off-by: Jijiang Liu
---
lib/librte_mbuf/rte_mbuf.h|2 +
lib/librte_pmd_i40e/i40e_ethdev.c | 157 +++
There are "some" destination UDP port numbers that have unque meaning.
In terms of VxLAN, "IANA has assigned the value 4789 for the VXLAN UDP port,
and this value SHOULD be used by default as the destination UDP port. Some
early implementations of VXLAN have used other values for the destination
Add definations of basic data structures of VxLAN.
Signed-off-by: Jijiang Liu
---
lib/librte_ether/rte_eth_ctrl.h | 12
lib/librte_ether/rte_ethdev.h |8
lib/librte_ether/rte_ether.h| 13 +
3 files changed, 33 insertions(+), 0 deletions(-)
diff --
Replace the "reserved2" field with the "packet_type" field and add the
"inner_l2_l3_len" field in the rte_mbuf structure.
The "packet_type" field is used to indicate ordinary packet format and also
tunneling packet format such as IP in IP, IP in GRE, MAC in GRE and MAC in UDP.
The "inner_l2_len"
The patch set supports VxLAN on Fortville based on latest rte_mbuf structure.
It includes:
- Support VxLAN packet identification by configuring UDP tunneling port.
- Support VxLAN packet filters. It uses MAC and VLAN to point
to a queue. The filter types supported are listed below:
1. Inn
2014-10-25 00:48, Ouyang, Changchun:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > 2014-10-24 16:38, Ouyang Changchun:
> > > For zero copy, it need check whether RX descriptor num meets the least
> > > requirement when using vector PMD Rx function, and give user more
> > > hints
Per definition, rte_eth_rx_burst/rte_eth_tx_burst/rte_eth_rx_queue_count
returns the packet number
When RTE_LIBRTE_ETHDEV_DEBUG turns on, retval of FUNC_PTR_OR_ERR_RTE was set to
-ENOTSUP.
It makes confusing.
The patch always return 0 no matter no packet or there's error.
Signed-off-by: Cunming
The unit test can be used to measure cycles per packet in different rx/tx
rouines.
The NIC works in loopback mode. So it doesn't require test equipment to measure
throughput.
As result, the unit test shows the average cycles per packet consuming.
When doing the test, make sure the link is UP.
Us
adding support to allow packet burst generator to create packets in differenct
sizes
Signed-off-by: Cunming Liang
Acked-by: Declan Doherty
---
app/test/packet_burst_generator.c | 26
app/test/packet_burst_generator.h | 11 +++--
app/test/test_link_bonding.c
v6 update:
# leave FUNC_PTR_OR_*_RET unmodified
v5 update:
# fix the confusing of retval in some API of rte_ethdev
v4 ignore
v3 update:
# Codes refine according to the feedback.
1. add ether_format_addr to rte_ether.h
2. fix typo in code comments.
3. %lu to %PRIu64, fixing 32-bit targets c
Pls ignore this duplicated one,
The mail server should has some issue, I cancel the sending out in first 2
times but it still sent it out. :-( Sorry for that.
Changchun
> -Original Message-
> From: Ouyang, Changchun
> Sent: Monday, October 27, 2014 11:39 AM
> To: dev at dpdk.org
> Cc: C
Acked-by: Helin Zhang
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jijiang Liu
> Sent: Monday, October 27, 2014 10:13 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v8 00/10] Support VxLAN on Fortville
>
> The patch set supports VxLAN on Fortville
Tested-by: Yong Liu
- Tested Commit: 455d09e54b92a4626e178b020fe9c23e43ede3f7
- OS: Fedora20 3.15.8-200.fc20.x86_64
- GCC: gcc version 4.8.3 20140624
- CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz
- NIC: Intel Corporation Ethernet Controller XL710 for 40GbE QSFP+ [8086:1583]
- Default x86_64-na
Tested-by: Yong Liu
- Tested Commit: 1ab07743b21b785a71fa334641ab58e779532600
- OS: Fedora20 3.15.8-200.fc20.x86_64
- GCC: gcc version 4.8.3 20140624
- CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz
- NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection
[8086:10fb]
- Default x86
Ok, I'll roll back to v4.
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Friday, October 24, 2014 7:05 PM
> To: dev at dpdk.org
> Cc: nhorman at tuxdriver.com; Richardson, Bruce; De Lara Guarch, Pablo; Liang,
> Cunming
> Subject: RE: [PATCH v5 3/3] ethdev: fix wrong error return
44 matches
Mail list logo
