[dpdk-dev] [PATCH v3 0/5] support of configurable CRC stripping in VF

2014-11-06 Thread Thomas Monjalon
> > To support configurable CRC stripping in both PF host > > and VF, a new operation and a new structure are added > > to carry more configurations from VF to PF host. > > > > v2 changes: > > * Put all the renaming and code style fixes into a patch. > > * Put processing crc stripping configuratio

[dpdk-dev] Cannot run l3fwd

2014-11-06 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Eduard Gibert Renart > Sent: Thursday, November 06, 2014 7:40 PM > To: > Subject: [dpdk-dev] Cannot run l3fwd > > Hi Everyone: > > When I try to run l3fwd inside my VM I get the following error: > > ubuntu

[dpdk-dev] [PATCH v5] eal: map uio resources after hugepages when the base_virtaddr is configured.

2014-11-06 Thread lxu
Sorry, I'm learning the right way to send a patch by git. I have a multiple processes application. When start the secondary process, I got error message "EAL: pci_map_resource(): cannot mmap(11, 0x77fba000, 0x2, 0x0): Bad file descriptor (0x77fb9000)". The secondary process links a l

[dpdk-dev] [PATCH 1/2] lib/librte_vhost: code style fixes

2014-11-06 Thread Thomas Monjalon
> > fixes alignment issues, lengthy lines, misordered type and other coding > > style issues. > > > > Signed-off-by: Huawei Xie > > Acked-by: Neil Horman Both patches merged and applied. Thanks -- Thomas

[dpdk-dev] [PATCH] librte_vhost: Fix the path test issue

2014-11-06 Thread Thomas Monjalon
> > Commit aec8283d47d4e4366b6 fixes the compilation issue, but it leads to > > one runtime issue: early exit wrongly. In some case, 'path' is NULL, but > > 'resolved_path' has effective path, it should continue going ahead rather > > than exit. > > > > Signed-off-by: Changchun Ouyang > > Acked-

[dpdk-dev] [PATCH v4] eal: map uio resources after hugepages when the base_virtaddr is configured.

2014-11-06 Thread lxu
Signed-off-by: lxu --- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c index 7e62266..a2c9ab6 100644 --- a/lib/librte_

[dpdk-dev] [PATCH v4] eal: map uio resources after hugepages when the base_virtaddr is configured.

2014-11-06 Thread lxu
--- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c index 7e62266..a2c9ab6 100644 --- a/lib/librte_eal/linuxapp/eal/eal

[dpdk-dev] 答复:[PATCH v2] eal: map uio resources after hugepages when the base_virtaddr is configured.

2014-11-06 Thread 徐亮
When user configure?base_virtaddr, we should believe they can take care it. In my case, I always check /proc//maps to find a huge free address space, such as 0x20 , to map all the hugepages and uio resource.? --Burako

[dpdk-dev] [PATCH v3] eal: map uio resources after hugepages when the base_virtaddr is configured.

2014-11-06 Thread lxu
--- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c index 7e62266..3a218d0 100644 --- a/lib/librte_eal/linuxapp/eal/eal

[dpdk-dev] [PATCH v5 8/8] i40evf: support of updating/querying redirection table

2014-11-06 Thread Helin Zhang
Support of updating/querying redirection table has been added for VF. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e_ethdev_vf.c | 99 ++-- 1 file changed, 94 insertions(+), 5 deletions(-) v2 changes: * Add support of updating/querying i40e reta of VF.

[dpdk-dev] [PATCH v5 7/8] ethdev: support of multiple sizes of redirection table

2014-11-06 Thread Helin Zhang
As 40G NIC supports different sizes (128/512/64 entries) of redirection table from that (128 entries) of 1G and 10G NICs, support of multiple sizes of redirection table is needed. It includes, * Redefine 'struct rte_eth_rss_reta' in ethdev. - To 'struct rte_eth_rss_reta_entry64' which contains 64

[dpdk-dev] [PATCH v5 6/8] i40e: rework of ops of 'dev_infos_get' for both PF and VF

2014-11-06 Thread Helin Zhang
Returning redirection table size has been supported in ops of 'dev_infos_get' for both PF and VF. Default RX/TX configurations of VF can be returned in ops of 'dev_infos_get', while it was missed before. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e_ethdev.c| 15 +++ li

[dpdk-dev] [PATCH v5 5/8] ixgbe: implement ops of 'dev_infos_get' for PF and VF respectively

2014-11-06 Thread Helin Zhang
As more and more information are different between PF and VF, ops of 'dev_infos_get' has been implemented respectively. In addition, returning redirection table size has been supported in it. Signed-off-by: Helin Zhang --- lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 90 +---

[dpdk-dev] [PATCH v5 4/8] igb: implement ops of 'dev_infos_get' for PF and VF respectively

2014-11-06 Thread Helin Zhang
As more and more information are different between PF and VF, ops of 'dev_infos_get' has been implemented respectively. In addition, new field of 'reta_size' has been added in 'struct rte_eth_dev_info' for returning redirection table size. Signed-off-by: Helin Zhang --- lib/librte_ether/rte_ethd

[dpdk-dev] [PATCH v5 3/8] i40e: support of setting hash lookup table size

2014-11-06 Thread Helin Zhang
Add support of setting hash lookup table size according to the hardawre capability. Signed-off-by: Helin Zhang --- lib/librte_ether/rte_ethdev.h | 9 - lib/librte_pmd_i40e/i40e_ethdev.c | 14 +- lib/librte_pmd_i40e/i40e_ethdev.h | 1 + 3 files changed, 22 insertions(+),

[dpdk-dev] [PATCH v5 2/8] i40evf: code style fix

2014-11-06 Thread Helin Zhang
Fix of several code style issues. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e_ethdev_vf.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e_ethdev_vf.c b/lib/librte_pmd_i40e/i40e_ethdev_vf.c index fa838e6..5b8a3bf 100644 --- a/

[dpdk-dev] [PATCH v5 1/8] app/testpmd: code style fix

2014-11-06 Thread Helin Zhang
Fix of several code style issues. Signed-off-by: Helin Zhang --- app/test-pmd/cmdline.c | 28 +++- app/test-pmd/config.c | 2 +- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 4c3fc76..daba286 10064

[dpdk-dev] [PATCH v5 0/8] support of multiple sizes of redirection table

2014-11-06 Thread Helin Zhang
As e1000, ixgbe and i40e hardware use different sizes of redirection table in PF or VF, ethdev and PMDs need to be reworked to support multiple sizes of that table. In addition, commands in testpmd also need to be reworked to support these changes. v2 changes: * Reorganized the patches. * Added co

[dpdk-dev] [PATCH v2] eal: map uio resources after hugepages when the base_virtaddr is configured.

2014-11-06 Thread lxu
--- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c index 7e62266..a591da3 100644 --- a/lib/librte_eal/linuxapp/eal/eal

[dpdk-dev] Bugs in newest patches

2014-11-06 Thread Thomas Monjalon
Hi, 2014-11-07 05:21, Keunhong Lee: > I just pulled new patches from the master branch, and found that it doesn't > work with C++. > > in lib/librte_eal/common/include/generic/rte_cycles.h > +#ifdef __cplusplus > +extern "C" { > +#endif It's already included in lib/librte_eal/common/include/arc

[dpdk-dev] Cannot run l3fwd

2014-11-06 Thread Thomas Monjalon
Hi, You replied to an email which is absolutely not related to your question, polluting the thread. Don't take me wrong: I don't want you to re-post your question in a new thread. You have the source code of DPDK and you didn't check where the error is, not enabled the debug logs. So, it's clearly

[dpdk-dev] 答复: [PATCH] Add user defined tag calculation callback tolibrte_distributor.

2014-11-06 Thread jigsaw
Hi Bruce, Actually IMHO it is good to leave the freedom to user to decide how to interpret the tag value, i.e. remove the OR 1 bit. If the tag value is zero, then we assume the programmer know what he is doing. Of course this shall be clearly documented in the comment/doxgen. thx & rgds, -qingla

[dpdk-dev] [PATCH v3 5/5] i40e: support of configurable VF crc stripping

2014-11-06 Thread Helin Zhang
Configurable CRC stripping needs to be supported in VF, and the configuration should be finally set in relevant RX queue context with PF host support. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e_ethdev_vf.c | 155 +-- lib/librte_pmd_i40e/i40e_pf.c

[dpdk-dev] [PATCH v3 4/5] i40e: support of configurable crc stripping in rx queue

2014-11-06 Thread Helin Zhang
Support of configurable crc stripping in context of VF RX queues. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e_pf.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) v2 changes: * Put setting the crc stripping into a single patch. v3 changes: * Added an input paramet

[dpdk-dev] [PATCH v3 3/5] i40e: renaming and code style fix

2014-11-06 Thread Helin Zhang
Rename some local variables to express more accurately and briefly. Fix several code style issues reported by checkpatch.pl. Line warpping for some source lines which has more than 80 characters, and merge lines together for those source lines which does not need any line wrapping actually. Add mac

[dpdk-dev] [PATCH v3 2/5] i40evf: Remove 'host_is_dpdk', and use version number instead

2014-11-06 Thread Helin Zhang
API version number is straightfoward enough for checking the PF host, and no need to use 'host_is_dpdk'. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e_ethdev.h| 3 ++- lib/librte_pmd_i40e/i40e_ethdev_vf.c | 29 +++-- 2 files changed, 17 insertions(+), 15 de

[dpdk-dev] [PATCH v3 1/5] config: remove useless i40e items in config files

2014-11-06 Thread Helin Zhang
Remove 'CONFIG_RTE_LIBRTE_I40E_PF_DISABLE_STRIP_CRC' from config files, as nowhere uses it. Signed-off-by: Helin Zhang --- config/common_bsdapp | 1 - config/common_linuxapp | 1 - 2 files changed, 2 deletions(-) diff --git a/config/common_bsdapp b/config/common_bsdapp index 9dc9f56..57cad76

[dpdk-dev] [PATCH v3 0/5] support of configurable CRC stripping in VF

2014-11-06 Thread Helin Zhang
To support configurable CRC stripping in both PF host and VF, a new operation and a new structure are added to carry more configurations from VF to PF host. v2 changes: * Put all the renaming and code style fixes into a patch. * Put processing crc stripping configuration in PF host into a single

[dpdk-dev] [PATCH] librte_vhost: Fix the path test issue

2014-11-06 Thread Xie, Huawei
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun > Sent: Monday, November 03, 2014 1:12 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] librte_vhost: Fix the path test issue > > Commit aec8283d47d4e4366b6 fixes the compilation issue,

[dpdk-dev] [PATCH] librte_vhost: Fix the path test issue

2014-11-06 Thread Xie, Huawei
> -Original Message- > From: Ouyang, Changchun > Sent: Wednesday, November 05, 2014 10:20 PM > To: Xie, Huawei; dev at dpdk.org > Cc: Ouyang, Changchun > Subject: RE: [dpdk-dev] [PATCH] librte_vhost: Fix the path test issue > > Hi Huawei, > Thanks for the comments, > And my response as f

[dpdk-dev] Max throughput Using QOS Scheduler

2014-11-06 Thread Dumitrescu, Cristian
Hi Srikanth, >>Is there any difference between scheduler behavior for above two scenarios >>while enqueing and de-queueing ?? All the pipe queues share the bandwidth allocated to their pipe. The distribution of available pipe bandwidth between the pipe queues is governed by features like traf

[dpdk-dev] [TEST] lib/librte_pmd_vhost: Add vhost pmd

2014-11-06 Thread Tetsuya Mukawa
Addition: The patch was written just for testing vhost-user extension patches. So it has a lot of issues now. Thanks, Tetsuya

[dpdk-dev] [TEST] lib/librte_pmd_vhost: Add vhost pmd

2014-11-06 Thread Tetsuya Mukawa
The vhost pmd is a poll mode driver using librte_vhost library. It is almost similar to a relation between librte_ring and ring pmd. Here is a command example of QEMU(above 2.1) to communicate with the vhost pmd. qemu-system-x86_64 -M pc-1.0 -cpu host -m 4096 \ -object memory-backend-file

[dpdk-dev] [TEST] vhost pmd for testing vhost-user

2014-11-06 Thread Tetsuya Mukawa
Hi Xie, I've written vhost PMD to test vhost-user. This patch may be useful when you test vhost-user. Here are steps when I test vhost-user. 1. Start testpmd on the host $ sudo ./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 1 -m 1024 \ --vdev 'eth_vhost0,iface=/tmp/virtq0' \ --

[dpdk-dev] [RFC PATCH 7/7] lib/librte_vhost: Add vhost-user implementation

2014-11-06 Thread Tetsuya Mukawa
This patch adds vhost-user implementation to librte_vhost. To communicate with vhost-user of QEMU, speficy VHOST_DRV_USER as a vhost_driver_type_t variable in rte_vhost_driver_register(). Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/rte_virtio_net.h | 19 +- lib/librte_vhost/vhost-net-us

[dpdk-dev] [RFC PATCH 6/7] lib/librte_vhost: Add vhost-cuse/user specific initialization

2014-11-06 Thread Tetsuya Mukawa
Initialization of vhost-cuse and vhost-user are different. To call each initialization, the patch is needed. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/virtio-net-cdev.c | 12 +++- lib/librte_vhost/virtio-net.c | 13 ++--- 2 files changed, 21 insertions(+), 4 deletio

[dpdk-dev] [RFC PATCH 5/7] lib/librte_vhost: Add a vhost session abstraction

2014-11-06 Thread Tetsuya Mukawa
Vhost session relates vhost communication layer to virtio-net device layer. Because vhost-cuse and vhost-user have different session information, the patch is needed. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/rte_virtio_net.h | 2 +- lib/librte_vhost/vhost-net-cdev.c | 8 lib

[dpdk-dev] [RFC PATCH 4/7] lib/librte_vhost: Move vhost vhost-cuse device list and accessor functions

2014-11-06 Thread Tetsuya Mukawa
vhost-cuse and vhost-user should have a independent device list. This patch moves vhost-cuse device list and list accessor functions to 'virtio-net-cdev.c'. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/vhost-net-cdev.c | 1 + lib/librte_vhost/vhost-net.h | 5 +- lib/librte_vhost

[dpdk-dev] [RFC PATCH 3/7] lib/librte_vhost: Add an abstraction layer tointerpret messages

2014-11-06 Thread Tetsuya Mukawa
This patch adds an abstraction layer to interpret messages from QEMU. This abstraction layer is needed because there are differences in message formats between vhost-cuse and vhost-user. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/vhost-net-cdev.c | 2 +- lib/librte_vhost/vhost-net.h

[dpdk-dev] [RFC PATCH 2/7] lib/librte_vhost: Add an abstraction layer for vhost backends

2014-11-06 Thread Tetsuya Mukawa
The patch adds an abstraction layer for vhost backends. So far CUSE is the only one vhost backend. But QEMU-2.1 can have one more backend called vhost-user. To handle both backends, this kind of layer is needed. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/Makefile | 2 +- lib/li

[dpdk-dev] [RFC PATCH 1/7] lib/librte_vhost: Fix host_memory_map() to handle various memory regions

2014-11-06 Thread Tetsuya Mukawa
Without this patch, host_memory_map() can only handle a region that exists on head of a guest physical memory. The patch fixes the host_memory_map() to handle regions exist on middle of the physical memory. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/virtio-net.c | 7 --- 1 file chang

[dpdk-dev] [RFC PATCH 0/7] lib/librte_vhost: Add vhost-user extension

2014-11-06 Thread Tetsuya Mukawa
Hi Xie, Here are RFC patches to add vhost-user extension to librte_vhost. It seems now you are merging a patch that fixes coding style of librte_vhost. Unfortunately my patches based on latest tree, so I will submit again after your patch is acked. Because of this, I haven't check coding style st

[dpdk-dev] 答复: [PATCH] Add user defined tag calculation callback tolibrte_distributor.

2014-11-06 Thread jigsaw
Hi Bruce, In my use case, unfortunately the tag is not hash. And the tag can be on either low or high bits, depending on configuration. I wonder if it is possible to let the user to decide which bit to mask, i.e. to add another param to rte_distributor_create to define the mask. thx & rgds, -qing

[dpdk-dev] [RFC PATCH] Adding RTE_KNI_PREEMPT configuration option

2014-11-06 Thread Marc Sune
Hi guys, Any comment, suggestion or objection to this patch? Otherwise I would send a non-RFC patch Thanks Marc On 05/11/14 01:17, Marc Sune wrote: > This patch introduces CONFIG_RTE_KNI_PREEMPT flag. When set to 'no', KNI > kernel thread(s) do not call schedule_timeout_interruptible(), which i

[dpdk-dev] [PATCH] ADD mode 5(tlb) to link bonding pmd

2014-11-06 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Daniel Mrzyglod > Sent: Wednesday, September 17, 2014 11:01 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] ADD mode 5(tlb) to link bonding pmd > > This patch set adds support of mode 5 to link bonding

[dpdk-dev] UDP Checksum

2014-11-06 Thread Alex Markuze
I was setting both ip and udp scum fields to 0. PKT_TX_UDP_CKSUM == PKT_TX_L4_MASK = 0x6000. I was not aware of the get_ipv4_psd_sum(ipv4_hdr); And I'm quite frankly surprised the HW doesn't already do this. Farther more I don't remember kernel drivers messing with L3 Headers(bnx2x/mlx4). Is this

[dpdk-dev] Max throughput Using QOS Scheduler

2014-11-06 Thread Srikanth Akula
Hi Cristian, Thank you very much for your points and it should really help me in fixing few issues we might have. thanks again ! Regards, srikanth On Thu, Nov 6, 2014 at 12:37 PM, Dumitrescu, Cristian < cristian.dumitrescu at intel.com> wrote: > Hi Srikanth, > > > > >>Is there any differenc

[dpdk-dev] UDP Checksum

2014-11-06 Thread Alex Markuze
Hi, I'm seeing "UDP: bad checksum." messages(dmesg) for packets sent by my dpdk app to a socket on a remote machine. Looking at the packets the scum value is set, its just not what wireshark expects. When sending I'm setting these fields in the egress packets. pkt->pkt.vlan_macip.f.l2_len

[dpdk-dev] Could virtio-net-pmd co-exist with virtio-net.ko?

2014-11-06 Thread GongJinrong
Hi, Matthew, Thanks a lot, I will try it. -Original Message- From: Matthew Hall [mailto:mh...@mhcomputing.net] Sent: Thursday, November 06, 2014 4:21 PM To: GongJinrong Cc: dev at dpdk.org Subject: Re: [dpdk-dev] Could virtio-net-pmd co-exist with virtio-net.ko? On Thu, Nov 06, 2014 at 1

[dpdk-dev] [PATCH v5] eal: map uio resources after hugepages when the base_virtaddr is configured.

2014-11-06 Thread Bruce Richardson
On Thu, Nov 06, 2014 at 04:10:15PM +, Burakov, Anatoly wrote: > Well, removing --base-virtaddr is not what I'm asking about. > > The issue at hand here is that, given our secondary process mechanism (that > you don't like :-) ), some stuff may be attempted to be mapped into space a > seconda

[dpdk-dev] UDP Checksum

2014-11-06 Thread Olivier MATZ
Hello, On 11/06/2014 05:05 PM, Alex Markuze wrote: > I'm seeing "UDP: bad checksum." messages(dmesg) for packets sent by my dpdk > app to a socket on a remote machine. > Looking at the packets the scum value is set, its just not what wireshark > expects. > > When sending I'm setting these fields

[dpdk-dev] UDP Checksum

2014-11-06 Thread Ananyev, Konstantin
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, November 06, 2014 5:04 PM > To: Ananyev, Konstantin > Subject: FW: [dpdk-dev] UDP Checksum > > > > From: Alex Markuze [mailto:alex at weka.io] > Sent: Thursday, November 06, 2014 4:27 PM > To: Ananyev, Konstantin > Cc:

[dpdk-dev] Valgrind and DPDK - does it work ?

2014-11-06 Thread Matthew Hall
On Fri, Nov 07, 2014 at 01:22:49AM +0100, Marc Sune wrote: > Found some time to have a close look. I also wanted to check a DPDK app > against valgrind. It works! > > I downloaded and compiled valgrind from sources (3.10.0) and applied > (manually) this patch: > > https://bugs.kde.org/attachment.

[dpdk-dev] [PATCH v5] eal: map uio resources after hugepages when the base_virtaddr is configured.

2014-11-06 Thread Thomas Monjalon
2014-11-06 15:41, Burakov, Anatoly: > Thomas, do we need to do similar changes to VFIO code, to keep consistency? > Also, do we really need for this to depend on --base-virtaddr? Why not do it > unconditionally, i.e. map PCI resources right after hugepages in memory? I don't really like the second

[dpdk-dev] vmware vmxnet3-usermap AND DPDK VMXNET3 PMD

2014-11-06 Thread Aziz Hajee
I am using the dpdk1.6.0r1 I could not find a complete clarification, sorry if missed. VMXNET3 PMD I have enabled the VMXNET3 PMD in the dpdk. # Compile burst-oriented VMXNET3 PMD driver # CONFIG_RTE_LIBRTE_VMXNET3_PMD=y CONFIG_RTE_LIBRTE_VMXNET3_DEBUG_INIT=y CONFIG_RTE_LIBRTE_VMXN

[dpdk-dev] Panic in rte MEMPOOL__mempool_check_cookies()

2014-11-06 Thread Kamraan Nasim
Greetings, I have been hitting this issue fairly consistently for the ixgbe driver MEMPOOL: obj=0x7ffeed1f5d00, mempool=0x7ffeecb69bc0, cookie=badbadbadadd2e55 PANIC in __mempool_check_cookies(): MEMPOOL: bad header cookie (get) It seems to be a corruption in the mempool bound to my ixgbe port.

[dpdk-dev] UDP Checksum

2014-11-06 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Alex Markuze > Sent: Thursday, November 06, 2014 4:05 PM > To: dev at dpdk.org > Subject: [dpdk-dev] UDP Checksum > > Hi, > I'm seeing "UDP: bad checksum." messages(dmesg) for packets sent by my dpdk > app to

[dpdk-dev] [PATCH v4] eal: map uio resources after hugepages when the base_virtaddr is configured.

2014-11-06 Thread Thomas Monjalon
No explanation -> I won't review it. No signed-off-by -> I'll ignore it. Maybe your patch is useful, maybe not. I cannot know. -- Thomas

[dpdk-dev] [PATCH v5] eal: map uio resources after hugepages when the base_virtaddr is configured.

2014-11-06 Thread Burakov, Anatoly
Well, removing --base-virtaddr is not what I'm asking about. The issue at hand here is that, given our secondary process mechanism (that you don't like :-) ), some stuff may be attempted to be mapped into space a secondary process may already have mapped something else into (some libraries, for

[dpdk-dev] [PATCH v3 0/5] support of configurable CRC stripping in VF

2014-11-06 Thread Ananyev, Konstantin
> From: Zhang, Helin > Sent: Thursday, November 06, 2014 12:54 PM > To: dev at dpdk.org > Cc: Cao, Waterman; Cao, Min; Ananyev, Konstantin; Zhang, Helin > Subject: [PATCH v3 0/5] support of configurable CRC stripping in VF > > To support configurable CRC stripping in both PF host > and VF, a new

[dpdk-dev] [PATCH v5] eal: map uio resources after hugepages when the base_virtaddr is configured.

2014-11-06 Thread Burakov, Anatoly
The explanation of the patch should be generic and impartial, i.e. when this and this happens, it results in such and such problem, and this patch fixes it by doing this and that. In other words, this will appear in the git history, so whoever is reading the commit log will be able to figure out

[dpdk-dev] [PATCH v3] eal: map uio resources after hugepages when the base_virtaddr is configured.

2014-11-06 Thread De Lara Guarch, Pablo
Include at least signoff. > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of lxu > Sent: Thursday, November 06, 2014 2:47 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v3] eal: map uio resources after hugepages > when the base_virtaddr is configured. >

[dpdk-dev] [PATCH v3 4/5] virtio: New API for promisc and allmulticast

2014-11-06 Thread Thomas Monjalon
2014-10-31 13:19, Ouyang Changchun: > Add new API in virtio for supporting promiscuous and allmulticast enable and > disable. It's not a new API because there is no difference for application programming. It should be something like "virtio: support promiscuous and allmulticast" -- Thomas

[dpdk-dev] [PATCH v3] eal: map uio resources after hugepages when the base_virtaddr is configured.

2014-11-06 Thread Burakov, Anatoly
+ requested_addr = (uint8_t *)mapaddr + maps[j].size; RTE_PTR_ADD? Thanks, Anatoly -Original Message- From: lxu [mailto:liang...@cinfotech.cn] Sent: Thursday, November 6, 2014 2:47 PM To: dev at dpdk.org Cc: Burakov, Anatoly Subject: [PATCH v3] eal

[dpdk-dev] [PATCH v3 3/5] ixgbe: Config PFVML2FLT register

2014-11-06 Thread Thomas Monjalon
Title would be more high level. Example: "ixgbe: configure Rx mode for VMDQ" 2014-10-31 13:19, Ouyang Changchun: > + for (i = 0; i < (int)num_pools; i++) { > + if (cfg->rx_mode & ETH_VMDQ_ACCEPT_UNTAG) > + vmolr |= IXGBE_VMOLR_AUPE; > + if (cfg->rx_m

[dpdk-dev] [PATCH v3 1/5] ethdev: add vmdq rx mode

2014-11-06 Thread Thomas Monjalon
2014-10-31 13:19, Ouyang Changchun: > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -577,6 +577,7 @@ struct rte_eth_vmdq_rx_conf { > uint8_t default_pool; /**< The default pool, if applicable */ > uint8_t enable_loop_back; /**< Enable VT loop back */ >

[dpdk-dev] Cannot run l3fwd

2014-11-06 Thread Eduard Gibert Renart
Hi Everyone: When I try to run l3fwd inside my VM I get the following error: ubuntu at ubuntu-VirtualBox:~/Desktop/dpdk-1.7.1/examples/l3fwd/build$ sudo ./l3fwd -c 0x3 -n 2 -- -p 0x3 --config="(0,0,0),(1,0,1)" EAL: Cannot read numa node link for lcore 0 - using physical package id instead EAL: D

[dpdk-dev] 答复: [PATCH] Add user defined tag calculation callback tolibrte_distributor.

2014-11-06 Thread Qinglai Xiao
Hi Bruce, There is a subtle case in which tag values are 2 and 3, respectively. Then these two tags cannot be distinguished. There should be a better way so as to handle this situation. thx & rgds -qinglai -- ???: "Thomas Monjalon" : ?2014/?11/?6 12:36 ???: "Bruce Richardson"

[dpdk-dev] [PATCH v8 10/10] app/testpmd:test VxLAN Tx checksum offload

2014-11-06 Thread Liu, Jijiang
Hi Olivier, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Thursday, November 6, 2014 9:09 PM > To: Liu, Jijiang > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 10/10] app/testpmd:test VxLAN Tx checksum > offload > > Hello Jijiang, > > On 1

[dpdk-dev] [PATCH v2] eal: map uio resources after hugepages when the base_virtaddr is configured.

2014-11-06 Thread Burakov, Anatoly
Few nitpicks. Static variables are always initialized to 0, so "= NULL" isn't necessary, a declaration will suffice. Also, we have a macro RTE_PTR_ADD to add numbers to pointers, I think it would be better to use those. Otherwise, looks fine to me. I still feel uneasy about depending on nothing

[dpdk-dev] [PATCH v8 10/10] app/testpmd:test VxLAN Tx checksum offload

2014-11-06 Thread Olivier MATZ
Hello Jijiang, On 11/06/2014 12:24 PM, Liu, Jijiang wrote: >> Is it possible to have a more formal definition? For instance, is the >> following >> definition below correct? >> >> "the PKT_RX_TUNNEL_IPV4_HDR flag CAN be set by a driver if the packet >>contains a tunneling protocol inside an

[dpdk-dev] 答复: [PATCH] Add user defined tag calculation callback tolibrte_distributor.

2014-11-06 Thread Bruce Richardson
On Thu, Nov 06, 2014 at 02:36:09PM +0200, Qinglai Xiao wrote: > Hi Bruce, > > There is a subtle case in which tag values are 2 and 3, respectively. Then > these two tags cannot be distinguished. There should be a better way so as to > handle this situation. It's not just in that, case, it's in

[dpdk-dev] [PATCH] Add user defined tag calculation callback to librte_distributor.

2014-11-06 Thread Bruce Richardson
On Thu, Nov 06, 2014 at 11:36:09AM +0100, Thomas Monjalon wrote: > 2014-11-06 09:22, Bruce Richardson: > > On Wed, Nov 05, 2014 at 07:24:13PM +0200, jigsaw wrote: > > > http://dpdk.org/browse/dpdk/tree/lib/librte_distributor/rte_distributor.c#n285 > > > > > > new_tag = (next_mb->hash.rss |

[dpdk-dev] [PATCH] distributor: add comments to make code more readable

2014-11-06 Thread Bruce Richardson
From: "Bruce Richardson" Add in some additional comments around more complex areas of the code so as to make the code easier to read and understand. Signed-off-by: Bruce Richardson --- lib/librte_distributor/rte_distributor.c | 13 + 1 file changed, 13 insertions(+) diff --git a/l

[dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes

2014-11-06 Thread Huawei Xie
This patchset fixes serious coding style issues in vhost library. Huawei Xie (2): fix alignment, lengthy lines, misordered type and other style issues printk -> pr_debug lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++--- lib/librte_vhost/eventfd_link/eventfd_link.h |

[dpdk-dev] [PATCH] Add user defined tag calculation callback to librte_distributor.

2014-11-06 Thread jigsaw
OK understood. Thanks. -qinglai On Thu, Nov 6, 2014 at 11:22 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Wed, Nov 05, 2014 at 07:24:13PM +0200, jigsaw wrote: > > Hi Bruce, > > > > OK understood. Then there's no real need to make any change. > > But the question remains about

[dpdk-dev] [PATCH] Add user defined tag calculation callback to librte_distributor.

2014-11-06 Thread Thomas Monjalon
2014-11-06 09:22, Bruce Richardson: > On Wed, Nov 05, 2014 at 07:24:13PM +0200, jigsaw wrote: > > http://dpdk.org/browse/dpdk/tree/lib/librte_distributor/rte_distributor.c#n285 > > > > new_tag = (next_mb->hash.rss | 1); > > > > Why the logical OR is needed? > > That's needed to ensure th

[dpdk-dev] [PULL REQUEST] doc: TestPMD Application User Guide.

2014-11-06 Thread Thomas Monjalon
> Bernard Iremonger (1): > doc: TestPMD Application User Guide Pulled in the main repository. This document should now be updated to reflect the recent changes to testpmd. >From now, patches for testpmd should include doc update. Thanks -- Thomas

[dpdk-dev] [PATCH v8 10/10] app/testpmd:test VxLAN Tx checksum offload

2014-11-06 Thread Liu, Jijiang
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Wednesday, November 5, 2014 6:28 PM > To: Liu, Jijiang > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 10/10] app/testpmd:test VxLAN Tx checksum > offload > > Hi Jijiang, > > Thank you for you

[dpdk-dev] Could virtio-net-pmd co-exist with virtio-net.ko?

2014-11-06 Thread GongJinrong
Hi, Guys When I run virtio-net-pmd in VM, I got "virtio-net device is already used by another driver" error message, after I removed the virtio-net.ko, it worked, but now I cannot use the virio-net driver for another virtual NIC, this cost that normal network performance(non-DPDK application)

[dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes

2014-11-06 Thread De Lara Guarch, Pablo
Hi Huawei, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Huawei Xie > Sent: Thursday, November 06, 2014 4:46 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes > > This patchset fixes serious coding style issues

[dpdk-dev] bifurcated driver

2014-11-06 Thread Alex Markuze
Danny sums up the issue perfectly IMHO. While both verbs and DPDK aim to provide generic user space networking, the similarities end there. verbs and RDMA HW are closely coupled and behave differently then standard eth nics and are not related to netdev mechanisms. Or, welcome to this discussion.

[dpdk-dev] bifurcated driver

2014-11-06 Thread Nicolas Dichtel
Also CC netdev, this thread may interest network folks. Le 06/11/2014 09:13, Alex Markuze a ?crit : > Danny sums up the issue perfectly IMHO. > While both verbs and DPDK aim to provide generic user space networking, the > similarities end there. > verbs and RDMA HW are closely coupled and behave d

[dpdk-dev] [PATCH v5 2/5] ethdev: add enum type and relevant structures for hash filter control

2014-11-06 Thread Thomas Monjalon
2014-11-06 03:41, Zhang, Helin: > > > +/** > > > + * A structure used to set or get filter swap information, to support > > > + * 'RTE_ETH_FILTER_HASH', 'RTE_ETH_FILTER_GET/RTE_ETH_FILTER_SET', > > > + * with information type 'RTE_ETH_HASH_FILTER_INFO_TYPE_FILTER_SWAP'. > > > + */ > > > +struct rte

[dpdk-dev] [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix

2014-11-06 Thread Thomas Monjalon
2014-11-06 00:22, Xie, Huawei: > Thomas, comments for this patch? No, but Jing Chen made some comments that you didn't replied: "Please try to use macro to replace numbers." So I wait a v2. > > -Original Message- > > From: Xie, Huawei > > Sent: Saturday, September 27, 2014 10:49 P

[dpdk-dev] [PATCH v4 7/8] ethdev: support of multiple sizes of redirection table

2014-11-06 Thread Thomas Monjalon
2014-11-06 01:02, Zhang, Helin: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2014-10-31 17:03, Helin Zhang: > > > #define ETH_RSS_RETA_SIZE_64 64 > > > #define ETH_RSS_RETA_SIZE_128 128 > > > #define ETH_RSS_RETA_SIZE_512 512 > > > > Are these values still needed? > > It

[dpdk-dev] [PATCH] Add user defined tag calculation callback to librte_distributor.

2014-11-06 Thread Bruce Richardson
On Wed, Nov 05, 2014 at 07:24:13PM +0200, jigsaw wrote: > Hi Bruce, > > OK understood. Then there's no real need to make any change. > But the question remains about this line: > > http://dpdk.org/browse/dpdk/tree/lib/librte_distributor/rte_distributor.c#n285 > > new_tag = (next_mb->hash

[dpdk-dev] [PATCH v5 2/5] ethdev: add enum type and relevant structures for hash filter control

2014-11-06 Thread Zhang, Helin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, November 6, 2014 4:43 PM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 2/5] ethdev: add enum type and relevant > structures for hash filter control > > 2014

[dpdk-dev] [PATCH v4 7/8] ethdev: support of multiple sizes of redirection table

2014-11-06 Thread Zhang, Helin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, November 6, 2014 4:33 PM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 7/8] ethdev: support of multiple sizes of > redirection table > > 2014-11-06 01:02, Z

[dpdk-dev] [PATCH v5 1/5] i40e: Use constant random hash keys

2014-11-06 Thread Zhang, Helin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, November 3, 2014 4:59 PM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 1/5] i40e: Use constant random hash keys > > 2014-11-03 08:18, Zhang, Helin: > > From:

[dpdk-dev] [PATCH 2/2] lib/librte_vhost: printk->pr_debug

2014-11-06 Thread Huawei Xie
printk -> pr_debug Signed-off-by: Huawei Xie --- lib/librte_vhost/eventfd_link/eventfd_link.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_vhost/eventfd_link/eventfd_link.c b/lib/librte_vhost/eventfd_link/eventfd_link.c index 542ec2c..7755dd6 100644

[dpdk-dev] [PATCH 1/2] lib/librte_vhost: code style fixes

2014-11-06 Thread Huawei Xie
fixes alignment issues, lengthy lines, misordered type and other coding style issues. Signed-off-by: Huawei Xie --- lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++--- lib/librte_vhost/eventfd_link/eventfd_link.h | 127 ++- lib/librte_vhost/rte_virtio_net.h

[dpdk-dev] [PATCH 2/2] lib/librte_vhost: printk->pr_debug

2014-11-06 Thread Neil Horman
On Thu, Nov 06, 2014 at 07:31:42AM +0800, Huawei Xie wrote: > printk -> pr_debug > > Signed-off-by: Huawei Xie > --- > lib/librte_vhost/eventfd_link/eventfd_link.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_vhost/eventfd_link/eventfd_link.c >

[dpdk-dev] [PATCH 1/2] lib/librte_vhost: code style fixes

2014-11-06 Thread Neil Horman
On Thu, Nov 06, 2014 at 07:31:41AM +0800, Huawei Xie wrote: > fixes alignment issues, lengthy lines, misordered type and other coding style > issues. > > Signed-off-by: Huawei Xie > --- > lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++--- > lib/librte_vhost/eventfd_link/e

[dpdk-dev] [PATCH] librte_vhost: Fix the path test issue

2014-11-06 Thread Ouyang, Changchun
Hi Huawei, Thanks for the comments, And my response as follows. > -Original Message- > From: Xie, Huawei > Sent: Thursday, November 6, 2014 10:39 AM > To: Ouyang, Changchun; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH] librte_vhost: Fix the path test issue > > > path = r

[dpdk-dev] bifurcated driver

2014-11-06 Thread Zhou, Danny
I roughly read libibverbs related code and relevant infiniband/rdma documents, and found though many concepts in libibverbs looks similar to bifurcated driver, but there are still lots of differences as illustrated below based on my understanding: 1) Queue pair defined in RDMA specification a

[dpdk-dev] [PATCH v5 2/5] ethdev: add enum type and relevant structures for hash filter control

2014-11-06 Thread Zhang, Helin
Thanks for your good comments! > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, November 3, 2014 3:57 PM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 2/5] ethdev: add enum type and relevant > structures for h

[dpdk-dev] [PATCH] librte_vhost: Fix the path test issue

2014-11-06 Thread Xie, Huawei
> path = realpath(memfile, resolved_path); > - if (path == NULL) { > + if ((path == NULL) && (strlen(resolved_path) == 0)) { > RTE_LOG(ERR, VHOST_CONFIG, > "(%"PRIu64") Failed to resolve fd directory\n", >

[dpdk-dev] bifurcated driver

2014-11-06 Thread Vincent JARDIN
+Or On 05/11/2014 23:48, Zhou, Danny wrote: > Hi Thomas, > > Thanks for sharing the links to ibverbs, I will take a close look at it and > compare it to bifurcated driver. My take > after a rough review is that idea is very much similar, but bifurcated driver > implementation is generic for any

[dpdk-dev] [PATCH] lib/librte_vhost: code style fixes

2014-11-06 Thread Huawei Xie
This patch fixes code style issues and refines some comments in vhost library. Signed-off-by: Huawei Xie --- lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++--- lib/librte_vhost/eventfd_link/eventfd_link.h | 127 ++- lib/librte_vhost/rte_virtio_net.h|

  1   2   >