[dpdk-dev] 2nd parameter of driver init function can be NULL using latest code

2015-02-19 Thread Tetsuya Mukawa
Hi, It seems after applying below patch, 2nd parameter of PMD initialization code can be NULL when vdev option is like below. commit c07691ae10894bb6bf284fed75829b95844eacdb devargs: remove limit on parameters length Here is example vdev option --vdev

[dpdk-dev] [PATCH] Fix compilation error when compiling with clang-3.4 in C++11 mode: in C++11 concatenated string literals need to have a space in between.

2015-02-19 Thread Stefan Puiu
From: Stefan Puiu Sample error message: dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal] --- lib/librte_eal/common/include/rte_pci.h |4 ++-- 1 file changed, 2

[dpdk-dev] [PATCH] Fix C++11 compilation error with rte_pci.h

2015-02-19 Thread Stefan Puiu
In C++11 concatenated string literals need to have a space in between. Found while trying to compile with clang++-3.4. Sample error message: dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]

[dpdk-dev] [PATCH v9 13/14] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-19 Thread Tetsuya Mukawa
On 2015/02/19 22:30, Tetsuya Mukawa wrote: > On 2015/02/19 21:10, Thomas Monjalon wrote: >> 2015-02-19 11:49, Tetsuya Mukawa: >>> +/* attach the new virtual device, then store port_id of the device */ >>> +static int >>> +rte_eal_dev_attach_vdev(const char *vdevargs, uint8_t *port_id) >>> +{ >>> +

[dpdk-dev] [PATCH v9 08/14] ethdev: Add functions that will be used by port hotplug functions

2015-02-19 Thread Tetsuya Mukawa
On 2015/02/19 20:24, Thomas Monjalon wrote: > 2015-02-19 11:49, Tetsuya Mukawa: >> --- a/lib/librte_ether/rte_ether_version.map >> +++ b/lib/librte_ether/rte_ether_version.map >> @@ -109,6 +109,13 @@ DPDK_2.0 { >> rte_eth_tx_queue_setup; >> rte_eth_xstats_get; >>

[dpdk-dev] [PATCH v9 02/14] eal_pci: Add flag to hold kernel driver type

2015-02-19 Thread Tetsuya Mukawa
On 2015/02/19 20:17, Thomas Monjalon wrote: >> @@ -152,6 +159,7 @@ struct rte_pci_device { >> uint16_t max_vfs; /**< sriov enable if not zero */ >> int numa_node; /**< NUMA node connection */ >> struct rte_devargs *devargs;

[dpdk-dev] Binding NICs while running DPDK app

2015-02-19 Thread Daniele Di Proietto
Hi, I would like to implement a scenario like the following: - Some NICs are bound to the igb_uio driver - A DPDK application is started and it sends/receives packet to/from those NICs. - Another set of NICs are bound to the igb_uio driver. - The same DPDK application continues processing

[dpdk-dev] [PATCH v4 5/5] l3fwd-power: enable one-shot rx interrupt and polling/interrupt mode switch

2015-02-19 Thread Zhou Danny
v3 changes - Add spinlock to ensure thread safe when accessing interrupt mask register v2 changes - Remove unused function which is for debug purpose Demonstrate how to handle per rx queue interrupt in a NAPI-like implementation in usersapce. PDK polling thread mainly works in polling mode and

[dpdk-dev] [PATCH v4 4/5] eal: add per rx queue interrupt handling based on VFIO

2015-02-19 Thread Zhou Danny
v4 changes: - Adjust position of new-added structure fields v3 changes: - Fix review comments v2 changes: - Fix compilation issue for a missed header file - Bug fix: free unreleased resources on the exception path before return - Consolidate coding style related review comments This patch does

[dpdk-dev] [PATCH v4 3/5] igb: enable rx queue interrupts for PF

2015-02-19 Thread Zhou Danny
v3 changes - Remove unnecessary variables in e1000_mac_info - Remove spinlok from PMD v2 changes - Consolidate review comments related to coding style The patch does below for igb PF: - Setup NIC to generate MSI-X interrupts - Set the IVAR register to map interrupt causes to vectors - Implement

[dpdk-dev] [PATCH v4 2/5] ixgbe: enable rx queue interrupts for both PF and VF

2015-02-19 Thread Zhou Danny
v3 changes - Remove spinlok from PMD v2 changes - Consolidate review comments related to coding style The patch does below things for ixgbe PF and VF: - Setup NIC to generate MSI-X interrupts - Set the IVAR register to map interrupt causes to vectors - Implement interrupt enable/disable

[dpdk-dev] [PATCH v4 1/5] ethdev: add rx interrupt enable/disable functions

2015-02-19 Thread Zhou Danny
v4 changes - Export interrupt enable/disable functions for shared libraries - Put new functions at the end of eth_dev_ops to avoid breaking ABI v3 changes - Add return value for interrupt enable/disable functions Add two dev_ops functions to enable and disable rx queue interrupts Signed-off-by:

[dpdk-dev] [PATCH v4 0/5] Interrupt mode PMD

2015-02-19 Thread Zhou Danny
v4 changes - Export interrupt enable/disable functions for shared libraries - Adjust position of new-added structure fields and functions to avoid breaking ABI v3 changes - Add return value for interrupt enable/disable functions - Move spinlok from PMD to L3fwd-power - Remove unnecessary

[dpdk-dev] [PATCH v9 2/2] librte_pmd_null: Support port hotplug function

2015-02-19 Thread Tetsuya Mukawa
This patch adds port hotplug support to Null PMD. v9: - Use rte_eth_dev_release_port() instead of rte_eth_dev_free(). v7: - Add parameter checkings. (Thanks to Iremonger, Bernard) v6: - Fix a parameter of rte_eth_dev_free(). v4: - Fix commit title. Signed-off-by: Tetsuya Mukawa ---

[dpdk-dev] [PATCH v9 1/2] librte_pmd_null: Add Null PMD

2015-02-19 Thread Tetsuya Mukawa
Null PMD is a driver of the virtual device particularly designed to measure performance of DPDK PMDs. When an application call rx, Null PMD just allocates mbufs and returns those. Also tx, the PMD just frees mbufs. The PMD has following options. - size: specify packe size allocated by RX. Default

[dpdk-dev] [PATCH v3 6/6] bond: add unit tests for link bonding mode 6.

2015-02-19 Thread Michal Jastrzebski
From: Maciej Gajdzica Added 4 unit tests checking link bonding mode 6 behavior. Also modified virtual_pmd so it is possible to provide packets, that should be received with rx_burst and to inspect packets transmitted by tx_burst. In packet_burst_generator.c

[dpdk-dev] [PATCH v3 5/6] bond: modify TLB unit tests

2015-02-19 Thread Michal Jastrzebski
From: Daniel Mrzyglod This patch modify mode older name from BONDING_MODE_ADAPTIVE_TRANSMIT_LOAD_BALANCING to BONDING_MODE_TLB This patch also changes order of TEST_ASSERT macro in test_tlb_verify_slave_link_status_change_failover. Signed-off-by: Daniel Mrzyglod

[dpdk-dev] [PATCH v3 4/6] bond: add example application for link bonding mode 6

2015-02-19 Thread Michal Jastrzebski
This patch contains an example for link bonding mode 6. It interact with user by a command prompt. Available commands are: Start - starts ARP_thread which respond to ARP_requests and sends ARP_updates (this Is enabled by default after startup), Stop -stops ARP_thread, Send count ip - send count

[dpdk-dev] [PATCH v3 3/6] bond: add debug info for mode 6 link bonding

2015-02-19 Thread Michal Jastrzebski
This patch add some debug information when using link bonding mode 6. It prints basic information about ARP packets on RX and TX (MAC, ip, packet number, arp packet type). If CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB == y. If CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB_L1 is enabled instead of previous one, use show

[dpdk-dev] [PATCH v3 2/6] bond: add link bonding mode 6 implementation

2015-02-19 Thread Michal Jastrzebski
From: Maciej Gajdzica This mode includes adaptive TLB and receive load balancing (RLB). In RLB the bonding driver intercepts ARP replies send by local system and overwrites its source MAC address, so that different peers send data to the server on different slave

[dpdk-dev] [PATCH v3 1/6] net: changed arp_hdr struct declaration

2015-02-19 Thread Michal Jastrzebski
From: Maciej Gajdzica Changed MAC address type from uint8_t[6] to struct ether_addr and IP address type from uint8_t[4] to uint32_t. Also removed union from arp_hdr struct. Updated test-pmd to match new arp_hdr version. Signed-off-by: Maciej Gajdzica ---

[dpdk-dev] [PATCH v3 0/6] Link Bonding mode 6 support (ALB)

2015-02-19 Thread Michal Jastrzebski
v3 changes: - completed description for mode 5 unit tests patch - fixed errors required by checkpatch.pl - moved patch version changes from patches to cover-letter v2 changes: in mode 6 patch 2/6: - add VLAN support - fixed sending duplicated ARPupdates - fixed assigning slaves for next clients -

[dpdk-dev] [PATCH v4 3/3] examples: example showing use of callbacks.

2015-02-19 Thread John McNamara
From: Richardson, Bruce Example showing how callbacks can be used to insert a timestamp into each packet on RX. On TX the timestamp is used to calculate the packet latency through the app, in cycles. Signed-off-by: Bruce Richardson Signed-off-by: John McNamara ---

[dpdk-dev] [PATCH v4 2/3] ethdev: add optional rxtx callback support

2015-02-19 Thread John McNamara
From: Richardson, Bruce Add optional support for inline processing of packets inside the RX or TX call. For an RX callback, what happens is that we get a set of packets from the NIC and then pass them to a callback function, if configured, to allow additional

[dpdk-dev] [PATCH v4 1/3] ethdev: rename callbacks field to link_intr_cbs

2015-02-19 Thread John McNamara
From: Richardson, Bruce The 'callbacks' member of the rte_eth_dev structure has been renamed to 'link_intr_cbs' to make it clear that it refers to callbacks from NIC interrupts. This allows us to add other types of callbacks to the structure without ambiguity.

[dpdk-dev] [PATCH v4 0/3] DPDK ethdev callback support

2015-02-19 Thread John McNamara
This patchset is for a small optional addition to the ethdev library, to add support for callbacks at the RX and TX stages. This allows packet processing to be done on packets before they get returned to applications using rte_eth_rx_burst call. See the RFC cover letter for the use cases:

[dpdk-dev] [PATCH] ACL: use setjmp/longjmp to handle memory allocation failure at build phase

2015-02-19 Thread Konstantin Ananyev
During build phase ACL doing quite a lot of memory allocations for relatively small temporary structures. In theory each of such allocation can fail, so we need to handle all these possible failures. That adds a lot of extra checks and makes the code harder to read and follow. To simplify the

[dpdk-dev] [PATCH v4 7/7] pmd ixgbe: fix vlan setting in in PF

2015-02-19 Thread Pawel Wodkowski
The ixgbe_vlan_filter_set() should use hw->mac.ops.set_vfta() to set VLAN filtering as this is generic function that handles both non-SRIOV and SRIOV cases. Bug was discovered issuing command in testpmd 'rx_vlan add VLAN PORT' for PF. Requested VLAN was enabled but pool mask is not set. Only

[dpdk-dev] [PATCH v4 6/7] tespmd: fix DCB in SRIOV mode support

2015-02-19 Thread Pawel Wodkowski
This patch incorporate fixes to support DCB in SRIOV mode for testpmd. Signed-off-by: Pawel Wodkowski --- app/test-pmd/cmdline.c | 4 ++-- app/test-pmd/testpmd.c | 39 +-- app/test-pmd/testpmd.h | 10 -- 3 files changed, 31 insertions(+), 22

[dpdk-dev] [PATCH v4 5/7] pmd ixgbe: enable DCB in SRIOV

2015-02-19 Thread Pawel Wodkowski
Enable DCB in SRIOV mode for ixgbe driver. To use DCB in VF PF must configure port as DCB + VMDQ and VF must configure port as DCB only. VF are not allowed to change DCB settings that are common to all ports like number of TC. Signed-off-by: Pawel Wodkowski ---

[dpdk-dev] [PATCH v4 4/7] move rte_eth_dev_check_mq_mode() logic to driver

2015-02-19 Thread Pawel Wodkowski
Function rte_eth_dev_check_mq_mode() is driver specific. It should be done in PF configuration phase. This patch move igb/ixgbe driver specific mq check and SRIOV configuration code to driver part. Also rewriting log messages to be shorter and more descriptive. Signed-off-by: Pawel Wodkowski ---

[dpdk-dev] [PATCH v4 3/7] pmd: igb/ixgbe split nb_q_per_pool to rx and tx nb_q_per_pool

2015-02-19 Thread Pawel Wodkowski
rx and tx number of queue might be different if RX and TX are configured in different mode. This allow to inform VF about proper number of queues. Signed-off-by: Pawel Wodkowski --- lib/librte_ether/rte_ethdev.c | 12 ++-- lib/librte_ether/rte_ethdev.h | 3 ++-

[dpdk-dev] [PATCH v4 2/7] pmd igb: fix VMDQ mode checking

2015-02-19 Thread Pawel Wodkowski
RX mode is an enum created by ORing flags. Change compare by value to test a flag when enabling/disabling VLAN filtering during RX queue setup. Signed-off-by: Pawel Wodkowski --- lib/librte_pmd_e1000/igb_ethdev.c | 2 +- lib/librte_pmd_e1000/igb_rxtx.c | 2 +- 2 files changed, 2

[dpdk-dev] [PATCH v4 1/7] ethdev: Allow zero rx/tx queues in SRIOV mode

2015-02-19 Thread Pawel Wodkowski
Allow zero rx/tx queues to be passed to rte_eth_dev_configure(). This way PF might be used only for configuration purpose when no receive and/or transmit functionality is needed. Rationale: in SRIOV mode PF use first free VF to RX/TX (at least ixgbe based NICs). For example: if using 82599EB

[dpdk-dev] [PATCH v4 0/7] Enable DCB in SRIOV mode for ixgbe driver

2015-02-19 Thread Pawel Wodkowski
This patchset enables DCB in SRIOV (ETH_MQ_RX_VMDQ_DCB and ETH_MQ_TX_VMDQ_DCB) for each VF and PF for ixgbe driver. As a side effect this allow to use multiple queues for TX in VF (8 if there is 16 or less VFs or 4 if there is 32 or less VFs) when PFC is not enabled. PATCH v4 changes: - resend

[dpdk-dev] i40e and RSS woes

2015-02-19 Thread Gleb Natapov
CCing i40e driver author in a hope to get an answer. On Mon, Feb 16, 2015 at 03:36:54PM +0200, Gleb Natapov wrote: > I have an application that works reasonably well with ixgbe driver, but > when I try to use it with i40e I encounter various RSS related issues. > > First one is that for some

[dpdk-dev] [PATCH v1 1/3] eal: enable uio_pci_generic support

2015-02-19 Thread Zhou, Danny
Thomas, thanks for review and I added comments inline. > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, February 18, 2015 9:40 PM > To: Zhou, Danny > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 1/3] eal: enable

[dpdk-dev] [PATCH v6 0/7] rte_hash_crc reworked to be platform-independent

2015-02-19 Thread Bruce Richardson
On Mon, Feb 02, 2015 at 11:39:18AM +0600, Yerden Zhumabekov wrote: > > 02.02.2015 9:31, Neil Horman ?: > > On Mon, Feb 02, 2015 at 09:07:45AM +0600, Yerden Zhumabekov wrote: > > > >> I think so, I've just successfully built it against latest snapshot with > >> RTE_TARGET > >> equal to

[dpdk-dev] Patches outstanding

2015-02-19 Thread O'driscoll, Tim
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, February 19, 2015 1:47 PM > To: Neil Horman > Cc: dev at dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] Patches outstanding > > 2015-02-19 08:08, Neil Horman: > > On

[dpdk-dev] [PATCH 6/6] examples: remove unneeded casts

2015-02-19 Thread Bruce Richardson
On Sat, Feb 14, 2015 at 09:59:10AM -0500, Stephen Hemminger wrote: > *alloc() routines return void * and therefore cast is not needed. > > Signed-off-by: Stephen Hemminger > --- > examples/kni/main.c | 4 ++-- > examples/l3fwd-acl/main.c | 4 ++-- > examples/vhost/main.c | 7 --- >

[dpdk-dev] [PATCH 5/6] eal: remove useless memset

2015-02-19 Thread Bruce Richardson
On Sat, Feb 14, 2015 at 09:59:09AM -0500, Stephen Hemminger wrote: > The path variable is set via snprintf, and does not need to > memset before that. > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson > --- > lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 2 -- > 1 file

[dpdk-dev] [PATCH 4/6] enic: eliminate useless cast

2015-02-19 Thread Bruce Richardson
On Sat, Feb 14, 2015 at 09:59:08AM -0500, Stephen Hemminger wrote: > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson > --- > lib/librte_pmd_enic/enic_clsf.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_pmd_enic/enic_clsf.c

[dpdk-dev] [PATCH 2/6] vhost_xen: remove unnecessary cast

2015-02-19 Thread Bruce Richardson
On Sat, Feb 14, 2015 at 09:59:06AM -0500, Stephen Hemminger wrote: > Don't need to cast malloc family of functions since they return > void *. > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson > --- > examples/vhost_xen/vhost_monitor.c | 2 +- >

[dpdk-dev] [PATCH 1/6] test: remove unneeded casts

2015-02-19 Thread Bruce Richardson
On Sat, Feb 14, 2015 at 09:59:05AM -0500, Stephen Hemminger wrote: > The malloc family returns void * and therefore cast is unnecessary. > Use calloc rather than zmalloc with multiply for array. > > Signed-off-by: Stephen Hemminger Looks like a good basic cleanup Acked-by: Bruce Richardson >

[dpdk-dev] [PATCH v9 12/14] ethdev: Add one dev_type parameter to rte_eth_dev_allocate

2015-02-19 Thread Iremonger, Bernard
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Thursday, February 19, 2015 2:50 AM > To: dev at dpdk.org > Cc: Qiu, Michael; Iremonger, Bernard; thomas.monjalon at 6wind.com; Tetsuya > Mukawa > Subject: [PATCH v9 12/14] ethdev: Add one dev_type

[dpdk-dev] Patches outstanding

2015-02-19 Thread Thomas Monjalon
2015-02-19 08:08, Neil Horman: > On Tue, Feb 17, 2015 at 10:35:07AM -0500, Stephen Hemminger wrote: > > There are currently 1039 patches outstanding on DPDK. > > What is the schedule for getting these merged or resolved? > > I don't think it would be reasonable to declare 2.0 as done > > until the

[dpdk-dev] [PATCH] ixgbe: fix build with gcc 5

2015-02-19 Thread Panu Matilainen
On 02/19/2015 02:02 PM, Ananyev, Konstantin wrote: > Hi Panu, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen >> Sent: Thursday, February 19, 2015 10:25 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] ixgbe: fix build with gcc 5

[dpdk-dev] [PATCH v9 07/14] eal, ethdev: Add a function and function pointers to close ether device

2015-02-19 Thread Iremonger, Bernard
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Thursday, February 19, 2015 2:50 AM > To: dev at dpdk.org > Cc: Qiu, Michael; Iremonger, Bernard; thomas.monjalon at 6wind.com; Tetsuya > Mukawa > Subject: [PATCH v9 07/14] eal,ethdev: Add a function and

[dpdk-dev] mapping lcore – port –queue

2015-02-19 Thread kuldeep.sam...@wipro.com
Hi Team , I am using DPDK-1.7.1 to process my packet faster & trying to understand how physical nic ports are map with lcore . Any suggestion the mapping on lcore ? port ?queue relation & which file I suppose to be follow for mapping . Regards , Kuldeep

[dpdk-dev] [PATCH v2] i40e: fix build with gcc 5

2015-02-19 Thread Panu Matilainen
Eliminate ambiguity in the condition which trips up a "logical not is only applied to the left..." warning from gcc 5, causing build failure with -Werror. Besides non-ambiguous, the condition is far more obvious this way. Signed-off-by: Panu Matilainen --- lib/librte_pmd_i40e/i40e_rxtx.c | 2 +-

[dpdk-dev] [PATCH v5 3/3] MAINTAINERS: claim responsibility for headroom library and example app

2015-02-19 Thread Pawel Wodkowski
Signed-off-by: Pawel Wodkowski --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a771fa3..782b585 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -362,6 +362,10 @@ F: app/test/test_timer* F: examples/timer/ F:

[dpdk-dev] [PATCH v5 2/3] examples: introduce new l2fwd-headroom example

2015-02-19 Thread Pawel Wodkowski
This app demonstrate usage of new headroom library. It is basically the orginal l2fwd with following modifications to met headroom library requirements: - main_loop() was split into two jobs: forward job and flush job. Logic for those jobs is almost the same as in original application. - stats is

[dpdk-dev] [PATCH v5 1/3] librte_headroom: New library for checking core/system/app load

2015-02-19 Thread Pawel Wodkowski
This library provide API to measure time spend in particular parts of code and to calculate optimal polling time. To calculate a those statistics application code need to be divided into parts (called jobs) that do something. It is up to application to decide what is considered a job. Series of

[dpdk-dev] [PATCH v5 0/3] new headroom stats library and example application

2015-02-19 Thread Pawel Wodkowski
Hi community, I would like to introduce library for measuring load of some arbitrary jobs. It can be used to profile every kind of job sets on any arbitrary execution unit or tasking library. In provided l2fwd-headroom example I demonstrate how to use this library to select optimal rx burst poll

[dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions

2015-02-19 Thread Zhou, Danny
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Thursday, February 19, 2015 9:10 PM > To: Zhou, Danny > Cc: Gonzalez Monroy, Sergio; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt > enable/disable functions > > On

[dpdk-dev] [PATCH v9 13/14] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-19 Thread Thomas Monjalon
2015-02-19 11:49, Tetsuya Mukawa: > +/* attach the new virtual device, then store port_id of the device */ > +static int > +rte_eal_dev_attach_vdev(const char *vdevargs, uint8_t *port_id) > +{ > + char *args; > + uint8_t new_port_id; > + struct rte_eth_dev devs[RTE_MAX_ETHPORTS]; > + >

[dpdk-dev] [PATCH] i40e: fix build with gcc 5

2015-02-19 Thread Panu Matilainen
On 02/19/2015 01:05 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen >> Sent: Thursday, February 19, 2015 10:25 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] i40e: fix build with gcc 5 >> >>

[dpdk-dev] [PATCH] i40e: fix build with gcc 5

2015-02-19 Thread Panu Matilainen
Eliminate embiguity in the condition which trips up a "logical not is only applied to the left..." warning from gcc 5, causing build failure with -Werror. Signed-off-by: Panu Matilainen --- lib/librte_pmd_i40e/i40e_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH] ixgbe: fix build with gcc 5

2015-02-19 Thread Panu Matilainen
Add extra parenthesis to remove ambiguity on what we want to compare, otherwise gcc 5 issues a "logical not is only applied to the left hand side of comparison" warning which with -Werror fails the build. Signed-off-by: Panu Matilainen --- lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c | 4 ++-- 1

[dpdk-dev] [PATCH v9 08/14] ethdev: Add functions that will be used by port hotplug functions

2015-02-19 Thread Thomas Monjalon
2015-02-19 11:49, Tetsuya Mukawa: > --- a/lib/librte_ether/rte_ether_version.map > +++ b/lib/librte_ether/rte_ether_version.map > @@ -109,6 +109,13 @@ DPDK_2.0 { > rte_eth_tx_queue_setup; > rte_eth_xstats_get; > rte_eth_xstats_reset; > + rte_eth_dev_allocated; > +

[dpdk-dev] [PATCH v9 02/14] eal_pci: Add flag to hold kernel driver type

2015-02-19 Thread Thomas Monjalon
> @@ -152,6 +159,7 @@ struct rte_pci_device { > uint16_t max_vfs; /**< sriov enable if not zero */ > int numa_node; /**< NUMA node connection */ > struct rte_devargs *devargs;/**< Device user arguments */ > + enum

[dpdk-dev] [PATCH] ixgbe: fix build with gcc 5

2015-02-19 Thread Ananyev, Konstantin
Hi Panu, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen > Sent: Thursday, February 19, 2015 10:25 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] ixgbe: fix build with gcc 5 > > Add extra parenthesis to remove ambiguity on what we

[dpdk-dev] [PATCH v9] testpmd: Add port hotplug support

2015-02-19 Thread Tetsuya Mukawa
The patch introduces following commands. - port attach [ident] - port detach [port_id] - attach: attaching a port - detach: detaching a port - ident: pci address of physical device. Or device name and parameters of virtual device. (ex. :02:00.0, eth_pcap0,iface=eth0) -

[dpdk-dev] [PATCH v9] librte_pmd_pcap: Add port hotplug support

2015-02-19 Thread Tetsuya Mukawa
This patch adds finalization code to free resources allocated by the PMD. v6: - Fix a paramter of rte_eth_dev_free(). v4: - Change function name. Signed-off-by: Tetsuya Mukawa --- lib/librte_pmd_pcap/rte_eth_pcap.c | 40 ++ 1 file changed, 40 insertions(+)

[dpdk-dev] [PATCH v9 14/14] doc: Add port hotplug framework section to programmers guide

2015-02-19 Thread Tetsuya Mukawa
This patch adds a new section for describing port hotplug framework. Signed-off-by: Tetsuya Mukawa --- doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/port_hotplug_framework.rst | 110 +++ 2 files changed, 111 insertions(+) create mode 100644

[dpdk-dev] [PATCH v9 13/14] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-19 Thread Tetsuya Mukawa
These functions are used for attaching or detaching a port. When rte_eal_dev_attach() is called, the function tries to realize the device name as pci address. If this is done successfully, rte_eal_dev_attach() will attach physical device port. If not, attaches virtual devive port. When

[dpdk-dev] [PATCH v9 12/14] ethdev: Add one dev_type parameter to rte_eth_dev_allocate

2015-02-19 Thread Tetsuya Mukawa
This new parameter is needed to keep device type like PCI or virtual. Port detaching processes are different between PCI device and virtual device. RTE_ETH_DEV_PCI indicates device type is PCI. RTE_ETH_DEV_VIRTUAL indicates device is virtual. v9: - Fix commit log. - RTE_ETH_DEV_PHYSICAL is

[dpdk-dev] [PATCH v9 11/14] eal/pci: Add probe and close functions of pci driver

2015-02-19 Thread Tetsuya Mukawa
- Add pci_close_all_drivers() The function tries to find a driver for the specified device, and then close the driver. - Add rte_eal_pci_probe_one() and rte_eal_pci_close_one() The functions are used for probe and close a device. First the function tries to find a device that has the

[dpdk-dev] [PATCH v9 10/14] eal/pci: Add a function to remove the entry of devargs list

2015-02-19 Thread Tetsuya Mukawa
The function removes the specified devargs entry from devargs_list. Also, the patch adds sanity checking to rte_eal_devargs_add(). v5: - Change function definition of rte_eal_devargs_remove(). v4: - Fix sanity check code. Signed-off-by: Tetsuya Mukawa ---

[dpdk-dev] [PATCH v9 09/14] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-02-19 Thread Tetsuya Mukawa
The patch adds functions for unmapping igb_uio resources. The patch is only for Linux and igb_uio environment. VFIO and BSD are not supported. v9: - Remove "rte_dev_hotplug.h". - Remove needless "#ifdef". (Thanks to Thomas Monjalon and Neil Horman) - Remove pci_unmap_device(). It will be

[dpdk-dev] [PATCH v9 08/14] ethdev: Add functions that will be used by port hotplug functions

2015-02-19 Thread Tetsuya Mukawa
The patch adds following functions. - rte_eth_dev_save() The function is used for saving current rte_eth_dev structures. - rte_eth_dev_get_changed_port() The function receives the rte_eth_dev structures, then compare these with current values to know which port is actually attached or

[dpdk-dev] [PATCH v9 07/14] eal, ethdev: Add a function and function pointers to close ether device

2015-02-19 Thread Tetsuya Mukawa
The patch adds function pointer to rte_pci_driver and eth_driver structure. These function pointers are used when ports are detached. Also, the patch adds rte_eth_dev_uninit(). So far, it's not called by anywhere, but it will be called when port hotplug function is implemented. v9: - Change

[dpdk-dev] [PATCH v9 06/14] ethdev: Add rte_eth_dev_release_port to release specified port

2015-02-19 Thread Tetsuya Mukawa
This patch adds rte_eth_dev_release_port(). The function is used for changing an attached status of the device that has specified name. v9: - rte_eth_dev_free() is replaced by rte_eth_dev_release_port(). (Thanks to Thomas Monjalon) v6: - Use rte_eth_dev structure as the paramter of

[dpdk-dev] [PATCH v9 05/14] eal/pci: Consolidate pci address comparison APIs

2015-02-19 Thread Tetsuya Mukawa
This patch replaces pci_addr_comparison() and memcmp() of pci addresses by rte_eal_compare_pci_addr(). To compare PCI addresses, rte_eal_compare_pci_addr() doesn't use memcmp(). This is because sizeof(struct rte_pci_addr) returns 6, but actually this structure is like below. struct rte_pci_addr

[dpdk-dev] [PATCH v9 04/14] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-19 Thread Tetsuya Mukawa
To remove assumption, do like followings. This patch adds "RTE_PCI_DRV_DETACHABLE" to drv_flags of rte_pci_driver structure. The flags indicate the driver can detach devices at runtime. Also, remove assumption that port will not be detached. To remove the assumption. - Add 'attached' member to

[dpdk-dev] [PATCH v9 03/14] eal_pci: pci memory map work with driver type

2015-02-19 Thread Tetsuya Mukawa
From: Michael Qiu With the driver type flag in struct rte_pci_dev, we do not need to always map uio devices with vfio related function when vfio enabled. Signed-off-by: Michael Qiu Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/linuxapp/eal/eal_pci.c | 30

[dpdk-dev] [PATCH v9 02/14] eal_pci: Add flag to hold kernel driver type

2015-02-19 Thread Tetsuya Mukawa
From: Michael Qiu Currently, dpdk has no ability to know which type of driver( vfio-pci/igb_uio/uio_pci_generic) the device used. It only can check whether vfio is enabled or not staticly. It really useful to have the flag, becasue different type need to handle

[dpdk-dev] [PATCH v9 01/14] eal: Enable port Hotplug framework in Linux

2015-02-19 Thread Tetsuya Mukawa
The patch adds CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux and BSD configuration. So far, Hotplug functions only support linux. v9: - Move this patch at the top of this patch series. (Thanks to Thomas Monjalon) Signed-off-by: Tetsuya Mukawa --- config/common_bsdapp | 6 ++

[dpdk-dev] [PATCH v9 00/14] Port Hotplug Framework

2015-02-19 Thread Tetsuya Mukawa
This patch series adds a dynamic port hotplug framework to DPDK. With the patches, DPDK apps can attach or detach ports at runtime. The basic concept of the port hotplug is like followings. - DPDK apps must have responsibility to manage ports. DPDK apps only know which ports are attached or

[dpdk-dev] [PATCH v2] i40e: fix build with gcc 5

2015-02-19 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen > Sent: Thursday, February 19, 2015 11:21 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2] i40e: fix build with gcc 5 > > Eliminate ambiguity in the condition which trips up a

[dpdk-dev] [PATCH v2] eal: add rte_eal_iopl_init to version map

2015-02-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Thursday, February 12, 2015 3:41 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2] eal: add rte_eal_iopl_init to version map > > Building shared libraries and using

[dpdk-dev] [PATCH] eal: fix fscanf format mismatch

2015-02-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Thursday, February 12, 2015 3:40 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] eal: fix fscanf format mismatch > > Variables are unsigned int but format scans for

[dpdk-dev] [PATCH] i40e: fix build with gcc 5

2015-02-19 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen > Sent: Thursday, February 19, 2015 10:25 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] i40e: fix build with gcc 5 > > Eliminate embiguity in the condition which trips up a "logical

[dpdk-dev] [PATCH v5 1/6] reorder: new reorder library

2015-02-19 Thread Olivier MATZ
Hi, On 02/19/2015 10:20 AM, Olivier MATZ wrote: > Hi Sergio, > > On 02/18/2015 03:58 PM, Sergio Gonzalez Monroy wrote: >> This library provides reordering capability for out of order mbufs based >> on a sequence number in the mbuf structure. >> >> Signed-off-by: Reshma Pattan >> Signed-off-by:

[dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB)

2015-02-19 Thread Thomas Monjalon
2015-02-19 09:18, Jastrzebski, MichalX K: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2015-02-13 16:12, Declan Doherty: > > > On 13/02/15 15:16, Michal Jastrzebski wrote: > > > > Michal Jastrzebski (6): > > > >net: changed arp_hdr struct declaration > > > >bond: add

[dpdk-dev] [PATCH v5 1/6] reorder: new reorder library

2015-02-19 Thread Olivier MATZ
Hi Sergio, On 02/18/2015 03:58 PM, Sergio Gonzalez Monroy wrote: > This library provides reordering capability for out of order mbufs based > on a sequence number in the mbuf structure. > > Signed-off-by: Reshma Pattan > Signed-off-by: Richardson Bruce > Signed-off-by: Sergio Gonzalez Monroy >

[dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB)

2015-02-19 Thread Jastrzebski, MichalX K
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, February 19, 2015 10:40 AM > To: Jastrzebski, MichalX K > Cc: Doherty, Declan; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB) > > 2015-02-19

[dpdk-dev] [PATCH v3 2/3] ethdev: Add rxtx callback support

2015-02-19 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, February 18, 2015 6:20 PM > To: Mcnamara, John; Richardson, Bruce > Cc: dev at dpdk.org; nhorman at tuxdriver.com; stephen at networkplumber.org; > Doherty, Declan > Subject: Re: [PATCH v3

[dpdk-dev] [PATCH v5 0/3] new headroom stats library and example application

2015-02-19 Thread Neil Horman
On Thu, Feb 19, 2015 at 01:18:41PM +0100, Pawel Wodkowski wrote: > Hi community, > I would like to introduce library for measuring load of some arbitrary jobs. > It > can be used to profile every kind of job sets on any arbitrary execution unit > or > tasking library. > > In provided

[dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB)

2015-02-19 Thread Jastrzebski, MichalX K
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, February 18, 2015 8:10 PM > To: Doherty, Declan; Jastrzebski, MichalX K > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB) > > Hi, > >

[dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions

2015-02-19 Thread Zhou, Danny
> -Original Message- > From: Gonzalez Monroy, Sergio > Sent: Thursday, February 19, 2015 4:22 PM > To: Zhou, Danny; Neil Horman > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt > enable/disable functions > > On 19/02/2015 08:06, Zhou, Danny wrote:

[dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions

2015-02-19 Thread Gonzalez Monroy, Sergio
On 19/02/2015 08:06, Zhou, Danny wrote: > >> -Original Message- >> From: Neil Horman [mailto:nhorman at tuxdriver.com] >> Sent: Tuesday, February 17, 2015 11:53 PM >> To: Zhou, Danny >> Cc: dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt >>

[dpdk-dev] [PATCH v3 4/5] eal: add per rx queue interrupt handling based on VFIO

2015-02-19 Thread Zhou, Danny
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Tuesday, February 17, 2015 11:59 PM > To: Zhou, Danny > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 4/5] eal: add per rx queue interrupt > handling based on VFIO > > On Tue, Feb 17, 2015 at

[dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions

2015-02-19 Thread Neil Horman
On Thu, Feb 19, 2015 at 08:34:22AM +, Zhou, Danny wrote: > > > > -Original Message- > > From: Gonzalez Monroy, Sergio > > Sent: Thursday, February 19, 2015 4:22 PM > > To: Zhou, Danny; Neil Horman > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx

[dpdk-dev] Patches outstanding

2015-02-19 Thread Neil Horman
On Tue, Feb 17, 2015 at 10:35:07AM -0500, Stephen Hemminger wrote: > There are currently 1039 patches outstanding on DPDK. > What is the schedule for getting these merged or resolved? > I don't think it would be reasonable to declare 2.0 as done > until the patch backlog is 0! > I think the

[dpdk-dev] [PATCH] ixgbe: fix build with gcc 5

2015-02-19 Thread Neil Horman
On Thu, Feb 19, 2015 at 12:02:06PM +, Ananyev, Konstantin wrote: > Hi Panu, > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen > > Sent: Thursday, February 19, 2015 10:25 AM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH]

[dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions

2015-02-19 Thread Zhou, Danny
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Tuesday, February 17, 2015 11:53 PM > To: Zhou, Danny > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt > enable/disable functions > > On Tue, Feb 17, 2015 at

[dpdk-dev] [PATCH v3 4/5] eal: add per rx queue interrupt handling based on VFIO

2015-02-19 Thread Neil Horman
On Thu, Feb 19, 2015 at 08:10:47AM +, Zhou, Danny wrote: > > > > -Original Message- > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > Sent: Tuesday, February 17, 2015 11:59 PM > > To: Zhou, Danny > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3 4/5] eal: add

[dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions

2015-02-19 Thread Neil Horman
On Thu, Feb 19, 2015 at 07:58:38AM +, Zhou, Danny wrote: > > > > -Original Message- > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > Sent: Tuesday, February 17, 2015 11:55 PM > > To: Zhou, Danny > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add

[dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions

2015-02-19 Thread Zhou, Danny
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Tuesday, February 17, 2015 11:55 PM > To: Zhou, Danny > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt > enable/disable functions > > On Tue, Feb 17, 2015 at

  1   2   >