[dpdk-dev] ixgbe vPMD question

2015-09-17 Thread Zoltan Kiss
Hi, The recv function does a prefetch on cacheline1, however it seems to me that rx_pkts[pos] should be uninitialized pointer at that time: http://dpdk.org/browse/dpdk/tree/drivers/net/ixgbe/ixgbe_rxtx_vec.c#n287 So I guess it prefetches only random value. Or am I missing something? Regards,

[dpdk-dev] [PATCH v2 4/4] librte_table: modify release notes and deprecation notice

2015-09-17 Thread Jasvinder Singh
The LIBABIVER number is incremented. The release notes is updated and the deprecation announcement is removed. Signed-off-by: Jasvinder Singh --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_2_2.rst | 4 +++- lib/librte_table/Makefile| 2 +- 3 files

[dpdk-dev] [PATCH v2 3/4] ip_pipeline: modify lpm table for routing pipeline

2015-09-17 Thread Jasvinder Singh
The name parameter has been defined in lpm table of routing pipeline. Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/pipeline/pipeline_routing_be.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/ip_pipeline/pipeline/pipeline_routing_be.c

[dpdk-dev] [PATCH v2 2/4] app/test: modify table and pipeline test

2015-09-17 Thread Jasvinder Singh
LPM table and test-pipeline has been modified to include name parameter of the lpm table. Signed-off-by: Jasvinder Singh --- app/test-pipeline/pipeline_lpm.c | 1 + app/test-pipeline/pipeline_lpm_ipv6.c | 1 + app/test/test_table_combined.c| 2 + app/test/test_table_tables.c

[dpdk-dev] [PATCH v2 1/4] librte_table: modify LPM table parameter structure

2015-09-17 Thread Jasvinder Singh
This patch relates to ABI change proposed for librte_table (lpm table). A new parameter to hold the table name has been added to the LPM table parameter structures rte_table_lpm_params and rte_table_lpm_ipv6_params. Signed-off-by: Jasvinder Singh --- lib/librte_table/rte_table_lpm.c | 8

[dpdk-dev] [PATCH v2 0/4]librte_table: add name parameter to lpm table

2015-09-17 Thread Jasvinder Singh
This patchset links to ABI change announced for librte_table. For lpm table, name parameter has been included in LPM table parameters structure. It will eventually allow applications to create more than one instances of lpm table, if required. Changes in v2: - rte_table_lpm_ipv6.c: removed name

[dpdk-dev] Fwd: [PATCH] PPC: Fix NUMA node numbering on IBM POWER8 LE machine

2015-09-17 Thread Chao Zhu
David, Let me take a look. On 2015/9/16 16:09, David Marchand wrote: > Hello Chao, > > On Wed, Sep 16, 2015 at 4:02 AM, Chao Zhu > wrote: > > Actually, without this change, DPDK can't work properly on PPC64 > little endian platform. It'll report

[dpdk-dev] QoS scheduler example fails to run

2015-09-17 Thread Gholam Reza Rahimi
Hi all, I'm trying to run QoS scheduler example based on the information which has been posted in "http://dpdk.org/doc/guides/sample_app_ug/qos_scheduler.html; with DPDK 2.1.0. I have been trying different hugepage sizes (2MByte, 1GByte), but I have received the same error for both. I have

[dpdk-dev] [PATCH v2 0/4]librte_table: add name parameter to lpm table

2015-09-17 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Thursday, September 17, 2015 7:03 PM > To: dev at dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH v2 0/4]librte_table: add name parameter to lpm table > > This patchset links to ABI change announced for librte_table. For > lpm

[dpdk-dev] [PATCH 1/1] ip_pipeline: add pipeline type validation

2015-09-17 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maciej Gajdzica > Sent: Thursday, September 17, 2015 3:59 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 1/1] ip_pipeline: add pipeline type validation > > This commit add to CLI command check for

[dpdk-dev] virtio optimization idea

2015-09-17 Thread Xie, Huawei
On 9/8/2015 11:54 PM, Xie, Huawei wrote: > On 9/8/2015 11:39 PM, Stephen Hemminger wrote: >> On Fri, 4 Sep 2015 08:25:05 + >> "Xie, Huawei" wrote: >> >>> Hi: >>> >>> Recently I have done one virtio optimization proof of concept. The >>> optimization includes two parts: >>> 1) avail ring set

[dpdk-dev] [PATCH 1/1] ip_pipeline: add pipeline type validation

2015-09-17 Thread Maciej Gajdzica
This commit add to CLI command check for pipeline type. It prevents running CLI commands on not supported pipeline types. Signed-off-by: Maciej Gajdzica --- examples/ip_pipeline/app.h |1 + examples/ip_pipeline/init.c|2 ++

[dpdk-dev] [PATCH v3] ixgbe: fix access to last byte of EEPROM

2015-09-17 Thread Remy Horton
Incorrect operator in ixgbe_get_eeprom & ixgbe_set_eeprom prevents last byte of EEPROM being read/written, and hence cannot be dumped or updated in entirity using these functions. Fixes: 0198848a47f5 ("ixgbe: add access to specific device info") Signed-off-by: Remy Horton ---

[dpdk-dev] [RFC PATCH] vhost: Add VHOST PMD

2015-09-17 Thread Loftus, Ciara
> > On 2015/09/16 1:27, Loftus, Ciara wrote: > >> + > >> +static int > >> +rte_pmd_vhost_devinit(const char *name, const char *params) > >> +{ > >> + struct rte_kvargs *kvlist = NULL; > >> + int ret = 0; > >> + int index; > >> + char *iface_name; > >> + > >> + RTE_LOG(INFO, PMD,

[dpdk-dev] [Q] asymmetric ping latency over KNI

2015-09-17 Thread Moon-Sang Lee
hello. I installed dpdp-2.1.0 on my ubuntu 14.04 server where two NIC ports are available. There are two KNI interfaces, vEth0 and vEth1, for two NIC ports. (i.e. one KNI for one NIC port) And I connected two servers, M1 and M3, to each NIC port as below. [ M1 ]eth0-[ M2 ]-eth1[

[dpdk-dev] [PATCH] hash: fix incorrect lookup if key is all zero

2015-09-17 Thread Thomas Monjalon
Hi Pablo, 2015-09-17 10:04, Pablo de Lara: > If user has not added an all zero key in the hash table, > and tries to look it up, it results in an incorrect hit, > as dummy slot in the key table has all zero as well. > > Signed-off-by: Pablo de Lara Please try to remember to use "Fixes:" tag.

[dpdk-dev] [PATCH v2] ixgbe: fix access to last byte of EEPROM

2015-09-17 Thread Thomas Monjalon
2015-09-17 10:05, Remy Horton: > Incorrect operator in ixgbe_get_eeprom & ixgbe_set_eeprom prevents > last byte of EEPROM being read/written, and hence cannot be dumped > or updated in entirity using these functions. > > Signed-off-by: Remy Horton > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 8

[dpdk-dev] X520 virtual functions worked in 2.0 but fails in 2.1

2015-09-17 Thread Jesper Wramberg
Hey there, Thanks for your help. I checked the eth_ixgbevf_dev_init() function against DPDK 2.0 but did think about changes in the eth_ixgbe_dev_init() function. Anyway, I have just been using 2.0 for now but it's nice to know I wasn't doing anything wrong :-) Regards, Jesper Wramberg

[dpdk-dev] [PATCH v2] hash: fix incorrect lookup if key is all zero

2015-09-17 Thread Pablo de Lara
If user has not added an all zero key in the hash table, and tries to look it up, it results in an incorrect hit, as dummy slot in the key table has all zero as well. Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation") Signed-off-by: Pablo de Lara --- Changes in v2: - Include

[dpdk-dev] [PATCH v2] ixgbe: fix access to last byte of EEPROM

2015-09-17 Thread Remy Horton
Incorrect operator in ixgbe_get_eeprom & ixgbe_set_eeprom prevents last byte of EEPROM being read/written, and hence cannot be dumped or updated in entirity using these functions. Signed-off-by: Remy Horton --- drivers/net/ixgbe/ixgbe_ethdev.c | 8 1 file changed, 4 insertions(+), 4

[dpdk-dev] [PATCH] hash: fix incorrect lookup if key is all zero

2015-09-17 Thread Pablo de Lara
If user has not added an all zero key in the hash table, and tries to look it up, it results in an incorrect hit, as dummy slot in the key table has all zero as well. Signed-off-by: Pablo de Lara --- doc/guides/rel_notes/release_2_2.rst | 5 + lib/librte_hash/rte_cuckoo_hash.c| 27

[dpdk-dev] [PATCH] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data

2015-09-17 Thread Thomas Monjalon
2015-09-16 21:22, De Lara Guarch, Pablo: > From: Ananyev, Konstantin > > Why not something like: > > ret = dev->dev_ops->tx_queue_start(dev, tx_queue_id); > > if (ret == 0) > > dev->data->tx_queue_state[tx_queue_id] = > > RTE_ETH_QUEUE_STATE_START; > > > > Same for dev_stop and RX. > > Then you

[dpdk-dev] [Pktgen] [PATCH] pktgen_setup_packets: fix race for packet header

2015-09-17 Thread Ilya Maximets
Ok. Thank you. I'll wait. On 16.09.2015 18:37, Wiles, Keith wrote: > Thanks the patch looks fine, but I have not had a lot of time to review it > detail. I hope to get to it next week after I return back home. > > On 9/16/15, 2:09 AM, "Ilya Maximets" wrote: > >> Ping. >> >> On 09.09.2015

[dpdk-dev] [PATCH] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data

2015-09-17 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, September 17, 2015 8:24 AM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org; Ananyev, Konstantin > Subject: Re: [dpdk-dev] [PATCH] ethdev: add new RX/TX queue state arrays > in

[dpdk-dev] [PATCH v2]doc:Add performance test guide about how to get DPDK high perf on Intel platform

2015-09-17 Thread Xu, Qian Q
Thomas/John Thanks a lot for your comments, and I will update the patch soon. Thanks Qian -Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Wednesday, September 16, 2015 9:01 PM To: Mcnamara, John Cc: Xu, Qian Q; dev at dpdk.org; Jayakumar, Muthurajan

[dpdk-dev] [PATCH 8/8] app/testpmd: modify the mac of csum forwarding

2015-09-17 Thread Jijiang Liu
The change will affect on the csum fwd performance. But I also think the change is necessary, or we cannot use csumonly fwd mode in a VM. Signed-off-by: Jijiang Liu --- app/test-pmd/csumonly.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/app/test-pmd/csumonly.c

[dpdk-dev] [PATCH 7/8] examples/vhost:support TSO in vhost sample

2015-09-17 Thread Jijiang Liu
Change the vhost sample in order to support and test TSO offload. Signed-off-by: Jijiang Liu --- examples/vhost/main.c | 20 ++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index 1b137b9..482f7af 100644 ---

[dpdk-dev] [PATCH 6/8] lib/librte_vhost:extend supported vhost features

2015-09-17 Thread Jijiang Liu
Add host TSO support into vhost features bits Signed-off-by: Jijiang Liu --- lib/librte_vhost/virtio-net.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c index b520ec5..2f9ac25 100644 ---

[dpdk-dev] [PATCH 5/8] lib/librte_vhost:dequeue vhost TSO offload

2015-09-17 Thread Jijiang Liu
Dequeue host TSO4/6 offload in host side. Signed-off-by: Jijiang Liu --- lib/librte_vhost/vhost_rxtx.c | 29 - 1 files changed, 28 insertions(+), 1 deletions(-) diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c index 0d07338..b84ec64

[dpdk-dev] [PATCH 4/8] driver/virtio:enqueue TSO offload

2015-09-17 Thread Jijiang Liu
Enqueue host TSO4/6 offload in guest side. Signed-off-by: Jijiang Liu --- drivers/net/virtio/virtio_rxtx.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index

[dpdk-dev] [PATCH 3/8] driver/virtio: record virtual address of virtio net header

2015-09-17 Thread Jijiang Liu
Record virtual address of virtio net header. Signed-off-by: Jijiang Liu --- drivers/net/virtio/virtio_ethdev.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 465d3cd..cb5dfee 100644 ---

[dpdk-dev] [PATCH 2/8] driver/virtio:add virtual addr for virtio net header

2015-09-17 Thread Jijiang Liu
The virtual addr for virtio net header need to be recorded. Signed-off-by: Jijiang Liu --- drivers/net/virtio/virtqueue.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h index 7789411..530f840 100644 ---

[dpdk-dev] [PATCH 1/8] driver/virtio:add vhost TSO support capability

2015-09-17 Thread Jijiang Liu
Signed-off-by: Jijiang Liu --- drivers/net/virtio/virtio_ethdev.h |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 9026d42..3a66491 100644 --- a/drivers/net/virtio/virtio_ethdev.h +++

[dpdk-dev] [PATCH 0/8] add vhost TSO capability

2015-09-17 Thread Jijiang Liu
The patch set add the negotiation between us-vhost and virtio-net for vhost TSO feature, and enqueue/dequeue vhost TSO offload and change vhost sample and csum application to test these. *** BLURB HERE *** Jijiang Liu (8): add host TSO support in virtio_ethdev.h file add virtual addr for

[dpdk-dev] vhost-net stops sending to virito pmd -- already fixed?

2015-09-17 Thread Ouyang, Changchun
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Kyle Larose > Sent: Wednesday, September 16, 2015 5:05 AM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] vhost-net stops sending to virito pmd -- already > fixed? > > On Sun, Sep 13,