[dpdk-dev] Wrong TCP Checkum computed by hardware

2015-10-27 Thread Matthew Hall
On Wed, Oct 28, 2015 at 12:20:22PM +0530, Padam Jeet Singh wrote: > Any hint what could I be doing wrong here? When this kind of stuff doesn't work it often will depend on the exact version of card, chip, etc. if there are any errata. So you might want to collect the specifics of the board with

[dpdk-dev] [PATCH v2 7/7] l3fwd-power: disable interrupt when wake up from sleep

2015-10-27 Thread Yong Liu
e1000 device interrupt can't be auto-clear. So disble interrupt when thread wake-up. Signed-off-by: Marvin Liu diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 8bb88ce..9175989 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -798,6 +798,7

[dpdk-dev] [PATCH v2 6/7] e1000: lsc interrupt setup function only enable itself

2015-10-27 Thread Yong Liu
Only mask lsc interrupt bit when setup device interrupt. Signed-off-by: Marvin Liu diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index b1e0c3c..d2d017c 100644 --- a/drivers/net/e1000/em_ethdev.c +++ b/drivers/net/e1000/em_ethdev.c @@ -1343,11 +1343,14 @@ eth_em_vlan_

[dpdk-dev] [PATCH v2 5/7] e1000: check lsc and rxq not enable in the same time

2015-10-27 Thread Yong Liu
e1000 only support one type of interrupt cause, so remove lsc interrupt handler if rxq enabled. Signed-off-by: Marvin Liu diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index fc3cc1e..b1e0c3c 100644 --- a/drivers/net/e1000/em_ethdev.c +++ b/drivers/net/e1000/em_ethdev

[dpdk-dev] [PATCH v2 4/7] e1000: add rxq interrupt handler

2015-10-27 Thread Yong Liu
When datapath rxq interupt is enabled, enable related device rxq. Remove the interrupt handler after device stopped. Signed-off-by: Marvin Liu diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index 6dc2534..fc3cc1e 100644 --- a/drivers/net/e1000/em_ethdev.c +++ b/driver

[dpdk-dev] [PATCH v2 3/7] e1000: add ethdev rxq enable and disable function

2015-10-27 Thread Yong Liu
Implement rxq interrupt related functions in eth_dev_ops structure. Signed-off-by: Marvin Liu diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index 39f330a..6dc2534 100644 --- a/drivers/net/e1000/em_ethdev.c +++ b/drivers/net/e1000/em_ethdev.c @@ -108,9 +108,13 @@ stat

[dpdk-dev] [PATCH v2 2/7] e1000: separate lsc and rxq interrupt disable function

2015-10-27 Thread Yong Liu
Separate lsc and rxq interrupt for they have different interrupt handlers. Signed-off-by: Marvin Liu diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index 3be8269..39f330a 100644 --- a/drivers/net/e1000/em_ethdev.c +++ b/drivers/net/e1000/em_ethdev.c @@ -108,11 +108,12

[dpdk-dev] [PATCH v2 1/7] e1000: add rx interrupt support

2015-10-27 Thread Yong Liu
Enable rx interrupt support on e1000 physical and emulated device. Signed-off-by: Marvin Liu diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index 912f5dd..3be8269 100644 --- a/drivers/net/e1000/em_ethdev.c +++ b/drivers/net/e1000/em_ethdev.c @@ -81,6 +81,7 @@ static i

[dpdk-dev] [PATCH v2 0/7] interrupt mode for e1000

2015-10-27 Thread Yong Liu
v2 changes: describe interrupt mode work with uio and vfio+msi flush after enable and disable interrupt register replace attribuite __unused__ with __rte_unused This patch set will enable interrup for physical and emulated e1000 device. Rx queue interrupt will work with uio

[dpdk-dev] Mellanox PMD failure w/DPDK-2.1.0 and MLNX_OFED-3.1-1.0.3

2015-10-27 Thread Dave Engebretsen
Hi I'm seeing a similar failure "CQ creation failure: Cannot allocate memory". My FW level and OFED version match Bill's and we are on DPDK 2.1. Has any solution other than changing the linkage been found yet? Thanks

[dpdk-dev] [PATCH v4] ixgbe_pmd: enforce RS bit on every EOP descriptor for devices newer than 82598

2015-10-27 Thread Vlad Zolotarov
On 10/27/15 21:10, Ananyev, Konstantin wrote: > Hi lads, > >> -Original Message- >> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] >> Sent: Tuesday, October 27, 2015 6:48 PM >> To: Thomas Monjalon; Ananyev, Konstantin; Zhang, Helin >> Cc: dev at dpdk.org; Kirsher, Jeffrey T;

[dpdk-dev] [Patch 2/2] i40e simple tx: Larger list size (33 to 128) throughput optimization

2015-10-27 Thread Polehn, Mike A
Added packet memory prefetch for faster access to variables inside packet buffer needed for the free operation. Signed-off-by: Mike A. Polehn diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 177fb2e..d9bc30a 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/

[dpdk-dev] [Patch 1/2] i40e simple tx: Larger list size (33 to 128) throughput optimization

2015-10-27 Thread Polehn, Mike A
Reduce the 32 packet list size focus for better packet list size range handling. Changed maximum new buffer loop process size to the NIC queue free buffer count per loop. Removed redundant single call check to just one call with focused loop. Remove NIC register update write from per loop to on

[dpdk-dev] [Patch 2/2] i40e rx Bulk Alloc: Larger list size (33 to 128) throughput optimization

2015-10-27 Thread Polehn, Mike A
Added check of minimum of 2 packet allocation count to eliminate the extra overhead for supporting prefetch for the case of checking for only one packet allocated into the queue at a time. Used some standard variables to help reduce overhead of non-standard variable sizes. Added second level

[dpdk-dev] [Patch 1/2] i40e RX Bulk Alloc: Larger list size (33 to 128) throughput optimization

2015-10-27 Thread Polehn, Mike A
Combined 2 subroutines of code into one subroutine with one read operation followed by buffer allocate and load loop. Eliminated the staging queue and subroutine, which removed extra pointer list movements and reduced number of active variable cache pages during for call. Reduced queue positi

[dpdk-dev] [Patch] Eth Driver: Optimization for improved NIC processing rates

2015-10-27 Thread Polehn, Mike A
Prefetch of interface access variables while calling into driver RX and TX subroutines. For converging zero loss packet task tests, a small drop in latency for zero loss measurements and small drop in lost packet counts for the lossy measurement points was observed, indicating some savings of

[dpdk-dev] [PATCH v4] ixgbe_pmd: enforce RS bit on every EOP descriptor for devices newer than 82598

2015-10-27 Thread Vlad Zolotarov
On 10/27/15 20:09, Thomas Monjalon wrote: > Any Follow-up to this discussion? > Should we mark this patch as rejected? Hmmm... This patch fixes an obvious spec violation. Why would it be rejected? > > 2015-08-24 11:11, Vlad Zolotarov: >> On 08/20/15 18:37, Vlad Zolotarov wrote: >>> According t

[dpdk-dev] [PATCH v3 17/17] acl: handle when SSE 4.1 is unsupported

2015-10-27 Thread Jan Viktorin
The main goal of this check is to avoid passing the -msse4.1 option to the GCC that does not support it (like arm toolchains). The ACL now builds for ARM. Signed-off-by: Jan Viktorin --- v2 -> v3: handle missing SSE as suggested by K. Ananyev --- lib/librte_acl/Makefile | 7 ++- lib/librt

[dpdk-dev] [PATCH v3 16/17] lpm/arm: implement rte_lpm_lookupx4 using rte_lpm_lookup_bulk for non-x86

2015-10-27 Thread Jan Viktorin
From: Vlastimil Kosar LPM function rte_lpm_lookupx4() uses i686/x86_64 SIMD intrinsics. Therefore, the function is reimplemented using non-vector operations for non-x86 architectures. LPM now builds for ARM. Signed-off-by: Vlastimil Kosar Signed-off-by: Jan Viktorin --- v2 -> v3: as SIMD oper

[dpdk-dev] [PATCH v3 15/17] eal/arm: add very incomplete rte_vect

2015-10-27 Thread Jan Viktorin
This patch does not map x86 SIMD operations to the ARM ones. It just fills the necessary gap between the platforms to enable compilation of libraries LPM (includes rte_vect.h, lpm_test needs those SIMD functions) and ACL (includes rte_vect.h). Signed-off-by: Jan Viktorin --- lib/librte_eal/commo

[dpdk-dev] [PATCH v3 14/17] maintainers: claim responsibility for ARMv7

2015-10-27 Thread Jan Viktorin
Signed-off-by: Jan Viktorin --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 080a8e8..a8933eb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -124,6 +124,10 @@ IBM POWER M: Chao Zhu F: lib/librte_eal/common/include/arch/ppc_64/ +ARM v7 +M:

[dpdk-dev] [PATCH v3 13/17] gcc/arm: avoid alignment errors to break build

2015-10-27 Thread Jan Viktorin
There several issues with alignment when compiling for ARMv7. They are not considered to be fatal (ARMv7 supports unaligned access of 32b words), so we just leave them as warnings. They should be solved later, however. Signed-off-by: Jan Viktorin Signed-off-by: Vlastimil Kosar --- mk/toolchain/

[dpdk-dev] [PATCH v3 12/17] eal/arm: rwlock support for ARM

2015-10-27 Thread Jan Viktorin
Just a copy from PPC. Signed-off-by: Jan Viktorin --- .../common/include/arch/arm/rte_rwlock.h | 40 ++ 1 file changed, 40 insertions(+) create mode 100644 lib/librte_eal/common/include/arch/arm/rte_rwlock.h diff --git a/lib/librte_eal/common/include/arch/arm/rte_

[dpdk-dev] [PATCH v3 11/17] eal/arm: detect arm architecture in cpu flags

2015-10-27 Thread Jan Viktorin
Based on the patch by David Hunt and Armuta Zende: lib: added support for armv7 architecture Signed-off-by: Jan Viktorin Signed-off-by: Amruta Zende Signed-off-by: David Hunt --- v2 -> v3: fixed forgotten include of string.h --- lib/librte_eal/common/include/arch/arm/rte_cpuflags.h | 16 +++

[dpdk-dev] [PATCH v3 10/17] eal/arm: cpu flag checks for ARM

2015-10-27 Thread Jan Viktorin
From: Vlastimil Kosar This implementation is based on IBM POWER version of rte_cpuflags. We use software emulation of HW capability registers, because those are usually not directly accessible from userspace on ARM. Signed-off-by: Vlastimil Kosar Signed-off-by: Jan Viktorin --- app/test/test_

[dpdk-dev] [PATCH v3 09/17] eal/arm: use vector memcpy only when NEON is enabled

2015-10-27 Thread Jan Viktorin
The GCC can be configured to avoid using NEON extensions. For that purpose, we provide just the memcpy implementation of the rte_memcpy. Based on the patch by David Hunt and Armuta Zende: lib: added support for armv7 architecture Signed-off-by: Jan Viktorin Signed-off-by: Amruta Zende Signed

[dpdk-dev] [PATCH v3 08/17] eal/arm: vector memcpy for ARM

2015-10-27 Thread Jan Viktorin
From: Vlastimil Kosar The SSE based memory copy in DPDK only support x86. This patch adds ARM NEON based memory copy functions for ARM architecture. The implementation improves memory copy of short or well aligned data buffers. The following measurements show improvements over the libc memcpy on

[dpdk-dev] [PATCH v3 07/17] eal/arm: spinlock operations for ARM (without HTM)

2015-10-27 Thread Jan Viktorin
From: Vlastimil Kosar This patch adds spinlock operations for ARM architecture. We do not support HTM in spinlocks on ARM. Signed-off-by: Vlastimil Kosar Signed-off-by: Jan Viktorin --- .../common/include/arch/arm/rte_spinlock.h | 114 + 1 file changed, 114 inserti

[dpdk-dev] [PATCH v3 06/17] eal/arm: prefetch operations for ARM

2015-10-27 Thread Jan Viktorin
From: Vlastimil Kosar This patch adds architecture specific prefetch operations for ARM architecture. It utilizes the pld instruction that starts filling the appropriate cache line without blocking. Signed-off-by: Vlastimil Kosar Signed-off-by: Jan Viktorin --- .../common/include/arch/arm/rte

[dpdk-dev] [PATCH v3 05/17] eal/arm: implement rdtsc by PMU or clock_gettime

2015-10-27 Thread Jan Viktorin
Enable to choose a preferred way to read timer based on the configuration entry CONFIG_RTE_ARM_EAL_RDTSC_USE_PMU. It requires a kernel module that is not included to work. Based on the patch by David Hunt and Armuta Zende: lib: added support for armv7 architecture Signed-off-by: Jan Viktorin

[dpdk-dev] [PATCH v3 04/17] eal/arm: cpu cycle operations for ARM

2015-10-27 Thread Jan Viktorin
From: Vlastimil Kosar ARM architecture doesn't have a suitable source of CPU cycles. This patch uses clock_gettime instead. The implementation should be improved in the future. Signed-off-by: Vlastimil Kosar Signed-off-by: Jan Viktorin --- .../common/include/arch/arm/rte_cycles.h |

[dpdk-dev] [PATCH v3 03/17] eal/arm: byte order operations for ARM

2015-10-27 Thread Jan Viktorin
From: Vlastimil Kosar This patch adds architecture specific byte order operations for ARM. The architecture supports both big and little endian. Signed-off-by: Vlastimil Kosar Signed-off-by: Jan Viktorin --- .../common/include/arch/arm/rte_byteorder.h| 148 + 1 fil

[dpdk-dev] [PATCH v3 02/17] eal/arm: atomic operations for ARM

2015-10-27 Thread Jan Viktorin
From: Vlastimil Kosar This patch adds architecture specific atomic operation file for ARM architecture. It utilizes compiler intrinsics only. Signed-off-by: Vlastimil Kosar Signed-off-by: Jan Viktorin --- v1 -> v2: * improve rte_wmb() * use __atomic_* or __sync_*? (may affect the required GCC

[dpdk-dev] [PATCH v3 01/17] mk: Introduce ARMv7 architecture

2015-10-27 Thread Jan Viktorin
From: Vlastimil Kosar Make DPDK run on ARMv7-A architecture. This patch assumes ARM Cortex-A9. However, it is known to be working on Cortex-A7 and Cortex-A15. Signed-off-by: Vlastimil Kosar Signed-off-by: Jan Viktorin --- v1 -> v2: * the -mtune parameter of GCC is configurable now * the -mfpu=

[dpdk-dev] [PATCH v3 00/17] Support ARMv7 architecture

2015-10-27 Thread Jan Viktorin
Hello DPDK community, this is the third attempt to post support for ARMv7 into the DPDK. There are changes related to the LPM and ACL libraries only: * included rte_vect.h, however, it is more a placeholder * rte_lpm.h was simplified due to the previous point * ACL now compiles as we detect wheth

[dpdk-dev] [PATCH v4 0/2] e1000: enable igb TSO support

2015-10-27 Thread Thomas Monjalon
> > v4: > > * Added ULL postfix to compare mask of igb_tx_offload. > > > > v3: > > * Removed the "unlikely" in check_tso_para function, for there was no > > obvious performance > > difference, let the branch predictor do the job. > > > > v2: > > * Reworded the old comment about union igb_vlan_m

[dpdk-dev] [PATCH 10/11] mk: add makefile and config changes for armv8 architecture

2015-10-27 Thread Jan Viktorin
On Mon, 26 Oct 2015 17:22:01 +0100 Jan Viktorin wrote: > On Fri, 23 Oct 2015 15:17:12 +0100 > David Hunt wrote: > > > > > +# ARMv8 CPU flags > > +ifneq ($(filter $(AUTO_CPUFLAGS),__aarch64__),) I do not believe that this works. The function filter accepts arguments swapped. I.e. first a patt

[dpdk-dev] [PATCH v3 1/2] e1000: enable igb TSO support

2015-10-27 Thread Thomas Monjalon
Please guys, allow us to read your discussion by removing the useless lines. It's enough hard to follow to add the constraint of looking for the interesting lines. Thanks PS: do not hesitate to spread the word around you, Patchwork and the MUAs will thank you.

[dpdk-dev] [PATCH v4] ixgbe_pmd: enforce RS bit on every EOP descriptor for devices newer than 82598

2015-10-27 Thread Ananyev, Konstantin
Hi lads, > -Original Message- > From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > Sent: Tuesday, October 27, 2015 6:48 PM > To: Thomas Monjalon; Ananyev, Konstantin; Zhang, Helin > Cc: dev at dpdk.org; Kirsher, Jeffrey T; Brandeburg, Jesse > Subject: Re: [dpdk-dev] [PATCH v4]

[dpdk-dev] [PATCH v4] ixgbe_pmd: enforce RS bit on every EOP descriptor for devices newer than 82598

2015-10-27 Thread Thomas Monjalon
Any Follow-up to this discussion? Should we mark this patch as rejected? 2015-08-24 11:11, Vlad Zolotarov: > On 08/20/15 18:37, Vlad Zolotarov wrote: > > According to 82599 and x540 HW specifications RS bit *must* be > > set in the last descriptor of *every* packet. > > > > Before this patch there

[dpdk-dev] [PATCH v2 4/5] doc: add documentation for szedata2 PMD

2015-10-27 Thread Thomas Monjalon
2015-10-27 18:33, Matej Vido: > 2015-10-26 16:09 GMT+01:00 Thomas Monjalon : > > SZEDATA2 is not a vdev. Is it possible to probe it as a standard PCI > > device? > > > It would be possible to probe it as a standard PCI device, but as this > szedata2 driver uses libsze2 library it needs to pass some

[dpdk-dev] [PATCH] enic: improve Tx packet rate

2015-10-27 Thread Thomas Monjalon
2015-10-23 15:47, John Daley: > For every packet sent, a completion was being requested and the > posted_index register on the nic was being updated. Instead, > request a completion and update the posted index once per burst > after all packets have been sent by the burst function. > > Signed-off-

[dpdk-dev] [PATCH v4] ixgbe_pmd: enforce RS bit on every EOP descriptor for devices newer than 82598

2015-10-27 Thread Brandeburg, Jesse
+ixgbe developers. -Original Message- From: Vlad Zolotarov [mailto:vl...@cloudius-systems.com] Sent: Tuesday, October 27, 2015 11:48 AM To: Thomas Monjalon; Ananyev, Konstantin; Zhang, Helin Cc: dev at dpdk.org; Kirsher, Jeffrey T; Brandeburg, Jesse Subject: Re: [dpdk-dev] [PATCH v4] ixgb

[dpdk-dev] [PATCH] librte: Link status interrupt race condition, IGB E1000

2015-10-27 Thread Thomas Monjalon
2015-10-26 05:25, Lu, Wenzhuo: > I think you're right. To my opinion, this if is added to avoid the race > condition. So, it should be " dev->data->dev_conf.intr_conf.lsc == 0". It > means if the interrupts are not enabled, we'd update the link when starting, > if not we can leave it the interru

[dpdk-dev] [PATCH] e1000: fix rx/tx total byte statistics

2015-10-27 Thread Thomas Monjalon
> > This patch fixes a bug in reading the 64 bit register reading which was > > causing the total octets counters to show zero. > > Now the code reads both the lower and higher 32 bits. > > Tested in testpmd, byte values are correct. > > > > Fixes: 805803445a02 ("e1000: support EM devices (also kn

[dpdk-dev] [PATCH v2 3/5] szedata2: add handling of scattered packets in TX

2015-10-27 Thread Matej Vido
Hi Thomas, 2015-10-26 15:55 GMT+01:00 Thomas Monjalon : > Hi Matej, > > 2015-09-18 10:32, Matej Vido: > > - rte_memcpy(tmp_dst, > > - rte_pktmbuf_mtod(mbuf, const void *), > > - pkt_len); > > + if (lik

[dpdk-dev] [PATCH v6 6/9] test: dynamic rss configuration

2015-10-27 Thread Thomas Monjalon
This new test depends on null PMD. The dependency should be checked gracefully, see below. 2015-10-16 12:00, Tomasz Kulasek: > --- a/app/test/Makefile > +++ b/app/test/Makefile > @@ -138,6 +138,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_ACL) += test_acl.c > ifeq ($(CONFIG_RTE_LIBRTE_PMD_RING),y) > SRCS-$(CON

[dpdk-dev] [PATCH v2 4/5] doc: add documentation for szedata2 PMD

2015-10-27 Thread Matej Vido
Hi Thomas, thank you for feedback. 2015-10-26 16:09 GMT+01:00 Thomas Monjalon : > Hi Matej, > > Thanks for providing a documentation. > I'm sorry to give a late feedback and I would like that other contributors > have reviewed it. There are a lot of PMD developers around. Please help. > > > 2015

[dpdk-dev] [PATCH v5] mem: command line option to delete hugepage backing files

2015-10-27 Thread shesha Sreenivasamurthy (shesha)
When an application using huge-pages crash or exists, the hugetlbfs backing files are not cleaned up. This is a patch to clean those files. There are multi-process DPDK applications that may be benefited by those backing files. Therefore, I have made that configurable so that the application that d

[dpdk-dev] [PATCH] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Tetsuya Mukawa
On 2015/10/27 17:39, Yuanhan Liu wrote: > On Tue, Oct 27, 2015 at 08:24:00AM +, Xie, Huawei wrote: >> On 10/27/2015 3:52 PM, Tetsuya Mukawa wrote: >>> The patch fixes wrong handling of virtqueue array index when >>> GET_VRING_BASE message comes. >>> The vhost backend will receive the message pe

[dpdk-dev] [PATCH v5] mem: command line option to delete hugepage backing files

2015-10-27 Thread shesha Sreenivasamurthy (shesha)
When an application using huge-pages crash or exists, the hugetlbfs backing files are not cleaned up. This is a patch to clean those files. There are multi-process DPDK applications that may be benefited by those backing files. Therefore, I have made that configurable so that the application that d

[dpdk-dev] [PATCH v2 16/16] acl: check for SSE 4.1 support

2015-10-27 Thread Jan Viktorin
Hello Konstantin, thank you for those hints! I reworked the code a little bit - refactored the LPM vector operations into rte_vect.h which helped to the ACL library as well. I will sort it out a little and send the v3 of the series. The LPM and ACL now seem to be much more sane on ARM. Regards Ja

[dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd added to bonding

2015-10-27 Thread Thomas Monjalon
Hi, There is no change in v6 for this patch which was acked by Tetsuya. So why not keep the Acked-by below your Signed-off-by? It seems patches 2, 3, 4 and 5 were Acked by Tetsuya. Other acks I'm missing? 2015-10-16 12:00, Tomasz Kulasek: > This patch initializes eth_dev->link_intr_cbs queue use

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-27 Thread Yuanhan Liu
On Tue, Oct 27, 2015 at 11:42:24AM +0200, Michael S. Tsirkin wrote: ... > > > Looking at that, at least when MQ is enabled, please don't key > > > stopping queues off GET_VRING_BASE. > > > > Yes, that's only a workaround. I guess it has been there for quite a > > while, maybe at the time qemu does

[dpdk-dev] [PATCH v3 16/16] doc: release notes update for fm10k Vector PMD

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Update 2.2 release notes, add descriptions for Vector PMD implementation in fm10k driver. Signed-off-by: Chen Jing D(Mark) --- doc/guides/rel_notes/release_2_2.rst |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/doc/guides/rel_notes/releas

[dpdk-dev] [PATCH v3 15/16] fm10k: fix a crash issue in vector RX func

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Vector RX function will process 4 packets at a time. When the RX ring wrapps to the tail and the left descriptor size is not multiple of 4, SW will overwrite memory that not belongs to it and cause crash. The fix will allocate additional 4 HW/SW spaces at the tail to avo

[dpdk-dev] [PATCH v3 14/16] fm10k: Add function to decide best TX func

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add func fm10k_set_tx_function to decide the best TX func in fm10k_dev_tx_init. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h|1 + drivers/net/fm10k/fm10k_ethdev.c | 38 -- 2 files changed, 37 insertio

[dpdk-dev] [PATCH v3 13/16] fm10k: introduce 2 funcs to reset TX queue and mbuf release

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add 2 funcs to reset TX queue and mbuf release when Vector TX applied. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k_rxtx_vec.c | 68 1 files changed, 68 insertions(+), 0 deletions(-) diff --git a/drivers/net/fm10

[dpdk-dev] [PATCH v3 12/16] fm10k: use func pointer to reset TX queue and mbuf release

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Vector TX use different way to manage TX queue, it's necessary to use different functions to reset TX queue and release mbuf in TX queue. So, introduce 2 function pointers to do such ops. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h|9 +++

[dpdk-dev] [PATCH v3 11/16] fm10k: add Vector TX function

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add Vector TX func fm10k_xmit_pkts_vec to transmit packets. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |5 + drivers/net/fm10k/fm10k_rxtx_vec.c | 150 2 files changed, 155 insertions(+), 0 deletion

[dpdk-dev] [PATCH v3 10/16] fm10k: add func to release mbuf in case Vector RX applied

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Since Vector RX use different variables to trace RX HW ring, it leads to need different func to release mbuf properly. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |1 + drivers/net/fm10k/fm10k_ethdev.c |6 ++ drivers/net/fm10k

[dpdk-dev] [PATCH v3 09/16] fm10k: add function to decide best RX function

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add func fm10k_set_rx_function to decide best RX func in fm10k_dev_rx_init Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h|1 + drivers/net/fm10k/fm10k_ethdev.c | 36 2 files changed, 33 insertions(+),

[dpdk-dev] [PATCH v3 08/16] fm10k: add Vector RX scatter function

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add func fm10k_recv_scattered_pkts_vec to receive chained packets with SSE instructions. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |2 + drivers/net/fm10k/fm10k_rxtx_vec.c | 88 2 files changed,

[dpdk-dev] [PATCH v3 07/16] fm10k: add func to do Vector RX condition check

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add func fm10k_rx_vec_condition_check to check if Vector RX func can be applied. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |1 + drivers/net/fm10k/fm10k_rxtx_vec.c | 31 +++ 2 files changed, 32 insertions

[dpdk-dev] [PATCH v3 06/16] fm10k: add Vector RX function

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add func fm10k_recv_raw_pkts_vec to parse raw packets, in which includes possible chained packets. Add func fm10k_recv_pkts_vec to receive single mbuf packet. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |1 + drivers/net/fm10k/fm10k_rxt

[dpdk-dev] [PATCH v3 05/16] fm10k: add 2 functions to parse pkt_type and offload flag

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add 2 functions, in which using SSE instructions to parse RX desc to get pkt_type and ol_flags in mbuf. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k_rxtx_vec.c | 127 1 files changed, 127 insertions(+), 0 deletions

[dpdk-dev] [PATCH v3 04/16] fm10k: add func to re-allocate mbuf for RX ring

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add function fm10k_rxq_rearm to re-allocate mbuf for used desc in RX HW ring. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |9 drivers/net/fm10k/fm10k_ethdev.c |3 + drivers/net/fm10k/fm10k_rxtx_vec.c | 90 ++

[dpdk-dev] [PATCH v3 03/16] fm10k: Add a new func to initialize all parameters

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add new function fm10k_params_init to initialize all fm10k related variables. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k_ethdev.c | 35 +++ 1 files changed, 23 insertions(+), 12 deletions(-) diff --git a/drivers/net

[dpdk-dev] [PATCH v3 02/16] fm10k: add vPMD pre-condition check for each RX queue

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add condition check in rx_queue_setup func. If number of RX desc can't satisfy vPMD requirement, record it into a variable. Or call fm10k_rxq_vec_setup to initialize Vector RX. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h | 11 ---

[dpdk-dev] [PATCH v3 01/16] fm10k: add new vPMD file

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add new file fm10k_rxtx_vec.c and add it into compiling. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/Makefile |1 + drivers/net/fm10k/fm10k_rxtx_vec.c | 45 2 files changed, 46 insertions(+), 0 deletions(-)

[dpdk-dev] [PATCH v3 00/16] Vector Rx/Tx PMD implementation for fm10k

2015-10-27 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" v3: - Add a blank line after variable definition. - Do floor alignment for passing in argument nb_pkts to avoid memory overwritten. - Only scan max of 32 desc in scatter Rx function to avoid memory overwritten. v2: - Fix a typo issue. - Fix an improper prefetch in

[dpdk-dev] [PATCH] lib/librte_ether: Prevent link status race condition when LSI enabled

2015-10-27 Thread Tim Shearer
Calling the Ethernet driver's link_update function from rte_eth_dev_start can result in a race condition if the NIC raises the link interrupt at the same time. Depending on the interrupt handler implementation, the race can cause the it to think that it received two consecutive link up interrupt

[dpdk-dev] [PATCH v8 8/8] doc: update release note for vhost-user mq support

2015-10-27 Thread Yuanhan Liu
On Mon, Oct 26, 2015 at 09:22:10PM +0100, Thomas Monjalon wrote: > 2015-10-22 20:35, Yuanhan Liu: > > +* **vhost: added vhost-user mulitple queue support.** > > + > > + Added vhost-user multiple queue support. > > Excepted the typo, it is the same sentence twice, so not needed. Good to know; I t

[dpdk-dev] [PATCH] ixgbe: change logging for ixgbe tx code path selection

2015-10-27 Thread Traynor, Kevin
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, October 27, 2015 12:13 PM > To: Richardson, Bruce; Traynor, Kevin > Cc: dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH] ixgbe: change logging for ixgbe tx code path > selection > > > > > -Original Message- > > F

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-27 Thread Yuanhan Liu
On Tue, Oct 27, 2015 at 11:17:16AM +0200, Michael S. Tsirkin wrote: > On Tue, Oct 27, 2015 at 03:20:40PM +0900, Tetsuya Mukawa wrote: > > On 2015/10/26 14:42, Yuanhan Liu wrote: > > > On Mon, Oct 26, 2015 at 02:24:08PM +0900, Tetsuya Mukawa wrote: > > >> On 2015/10/22 21:35, Yuanhan Liu wrote: > >

[dpdk-dev] [PATCH v3 4/4] doc: update release note for fm10k VMDQ support

2015-10-27 Thread Shaopeng He
Signed-off-by: Shaopeng He --- doc/guides/rel_notes/release_2_2.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst index 5687676..278149f 100644 --- a/doc/guides/rel_notes/release_2_2.rst +++ b/doc/guides/rel_n

[dpdk-dev] [PATCH v3 3/4] fm10k: add VMDQ support in multi-queue configure

2015-10-27 Thread Shaopeng He
Add separate functions to configure VMDQ and RSS. Update dglort map and logic ports accordingly. Reset MAC/VLAN filter after VMDQ config was changed. Signed-off-by: Shaopeng He --- drivers/net/fm10k/fm10k_ethdev.c | 164 +-- 1 file changed, 141 insertions(+),

[dpdk-dev] [PATCH v3 2/4] fm10k: add VMDQ support in MAC/VLAN filter

2015-10-27 Thread Shaopeng He
The patch does below things for fm10k MAC/VLAN filter: - Add separate functions for VMDQ and main VSI to change MAC filter. - Disable modification to VLAN filter in VMDQ mode. - In device close phase, delete logic ports to remove all MAC/VLAN filters belonging to those ports. Signed-off-by: Sh

[dpdk-dev] [PATCH v3 1/4] fm10k: add multi-queue checking

2015-10-27 Thread Shaopeng He
Add multi-queue checking in device configure function. Currently, VMDQ and RSS are supported. Signed-off-by: Shaopeng He --- drivers/net/fm10k/fm10k_ethdev.c | 44 1 file changed, 44 insertions(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/n

[dpdk-dev] [PATCH v3 0/4] fm10k: add VMDQ support

2015-10-27 Thread Shaopeng He
This patch series adds VMDQ support for fm10k. It includes the functions to configure VMDQ mode and add MAC address for each VMDQ queue pool. It also includes logic to do sanity check for multi-queue settings. Changes in v3: - Keep device default MAC address even in VMDQ mode after queue pool co

[dpdk-dev] [PATCH v3 1/1] vmxnet3: add PCI Port Hotplug support

2015-10-27 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_2_2.rst | 2 ++ drivers/net/vmxnet3/vmxnet3_ethdev.c | 33 + 2 files changed, 31 insertions(+), 4 deletions(-) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.

[dpdk-dev] [PATCH v3 0/1] vmxnet3 hotplug support

2015-10-27 Thread Bernard Iremonger
add PCI Port Hotplug support to the vmxnet3 PMD This patch depends on v5 of the following patch set: remove-pci-driver-from-vdevs.patch Changes in v3: Rebase. Changes in v2: Update release notes. Bernard Iremonger (1): vmxnet3: add PCI Port Hotplug support doc/guides/rel_notes/release_2_2.

[dpdk-dev] [PATCH v3] examples/vmdq: Fix the core dump issue when mem_pool is more than 34

2015-10-27 Thread Xutao Sun
Macro MAX_QUEUES was defined to 128, only allow 16 vmdq_pools in theory. When running vmdq_app with more than 34 vmdq_pools, it will cause the core_dump issue. Change MAX_QUEUES to 1024 will solve this issue. Signed-off-by: Xutao Sun --- v2: - Rectify the NUM_MBUFS_PER_PORT since MAX_QUEUES has

[dpdk-dev] [PATCH] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Yuanhan Liu
On Tue, Oct 27, 2015 at 08:46:48AM +, Xie, Huawei wrote: > On 10/27/2015 4:39 PM, Yuanhan Liu wrote: > > On Tue, Oct 27, 2015 at 08:24:00AM +, Xie, Huawei wrote: > >> On 10/27/2015 3:52 PM, Tetsuya Mukawa wrote: > >>> The patch fixes wrong handling of virtqueue array index when > >>> GET_VR

[dpdk-dev] [PATCH 0/3] Add VHOST PMD

2015-10-27 Thread Tetsuya Mukawa
Below patch has been submitted as a separate patch. - [dpdk-dev,1/3] vhost: Fix wrong handling of virtqueue array index (http://dpdk.org/dev/patchwork/patch/8038/) Tetsuya On 2015/10/27 15:12, Tetsuya Mukawa wrote: > The patch introduces a new PMD. This PMD is implemented as thin wrapper >

[dpdk-dev] [PATCH] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Tetsuya Mukawa
The patch fixes wrong handling of virtqueue array index when GET_VRING_BASE message comes. The vhost backend will receive the message per virtqueue. Also we should call a destroy callback handler when both RXQ and TXQ receives the message. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/vhost

[dpdk-dev] [PATCH] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Yuanhan Liu
On Tue, Oct 27, 2015 at 08:24:00AM +, Xie, Huawei wrote: > On 10/27/2015 3:52 PM, Tetsuya Mukawa wrote: > > The patch fixes wrong handling of virtqueue array index when > > GET_VRING_BASE message comes. > > The vhost backend will receive the message per virtqueue. > > Also we should call a dest

[dpdk-dev] [PATCH v2 15/16] lpm/arm: implement rte_lpm_lookupx4 using rte_lpm_lookup_bulk on for-x86

2015-10-27 Thread Jan Viktorin
Hi Konstantin, On Tue, 27 Oct 2015 15:31:44 + "Ananyev, Konstantin" wrote: > Hi Jan, > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jan Viktorin > > Sent: Monday, October 26, 2015 4:38 PM > > To: Thomas Monjalon; Hunt, David; dev at dpdk.org > >

[dpdk-dev] [PATCH] doc: update release note for i40e base driver update

2015-10-27 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- doc/guides/rel_notes/release_2_2.rst | 16 1 file changed, 16 insertions(+) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst index de6916e..1665ec7 100644 --- a/doc/guides/rel_notes/release_2_2.rst +++ b/doc

[dpdk-dev] [PATCH v3 00/36] update e1000 base code

2015-10-27 Thread Thomas Monjalon
2015-10-16 10:50, Wenzhuo Lu: > Wenzhuo Lu (36): > e1000/base: update readme and copyright > e1000/base: add new devices > e1000/base: fix issue with link flap on 82579 > e1000/base: fix issue with jumbo frame CRC failures in client > e1000/base: redundant PHY power down for i210 > e100

[dpdk-dev] [PATCH v3 36/36] doc: update release notes for e1000 base code update

2015-10-27 Thread Thomas Monjalon
2015-10-16 10:51, Wenzhuo Lu: > New Features > > > +* **Updated the e1000 base driver.** > + The e1000 base driver was updated with several changes including the > + following: > + > + * Add some new i218 devices > + * Fix issue with link flap on 82579 > + * Fix issue with jum

[dpdk-dev] [PATCH 1/3] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Tetsuya Mukawa
Hi Yuanhan, I appreciate your checking. I haven't noticed SET_BACKEND is only supported by vhost-cuse. :-( I will follow your comments, then submit again. Thanks, Tetsuya On 2015/10/27 15:47, Yuanhan Liu wrote: > On Tue, Oct 27, 2015 at 03:12:53PM +0900, Tetsuya Mukawa wrote: >> The patch fixes

[dpdk-dev] [PATCH v2 2/2] xenvirt: free queues in dev_close

2015-10-27 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/xenvirt/rte_eth_xenvirt.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/net/xenvirt/rte_eth_xenvirt.c b/drivers/net/xenvirt/rte_eth_xenvirt.c index 084a753..6c2c067 100644 --- a/drivers/net/x

[dpdk-dev] [PATCH v2 1/2] xenvirt: add support for Port Hotplug

2015-10-27 Thread Bernard Iremonger
update release notes. Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_2_2.rst | 2 ++ drivers/net/xenvirt/rte_eth_xenvirt.c | 49 ++- drivers/net/xenvirt/rte_xen_lib.c | 26 --- drivers/net/xenvirt/rte_xen_lib.h | 5 +++

[dpdk-dev] [PATCH v2 0/2] xenvirt hotplug support

2015-10-27 Thread Bernard Iremonger
add Port Hotplug support to the xenvirt PMD This patch depends on v5 of the following patch set: remove-pci-driver-from-vdevs.patch Changes in v2: Rebase Update release notes. Bernard Iremonger (2): xenvirt: add support for Port Hotplug xenvirt: free queues in dev_close doc/guides/rel_no

[dpdk-dev] [PATCH] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Yuanhan Liu
On Tue, Oct 27, 2015 at 04:51:46PM +0900, Tetsuya Mukawa wrote: > The patch fixes wrong handling of virtqueue array index when > GET_VRING_BASE message comes. > The vhost backend will receive the message per virtqueue. > Also we should call a destroy callback handler when both RXQ > and TXQ receiv

[dpdk-dev] [PATCH v2 16/16] acl: check for SSE 4.1 support

2015-10-27 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jan Viktorin > Sent: Monday, October 26, 2015 4:38 PM > To: Thomas Monjalon; Hunt, David; dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 16/16] acl: check for SSE 4.1 support > > The main goal of this check i

[dpdk-dev] [PATCH 1/3] vhost: Fix wrong handling of virtqueue array index

2015-10-27 Thread Yuanhan Liu
On Tue, Oct 27, 2015 at 04:28:58PM +0900, Tetsuya Mukawa wrote: > Hi Yuanhan, > > I appreciate your checking. Welcome! And thank you for catching out my faults. --yliu > I haven't noticed SET_BACKEND is only supported by vhost-cuse. :-( > I will follow your comments, then submit again. >

[dpdk-dev] [PATCH v2 15/16] lpm/arm: implement rte_lpm_lookupx4 using rte_lpm_lookup_bulk on for-x86

2015-10-27 Thread Ananyev, Konstantin
Hi Jan, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jan Viktorin > Sent: Monday, October 26, 2015 4:38 PM > To: Thomas Monjalon; Hunt, David; dev at dpdk.org > Cc: Vlastimil Kosar > Subject: [dpdk-dev] [PATCH v2 15/16] lpm/arm: implement rte_lpm_lookupx4

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-27 Thread Tetsuya Mukawa
On 2015/10/26 14:42, Yuanhan Liu wrote: > On Mon, Oct 26, 2015 at 02:24:08PM +0900, Tetsuya Mukawa wrote: >> On 2015/10/22 21:35, Yuanhan Liu wrote: > ... >>> @@ -292,13 +300,13 @@ user_get_vring_base(struct vhost_device_ctx ctx, >>> * sent and only sent in vhost_vring_stop. >>> * TODO: c

  1   2   >