> > In case of creating bond device without add any slaves and
> > quit from testpmd, application crashed since rx/tx queues
> > are NULL.
> >
> > add checking of this paramters before trying to free.
> >
> > Signed-off-by: Raslsn Darawsheh
> > Signed-off-by: Yaacov Hazan
>
> Acked-by: Declan Do
2015-10-14 09:41, Charles Williams:
> On Tue, 2015-10-13 at 14:49 +0200, Olivier MATZ wrote:
> > For PCI devices that have several interfaces (I think it's the case for
> > some Mellanox boards), maybe we should not store the interface name?
>
> I am not sure what you mean here. If a device has
> >Signed-off-by: Chas Williams <3chas3 at gmail.com>
>
> Acked-by: Harish Patil
Applied, thanks
> > > Someone may need to call rte_eal_init() with a fake argc/argv array
> > > in the middle of using getopt() to parse its own unrelated argc/argv
> > > parameters. So getopt lib shouldn't be reset by rte_eal_init().
> > >
> > > Now eal will always save optind, optarg and optopt (and optreset on
2015-10-27 17:38, Tim Shearer:
> Calling the Ethernet driver's link_update function from rte_eth_dev_start can
> result in a race condition if the NIC raises the link interrupt at the same
> time. Depending on the interrupt handler implementation, the race can cause
> the it to think that it rec
When stop device, should disable interrupt of FDIR but not
enable it. This patch corrected it.
Signed-off-by: Jingjing Wu
---
drivers/net/i40e/i40e_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
ind
2015-10-20 15:20, Simon Kagstrom:
> The tx_rate unit is Mbps.
>
> Gleaned from the ixgbe implementation, the 82599 datasheet and the use
> in test-pmd.
>
> Signed-off-by: Simon Kagstrom
Applied, thanks
> > This patch set adds new flow director behavior "passthru" on Intel X(L)710
> > NIC.
> > When this mode is selected flow director will direct packet to LAN while the
> > queue is defined by other filters. This can be used to extract flexible
> > payload
> > to RX desriptor with the flow directo
This commit introduce rte_smp_mb(), rte_smp_wmb() and rte_smp_rmb(), in
order to enable memory barriers between lcores.
The patch does not provide any functional change for IA, the goal is to
have infrastructure for weakly ordered machines like ARM to work on DPDK.
Signed-off-by: Jerin Jacob
---
Its a RFC patch and I am not sure about the ordering behavior in
tile and ppc_64 architecture so kept as rte_compiler_barrier()
as existing code.
If it need changes in tile and ppc_64 then let me know, I will send the
updated patch.
Jerin Jacob (1):
Introduce rte_smp_*mb() for memory barrier
Is there a way where we can just define the fields that ought to be there in
the mbuf structure, but the position and size is implementation dependent ? The
application can provide "mbuf_impl.h" that contains mbuf_rte fields in the
order that seems appropriate to application.
--
- Thanks
char *
Change the vhost sample to support and test TX offload.
Signed-off-by: Jijiang Liu
---
examples/vhost/main.c | 128 ++---
1 files changed, 111 insertions(+), 17 deletions(-)
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 9eac2d0..06
Dequeue vhost TX offload in vhost lib.
Signed-off-by: Jijiang Liu
---
lib/librte_vhost/vhost_rxtx.c | 108 -
1 files changed, 107 insertions(+), 1 deletions(-)
diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c
index 9322ce6..86bf
Enqueue vhost TX checksum and TSO4/6 offload in virtio-net lib.
Signed-off-by: Jijiang Liu
---
drivers/net/virtio/virtio_rxtx.c | 61 ++
1 files changed, 61 insertions(+), 0 deletions(-)
diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/vir
Enqueue vhost TX checksum and TSO4/6 offload in virtio-net lib.
Signed-off-by: Jijiang Liu
---
lib/librte_vhost/virtio-net.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c
index 14278de..81bd309 100644
-
Fill virtio device info for TX offload.
Signed-off-by: Jijiang Liu
---
drivers/net/virtio/virtio_ethdev.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virtio_ethdev.c
index cb5dfee..b831c02 100644
---
Add vhost TX checksum and TSO capabilities in virtio-net lib.
Signed-off-by: Jijiang Liu
---
drivers/net/virtio/virtio_ethdev.h |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.h
b/drivers/net/virtio/virtio_ethdev.h
index 9026d42..6ee
Record virtual address of virtio net header.
Signed-off-by: Jijiang Liu
---
drivers/net/virtio/virtio_ethdev.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virtio_ethdev.c
index 465d3cd..cb5dfee 100644
--- a/d
The virtual addr for virtio net header need to be recorded.
Signed-off-by: Jijiang Liu
---
drivers/net/virtio/virtqueue.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 689c321..5b43eeb 100644
--- a/d
Adds vhost TX offload support.
The patch set add the negotiation between us-vhost and virtio-net for vhost TX
offload(checksum and TSO), and add the TX offload support in the libs and
change vhost sample and csum application to test these changes.
v3 change:
rebase latest codes.
v2 change:
2015-11-04 08:14, Qiu, Michael:
> On 2015/11/4 14:14, Chao Zhu wrote:
> > The fm10k vector driver is specific for x86 platform which can't compile
> > on IBM POWER for lacking of tmmintrin.h header file. This patch turns
> > off fm10k driver compilation on IBM POWER to prevent compile issue.
> >
>
2015-11-04 17:05, Bruce Richardson:
> The i40e driver was using a #define value for the max number of rxtx
> interrupts
> supported. This value was defined only for linux, giving an error when
> compiling
> on FreeBSD.
>
> CC i40e_ethdev.o
> /usr/home/bruce/dpdk.org/drivers/net/i40e/i40e_ethde
2015-11-04 16:14, Harry van Haaren:
> This patch removes l3_l4_xsum_errors from rx errors.
>
> The reason to remove it is that UDP packets have an optional checksum, and
> when not calculated the checksum field should be set to zero. When the
> checksum is not calculated (zero-ed out), the hardwar
> > Following the same approach taken with dev_started field
> > in rte_eth_dev_data structure, this patch adds two new fields
> > in it, rx_queue_state and tx_queue_state arrays, which track
> > which queues have been started and which not.
> >
> > This is important to avoid trying to start/stop
On 04.11.15 16:54, Van Haaren, Harry wrote:
>> From: Martin Weiser [mailto:martin.weiser at allegro-packets.com]
>> Subject: Re: [dpdk-dev] ixgbe: ierrors counter spuriously increasing in DPDK
>> 2.1
>> The
>> rx-error which showed up immediately after starting the interface is
>> gone since this
2015-11-04 23:01, Jingjing Wu:
> When stop device, should disable interrupt of FDIR but not
> enable it. This patch corrected it.
>
> Signed-off-by: Jingjing Wu
Applied, thanks
The old statistics on i40e only counted the packets on ports.
So the discarding packets on VSI were not counted.
This patch is to make statistics for packets both on ports and VSI.
Also update release notes.
Signed-off-by: Xutao Sun
---
v2:
- reword comments
v3:
- update release notes
v4:
- fi
2015-11-04 15:50, Harry van Haaren:
> This patch removes l3_l4_xsum_errors from rx errors.
>
> The reason to remove it is that UDP packets have an optional checksum, and
> when not calculated the checksum field should be set to zero. When the
> checksum is not calculated (zero-ed out), the hardwar
The i40e driver was using a #define value for the max number of rxtx interrupts
supported. This value was defined only for linux, giving an error when compiling
on FreeBSD.
CC i40e_ethdev.o
/usr/home/bruce/dpdk.org/drivers/net/i40e/i40e_ethdev.c:3885:9: fatal error:
use of undeclared
id
This patch updates the release notes with the features
added to ip_pipeline application.
v2:
*placed the release notes under New Features header
Signed-off-by: Jasvinder Singh
---
doc/guides/rel_notes/release_2_2.rst | 33 +
1 file changed, 33 insertions(+)
diff
On Tue, Nov 03, 2015 at 03:00:15PM +, Polehn, Mike A wrote:
> Adds Eth driver prefetch variable structure to CPU cache 0 while calling into
> tx or rx
> device driver operation.
>
> RFC 2544 test of NIC task test measurement points show improvement of lower
> latency and/or better packet th
The patch enables rx interrupt support on i40e VF and some necessary change on
PF IOV mode to support VF.
On PF side, running in IOV mode via uio won't allow rx interrupt which is
exclusive with mbox interrupt
in single vector competition.
On VF side, one single vector is shared for all the rx qu
The patch enables rx interrupt support on i40e PF non-IOV mode.
Per queue rx interrupt works on vfio, however on uio, all rx queues share one
interrupt vector.
v4 change:
- remove redundancy condition check
v3 change:
- macro change according the EAL
- add doc update follow on the code cha
When igb runs as a PF, mbox interrupt is prerequisite to make VF start normally.
And PF sometimes won't 'dev_start', so the mbox interrupt register during
'dev_init' is required.
The patch rolls back the interrupt register for mbox,lsc to the 'dev_init'.
As UIO doesn't support multiple vector, mbo
As ixgbe vf doesn't support lsc, the patch removes those unused code.
In addition, it does some tiny cleanup.
Signed-off-by: Cunming Liang
---
drivers/net/ixgbe/ixgbe_ethdev.c | 62 +---
1 file changed, 1 insertion(+), 61 deletions(-)
diff --git a/drivers/net
The intr_vec is free in dev_stop. It's not necessary to check in dev_close.
Signed-off-by: Cunming Liang
---
drivers/net/ixgbe/ixgbe_ethdev.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index c322168..948a84f 10064
When ixgbe runs as a PF, mbox interrupt is prerequisite to make VF start
normally.
And PF sometimes won't 'dev_start', so the mbox interrupt register during
'dev_init' is required.
The patch rolls back the interrupt register for mbox,lsc to the 'dev_init'.
As UIO doesn't support multiple vector,
VFIO allows multiple MSI-X vector, others doesn't, but maybe will allow it in
the future.
Device drivers need to be aware of the capability.
It's better to avoid condition check on interrupt type(VFIO) everywhere, instead
a capability api is more flexible for the condition change.
v3 change:
-
Signed-off-by: Cunming Liang
---
drivers/net/e1000/igb_ethdev.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 1332974..76d2acc 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/ig
Signed-off-by: Cunming Liang
---
drivers/net/ixgbe/ixgbe_ethdev.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 153ba98..f1a738c 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/dri
The patch adds condition check to avoid enable nothing.
In disable state, both max_intr and nb_efd are zero.
Signed-off-by: Cunming Liang
---
lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h | 3 ++-
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 8 +++-
lib/lib
According to the VFIO interrupt mapping, the interrupt vector id for rxq starts
from RX_VEC_START.
It doesn't impact the UIO cases.
v3 change:
- macro renaming according to the EAL change
Signed-off-by: Cunming Liang
---
drivers/net/e1000/e1000_ethdev.h | 3 +++
drivers/net/e1000/igb_ethdev
According to the VFIO interrupt mapping, the interrupt vector id for rxq starts
from RX_VEC_START.
It doesn't impact the UIO cases.
v3 changes:
- macro renaming according to the EAL change
Signed-off-by: Cunming Liang
---
drivers/net/ixgbe/ixgbe_ethdev.c | 22 ++
drivers/
During VFIO_DEVICE_SET_IRQS, the previous order is {Q0_fd, ... Qn_fd, misc_fd}.
The vector number of misc is indeterminable which is ugly to some NIC(e.g.
i40e, fm10k).
The patch adjusts the order in {misc_fd, Q0_fd, ... Qn_fd}, always reserve the
first vector to misc interrupt.
v3 changes:
-
v4 change:
- remove redundancy condition check on PF
v3 changes:
- rename MISC_VEC_ID and RX_VEC_START
- add bsdapp dummy
- split cleanup and fix patches
- merge doc update along with code change
v2 changes:
- rework to depend on one previous patch
patch http://dpdk.org/dev/patchw
Change the vhost sample to support and test TX offload.
Signed-off-by: Jijiang Liu
---
examples/vhost/main.c | 128 ++---
1 files changed, 111 insertions(+), 17 deletions(-)
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 9eac2d0..06
Dequeue vhost TX offload in vhost lib.
Signed-off-by: Jijiang Liu
---
lib/librte_vhost/vhost_rxtx.c | 108 -
1 files changed, 107 insertions(+), 1 deletions(-)
diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c
index 7026bfa..a888
Enqueue vhost TX checksum and TSO4/6 offload in virtio-net lib.
Signed-off-by: Jijiang Liu
---
drivers/net/virtio/virtio_rxtx.c | 61 ++
1 files changed, 61 insertions(+), 0 deletions(-)
diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/vir
Enqueue vhost TX checksum and TSO4/6 offload in virtio-net lib.
Signed-off-by: Jijiang Liu
---
lib/librte_vhost/virtio-net.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c
index 14278de..81bd309 100644
-
Fill virtio device info for TX offload.
Signed-off-by: Jijiang Liu
---
drivers/net/virtio/virtio_ethdev.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virtio_ethdev.c
index cb5dfee..b831c02 100644
---
Add vhost TX checksum and TSO capabilities in virtio-net lib.
Signed-off-by: Jijiang Liu
---
drivers/net/virtio/virtio_ethdev.h |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.h
b/drivers/net/virtio/virtio_ethdev.h
index 9026d42..6ee
Record virtual address of virtio net header.
Signed-off-by: Jijiang Liu
---
drivers/net/virtio/virtio_ethdev.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virtio_ethdev.c
index 465d3cd..cb5dfee 100644
--- a/d
The virtual addr for virtio net header need to be recorded.
Signed-off-by: Jijiang Liu
---
drivers/net/virtio/virtqueue.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 7789411..530f840 100644
--- a/d
Adds vhost TX offload support.
The patch set add the negotiation between us-vhost and virtio-net for vhost TX
offload(checksum and TSO), and add the TX offload support in the libs and
change vhost sample and csum application to test these changes.
v3 change:
rebase latest codes.
v2 change:
On Wed, Nov 04, 2015 at 02:10:50PM +, Bruce Richardson wrote:
> On Wed, Nov 04, 2015 at 11:24:18AM +0100, Adrien Mazarguil wrote:
> > On Wed, Nov 04, 2015 at 02:19:36AM +0100, Thomas Monjalon wrote:
> > > 2015-11-03 12:00, Bruce Richardson:
> > > > Move the function ptr and port id checking mac
This patch removes l3_l4_xsum_errors from rx errors.
The reason to remove it is that UDP packets have an optional checksum, and
when not calculated the checksum field should be set to zero. When the
checksum is not calculated (zero-ed out), the hardware still counts a valid
UDP packet as an l3_l4_
2015-11-02 12:25, Alejandro.Lucero:
> +static struct eth_dev_ops nfp_net_eth_dev_ops = {
> + .dev_configure = nfp_net_configure,
> + .dev_start = nfp_net_start,
> + .dev_stop = nfp_net_stop,
> + .dev_close = nfp_net_close,
> +
2015-11-02 12:25, Alejandro.Lucero:
> +Before using the Netronome's DPDK PMD some NFP-6xxx configuration,
> +which is not related to DPDK, is required. The system requires
> +installation of **Netronome's BSP (Board Support Package)** which includes
> +Linux drivers, programs and libraries.
Do you
> From: Martin Weiser [mailto:martin.weiser at allegro-packets.com]
> Subject: Re: [dpdk-dev] ixgbe: ierrors counter spuriously increasing in DPDK
> 2.1
> The
> rx-error which showed up immediately after starting the interface is
> gone since this was probably caused by mac_remote_errors.
Impro
2015-10-31 03:06, He, Shaopeng:
> > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > The problem is that i40e interrupt patches are not merge-able.
> > They are not enough reviewed especially for igb/ixgbe and vfio changes.
> Thanks for your time, understood.
Now that i40e interrupt
This patch removes l3_l4_xsum_errors from rx errors.
The reason to remove it is that UDP packets have an optional checksum, and
when not calculated the checksum field should be set to zero. When the
checksum is not calculated (zero-ed out), the hardware still counts a valid
UDP packet as an l3_l4_
Yes. It will build by now.
Once we add the PF then BSP will be needed. I guess this is the same for
MLX PMDs needing specific Mellanox libraries.
On Wed, Nov 4, 2015 at 3:03 PM, Thomas Monjalon
wrote:
> 2015-11-02 12:25, Alejandro.Lucero:
> > +Before using the Netronome's DPDK PMD some NFP-6xxx
2015-11-04 16:45, Cunming Liang:
> v4 change:
> - remove redundancy condition check on PF
>
> v3 changes:
> - rename MISC_VEC_ID and RX_VEC_START
> - add bsdapp dummy
> - split cleanup and fix patches
> - merge doc update along with code change
>
> v2 changes:
> - rework to depend on
>
> Hi Jasvinder,
>
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jasvinder Singh
> > Sent: Wednesday, November 04, 2015 3:05 PM
> > To: dev at dpdk.org
> > Subject: [dpdk-dev] [PATCH] doc: update release notes for ip_pipeline
> > app
> >
> > This patc
Hi Jasvinder,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jasvinder Singh
> Sent: Wednesday, November 04, 2015 3:05 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: update release notes for ip_pipeline app
>
> This patch updates the release no
This patch updates the release notes with the features
added to ip_pipeline application.
Signed-off-by: Jasvinder Singh
---
doc/guides/rel_notes/release_2_2.rst | 49
1 file changed, 49 insertions(+)
diff --git a/doc/guides/rel_notes/release_2_2.rst
b/doc/g
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Helin Zhang
> Sent: Tuesday, November 3, 2015 3:40 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v3 0/2] i40e: Enlarge the number of supported
> queues
>
> It enlarges the number of supported queues to h
Hi Martin
Thank you very much for reporting the issue!
Could you help to add more detailed steps and other information?
We will try to reproduce what have seen in our lab, and then debug.
Regards,
Helin
> -Original Message-
> From: Martin Weiser [mailto:martin.weiser at allegro-packets.c
> From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com]
> Sent: Wednesday, November 04, 2015 1:29 PM
> To: dev at dpdk.org
> Cc: thomas.monjalon at 6wind.com; Hunt, David; viktorin at rehivetech.com;
> Ananyev, Konstantin; Richardson, Bruce; Xie, Huawei;
> changchun.ouyang at intel.com; zlu
The change in tsc value from rte_rdtsc() needs to be multiplied by the scale to
convert from clocks to get change in seconds.
For example from below:
elapse_us = (rte_rdtsc() - entry->tsc_first_packet) * flow_time_scale_us;
The bit rate requires the number of bytes passed in the time period then
2015-11-04 12:52, Liu, Jijiang:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > Please could you check that your virtio implementation works with a vanilla
> > Linux with or without vhost?
> > Thanks
[...]
> Xu Qian can send the test report out.
Yes please, I'd like to see a te
On Tue, Nov 03, 2015 at 02:00:29PM -0800, Stephen Hemminger wrote:
> On Tue, 3 Nov 2015 12:00:59 +
> Bruce Richardson wrote:
>
> > * @return
> > - * The number of used descriptors in the specific queue.
> > + * The number of used descriptors in the specific queue, or:
> > + * (-EINVAL
The fm10k vector driver is specific for x86 platform which can't compile
on IBM POWER for lacking of tmmintrin.h header file. This patch turns
off fm10k driver compilation on IBM POWER to prevent compile issue.
Signed-off-by: Chao Zhu
---
config/defconfig_ppc_64-power8-linuxapp-gcc |1 +
1 f
On Wed, Nov 04, 2015 at 11:24:18AM +0100, Adrien Mazarguil wrote:
> On Wed, Nov 04, 2015 at 02:19:36AM +0100, Thomas Monjalon wrote:
> > 2015-11-03 12:00, Bruce Richardson:
> > > Move the function ptr and port id checking macros to the header file, so
> > > that they can be used in the static inlin
The patch enables rx interrupt support on i40e VF and some necessary change on
PF IOV mode to support VF.
On PF side, running in IOV mode via uio won't allow rx interrupt which is
exclusive with mbox interrupt
in single vector competition.
On VF side, one single vector is shared for all the rx qu
The patch enables rx interrupt support on i40e PF non-IOV mode.
Per queue rx interrupt works on vfio, however on uio, all rx queues share one
interrupt vector.
v3 change:
- macro change according the EAL
- add doc update follow on the code change
v2 change:
- add write flush
- al
When igb runs as a PF, mbox interrupt is prerequisite to make VF start normally.
And PF sometimes won't 'dev_start', so the mbox interrupt register during
'dev_init' is required.
The patch rolls back the interrupt register for mbox,lsc to the 'dev_init'.
As UIO doesn't support multiple vector, mbo
As ixgbe vf doesn't support lsc, the patch removes those unused code.
In addition, it does some tiny cleanup.
Signed-off-by: Cunming Liang
---
drivers/net/ixgbe/ixgbe_ethdev.c | 62 +---
1 file changed, 1 insertion(+), 61 deletions(-)
diff --git a/drivers/net
The intr_vec is free in dev_stop. It's not necessary to check in dev_close.
Signed-off-by: Cunming Liang
---
drivers/net/ixgbe/ixgbe_ethdev.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 6b075f6..d5556cc 10064
When ixgbe runs as a PF, mbox interrupt is prerequisite to make VF start
normally.
And PF sometimes won't 'dev_start', so the mbox interrupt register during
'dev_init' is required.
The patch rolls back the interrupt register for mbox,lsc to the 'dev_init'.
As UIO doesn't support multiple vector,
VFIO allows multiple MSI-X vector, others doesn't, but maybe will allow it in
the future.
Device drivers need to be aware of the capability.
It's better to avoid condition check on interrupt type(VFIO) everywhere, instead
a capability api is more flexible for the condition change.
v3 change:
-
Signed-off-by: Cunming Liang
---
drivers/net/e1000/igb_ethdev.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 1332974..76d2acc 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/ig
Signed-off-by: Cunming Liang
---
drivers/net/ixgbe/ixgbe_ethdev.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 153ba98..f1a738c 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/dri
The patch adds condition check to avoid enable nothing.
In disable state, both max_intr and nb_efd are zero.
Signed-off-by: Cunming Liang
---
lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h | 3 ++-
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 8 +++-
lib/lib
According to the VFIO interrupt mapping, the interrupt vector id for rxq starts
from RX_VEC_START.
It doesn't impact the UIO cases.
v3 change:
- macro renaming according to the EAL change
Signed-off-by: Cunming Liang
---
drivers/net/e1000/e1000_ethdev.h | 3 +++
drivers/net/e1000/igb_ethdev
According to the VFIO interrupt mapping, the interrupt vector id for rxq starts
from RX_VEC_START.
It doesn't impact the UIO cases.
v3 changes:
- macro renaming according to the EAL change
Signed-off-by: Cunming Liang
---
drivers/net/ixgbe/ixgbe_ethdev.c | 22 ++
drivers/
During VFIO_DEVICE_SET_IRQS, the previous order is {Q0_fd, ... Qn_fd, misc_fd}.
The vector number of misc is indeterminable which is ugly to some NIC(e.g.
i40e, fm10k).
The patch adjusts the order in {misc_fd, Q0_fd, ... Qn_fd}, always reserve the
first vector to misc interrupt.
v3 changes:
-
v3 change:
- rename MISC_VEC_ID and RX_VEC_START
- add bsdapp dummy
- split cleanup and fix patches
- merge doc update along with code change
v2 change:
- rework to depend on one previous patch
patch http://dpdk.org/dev/patchwork/patch/7504/
- always set DIS_AUTOMASK_* bit in PF to
On Wed, Nov 4, 2015 at 9:45 AM, Cunming Liang
wrote:
> VFIO allows multiple MSI-X vector, others doesn't, but maybe will allow it
> in the future.
> Device drivers need to be aware of the capability.
> It's better to avoid condition check on interrupt type(VFIO) everywhere,
> instead
> a capabili
On Wed, Nov 4, 2015 at 9:45 AM, Cunming Liang
wrote:
> The patch adds condition check to avoid enable nothing.
> In disable state, both max_intr and nb_efd are zero.
>
> Signed-off-by: Cunming Liang
>
Acked-by: David Marchand
--
David Marchand
On Wed, Nov 4, 2015 at 9:45 AM, Cunming Liang
wrote:
> During VFIO_DEVICE_SET_IRQS, the previous order is {Q0_fd, ... Qn_fd,
> misc_fd}.
> The vector number of misc is indeterminable which is ugly to some NIC(e.g.
> i40e, fm10k).
> The patch adjusts the order in {misc_fd, Q0_fd, ... Qn_fd}, alway
2015-11-04 11:29, Jingjing Wu:
> This patch set extends flow director to VF filtering in i40e driver.
>
> v2 change:
> - rework the doc, including release notes and testpmd guide
>
> v3 change:
> - rebase doc update to the same commit with code change
>
> v4 change:
> - remove the fix of disa
On Fri, 2015-10-30 at 18:10 -0400, Mussar, Gary wrote:
> I have been attempting to build testpmd with the bnx2x pmd enabled to try and
> talk through a bcm57810 10G NIC card. I have tried using SR-IOV VFs and I
> have tried using the PFs. Neither seem to be able to be properly initialized
> in t
The following structure is defined in virtio standard,
struct virtio_net_hdr {
#define VIRTIO_NET_HDR_F_NEEDS_CSUM 1
u8 flags;
#define VIRTIO_NET_HDR_GSO_NONE 0
#define VIRTIO_NET_HDR_GSO_TCPV4 1
#define VIRTIO_NET_HDR_GSO_UDP 3
#define VIRTIO_NET_HDR_GSO_TCPV6 4
#define VIRTIO_NET_HDR_GSO_ECN 0x
> > The old statistics on i40e only counted the packets on ports.
> > So the discarding packets on VSI were not counted.
> > This patch is to make statistics for packets both on ports and VSI.
> > Also update release notes.
> >
> > Signed-off-by: Xutao Sun
>
> Acked-by: Harry van Haaren
Applie
> -Original Message-
> From: Liu, Jijiang
> Sent: Wednesday, November 4, 2015 8:52 PM
> To: 'Thomas Monjalon'
> Cc: dev at dpdk.org; Michael S. Tsirkin
> Subject: RE: [dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX
> offload
>
> Hi Thomas,
>
>
> > -Original Message-
>
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, November 4, 2015 7:18 PM
> To: Liu, Jijiang
> Cc: dev at dpdk.org; Michael S. Tsirkin
> Subject: Re: [dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX
> offload
>
> 2015
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, November 4, 2015 7:18 PM
> To: Liu, Jijiang
> Cc: dev at dpdk.org; Michael S. Tsirkin
> Subject: Re: [dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost
The following code
On 2015-11-04 11:35, Thomas Monjalon wrote:
> 2015-08-20 08:51, Simon Kagstrom:
>> -ifeq ($(shell test -f /proc/version_signature && lsb_release -si
>> 2>/dev/null),Ubuntu)
>> +ifeq ($(shell lsb_release -si 2>/dev/null),Ubuntu)
>> MODULE_CFLAGS += -DUBUNTU_RELEASE_CODE=$(shell lsb_release -sr | t
2015-11-04 18:54, Jijiang Liu:
> + /* if vhost TX checksum offload is required */
> + if (m->ol_flags & PKT_TX_IP_CKSUM) {
> + hdr->csum_start = m->l2_len;
> + hdr->csum_offset = offsetof(struct ipv4_hdr, hdr_checksum);
> + } else if (m->ol_flags & PKT_
1 - 100 of 160 matches
Mail list logo