[dpdk-dev] [PATCH] fm10k: fix a crash bug when quit from testpmd

2015-11-12 12:57, Chen Jing D: > From: "Chen Jing D(Mark)" > > When the fm10k port is closed, both func tx_queue_clean() and > fm10k_tx_queue_release_mbufs_vec() will try to release buffer in > SW ring. The latter func won't do sanity check on those pointers > and cause crash. > > The fix

[dpdk-dev] [PATCH] ring: Fix memory leakage in rte_pmd_ring_devuninit

2015-11-20 19:24, Mauricio Vasquez B: > When freeing the device it is also neccesary to free > rx_queues and tx_queues > > Signed-off-by: Mauricio Vasquez B studenti.polito.it> Applied with spacing fix, thanks

[dpdk-dev] [PATCH v3 11/11] bnx2x: Add BNX2X PMD versioning

Add BNX2X PMD version, print it as part of adapter info. Adjusted print adapter info output formatting. This patch versions BNX2X PMD at 1.0.0. Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c | 101 + 1 file changed, 65 insertions(+), 36

[dpdk-dev] [PATCH v3 10/11] config: Enable BNX2X driver build by default

From: Harish Patil Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody --- config/common_bsdapp |4 ++-- config/common_linuxapp |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/config/common_bsdapp b/config/common_bsdapp index

[dpdk-dev] [PATCH v3 09/11] maintainers: Add maintainers for BNX2X PMD

Add maintainers for BNX2X PMD. Add file path to BNX2X PMD guide. Signed-off-by: Rasesh Mody --- MAINTAINERS |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 840faeb..1c94a93 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -304,8 +304,12

[dpdk-dev] [PATCH v3 08/11] bnx2x: Handle zlib compatibility error

Following error will be reported: PMD: ecore_gunzip(): Newer version of zlib required, 1.2.5.2 or higher EAL: Error - exiting with code: 1 Cause: rte_eth_dev_start:err=-1, port=0 Signed-off-by: Rasesh Mody --- doc/guides/nics/bnx2x.rst |4 drivers/net/bnx2x/bnx2x.c

[dpdk-dev] [PATCH v3 07/11] bnx2x: Linux 32bit enablement

Compile tested. Signed-off-by: Rasesh Mody --- doc/guides/nics/bnx2x.rst|8 drivers/net/bnx2x/bnx2x.h| 12 ++-- drivers/net/bnx2x/bnx2x_ethdev.c |2 +- drivers/net/bnx2x/bnx2x_rxtx.c | 11 +++ drivers/net/bnx2x/bnx2x_vfpf.c |4 ++-- 5

[dpdk-dev] [PATCH v3 06/11] bnx2x: FreeBSD enablement

Compile tested. Signed-off-by: Rasesh Mody --- doc/guides/nics/bnx2x.rst|8 drivers/net/bnx2x/bnx2x.c|9 + drivers/net/bnx2x/bnx2x.h| 23 +++ drivers/net/bnx2x/ecore_sp.h |6 ++ 4 files changed, 46 insertions(+) diff --git

[dpdk-dev] [PATCH v3 05/11] bnx2x: Add LICENSE.bnx2x_pmd and update source files

Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/LICENSE.bnx2x_pmd | 28 drivers/net/bnx2x/bnx2x.c | 29 - drivers/net/bnx2x/bnx2x.h | 29 - drivers/net/bnx2x/bnx2x_ethdev.c|4

[dpdk-dev] [PATCH v3 04/11] doc: Add BNX2X PMD documentationdoc: Add BNX2X PMD documentation

Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody --- doc/guides/nics/bnx2x.rst | 314 + 1 file changed, 314 insertions(+) create mode 100644 doc/guides/nics/bnx2x.rst diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst new file

[dpdk-dev] [PATCH v3 03/11] bnx2x: Add periodic debug option

From: Harish Patil The periodic debug option is used to collect periodic events like statistics, register access etc and won't interfere with user-level messages. Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody --- config/common_bsdapp |1 +

[dpdk-dev] [PATCH v3 02/11] bnx2x: Fix x86_64-native-linuxapp-clang build error

From: Harish Patil Fix for the following clang build error: drivers/net/bnx2x/elink.c:10384:41: error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value] vars->eee_status &= ~SHMEM_EEE_1G_ADV <<

[dpdk-dev] [PATCH v3 01/11] bnx2x: Update VF to support newer PF drivers

From: Harish Patil SR-IOV is supported using bnx2x poll mode driver running as VF driver and native linux driver running as PF (in host/hypervisor). There is no issue while running with the PF driver which is at the base version as that of PMD. However, there is a

[dpdk-dev] [PATCH v3 00/11] bnx2x: Enhancement, fixes, licensing and doumentation

Hi Thomas, This patch set consists of enhancements, fixes, licensing and documentation changes for the QLogic bnx2x Poll Mode Driver. The patches addresses the latets review feedback and have been generated and tested against latest dpdk tree. This patch set enables the BNX2X PMD and

[dpdk-dev] [PATCH] ethdev: add a missing sanity check for nb_tx_desc during txq setup

> > Add a sanity check for number of tx descriptors requested during tx > > queue setup. Return -EINVAL if the number requested does not meet > > the tx descriptor requirements of the device. > > > > Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information") > > > > Signed-off-by:

[dpdk-dev] [PATCH] i40e: fix the write flush in vf driver

> For i40e vf driver, should use I40EVF_WRITE_FLUSH to flush configuration but > not I40E_WRITE_FLUSH. This patch fixed this issue. > > Fixes: be6c228d4da3 (i40evf: support Rx interrupt) > > Reported-by: Qian Xu > Signed-off-by: Jingjing Wu > Acked-by: Helin Zhang Applied, thanks

[dpdk-dev] [PATCH] i40e: fix the issue dcb cannot be configured when FW version is 5.x

> When NVM version is updated to 5.x, DCB can not be configured. This issue is > because of the FW version validation is not correct. > This patch fixed this issue. > > Fixes: c8b9a3e3fe1b (i40e: support DCB mode) > > Signed-off-by: Jingjing Wu Tested-by: Yulong Pei Applied, thanks

[dpdk-dev] [PATCH] i40e: skip any phy config as a workaround

2015-11-17 15:09, Helin Zhang: > As firmware does not support any link control from software driver > side, any phy config should be ignored as a workaround. Otherwise > the link might not be up again after binding back to kernel driver. > > Signed-off-by: Helin Zhang [...] >

[dpdk-dev] [PATCH v3] i40e: fix BW info update if no dcb enabled

> > If DCB is not enabled, the BW info is not stored for VSI. This patch fixes > > this > > issue by merging functions i40e_vsi_dump_bw_config and > > i40e_vsi_get_bw_info together. > > > > Fixes: c8b9a3e3fe1b (i40e: support DCB mode) > > > > Signed-off-by: Jingjing Wu > Acked-by: Helin Zhang

[dpdk-dev] [PATCH v2] i40e: configure the vector PMD option as no for default for l3fwd undefined ptype issue

2015-11-24 02:47, Zhe Tao: > PATCH v1: configure the vector PMD option as no for FVL > PATCH v2: Update the "know issues" for 2.2 release note > > Issue: l3fwd app need the ptype in the mbuf to forwarding the packets > properly. > but now some drivers like virtio driver and FVL vPMD will not set

[dpdk-dev] [PATCH v2] i40e: fix issue of reconfigure hash enable flags

> > It fixes the issue of not re-configuring hash enable flags (HENA) if there > > is no > > key. > > > > Fixes: d0a349409bd7 ("i40e: support AQ based RSS config") > > > > Signed-off-by: Helin Zhang > Acked-by: Jingjing Wu Applied, thanks

[dpdk-dev] [PATCH v2 0/3] Remove CRC from byte counters

> > Harry van Haaren (3): > > e1000: remove crc size from all byte counters > > ixgbe: remove crc size from all byte counters > > i40e: fix rx/tx size mismatch, remove crc bytes > > Acked-by: Konstantin Ananyev Applied, thanks

[dpdk-dev] [PATCH] igb/e1000: Copy PCI device info after the rte_eal_process_type() check

> > This fixes a bug added to these two drivers by eeefe73 (drivers: copy PCI > > device info to ethdev data) which causes the pci info seen by the primary > > process to become invalidated by secondary process startup. > > This call was added after the process type check in the other drivers. > >

[dpdk-dev] Mellanox dpdk issues

Hi all, For future reference problem root casue was missing package for the kernel version I was using. After doing zypper install kernel-default-devel-3.12.28-4.6.x86_64 Compilation worked fine. Thanks Mellanox team for the support. Regards Sotiris -Original Message- From:

[dpdk-dev] [PATCH] ethdev: fix missing symbol export for rte_eth_dma_zone_reserve()

> > Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime") > > > > Signed-off-by: Panu Matilainen > > Acked-by: John McNamara Applied, thanks

[dpdk-dev] running dpdk 2.1 on openstak causes CPU soft lockup

Hi, I am running DPDK 2.1.0 based app on OpenStack KVM guest. OS of guest is Ubuntu LTS 14.04 3.13 kernel. virtio. After upgrade to dpdk 2.1 (previous version was dpdk 1.8 and it worked fine) we are seeing the following issue: [960.004535] BUG: soft lockup - CPU#3 stuck for 23s! [ip:8419]

[dpdk-dev] [PATCH] igb/e1000: Copy PCI device info after the rte_eal_process_type() check

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jon DeVree > Sent: Monday, November 23, 2015 3:14 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] igb/e1000: Copy PCI device info after the > rte_eal_process_type() check > > This fixes a bug added to

[dpdk-dev] [PATCH] eal: fix plugindir processing to be filesystem agnostic

2015-11-18 08:45, Panu Matilainen: > Not all filesystems supply struct dirent d_type field, in which case > everything in the specified directory would go ignored. One such > filesystem being XFS which RHEL 7 defaults to... stat() the entries > instead. > > Fixes: 9f8eb1d9ca0f ("eal: support

[dpdk-dev] Can't compile DPDK if both CONFIG_RTE_BUILD_COMBINE_LIBS and LIBRTE_PMD_XENVIRT are set to "yes"

Hello! My name is Thiago, I'm trying to compile DPDK 2.0, 2.1 and/or 2.2-rc1, on Ubuntu with Xen support but, it does not build... Also, initially, I'm using DPDK sources from Ubuntu APT repository but, it is also reproducible using upstream DPDK tarball as well, explained as follows: Problem:

[dpdk-dev] [PATCH] eal: fix regression of plugins always requiring full path

2015-11-23 14:05, Panu Matilainen: > The added error checking on plugin initialization in > commit 9f8eb1d9ca0f56d6292db5858c52e6873d0abe51 broke the ability of > loading plugins by their basename from default linker locations. > Only use stat() for directory discovery and leave error handling >

[dpdk-dev] [PATCH 2/2] eal: move empty declarations to doc

2015-11-13 10:35, David Marchand: > No need for those forward declarations (which breaks build when asking for > C++11 or adding pedantic flag). > > Signed-off-by: David Marchand Applied, thanks

[dpdk-dev] [PATCH v7 06/10] mbuf_offload: library to support attaching offloads to a mbuf

On 23/11/15 14:46, Thomas Monjalon wrote: > 2015-11-23 15:17, Thomas Monjalon: >> Yes, it is a totally new work and it probably needs more time to have a >> design working well for most of use cases. >> As I already discussed with Olivier, I think it should be considered as >> experimental. It

[dpdk-dev] [PATCH v7 06/10] mbuf_offload: library to support attaching offloads to a mbuf

2015-11-23 15:17, Thomas Monjalon: > Yes, it is a totally new work and it probably needs more time to have a > design working well for most of use cases. > As I already discussed with Olivier, I think it should be considered as > experimental. It means we can try it but do not consider it as a

[dpdk-dev] [PATCH 14/14] mlx5: add environment variables section to documentation

From: Olga Shern Describe how applications can benefit from CQE compression. Signed-off-by: Olga Shern Signed-off-by: Adrien Mazarguil --- doc/guides/nics/mlx5.rst | 13 + 1 file changed, 13 insertions(+) diff --git a/doc/guides/nics/mlx5.rst

[dpdk-dev] [PATCH 13/14] mlx5: fix available entries in TX rings

From: Nelio Laranjeiro The number of available entries in TX rings is taken before performing completion, effectively making rings smaller than they are and causing TX performance issues under load. Fixes: 2e22920b85d9 ("mlx5: support non-scattered Tx and Rx")

[dpdk-dev] [PATCH 12/14] mlx5: fix local protection error when TX MP to MR cache is full

From: Olga Shern When MP to MR cache is full, the last (newest) MR is freed instead of the first (oldest) one, causing local protection errors during TX. Fixes: 2e22920b85d9 ("mlx5: support non-scattered Tx and Rx") Signed-off-by: Olga Shern Signed-off-by: Adrien Mazarguil

[dpdk-dev] [PATCH 11/14] mlx5: fix TX packet loss after initialization

From: Olga Shern Pre-registering mbuf memory pools when creating TX queues avoids costly registrations later in the data path. Fixes: 2e22920b85d9 ("mlx5: support non-scattered Tx and Rx") Signed-off-by: Olga Shern Signed-off-by: Adrien Mazarguil ---

[dpdk-dev] [PATCH 10/14] mlx5: fix TX for scattered mbufs with too many segments

Buffers with too many segments are linearized to overcome MLX5_PMD_SGE_WR_N, unfortunately the last segment is never sent. Fixes: 3ee8444608a9 ("mlx5: support scattered Rx and Tx") Signed-off-by: Jesper Wramberg Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_rxtx.c | 2 ++ 1 file

[dpdk-dev] [PATCH 09/14] mlx5: fix memory registration for indirect mbuf data

Indirect mbuf data may come from a different mempool which must be registered separately as another memory region, otherwise such mbufs cannot be sent. Fixes: 2e22920b85d9 ("mlx5: support non-scattered Tx and Rx") Signed-off-by: Jesper Wramberg Signed-off-by: Adrien Mazarguil ---

[dpdk-dev] [PATCH 08/14] mlx5: fix possible crash when clearing device statistics

A typo causes TX stats indices to be retrieved from RX queues. Fixes: 87011737b715 ("mlx5: add software counters") Reported-by: Nicolas Harnois Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH 07/14] mlx4: allow operation in secondary processes

From: Or Ami Secondary processes are expected to use queues and other resources allocated by the primary, however Verbs resources can only be shared between processes when inherited through fork(). This limitation can be worked around for TX by configuring separate queues

[dpdk-dev] [PATCH 05/14] mlx4: fix local protection error when TX MP to MR cache is full

From: Olga Shern When MP to MR cache is full, the last (newest) MR is freed instead of the first (oldest) one, causing local protection errors during TX. Fixes: 7fae69eeff13 ("mlx4: new poll mode driver") Signed-off-by: Olga Shern Signed-off-by: Adrien Mazarguil ---

[dpdk-dev] [PATCH 04/14] mlx4: fix TX packet loss after initialization

From: Olga Shern Pre-registering mbuf memory pools when creating TX queues avoids costly registrations later in the data path. Fixes: 7fae69eeff13 ("mlx4: new poll mode driver") Signed-off-by: Olga Shern Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 89

[dpdk-dev] [PATCH 03/14] mlx4: fix TX for scattered mbufs with too many segments

Buffers with too many segments are linearized to overcome MLX4_PMD_SGE_WR_N, unfortunately the last segment is never sent. Fixes: be11b35817e0 ("mlx4: move scattered Tx processing to helper function") Signed-off-by: Jesper Wramberg Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c |

[dpdk-dev] [PATCH 02/14] mlx4: fix memory registration for indirect mbuf data

Indirect mbuf data may come from a different mempool which must be registered separately as another memory region, otherwise such mbufs cannot be sent. Fixes: 7fae69eeff13 ("mlx4: new poll mode driver") Signed-off-by: Jesper Wramberg Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c

[dpdk-dev] [PATCH 01/14] mlx4: fix possible crash when clearing device statistics

A typo causes TX stats indices to be retrieved from RX queues. Fixes: 7fae69eeff13 ("mlx4: new poll mode driver") Reported-by: Nicolas Harnois Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH 00/14] Fixes for mlx4 and mlx5

Here is a set of fixes for mlx4 and mlx5. Since mlx5 derives from mlx4, most patches apply to both PMDs. Besides bugfixes, there is a documentation commit for mlx5 (undocumented environment variables) and another commit that addresses secondary process operation with mlx4 (does not work at all).

[dpdk-dev] |ERROR| pw 9018 ethdev: add a missing sanity check for nb_tx_desc during txq setup

On Mon, Nov 23, 2015 at 07:36:38AM +, Liu, Yong wrote: > Yuanhan, > The validation system is based on dpkdk.org patchwork, all patch sets > recorded by patchwork should be validated. > Can you supply the patch Id or just patch name? Thus, we can check out what > happened. Sure, here you

[dpdk-dev] max MEMZONEs allowed

Hi all, We are working on a system which requires allocating a big number of mem zones. We are now reaching the max limit of MEMZONEs allowed (RTE_MAX_MEMZONE). I see today dpdk limit the above number to 2560. Is there any specific reason for that? can I increase it in case needed. What may

[dpdk-dev] |ERROR| pw 9018 ethdev: add a missing sanity check for nb_tx_desc during txq setup

On Mon, Nov 23, 2015 at 07:06:45AM +, Liu, Yong wrote: > Hi Rahul, > Your patch passed "checksum_offload_with_vlan" after rerun this case. Please > ignore this error report. I got a same report few weeks ago. And my patch was very vhost-user specific, touching nothing else. Even though, I

[dpdk-dev] [PATCH 1/1] app/test: create ring and ethdevs in pmd_ring_autotest

Use command line option --vdev=eth_ring0 to create port 0. Create two rings and five ethdevs in test_pmd_ring for ports 1 to 5. Improve test output by adding the port number to printf statements, and adding a printf describing each test. revise ring-based PMD doc to match latest ring PMD code.

[dpdk-dev] [PATCH v7 06/10] mbuf_offload: library to support attaching offloads to a mbuf

2015-11-23 14:08, Olivier MATZ: > 2015-11-23 12:16, Declan Doherty: > > 2015-11-23 11:52, Ananyev, Konstantin: > >> I understand that current API is probably not perfect and might need > >> to be revised in future. > > The problem is that it's not easy to change the dpdk API now. [...] > > Just

[dpdk-dev] [PATCH] eal: fix plugindir processing to be filesystem agnostic

2015-11-23 13:42, Panu Matilainen: > On 11/23/2015 12:41 PM, Thomas Monjalon wrote: > > 2015-11-23 08:04, Panu Matilainen: > >> On 11/20/2015 06:38 PM, David Marchand wrote: > >>> It looks like you would skip the symbolic links while you were not before. > >>> Intended ? > >> > >> Intended. We

[dpdk-dev] [PATCH v7 06/10] mbuf_offload: library to support attaching offloads to a mbuf

On 23/11/15 13:08, Olivier MATZ wrote: > Hi, > > On 11/23/2015 01:16 PM, Declan Doherty wrote: >>> I don't think we should start to re-use userdata. >>> Userdata was intended for the upper layer app to pass/store it's >>> private data associated with mbuf, and we probably should keep it this >>>

[dpdk-dev] [PATCH v2] i40e: fix issue of reconfigure hash enable flags

It fixes the issue of not re-configuring hash enable flags (HENA) if there is no key. Fixes: d0a349409bd7 ("i40e: support AQ based RSS config") Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_ethdev.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) v2 changes: Removed

[dpdk-dev] [PATCH v7 06/10] mbuf_offload: library to support attaching offloads to a mbuf

Hi, On 11/23/2015 01:16 PM, Declan Doherty wrote: >> I don't think we should start to re-use userdata. >> Userdata was intended for the upper layer app to pass/store it's >> private data associated with mbuf, and we probably should keep it this >> way. If the crypto API PMD takes both mbuf and

[dpdk-dev] [PATCH] eal: fix regression of plugins always requiring full path

The added error checking on plugin initialization in commit 9f8eb1d9ca0f56d6292db5858c52e6873d0abe51 broke the ability of loading plugins by their basename from default linker locations. Only use stat() for directory discovery and leave error handling to dlopen() to restore former behavior.

[dpdk-dev] [PATCH] eal: fix plugindir processing to be filesystem agnostic

On 11/23/2015 12:41 PM, Thomas Monjalon wrote: > Hi Panu, > > 2015-11-23 08:04, Panu Matilainen: >> On 11/20/2015 06:38 PM, David Marchand wrote: >>> It looks like you would skip the symbolic links while you were not before. >>> Intended ? >> >> Intended. We want to accept symlinks in the driver

[dpdk-dev] [PATCH] i40e: fix issue of reconfigure hash enable flags

It fixes the issue of not re-configuring hash enable flags (HENA) if there is no key. Fixes: d0a349409bd7 ("i40e: support AQ based RSS config") Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_ethdev.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH v7 06/10] mbuf_offload: library to support attaching offloads to a mbuf

On 23/11/15 11:52, Ananyev, Konstantin wrote: > Hi Olivier, > >> On 11/20/2015 06:26 PM, Declan Doherty wrote: The new files are called rte_mbuf_offload, but from what I understand, it is more like a mbuf metadata api. What you call "offload operation" is not called because an

[dpdk-dev] [PATCH] i40e: configure the vector PMD option as no for default for l3fwd undefined ptype issue

> > Configure the vector PMD option as no for default as a work around for > > l3fwd. > > After the l3fwd app can handle the undefined ptype or the i40e vPMD can > > return the ptype, the option will be set as yes for default again. > > > > Signed-off-by: Zhe Tao > Acked-by: Helin Zhang Few

[dpdk-dev] [PATCH v7 06/10] mbuf_offload: library to support attaching offloads to a mbuf

Hi Olivier, > On 11/20/2015 06:26 PM, Declan Doherty wrote: > >> The new files are called rte_mbuf_offload, but from what I understand, > >> it is more like a mbuf metadata api. What you call "offload operation" > >> is not called because an offload is attached, but because you call > >>

[dpdk-dev] [PATCH] test: fix crash in pmd_perf_test

Fix crash in pmd_perf_test autotest (div by 0) when no packets received Also fixes the fact that the test passes even if exec_burst fails To repeat the issue: The system must be incorrectly set up so that all packets will be lost, i.e. no loopback cable, etc. This is an edge case, but still

[dpdk-dev] [PATCH] eal: fix plugindir processing to be filesystem agnostic

Hi Panu, 2015-11-23 08:04, Panu Matilainen: > On 11/20/2015 06:38 PM, David Marchand wrote: > > It looks like you would skip the symbolic links while you were not before. > > Intended ? > > Intended. We want to accept symlinks in the driver directory, but the > actual drivers are always regular

[dpdk-dev] [PATCH] vhost-user: fix enabling of queue pair

On Fri, Nov 20, 2015 at 03:45:00PM +0200, Victor Kaplansky wrote: > The VHOST_USER_SET_VRING_ENABLE request is sent for each queue in > queue-pair separately. So, a queue-pair should be considered > enabled only when both RX and TX queues are enabled. Hi Victor, It was sent per queue-pair, and I

[dpdk-dev] [RFC PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling

On Mon, Nov 23, 2015 at 02:54:54AM +, Xie, Huawei wrote: I checked shared mapping with MAP_POPULATE between two processes. It > works. Then i did some search, find the manual is also ambiguous to > others and thus have been changed, :). > Before: MAP_POPULATE is only supported for private

[dpdk-dev] [PATCH] igb/e1000: Copy PCI device info after the rte_eal_process_type() check

This fixes a bug added to these two drivers by eeefe73 (drivers: copy PCI device info to ethdev data) which causes the pci info seen by the primary process to become invalidated by secondary process startup. This call was added after the process type check in the other drivers. Signed-off-by: Jon

[dpdk-dev] [PATCH v7 06/10] mbuf_offload: library to support attaching offloads to a mbuf

Hi Declan, On 11/20/2015 06:26 PM, Declan Doherty wrote: >> The new files are called rte_mbuf_offload, but from what I understand, >> it is more like a mbuf metadata api. What you call "offload operation" >> is not called because an offload is attached, but because you call >>

[dpdk-dev] |ERROR| pw 9018 ethdev: add a missing sanity check for nb_tx_desc during txq setup

Yuanhan, First three reports is for patch sets in the same email thread. I think patchwork scanned the mail and strip all of them out. So the patch names did not change any more. For the failure one, it caused by validation environment. We're trying to find the root cause. > -Original

[dpdk-dev] [PATCH v2] i40e: fix issue of reconfigure hash enable flags

> -Original Message- > From: Zhang, Helin > Sent: Monday, November 23, 2015 2:19 PM > To: dev at dpdk.org > Cc: Wu, Jingjing; Pei, Yulong; Zhang, Helin > Subject: [PATCH v2] i40e: fix issue of reconfigure hash enable flags > > It fixes the issue of not re-configuring hash enable flags

[dpdk-dev] [PATCH] eal: fix plugindir processing to be filesystem agnostic

On 11/20/2015 06:38 PM, David Marchand wrote: > Hello Panu, > > On Wed, Nov 18, 2015 at 7:45 AM, Panu Matilainen > wrote: > >> Not all filesystems supply struct dirent d_type field, in which case >> everything in the specified directory would go ignored. One such >> filesystem being XFS which

[dpdk-dev] |ERROR| pw 9018 ethdev: add a missing sanity check for nb_tx_desc during txq setup

Yuanhan, The validation system is based on dpkdk.org patchwork, all patch sets recorded by patchwork should be validated. Can you supply the patch Id or just patch name? Thus, we can check out what happened. > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at

[dpdk-dev] |ERROR| pw 9018 ethdev: add a missing sanity check for nb_tx_desc during txq setup

Hi Rahul, Your patch passed "checksum_offload_with_vlan" after rerun this case. Please ignore this error report. > -Original Message- > From: Rahul Lakkireddy [mailto:rahul.lakkireddy at chelsio.com] > Sent: Friday, November 20, 2015 9:37 PM > To: dev at dpdk.org > Cc: Liu, Yong; Kumar

[dpdk-dev] [PATCH] i40e: fix issue of reconfigure hash enable flags

> -Original Message- > From: Wu, Jingjing > Sent: Monday, November 23, 2015 1:54 PM > To: Zhang, Helin; dev at dpdk.org > Cc: Pei, Yulong > Subject: RE: [PATCH] i40e: fix issue of reconfigure hash enable flags > > > > > - if (!key || key_len != ((I40E_PFQF_HKEY_MAX_INDEX + 1) * > > -

[dpdk-dev] [PATCH] i40e: fix issue of reconfigure hash enable flags

> > - if (!key || key_len != ((I40E_PFQF_HKEY_MAX_INDEX + 1) * > - sizeof(uint32_t))) > + if (!key || key_len == 0) { > + PMD_DRV_LOG(DEBUG, "No key to be configured"); > + return 0; > + } else if (key && (key_len != (I40E_PFQF_HKEY_MAX_INDEX + 1) *

[dpdk-dev] [RFC PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling

On 11/23/2015 12:07 PM, Stephen Hemminger wrote: > On Mon, 23 Nov 2015 03:46:31 + > "Xie, Huawei" wrote: > >>> Why cannot we rely on the kernel zeroing the memory ? >>> If that behavior were to change, then we can zero out the memory >>> ourselves. >> It is undocumented kernel behavior. My

[dpdk-dev] [RFC PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling

On 11/19/2015 5:15 PM, Gonzalez Monroy, Sergio wrote: > On 18/11/2015 12:07, Xie, Huawei wrote: >> On 11/18/2015 6:45 PM, Wang, Zhihong wrote: -Original Message- From: Mcnamara, John Sent: Wednesday, November 18, 2015 6:40 PM To: Wang, Zhihong ; dev at dpdk.org

[dpdk-dev] [RFC PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling

On 11/19/2015 2:32 PM, Wang, Zhihong wrote: >> -Original Message- >> From: Xie, Huawei >> Sent: Thursday, November 19, 2015 2:05 PM >> To: Wang, Zhihong ; Stephen Hemminger >> ; Richardson, Bruce >> >> Cc: dev at dpdk.org >> Subject: Re: [dpdk-dev] [RFC PATCH 2/2] lib/librte_eal: Remove

[dpdk-dev] [PATCH v2 2/2] scripts: add build tests

This script helps to build a list of target with some custom options. It tries to enable most of the options. The examples and documentation are also built. It uses some configuration from exported variables. This config works on my machine: export DPDK_DEP_PCAP=y export DPDK_DEP_MOFED=y

[dpdk-dev] [PATCH v2 1/2] scripts: add checkpatch wrapper

This script can be used to call checkpatch.pl from Linux with some custom DPDK options. The path to the original Linux script must be set in an environment variable. A script is added to load any configuration variables required by development tools from a file .develconfig, or

[dpdk-dev] [PATCH v2 0/2] more basic tests

I use some scripts to make some basic checks before committing or submitting some patches. As they can be useful for every DPDK developers and especially for new committers / tree owners, they are added to the scripts directory. The problem, when sharing such tools, is how to make them

[dpdk-dev] OK to reindent the pktgen (mix of tabs and spaces, etc.)?

I would like to reindent it using the following astyle command, with a few small hand edits past that level, to get it closer to most other DPDK code as the inconsistent mix of tabs, spaces, etc. makes it difficult to read and debug when it has issues. Obviously the upstream Lua and

[dpdk-dev] [PATCH RFC v2 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling

> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Saturday, November 21, 2015 12:33 AM > To: Wang, Zhihong > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH RFC v2 2/2] lib/librte_eal: Remove unnecessary > hugepage zero-filling > > On

[dpdk-dev] [PATCH RFC v2 1/2] lib/librte_eal: Reduce timer initialization time

> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Saturday, November 21, 2015 12:32 AM > To: Wang, Zhihong > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH RFC v2 1/2] lib/librte_eal: Reduce timer > initialization time > > On Thu, 19

[dpdk-dev] missing __rte_deprecated on rte_eth_stats.imcasts ?

2015-11-22 18:53, Matthew Hall: > I was reading through the deprecations in rte_eth_stats to see if I could fix > the pktgen. Of course many fields were marked with __rte_deprecated . > > However I found this one field which said deprecated in its comment, but it > lacked __rte_deprecated .

[dpdk-dev] difficulty w/ RTE_NEXT_ABI

2015-11-22 18:25, Matthew Hall: > On Sun, Nov 22, 2015 at 09:59:30PM +0100, Thomas Monjalon wrote: > > > So again I am confused what advantage we got from RTE_NEXT_ABI here, and > > > how > > > you have multiple copies of RTE_NEXT_ABI on a single symbol when it is a > > > binary variable. > >