We find significant perfermance drop introduced by below commit,
when vhost example is started with --mergeable 0 and inside vm,
kernel virtio-net driver is used to do ip based forwarding.
The root cause is that below commit adds support for
VIRTIO_NET_F_GUEST_TSO4 and VIRTIO_NET_F_GUEST_TSO6, and
Self-Nack this patch because the commit log needs change further.
> -Original Message-
> From: Tan, Jianfeng
> Sent: Thursday, July 21, 2016 8:24 AM
> To: dev at dpdk.org
> Cc: yuanhan.liu at linux.intel.com; Wang, Zhihong; Xu, Qian Q; Tan, Jianfeng
> Subject: [PATCH v2] examples/vhost: fi
We find significant perfermance drop introduced by below commit,
when vhost example is started with --mergeable 0 and inside vm,
kernel virtio-net driver is used to do ip based forwarding.
The commit, 859b480d5afd ("vhost: add guest offload setting"), adds
support for VIRTIO_NET_F_GUEST_TSO4 and V
On Thu, Jul 21, 2016 at 12:42:45AM +, Jianfeng Tan wrote:
> We find significant perfermance drop introduced by below commit,
> when vhost example is started with --mergeable 0 and inside vm,
> kernel virtio-net driver is used to do ip based forwarding.
>
> The commit, 859b480d5afd ("vhost: add
Add the tested-by:)
Tested-by: Qian Xu
- Test Commit: 608487f3fc96704271c624d0f3fe9d7fb2187aea
- OS/Kernel: Fedora 21/4.1.13
- GCC: gcc (GCC) 4.9.2 20141101 (Red Hat 4.9.2-1)
- CPU: Intel(R) Xeon(R) CPU E5-2695 v4 @ 2.10
- NIC: Intel(R) Ethernet Controller X710 for 10GbE SFP+
- Total 2 cases, 2
Hi Adrien,
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com]
> Sent: Wednesday, July 20, 2016 6:41 PM
> To: Lu, Wenzhuo
> Cc: dev at dpdk.org; Thomas Monjalon; Zhang, Helin; Wu, Jingjing; Rasesh Mody;
> Ajit Khaparde; Rahul Lakkireddy; Jan Medala; John Da
The usual device sequence is configure, queue setup and start.
Crypto device should be started before use.
Signed-off-by: Akhil Goyal
Signed-off-by: Hemant Agrawal
---
examples/l2fwd-crypto/main.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/examples/l2fwd-crypto/main.c b/examples/
The usual device sequence is configure, queue setup and start.
Crypto device should be started before use.
Signed-off-by: Akhil Goyal
Signed-off-by: Hemant Agrawal
---
examples/ipsec-secgw/ipsec-secgw.c | 4
1 file changed, 4 insertions(+)
diff --git a/examples/ipsec-secgw/ipsec-secgw.c
The '-' in lcores set overrides cpu set of following
lcore set in the argument of EAL option --lcores.
Fixes: 53e54bf81700 ("eal: new option --lcores for cpu assignment")
Signed-off-by: Wei Dai
---
lib/librte_eal/common/eal_common_options.c | 12
1 file changed, 12 insertions(+)
d
This patchset, targetted for 16.11, introduces the support of rx and tx
offload in virtio pmd. To achieve this, some new mbuf flags must be
introduced, as discussed in [1].
It applies on top of:
- 16.07-rc3
- software packet type [2]
- testpmd enhancements [3]
- virtio packet corruption fix [4]
Move all code related to device initialization in a new function
virtio_init_device().
This commit brings no functional change, it prepares the next commits
that will add the offload support. For that, it will be needed to
reinitialize the device from ethdev->configure(), using this new
function.
Move the configuration of control queue in the configure callback.
This is needed by next commit, which introduces the reinitialization
of the device in the configure callback to change the feature flags.
Therefore, the control queue will have to be restarted at the same
place.
As virtio_dev_cq_qu
Add the ability to reset the virtio device in the configure callback
if the features flag changed since previous reset. This will be possible
with the introduction of offload support in next commits.
Signed-off-by: Olivier Matz
---
drivers/net/virtio/virtio_ethdev.c | 26 +++-
This function can be used to calculate the checksum of data embedded in
mbuf, that can be composed of several segments.
This function will be used by the virtio pmd in next commits to calculate
the checksum in software in case the protocol is not recognized.
Signed-off-by: Olivier Matz
---
doc/
Following discussions in [1] and [2], introduce a new bit to
describe the Rx checksum status in mbuf.
Before this patch, only one flag was available:
PKT_RX_L4_CKSUM_BAD: L4 cksum of RX pkt. is not OK.
And same for L3:
PKT_RX_IP_CKSUM_BAD: IP cksum of RX pkt. is not OK.
This had 2 issues:
-
---
app/test-pmd/csumonly.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
index 4b36d74..34a2591 100644
--- a/app/test-pmd/csumonly.c
+++ b/app/test-pmd/csumonly.c
@@ -680,8 +680,10 @@ pkt_burst_checksum_forward(struct f
When receiving coalesced packets in virtio, the original size of the
segments is provided. This is a useful information because it allows to
resegment with the same size.
Add a RX new flag in mbuf, that can be set when packets are coalesced by
a hardware or virtual driver when the m->tso_segsz fie
In csumonly engine, display the value of LRO segment if the
LRO flag is set.
Signed-off-by: Olivier Matz
---
app/test-pmd/csumonly.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
index 34a2591..3455a7e 100644
--- a/app/test-pmd/csumonly.c
Signed-off-by: Olivier Matz
---
drivers/net/virtio/virtio_ethdev.c | 7 ++-
drivers/net/virtio/virtio_ethdev.h | 9 -
drivers/net/virtio/virtio_rxtx.c | 21 +
3 files changed, 27 insertions(+), 10 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b
Signed-off-by: Olivier Matz
---
drivers/net/virtio/virtio_ethdev.c | 6 ++
drivers/net/virtio/virtio_ethdev.h | 2 +
drivers/net/virtio/virtio_rxtx.c | 129 -
3 files changed, 134 insertions(+), 3 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethde
Signed-off-by: Olivier Matz
---
drivers/net/virtio/virtio_ethdev.c | 14
drivers/net/virtio/virtio_ethdev.h | 2 +-
drivers/net/virtio/virtio_rxtx.c | 66 ++
drivers/net/virtio/virtqueue.h | 1 +
4 files changed, 75 insertions(+), 8 deletions(-
Signed-off-by: Olivier Matz
---
drivers/net/virtio/virtio_ethdev.c | 7 +
drivers/net/virtio/virtio_ethdev.h | 1 +
drivers/net/virtio/virtio_rxtx.c | 57 +-
3 files changed, 45 insertions(+), 20 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethd
Hi Adrien,
The proposal looks very good. It satisfies most of the features
supported by Chelsio NICs. We are looking for suggestions on exposing
more additional features supported by Chelsio NICs via this API.
Chelsio NICs have two regions in which filters can be placed -
Maskfull and Maskless
On Wed, Jul 20, 2016 at 11:32:43AM +0300, Ilya Maximets wrote:
> Currently while calling of 'rte_vhost_driver_unregister()' connection
> to QEMU will not be closed. This leads to inability to register driver
> again and reconnect to same virtual machine.
>
> This scenario is reproducible with OVS.
If something abnormal happened to QEMU, 'connect()' can block calling
thread (e.g. main thread of OVS) forever or for a really long time.
This can break whole application or block the reconnection thread.
Example with OVS:
ovs_rcu(urcu2)|WARN|blocked 512000 ms waiting for main to quiesce
> Tested-by: Yongjie Gu
Applied
Sometimes app just wants to update the RSS hash function and no RSS key
update is needed, but fm10k pmd will return EINVAL for this case.
If the rss_key is NULL, we don't need to check the rss_key_len.
Fixes: 57033cdf8fdc ("fm10k: add PF RSS")
Reported-by: Xueqin Lin
Signed-off-by: Xiao Wang
-
On Tue, Jul 19, 2016 at 02:31:59PM +0200, Olivier Matz wrote:
> The support of virtio-user changed the way the mbuf dma address is
> retrieved, using a physical address in case of virtio-pci and a virtual
> address in case of virtio-user.
>
> This change introduced some possible memory corruption
> > The sed syntax of '0,/regexp/' is GNU specific and fails with
> > non GNU sed in FreeBSD.
> >
> > To solve the issue we can use awk instead to remove duplicates.
> >
> > The awk script basically keeps the last config value, while
> > maintaining order and comments from original config file.
> >
Currently while calling of 'rte_vhost_driver_unregister()' connection
to QEMU will not be closed. This leads to inability to register driver
again and reconnect to same virtual machine.
This scenario is reproducible with OVS. While executing of the following
command vhost port will be re-created (
Thanks. Fixed.
Best regards, Ilya Maximets.
On 21.07.2016 11:24, Yuanhan Liu wrote:
> On Wed, Jul 20, 2016 at 11:32:43AM +0300, Ilya Maximets wrote:
>> Currently while calling of 'rte_vhost_driver_unregister()' connection
>> to QEMU will not be closed. This leads to inability to register driver
>
Hi,
> diff --git a/drivers/net/fm10k/fm10k_ethdev.c
> b/drivers/net/fm10k/fm10k_ethdev.c
> index 144b2de..01f4a72 100644
> --- a/drivers/net/fm10k/fm10k_ethdev.c
> +++ b/drivers/net/fm10k/fm10k_ethdev.c
> @@ -2159,8 +2159,8 @@ fm10k_rss_hash_update(struct rte_eth_dev *dev,
>
> PMD_INIT_FUN
On 07/19/2016 07:21 PM, Thomas Monjalon wrote:
> The autotest lists, requirements and distribution needs a big rework
> to reduce the amount of cores and memory required.
> The root cause is not addressed yet.
>
> This patch just increase some memory allocation for some greedy tests
> which ofte
On 07/19/2016 06:53 PM, Thomas Monjalon wrote:
> The unavailable tests are filtered out by autotest by looking for
> the symbols in the binary:
>
> PCI autotest: Skipped [Not Available] [00m 00s]
> Malloc autotest: Success [00m 00s]
>
>
Signed-off-by: John Daley
---
doc/guides/nics/enic.rst | 9 +++--
doc/guides/nics/overview.rst | 2 +-
doc/guides/rel_notes/release_16_07.rst | 23 +++
3 files changed, 27 insertions(+), 7 deletions(-)
diff --git a/doc/guides/nics/enic.rst b/doc/
On Thu, Jul 21, 2016 at 11:21:15AM +0300, Ilya Maximets wrote:
> If something abnormal happened to QEMU, 'connect()' can block calling
> thread (e.g. main thread of OVS) forever or for a really long time.
> This can break whole application or block the reconnection thread.
>
> Example with OVS:
>
Hi Mark,
> -Original Message-
> From: Chen, Jing D
> Sent: Thursday, July 21, 2016 4:48 PM
> To: Wang, Xiao W ; dev at dpdk.org
> Cc: Lin, Xueqin
> Subject: RE: [PATCH] net/fm10k: fix RSS hash config
>
> Hi,
>
> > diff --git a/drivers/net/fm10k/fm10k_ethdev.c
> > b/drivers/net/fm10k/fm1
On 21.07.2016 12:37, Yuanhan Liu wrote:
> On Thu, Jul 21, 2016 at 11:21:15AM +0300, Ilya Maximets wrote:
>> If something abnormal happened to QEMU, 'connect()' can block calling
>> thread (e.g. main thread of OVS) forever or for a really long time.
>> This can break whole application or block the r
On Thu, Jul 21, 2016 at 12:45:32PM +0300, Ilya Maximets wrote:
> On 21.07.2016 12:37, Yuanhan Liu wrote:
> > On Thu, Jul 21, 2016 at 11:21:15AM +0300, Ilya Maximets wrote:
> >> If something abnormal happened to QEMU, 'connect()' can block calling
> >> thread (e.g. main thread of OVS) forever or for
Hi Robert,
Thank you for reviewing.
In the following case, the skip list is broken.
- Timer A and timer B are configured on the same lcore, in the same
pending list.
- The expire time of timer A is earlier than that of timer B.
- rte_timer_manage() is called on the lcore after the expire time of
On 21.07.2016 13:13, Yuanhan Liu wrote:
> On Thu, Jul 21, 2016 at 12:45:32PM +0300, Ilya Maximets wrote:
>> On 21.07.2016 12:37, Yuanhan Liu wrote:
>>> On Thu, Jul 21, 2016 at 11:21:15AM +0300, Ilya Maximets wrote:
If something abnormal happened to QEMU, 'connect()' can block calling
th
This patchset adds the configuration file supported to ipsec_secgw
sample application. Two sample configuration files, ep0.cfg and ep1.cfg
are also added to show how to configure two systems back-to-back that
would forward traffic through an IPsec tunnel
v4 change:
- rebase the patchset on top of
This patch adds the configuration file support to ipsec_secgw
sample application. Instead of hard-coded rules, the users can
specify their own SP, SA, and routing rules in the configuration
file. An command line option "-f" is added to pass the
configuration file location to the application.
Confi
This patch adds two sample configuration files to ipsec-secgw sample
application. The sample configuration files shows how to set-up systems
back-to-back that would forward traffic through an IPsec tunnel.
Signed-off-by: Fan Zhang
---
examples/ipsec-secgw/ep0.cfg | 160 ++
Hi Olivier,
>
> This function can be used to calculate the checksum of data embedded in mbuf,
> that can be composed of several segments.
>
> This function will be used by the virtio pmd in next commits to calculate the
> checksum in software in case the protocol is not recognized.
>
> Signed
Hi Beilei,
On Wed, Jul 20, 2016 at 3:59 AM, Xing, Beilei wrote:
> Hi Ceara,
>
>> -Original Message-
>> From: Take Ceara [mailto:dumitru.ceara at gmail.com]
>> Sent: Tuesday, July 19, 2016 10:59 PM
>> To: Xing, Beilei
>> Cc: Zhang, Helin ; Wu, Jingjing
>> ; dev at dpdk.org
>> Subject: Re:
From: Sergey Dyasly
Rx loop inside _recv_raw_pkts_vec() ignores nb_pkts argument and always
tries to receive RTE_I40E_VPMD_RX_BURST (32) packets. This is a violation
of rte_eth_rx_burst() API and can lead to memory corruption (out-of-bounds
writes to struct rte_mbuf **rx_pkts) if nb_pkts is less
Hi Adrien,
Please find my comments below
Regards
_Sugesh
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com]
> Sent: Wednesday, July 20, 2016 6:11 PM
> To: Chandran, Sugesh
> Cc: dev at dpdk.org; Thomas Monjalon ;
> Zhang, Helin ; Wu, Jingjing
> ; Rases
> Subject: [dpdk-dev] [PATCH] doc: deprecate vhost-cuse
>
> Vhost-cuse was invented before vhost-user exist. The both are actually
> doing the same thing: a vhost-net implementation in user space. But they
> are not exactly the same thing.
>
> Firstly, vhost-cuse is harder for use; no one seems t
If something abnormal happened to QEMU, 'connect()' can block calling
thread (e.g. main thread of OVS) forever or for a really long time.
This can break whole application or block the reconnection thread.
Example with OVS:
ovs_rcu(urcu2)|WARN|blocked 512000 ms waiting for main to quiesce
On 21.07.2016 13:37, Ilya Maximets wrote:
>
>
> On 21.07.2016 13:13, Yuanhan Liu wrote:
>> On Thu, Jul 21, 2016 at 12:45:32PM +0300, Ilya Maximets wrote:
>>> On 21.07.2016 12:37, Yuanhan Liu wrote:
On Thu, Jul 21, 2016 at 11:21:15AM +0300, Ilya Maximets wrote:
> If something abnormal hap
On Thu, Jul 21, 2016 at 02:14:59PM +0300, Ilya Maximets wrote:
> > Hmm, how about this fixup:
> > --
> > diff --git a/lib/librte_vhost/vhost_user/vhost-net-user.c
> > b/lib/librte_vhost/vhost_user/vhost-net-user.c
> > inde
test_mempool func not using pointer variable 'mp_ext' and incorrectly freed. So
removing ptr var. Now freeing mp_stack var.
Signed-off-by: Santosh Shukla
---
app/test/test_mempool.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/app/test/test_mempool.c b/app/test/test_m
Hi Thomas,
As I understand Sergio suggested to come back to the solution similar to v1.
Could you comment or better take decision which solution should be applied,
please.
Best Regards,
S?awomir
>-Original Message-
>From: Gonzalez Monroy, Sergio
>Sent: Monday, June 20, 2016 1:29 PM
>T
On 21.07.2016 14:40, Yuanhan Liu wrote:
> On Thu, Jul 21, 2016 at 02:14:59PM +0300, Ilya Maximets wrote:
>>> Hmm, how about this fixup:
>>> --
>>> diff --git a/lib/librte_vhost/vhost_user/vhost-net-user.c
>>> b/lib/librte_
On 21.07.2016 15:10, Ilya Maximets wrote:
> On 21.07.2016 14:40, Yuanhan Liu wrote:
>> On Thu, Jul 21, 2016 at 02:14:59PM +0300, Ilya Maximets wrote:
Hmm, how about this fixup:
--
diff --git a/lib/librte_vh
On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote:
> >>
> >> What do you think of it?
> >
> > I found that we can't check connection status without select/poll
> > on it. 'getsockopt()' will return 0 with no errors if connection
> > is not still established just like if it was.
> > So,
On 21.07.2016 15:35, Yuanhan Liu wrote:
> On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote:
What do you think of it?
>>>
>>> I found that we can't check connection status without select/poll
>>> on it. 'getsockopt()' will return 0 with no errors if connection
>>> is not still
Hi Wenzhuo,
It seems that we agree on about everything now, just a few more comments
below after snipping the now irrelevant parts.
On Thu, Jul 21, 2016 at 03:18:11AM +, Lu, Wenzhuo wrote:
[...]
> > > > > Does it mean PMD should store and maintain all the rules? Why not
> > > > > let rte do
>
On Thu, Jul 21, 2016 at 03:42:54PM +0300, Ilya Maximets wrote:
> On 21.07.2016 15:35, Yuanhan Liu wrote:
> > On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote:
>
> What do you think of it?
> >>>
> >>> I found that we can't check connection status without select/poll
> >>> on i
2016-07-21 12:01, Mrozowicz, SlawomirX:
> Hi Thomas,
>
> As I understand Sergio suggested to come back to the solution similar to v1.
> Could you comment or better take decision which solution should be applied,
> please.
>
> Best Regards,
> S?awomir
>
>
> >-Original Message-
> >From:
Currently while calling of 'rte_vhost_driver_unregister()' connection
to QEMU will not be closed. This leads to inability to register driver
again and reconnect to same virtual machine.
This scenario is reproducible with OVS. While executing of the following
command vhost port will be re-created (
I've fixed leak of file descriptors in 'vhost_user_remove_reconnect()'
and sent v3.
On 21.07.2016 11:31, Ilya Maximets wrote:
> Currently while calling of 'rte_vhost_driver_unregister()' connection
> to QEMU will not be closed. This leads to inability to register driver
> again and reconnect to sa
On 21.07.2016 15:58, Yuanhan Liu wrote:
> On Thu, Jul 21, 2016 at 03:42:54PM +0300, Ilya Maximets wrote:
>> On 21.07.2016 15:35, Yuanhan Liu wrote:
>>> On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote:
>>
>> What do you think of it?
>
> I found that we can't check conne
- Fix vhost setup flags
- Add minor edits to improve readability and consistency
---
v2: - revert file mode changes made erroneously in v1
Signed-off-by: Mark Kavanagh
---
doc/guides/sample_app_ug/tep_termination.rst | 8
1 file changed, 4 insertions(+), 4 deletions(-)
mode change 10
On Thu, Jul 21, 2016 at 03:58:11PM +0300, Ilya Maximets wrote:
> On 21.07.2016 15:58, Yuanhan Liu wrote:
> > On Thu, Jul 21, 2016 at 03:42:54PM +0300, Ilya Maximets wrote:
> >> On 21.07.2016 15:35, Yuanhan Liu wrote:
> >>> On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote:
> >>
> >>
- Fix vhost setup flags
- Add minor edits to improve readability and consistency
---
v2: - revert file mode changes made erroneously in v1
Signed-off-by: Mark Kavanagh
---
doc/guides/sample_app_ug/tep_termination.rst | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/d
Please disregard - correct version of patch to follow.
Cheers,
Mark
>-Original Message-
>From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mark Kavanagh
>Sent: Thursday, July 21, 2016 2:04 PM
>To: dev at dpdk.org
>Subject: [dpdk-dev] [PATCH V2] doc: fix vhost setup in tep-terminatio
On Thu, Jul 21, 2016 at 03:55:36PM +0300, Ilya Maximets wrote:
> Currently while calling of 'rte_vhost_driver_unregister()' connection
> to QEMU will not be closed. This leads to inability to register driver
> again and reconnect to same virtual machine.
>
> This scenario is reproducible with OVS.
If something abnormal happened to QEMU, 'connect()' can block calling
thread (e.g. main thread of OVS) forever or for a really long time.
This can break whole application or block the reconnection thread.
Example with OVS:
ovs_rcu(urcu2)|WARN|blocked 512000 ms waiting for main to quiesce
Hi Santosh,
On 07/21/2016 01:49 PM, Santosh Shukla wrote:
> test_mempool func not using pointer variable 'mp_ext' and incorrectly freed.
> So
> removing ptr var. Now freeing mp_stack var.
>
> Signed-off-by: Santosh Shukla
> ---
> app/test/test_mempool.c |3 +--
> 1 file changed, 1 insertio
On Thu, Jul 21, 2016 at 04:19:35PM +0300, Ilya Maximets wrote:
> If something abnormal happened to QEMU, 'connect()' can block calling
> thread (e.g. main thread of OVS) forever or for a really long time.
> This can break whole application or block the reconnection thread.
>
> Example with OVS:
>
2016-07-21 15:28, Olivier Matz:
> Hi Santosh,
>
> On 07/21/2016 01:49 PM, Santosh Shukla wrote:
> > test_mempool func not using pointer variable 'mp_ext' and incorrectly
> > freed. So
> > removing ptr var. Now freeing mp_stack var.
> >
> > Signed-off-by: Santosh Shukla
> > ---
> > app/test/tes
Hi Sugesh,
I do not have much to add, please see below.
On Thu, Jul 21, 2016 at 11:06:52AM +, Chandran, Sugesh wrote:
[...]
> > > RSS hashing support :- Just to confirm, the RSS flow action allows
> > > application to decide the header fields to produce the hash. This
> > > gives programmabil
Hi Zoltan,
On 07/20/2016 07:16 PM, Zoltan Kiss wrote:
> A recent patch brought up an issue about the size of the 'name' fields:
>
> 85cf0079 mem: avoid memzone/mempool/ring name truncation
>
> These relations should be observed:
>
> 1. Each ring creates a memzone with a prefixed name:
> RTE_RI
Hi Jerin,
On 07/18/2016 07:55 AM, Jerin Jacob wrote:
> rte_ring_create expects the size of the ring to
> be a power of 2. REFCNT_RING_SIZE value is not
> power of 2 in-case if RTE_MAX_LCORE == 96.
> Fix it by aligning the size to next power of 2 value.
>
> Fixes: af75078f ("first public release")
On 21.07.2016 16:35, Yuanhan Liu wrote:
> On Thu, Jul 21, 2016 at 04:19:35PM +0300, Ilya Maximets wrote:
>> If something abnormal happened to QEMU, 'connect()' can block calling
>> thread (e.g. main thread of OVS) forever or for a really long time.
>> This can break whole application or block the
Hi,
On 07/20/2016 07:16 PM, Zoltan Kiss wrote:
> (strlen(name) == sizeof(mz->name) - 1) is a valid case, change the
> condition to reflect that.
> Move it earlier to avoid lookup with invalid name.
> Change errno to ENAMETOOLONG.
>
> Fixes: 85cf0079 ("mem: avoid memzone/mempool/ring name truncati
On 21/07/16 14:40, Olivier Matz wrote:
> Hi Zoltan,
>
>
> On 07/20/2016 07:16 PM, Zoltan Kiss wrote:
>> A recent patch brought up an issue about the size of the 'name' fields:
>>
>> 85cf0079 mem: avoid memzone/mempool/ring name truncation
>>
>> These relations should be observed:
>>
>> 1. Each ri
On Thu, Jul 21, 2016 at 04:43:25PM +0300, Ilya Maximets wrote:
>
>
> On 21.07.2016 16:35, Yuanhan Liu wrote:
> > On Thu, Jul 21, 2016 at 04:19:35PM +0300, Ilya Maximets wrote:
> >> If something abnormal happened to QEMU, 'connect()' can block calling
> >> thread (e.g. main thread of OVS) forever
On Wed, Jul 20, 2016 at 10:32:28PM +, Wiles, Keith wrote:
>
> > On Jul 20, 2016, at 3:16 PM, Neil Horman wrote:
> >
> > On Wed, Jul 20, 2016 at 07:47:32PM +, Wiles, Keith wrote:
> >>
> >>> On Jul 20, 2016, at 12:48 PM, Neil Horman wrote:
> >>>
> >>> On Wed, Jul 20, 2016 at 07:40:49PM
Hi Amin,
> -Original Message-
> From: Tootoonchian, Amin
> Sent: Wednesday, July 20, 2016 5:08 PM
> To: Kerlin, MarcinX
> Cc: dev at dpdk.org; thomas.monjalon at 6wind.com
> Subject: RE: [PATCH] ethdev: ensure consistent port id assignment
>
> Hi Marcin,
>
> Comments inline:
>
> >
CN81xx is four core version of ThunderX SoC.
Added the support by adding new HW capability flag to select
the difference in runtime.
Jerin Jacob (3):
net/thunderx: remove generic passx references from the driver
net/thunderx: introduce cqe_rx2 HW capability flag
net/thunderx: add 81xx SoC s
thunderx pmd driver needs to support multiple SoC
variants in ThunderX family.
Remove generic pass references from driver as each SoC
can have same pass number.
Signed-off-by: Jerin Jacob
---
drivers/net/thunderx/base/nicvf_hw.c | 2 +-
drivers/net/thunderx/base/nicvf_hw.h | 12 +---
dr
Certain thunderx SoC pass has additional optional word
in Rx descriptor to hold tunneling extension info.
Based on this capability, the location where packet pointer
address stored in Rx descriptor will vary.
Signed-off-by: Jerin Jacob
---
drivers/net/thunderx/base/nicvf_hw.h | 5 +++--
drivers/
81xx NIC subsystem differs in new PCI subsystem_device_id and
NICVF_CAP_CQE_RX2 capability.
Signed-off-by: Jerin Jacob
---
doc/guides/nics/thunderx.rst | 1 +
drivers/net/thunderx/base/nicvf_hw.c | 3 +++
drivers/net/thunderx/base/nicvf_hw.h | 1 +
drivers/net/thunderx/nicvf_ethdev.c |
> On Jul 21, 2016, at 8:54 AM, Neil Horman wrote:
>
> On Wed, Jul 20, 2016 at 10:32:28PM +, Wiles, Keith wrote:
>>
>>> On Jul 20, 2016, at 3:16 PM, Neil Horman wrote:
>>>
>>> On Wed, Jul 20, 2016 at 07:47:32PM +, Wiles, Keith wrote:
> On Jul 20, 2016, at 12:48 PM, Neil Horma
Hi,
2016-07-21 14:03, Wei Dai:
> The '-' in lcores set overrides cpu set of following
> lcore set in the argument of EAL option --lcores.
>
> Fixes: 53e54bf81700 ("eal: new option --lcores for cpu assignment")
>
> Signed-off-by: Wei Dai
Thanks for the catch!
> --- a/lib/librte_eal/common/eal_
2016-07-15 10:30, Chao Zhu:
> On weak memory order architecture like POWER, rte_smp_wmb/rte_smp_rmb
> need to use CPU instructions, not compiler barrier. This patch fixes
> this. Also, to improve performance on PPC64, use light weight sync
> instruction instead of sync instruction.
>
> Signed-off-
On 07/21/2016 03:47 PM, Zoltan Kiss wrote:
>
>
> On 21/07/16 14:40, Olivier Matz wrote:
>> Hi Zoltan,
>>
>>
>> On 07/20/2016 07:16 PM, Zoltan Kiss wrote:
>>> A recent patch brought up an issue about the size of the 'name' fields:
>>>
>>> 85cf0079 mem: avoid memzone/mempool/ring name truncation
Hi,
2016-07-20 16:24, Michal Jastrzebski:
> - if (read(fd, &page, sizeof(uint64_t)) < 0) {
> +
> + retval = read(fd, &page, sizeof(uint64_t));
> + if (retval < 0) {
> RTE_LOG(ERR, EAL, "%s(): cannot read /proc/self/pagemap: %s\n",
> __func__,
On 20/07/2016 15:24, Michal Jastrzebski wrote:
> In rte_mem_virt2phy: Value returned from a function and indicating the
> number of bytes was ignored. This could cause a wrong pfn (page frame
> number) mask read from pagemap file.
> When read returns less than the number of sizeof(uint64_t) bytes,
On Thu, Jul 21, 2016 at 02:09:19PM +, Wiles, Keith wrote:
>
> > On Jul 21, 2016, at 8:54 AM, Neil Horman wrote:
> >
> > On Wed, Jul 20, 2016 at 10:32:28PM +, Wiles, Keith wrote:
> >>
> >>> On Jul 20, 2016, at 3:16 PM, Neil Horman wrote:
> >>>
> >>> On Wed, Jul 20, 2016 at 07:47:32PM +
This is an ABI deprecation notice for DPDK 16.11 in librte_ether about
changes in rte_eth_dev and rte_eth_desc_lim structures.
As discussed in that thread:
http://dpdk.org/ml/archives/dev/2015-September/023603.html
Different NIC models depending on HW offload requested might impose
different req
> On Jul 21, 2016, at 10:06 AM, Neil Horman wrote:
>
> On Thu, Jul 21, 2016 at 02:09:19PM +, Wiles, Keith wrote:
>>
>>> On Jul 21, 2016, at 8:54 AM, Neil Horman wrote:
>>>
>>> On Wed, Jul 20, 2016 at 10:32:28PM +, Wiles, Keith wrote:
> On Jul 20, 2016, at 3:16 PM, Neil Horma
On 7/20/2016 5:07 PM, Thomas Monjalon wrote:
> The out-of-tree kernel code must be avoided.
> Moreover there is no good reason to keep this legacy feature
> which is only partially supported.
>
> As described earlier in this plan:
> http://dpdk.org/ml/archives/dev/2016-July/043606.html
> it
Hello.
I think good alternative is rte_ethtool library from ethtool sample
application.
But I am wondering why this code is only in app, not in lib.
Best regards,
Igor
On Thu, Jul 21, 2016 at 4:33 PM, Ferruh Yigit
wrote:
> On 7/20/2016 5:07 PM, Thomas Monjalon wrote:
> > The out-of-tree kernel
> -Original Message-
> From: Ananyev, Konstantin [mailto:konstantin.ananyev at intel.com]
> Sent: Thursday, July 21, 2016 3:51 AM
> Subject: Re: [dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a
> checksum
>
>...
> > + Added a new function ``rte_pktmbuf_cksum()`` to process the c
2016-07-21 16:41, Igor Ryzhov:
> On Thu, Jul 21, 2016 at 4:33 PM, Ferruh Yigit
> wrote:
> > On 7/20/2016 5:07 PM, Thomas Monjalon wrote:
> > > The out-of-tree kernel code must be avoided.
> > > Moreover there is no good reason to keep this legacy feature
> > > which is only partially supported.
>
Dear Don,
On 07/21/2016 06:26 PM, Don Provan wrote:
>> -Original Message-
>> From: Ananyev, Konstantin [mailto:konstantin.ananyev at intel.com]
>> Sent: Thursday, July 21, 2016 3:51 AM
>> Subject: Re: [dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a
>> checksum
>>
>> ...
>>> + A
1 - 100 of 143 matches
Mail list logo