[dpdk-dev] [PATCH v2] tools: add crypto device details

2016-09-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Eoin Breen > Sent: Thursday, August 25, 2016 6:52 AM > To: Jain, Deepak K; Trahe, Fiona; Griffin, John > Cc: dev at dpdk.org; Breen, Eoin > Subject: [dpdk-dev] [PATCH v2] tools: add crypto device details > > Ad

[dpdk-dev] [PATCH] rte_delay_us can be replaced with user function

2016-09-13 Thread Thomas Monjalon
Hi, Sorry for late review. This patch was in a summer hole :/ First a general comment: please check your patch with scripts/checkpatches.sh. In order to ease tracking of this patch, please increment the version when sending a new one in the same thread: git send-email -1 -v3 --annotate --

[dpdk-dev] [PATCH v2 0/2] Add HMAC_MD5 to Intel QuickAssist Technology driver

2016-09-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jain, Deepak K > Sent: Friday, September 09, 2016 8:45 AM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo; Jain, Deepak K > Subject: [PATCH v2 0/2] Add HMAC_MD5 to Intel QuickAssist Technology > driver > > This patchset add capability to use HMAC_MD5 hash a

[dpdk-dev] [PATCH] vhost: change the vhost library to a common framework which can support more VIRTIO devices

2016-09-13 Thread Yuanhan Liu
On Tue, Sep 13, 2016 at 03:24:53PM +0200, Thomas Monjalon wrote: > 2016-09-13 20:58, Yuanhan Liu: > > rte_virtio_net.h is the header file will be exported for applications. > > Every change there would mean either an API or ABI breakage. Thus, we > > should try to avoid touching it. Don't even to s

[dpdk-dev] [PATCH] nfp: using random mac address if not a configured mac

2016-09-13 Thread Thomas Monjalon
2016-09-13 18:10, Ferruh Yigit: > Hi Alejandro, > > On 8/16/2016 4:15 PM, Alejandro Lucero wrote: > > Signed-off-by: Alejandro Lucero > > --- > > There are following checkpatch warnings, also check-git-log complains: > > Headline too long: > nfp: unregister interrupt callback function w

[dpdk-dev] [PATCH] vhost: change the vhost library to a common framework which can support more VIRTIO devices

2016-09-13 Thread Yuanhan Liu
On Wed, Sep 14, 2016 at 08:15:00PM +0800, Changpeng Liu wrote: > For storage virtualization use cases, vhost-scsi becomes a more popular > solution to support VMs. However a user space vhost-scsi-user solution > does not exist currently. SPDK(Storage Performance Development Kit, > https://github.co

[dpdk-dev] [RFC][PATCH V2 2/3] examples/vhost: Add vswitch command line options

2016-09-13 Thread Yuanhan Liu
On Mon, Sep 05, 2016 at 04:24:30PM +0530, Pankaj Chauhan wrote: > Add command line options for selecting switch implementation > and maximum ports for the vswitch.following are two new command > line options: > > --switch [char string, Selects the switch imlementation] > --max-ports [int, selects

[dpdk-dev] [PATCH] nfp: using random mac address if not a configured mac

2016-09-13 Thread Ferruh Yigit
On 9/13/2016 6:10 PM, Ferruh Yigit wrote: > Hi Alejandro, > > On 8/16/2016 4:15 PM, Alejandro Lucero wrote: >> Signed-off-by: Alejandro Lucero >> --- > > There are following checkpatch warnings, also check-git-log complains: > > Headline too long: > nfp: unregister interrupt callback fu

[dpdk-dev] [PATCH] nfp: unregister interrupt callback function when closing device

2016-09-13 Thread Ferruh Yigit
On 8/16/2016 4:57 PM, Alejandro Lucero wrote: > With an app using hotplug feature, when a device is unplugged without > unregistering makes the interrupt handling unstable. > > Fixes: 6c53f87b3497 ("nfp: add link status interrupt") > > Signed-off-by: Alejandro Lucero Headline too long:

[dpdk-dev] [PATCH] nfp: fixing bug when copying mac address

2016-09-13 Thread Ferruh Yigit
On 8/16/2016 4:31 PM, Alejandro Lucero wrote: > Fixes: defb9a5dd156 ("nfp: introduce driver initialization") > > Signed-off-by: Alejandro Lucero check-git-log warning, looks like because of "mac" which should be uppercase: Wrong headline lowercase: nfp: fixing bug when copying mac addre

[dpdk-dev] [PATCH] nfp: using random mac address if not a configured mac

2016-09-13 Thread Ferruh Yigit
Hi Alejandro, On 8/16/2016 4:15 PM, Alejandro Lucero wrote: > Signed-off-by: Alejandro Lucero > --- There are following checkpatch warnings, also check-git-log complains: Headline too long: nfp: unregister interrupt callback function when closing device ... > > +static void nfp_net_

[dpdk-dev] [PATCH] net/vhost: Add function to retreive the 'vid' for a given port id.

2016-09-13 Thread Thomas Monjalon
2016-09-13 14:47, Ciara Loftus: > In some cases when using the vHost PMD, certain vHost library functions > may still need to be accessed. One such example is the > rte_vhost_get_queue_num function which returns the number of virtqueues > reported by the guest - information which is not exposed by

[dpdk-dev] [PATCH] app/testpmd: fix timeout in Rx queue flushing

2016-09-13 Thread Ferruh Yigit
On 9/8/2016 10:49 AM, James Poole wrote: > When testpmd is run, the application would hang on the second time > that "start" is executed. This is because the timer limit would get > multiplied to an unreachably high number. > > At the start of flush_fwd_rx_queues(), the timer limit now resets > to

[dpdk-dev] [PATCH v9 00/25] Introducing rte_driver/rte_device generalization

2016-09-13 Thread Shreyansh Jain
Hi Declan, Apologies for delayed reply and thank you so much for your inputs. On Friday 09 September 2016 09:41 PM, Declan Doherty wrote: > On 07/09/16 15:07, Shreyansh Jain wrote: >> Based on master (e22856313) >> >> Background: >> === >> >> It includes two different patch-sets floated o

[dpdk-dev] [PATCH] scripts: hide double git reference check error

2016-09-13 Thread Thomas Monjalon
2016-08-29 10:35, Thomas Monjalon: > When checking a git reference which does not exist, a git error > with the long git-branch usage is printed: > > % scripts/check-git-log.sh '-1 3780cbd' > error: malformed object name 2de9f8551ff9 > usage: git branch ... > [a lot of lines] > Wrong 'Fixes' ref

[dpdk-dev] [PATCH] scripts: remove useless checkpatch notes

2016-09-13 Thread Thomas Monjalon
2016-08-29 11:12, Thomas Monjalon: > Depending of the checkpatch version in use, more or less notes are > printed below the report. > Only 6 lines were stripped, resulting to such note being printed: > NOTE: If any of the errors are false positives, please report > them to the maintainer, see

[dpdk-dev] [PATCH] scripts: reverse order of checked commits

2016-09-13 Thread Thomas Monjalon
2016-09-09 15:42, David Marchand: > On Fri, Sep 9, 2016 at 1:11 PM, Thomas Monjalon > wrote: > > The list of git commits to check was in the reversed order. > > Also add a comment in the help of checkpatches.sh about list input. > > > > Signed-off-by: Thomas Monjalon > > Thanks Thomas. > Tested-

[dpdk-dev] [RFC PATCH v2 5/5] app/test_pmd: add tests for new API's

2016-09-13 Thread Yuanhan Liu
On Tue, Sep 13, 2016 at 08:38:08AM +, Iremonger, Bernard wrote: > Hi Yuanhan, > > > Subject: Re: [dpdk-dev] [RFC PATCH v2 5/5] app/test_pmd: add tests for > > new API's > > > > On Mon, Sep 12, 2016 at 03:57:19PM +, Iremonger, Bernard wrote: > > > > /root/dpdk/x86_64-native-linuxapp- > >

[dpdk-dev] [PATCH v5 00/10] Fix build errors related to exported headers

2016-09-13 Thread Thomas Monjalon
2016-09-08 14:25, Adrien Mazarguil: > DPDK uses GNU C language extensions in most of its code base. This is fine > for internal source files whose compilation flags are controlled by DPDK, > however user applications that use exported "public" headers may experience > compilation failures when enab

[dpdk-dev] [PATCH] vhost: change the vhost library to a common framework which can support more VIRTIO devices

2016-09-13 Thread Thomas Monjalon
2016-09-13 20:58, Yuanhan Liu: > rte_virtio_net.h is the header file will be exported for applications. > Every change there would mean either an API or ABI breakage. Thus, we > should try to avoid touching it. Don't even to say you added yet another > header file, rte_virtio_dev.h. > > I confess

[dpdk-dev] [PATCH v3] doc/guides: add info on how to enable QAT

2016-09-13 Thread Deepak Kumar Jain
From: Eoin Breen Signed-off-by: Eoin Breen Signed-off-by: Deepak Kumar Jain --- Changes in v3: * Add console code-block * Modified the command to replace n with y in build/.config Changes in v2: * Incorporated comments received on v1. doc/guides/cryptodevs/qat.rst | 11 +++ 1 file c

[dpdk-dev] [RFC][PATCH V2 1/3] examples/vhost: Add vswitch (generic switch) framework

2016-09-13 Thread Tan, Jianfeng
Hi Pankaj, On 9/12/2016 6:55 PM, Pankaj Chauhan wrote: > On 9/9/2016 2:26 PM, Tan, Jianfeng wrote: >> Hi Pankaj, >> >> Thanks for the massive and great work. > > Hi Jianfeng, > > Thanks for the review. >> >> On 9/5/2016 6:54 PM, Pankaj Chauhan wrote: >>> Introduce support for a generic framework

[dpdk-dev] [PATCH] net/vhost: Add function to retreive the 'vid' for a given port id.

2016-09-13 Thread Ciara Loftus
In some cases when using the vHost PMD, certain vHost library functions may still need to be accessed. One such example is the rte_vhost_get_queue_num function which returns the number of virtqueues reported by the guest - information which is not exposed by the PMD. This commit introduces a new r

[dpdk-dev] [RFC PATCH v2 1/5] librte_ether: add internal callback functions

2016-09-13 Thread Jerin Jacob
On Fri, Sep 09, 2016 at 04:32:07PM +, ZELEZNIAK, ALEX wrote: > Use case could be to inform application managing SRIOV about VM's intention > to modify parameters like add VLAN which might not be the one which is > assigned to VF or inform about VF reset and reapply settings like strip/insert >

[dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash

2016-09-13 Thread Ferruh Yigit
On 9/11/2016 10:59 AM, zhouyangchao wrote: > Signed-off-by: zhouyangchao > --- There is a typo in the patch subject, I suggest: kni: fix error rollback kernel crash Fixes: 9c61145ff6f9 ("kni: allow multiple threads") Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH v2] doc/guides: add info on how to enable QAT

2016-09-13 Thread Thomas Monjalon
2016-09-13 11:47, Deepak Kumar Jain: > +#. ``make config T=x86_64-native-linuxapp-gcc`` > +#. Open the ``./build/.config`` file > +#. Replace ``CONFIG_RTE_LIBRTE_PMD_QAT=n`` with > ``CONFIG_RTE_LIBRTE_PMD_QAT=y`` It is better to put commands after "code-block:: console" Then I suggest this comman

[dpdk-dev] [PATCH v2] doc/guides: add info on how to enable QAT

2016-09-13 Thread Jain, Deepak K
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, September 13, 2016 12:51 PM > To: Jain, Deepak K > Cc: dev at dpdk.org; De Lara Guarch, Pablo intel.com>; > Breen, Eoin > Subject: Re: [dpdk-dev] [PATCH v2] doc/guides: add info on how t

[dpdk-dev] [PATCH 1/3] lib/librte_table: enabling cuckoo hash into table library

2016-09-13 Thread Yuanhan Liu
On Fri, Aug 26, 2016 at 05:01:16PM -0700, Sankar Chokkalingam wrote: > This patch provides table apis for dosig version of cuckoo hash via > rte_table_hash_cuckoo_dosig_ops > > The following apis are implemented for cuckoo hash > rte_table_hash_cuckoo_create > rte_table_hash_cuckoo_fr

[dpdk-dev] [RFC PATCH v2 5/5] app/test_pmd: add tests for new API's

2016-09-13 Thread Yuanhan Liu
On Mon, Sep 12, 2016 at 03:57:19PM +, Iremonger, Bernard wrote: > > /root/dpdk/x86_64-native-linuxapp- > > clang/include/cmdline_parse_num.h:107:3: note: expanded from macro > > 'TOKEN_NUM_INITIALIZER' > > numtype,/* type */ \ > >

[dpdk-dev] [PATCH] doc/guides: fix name of algorithm

2016-09-13 Thread Deepak Kumar Jain
Update documentation with correct names of algorithm supported. Fixes: 1703e94ac5cee ("qat: add driver for QuickAssist devices") Signed-off-by: Deepak Kumar Jain --- doc/guides/cryptodevs/qat.rst | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/guides/crypt

[dpdk-dev] [PATCH v2] doc/guides: add info on how to enable QAT

2016-09-13 Thread Deepak Kumar Jain
From: Eoin Breen Signed-off-by: Eoin Breen Signed-off-by: Deepak Kumar Jain --- Changes in v2: Incorporated comments received on v1. doc/guides/cryptodevs/qat.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst inde

[dpdk-dev] [PATCH v4] crypto/qat: add Intel QuickAssist C62x device

2016-09-13 Thread Deepak Kumar Jain
From: Deepak Kumar JAIN Signed-off-by: Deepak Kumar Jain Acked-by: Fiona Trahe --- Changes in v4: Fixed the issues in qat.rst file. Changes in v3: Added new feature information Changes in v2: Removed trialing white spaces doc/guides/cryptodevs/qat.rst | 86 +

[dpdk-dev] [RFC PATCH v2 3/5] librte_ether: add API's for VF management

2016-09-13 Thread Thomas Monjalon
2016-09-12 16:28, Iremonger, Bernard: > > On Fri, Aug 26, 2016 at 10:10:18AM +0100, Bernard Iremonger wrote: > > > Add new API functions to configure and manage VF's on a NIC. > > > > > > add rte_eth_dev_vf_ping function. > > > add rte_eth_dev_set_vf_vlan_anti_spoof function. > > > add rte_eth_dev_

[dpdk-dev] [PATCH v2 2/2] kni: add support for core_id param in single threaded mode

2016-09-13 Thread Vladyslav Buslov
Hi Ferruh, Thanks for reviewing my code. Regarding creating kthread within locked mutex section: It is executed in context of ioctl_unlocked so I assume we may have race condition otherwise if multiple threads in same task try to create KNI interface simultaneously. My kernel programming knowle

[dpdk-dev] [PATCH 1/2] examples/tep_term: fix offload on VXLAN failure

2016-09-13 Thread Yuanhan Liu
On Mon, Sep 12, 2016 at 11:36:01AM +0200, Thomas Monjalon wrote: > 2016-09-12 08:42, Tan, Jianfeng: > > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > > > FYI, my testrobot caught some errors when this patch is applied. > > > > It's because this patch set has dependency on a previous

[dpdk-dev] [PATCH v3] crypto/qat: add Intel QuickAssist C62x device

2016-09-13 Thread Deepak Kumar Jain
From: Deepak Kumar JAIN Signed-off-by: Deepak Kumar Jain Acked-by: Fiona Trahe --- Changes in v3: Added new feature information Changes in v2: Removed trialing white spaces doc/guides/cryptodevs/qat.rst | 82 -- doc/guides/rel_notes/release_16_11.rst

[dpdk-dev] [PATCH v3 2/2] app/test: add test cases for NULL for Intel QAT driver

2016-09-13 Thread Deepak Kumar Jain
From: Deepak Kumar JAIN Added NULL algorithm to test file for Intel(R) QuickAssist Technology Driver Signed-off-by: Deepak Kumar Jain --- app/test/test_cryptodev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 855375

[dpdk-dev] [PATCH v3 1/2] crypto/qat: add NULL capability to Intel QAT driver

2016-09-13 Thread Deepak Kumar Jain
From: Deepak Kumar JAIN enabled NULL crypto for Intel(R) QuickAssist Technology Signed-off-by: Deepak Kumar Jain --- doc/guides/cryptodevs/qat.rst| 3 +- doc/guides/rel_notes/release_16_11.rst | 1 + drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++ driv

[dpdk-dev] [PATCH v3 0/2] add NULL crypto support in Intel QAT driver

2016-09-13 Thread Deepak Kumar Jain
This patchset adds support of NULL crypto in Intel(R) QuickAssist Technology driver. This patchset depends on following patchset: "crypto/qat: add aes-sha384-hmac capability to Intel QAT driver" (http://dpdk.org/dev/patchwork/patch/15778/) Deepak Kumar JAIN (2): crypto/qat: add NULL capabilit

[dpdk-dev] [PATCH] doc: add limitations for i40e PMD

2016-09-13 Thread Xing, Beilei
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jingjing Wu > Sent: Tuesday, September 6, 2016 10:17 AM > To: Mcnamara, John > Cc: dev at dpdk.org; Wu, Jingjing ; Zhang, Helin > > Subject: [dpdk-dev] [PATCH] doc: add limitations for i40e PMD > > This patc

[dpdk-dev] [RFC PATCH v2 5/5] app/test_pmd: add tests for new API's

2016-09-13 Thread Iremonger, Bernard
Hi Yuanhan, Subject: Re: [dpdk-dev] [RFC PATCH v2 5/5] app/test_pmd: add tests for > new API's > > On Mon, Sep 12, 2016 at 03:57:19PM +, Iremonger, Bernard wrote: > > > /root/dpdk/x86_64-native-linuxapp- > > > clang/include/cmdline_parse_num.h:107:3: note: expanded from macro > > > 'TOKEN_NU

[dpdk-dev] [PATCH 1/2] examples/tep_term: fix offload on VXLAN failure

2016-09-13 Thread Tan, Jianfeng
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, September 12, 2016 5:36 PM > To: Tan, Jianfeng; Yuanhan Liu > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] examples/tep_term: fix offload on > VXLAN failure > > 2016-