[dpdk-dev] [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-09-29 Thread Maxime Coquelin
On 09/29/2016 10:21 PM, Michael S. Tsirkin wrote: > On Thu, Sep 29, 2016 at 10:05:22PM +0200, Maxime Coquelin wrote: >> >> >> On 09/29/2016 07:57 PM, Michael S. Tsirkin wrote: >>> On Thu, Sep 29, 2016 at 05:30:53PM +0200, Maxime Coquelin wrote: >> ... Before enabling anything by default

[dpdk-dev] [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-09-29 Thread Michael S. Tsirkin
On Thu, Sep 29, 2016 at 10:05:22PM +0200, Maxime Coquelin wrote: > > > On 09/29/2016 07:57 PM, Michael S. Tsirkin wrote: > > On Thu, Sep 29, 2016 at 05:30:53PM +0200, Maxime Coquelin wrote: > ... > > > > > > Before enabling anything by default, we should first optimize the 1 slot > > > case. Ind

[dpdk-dev] [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-09-29 Thread Maxime Coquelin
On 09/29/2016 07:57 PM, Michael S. Tsirkin wrote: > On Thu, Sep 29, 2016 at 05:30:53PM +0200, Maxime Coquelin wrote: ... >> >> Before enabling anything by default, we should first optimize the 1 slot >> case. Indeed, micro-benchmark using testpmd in txonly[0] shows ~17% >> perf regression for 64

[dpdk-dev] [PATCH 0/3] Hash library fixes

2016-09-29 Thread Thomas Monjalon
> > This patchset includes some minor fixes to the hash library, plus a small > > improvement in checking for an empty slot when performing different hash > > operations. > > > > Pablo de Lara (3): > > hash: fix ring size > > hash: fix false zero signature key hit lookup > > hash: check if s

[dpdk-dev] [PATCH v8 2/2] net/vhost: add pmd xstats

2016-09-29 Thread Yuanhan Liu
On Thu, Sep 29, 2016 at 08:35:49PM +0800, Zhiyong Yang wrote: > This feature adds vhost pmd extended statistics from per port perspective > in order to meet the requirements of the applications such as OVS etc. > RX/TX xstats count the bytes without CRC. This is different from physical > NIC stats

[dpdk-dev] [PATCH 2/2] net/virtio: enable any layout feature

2016-09-29 Thread Michael S. Tsirkin
On Thu, Sep 29, 2016 at 09:00:47PM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 26, 2016 at 02:40:56PM +0800, Yuanhan Liu wrote: > > The feature VIRTIO_F_ANY_LAYOUT was actually supported by commit > > dd856dfcb9e7 ("virtio: use any layout on Tx"). But it's not enabled. > > Here this patch enable

[dpdk-dev] [PATCH 2/2] net/virtio: enable any layout feature

2016-09-29 Thread Michael S. Tsirkin
On Mon, Sep 26, 2016 at 02:40:56PM +0800, Yuanhan Liu wrote: > The feature VIRTIO_F_ANY_LAYOUT was actually supported by commit > dd856dfcb9e7 ("virtio: use any layout on Tx"). But it's not enabled. > Here this patch enables it. > > Signed-off-by: Yuanhan Liu Well this will break cross-version m

[dpdk-dev] [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-09-29 Thread Michael S. Tsirkin
On Thu, Sep 29, 2016 at 05:30:53PM +0200, Maxime Coquelin wrote: > > > On 09/28/2016 04:28 AM, Yuanhan Liu wrote: > > On Tue, Sep 27, 2016 at 10:56:40PM +0300, Michael S. Tsirkin wrote: > > > On Tue, Sep 27, 2016 at 11:11:58AM +0800, Yuanhan Liu wrote: > > > > On Mon, Sep 26, 2016 at 10:24:55PM +

[dpdk-dev] [PATCH v8 2/2] net/vhost: add pmd xstats

2016-09-29 Thread Zhiyong Yang
This feature adds vhost pmd extended statistics from per port perspective in order to meet the requirements of the applications such as OVS etc. RX/TX xstats count the bytes without CRC. This is different from physical NIC stats with CRC. The statistics counters are based on RFC 2819 and RFC 2863

[dpdk-dev] [PATCH v8 1/2] net/vhost: add a new defined stats struct

2016-09-29 Thread Zhiyong Yang
The patch moves all stats counters to a new defined struct vhost_stats as follows, in order to manage all stats counters in a unified way and simplify the subsequent function implementation(vhost_dev_xstats_reset). Signed-off-by: Zhiyong Yang --- Changes in v4: A queue can be only used as TX or

[dpdk-dev] [PATCH v8 0/2] net/vhost: add pmd xstats support

2016-09-29 Thread Zhiyong Yang
Patch 1 moves all stats counters to a new defined struct vhost_stats, in order to manage all stats counters in a consistent way. Patch 2 adds the pmd xstats support from per port perspective. RX/TX xstats count the byte without CRC. Changes in V8: Patch 1 fix the build error. Changes in V7: Pa

[dpdk-dev] [PATCH] net/vhost: Add function to retreive the 'vid' for a given port id.

2016-09-29 Thread Yuanhan Liu
On Thu, Sep 29, 2016 at 09:21:11AM +, Mcnamara, John wrote: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ciara Loftus > > Sent: Tuesday, September 13, 2016 2:48 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH] net/vhost: Add function to re

[dpdk-dev] [PATCH v7 2/2] net/vhost: add pmd xstats

2016-09-29 Thread Yuanhan Liu
On Thu, Sep 29, 2016 at 08:48:40AM +, Loftus, Ciara wrote: > Thanks for the patches Zhiyong. I've tested the size stats and they look good > to me. > > Tested-by: Ciara Loftus Ciara, thanks for testing. Zhiyong, please fix the build issue so that I can apply. We have to make sure every com

[dpdk-dev] [PATCH] cryptodev: fix compilation error in SUSE 11 SP2

2016-09-29 Thread De Lara Guarch, Pablo
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com] > Sent: Tuesday, September 27, 2016 12:45 AM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org; Doherty, Declan > Subject: Re: [PATCH] cryptodev: fix compilation error in SUSE 11 SP2 > > On Mon, Sep 26,

[dpdk-dev] [PATCH] drivers/i40e: fix the hash filter invalid calculation in X722

2016-09-29 Thread Ferruh Yigit
On 9/26/2016 11:51 AM, Jeff Guo wrote: > As X722 extracts IPv4 header to Field Vector different with XL710/X710, > need to corresponding to modify the fields of IPv4 header in input set > to map different default Field Vector Table of different nics. > > Signed-off-by: Jeff Guo > --- > drivers/n

[dpdk-dev] [RFC v2] Generic flow director/filtering/classification API

2016-09-29 Thread Adrien Mazarguil
On Fri, Aug 19, 2016 at 08:50:44PM +0200, Adrien Mazarguil wrote: > Hi All, > > Thanks to many for the positive and constructive feedback I've received so > far. Here is the updated specification (v0.7) at last. > > I've attempted to address as many comments as possible but could not > process th

[dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2016-09-29 Thread Rao, Nikhil
On 9/29/2016 6:35 PM, Christian Ehrhardt wrote: > The patch misses a fixed: line which it should get I think. The bug has existed from the day the DPDK was open-sourced, i.e, there wasn't a specific commit that introduced this feature/bug, hence wasn't sure if it needed the fixes tag. > > Bu

[dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF management

2016-09-29 Thread Thomas Monjalon
2016-09-29 16:38, Iremonger, Bernard: > Hi Thomas, > > > Subject: Re: [dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF > > management > > > > 2016-09-29 15:16, Iremonger, Bernard: > > > > 2016-09-29 15:16, Bernard Iremonger: > > > > > +int > > > > > +rte_eth_dev_set_vf_vlan_stripq(uint8_t p

[dpdk-dev] [PATCH 2/4] bnxt: Fix a segfault encountered during KNI exit

2016-09-29 Thread Ferruh Yigit
On 9/29/2016 6:03 PM, Ajit Khaparde wrote: > The bnxt PMD is running into a segfault when exiting out of KNI KNI? > in the dev_uninit/close path. This patch fixes that. > > Signed-off-by: Ajit Khaparde ...

[dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2016-09-29 Thread Thomas Monjalon
2016-09-30 02:54, Nikhil Rao: > The original code used movl instead of xchgl, this caused > rte_atomic64_cmpset to use ebx as the lower dword of the source > to cmpxchg8b instead of the lower dword of function argument "src". Could you please start the explanation with a statement of what is wrong

[dpdk-dev] [PATCH 0/4] bnxt patch series

2016-09-29 Thread Ferruh Yigit
On 9/29/2016 6:03 PM, Ajit Khaparde wrote: > Please consider applying this patch series. > This series is expected to be applied over the previous patchset > once it is accepted. > Depends on: [v2,15/15] bnxt: Update struct definitions to use the 1.5.1 > HWRM API > http://dpdk.org/dev/patchwork/pat

[dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF management

2016-09-29 Thread Thomas Monjalon
2016-09-29 15:16, Iremonger, Bernard: > > 2016-09-29 15:16, Bernard Iremonger: > > > +int > > > +rte_eth_dev_set_vf_vlan_stripq(uint8_t port, uint16_t vf, int on); > > > > Why keeping this function in ethdev? > > This function is using an existing API in the eth_dev_ops structure. > > dev->dev_o

[dpdk-dev] [PATCH v2] app/test: remove hard-coding of crypto num qps

2016-09-29 Thread Fiona Trahe
ts_params->conf.nb_queue_pairs should not be hard coded with device specific number. It should be retrieved from the device info. Any test which changes it should restore it to orig value. Also related cleanup of test code setting number and size of queue-pairs on a device, e.g. * Removed irreleva

[dpdk-dev] [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-09-29 Thread Maxime Coquelin
On 09/28/2016 04:28 AM, Yuanhan Liu wrote: > On Tue, Sep 27, 2016 at 10:56:40PM +0300, Michael S. Tsirkin wrote: >> On Tue, Sep 27, 2016 at 11:11:58AM +0800, Yuanhan Liu wrote: >>> On Mon, Sep 26, 2016 at 10:24:55PM +0300, Michael S. Tsirkin wrote: On Mon, Sep 26, 2016 at 11:01:58AM -0700, S

[dpdk-dev] [PATCH v5 2/3] net/ixgbe: add API's for VF management

2016-09-29 Thread Reshma Pattan
Hi, On 9/29/2016 3:16 PM, Bernard Iremonger wrote: > diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile > index a6c71f3..7493b8d 100644 > --- a/drivers/net/ixgbe/Makefile > +++ b/drivers/net/ixgbe/Makefile > @@ -119,6 +119,8 @@ SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_bypass

[dpdk-dev] [PATCH v3 5/6] ixgbe: add Tx preparation

2016-09-29 Thread Ananyev, Konstantin
I Tomasz, > > > > Just thought about it once again: > > As now inside rte_eth_tx_prep() we do now: > > + > > + if (!dev->tx_pkt_prep) > > + return nb_pkts; > > > > Then there might be a better approach to set > > dev->tx_pkt_prep = NULL > > for simple and vector TX functions? > > > > A

[dpdk-dev] [PATCH v3 9/9] examples/ipsec-secgw: update ipsec-secgw guide

2016-09-29 Thread Sergio Gonzalez Monroy
Update sample guide to reflect support for new algorithms. Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/sample_app_ug/ipsec_secgw.rst | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst b/doc/guides/sample_app_ug/

[dpdk-dev] [PATCH v3 9/9] doc: update ipsec-secgw sample app guide

2016-09-29 Thread Sergio Gonzalez Monroy
Update sample guide to reflect support for new algorithms. Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/sample_app_ug/ipsec_secgw.rst | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst b/doc/guides/sample_app_ug/

[dpdk-dev] [PATCH v3 8/9] examples/ipsec-secgw: update release notes

2016-09-29 Thread Sergio Gonzalez Monroy
Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/rel_notes/release_16_11.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst index cc507a9..168d589 100644 --- a/doc/guides/rel_notes/release_16_11.rst

[dpdk-dev] [PATCH v3 8/9] doc: ipsec-secgw release notes

2016-09-29 Thread Sergio Gonzalez Monroy
Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/rel_notes/release_16_11.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst index cc507a9..168d589 100644 --- a/doc/guides/rel_notes/release_16_11.rst

[dpdk-dev] [PATCH v3 7/9] examples/ipsec-secgw: initialize sa salt

2016-09-29 Thread Sergio Gonzalez Monroy
This patch initializes the salt value used by the following cipher algorithms: - CBC: random salt - GCM/CTR: the key required is 20B, and the last 4B are used as salt. Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/sa.c | 17 ++--- 1 file changed, 14 insertions(+), 3

[dpdk-dev] [PATCH v3 6/9] examples/ipsec-secgw: add cryptodev queue size macro

2016-09-29 Thread Sergio Gonzalez Monroy
Introduce a specific cryptodev queue size macro. Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/ipsec-secgw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index 9eee96f..5a4c9b7 1006

[dpdk-dev] [PATCH v3 5/9] examples/ipsec-secgw: check sp only when setup

2016-09-29 Thread Sergio Gonzalez Monroy
Application will segfault if there is IPv4 or IPv6 and no SP/ACL rules for IPv4 or IPv6 respectively. Avoid checking the ACL/SP in such cases. Fixes: 906257e965b7 ("examples/ipsec-secgw: support IPv6") Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/ipsec-secgw.c | 4 ++-- 1 fil

[dpdk-dev] [PATCH v3 4/9] examples/ipsec-secgw: enable AES-CTR mode

2016-09-29 Thread Sergio Gonzalez Monroy
RFC3686: Using AES Counter (CTR) Mode With IPsec ESP.` Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/esp.c | 2 ++ examples/ipsec-secgw/sa.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c index 7ee53da..ec5a2e

[dpdk-dev] [PATCH v3 3/9] examples/ipsec-secgw: add AES-GCM support

2016-09-29 Thread Sergio Gonzalez Monroy
Add support for AES-GCM (Galois-Counter Mode). RFC4106: The Use of Galois-Counter Mode (GCM) in IPSec ESP. Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/esp.c | 59 ++-- examples/ipsec-secgw/ipsec.h | 9 +++ examples/ipsec-secgw/sa

[dpdk-dev] [PATCH v3 2/9] examples/ipsec-secgw: reset crypto operation status

2016-09-29 Thread Sergio Gonzalez Monroy
Signed-off-by: Sergio Gonzalez Monroy --- examples/ipsec-secgw/ipsec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c index 1e87d0d..f49143b 100644 --- a/examples/ipsec-secgw/ipsec.c +++ b/examples/ipsec-secgw/ipsec.c @@ -124,6 +124

[dpdk-dev] [PATCH v3 1/9] examples/ipsec-secgw: change CBC IV generation

2016-09-29 Thread Sergio Gonzalez Monroy
NIST SP800-38A recommends two methods to generate unpredictable IVs (Initilisation Vector) for CBC mode: 1) Apply the forward function to a nonce (ie. counter) 2) Use a FIPS-approved random number generator This patch implements the first recommended method by using the forward function to generat

[dpdk-dev] [PATCH v3 0/9] IPsec Enhancements

2016-09-29 Thread Sergio Gonzalez Monroy
This patch set mainly adds support for AES-GCM and AES-CTR. It also updates the IV generation method for AES-CBC mode using the forward function instead of randomly generating the IV. v3: - update sample app guide - remove unused function - improve commit messages v2: - Update releas notes.

[dpdk-dev] [PATCH] eal: check cpu flags at init

2016-09-29 Thread Aaron Conole
Flavio Leitner writes: > On Mon, Sep 26, 2016 at 11:43:37AM -0400, Aaron Conole wrote: >> My only concern is whether this change would be considered ABI >> breaking. I wouldn't think so, since it doesn't seem as though an >> application would want to call this explicitly (and is spelled out as >

[dpdk-dev] [PATCH v3 3/3] examples/l2fwd-crypto: updated example for libcrypto PMD

2016-09-29 Thread Slawomir Mrozowicz
Libcrypto PMD has support for: Supported cipher algorithms: RTE_CRYPTO_CIPHER_3DES_CBC RTE_CRYPTO_CIPHER_AES_CBC RTE_CRYPTO_CIPHER_AES_CTR RTE_CRYPTO_CIPHER_3DES_CTR RTE_CRYPTO_CIPHER_AES_GCM Supported authentication algorithms: RTE_CRYPTO_AUTH_AES_GMAC RTE_CRYPTO_AUTH_MD5 RTE_CRYPTO_AUTH_SHA1 RT

[dpdk-dev] [PATCH 13/13] net/thunderx: document secondary queue set support

2016-09-29 Thread Maciej Czekaj
We will address all the issues in v2. >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Kamil Rytarowski >> Sent: Friday, August 26, 2016 5:54 PM >> To: dev at dpdk.org >> Cc: maciej.czekaj at caviumnetworks.com; zyta.szpak at semihalf.com; >> slawomir.rose

[dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF management

2016-09-29 Thread Iremonger, Bernard
Hi Thomas, > Subject: Re: [dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF > management > > 2016-09-29 15:16, Iremonger, Bernard: > > > 2016-09-29 15:16, Bernard Iremonger: > > > > +int > > > > +rte_eth_dev_set_vf_vlan_stripq(uint8_t port, uint16_t vf, int > > > > +on); > > > > > > Why keep

[dpdk-dev] [PATCH 12/13] net/thunderx: add final bits for secondary queue support

2016-09-29 Thread Maciej Czekaj
> On 8/26/2016 5:54 PM, Kamil Rytarowski wrote: >> From: Kamil Rytarowski >> >> Signed-off-by: Maciej Czekaj >> Signed-off-by: Kamil Rytarowski >> Signed-off-by: Zyta Szpak >> Signed-off-by: Slawomir Rosek >> Signed-off-by: Radoslaw Biernacki >> Signed-off-by: Jerin Jacob >> --- > > Is it po

[dpdk-dev] [PATCH 07/13] net/thunderx: fix multiprocess support in stats

2016-09-29 Thread Maciej Czekaj
> On 8/26/2016 5:54 PM, Kamil Rytarowski wrote: >> From: Kamil Rytarowski >> >> In case of the multiprocess mode a shared nicvf struct between processes >> cannot point with the eth_dev pointer to master device, therefore remove it >> allong with references to it refactoring the code where needed.

[dpdk-dev] [PATCH v5 2/3] net/ixgbe: add API's for VF management

2016-09-29 Thread Iremonger, Bernard
Hi Reshma, > -Original Message- > From: Pattan, Reshma > Sent: Thursday, September 29, 2016 5:11 PM > To: Iremonger, Bernard ; dev at dpdk.org; > Shah, Rahul R ; Lu, Wenzhuo > ; az5157 at att.com > Cc: azelezniak > Subject: Re: [dpdk-dev] [PATCH v5 2/3] net/ixgbe: add API's for VF > mana

[dpdk-dev] [PATCH v7] net/virtio: add set_mtu in virtio

2016-09-29 Thread Dey
Virtio interfaces do not currently allow the user to specify a particular Maximum Transmission Unit (MTU).Consequently, the MTU of Virtio interfaces is typically set to the Ethernet default value of 1500. This is problematic in the case of cloud deployments, in which a specific (and potentially

[dpdk-dev] [PATCH v5 2/3] net/ixgbe: add API's for VF management

2016-09-29 Thread Iremonger, Bernard
Hi Reshma, > -Original Message- > From: Pattan, Reshma > Sent: Thursday, September 29, 2016 5:16 PM > To: Iremonger, Bernard ; dev at dpdk.org; > Shah, Rahul R ; Lu, Wenzhuo > ; az5157 at att.com > Cc: Iremonger, Bernard ; azelezniak > > Subject: RE: [dpdk-dev] [PATCH v5 2/3] net/ixgbe: a

[dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF management

2016-09-29 Thread Thomas Monjalon
2016-09-29 15:16, Bernard Iremonger: > Add new API function to configure and manage VF's on a NIC. > > add rte_eth_dev_set_vf_vlan_stripq function. > > Signed-off-by: azelezniak We need the full name of azelezniak. > Signed-off-by: Bernard Iremonger [...] > +int > +rte_eth_dev_set_vf_vlan_str

[dpdk-dev] [PATCH] app/test: Remove hard coding for nb_queue_pairs in test_cryptodev

2016-09-29 Thread Thomas Monjalon
2016-09-29 14:12, Trahe, Fiona: > > > From: Akhil Goyal > > > > > > nb_queue_pairs should not be hard coded with device specific number. > > > It should be retrieved from the device infos. > > > Also in ut_setup, ts_params->conf.nb_queue_pairs is already set in > > > testsuite_setup and we are not

[dpdk-dev] [PATCH 04/13] net/thunderx/base: add secondary queue set support

2016-09-29 Thread Maciej Czekaj
> On 8/26/2016 5:53 PM, Kamil Rytarowski wrote: >> From: Kamil Rytarowski >> >> Changes: >> - add new message sqs_alloc in mailbox >> - add a queue container to hold secondary qsets. >> - add nicvf_mbox_request_sqs >> - handle new mailbox messages for secondary queue set support >> - register

[dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2016-09-29 Thread Thomas Monjalon
2016-09-29 18:46, Rao, Nikhil: > > On 9/29/2016 6:35 PM, Christian Ehrhardt wrote: > > The patch misses a fixed: line which it should get I think. > > The bug has existed from the day the DPDK was open-sourced, i.e, there wasn't > a specific > commit that introduced this feature/bug, hence wasn'

[dpdk-dev] [PATCH 01/13] net/thunderx: cleanup the driver before adding new features

2016-09-29 Thread Maciej Czekaj
> On 8/26/2016 5:53 PM, Kamil Rytarowski wrote: >> From: Kamil Rytarowski >> >> Refactored features: >> - enable nicvf_qset_rbdr_precharge to handle handle secondary queue sets > double "handle" Will fix comment in v2. > >> - rte_free already handles NULL pointer >> - check mempool flags

[dpdk-dev] [PATCH v5 2/3] net/ixgbe: add API's for VF management

2016-09-29 Thread Pattan, Reshma
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bernard Iremonger > Sent: Thursday, September 29, 2016 3:17 PM > To: dev at dpdk.org; Shah, Rahul R ; Lu, Wenzhuo > ; az5157 at att.com > Cc: Iremonger, Bernard ; azelezniak > > Subject: [dpdk-dev] [PATCH v

[dpdk-dev] [PATCH v3 2/3] app/test: added tests for libcrypto PMD

2016-09-29 Thread Slawomir Mrozowicz
This patch containes unit tests for libcrypto PMD. User can use app/test application to check how to use this pmd and to verify crypto processing. Test name is cryptodev_libcrypto_autotest. For performance test cryptodev_libcrypto_perftest can be used. Signed-off-by: Piotr Azarewicz Signed-off-b

[dpdk-dev] [PATCH v3 1/3] libcrypto_pmd: initial implementation of SW crypto device

2016-09-29 Thread Slawomir Mrozowicz
This code provides the initial implementation of the libcrypto poll mode driver. All cryptography operations are using Openssl library crypto API. Each algorithm uses EVP_ interface from openssl API - which is recommended by Openssl maintainers. This patch adds libcrypto poll mode driver support t

[dpdk-dev] [PATCH v3 0/3] new crypto software based device

2016-09-29 Thread Slawomir Mrozowicz
This code provides the initial implementation of the libcrypto poll mode driver. All cryptography operations are using Openssl library crypto API. Each algorithm uses EVP_ interface from openssl API - which is recommended by Openssl maintainers. For more information about how to use this driver, g

[dpdk-dev] [PATCH v2 1/7] examples/ipsec-secgw: change CBC IV generation

2016-09-29 Thread Sergio Gonzalez Monroy
On 28/09/2016 04:51, De Lara Guarch, Pablo wrote: > Hi Sergio, > >> -Original Message- >> From: Gonzalez Monroy, Sergio >> Sent: Friday, September 23, 2016 12:45 AM >> To: dev at dpdk.org; De Lara Guarch, Pablo >> Subject: [PATCH v2 1/7] examples/ipsec-secgw: change CBC IV generation >> >>

[dpdk-dev] [PATCH v2 8/8] examples/ipsec-secgw: update release notes

2016-09-29 Thread Sergio Gonzalez Monroy
On 28/09/2016 05:05, De Lara Guarch, Pablo wrote: > Hi Sergio, > >> -Original Message- >> From: Gonzalez Monroy, Sergio >> Sent: Friday, September 23, 2016 12:46 AM >> To: dev at dpdk.org; De Lara Guarch, Pablo >> Subject: [PATCH v2 8/8] examples/ipsec-secgw: update release notes >> >> Sign

[dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF management

2016-09-29 Thread Iremonger, Bernard
Hi Thomas, > Subject: Re: [dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF > management > > 2016-09-29 15:16, Bernard Iremonger: > > Add new API function to configure and manage VF's on a NIC. > > > > add rte_eth_dev_set_vf_vlan_stripq function. > > > > Signed-off-by: azelezniak > > We

[dpdk-dev] [PATCH v5 3/3] app/test_pmd: add tests for new API's

2016-09-29 Thread Bernard Iremonger
add test for set vf vlan anti spoof add test for set vf mac anti spoof add test for set vf vlan stripq add test for set vf vlan insert add test for set tx loopback add test for set all queues drop enable bit add test for set vf split drop enable bit add test for set vf mac address add new API's to

[dpdk-dev] [PATCH v5 2/3] net/ixgbe: add API's for VF management

2016-09-29 Thread Bernard Iremonger
Add API's to configure and manage VF's on an Intel 82559 NIC. add rte_pmd_ixgbe_set_vf_vlan_anti_spoof function. add rte_pmd_ixgbe_set_vf_mac_anti_spoof function. Signed-off-by: azelezniak add rte_pmd_ixgbe_set_vf_vlan_insert function. add rte_pmd_ixgbe_set_tx_loopback function. add rte_pmd_ixg

[dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF management

2016-09-29 Thread Bernard Iremonger
Add new API function to configure and manage VF's on a NIC. add rte_eth_dev_set_vf_vlan_stripq function. Signed-off-by: azelezniak Signed-off-by: Bernard Iremonger --- lib/librte_ether/rte_ethdev.c | 27 +++ lib/librte_ether/rte_ethdev.h | 23 +

[dpdk-dev] [PATCH v5 0/3] add API's for VF management

2016-09-29 Thread Bernard Iremonger
This patchset contains new DPDK API's requested by AT&T for use with the Virtual Function Daemon (VFD). The need to configure and manage VF's on a NIC has grown to the point where AT&T have devloped a DPDK based tool, VFD, to do this. This patch set adds API extensions to DPDK VF configuration.

[dpdk-dev] [PATCH v3 5/6] ixgbe: add Tx preparation

2016-09-29 Thread Kulasek, TomaszX
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, September 29, 2016 13:09 > To: Kulasek, TomaszX ; dev at dpdk.org > Subject: RE: [PATCH v3 5/6] ixgbe: add Tx preparation > > Hi Tomasz, > > > Signed-off-by: Tomasz Kulasek > > --- ... > > +*/ > > +uint1

[dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2016-09-29 Thread Christian Ehrhardt
The patch misses a fixed: line which it should get I think. But in general If applied -> stable for this one? On Thu, Sep 29, 2016 at 11:24 PM, Nikhil Rao wrote: > The original code used movl instead of xchgl, this caused > rte_atomic64_cmpset to use ebx as the lower dword of the source > to c

[dpdk-dev] [PATCH V2 2/2] virtio: support IOMMU platform

2016-09-29 Thread Maxime Coquelin
On 09/28/2016 10:25 AM, Jason Wang wrote: > Negotiate VIRTIO_F_IOMMU_PLATFORM to have IOMMU support. > > Signed-off-by: Jason Wang > --- > Changes from v1: > - remove unnecessary NEED_MAPPING flag > --- > drivers/net/virtio/virtio_ethdev.h | 3 ++- > drivers/net/virtio/virtio_pci.h| 3 ++- >

[dpdk-dev] [PATCH V2 1/2] net/virtio: support modern device id

2016-09-29 Thread Maxime Coquelin
On 09/28/2016 10:25 AM, Jason Wang wrote: > Add modern device id and rename VIRTIO_PCI_DEVICEID_MIN to > VIRTIO_PCI_LEGACY_DEVICEID_NET. While at it, remove unused macros too. > > Signed-off-by: Jason Wang > --- > drivers/net/virtio/virtio_ethdev.c | 3 ++- > drivers/net/virtio/virtio_pci.h

[dpdk-dev] [PATCH] app/test: Remove hard coding for nb_queue_pairs in test_cryptodev

2016-09-29 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, September 29, 2016 7:25 AM > To: Trahe, Fiona > Cc: dev at dpdk.org; De Lara Guarch, Pablo; akhil.goyal at nxp.com > Subject: Re: [dpdk-dev] [PATCH] app/test: Remove hard coding for > nb_q

[dpdk-dev] [PATCH v2]:rte_timer:timer lag issue correction

2016-09-29 Thread Karmarkar Suyash
Hello, Can you please review the changes and suggest next steps? Thanks Regards Suyash Karmarkar -Original Message- From: Karmarkar Suyash Sent: Wednesday, September 21, 2016 4:54 PM To: dev at dpdk.org; thomas.monjalon at 6wind.com; rsanford at akamai.com; reshma.pattan at intel.com C

[dpdk-dev] [PATCH 2/2] app/testpmd/txonly: Reset headroom after raw packet allocation

2016-09-29 Thread Maxime Coquelin
This patch fixes txonly raw packets allocations by resetting the available headroom. Indeed, some PMDs such as Virtio might prepend some data to the packet, resulting in mbuf's data_off field to be decremented each time the mbuf gets re-allocated. For Virtio PMD, it means that we use only single

[dpdk-dev] [PATCH 1/2] mbuf: add rte_pktmbuff_reset_headroom function

2016-09-29 Thread Maxime Coquelin
Some application use rte_mbuf_raw_alloc() function to improve performance by not resetting mbuf's fields to their default state. This can be however problematic for mbuf consumers that need some headroom, meaning that data_off field gets decremented after allocation. When the mbuf is re-used after

[dpdk-dev] [PATCH] app/test: Remove hard coding for nb_queue_pairs in test_cryptodev

2016-09-29 Thread Trahe, Fiona
Hi Ahkil > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Monday, September 26, 2016 8:37 PM > To: akhil.goyal at nxp.com; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] app/test: Remove hard coding for > nb_queue_pairs in te

[dpdk-dev] [PATCH 2/4] bnxt: Fix a segfault encountered during KNI exit

2016-09-29 Thread Ajit Khaparde
On Thu, Sep 29, 2016 at 12:41 PM, Ferruh Yigit wrote: > On 9/29/2016 6:03 PM, Ajit Khaparde wrote: > > The bnxt PMD is running into a segfault when exiting out of KNI > > KNI? > examples/kni ?On closing the kni app, I am seeing a segfault.? because of improper cleanup of resources in the dev_uni

[dpdk-dev] [PATCH v2 2/4] net/bnxt: ensure entry_length is unsigned in bnxt_alloc_vnic_attributes

2016-09-29 Thread Ajit Khaparde
On Thu, Sep 29, 2016 at 12:39 PM, John W. Linville wrote: > Otherwise, the inherent cast when multiplying entry_length by max_vnics > in the call to rte_memzone_reserve could promote max_vnics to a signed > value, causing hilarity to ensue... > > Coverity issue: 127557 > Fixes: 9738793f28ec ("net

[dpdk-dev] [PATCH v3 1/6] ethdev: add Tx preparation

2016-09-29 Thread Ananyev, Konstantin
> -Original Message- > From: Kulasek, TomaszX > Sent: Thursday, September 29, 2016 2:04 PM > To: Ananyev, Konstantin ; dev at dpdk.org > Subject: RE: [PATCH v3 1/6] ethdev: add Tx preparation > > Hi Konstantin, > > > -Original Message- > > From: Ananyev, Konstantin > > Sent: Thu

[dpdk-dev] [PATCH 4/4] net/enic: extend fdir support for 1300 series adapters

2016-09-29 Thread John Daley
1300 series Cisco adapter firmware version 2.0(13) for UCS C-series servers and 3.1(2) for blade servers supports more filtering capabilities. The feature can be enabled via Cisco CIMC or USCM with the 'advanced filters' radio button. When enabled, the these additional flow director modes are avail

[dpdk-dev] [PATCH 3/4] net/enic: update VIC interface file

2016-09-29 Thread John Daley
Update the VIC adapter file which is common with the firmware and other VIC drivers. This is needed to support new capabilities for 1300 adapters, including advanced filtering, which is available in VIC firmware version 2.0(13) for UCS rack and 3.1(2). Signed-off-by: John Daley --- drivers/net/e

[dpdk-dev] [PATCH 2/4] net/enic: fix segfault when restarting with fdir filters

2016-09-29 Thread John Daley
When flow director filters where removed when an enic device is stopped, the filters were freed but the pointer was not set to NULL so the next stop would try to free them again. Fixes: fefed3d1e62c ("enic: new driver") Signed-off-by: John Daley --- drivers/net/enic/enic_clsf.c | 1 + 1 file ch

[dpdk-dev] [PATCH 1/4] net/enic: fix fdir usage with scattered Rx

2016-09-29 Thread John Daley
The wrong queue id was being used in the enic flow director code after the scattered Rx feature was added. Fixes: 856d7ba7ed22 ("net/enic: support scattered Rx") Signed-off-by: John Daley --- drivers/net/enic/enic_clsf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dri

[dpdk-dev] [PATCH] net/enic: update enic guide and add warning for invalid conf

2016-09-29 Thread John Daley
From: Nelson Escobar Update the enic guide to better explain how to setup vNIC parameters on the Cisco VIC since the introduction of rx scatter and print an error message for the case of having 1 RQ configured in the vNIC. Signed-off-by: Nelson Escobar --- doc/guides/nics/enic.rst | 53 +++

[dpdk-dev] [PATCH v8 2/2] net/vhost: add pmd xstats

2016-09-29 Thread Yang, Zhiyong
Thanks very much, yuanhan. > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Thursday, September 29, 2016 9:05 PM > To: Yang, Zhiyong > Cc: dev at dpdk.org; Loftus, Ciara > Subject: Re: [PATCH v8 2/2] net/vhost: add pmd xstats > > On Thu, Sep 29,

[dpdk-dev] [PATCH v4 1/2] librte_ether: add protection against overwrite device data

2016-09-29 Thread Kerlin, MarcinX
Hi Reshma, > -Original Message- > From: Pattan, Reshma > Sent: Wednesday, September 28, 2016 4:04 PM > To: Kerlin, MarcinX ; dev at dpdk.org > Cc: De Lara Guarch, Pablo ; > thomas.monjalon at 6wind.com; Kerlin, MarcinX > Subject: RE: [dpdk-dev] [PATCH v4 1/2] librte_ether: add protection

[dpdk-dev] [PATCH v2 4/4] net/bnxt: add ULL suffix to constant 1 for bit shift in bnxt_mac_addr_remove_op

2016-09-29 Thread John W. Linville
Some(?) compilers will treat the unmarked constant 1 as a 32-bit integer, but the shift operation is in a loop that could run up to 63 times -- undefined behavior! Coverity issue: 127546 Fixes: 778b759ba10e ("net/bnxt: add MAC address") Signed-off-by: John W. Linville --- v2: fix-up changelog en

[dpdk-dev] [PATCH v2 3/4] net/i40e: do not use vsi until after NULL check in i40e_vsi_release

2016-09-29 Thread John W. Linville
Coverity issue: 127556 Fixes: 440499cf5376 ("net/i40e: support floating VEB") Signed-off-by: John W. Linville Acked-by: Ferruh Yigit --- v2: fix-up changelog entries based-on comments from Ferruh Yigit drivers/net/i40e/i40e_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) dif

[dpdk-dev] [PATCH v2 2/4] net/bnxt: ensure entry_length is unsigned in bnxt_alloc_vnic_attributes

2016-09-29 Thread John W. Linville
Otherwise, the inherent cast when multiplying entry_length by max_vnics in the call to rte_memzone_reserve could promote max_vnics to a signed value, causing hilarity to ensue... Coverity issue: 127557 Fixes: 9738793f28ec ("net/bnxt: add VNIC functions and structs") Signed-off-by: John W. Linvill

[dpdk-dev] [PATCH v2 1/4] net/ena: improve safety of string handling in ena_config_host_info

2016-09-29 Thread John W. Linville
Use sizeof dest rather than sizeof src for limiting copy length, and replace strncpy with snprintf to ensure NULL termination. Coverity issue: 127795 Fixes: 372c1af5ed8f ("net/ena: add dedicated memory area for extra device info") Signed-off-by: John W. Linville --- v2: fix-up changelog entries

[dpdk-dev] [PATCH v2 0/4] random fixes for bugs identified by Coverity

2016-09-29 Thread John W. Linville
Today I attempted to exercise my brain between meetings by handling a few bugs identified by Coverity. All of the fixes are simple and (hopefully) obvious. They are compile-tested only. v2: fix-up changelog entries based-on comments from Ferruh Yigit John -- John W. LinvilleSomed

[dpdk-dev] [PATCH v3 1/6] ethdev: add Tx preparation

2016-09-29 Thread Kulasek, TomaszX
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, September 29, 2016 12:41 > To: Kulasek, TomaszX ; dev at dpdk.org > Subject: RE: [PATCH v3 1/6] ethdev: add Tx preparation > > Hi Tomasz, > > > > > diff --git a/lib/librte_net/rte_pkt.h b/lib/librte_n

[dpdk-dev] [PATCH v7 2/2] net/vhost: add pmd xstats

2016-09-29 Thread Yang, Zhiyong
Hi, yuanhan: The new version has been ready, I will send it later. I'm thinking about how to avoid this kind of issue in an appropriate way. Thanks Zhiyong > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Thursday, September 29, 2016 8:02 PM > To:

[dpdk-dev] [PATCH 4/4] bnxt: Update the Broadcom PMD driver documentation

2016-09-29 Thread Ajit Khaparde
This patch reformats the Broadcom PMD driver documentation based on recommendations from previous review referenced below: http://dpdk.org/dev/patchwork/patch/16144/ Also since the PMD now loads on a VF interface, update the documentation accordingly. Signed-off-by: Ajit Khaparde --- doc/guides

[dpdk-dev] [PATCH 3/4] bnxt: Add support for Async Link Notification

2016-09-29 Thread Ajit Khaparde
This patch adds support to get Link notification asynchronously. The HW sends Async notifications on default completion ring. The PMD processes these notifications and logs a message appropriately. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt.h

[dpdk-dev] [PATCH 2/4] bnxt: Fix a segfault encountered during KNI exit

2016-09-29 Thread Ajit Khaparde
The bnxt PMD is running into a segfault when exiting out of KNI in the dev_uninit/close path. This patch fixes that. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 1 + drivers/net/bnxt/bnxt_ethdev.c | 34 ++ 2 files changed, 23 insertions(+),

[dpdk-dev] [PATCH 1/4] testpmd: Add support to configure 25G and 50G speeds

2016-09-29 Thread Ajit Khaparde
Support to configure 25G and 50G speeds is missing from testpmd. This patch also updates the testpmd user guide accordingly. Signed-off-by: Ajit Khaparde --- app/test-pmd/cmdline.c | 14 +- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- 2 files changed, 10

[dpdk-dev] [PATCH 0/4] bnxt patch series

2016-09-29 Thread Ajit Khaparde
Please consider applying this patch series. This series is expected to be applied over the previous patchset once it is accepted. Depends on: [v2,15/15] bnxt: Update struct definitions to use the 1.5.1 HWRM API http://dpdk.org/dev/patchwork/patch/16154/ Ajit Khaparde (4): testpmd: Add support to

[dpdk-dev] [PATCH] scripts: show fixes with release version of bug

2016-09-29 Thread Thomas Monjalon
This script can help to find commits to backport in stable branches. Fixes are found if there is the word "fix" in the headline or if there is a tag Fixes: or Reverts: in the message. Chained fixes of fixes are explored to find the oldest origin. Fixes of not released bugs are ignored. Signed-off

[dpdk-dev] [PATCH] net/vhost: Add function to retreive the 'vid' for a given port id.

2016-09-29 Thread Thomas Monjalon
2016-09-29 09:21, Mcnamara, John: > > In some cases when using the vHost PMD, certain vHost library functions > > may still need to be accessed. One such example is the > > rte_vhost_get_queue_num function which returns the number of virtqueues > > reported by the guest - information which is not e

[dpdk-dev] [PATCH v3 5/6] ixgbe: add Tx preparation

2016-09-29 Thread Ananyev, Konstantin
Hi Tomasz, > Signed-off-by: Tomasz Kulasek > --- > drivers/net/ixgbe/ixgbe_ethdev.c |3 ++ > drivers/net/ixgbe/ixgbe_ethdev.h |8 +++- > drivers/net/ixgbe/ixgbe_rxtx.c | 85 > +- > drivers/net/ixgbe/ixgbe_rxtx.h |2 + > 4 files changed, 96 i

[dpdk-dev] [PATCH v3 1/6] ethdev: add Tx preparation

2016-09-29 Thread Ananyev, Konstantin
Hi Tomasz, > -Original Message- > From: Kulasek, TomaszX > Sent: Wednesday, September 28, 2016 12:11 PM > To: dev at dpdk.org > Cc: Ananyev, Konstantin ; Kulasek, TomaszX > > Subject: [PATCH v3 1/6] ethdev: add Tx preparation > > Added API for `rte_eth_tx_prep` > > uint16_t rte_eth_tx_

[dpdk-dev] Did we reduce unnecessary linkage too well?

2016-09-29 Thread Panu Matilainen
On 09/29/2016 09:58 AM, Christian Ehrhardt wrote: > Hi, > I was finally getting to more deeply re-validate Openvswitch 2.6 together > with DPDK 16.07. And I think I found a whiplash of our effort to reduce > unnecessary hard linkage. > > Trying to avoid cross-posting, picking DPDK list and the main

[dpdk-dev] [PATCH v2 4/4] examples/l2fwd-crypto: enable ZUC EEA3 and EIA3 algos

2016-09-29 Thread Jain, Deepak K
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Thursday, September 29, 2016 4:00 AM > To: dev at dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > > Subject: [dpdk-dev] [PATCH v2 4/4] examples/l2fwd-crypto: enable ZUC > EEA3 and

  1   2   >