[dpdk-dev] [PATCH] kni: add support for core_id param in single threaded mode

2016-10-13 Thread Thomas Monjalon
> > Allow binding KNI thread to specific core in single threaded mode > > by setting core_id and force_bind config parameters. > > > > Signed-off-by: Vladyslav Buslov > > Acked-by: Ferruh Yigit > > Tested-by: Ferruh Yigit Applied, thanks

[dpdk-dev] [PATCH v4 2/3] app/test: add a case to verify lpm tlb8 recycle

2016-10-13 Thread Thomas Monjalon
2016-08-08 14:40, Wei Dai: > As a bug-fix for lpm tlb8 recycle is introduced, > add a test case to verify tlb8 group is correctly > freed when it only includes a rule with depth=24. > > Signed-off-by: Wei Dai > Acked-by: Bruce Richardson Series applied with typo tlb/tbl fixed

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

2016-10-13 Thread Yuanhan Liu
On Thu, Oct 13, 2016 at 04:02:49PM +0200, Olivier MATZ wrote: > > > On 10/13/2016 10:18 AM, Yuanhan Liu wrote: > >On Mon, Oct 03, 2016 at 11:00:23AM +0200, Olivier Matz wrote: > >>+/* When doing TSO, the IP length is not included in the pseudo header > >>+ * checksum of the packet given to the

[dpdk-dev] [PATCH v4] log: respect rte_openlog_stream calls before rte_eal_init

2016-10-13 Thread Thomas Monjalon
2016-10-12 12:38, John Ousterhout: > Before this patch, application-specific loggers could not be > installed before rte_eal_init completed (the initialization process > called rte_openlog_stream, overwriting any previously installed > logger). This made it impossible for an application to capture

[dpdk-dev] [PATCH v3 12/12] net/virtio: add Tso support

2016-10-13 Thread Olivier Matz
On 10/13/2016 08:50 PM, Thomas Monjalon wrote: > 2016-10-14 00:05, Yuanhan Liu: >> On Thu, Oct 13, 2016 at 04:16:11PM +0200, Olivier Matz wrote: >>> +/* When doing TSO, the IP length is not included in the pseudo header >>> + * checksum of the packet given to the PMD, but for virtio it is >>> +

[dpdk-dev] [PATCH] eal: avoid unnecessary conflicts over rte_config file

2016-10-13 Thread Tahhan, Maryam
> Hi John, > > > Before this patch, DPDK used the file ~/.rte_config as a lock to > > detect potential interference between multiple DPDK applications > > running on the same machine. However, if a single user ran DPDK > > applications concurrently on several different machines, and if the > >

[dpdk-dev] [PATCH] fix documentation error on debug functions

2016-10-13 Thread Thomas Monjalon
2016-09-26 12:28, Mcnamara, John: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mauricio Vasquez B > > Sent: Friday, September 2, 2016 12:02 PM > > To: dev at dpdk.org > > Cc: stephen at networkplumber.org > > Subject: [dpdk-dev] [PATCH] fix

[dpdk-dev] [PATCH v5 1/6] ethdev: add Tx preparation

2016-10-13 Thread Thomas Monjalon
Hi, 2016-10-13 19:36, Tomasz Kulasek: > Added API for `rte_eth_tx_prep` > > uint16_t rte_eth_tx_prep(uint8_t port_id, uint16_t queue_id, > struct rte_mbuf **tx_pkts, uint16_t nb_pkts) > > Added fields to the `struct rte_eth_desc_lim`: > > uint16_t nb_seg_max; > /**<

[dpdk-dev] dpdk/vpp and cross-version migration for vhost

2016-10-13 Thread Michael S. Tsirkin
Hi! So it looks like we face a problem with cross-version migration when using vhost. It's not new but became more acute with the advent of vhost user. For users to be able to migrate between different versions of the hypervisor the interface exposed to guests by hypervisor must stay unchanged.

[dpdk-dev] [PATCH v3 12/12] net/virtio: add Tso support

2016-10-13 Thread Thomas Monjalon
2016-10-14 00:05, Yuanhan Liu: > On Thu, Oct 13, 2016 at 04:16:11PM +0200, Olivier Matz wrote: > > +/* When doing TSO, the IP length is not included in the pseudo header > > + * checksum of the packet given to the PMD, but for virtio it is > > + * expected. > > + */ > > +static void > >

[dpdk-dev] [PATCH] doc: ZUC PMD cannot be built as a shared library

2016-10-13 Thread Pablo de Lara
ZUC PMD cannot be built as a shared library, due to the fact that some assembly code in the underlying libsso library is not relocatable. This will be fixed in the future, but for the moment, it is added as a limitation of the PMD. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/zuc.rst

[dpdk-dev] [PATCH] doc: how to build KASUMI as shared library

2016-10-13 Thread Pablo de Lara
Libsso KASUMI library has to be built with specific parameters to make the KASUMI PMD be built as a shared library, so a note has been added in its documentation. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/kasumi.rst | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff

[dpdk-dev] [PATCH] doc: fix libcrypto title

2016-10-13 Thread Pablo de Lara
Libcrypto documentation was missing the equal signs ("="), in its title, so it was not present in the documentation generated. Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library") Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/libcrypto.rst | 1 + 1 file changed, 1

[dpdk-dev] [PATCH] doc: ZUC PMD cannot be built as a shared library

2016-10-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, October 13, 2016 12:35 PM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH] doc: ZUC PMD cannot be built as a shared library > > ZUC PMD cannot be built as a shared library, due to > the fact that

[dpdk-dev] [PATCH] doc: how to build KASUMI as shared library

2016-10-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, October 13, 2016 12:34 PM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH] doc: how to build KASUMI as shared library > > Libsso KASUMI library has to be built with specific > parameters to make the

[dpdk-dev] [PATCH] doc: fix libcrypto title

2016-10-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Thursday, October 13, 2016 12:34 PM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] doc: fix libcrypto title > > Libcrypto documentation was missing the

[dpdk-dev] [PATCH] Revert "bonding: use existing enslaved device queues"

2016-10-13 Thread Eric Kinzie
On Wed Oct 12 16:24:21 +0100 2016, Bruce Richardson wrote: > On Wed, Oct 12, 2016 at 04:24:54PM +0300, Ilya Maximets wrote: > > On 07.10.2016 05:02, Eric Kinzie wrote: > > > On Wed Sep 07 15:28:10 +0300 2016, Ilya Maximets wrote: > > >> This reverts commit 5b7bb2bda5519b7800f814df64d4e015282140e5.

[dpdk-dev] [PATCH v5 6/6] testpmd: use Tx preparation in csum engine

2016-10-13 Thread Tomasz Kulasek
Removed pseudo header calculation for udp/tcp/tso packets from application and used Tx preparation API for packet preparation and verification. Adding aditional step to the csum engine costs about 3-4% of performance drop, on my setup with ixgbe driver. It's caused mostly by the need of

[dpdk-dev] [PATCH v5 5/6] ixgbe: add Tx preparation

2016-10-13 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek --- drivers/net/ixgbe/ixgbe_ethdev.c |3 ++ drivers/net/ixgbe/ixgbe_ethdev.h |5 +++- drivers/net/ixgbe/ixgbe_rxtx.c | 58 +- drivers/net/ixgbe/ixgbe_rxtx.h |2 ++ 4 files changed, 66 insertions(+), 2

[dpdk-dev] [PATCH v5 4/6] i40e: add Tx preparation

2016-10-13 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek --- drivers/net/i40e/i40e_ethdev.c |3 ++ drivers/net/i40e/i40e_rxtx.c | 72 +++- drivers/net/i40e/i40e_rxtx.h |8 + 3 files changed, 82 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH v5 3/6] fm10k: add Tx preparation

2016-10-13 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek --- drivers/net/fm10k/fm10k.h|6 + drivers/net/fm10k/fm10k_ethdev.c |5 drivers/net/fm10k/fm10k_rxtx.c | 50 +- 3 files changed, 60 insertions(+), 1 deletion(-) diff --git a/drivers/net/fm10k/fm10k.h

[dpdk-dev] [PATCH v5 2/6] e1000: add Tx preparation

2016-10-13 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek --- drivers/net/e1000/e1000_ethdev.h | 11 drivers/net/e1000/em_ethdev.c|5 +++- drivers/net/e1000/em_rxtx.c | 48 ++- drivers/net/e1000/igb_ethdev.c |4 +++ drivers/net/e1000/igb_rxtx.c | 52

[dpdk-dev] [PATCH v5 1/6] ethdev: add Tx preparation

2016-10-13 Thread Tomasz Kulasek
Added API for `rte_eth_tx_prep` uint16_t rte_eth_tx_prep(uint8_t port_id, uint16_t queue_id, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) Added fields to the `struct rte_eth_desc_lim`: uint16_t nb_seg_max; /**< Max number of segments per whole packet. */

[dpdk-dev] [PATCH v5 0/6] add Tx preparation

2016-10-13 Thread Tomasz Kulasek
As discussed in that thread: http://dpdk.org/ml/archives/dev/2015-September/023603.html Different NIC models depending on HW offload requested might impose different requirements on packets to be TX-ed in terms of: - Max number of fragments per packet allowed - Max number of fragments per

[dpdk-dev] [PATCH] crypto/zuc: fix init function names

2016-10-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Thursday, October 13, 2016 10:57 AM > To: De Lara Guarch, Pablo; dev at dpdk.org > Cc: De Lara Guarch, Pablo > Subject: RE: [dpdk-dev] [PATCH] crypto/zuc: fix init function names > > > > > -Original Message- > > From: dev

[dpdk-dev] [PATCH] crypto/libcrypto: fix init function names

2016-10-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Thursday, October 13, 2016 10:56 AM > To: De Lara Guarch, Pablo; dev at dpdk.org > Cc: De Lara Guarch, Pablo > Subject: RE: [dpdk-dev] [PATCH] crypto/libcrypto: fix init function names > > > > > -Original Message- > > From: dev

[dpdk-dev] [PATCH v3] test_cryptodev_perf: IV and digest should be stored at a DMAeble address

2016-10-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Trahe, Fiona > Sent: Wednesday, October 12, 2016 11:26 AM > To: akhil.goyal at nxp.com; Kusztal, ArkadiuszX; Doherty, Declan > Cc: Griffin, John; Jain, Deepak K; dev at dpdk.org; Trahe, Fiona > Subject: Re:

[dpdk-dev] [PATCH v2] examples/l3fwd: em: use hw accelerated crc hash function for arm64

2016-10-13 Thread Jerin Jacob
On Fri, Oct 14, 2016 at 12:17:05AM +0530, Hemant Agrawal wrote: > if machine level CRC extension are available, offload the > hash to machine provide functions e.g. armv8-a CRC extensions > support it > > Signed-off-by: Hemant Agrawal > Reviewed-by: Jerin Jacob > --- >

[dpdk-dev] [PATCH v3 2/2] mempool: pktmbuf pool default fallback for mempool ops error

2016-10-13 Thread Hemant Agrawal
Hi Olivier, Any updates w.r.t this patch set? Regards Hemant On 9/22/2016 6:42 PM, Hemant Agrawal wrote: > Hi Olivier > > On 9/19/2016 7:27 PM, Olivier Matz wrote: >> Hi Hemant, >> >> On 09/16/2016 06:46 PM, Hemant Agrawal wrote: >>> In the rte_pktmbuf_pool_create, if the default external

[dpdk-dev] [PATCH] eal: avoid unnecessary conflicts over rte_config file

2016-10-13 Thread Thomas Monjalon
2016-10-13 09:20, John Ousterhout: > Hi Harry, > > But, given the existence of the --file-prefix option, isn't it already > unsafe for Collectd to check only for .rte_config? If it's important for > other programs to be able to find the config files, it seems to me that a > more robust mechanism

[dpdk-dev] ZUC PMD as shared library

2016-10-13 Thread De Lara Guarch, Pablo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, October 12, 2016 12:23 AM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org > Subject: Re: ZUC PMD as shared library > > 2016-10-12 02:23, De Lara Guarch, Pablo: > > Hi

[dpdk-dev] [PATCH v2] app/test: fix crypto mbuf pool size

2016-10-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jastrzebski, MichalX > K > Sent: Thursday, October 13, 2016 1:48 AM > To: Azarewicz, PiotrX T; Trahe, Fiona > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] app/test: fix crypto mbuf pool size > > >

[dpdk-dev] [PATCH] examples/l2fwd-crypto: fix verify with decrypt in chain

2016-10-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jastrzebski, MichalX K > Sent: Thursday, October 13, 2016 1:48 AM > To: Azarewicz, PiotrX T; De Lara Guarch, Pablo; Yang, GangX > Cc: dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix verify with > decrypt in chain > > >

[dpdk-dev] [PATCH 1/1] doc: fix errors in pdump doc

2016-10-13 Thread Thomas Monjalon
> > - Fix copy/paste error in description of how to capture both rx > > & tx traffic in a single pcap file > > - Replace duplicate word with what original author presumably > > intended, such that description now makes sense > > > > Signed-off-by: Mark Kavanagh > > Acked-by: John McNamara

[dpdk-dev] [PATCH 1/1] doc: clarify usage of testpmd mac fwd mode

2016-10-13 Thread Thomas Monjalon
> > Explain default testpmd behavior in mac fwd mode to remove > > amiguity/confusion regarding user's ability to specify Ethernet addresses. > > > > Signed-off-by: Mark Kavanagh > > Acked-by: John McNamara Applied, thanks

[dpdk-dev] [PATCH] crypto/zuc: fix init function names

2016-10-13 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, October 11, 2016 2:15 AM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] crypto/zuc: fix init function names > > All init/uninit function names

[dpdk-dev] [PATCH] crypto/libcrypto: fix init function names

2016-10-13 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, October 11, 2016 2:15 AM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] crypto/libcrypto: fix init function names > > All init/uninit function

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

2016-10-13 Thread Olivier Matz
Le 13 octobre 2016 17:29:35 CEST, Yuanhan Liu a ?crit : >On Thu, Oct 13, 2016 at 05:15:24PM +0200, Olivier MATZ wrote: >> >> >> On 10/13/2016 05:01 PM, Yuanhan Liu wrote: >> >On Thu, Oct 13, 2016 at 04:52:25PM +0200, Olivier MATZ wrote: >> >> >> >> >> >>On 10/13/2016 04:16 PM, Yuanhan Liu

[dpdk-dev] [PATCH] mempool: fix search of maximum contiguous pages

2016-10-13 Thread Wei Dai
paddr[i] + pg_sz always points to the start physical address of the 2nd page after pddr[i], so only up to 2 pages can be combinded to be used. With this revision, more than 2 pages can be used. Fixes: 84121f197187 ("mempool: store memory chunks in a list") Signed-off-by: Wei Dai ---

[dpdk-dev] [PATCH v2] app/testpmd: add support to configure 25G and 50G speeds

2016-10-13 Thread Thomas Monjalon
2016-10-12 16:26, Ajit Khaparde: > Support to configure 25G and 50G speeds is missing from testpmd. > This patch also updates the testpmd user guide accordingly. > > Signed-off-by: Ajit Khaparde > -- > v2: shorten lines > 80 character limit > --- Applied, thanks

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

2016-10-13 Thread Olivier MATZ
On 10/13/2016 05:01 PM, Yuanhan Liu wrote: > On Thu, Oct 13, 2016 at 04:52:25PM +0200, Olivier MATZ wrote: >> >> >> On 10/13/2016 04:16 PM, Yuanhan Liu wrote: >>> On Thu, Oct 13, 2016 at 04:02:49PM +0200, Olivier MATZ wrote: On 10/13/2016 10:18 AM, Yuanhan Liu wrote: > On Mon,

[dpdk-dev] [PATCH v2] app/testpmd: fix DCB config issue

2016-10-13 Thread Thomas Monjalon
> > An issue is found that DCB cannot be configured on ixgbe NICs. It's said the > > TX queue number is not right. > > On ixgbe the max TX queue number is not fixed, it depends on the multi- > > queue mode. > > > > This patch adds the device configuration before getting info in the DCB > >

[dpdk-dev] [PATCH] mempool: fix search of maximum contiguous pages

2016-10-13 Thread Olivier MATZ
Hi Wei, On 10/13/2016 02:31 PM, Ananyev, Konstantin wrote: > >> > diff --git a/lib/librte_mempool/rte_mempool.c > b/lib/librte_mempool/rte_mempool.c > index 71017e1..e3e254a 100644 > --- a/lib/librte_mempool/rte_mempool.c > +++ b/lib/librte_mempool/rte_mempool.c > @@

[dpdk-dev] [PATCH v9] drivers/net:new PMD using tun/tap host interface

2016-10-13 Thread Keith Wiles
The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces on the local host. The PMD allows for DPDK and the host to communicate using a raw device interface on the host and in the DPDK application. The device created is a Tap device with a L2 packet header. v9 - Fix up the docs to use

[dpdk-dev] [PATCH] eal: avoid unnecessary conflicts over rte_config file

2016-10-13 Thread Ananyev, Konstantin
> > It's true that users can patch around this problem (and I started off doing > just that), but why impose this inconvenience on users when DPDK > can just "do the right thing" to begin with? For example, it took me several > hours to figure out why the problem was occurring and then to >

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

2016-10-13 Thread Olivier MATZ
On 10/13/2016 04:16 PM, Yuanhan Liu wrote: > On Thu, Oct 13, 2016 at 04:02:49PM +0200, Olivier MATZ wrote: >> >> >> On 10/13/2016 10:18 AM, Yuanhan Liu wrote: >>> On Mon, Oct 03, 2016 at 11:00:23AM +0200, Olivier Matz wrote: +/* When doing TSO, the IP length is not included in the pseudo

[dpdk-dev] 17.02 Roadmap

2016-10-13 Thread Thomas Monjalon
2016-10-13 15:18, Hunt, David: > Hi Thomas, > > On 10/10/2016 9:42 PM, Thomas Monjalon wrote: > > 2016-10-10 16:13, O'Driscoll, Tim: > >> Packet Distributor Enhancements: Enhancements will be made to the Packet > >> Distributor library to improve performance: > >> 1. Introduce burst

[dpdk-dev] [PATCH v2 10/12] virtio: add Tx checksum offload support

2016-10-13 Thread Yuanhan Liu
On Mon, Oct 03, 2016 at 11:00:21AM +0200, Olivier Matz wrote: > + /* Checksum Offload */ > + switch (cookie->ol_flags & PKT_TX_L4_MASK) { > + case PKT_TX_UDP_CKSUM: > + hdr->csum_start = cookie->l2_len + cookie->l3_len; > + hdr->csum_offset = 6; > +

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

2016-10-13 Thread Stephen Hemminger
On Thu, 13 Oct 2016 16:18:39 +0800 Yuanhan Liu wrote: > On Mon, Oct 03, 2016 at 11:00:23AM +0200, Olivier Matz wrote: > > +/* When doing TSO, the IP length is not included in the pseudo header > > + * checksum of the packet given to the PMD, but for virtio it is > > + * expected. > > + */ > >

[dpdk-dev] [PATCH v8] drivers/net:new PMD using tun/tap host interface

2016-10-13 Thread Mcnamara, John
Hi, Some doc comments below. Apologies, for the late review, I didn't see the docs inline. > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Keith Wiles > Sent: Thursday, October 13, 2016 5:11 PM > To: dev at dpdk.org > Cc: pmatilai at redhat.com;

[dpdk-dev] [PATCH] eal: avoid unnecessary conflicts over rte_config file

2016-10-13 Thread Van Haaren, Harry
Hi, > From: John Ousterhout [mailto:ouster at cs.stanford.edu] > But, given the existence of the --file-prefix option, isn't it already unsafe > for Collectd to check only for .rte_config? If it's important for other > programs to be able to find the config files, it seems to me that a more

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

2016-10-13 Thread Yuanhan Liu
On Mon, Oct 03, 2016 at 11:00:23AM +0200, Olivier Matz wrote: > +/* When doing TSO, the IP length is not included in the pseudo header > + * checksum of the packet given to the PMD, but for virtio it is > + * expected. > + */ > +static void > +virtio_tso_fix_cksum(struct rte_mbuf *m) > +{ > +

[dpdk-dev] [PATCH v3 12/12] net/virtio: add Tso support

2016-10-13 Thread Olivier Matz
Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 6 ++ drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_rxtx.c | 133 +++-- 3 files changed, 136 insertions(+), 5 deletions(-) diff --git

[dpdk-dev] [PATCH v3 11/12] net/virtio: add Lro support

2016-10-13 Thread Olivier Matz
Signed-off-by: Olivier Matz Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 15 ++- drivers/net/virtio/virtio_ethdev.h | 9 - drivers/net/virtio/virtio_rxtx.c | 25 - 3 files changed, 38 insertions(+), 11 deletions(-) diff

[dpdk-dev] [PATCH v3 10/12] net/virtio: add Tx checksum offload support

2016-10-13 Thread Olivier Matz
Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 7 drivers/net/virtio/virtio_ethdev.h | 1 + drivers/net/virtio/virtio_rxtx.c | 73 +++--- 3 files changed, 61 insertions(+), 20 deletions(-) diff --git

[dpdk-dev] [PATCH v3 09/12] net/virtio: add Rx checksum offload support

2016-10-13 Thread Olivier Matz
Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 21 ++ drivers/net/virtio/virtio_ethdev.h | 2 +- drivers/net/virtio/virtio_rxtx.c | 79 ++ drivers/net/virtio/virtqueue.h | 1 + 4 files changed, 95 insertions(+), 8

[dpdk-dev] [PATCH v3 08/12] app/testpmd: display lro segment size

2016-10-13 Thread Olivier Matz
In csumonly engine, display the value of LRO segment if the LRO flag is set. Signed-off-by: Olivier Matz Reviewed-by: Maxime Coquelin --- app/test-pmd/csumonly.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index da15185..57e6ae2

[dpdk-dev] [PATCH v3 07/12] mbuf: new flag for LRO

2016-10-13 Thread Olivier Matz
When receiving coalesced packets in virtio, the original size of the segments is provided. This is a useful information because it allows to resegment with the same size. Add a RX new flag in mbuf, that can be set when packets are coalesced by a hardware or virtual driver when the m->tso_segsz

[dpdk-dev] [PATCH v3 06/12] app/testpmd: adapt checksum stats in csum engine

2016-10-13 Thread Olivier Matz
Reviewed-by: Maxime Coquelin --- app/test-pmd/csumonly.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 27d0f08..da15185 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -697,8 +697,10 @@

[dpdk-dev] [PATCH v3 05/12] mbuf: add new Rx checksum mbuf flags

2016-10-13 Thread Olivier Matz
Following discussions in [1] and [2], introduce a new bit to describe the Rx checksum status in mbuf. Before this patch, only one flag was available: PKT_RX_L4_CKSUM_BAD: L4 cksum of RX pkt. is not OK. And same for L3: PKT_RX_IP_CKSUM_BAD: IP cksum of RX pkt. is not OK. This had 2 issues: -

[dpdk-dev] [PATCH v3 04/12] net: add function to calculate a checksum in a mbuf

2016-10-13 Thread Olivier Matz
This function can be used to calculate the checksum of data embedded in mbuf, that can be composed of several segments. This function will be used by the virtio pmd in next commits to calculate the checksum in software in case the protocol is not recognized. Signed-off-by: Olivier Matz ---

[dpdk-dev] [PATCH v3 03/12] net/virtio: reinitialize the device in configure callback

2016-10-13 Thread Olivier Matz
Add the ability to reset the virtio device in the configure callback if the features flag changed since previous reset. This will be possible with the introduction of offload support in next commits. Signed-off-by: Olivier Matz Reviewed-by: Maxime Coquelin ---

[dpdk-dev] [PATCH v3 02/12] net/virtio: setup and start cq in configure callback

2016-10-13 Thread Olivier Matz
Move the configuration of control queue in the configure callback. This is needed by next commit, which introduces the reinitialization of the device in the configure callback to change the feature flags. Therefore, the control queue will have to be restarted at the same place. As

[dpdk-dev] [PATCH v3 01/12] net/virtio: move device initialization in a function

2016-10-13 Thread Olivier Matz
Move all code related to device initialization in a new function virtio_init_device(). This commit brings no functional change, it prepares the next commits that will add the offload support. For that, it will be needed to reinitialize the device from ethdev->configure(), using this new function.

[dpdk-dev] [PATCH v3 00/12] net/virtio: add offload support

2016-10-13 Thread Olivier Matz
This patchset, targetted for 16.11, introduces the support of rx and tx offload in virtio pmd. To achieve this, some new mbuf flags must be introduced, as discussed in [1]. It applies on master + a patch fixing the testpmd csum engine: http://dpdk.org/dev/patchwork/patch/16538/ The new mbuf

[dpdk-dev] [PATCH] doc: add note on primary process dependency

2016-10-13 Thread Reshma Pattan
The note i.e. "The dpdk-pdump tool can only be used in conjunction with a primary process which has the packet capture framework initialized already" is added to doc/guides/sample_app_ug/pdump.rst to facilitate easy understanding on the usage of the tool. Suggested-by: Jianfeng Tan

[dpdk-dev] [PATCH v2] app/testpmd: fix RSS-hash-key size

2016-10-13 Thread Thomas Monjalon
> > RSS hash-key-size is retrieved from device configuration instead of > > using a fixed size of 40 bytes. > > > > Fixes: f79959ea1504 ("app/testpmd: allow to configure RSS hash key") > > > > Signed-off-by: Mohammad Abdul Awal > > Acked-by: Konstantin Ananyev Applied, thanks

[dpdk-dev] [PATCH] eal: avoid unnecessary conflicts over rte_config file

2016-10-13 Thread Van Haaren, Harry
Hi John, > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John Ousterhout > Subject: Re: [dpdk-dev] [PATCH] eal: avoid unnecessary conflicts over > rte_config file > For example, it took me several hours > to figure out why the problem was occurring and then to hunt down the >

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

2016-10-13 Thread Olivier MATZ
On 10/13/2016 10:18 AM, Yuanhan Liu wrote: > On Mon, Oct 03, 2016 at 11:00:23AM +0200, Olivier Matz wrote: >> +/* When doing TSO, the IP length is not included in the pseudo header >> + * checksum of the packet given to the PMD, but for virtio it is >> + * expected. >> + */ >> +static void >>

[dpdk-dev] [PATCH] testpmd: fix tso with csum engine

2016-10-13 Thread Thomas Monjalon
2016-10-13 15:40, Olivier Matz: > The commit that disabled tso for small packets was broken during the > rebase. The problem is the IP checksum is not calculated in software if: > - TX IP checksum is disabled > - TSO is enabled > - the current packet is smaller than tso segment size > > When

[dpdk-dev] [PATCH v2 10/12] virtio: add Tx checksum offload support

2016-10-13 Thread Olivier MATZ
On 10/13/2016 10:38 AM, Yuanhan Liu wrote: > On Mon, Oct 03, 2016 at 11:00:21AM +0200, Olivier Matz wrote: >> +/* Checksum Offload */ >> +switch (cookie->ol_flags & PKT_TX_L4_MASK) { >> +case PKT_TX_UDP_CKSUM: >> +hdr->csum_start = cookie->l2_len + cookie->l3_len; >> +

[dpdk-dev] [PATCH v2 03/12] virtio: reinitialize the device in configure callback

2016-10-13 Thread Olivier MATZ
On 10/13/2016 09:54 AM, Yuanhan Liu wrote: > On Wed, Oct 12, 2016 at 06:01:25PM +0200, Olivier MATZ wrote: >> Hello Yuanhan, >> >> On 10/12/2016 04:41 PM, Yuanhan Liu wrote: >>> On Mon, Oct 03, 2016 at 11:00:14AM +0200, Olivier Matz wrote: @@ -1344,6 +1347,7 @@ virtio_dev_configure(struct

[dpdk-dev] [PATCH 2/2] app/testpmd: use consistent vdev names

2016-10-13 Thread Thomas Monjalon
2016-10-07 02:27, De Lara Guarch, Pablo: > > > -Original Message- > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Thursday, October 06, 2016 3:34 AM > > To: De Lara Guarch, Pablo > > Cc: dev at dpdk.org > > Subject: [PATCH 2/2] app/testpmd: use consistent vdev

[dpdk-dev] [PATCH v2 03/12] virtio: reinitialize the device in configure callback

2016-10-13 Thread Yuanhan Liu
On Wed, Oct 12, 2016 at 06:01:25PM +0200, Olivier MATZ wrote: > Hello Yuanhan, > > On 10/12/2016 04:41 PM, Yuanhan Liu wrote: > >On Mon, Oct 03, 2016 at 11:00:14AM +0200, Olivier Matz wrote: > >>@@ -1344,6 +1347,7 @@ virtio_dev_configure(struct rte_eth_dev *dev) > >> { > >>const struct

[dpdk-dev] [PATCH] app/test: reduce lpm6 test case size

2016-10-13 Thread Thomas Monjalon
2016-09-30 02:11, Wei Dai: > copy app/test/test_lpm6_routes.h to app/test/test_lpm6_data.h . > and then delete app/test/test_lpm6_routes.h and clear the > large_ips_table[ ] to make LPM6 test case size much smaller than > before. Also add codes in app/test/test_lpm6_data.h to generate test > data

[dpdk-dev] [PATCH v6] drivers/net:new PMD using tun/tap host interface

2016-10-13 Thread Ferruh Yigit
On 10/12/2016 9:54 PM, Keith Wiles wrote: > The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces > on the local host. The PMD allows for DPDK and the host to > communicate using a raw device interface on the host and in > the DPDK application. The device created is a Tap device with > a

[dpdk-dev] [PATCH] testpmd: fix tso with csum engine

2016-10-13 Thread Olivier Matz
The commit that disabled tso for small packets was broken during the rebase. The problem is the IP checksum is not calculated in software if: - TX IP checksum is disabled - TSO is enabled - the current packet is smaller than tso segment size When checking if the PKT_TX_IP_CKSUM flag should be set

[dpdk-dev] [PATCH v2] app/test: remove large lpm test head file

2016-10-13 Thread Thomas Monjalon
2016-09-28 01:38, Wei Dai: > remove the large file app/test/test_lpm_routes.h and add codes to > auto-generate similar large route rule talbe which keeps same depth > and IP class distribution as previous one in test_lpm_routes.h . > With the rule table auto-generated at run time, the performance

[dpdk-dev] 17.02 Roadmap

2016-10-13 Thread Hunt, David
Hi Thomas, On 10/10/2016 9:42 PM, Thomas Monjalon wrote: > Thanks Tim for the interesting inputs. > Some of them may require a dedicated thread to continue the discussion > based on some preliminary specifications or drafts. > > 2016-10-10 16:13, O'Driscoll, Tim: >> Packet Distributor

[dpdk-dev] [PATCH] test: fix hash multiwriter test

2016-10-13 Thread Thomas Monjalon
2016-10-06 23:34, Pablo de Lara: > Hash multiwriter test consists of two subtests. > If the any of the subtests fails, the overall test should fail, > but the overall test only passed if the second subtest passed, > because the return of the first subtest was being overwritten. > > Fixes:

[dpdk-dev] [PATCH v9 0/2] add API's for VF management

2016-10-13 Thread Bruce Richardson
On Wed, Oct 12, 2016 at 06:54:10PM +0100, Bernard Iremonger wrote: > This patchset contains new DPDK API's for use > with the Virtual Function Daemon (VFD). > > The need to configure and manage VF's on a NIC has grown to the > point where a DPDK based tool, VFD, has been developed to do this. >

[dpdk-dev] [PATCH] net/ring: fix param string info

2016-10-13 Thread Bruce Richardson
On Thu, Oct 13, 2016 at 11:22:25AM +0100, Bruce Richardson wrote: > On Wed, Aug 31, 2016 at 05:53:51PM +0100, Ferruh Yigit wrote: > > Fixes: 65eca099f405 ("drivers: split parameters infos in multiple lines") > > > > Signed-off-by: Ferruh Yigit > > --- > Acked-by: Bruce Richardson Applied to

[dpdk-dev] [PATCH] net/ring: fix ring eth dev creation via devargs

2016-10-13 Thread Bruce Richardson
On Thu, Oct 13, 2016 at 11:21:57AM +0100, Bruce Richardson wrote: > On Wed, Aug 31, 2016 at 05:51:11PM +0100, Ferruh Yigit wrote: > > Using nodeaction devarg lets creating multiple ring eth devices: > > "eth_ring0,nodeaction=R0:0:CREATE,nodeaction=R1:0:CREATE" > > > > Trying to create all devices

[dpdk-dev] [PATCH v3 1/3] lib/librte_port: enable file descriptor port support

2016-10-13 Thread Thomas Monjalon
2016-10-13 10:17, Jasvinder Singh: > This patch adds File Descriptor(FD) port type (e.g. TAP port) to the > packet framework library that allows interface with the kernel network > stack. The FD port APIs are defined that allow port creation, writing > and reading packet from the kernel interface.

[dpdk-dev] [PATCH] net/enic: remove assert which causes compile error

2016-10-13 Thread Bruce Richardson
On Thu, Oct 13, 2016 at 02:22:16PM +0100, Bruce Richardson wrote: > On Wed, Oct 12, 2016 at 11:09:35AM -0700, John Daley wrote: > > Remove an RTE_ASSERT which will not compile if enabled and is not needed. > > > > Fixes: a1f7c7b3b5b2 ("net/enic: extend fdir support for 1300 series > > adapters")

[dpdk-dev] [PATCH 3/3] net/mlx5: implementation of Rx packet timestamping support

2016-10-13 Thread Oleg Kuporosov
Accurate RX timestaping is minimal requirement for several important financial services industry requirement for several applications like packet capture. Support of periodic time synchronization with system time and adjusting clock deviation was also added. We assume the system is synchronized

[dpdk-dev] [PATCH 2/3] app/testpmd: enabled control for packet timestamps

2016-10-13 Thread Oleg Kuporosov
Implemented two methods of control - by --enable-timestamps CL testpmd application we can enable timestamping for all ports; - in interactive mode port config timestamps on|off is able to configure timestamping per specific port. The control doesn't interact with IEEE1588 PTP implementation

[dpdk-dev] [PATCH 1/3] mbuf: embedding timestamp into the packet

2016-10-13 Thread Oleg Kuporosov
The hard requirement of financial services industry is accurate timestamping aligned with the packet itself. This patch is to satisfy this requirement: - include uint64_t timestamp field into rte_mbuf with minimal impact to throughput/latency. Keep it just simple uint64_t in ns (more than 580

[dpdk-dev] [PATCH 0/3] Improvements in packet timestamps support

2016-10-13 Thread Oleg Kuporosov
Hello DPDK Developers, Financial Services Industry which is pretty eager for several DPDK features especially low latency while high throughput. The major issue so far for increasing DPDK adoption there is requirement for several applications (capturers, some trading algorithms) to support of

[dpdk-dev] [PATCH] net/enic: remove assert which causes compile error

2016-10-13 Thread Bruce Richardson
On Wed, Oct 12, 2016 at 11:09:35AM -0700, John Daley wrote: > Remove an RTE_ASSERT which will not compile if enabled and is not needed. > > Fixes: a1f7c7b3b5b2 ("net/enic: extend fdir support for 1300 series adapters") > > Signed-off-by: John Daley > --- > Would have been nice if I caught this

[dpdk-dev] [dpdk-stable] [PATCH v6 1/6] vhost: fix windows vm hang

2016-10-13 Thread Yuanhan Liu
On Mon, Sep 19, 2016 at 10:00:12PM -0400, Zhihong Wang wrote: > This patch fixes a Windows VM compatibility issue in DPDK 16.07 vhost code > which causes the guest to hang once any packets are enqueued when mrg_rxbuf > is turned on by setting the right id and len in the used ring. > > As defined

[dpdk-dev] [PATCH 2/2] net/i40e: fix VF bonded device link down

2016-10-13 Thread Qiming Yang
Originally, using DPDK as host driver, when VF bonded device uses I40E_VIRTCHNL_OP_GET_LINK_STAT to query PF the link status, VF will wait for the interrupt from PF to get this link status. PF uses interrupt which already exists to communication with VF. These two kinds of interrupt will be

[dpdk-dev] [PATCH 1/2] net/i40e: fix link status change interrupt

2016-10-13 Thread Qiming Yang
Previously, link status interrupt in i40e is achieved by checking LINK_STAT_CHANGE_MASK in PFINT_ICR0 register which is provided only for diagnostic use. Instead, drivers need to get the link status change notification by using LSE (Link Status Event). This patch enables LSE and calls LSC

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-13 Thread Yuanhan Liu
On Wed, Oct 12, 2016 at 12:22:08PM +, Wang, Zhihong wrote: > > > >> > 3. How many percentage of drop are you seeing? > > > The testing result: > > > size (bytes) improvement (%) > > > 64 3.92 > > > 128 11.51 > > > 256 24.16 > > > 512

[dpdk-dev] [PATCH] app/test: add crypto continual tests

2016-10-13 Thread Arek Kusztal
This commit adds continual performace tests to Intel(R) QuickAssist Technology tests suite. Performance tests are run continually with some number of repeating loops. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_perf.c | 133 - 1 file changed,

[dpdk-dev] [PATCH] mempool: fix search of maximum contiguous pages

2016-10-13 Thread Ananyev, Konstantin
> > > > > diff --git a/lib/librte_mempool/rte_mempool.c > > > > b/lib/librte_mempool/rte_mempool.c > > > > index 71017e1..e3e254a 100644 > > > > --- a/lib/librte_mempool/rte_mempool.c > > > > +++ b/lib/librte_mempool/rte_mempool.c > > > > @@ -426,9 +426,12 @@ rte_mempool_populate_phys_tab(struct

[dpdk-dev] [PATCH v1 0/4] Generalize PCI specific EAL function/structures

2016-10-13 Thread Shreyansh Jain
Hi David, On Friday 30 September 2016 09:01 PM, David Marchand wrote: > On Tue, Sep 27, 2016 at 4:12 PM, Shreyansh Jain > wrote: >> (I rebased these over HEAD 7b3c4f3) >> >> These patches were initially part of Jan's original series on SoC >> Framework ([1],[2]). An update to that series,

[dpdk-dev] [PATCH] net/i40e: Fix a typo in a comment (Fortville instead of IXGBE).

2016-10-13 Thread Ferruh Yigit
On 9/25/2016 11:03 AM, Wu, Jingjing wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Rami Rosen >> Sent: Monday, August 1, 2016 12:52 PM >> To: dev at dpdk.org >> Cc: Rosen, Rami >> Subject: [dpdk-dev] [PATCH] net/i40e: Fix a typo in a comment

[dpdk-dev] [PATCH v2 2/3] app/testpmd: fix wrong flow director mask

2016-10-13 Thread Ferruh Yigit
Hi Wenzhuo, On 10/12/2016 7:24 AM, Wenzhuo Lu wrote: > In mac-vlan mode, MAC address mask is not supported by HW. > The MAC address mask should not be set in mac-vlan mode. > Remove this parameter from the CLI. Remove MAC address > from mask print too. > > Fixes: 53b2bb9b7ea7 ("app/testpmd: new

[dpdk-dev] [PATCH 1/5] i40e: extract non-x86 specific code from vector driver

2016-10-13 Thread Zhang, Qi Z
Hi Jianbo > -Original Message- > From: Jianbo Liu [mailto:jianbo.liu at linaro.org] > Sent: Thursday, October 13, 2016 11:00 AM > To: Zhang, Qi Z > Cc: Zhang, Helin ; Wu, Jingjing > ; jerin.jacob at caviumnetworks.com; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/5] i40e: extract

  1   2   >