Re: [dpdk-dev] [PATCH v3 02/12] eal/bus: introduce bus abstraction

2016-12-20 Thread Shreyansh Jain
On Tuesday 20 December 2016 10:41 PM, Stephen Hemminger wrote: On Tue, 20 Dec 2016 14:17:14 +0100 Jan Blunck wrote: On Fri, Dec 16, 2016 at 2:10 PM, Shreyansh Jain wrote: This patch introduces the rte_bus abstraction for devices and drivers in EAL framework. The model is: - One or more buse

[dpdk-dev] [PATCH v6 23/25] app/testpmd: handle i40e in VF VLAN filter command

2016-12-20 Thread Wenzhuo Lu
modify set_vf_rx_vlan function to handle the i40e PMD. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 41 ++--- app/test-pmd/config.c | 13 - app/test-pmd/testpmd.h | 2 -- 3 files changed, 34 insertions(+), 22 deletions(-) diff -

[dpdk-dev] [PATCH v6 25/25] net/i40e: set/clear VF stats from PF

2016-12-20 Thread Wenzhuo Lu
This patch add support to get/clear VF statistics from PF side. Two APIs are added: rte_pmd_i40e_get_vf_stats. rte_pmd_i40e_reset_vf_stats. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c| 81 +++ drivers/net/i40e/rte_pmd_i40e.h | 41 +

[dpdk-dev] [PATCH v6 22/25] app/testpmd: add command to test VF VLAN tag on i40e

2016-12-20 Thread Wenzhuo Lu
command is: set vf vlan tag port_id vf_id on|off Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 98 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++ 2 files changed, 105 insertions(+) diff --git a/app/test-pmd/cmdline.c b/ap

[dpdk-dev] [PATCH v6 24/25] net/i40e: enhance in sanity check of MAC

2016-12-20 Thread Wenzhuo Lu
When VF sends request to add a new MAC address, PF host will check if it's a non-zero or unicast address, or it will return with error. In fact, VF still can set multicast address. This change remove to check if it's a unicast address. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_p

[dpdk-dev] [PATCH v6 20/25] app/testpmd: use multicast promiscuous mode on i40e

2016-12-20 Thread Wenzhuo Lu
Add testpmd CLI to set VF multicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 93 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 102 insertions(+) diff --git a/app/test-pmd/cmdline.

[dpdk-dev] [PATCH v6 21/25] app/testpmd: add command to test VF broadcast mode on i40e

2016-12-20 Thread Wenzhuo Lu
Add command to call rte_pmd_i40e_set_vf_broadcast. Add set vf broadcast in testpmd_funcs.rst file. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 92 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++ 2 files changed, 99 insert

[dpdk-dev] [PATCH v6 19/25] app/testpmd: use unicast promiscuous mode on i40e

2016-12-20 Thread Wenzhuo Lu
Add testpmd CLI to set VF unicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 93 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 102 insertions(+) diff --git a/app/test-pmd/cmdline.c

[dpdk-dev] [PATCH v6 17/25] net/i40e: set VF VLAN filter from PF

2016-12-20 Thread Wenzhuo Lu
add rte_pmd_i40e_set_vf_vlan_filter API. User can call the API on PF to enable/disable a set of VF's VLAN filters. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 52 +++ drivers/net/i40e/rte_pmd_i40e.h | 22 + dr

[dpdk-dev] [PATCH v6 18/25] app/testpmd: use VFD APIs on i40e

2016-12-20 Thread Wenzhuo Lu
The new VF Daemon (VFD) APIs is implemented on i40e. Change testpmd code to use them, including VF MAC anti-spoofing, VF VLAN anti-spoofing, TX loopback, VF VLAN strip, VF VLAN insert. Signed-off-by: Wenzhuo Lu Signed-off-by: Chen Jing D(Mark) Signed-off-by: Bernard Iremonger --- app/test-pmd/

[dpdk-dev] [PATCH v6 15/25] net/i40e: set VF broadcast mode from PF

2016-12-20 Thread Wenzhuo Lu
Support enabling/disabling VF broadcast mode from PF. User can call the API on PF to enable/disable a specific VF's broadcast mode. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 47 +++ drivers/net/i40e/rte_pmd_i40e.h | 19

[dpdk-dev] [PATCH v6 16/25] net/i40e: set VF VLAN tag from PF

2016-12-20 Thread Wenzhuo Lu
Add rte_pmd_i40e_set_vf_vlan_tag API. User can call the API on PF to enable/disable a specific VF's VLAN tag. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 59 +++ drivers/net/i40e/rte_pmd_i40e.h | 18 ++ drivers/ne

[dpdk-dev] [PATCH v6 14/25] net/i40e: set VF VLAN insertion from PF

2016-12-20 Thread Wenzhuo Lu
Support inserting VF VLAN id from PF. User can call the API on PF to insert a VLAN id to a specific VF. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 53 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 +++ drivers/net/i40

[dpdk-dev] [PATCH v6 13/25] net/i40e: set VF VLAN strip from PF

2016-12-20 Thread Wenzhuo Lu
Add a function to configure vlan strip enable/disable for specific SRIOV VF device. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_ethdev.c| 26 ++ drivers/net/i40e/rte_pmd_i40e.h | 19 +++ drivers/net/i40e/rte_pmd_i40e_ve

[dpdk-dev] [PATCH v6 12/25] net/i40e: fix VF MAC address assignment

2016-12-20 Thread Wenzhuo Lu
If PF sets vf->mac_addr, in VF initialization hw->mac.addr will be set to that same value. It is possible to check if PF set a MAC address or not through the hw->mac.addr variable. hw->mac.addr set by i40e_vf_parse_hw_config(), call stack is: In PF side i40e_pf_host_process_cmd_get_vf_resources()

[dpdk-dev] [PATCH v6 09/25] net/i40e: fix VF reset flow

2016-12-20 Thread Wenzhuo Lu
Add missing step during VF reset: PF should set I40E_VFGEN_RSTAT to ACTIVE at end of the VF reset operation or VF driver may not able to detect that reset is already completed. This patch also remove the unnecessary enum for vfr state. Fixes: 4861cde46116 ("i40e: new poll mode driver") CC: sta...

[dpdk-dev] [PATCH v6 08/25] net/i40e: enable VF MTU change

2016-12-20 Thread Wenzhuo Lu
This patch implement mtu_set ops for i40e VF. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev_vf.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 12da0ec..bce01d0 100644

[dpdk-dev] [PATCH v6 10/25] net/i40e: set VF MAC from PF support

2016-12-20 Thread Wenzhuo Lu
Support setting VF MAC address from PF. User can call the API on PF to set a specific VF's MAC address. This will remove all existing MAC filters. Signed-off-by: Ferruh Yigit --- drivers/net/i40e/i40e_ethdev.c| 42 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v6 11/25] net/i40e: set VF MAC from VF support

2016-12-20 Thread Wenzhuo Lu
Support changing VF default MAC address. This function is not supported if PF set the MAC address for the PF. Signed-off-by: Ferruh Yigit --- drivers/net/i40e/i40e_ethdev.h| 4 +++- drivers/net/i40e/i40e_ethdev_vf.c | 49 +-- 2 files changed, 45 insertion

[dpdk-dev] [PATCH v6 06/25] net/i40e: set VF unicast promisc mode from PF

2016-12-20 Thread Wenzhuo Lu
Support enabling/disabling VF unicast promiscuous mode from PF. User can call the API on PF to enable/disable a specific VF's unicast promiscuous mode. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 39 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v6 05/25] net/i40e: set Tx loopback from PF

2016-12-20 Thread Wenzhuo Lu
Support enabling/disabling TX loopback from PF. User can call the API on PF to enable/disable TX loopback for all the PF and VFs. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 222 ++ drivers/net/i40e/rte_pmd_i40e.h | 16 +++ dri

[dpdk-dev] [PATCH v6 07/25] net/i40e: set VF multicast promisc mode from PF

2016-12-20 Thread Wenzhuo Lu
Support enabling/disabling VF multicast promiscuous mode from PF. User can call the API on PF to enable/disable a specific VF's multicast promiscuous mode. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 39 +++ drivers/net/i40e/rte_pmd_i40e.

[dpdk-dev] [PATCH v6 04/25] net/i40e: set VF VLAN anti-spoofing from PF

2016-12-20 Thread Wenzhuo Lu
Support enabling/disabling VF VLAN anti-spoofing from PF. User can call the API on PF to enable/disable a specific VF's VLAN anti-spoofing. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 116 +- drivers/net/i40e/i40e_ethdev.h|

[dpdk-dev] [PATCH v6 01/25] net/i40e: support link status notification

2016-12-20 Thread Wenzhuo Lu
Add an API to expose the ability, that PF can notify VF when link status changes, to APP. So if PF APP doesn't want to enable interruption but check link status by itself, PF APP can let VF know link status changed. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/Makefile | 4 ++-

[dpdk-dev] [PATCH v6 03/25] net/i40e: set VF MAC anti-spoofing from PF

2016-12-20 Thread Wenzhuo Lu
Support enabling/disabling VF MAC anti-spoofing from PF. User can call the API on PF to enable/disable a specific VF's MAC anti-spoofing. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 63 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 +

[dpdk-dev] [PATCH v6 00/25] Support VFD on i40e

2016-12-20 Thread Wenzhuo Lu
1, VF Daemon (VFD) VFD is an idea to control all the VFs from PF. As we need to support the scenario kernel PF + DPDK VF, DPDK follows the interface between kernel PF + kernel VF. We don't want to introduce too many new messages between PF and VF. So this patch set adds some new APIs to control VFs

[dpdk-dev] [PATCH v6 02/25] net/i40e: add callback to user on VF to PF mbox msg

2016-12-20 Thread Wenzhuo Lu
The callback asks the user application if it is allowed to perform the mailbox messages. If the return value from user is RTE_PMD_I40E_MB_EVENT_PROCEED then continue. If ACK or NACK, do nothing and send not_supported to VF. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_pf.c | 230 +++

Re: [dpdk-dev] [PATCH] i40e jumbo frames fix

2016-12-20 Thread Zhang, Helin
> From: Gregory Etelson [mailto:greg...@weka.io] > Sent: Wednesday, December 21, 2016 1:16 PM > To: dev > Cc: Wu, Jingjing; Zhang, Helin > Subject: [PATCH] i40e jumbo frames fix The format of the title is not corect as requried by DPDK community. Please refer to other patches. > > Allow i40e PF an

Re: [dpdk-dev] [PATCH v2 06/25] app/testpmd: implement basic support for rte_flow

2016-12-20 Thread Xing, Beilei
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, December 20, 2016 5:38 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Pei, Yulong > Subject: Re: [dpdk-dev] [PATCH v2 06/25] app/testpmd: implement basic > support for rte_flow > > On Tue, Dec

[dpdk-dev] [PATCH] i40e jumbo frames fix

2016-12-20 Thread Gregory Etelson
Allow i40e PF and VF ports to operate with Ethernet jumbo frames Signed-off-by: Gregory Etelson --- drivers/net/i40e/i40e_ethdev_vf.c |2 +- drivers/net/i40e/i40e_rxtx.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/dri

Re: [dpdk-dev] [PATCH 10/24] ethdev: parse ethertype filter

2016-12-20 Thread Xing, Beilei
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, December 21, 2016 2:12 AM > To: Xing, Beilei ; Wu, Jingjing > ; Zhang, Helin > Cc: dev@dpdk.org; Lu, Wenzhuo ; Adrien Mazarguil > > Subject: Re: [dpdk-dev] [PATCH 10/24] ethdev: parse ethertype filter > > On 12/2/2

[dpdk-dev] [PATCH] net/fm10k/base: add a break statement

2016-12-20 Thread Chenghu Yao
In function fm10k_mbx_create_reply(), the last case branch has no break statement. Signed-off-by: Chenghu Yao --- drivers/net/fm10k/base/fm10k_mbx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/fm10k/base/fm10k_mbx.c b/drivers/net/fm10k/base/fm10k_mbx.c index 2e70434..45d6ddb

Re: [dpdk-dev] [PATCH v3] app/testpmd: supported offload capabilities query

2016-12-20 Thread Yuanhan Liu
On Wed, Dec 21, 2016 at 10:20:26AM +0800, Qiming Yang wrote: > Add two new commands "show port capa " and "show I think 'cap' is a more well-known shortening for capability than "capa"? --yliu

[dpdk-dev] [PATCH v3] app/testpmd: supported offload capabilities query

2016-12-20 Thread Qiming Yang
Add two new commands "show port capa " and "show port capa all"to diaplay what offload capabilities supported in ports. It will not only display all the capabilities of the port, but also the enabling condition for each capability in the running time. Signed-off-by: Qiming Yang --- v2 changes: *

[dpdk-dev] [PATCH v2] net/ixgbe/base: clear redundant macro define

2016-12-20 Thread Chenghu Yao
In head file "ixgbe_mbx.h", macro define IXGBE_VF_API_NEGOTIATE and IXGBE_VF_GET_QUEUES appear two times with the same name, value, and notes. Version 2.0 VF requests can inherit the two macro defines in previous version 1.0 and 1.1. Otherwise, maybe cause confusion. Signed-off-by: Chenghu Yao -

Re: [dpdk-dev] [PATCH v5 29/29] net/i40e: set/clear VF stats from PF

2016-12-20 Thread Lu, Wenzhuo
Hi all, > -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, December 20, 2016 9:40 PM > To: Yigit, Ferruh; dev@dpdk.org > Cc: Wu, Jingjing; Zhang, Helin; Zhang, Qi Z; Lu, Wenzhuo; Chen, Jing D > Subject: RE: [dpdk-dev] [PATCH v5 29/29] net/i40e: set/clear VF stats from PF >

Re: [dpdk-dev] [PATCH v5 00/29] Support VFD and DPDK PF + kernel VF on i40e

2016-12-20 Thread Lu, Wenzhuo
Hi all, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Tuesday, December 20, 2016 11:32 PM > To: Vincent JARDIN; Chen, Jing D; Thomas Monjalon > Cc: dev@dpdk.org; Wu, Jingjing; Zhang, Helin > Subject: Re: [dpdk-dev] [PATCH v5 00/29] Suppor

Re: [dpdk-dev] [PATCH 1/7] net/qede: reduce noise in debug logs

2016-12-20 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, December 08, 2016 8:49 AM > > On 12/3/2016 2:43 AM, Harish Patil wrote: > > From: Rasesh Mody > > > > Replace CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER with > > CONFIG_RTE_LIBRTE_QEDE_DEBUG_VAL which is a 32-bit bitmapped value > >

Re: [dpdk-dev] [PATCH 1/8] net/qede: fix to get vendor/device id info

2016-12-20 Thread Mody, Rasesh
Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, December 09, 2016 5:36 AM > > Hi Rasesh, > > On 12/3/2016 6:35 AM, Rasesh Mody wrote: > > Fixes: ec94dbc5 ("qede: add base driver") > > > > Signed-off-by: Rasesh Mody > > Related to the commit logs of this patchset

Re: [dpdk-dev] [PATCH 6/7] net/qede: fix maximum VF count to 0

2016-12-20 Thread Harish Patil
> >2016-12-12 18:13, Ferruh Yigit: >> On 12/12/2016 5:47 PM, Harish Patil wrote: >> >> btw, while checking feature list, I have seen qede_vf supports >>SR-IOV, >> >> is that correct? >> > >> > Yes. The supported combination for SR-IOV is VF driver (qede PMD) >>with PF >> > driver (qede linux drive

Re: [dpdk-dev] [PATCH 7/7] net/qede: restrict maximum queues for PF/VF

2016-12-20 Thread Harish Patil
> >On 12/12/2016 7:29 PM, Harish Patil wrote: >> >>> On 12/3/2016 2:43 AM, Harish Patil wrote: Fix to adverstise max_rx_queues by taking into account the number >>> >>> s/adverstise/advertise >> >> Will correct that, thanks. >> >>> of PF connections instead of returning max_queues sup

Re: [dpdk-dev] [PATCH 2/7] net/qede: refactor filtering code

2016-12-20 Thread Harish Patil
> >On 12/12/2016 5:36 PM, Harish Patil wrote: >> >>> On 12/3/2016 2:43 AM, Harish Patil wrote: The filter_config in qed_eth_ops_pass is a wrapper call driving all the filtering configuration. This requires defining multiple structures and passing different function arguments

Re: [dpdk-dev] [PATCH 1/7] net/qede: reduce noise in debug logs

2016-12-20 Thread Harish Patil
> >On 12/12/2016 5:15 PM, Harish Patil wrote: >> Hi Ferruh, >> >>> On 12/3/2016 2:43 AM, Harish Patil wrote: From: Rasesh Mody Replace CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER with CONFIG_RTE_LIBRTE_QEDE_DEBUG_VAL which is a 32-bit bitmapped value where each bit represent a pa

Re: [dpdk-dev] [PATCH v3 3/4] crypto/aesni_mb: add single operation functionality

2016-12-20 Thread Declan Doherty
On 19/12/16 17:29, Pablo de Lara wrote: Update driver to use new AESNI Multibuffer IPSec library single operation functionality (cipher only and authentication only). This patch also adds tests for this new feature. Signed-off-by: Pablo de Lara --- app/test/test_cryptodev.c

Re: [dpdk-dev] [PATCH v3 1/4] crypto/aesni_mb: fix incorrect crypto session

2016-12-20 Thread Declan Doherty
On 19/12/16 17:29, Pablo de Lara wrote: When using sessionless crypto operations, crypto session is obtained from a pool of sessions, when processing the operation. Once the operation is processed, the session is put back in the pool, but for the AESNI MB PMD, this session was not being saved in

Re: [dpdk-dev] [PATCH] net/af_packet: initialize link interrupt callback queue

2016-12-20 Thread Chas Williams
On Tue, 2016-12-20 at 14:20 +, Ferruh Yigit wrote: > On 12/17/2016 6:03 PM, Chas Williams wrote: > > This patch initializes the eth_dev->link_intr_cbs queue which is > > used when af_packet is passed into rte_eth_ev_callback_register(). > > Why do you want to register callback to af_packet PMD

[dpdk-dev] [PATCH v4 22/25] app/testpmd: add L4 items to flow command

2016-12-20 Thread Adrien Mazarguil
Add the ability to match a few properties of common L4[.5] protocol headers: - ICMP: type and code. - UDP: source and destination ports. - TCP: source and destination ports. - SCTP: source and destination ports. - VXLAN: network identifier. Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern -

[dpdk-dev] [PATCH v4 25/25] doc: describe testpmd flow command

2016-12-20 Thread Adrien Mazarguil
Document syntax, interaction with rte_flow and provide usage examples. Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern Acked-by: John McNamara --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 612 +++ 1 file changed, 612 insertions(+) diff --git a/doc/guides/testpmd_

[dpdk-dev] [PATCH v4 24/25] app/testpmd: add queue actions to flow command

2016-12-20 Thread Adrien Mazarguil
- QUEUE: assign packets to a given queue index. - DUP: duplicate packets to a given queue index. - RSS: spread packets among several queues. Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern --- app/test-pmd/cmdline_flow.c | 152 +++ 1 file changed, 152 in

[dpdk-dev] [PATCH v4 23/25] app/testpmd: add various actions to flow command

2016-12-20 Thread Adrien Mazarguil
- MARK: attach 32 bit value to packets. - FLAG: flag packets. - DROP: drop packets. - COUNT: enable counters for a rule. - PF: redirect packets to physical device function. - VF: redirect packets to virtual device function. Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern --- app/test-pmd/c

[dpdk-dev] [PATCH v4 21/25] app/testpmd: add items ipv4/ipv6 to flow command

2016-12-20 Thread Adrien Mazarguil
Add the ability to match basic fields from IPv4 and IPv6 headers (source and destination addresses only). Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern --- app/test-pmd/cmdline_flow.c | 177 +++ 1 file changed, 177 insertions(+) diff --git a/app/test-

[dpdk-dev] [PATCH v4 19/25] app/testpmd: add item raw to flow command

2016-12-20 Thread Adrien Mazarguil
Matches arbitrary byte strings with properties: - relative: look for pattern after the previous item. - search: search pattern from offset (see also limit). - offset: absolute or relative offset for pattern. - limit: search area limit for start of pattern. - length: pattern length. - pattern: byte

[dpdk-dev] [PATCH v4 20/25] app/testpmd: add items eth/vlan to flow command

2016-12-20 Thread Adrien Mazarguil
These pattern items match basic Ethernet headers (source, destination and type) and related 802.1Q/ad VLAN headers. Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern --- app/test-pmd/cmdline_flow.c | 126 +++ 1 file changed, 126 insertions(+) diff --git a

[dpdk-dev] [PATCH v4 16/25] app/testpmd: add rte_flow bit-field support

2016-12-20 Thread Adrien Mazarguil
Several rte_flow structures expose bit-fields that cannot be set in a generic fashion at byte level. Add bit-mask support to handle them. Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern --- app/test-pmd/cmdline_flow.c | 59 1 file changed, 59 insert

[dpdk-dev] [PATCH v4 17/25] app/testpmd: add item any to flow command

2016-12-20 Thread Adrien Mazarguil
This pattern item matches any protocol in place of the current layer and has two properties: - min: minimum number of layers covered (0 or more). - max: maximum number of layers covered (0 means infinity). Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern --- app/test-pmd/cmdline_flow.c | 2

[dpdk-dev] [PATCH v4 18/25] app/testpmd: add various items to flow command

2016-12-20 Thread Adrien Mazarguil
- PF: match packets addressed to the physical function. - VF: match packets addressed to a virtual function ID. - PORT: device-specific physical port index to use. Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern --- app/test-pmd/cmdline_flow.c | 53

[dpdk-dev] [PATCH v4 15/25] app/testpmd: add rte_flow item spec prefix length

2016-12-20 Thread Adrien Mazarguil
Generating bit-masks from prefix lengths is often more convenient than providing them entirely (e.g. to define IPv4 and IPv6 subnets). This commit adds the "prefix" operator that assigns generated bit-masks to any pattern item specification field. Signed-off-by: Adrien Mazarguil Acked-by: Olga S

[dpdk-dev] [PATCH v4 14/25] app/testpmd: add rte_flow item spec handler

2016-12-20 Thread Adrien Mazarguil
Add parser code to fully set individual fields of pattern item specification structures, using the following operators: - fix: sets field and applies full bit-mask for perfect matching. - spec: sets field without modifying its bit-mask. - last: sets upper value of the spec => last range. - mask: s

[dpdk-dev] [PATCH v4 13/25] app/testpmd: add flow query command

2016-12-20 Thread Adrien Mazarguil
Syntax: flow query {port_id} {rule_id} {action} Query a specific action of an existing flow rule. Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern --- app/test-pmd/cmdline.c | 3 + app/test-pmd/cmdline_flow.c | 121 ++- 2 files changed, 123 inse

[dpdk-dev] [PATCH v4 11/25] app/testpmd: add flow destroy command

2016-12-20 Thread Adrien Mazarguil
Syntax: flow destroy {port_id} rule {rule_id} [...] Destroy a given set of flow rules associated with a port. Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern --- app/test-pmd/cmdline.c | 3 ++ app/test-pmd/cmdline_flow.c | 106 ++- 2 files chan

[dpdk-dev] [PATCH v4 12/25] app/testpmd: add flow validate/create commands

2016-12-20 Thread Adrien Mazarguil
Syntax: flow (validate|create) {port_id} [group {group_id}] [priority {level}] [ingress] [egress] pattern {item} [/ {item} [...]] / end actions {action} [/ {action} [...]] / end Either check the validity of a flow rule or create it. Any number of pattern items and actions can be prov

[dpdk-dev] [PATCH v4 10/25] app/testpmd: add flow flush command

2016-12-20 Thread Adrien Mazarguil
Syntax: flow flush {port_id} Destroy all flow rules on a port. Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern --- app/test-pmd/cmdline.c | 3 +++ app/test-pmd/cmdline_flow.c | 43 +++- 2 files changed, 45 insertions(+), 1 deletion(-) diff --gi

[dpdk-dev] [PATCH v4 09/25] app/testpmd: add flow list command

2016-12-20 Thread Adrien Mazarguil
Syntax: flow list {port_id} [group {group_id}] [...] List configured flow rules on a port. Output can optionally be limited to a given set of group identifiers. Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern --- app/test-pmd/cmdline.c | 4 ++ app/test-pmd/cmdline_flow.c | 141 ++

[dpdk-dev] [PATCH v4 07/25] app/testpmd: add flow command

2016-12-20 Thread Adrien Mazarguil
Managing generic flow API functions from command line requires the use of dynamic tokens for convenience as flow rules are not fixed and cannot be defined statically. This commit adds specific flexible parser code and object for a new "flow" command in separate file. Signed-off-by: Adrien Mazargu

[dpdk-dev] [PATCH v4 08/25] app/testpmd: add rte_flow integer support

2016-12-20 Thread Adrien Mazarguil
Parse all integer types and handle conversion to network byte order in a single function. Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern --- app/test-pmd/cmdline_flow.c | 148 +++ 1 file changed, 148 insertions(+) diff --git a/app/test-pmd/cmdline_flow

[dpdk-dev] [PATCH v4 06/25] app/testpmd: implement basic support for rte_flow

2016-12-20 Thread Adrien Mazarguil
Add basic management functions for the generic flow API (validate, create, destroy, flush, query and list). Flow rule objects and properties are arranged in lists associated with each port. Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern --- app/test-pmd/cmdline.c | 1 + app/test-pmd

[dpdk-dev] [PATCH v4 05/25] cmdline: add alignment constraint

2016-12-20 Thread Adrien Mazarguil
This prevents sigbus errors on architectures that cannot handle unexpected unaligned accesses to the output buffer. Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern --- lib/librte_cmdline/cmdline_parse.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/librte

[dpdk-dev] [PATCH v4 04/25] cmdline: add support for dynamic tokens

2016-12-20 Thread Adrien Mazarguil
Considering tokens must be hard-coded in a list part of the instruction structure, context-dependent tokens cannot be expressed. This commit adds support for building dynamic token lists through a user-provided function, which is called when the static token list is empty (a single NULL entry). B

[dpdk-dev] [PATCH v4 02/25] doc: add rte_flow prog guide

2016-12-20 Thread Adrien Mazarguil
This documentation is based on the latest RFC submission, subsequently updated according to feedback from the community. Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern --- doc/guides/prog_guide/index.rst|1 + doc/guides/prog_guide/rte_flow.rst | 2042 ++

[dpdk-dev] [PATCH v4 03/25] doc: announce deprecation of legacy filter types

2016-12-20 Thread Adrien Mazarguil
They are superseded by the generic flow API (rte_flow). Target release is not defined yet. Suggested-by: Kevin Traynor Signed-off-by: Adrien Mazarguil Acked-by: Olga Shern --- doc/guides/rel_notes/deprecation.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/

[dpdk-dev] [PATCH v4 00/25] Generic flow API (rte_flow)

2016-12-20 Thread Adrien Mazarguil
As previously discussed in RFC v1 [1], RFC v2 [2], with changes described in [3] (also pasted below), here is the first non-draft series for this new API. Its capabilities are so generic that its name had to be vague, it may be called "Generic flow API", "Generic flow interface" (possibly shortene

[dpdk-dev] [PATCH v4 01/25] ethdev: introduce generic flow API

2016-12-20 Thread Adrien Mazarguil
This new API supersedes all the legacy filter types described in rte_eth_ctrl.h. It is slightly higher level and as a result relies more on PMDs to process and validate flow rules. Benefits: - A unified API is easier to program for, applications do not have to be written for a specific filter t

Re: [dpdk-dev] [PATCH 10/24] ethdev: parse ethertype filter

2016-12-20 Thread Ferruh Yigit
On 12/2/2016 11:53 AM, Beilei Xing wrote: > Check if the rule is a ethertype rule, and get the ethertype > info BTW. > > Signed-off-by: Wenzhuo Lu > Signed-off-by: Beilei Xing > --- CC: Adrien Mazarguil > lib/librte_ether/rte_flow.c| 136 > + > li

Re: [dpdk-dev] [PATCH v3] drivers: advertise kmod dependencies in pmdinfo

2016-12-20 Thread Thomas Monjalon
> > Add a new macro RTE_PMD_REGISTER_KMOD_DEP() that allows a driver to > > declare the list of kernel modules required to run properly. > > > > Today, most PCI drivers require uio/vfio. > > > > Signed-off-by: Olivier Matz > > Acked-by: Fiona Trahe > > Acked-by: Adrien Mazarguil Applied in m

Re: [dpdk-dev] [PATCH 16/18] net/ixgbe: create consistent filter

2016-12-20 Thread Ferruh Yigit
On 12/2/2016 10:43 AM, Wei Zhao wrote: > From: wei zhao1 > > This patch adds a function to create the flow directory filter. > > Signed-off-by: wei zhao1 > Signed-off-by: Wenzhuo Lu <...> > +/** > + * Create or destroy a flow rule. > + * Theorically one rule can match more than one filters.

Re: [dpdk-dev] [PATCH 11/18] net/ixgbe: parse n-tuple filter

2016-12-20 Thread Ferruh Yigit
On 12/2/2016 10:43 AM, Wei Zhao wrote: > From: wei zhao1 > > Add rule validate function and check if the rule is a n-tuple rule, > and get the n-tuple info. > > Signed-off-by: wei zhao1 > Signed-off-by: Wenzhuo Lu > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 349 > +

Re: [dpdk-dev] [PATCH v2] examples/ethtool: fix bug in drvinfo callback

2016-12-20 Thread Thomas Monjalon
2016-11-23 09:00, Remy Horton: > Not sure this is a problem in practice, as the same set if fields is > updated each time...at least for now. > > On 22/11/2016 09:41, Qiming Yang wrote: > > Function pcmd_drvinfo_callback uses struct info to get > > the ethtool information of each port. Struct inf

Re: [dpdk-dev] [PATCH 04/13] eal: introduce driver type

2016-12-20 Thread Stephen Hemminger
On Tue, 20 Dec 2016 12:46:17 +0530 Shreyansh Jain wrote: > On Tuesday 20 December 2016 03:29 AM, Stephen Hemminger wrote: > > Since multiple buses and device types need to be supported. > > Provide type field in driver. > > --- > > lib/librte_eal/common/include/rte_dev.h | 15 --- >

Re: [dpdk-dev] [PATCH 01/13] ethdev: increase length ethernet device internal name

2016-12-20 Thread Stephen Hemminger
On Tue, 20 Dec 2016 12:23:25 +0530 Shreyansh Jain wrote: > On Tuesday 20 December 2016 03:29 AM, Stephen Hemminger wrote: > > Allow sufficicent space for UUID in string form (36+1). > > Needed to use UUID with Hyper-V > > > > Signed-off-by: Stephen Hemminger > > --- > > doc/guides/rel_notes/dep

Re: [dpdk-dev] [PATCH v3 02/12] eal/bus: introduce bus abstraction

2016-12-20 Thread Stephen Hemminger
On Tue, 20 Dec 2016 14:17:14 +0100 Jan Blunck wrote: > On Fri, Dec 16, 2016 at 2:10 PM, Shreyansh Jain > wrote: > > This patch introduces the rte_bus abstraction for devices and drivers in > > EAL framework. The model is: > > - One or more buses are connected to a CPU (or core) > > - One or m

Re: [dpdk-dev] [PATCH 04/13] eal: introduce driver type

2016-12-20 Thread Stephen Hemminger
On Tue, 20 Dec 2016 14:00:55 +0100 Jan Blunck wrote: > On Mon, Dec 19, 2016 at 10:59 PM, Stephen Hemminger > wrote: > > Since multiple buses and device types need to be supported. > > Provide type field in driver. > > --- > > lib/librte_eal/common/include/rte_dev.h | 15 --- > > li

Re: [dpdk-dev] [PATCH v3 25/25] doc: describe testpmd flow command

2016-12-20 Thread Ferruh Yigit
On 12/19/2016 5:49 PM, Adrien Mazarguil wrote: > Document syntax, interaction with rte_flow and provide usage examples. > > Signed-off-by: Adrien Mazarguil > Acked-by: Olga Shern > --- <...> > + > +Check whether redirecting any Ethernet packet received on port 0 to RX queue > +index 6 is suppo

Re: [dpdk-dev] [PATCH 15/18] net/ixgbe: parse flow director filter

2016-12-20 Thread Ferruh Yigit
On 12/2/2016 10:43 AM, Wei Zhao wrote: > From: wei zhao1 > > check if the rule is a flow director rule, and get the flow director info. > > Signed-off-by: wei zhao1 > Signed-off-by: Wenzhuo Lu > --- <...> > + PATTERN_SKIP_VOID(rule, struct ixgbe_fdir_rule, > + RTE_F

Re: [dpdk-dev] [PATCH 04/18] net/ixgbe: restore n-tuple filter

2016-12-20 Thread Ferruh Yigit
On 12/2/2016 10:43 AM, Wei Zhao wrote: > From: wei zhao1 > > Add support for restoring n-tuple filter in SW. > > Signed-off-by: Wenzhuo Lu > Signed-off-by: wei zhao1 > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 131 > +-- > 1 file changed, 83 insertions(+),

Re: [dpdk-dev] [PATCH 02/18] net/ixgbe: store flow director filter

2016-12-20 Thread Ferruh Yigit
On 12/2/2016 10:42 AM, Wei Zhao wrote: > From: wei zhao1 > > Add support for storing flow director filter in SW. > > Signed-off-by: Wenzhuo Lu > Signed-off-by: wei zhao1 > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 48 ++ > drivers/net/ixgbe/ixgbe_ethdev.h | 19 ++- > driv

Re: [dpdk-dev] [PATCH 01/18] net/ixgbe: store SYN filter

2016-12-20 Thread Ferruh Yigit
On 12/2/2016 10:42 AM, Wei Zhao wrote: > From: wei zhao1 > > Add support for storing SYN filter in SW. Do you think does it makes more clear to refer as TCP SYN filter? Or SYN filter is clear enough? > > Signed-off-by: Wenzhuo Lu > Signed-off-by: wei zhao1 Can you please update sign-off to

Re: [dpdk-dev] [PATCH v3 02/25] doc: add rte_flow prog guide

2016-12-20 Thread Mcnamara, John
Hi Adrien, There seems to be an issue when building the PDF version of the docs due to the width of some of the fields in 2 of the tables. I think this may be a Sphinx/Latex bug since it doesn't happen without the table:: directive. If you replace the following tables with the format below (the t

Re: [dpdk-dev] [PATCH v3 00/31] net/i40e: base code update

2016-12-20 Thread Gregory Etelson
add dmesg output: dmar: DRHD: handling fault status reg 502 dmar: DMAR:[DMA Read] Request device [04:00.0] fault addr 865bcc000 DMAR:[fault reason 02] Present bit in context entry is clear dmar: DRHD: handling fault status reg 602 dmar: DMAR:[DMA Read] Request device [04:00.0] fault addr 865bcc00

Re: [dpdk-dev] [PATCH v3 07/25] app/testpmd: add flow command

2016-12-20 Thread Ferruh Yigit
Hi Adrien, On 12/19/2016 5:48 PM, Adrien Mazarguil wrote: > Managing generic flow API functions from command line requires the use of > dynamic tokens for convenience as flow rules are not fixed and cannot be > defined statically. > > This commit adds specific flexible parser code and object for

Re: [dpdk-dev] [PATCH v3 00/31] net/i40e: base code update

2016-12-20 Thread Gregory Etelson
Hello, I have several XL710-Q2 interfaces that fail with `PMD: eth_i40e_dev_init(): Failed to init adminq: -54' Rebase to the latest dpdk-next-net/master did not fix the fault Firmware version is 5.04 0x80002505 0.0.0 lspci output looks the same for working and failed interfaces Full traces with

Re: [dpdk-dev] [PATCH v3 7/9] ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get()

2016-12-20 Thread Stephen Hemminger
On Tue, 20 Dec 2016 12:11:53 +0100 Jan Blunck wrote: > Only the device itself can decide its PCI or not. > > Signed-off-by: Jan Blunck > --- > drivers/net/bnx2x/bnx2x_ethdev.c| 1 + > drivers/net/bnxt/bnxt_ethdev.c | 2 ++ > drivers/net/cxgbe/cxgbe_ethdev.c| 2 ++ > dr

Re: [dpdk-dev] [PATCH v5 00/29] Support VFD and DPDK PF + kernel VF on i40e

2016-12-20 Thread Ferruh Yigit
On 12/20/2016 3:18 PM, Vincent JARDIN wrote: > Le 20/12/2016 à 05:48, Chen, Jing D a écrit : >> That's a collaboration with another team. we'll follow-up that but not >> guarantee >> it will happen. >> May I ask if my reply make it clear? Still NAC for this patch? > > Yes still nack, I am not con

Re: [dpdk-dev] [PATCH v3 2/9] ethdev: Helper to convert to struct rte_pci_device

2016-12-20 Thread Stephen Hemminger
On Tue, 20 Dec 2016 12:11:48 +0100 Jan Blunck wrote: > Signed-off-by: Jan Blunck > Acked-by: Shreyansh Jain > --- > lib/librte_ether/rte_ethdev.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index 9678179..3adbb

Re: [dpdk-dev] [PATCH 0/3] buildtools/devtools/usertools

2016-12-20 Thread Ferruh Yigit
On 12/15/2016 9:59 PM, Thomas Monjalon wrote: > The current tools/ and scripts/ directory names are not > self describing. > These patches create devtools/ and usertools/ directories. I think classifying scripts is a good idea. > > Thomas Monjalon (3): > scripts: move to buildtools > scripts

Re: [dpdk-dev] [PATCH v5 18/29] app/testpmd: use VFD APIs on i40e

2016-12-20 Thread Vincent JARDIN
Le 19/12/2016 à 12:03, Ferruh Yigit a écrit : And it is always possible to move these into ethdev layer, when multiple PMDs supports same feature. I agree this is something that needs to keep an eye on it, and be sure if an API is generic, move it into eth_dev layer. you are right, you have a g

Re: [dpdk-dev] [PATCH v5 00/29] Support VFD and DPDK PF + kernel VF on i40e

2016-12-20 Thread Vincent JARDIN
Le 20/12/2016 à 05:48, Chen, Jing D a écrit : That's a collaboration with another team. we'll follow-up that but not guarantee it will happen. May I ask if my reply make it clear? Still NAC for this patch? Yes still nack, I am not confident with this PF approach since you are breaking Linux PF

Re: [dpdk-dev] [PATCH v1] examples/ethtool: fix segfault querying non-PCI devices

2016-12-20 Thread Thomas Monjalon
2016-11-30 10:47, Remy Horton: > Doing a device information query on a non-PCI device such as > vhost was resulting in the dereferencing of a NULL pointer > (the absent PCI data), causing a segmentation fault. > > Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample > application

Re: [dpdk-dev] [PATCH v2] doc: introduce PVP reference benchmark

2016-12-20 Thread Maxime Coquelin
On 12/20/2016 11:03 AM, Thomas Monjalon wrote: Signed-off-by: Maxime Coquelin There is one trailing whitespace warning but apart from that: Acked-by: John McNamara Thanks John, Do you want me to send a v3, fixing the trailing whitespace & collecting the acks? No need (unless the tree

Re: [dpdk-dev] [PATCH] net/af_packet: initialize link interrupt callback queue

2016-12-20 Thread Ferruh Yigit
On 12/17/2016 6:03 PM, Chas Williams wrote: > This patch initializes the eth_dev->link_intr_cbs queue which is > used when af_packet is passed into rte_eth_ev_callback_register(). Why do you want to register callback to af_packet PMD, it won't be calling them? > > Fixes: 4dc294158cac ("ethdev: s

Re: [dpdk-dev] [PATCH 1/3] ethdev: New API to free consumed buffers in TX ring

2016-12-20 Thread Billy McFall
Thank you for your responses, see inline. On Tue, Dec 20, 2016 at 7:58 AM, Adrien Mazarguil wrote: > On Tue, Dec 20, 2016 at 12:17:10PM +, Ananyev, Konstantin wrote: >> >> >> > -Original Message- >> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrien Mazarguil >> > Sent: Tue

  1   2   >