Re: [dpdk-dev] [PATCH v2 5/6] net/vmxnet3: receive queue memory leak

2017-06-23 Thread Shrikrishna Khare
On Thu, 15 Jun 2017, Charles (Chas) Williams wrote: > From: Mandeep Rohilla > > This addresses an mbuf leak in an error condition during packet > receive. > > Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver > implementation") > > Signed-off-by: Mandeep Rohilla Acked-by:

[dpdk-dev] [PATCH v3 7/8] mk: sort object files when building deps lists

2017-06-23 Thread lboccass
From: Luca Boccassi In order to achieve reproducible builds, always use the same order when listing object files to build dependencies lists. Signed-off-by: Luca Boccassi --- mk/rte.app.mk | 4 ++-- mk/rte.hostapp.mk | 4 ++-- mk/rte.shared.mk | 4 ++-- 3 files changed, 6 insertions(+), 6

[dpdk-dev] [PATCH v3 8/8] mk: always rebuild in the same order

2017-06-23 Thread lboccass
From: Luca Boccassi In order to achieve reproducible builds, always check dependencies in the same order. Signed-off-by: Luca Boccassi --- mk/internal/rte.compile-pre.mk | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mk/internal/rte.compile-pre.mk b/mk/internal/rte

[dpdk-dev] [PATCH v3 6/8] mk: sort source files before passing them to the compiler

2017-06-23 Thread lboccass
From: Luca Boccassi In order to achieve reproducible builds, always use the same order when listing files for compilation. Signed-off-by: Luca Boccassi --- drivers/net/cxgbe/Makefile| 2 +- drivers/net/e1000/Makefile| 2 +- drivers/net/fm10k/Makefile| 2 +- drivers/net/i40e/Makefil

[dpdk-dev] [PATCH v3 5/8] mk: sort headers before wildcard inclusion

2017-06-23 Thread lboccass
From: Luca Boccassi In order to achieve fully reproducible builds, always use the same inclusion order for headers in the Makefiles. Signed-off-by: Luca Boccassi --- examples/ip_pipeline/Makefile | 2 +- examples/multi_process/client_server_mp/mp_server/Makefile |

[dpdk-dev] [PATCH v3 4/8] mk: sort list of files in examples.dox

2017-06-23 Thread lboccass
From: Luca Boccassi The result of find might not be stable depending on external conditions. Pipe it through LC_ALL=C sort to ensure reproducible results when generating examples.dox. Signed-off-by: Luca Boccassi --- mk/rte.sdkdoc.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH v3 3/8] mk: sort list of shared objects in linker script

2017-06-23 Thread lboccass
From: Luca Boccassi The output of wildcard might not be stable and depend on the filesystem and other factors. This means the content libdpdk.so linker script might change between builds from the same sources. Run the list through sort to ensure reproducibility. Signed-off-by: Luca Boccassi ---

[dpdk-dev] [PATCH v3 2/8] mk: fix excluding .doctrees when installing docs

2017-06-23 Thread lboccass
From: Luca Boccassi The --exclude parameter must be passed before the input directory to tar, otherwise it's silently ignored and the .doctrees directory is installed by make install-doc. Signed-off-by: Luca Boccassi --- mk/rte.sdkinstall.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[dpdk-dev] [PATCH v3 1/8] mk: use make silent flag to print HTML doc version

2017-06-23 Thread lboccass
From: Luca Boccassi Depending on the environment, make might echo the command being ran. In mk/rte.sdkdoc.mk make is used to print the DPDK version to be piped to doxygen. This causes the following to be written: DPDK  /usr/bin/make-f/build/dpdk-jYjqnr/ dpdk-16.11.2/mk/rte.sdkconfig.mkshowversi

[dpdk-dev] [PATCH v3 0/8] Reproducible build

2017-06-23 Thread lboccass
From: Luca Boccassi In the past couple of years a concerted effort among almost all Linux distros has been striving toward achieving reproducible builds. [1] This involves changes to the toolchain, new tools and CI systems. [2] v1 fixed the documentation, examples and linker script generation. v

Re: [dpdk-dev] [PATCH v2 0/7] Reproducible build

2017-06-23 Thread Luca Boccassi
On Fri, 2017-06-23 at 19:16 +0100, lbocc...@brocade.com wrote: > From: Luca Boccassi > > In the past couple of years a concerted effort among almost all Linux > distros has been striving toward achieving reproducible builds. [1] > This involves changes to the toolchain, new tools and CI systems.

[dpdk-dev] [PATCH v2 7/7] mk: always rebuild in the same order

2017-06-23 Thread lboccass
From: Luca Boccassi In order to achieve reproducible builds, always check dependencies in the same order. Signed-off-by: Luca Boccassi --- mk/internal/rte.compile-pre.mk | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mk/internal/rte.compile-pre.mk b/mk/internal/rte

[dpdk-dev] [PATCH v2 6/7] mk: sort object files when building deps lists

2017-06-23 Thread lboccass
From: Luca Boccassi In order to achieve reproducible builds, always use the same order when listing object files to build dependencies lists. Signed-off-by: Luca Boccassi --- mk/rte.app.mk | 4 ++-- mk/rte.hostapp.mk | 4 ++-- mk/rte.shared.mk | 4 ++-- 3 files changed, 6 insertions(+), 6

[dpdk-dev] [PATCH v2 5/7] mk: sort source files before passing them to the compiler

2017-06-23 Thread lboccass
From: Luca Boccassi In order to achieve reproducible builds, always use the same order when listing files for compilation. Signed-off-by: Luca Boccassi --- drivers/net/cxgbe/Makefile| 2 +- drivers/net/e1000/Makefile| 2 +- drivers/net/fm10k/Makefile| 2 +- drivers/net/i40e/Makefil

[dpdk-dev] [PATCH v2 1/7] mk: fix excluding .doctrees when installing docs

2017-06-23 Thread lboccass
From: Luca Boccassi The --exclude parameter must be passed before the input directory to tar, otherwise it's silently ignored and the .doctrees directory is installed by make install-doc. Signed-off-by: Luca Boccassi --- mk/rte.sdkinstall.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[dpdk-dev] [PATCH v2 3/7] mk: sort list of files in examples.dox

2017-06-23 Thread lboccass
From: Luca Boccassi The result of find might not be stable depending on external conditions. Pipe it through LC_ALL=C sort to ensure reproducible results when generating examples.dox. Signed-off-by: Luca Boccassi --- mk/rte.sdkdoc.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH v2 4/7] mk: sort headers before wildcard inclusion

2017-06-23 Thread lboccass
From: Luca Boccassi In order to achieve fully reproducible builds, always use the same inclusion order for headers in the Makefiles. Signed-off-by: Luca Boccassi --- examples/ip_pipeline/Makefile | 2 +- examples/multi_process/client_server_mp/mp_server/Makefile |

[dpdk-dev] [PATCH v2 2/7] mk: sort list of shared objects in linker script

2017-06-23 Thread lboccass
From: Luca Boccassi The output of wildcard might not be stable and depend on the filesystem and other factors. This means the content libdpdk.so linker script might change between builds from the same sources. Run the list through sort to ensure reproducibility. Signed-off-by: Luca Boccassi ---

[dpdk-dev] [PATCH v2 0/7] Reproducible build

2017-06-23 Thread lboccass
From: Luca Boccassi In the past couple of years a concerted effort among almost all Linux distros has been striving toward achieving reproducible builds. [1] This involves changes to the toolchain, new tools and CI systems. [2] v1 fixed the documentation, examples and linker script generation. v

[dpdk-dev] [PATCH v2] pci: pad vendor and device ID to 4 digits

2017-06-23 Thread Daniel Verkamp
Some PCI vendor and device IDs have leading zeros. Signed-off-by: Daniel Verkamp --- v2: added #define for format string, use %.4 style and PRIx16 lib/librte_eal/common/eal_common_pci.c | 8 lib/librte_eal/common/include/rte_pci.h | 3 +++ 2 files changed, 7 insertions(+), 4 deletion

Re: [dpdk-dev] DPDK drivers should not use kernel version

2017-06-23 Thread Stephen Hemminger
On Fri, 23 Jun 2017 13:03:55 +0530 Hemant Agrawal wrote: > On 6/21/2017 9:58 PM, Stephen Hemminger wrote: > > Looking at some other issues, I noticed that both the TAP and MLX5 device > > drivers are looking at kernel version through uname. Although this may > > seem like a good way to deal with

Re: [dpdk-dev] [PATCH 2/3] eal: PCI domain should be 32 bits

2017-06-23 Thread Stephen Hemminger
On Fri, 23 Jun 2017 00:41:43 + "Chang, Cunyin" wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Thursday, June 22, 2017 11:52 PM > > To: Chang, Cunyin > > Cc: dev@dpdk.org; Stephen Hemminger > > Subject: Re: [dpdk-dev] [PATCH 2/

Re: [dpdk-dev] [PATCH] pci: pad vendor and device ID to 4 digits

2017-06-23 Thread Stephen Hemminger
On Fri, 23 Jun 2017 10:29:41 -0700 Daniel Verkamp wrote: > Some PCI vendor and device IDs have leading zeros. > > Signed-off-by: Daniel Verkamp > --- > lib/librte_eal/common/eal_common_pci.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/common/e

[dpdk-dev] [PATCH] pci: pad vendor and device ID to 4 digits

2017-06-23 Thread Daniel Verkamp
Some PCI vendor and device IDs have leading zeros. Signed-off-by: Daniel Verkamp --- lib/librte_eal/common/eal_common_pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 78b097e..c2

Re: [dpdk-dev] [PATCH] eal: don't advertise a physical address when no hugepages

2017-06-23 Thread Jan Blunck
On Fri, Jun 23, 2017 at 10:11 AM, Olivier Matz wrote: > Hi Jan, > > On Sat, 10 Jun 2017 10:31:22 +0200, Jan Blunck wrote: >> On Fri, Jun 9, 2017 at 10:29 AM, Olivier Matz wrote: >> > When populating a mempool with a virtual memory area, the mempool >> > library expects to be able to get the phys

[dpdk-dev] [PATCH] (pkgtgen-dpdk) doc: Fix broken link to pktgen-dpdk documentation

2017-06-23 Thread McCullough, Harrison
The `setup.sh` script is now located in the `tools` subdirectory. In addition, it is not an executable but is shown as if it was. It should either be called with `bash`, run with `source`, or set to be an executable. Signed-off-by: Harrison McCullough --- docs/source/getting_started.rst | 8

Re: [dpdk-dev] [PATCH v2 0/9] Crypto fixes/cleanup

2017-06-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, June 22, 2017 1:02 PM > To: Doherty, Declan ; Trahe, Fiona > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v2 0/9] Crypto fixes/cleanup > > Prior to new crypto patches for this release, there were some f

Re: [dpdk-dev] bug: virtio PMD sends malformed packets for 32-bit processes on 64-bit kernel

2017-06-23 Thread Tan, Jianfeng
Hi Cadete, On 6/22/2017 10:58 PM, Frederico Cadete wrote: Hello, I believe commit 260aae9a [1] has introduced a regression for the case of 32-bit process running on a 64-bit kernel. The commit is effectively casting mbuf->buf_physaddr to uintptr_t before dereferencing it. It truncates the phy

Re: [dpdk-dev] [PATCH v2 00/12] Remove cryptodev driver structure

2017-06-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, June 21, 2017 7:28 AM > To: Doherty, Declan ; tho...@monjalon.net > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v2 00/12] Remove cryptodev driver structure > > Following the same approach taken for ethde

Re: [dpdk-dev] [PATCH v3 0/9] bus/pci: remove PCI bus from EAL

2017-06-23 Thread Thomas Monjalon
23/06/2017 16:35, Tan, Jianfeng: > Hi Thomas & Gaetan, > > > On 6/23/2017 8:48 PM, Thomas Monjalon wrote: > > 23/06/2017 10:19, Gaëtan Rivet: > >> Hi Jianfeng, > >> > >> On Fri, Jun 23, 2017 at 11:29:46AM +0800, Tan, Jianfeng wrote: > >>> Hi Gaetan, > >>> > >>> Do you (or anyone else) have plan t

[dpdk-dev] [PATCH v6 3/3] app/testpmd: enable TCP/IPv4 GRO

2017-06-23 Thread Jiayu Hu
This patch enables TCP/IPv4 GRO library in csum forwarding engine. By default, GRO is turned off. Users can use command "gro (on|off) (port_id)" to enable or disable GRO for a given port. If a port is enabled GRO, all TCP/IPv4 packets received from the port are performed GRO. Besides, users can set

[dpdk-dev] [PATCH v6 1/3] lib: add Generic Receive Offload API framework

2017-06-23 Thread Jiayu Hu
Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by reassembling small packets into large ones. This patchset is to support GRO in DPDK. To support GRO, this patch implements a GRO API framework. To enable m

[dpdk-dev] [PATCH v6 2/3] lib/gro: add TCP/IPv4 GRO support

2017-06-23 Thread Jiayu Hu
In this patch, we introduce five APIs to support TCP/IPv4 GRO. - gro_tcp_tbl_create: create a TCP reassembly table, which is used to merge packets. - gro_tcp_tbl_destroy: free memory space of a TCP reassembly table. - gro_tcp_tbl_flush: flush all packets from a TCP reassembly table. - gro_tcp_t

[dpdk-dev] [PATCH v6 0/3] Support TCP/IPv4 GRO in DPDK

2017-06-23 Thread Jiayu Hu
Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by reassembling small packets into large ones. Therefore, we propose to support GRO in DPDK. To enable more flexibility to applications, DPDK GRO is implement

Re: [dpdk-dev] [PATCH v3 0/9] bus/pci: remove PCI bus from EAL

2017-06-23 Thread Tan, Jianfeng
Hi Thomas & Gaetan, On 6/23/2017 8:48 PM, Thomas Monjalon wrote: 23/06/2017 10:19, Gaëtan Rivet: Hi Jianfeng, On Fri, Jun 23, 2017 at 11:29:46AM +0800, Tan, Jianfeng wrote: Hi Gaetan, Do you (or anyone else) have plan to move vdev bus into drivers/bus/. It is in the roadmap for the DPDK, b

Re: [dpdk-dev] [PATCH 06/33] app/testeventdev: define the test options

2017-06-23 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Sunday, May 28, 2017 8:58 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Eads, Gage > ; > nipun.gu...@nxp.com; Vangati, Narender ; Rao, > Nikhil > ; gprathyu...@caviumnetworks.com; J

[dpdk-dev] [PATCH v1] doc: import sphinx rtd doc theme when available

2017-06-23 Thread John McNamara
The ReadTheDocs theme is no longer available by default in Sphinx versions >= 1.3.1 and if it isn't available then an exception is raised. This patch imports the ReadTheDocs theme when it is available and warns but proceeds when it isn't. Signed-off-by: John McNamara --- doc/guides/conf.py | 12

Re: [dpdk-dev] [PATCH v4] eal: Set numa node value for system which not support it.

2017-06-23 Thread Thomas Monjalon
22/06/2017 17:15, Sergio Gonzalez Monroy: > Just fyi, the summary line should be lowercase apart from acronyms (DPDK > guidelines). > > On 11/05/2017 02:56, Tonghao Zhang wrote: > > The NUMA node information for PCI devices provided through > > sysfs is invalid for AMD Opteron(TM) Processor 62xx

Re: [dpdk-dev] [PATCH 33/33] maintainers: claim responsibility for the eventdev test app

2017-06-23 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Sunday, May 28, 2017 8:59 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Eads, Gage > ; > nipun.gu...@nxp.com; Vangati, Narender ; Rao, > Nikhil > ; gprathyu...@caviumnetworks.com; J

Re: [dpdk-dev] [PATCH 09/18] crypto/aesni_mb: remove check for SSE4

2017-06-23 Thread Declan Doherty
On 20/06/2017 4:23 PM, Bruce Richardson wrote: Since SSE4 is now part of the minimum requirements for DPDK, we don't need to check for its presence any more. Signed-off-by: Bruce Richardson --- ... Acked-by: Declan Doherty

Re: [dpdk-dev] [PATCH 32/33] doc/testeventdev: add "perf all types queue" test details

2017-06-23 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Sunday, May 28, 2017 8:59 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Eads, Gage > ; > nipun.gu...@nxp.com; Vangati, Narender ; Rao, > Nikhil > ; gprathyu...@caviumnetworks.com; J

Re: [dpdk-dev] [PATCH v2 03/12] cryptodev: rename device retrieval argument

2017-06-23 Thread Declan Doherty
On 21/06/2017 7:28 AM, Pablo de Lara wrote: rte_cryptodev_devices_get() function was parsing a crypto device name as an argument, but the function actually returns device identifiers of devices that share the same crypto driver, so the argument should be driver name, instead. Fixes: 38227c0e3ad2

Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions to a separate file

2017-06-23 Thread Declan Doherty
On 21/06/2017 7:28 AM, Pablo de Lara wrote: Move all functions handling virtual devices to a separate header file "rte_cryptodev_vdev.h", in order to leave only generic functions for any device in the rest of the files. Signed-off-by: Pablo de Lara --- ... Acked-by: Declan Doherty

Re: [dpdk-dev] [PATCH 28/33] doc: describe the new eventdev test application

2017-06-23 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Sunday, May 28, 2017 8:59 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Eads, Gage > ; > nipun.gu...@nxp.com; Vangati, Narender ; Rao, > Nikhil > ; gprathyu...@caviumnetworks.com; M

Re: [dpdk-dev] [PATCH 24/33] app/testeventdev: add perf queue test

2017-06-23 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Sunday, May 28, 2017 8:59 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Eads, Gage > ; > nipun.gu...@nxp.com; Vangati, Narender ; Rao, > Nikhil > ; gprathyu...@caviumnetworks.com; J

Re: [dpdk-dev] [PATCH v2 1/9] crypto/aesni_mb: remove assert check

2017-06-23 Thread Declan Doherty
On 22/06/2017 1:02 PM, Pablo de Lara wrote: Some assert checks in the driver were incorrect, but they are not necessary anyway, as application will panic in any case. Fixes: 0f548b50a160 ("crypto/aesni_mb: process crypto op on dequeue") CC: sta...@dpdk.org Signed-off-by: Pablo de Lara --- dri

Re: [dpdk-dev] [PATCH v3 0/9] bus/pci: remove PCI bus from EAL

2017-06-23 Thread Thomas Monjalon
23/06/2017 10:19, Gaëtan Rivet: > Hi Jianfeng, > > On Fri, Jun 23, 2017 at 11:29:46AM +0800, Tan, Jianfeng wrote: > > Hi Gaetan, > > > > Do you (or anyone else) have plan to move vdev bus into drivers/bus/. > > It is in the roadmap for the DPDK, but I haven't planned to do it. We need to move v

Re: [dpdk-dev] [PATCH 14/33] app/testeventdev: order: add eventdev port setup

2017-06-23 Thread Jerin Jacob
-Original Message- > Date: Fri, 23 Jun 2017 12:36:47 + > From: "Van Haaren, Harry" > To: Jerin Jacob , "dev@dpdk.org" > > CC: "Richardson, Bruce" , > "hemant.agra...@nxp.com" , "Eads, Gage" > , "nipun.gu...@nxp.com" , > "Vangati, Narender" , "Rao, Nikhil" > , "gprathyu...@caviumn

Re: [dpdk-dev] [PATCH v1] ring: fix return value for sc and mc dequeue

2017-06-23 Thread Thomas Monjalon
23/06/2017 10:43, Olivier Matz: > Hi Anand, > > On Fri, 2 Jun 2017 11:59:51 +0530, Anand B Jyoti > wrote: > > The error return code for rte_ring_sc_dequeue_bulk() and > > rte_ring_mc_dequeue_bulk() function should be -ENOENT rather > > than -ENOBUFS as described in the function description. >

Re: [dpdk-dev] [PATCH 22/33] app/testeventdev: perf: add eventdev port setup

2017-06-23 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Sunday, May 28, 2017 8:59 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Eads, Gage > ; > nipun.gu...@nxp.com; Vangati, Narender ; Rao, > Nikhil > ; gprathyu...@caviumnetworks.com; J

[dpdk-dev] [PATCH] net/virtio-user: fix crash when detaching device

2017-06-23 Thread Allain Legacy
The rte_eth_dev.data pointer is set to a reference to a static table. Attempting to rte_free() it leads to a panic. For example, the following commands result in a panic if run in testpmd testpmd> port attach virtio_user0,path=/dev/vhost-net,iface=test0 testpmd> port stop 2 testpmd> port cl

Re: [dpdk-dev] [PATCH 14/33] app/testeventdev: order: add eventdev port setup

2017-06-23 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Sunday, May 28, 2017 8:59 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Eads, Gage > ; > nipun.gu...@nxp.com; Vangati, Narender ; Rao, > Nikhil > ; gprathyu...@caviumnetworks.com; J

Re: [dpdk-dev] [pull-request] next-eventdev 17.08 pre-rc1

2017-06-23 Thread Thomas Monjalon
21/06/2017 15:39, Jerin Jacob: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks

Re: [dpdk-dev] [PATCH 04/33] app/testeventdev: add string parsing helpers

2017-06-23 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Sunday, May 28, 2017 8:58 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Eads, Gage > ; > nipun.gu...@nxp.com; Vangati, Narender ; Rao, > Nikhil > ; gprathyu...@caviumnetworks.com >

Re: [dpdk-dev] [PATCH 02/33] app/testeventdev: define eventdev test ops

2017-06-23 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Sunday, May 28, 2017 8:58 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Eads, Gage > ; > nipun.gu...@nxp.com; Vangati, Narender ; Rao, > Nikhil > ; gprathyu...@caviumnetworks.com; J

Re: [dpdk-dev] [PATCH 03/33] app/testeventdev: add eventdev test registration framework

2017-06-23 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Sunday, May 28, 2017 8:58 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Eads, Gage > ; > nipun.gu...@nxp.com; Vangati, Narender ; Rao, > Nikhil > ; gprathyu...@caviumnetworks.com; J

Re: [dpdk-dev] [PATCH 01/33] app/testeventdev: introduce dpdk-test-eventdev application

2017-06-23 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Sunday, May 28, 2017 8:58 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Eads, Gage > ; > nipun.gu...@nxp.com; Vangati, Narender ; Rao, > Nikhil > ; gprathyu...@caviumnetworks.com; J

Re: [dpdk-dev] [PATCH 00/33] introduce generic eventdev test application framework

2017-06-23 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Sunday, May 28, 2017 8:58 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Eads, Gage > ; > nipun.gu...@nxp.com; Vangati, Narender ; Rao, > Nikhil > ; gprathyu...@caviumnetworks.com; J

Re: [dpdk-dev] TAP PMD does not work in 17.05

2017-06-23 Thread Pascal Mazon
Hi Chillance, Ferruh, Can you give the complete command line you used, with output? (typically, are you using the remote feature) As Ferruh said, it may be that you don't have the module loaded. However in that case there should have been an error message earlier, like "Unable to create TAP i

Re: [dpdk-dev] TAP PMD does not work in 17.05

2017-06-23 Thread Ferruh Yigit
On 6/22/2017 8:05 AM, Chillance Zen wrote: > it always says something like this: > > PMD: tap1234: ioctl(35092) failed with error: No such device > PMD: Add queue to TAP tap1234 for qid 0 > PMD: tap1234: ioctl(35108) failed with error: Cannot assign requested > address > PMD: tun_alloc(tap1234, 0)

[dpdk-dev] Drop pkts whenever port link status changes

2017-06-23 Thread Karthikraj palanichamy
Hi! I am using DPDK to develop a delay measurement application. I put a timestamp in the packet and call rte_eth_tx_burst(). The receiving end would just loopback the packet. Using the timestamp that I had put, and the current time, I am able to calculate the delay in the network. But when

[dpdk-dev] [PATCH v2] net/i40e: fix division by 0 error

2017-06-23 Thread Yong Wang
In function i40e_vsi_config_tc_queue_mapping(), if 'enabled_tcmap' is 0, 'total_tc' might be 0. Then 'total_tc' might be used in a division by 0 in "qpnum_per_tc = i40e_align_floor(vsi->nb_qps / total_tc)". Fix it by changing 'total_tc' from 0 to 1 just as func i40e_vsi_update_queue_mapping() does.

Re: [dpdk-dev] mlx debug build error with clang

2017-06-23 Thread Ferruh Yigit
On 6/16/2017 3:49 PM, Ferruh Yigit wrote: > On 6/16/2017 1:58 PM, Ferruh Yigit wrote: >> On 6/16/2017 1:19 PM, Adrien Mazarguil wrote: >>> Hi Ferruh, >>> >>> On Tue, Jun 13, 2017 at 04:32:03PM +0100, Ferruh Yigit wrote: Hi Adrien, Nelio, I am getting following build error [1] with cl

Re: [dpdk-dev] [PATCH] net/i40e: avoid PCI probing failure when using bogus sfp

2017-06-23 Thread Ferruh Yigit
On 6/23/2017 10:25 AM, Wu, Jingjing wrote: > > >> -Original Message- >> From: Olivier Matz [mailto:olivier.m...@6wind.com] >> Sent: Thursday, June 15, 2017 5:09 PM >> To: dev@dpdk.org; Wu, Jingjing ; Zhang, Helin >> >> Cc: Xing, Beilei ; Richardson, Bruce >> >> Subject: [PATCH] net/i40

Re: [dpdk-dev] [PATCH] mbuf: reduce pktmbuf init cycles

2017-06-23 Thread Jerin Jacob
-Original Message- > Date: Fri, 23 Jun 2017 11:42:30 +0200 > From: Olivier Matz > To: Jerin Jacob > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] mbuf: reduce pktmbuf init cycles > X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) > > On Mon, 5 Jun 2017 22:08:07 +0530

Re: [dpdk-dev] [PATCH 1/2] net/ark: allow unique user data for each port in extension calls

2017-06-23 Thread Shepard Siegel
Hi Ferruh, I was absent from the code review John Miller and Ed Czeck held for earlier this week for this patch set. John and Ed are both on a long weekend this weekend. If my reply below is correct and sufficient, please ack this patch set. Otherwise, no reply is needed and please hold this open

Re: [dpdk-dev] [PATCH] net/i40e: fix param check to avoid division by 0

2017-06-23 Thread Wu, Jingjing
From: wang.yon...@zte.com.cn [mailto:wang.yon...@zte.com.cn] Sent: Tuesday, June 20, 2017 3:48 PM To: Wu, Jingjing Cc: dev@dpdk.org; Zhang, Helin Subject: RE: [PATCH] net/i40e: fix param check to avoid division by 0   > RE: [PATCH] net/i40e: fix param check to avoid division by 0 > > > >

Re: [dpdk-dev] [PATCH 00/10] NXP DPAA2 PMD changes

2017-06-23 Thread Ferruh Yigit
On 6/22/2017 2:57 PM, Hemant Agrawal wrote: > This patch series address some of the issues identified during testing on > latest code. > Last patch adds the support for multi-segment frames. > > Hemant Agrawal (9): > net/dpaa2: set the eth driver from dpaa2 driver > net/dpaa2: set data align

Re: [dpdk-dev] [PATCH v2 2/9] test/crypto: fix wrong AAD setting

2017-06-23 Thread Trahe, Fiona
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, June 22, 2017 1:02 PM > To: Doherty, Declan ; Trahe, Fiona > > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH v2 2/9] test/crypto: fix wrong AAD setting > > AAD should not point at IV f

Re: [dpdk-dev] [PATCH] mbuf: reduce pktmbuf init cycles

2017-06-23 Thread Olivier Matz
On Mon, 5 Jun 2017 22:08:07 +0530, Jerin Jacob wrote: > There is no need for initializing the complete > packet buffer with zero as the packet data area will be > overwritten by the NIC Rx HW anyway. > > The testpmd configures the packet mempool > with around 180k buffers with > 2176B size. In

[dpdk-dev] DPDK techboard minutes of June 21

2017-06-23 Thread Thomas Monjalon
The last Technical Board meeting was held on June 21. Attendees: Bruce Richardson Hemant Agrawal Jerin Jacob Keith Wiles Kevin Traynor Konstantin Ananyev Olivier Matz Stephen Hemminger Thomas Monjalon Yuanhan Liu *

Re: [dpdk-dev] [PATCH] net/i40e: avoid PCI probing failure when using bogus sfp

2017-06-23 Thread Wu, Jingjing
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Thursday, June 15, 2017 5:09 PM > To: dev@dpdk.org; Wu, Jingjing ; Zhang, Helin > > Cc: Xing, Beilei ; Richardson, Bruce > > Subject: [PATCH] net/i40e: avoid PCI probing failure when using bogus sfp > >

Re: [dpdk-dev] [PATCH 1/2] net/ark: allow unique user data for each port in extension calls

2017-06-23 Thread Ferruh Yigit
On 6/22/2017 1:30 PM, John Miller wrote: > Provide unique user data pointer in the extension calls for > each port. Hi John, Can you please give more details about why this is done. I can see in adapter data user_data pointer kept per port now, but why? What was observed with previous code? If th

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix flow director for IPv6

2017-06-23 Thread Ferruh Yigit
On 6/22/2017 10:30 AM, Beilei Xing wrote: > After adding a fdir rule for IPv6 with input set TC, IPv6 packets > with the specific TC can't be assigned the right queue. > The root cause is that TC is parsed wrongly, this patch fixes > TC parsing problem. > > Fixes: 7d83c152a207 ("net/i40e: parse fl

[dpdk-dev] [PATCH 5/6] service core: add unit tests

2017-06-23 Thread Harry van Haaren
Add a bunch of unit tests, to ensure that the service core functions are operating as expected. As part of these tests a dummy service is registered which allows identifying if a service callback has been invoked by using the CPU tick counter. This allows identifying if functions to start and stop

[dpdk-dev] [PATCH 6/6] service cores: enable event/sw with service

2017-06-23 Thread Harry van Haaren
This commit shows how easy it is to enable a specific DPDK component with a service callback, in order to get CPU cycles for it. The beauty of this method is that the service is unaware of how much CPU time it is getting - the application can decide how to split and slice cores and map them to the

[dpdk-dev] [PATCH 3/6] service cores: EAL init changes

2017-06-23 Thread Harry van Haaren
This commit shows the changes required in rte_eal_init() to transparently launch the service threads. The threads are launched into the service worker functions here because after rte_eal_init() the application is not gauranteed to call any other DPDK API. As the registration of services happens a

[dpdk-dev] [PATCH 4/6] service cores: mark cores in lcore config as RTE

2017-06-23 Thread Harry van Haaren
Mark these cores as RTE available by default Signed-off-by: Harry van Haaren --- lib/librte_eal/common/eal_common_lcore.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/librte_eal/common/eal_common_lcore.c index 84fa0cb..0db1555 100644 --- a/l

[dpdk-dev] [PATCH 2/6] service cores: coremask parsing

2017-06-23 Thread Harry van Haaren
Add logic for parsing a coremask from EAL, which allows the application to be unaware of the cores being taken from its coremask. Signed-off-by: Harry van Haaren --- lib/librte_eal/common/eal_common_options.c | 78 ++ 1 file changed, 78 insertions(+) diff --git a/lib

[dpdk-dev] [PATCH 1/6] service cores: header and implementation

2017-06-23 Thread Harry van Haaren
Add header files, update .map files with new service functions, and add the service header to the doxygen for building. This service header API allows DPDK to use services as a concept of something that requires CPU cycles. An example is a PMD that runs in software to schedule events, where a hard

Re: [dpdk-dev] [PATCH v2] librte_cmdline: fix parsing initialisation

2017-06-23 Thread Olivier Matz
Hi Adrien, On Thu, 15 Jun 2017 12:15:48 +0200, Adrien Mazarguil wrote: > From: "Bernard.Iremonger" > > The dyn_tokens array is initialised at the beginning of the cmdline_parse > function. However when the inst_num variable is incremented later in the > function the dyn_tokens array is not rei

Re: [dpdk-dev] [PATCH v1] ring: fix return value for sc and mc dequeue

2017-06-23 Thread Olivier Matz
Hi Anand, On Fri, 2 Jun 2017 11:59:51 +0530, Anand B Jyoti wrote: > The error return code for rte_ring_sc_dequeue_bulk() and > rte_ring_mc_dequeue_bulk() function should be -ENOENT rather > than -ENOBUFS as described in the function description. Fixes: cfa7c9e6fc1f ("ring: make bulk and burst

Re: [dpdk-dev] [PATCH v3 0/9] bus/pci: remove PCI bus from EAL

2017-06-23 Thread Gaëtan Rivet
Hi Jianfeng, On Fri, Jun 23, 2017 at 11:29:46AM +0800, Tan, Jianfeng wrote: > Hi Gaetan, > > Do you (or anyone else) have plan to move vdev bus into drivers/bus/. > It is in the roadmap for the DPDK, but I haven't planned to do it. > Thanks, > Jianfeng > > On 6/21/2017 7:36 AM, Gaetan Rivet w

Re: [dpdk-dev] Project move under DPDK.org umbrella.

2017-06-23 Thread Thomas Monjalon
Hi, 22/06/2017 23:58, Melik-Adamyan, Areg: > Per our discussion within Intel, I am sending official request to DPDK > community to include our cloud network function framework YANFF - > https://www.github.com/intel-go/yanff to DPDK.org. As it is using DPDK > underneath and provides higher level

Re: [dpdk-dev] [PATCH] eal: don't advertise a physical address when no hugepages

2017-06-23 Thread Olivier Matz
Hi Jan, On Sat, 10 Jun 2017 10:31:22 +0200, Jan Blunck wrote: > On Fri, Jun 9, 2017 at 10:29 AM, Olivier Matz wrote: > > When populating a mempool with a virtual memory area, the mempool > > library expects to be able to get the physical address of each page. > > > > When started with --no-huge,

Re: [dpdk-dev] DPDK drivers should not use kernel version

2017-06-23 Thread Hemant Agrawal
On 6/21/2017 9:58 PM, Stephen Hemminger wrote: Looking at some other issues, I noticed that both the TAP and MLX5 device drivers are looking at kernel version through uname. Although this may seem like a good way to deal with kernel API changes, it is not reliable. Enterprise kernel distro vend

[dpdk-dev] [PATCH] doc: update ipv4 multicast sample application guide

2017-06-23 Thread Hemant Agrawal
Add a note to indicate that only first four ports can be tested with this application. Signed-off-by: Hemant Agrawal --- doc/guides/sample_app_ug/ipv4_multicast.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/sample_app_ug/ipv4_multicast.rst b/doc/guides/sample_app_ug/i

Re: [dpdk-dev] [PATCH] ether: add support for vtune task tracing

2017-06-23 Thread Galanov, Dmitry
Hi Konstantin, We are planning to use Intel ITT https://software.intel.com/en-us/node/544195 for tracing wasted cycle iterations. The dependency on that library will only be required if user decides to enable that tracing by setting that in CONFIG_RTE_ETHDEV_TRACE_WASTED_RX_ITERATIONS=y. We cur