Re: [dpdk-dev] [PATCH v3] net/mlx5: support device removal event

2017-09-06 Thread Adrien Mazarguil
Hi Matan, On Tue, Sep 05, 2017 at 01:36:13PM +, Matan Azrad wrote: > Hi Adrien > > > -Original Message- > > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > Sent: Tuesday, September 5, 2017 3:02 PM > > To: Matan Azrad > > Cc: Nélio Laranjeiro ; dev@dpdk.org > > Subject:

[dpdk-dev] [PATCH v2] service: fix service lcore stop function

2017-09-06 Thread Guduri Prathyusha
lcore_states store the state of the lcore. Fixing the invalid dereference of lcore_states with service number Unit test case service_lcore_start_stop fails with the above fix. Service core was stopped without stopping the service. This commit fixes the test by adding negative and positive cases o

Re: [dpdk-dev] [PATCH 03/21] vhost: protect virtio_net device struct

2017-09-06 Thread Maxime Coquelin
Hi Tiwei, On 09/06/2017 03:15 AM, Tiwei Bie wrote: On Tue, Sep 05, 2017 at 01:00:42PM +0200, Maxime Coquelin wrote: On 09/05/2017 12:07 PM, Tiwei Bie wrote: On Tue, Sep 05, 2017 at 11:24:14AM +0200, Maxime Coquelin wrote: On 09/05/2017 06:45 AM, Tiwei Bie wrote: On Thu, Aug 31, 2017 at 11:50

Re: [dpdk-dev] long initialization of rte_eal_hugepage_init

2017-09-06 Thread Tan, Jianfeng
> -Original Message- > From: 王志克 [mailto:wangzh...@jd.com] > Sent: Wednesday, September 6, 2017 2:03 PM > To: Tan, Jianfeng; us...@dpdk.org; dev@dpdk.org > Subject: RE: long initialization of rte_eal_hugepage_init > > Do you mean "pagesize" when you say "size" option? I have specified th

Re: [dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush

2017-09-06 Thread Zhao1, Wei
Hi, Andrey > -Original Message- > From: Chilikin, Andrey > Sent: Wednesday, September 6, 2017 7:52 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Zhao1, Wei ; Xing, Beilei ; > Wu, Jingjing > Subject: RE: [dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush > > > > > -Original Mes

Re: [dpdk-dev] [PATCH 03/21] vhost: protect virtio_net device struct

2017-09-06 Thread Tiwei Bie
On Wed, Sep 06, 2017 at 09:15:47AM +0200, Maxime Coquelin wrote: > Hi Tiwei, > > On 09/06/2017 03:15 AM, Tiwei Bie wrote: > > On Tue, Sep 05, 2017 at 01:00:42PM +0200, Maxime Coquelin wrote: > > > On 09/05/2017 12:07 PM, Tiwei Bie wrote: > > > > On Tue, Sep 05, 2017 at 11:24:14AM +0200, Maxime Coq

Re: [dpdk-dev] long initialization of rte_eal_hugepage_init

2017-09-06 Thread Sergio Gonzalez Monroy
On 06/09/2017 05:35, Pavan Nikhilesh Bhagavatula wrote: On Wed, Sep 06, 2017 at 03:24:52AM +, 王志克 wrote: Hi All, I observed that rte_eal_hugepage_init() will take quite long time if there are lots of huge pages. Example I have 500 1G huge pages, and it takes about 2 minutes. That is too l

Re: [dpdk-dev] [PATCH 03/21] vhost: protect virtio_net device struct

2017-09-06 Thread Maxime Coquelin
Hi Stephen, On 09/06/2017 04:59 AM, Stephen Hemminger wrote: This lock has currently two purposes: 1. Prevent referencing freed virtio_dev struct in case of numa_realloc. 2. Protect vring pages against invalidation. For 2., it can be fixed by using the per-vq IOTLB lock (it was not the case in

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: increase port_id range

2017-09-06 Thread Hemant Agrawal
On 9/4/2017 11:27 AM, Zhiyong Yang wrote: Extend port_id definition from uint8_t to uint16_t in lib and drivers data structures, specifically rte_eth_dev_data. Modify the APIs, drivers and app using port_id at the same time except some drivers such as MLX4 and MLX5 due to fail to compile them in

Re: [dpdk-dev] [PATCH v2 3/4] common_base: extend RTE_MAX_ETHPORTS from 32 to 1024

2017-09-06 Thread Hemant Agrawal
On 9/4/2017 3:57 PM, Ananyev, Konstantin wrote: Hi Zhiong, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yang, Zhiyong Sent: Monday, September 4, 2017 11:05 AM To: Richardson, Bruce Cc: Yao, Lei A ; dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh ; Wiles, Ke

Re: [dpdk-dev] [PATCH v7 0/6] Reproducible build

2017-09-06 Thread Bruce Richardson
On Tue, Sep 05, 2017 at 10:15:29PM +0100, Luca Boccassi wrote: > On Tue, 2017-09-05 at 14:00 -0700, Stephen Hemminger wrote: > > On Tue,  5 Sep 2017 21:51:53 +0100 > > luca.bocca...@gmail.com wrote: > > > > > From: Luca Boccassi > > > > > > In the past couple of years a concerted effort among al

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: increase port_id range

2017-09-06 Thread Yang, Zhiyong
Hi, hemant: This patchset will focus on ethdev, don't touch rte_eventdev next version. Thanks Zhiyong > > */ > > typedef void (*eventdev_port_default_conf_get_t)(struct rte_eventdev *dev, > > - uint8_t port_id, struct rte_event_port_conf *port_conf); > > + uint

Re: [dpdk-dev] [PATCH v2 3/4] common_base: extend RTE_MAX_ETHPORTS from 32 to 1024

2017-09-06 Thread Yang, Zhiyong
Hi, Hemant: This patch will be dropped from the patchset next version. Thanks Zhiyong >> In testpmd, the following function will be called to validate the port_id. > >> So, It is necessary to modify the max port num RTE_MAX_ETHPORTS. > > > > There are quite a lot memory allocations (both

Re: [dpdk-dev] [PATCH v2] service: fix service lcore stop function

2017-09-06 Thread Van Haaren, Harry
> From: Guduri Prathyusha [mailto:gprathyu...@caviumnetworks.com] > Sent: Wednesday, September 6, 2017 8:16 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Guduri Prathyusha > Subject: [dpdk-dev] [PATCH v2] service: fix service lcore stop function > > lcore_states store the state of the lcore. Fi

Re: [dpdk-dev] long initialization of rte_eal_hugepage_init

2017-09-06 Thread 王志克
Thanks Jianfeng for your suggestion. I get the point. Br, Wang Zhike -Original Message- From: Tan, Jianfeng [mailto:jianfeng@intel.com] Sent: Wednesday, September 06, 2017 3:18 PM To: 王志克; us...@dpdk.org; dev@dpdk.org Subject: RE: long initialization of rte_eal_hugepage_init > ---

Re: [dpdk-dev] long initialization of rte_eal_hugepage_init

2017-09-06 Thread 王志克
Thanks Sergio. It really helps. Br, Wang Zhike -Original Message- From: Sergio Gonzalez Monroy [mailto:sergio.gonzalez.mon...@intel.com] Sent: Wednesday, September 06, 2017 3:37 PM To: Pavan Nikhilesh Bhagavatula; 王志克 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] long initialization of rte_ea

Re: [dpdk-dev] [PATCH v2] net/bonding: support bifurcated driver in eal cli using --vdev

2017-09-06 Thread gowrishankar muthukrishnan
Hi Thomas, I will rework on my patch with these suggestions and send new version. Thanks Declan and Gaëtan. Thank you Thomas too reminding me. Regards, Gowrishankar On Tuesday 05 September 2017 02:43 PM, Thomas Monjalon wrote: Ping - any news? 31/07/2017 16:34, Gaëtan Rivet: Hi Gowrishankar,

Re: [dpdk-dev] [PATCH v2 2/8] crypto/armv8: do not append digest

2017-09-06 Thread De Lara Guarch, Pablo
Hi Jerin, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, September 5, 2017 3:20 AM > To: Doherty, Declan ; Zhang, Roy Fan > ; jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > Subject: [PATCH v2 2/8] crypto/armv8: do not append digest > > W

Re: [dpdk-dev] [PATCH v2] service: fix service lcore stop function

2017-09-06 Thread Guduri Prathyusha
On Wed, Sep 06, 2017 at 08:53:30AM +, Van Haaren, Harry wrote: > > From: Guduri Prathyusha [mailto:gprathyu...@caviumnetworks.com] > > Sent: Wednesday, September 6, 2017 8:16 AM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org; Guduri Prathyusha > > Subject: [dpdk-dev] [PATCH v2] service: fix s

Re: [dpdk-dev] [PATCH v7 0/6] Reproducible build

2017-09-06 Thread Luca Boccassi
On Wed, 2017-09-06 at 09:46 +0100, Bruce Richardson wrote: > On Tue, Sep 05, 2017 at 10:15:29PM +0100, Luca Boccassi wrote: > > On Tue, 2017-09-05 at 14:00 -0700, Stephen Hemminger wrote: > > > On Tue,  5 Sep 2017 21:51:53 +0100 > > > luca.bocca...@gmail.com wrote: > > > > > > > From: Luca Boccass

Re: [dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush

2017-09-06 Thread Ferruh Yigit
On 9/1/2017 3:38 AM, Zhao1, Wei wrote: > HI, Ferruh > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Friday, September 1, 2017 12:18 AM >> To: Zhao1, Wei ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush >> >> On 8/24/2017 4:26 AM, Wei Zhao

Re: [dpdk-dev] [PATCH 2/3] ethdev: add new rte_mtr API for traffic metering and policing

2017-09-06 Thread Hemant Agrawal
Hi Cristian, On 9/4/2017 8:02 PM, Dumitrescu, Cristian wrote: ... + +/** + * Traffic metering algorithms + */ +enum rte_mtr_algorithm { + /**< Single Rate Three Color Marker (srTCM) - IETF RFC 2697. */ + RTE_MTR_SRTCM_RFC2697 = 0, + + /**< Two Rate Three Color Marker (trTCM)

Re: [dpdk-dev] [PATCH] net/cxgbe: fix memory leak

2017-09-06 Thread Rahul Lakkireddy
On Tuesday, September 09/05/17, 2017 at 14:16:57 +0530, Congwen Zhang wrote: > In function t4_wr_mbox_meat_timeout(), Dynamic memory stored > in 'temp' not free when the functon return, It possible memory > leak. > > Signed-off-by: Congwen Zhang > --- > drivers/net/cxgbe/base/t4_hw.c | 3 +++ >

Re: [dpdk-dev] [PATCH] timer: fix reset on service cores

2017-09-06 Thread Van Haaren, Harry
> From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Wednesday, August 23, 2017 4:19 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Pavan Nikhilesh > > Subject: [dpdk-dev] [PATCH] timer: fix reset on service cores > > - API rte_timer_reset() should be able to register timers

Re: [dpdk-dev] [PATCH v3] crypto/openssl: add openssl path for cross compile

2017-09-06 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Tuesday, September 5, 2017 10:03 AM > To: dev@dpdk.org; De Lara Guarch, Pablo > > Cc: hemant.agra...@nxp.com; Doherty, Declan > ; Akhil Goyal > Subject: [PATCH v3] crypto/openssl: add openssl path for cross co

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-06 Thread Ananyev, Konstantin
> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Wednesday, September 6, 2017 7:02 AM > To: Ananyev, Konstantin ; Thomas Monjalon > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new > offloads API > > Tuesda

[dpdk-dev] [PATCH] examples/ip_reassembly: use pktmbuf to create pool

2017-09-06 Thread Hemant Agrawal
From: Ashish Jain Use of rte_mempool_create() with the helper provided in librte_mbuf: rte_pktmbuf_pool_create(). This is the preferred way to create a mbuf pool else it may not work on implementation using the HW buffer pool Signed-off-by: Ashish Jain --- examples/ip_reassembly/main.c | 13 ++

Re: [dpdk-dev] [PATCH v2 16/18] doc: update NFP with PF support information

2017-09-06 Thread Ferruh Yigit
On 9/4/2017 5:03 PM, Alejandro Lucero wrote: > Hi John, > > Thanks for your review. I will modify the doc in next patch set version. > > I'll wait until Ferruh give me the green light for sending the new version. Patchset looks good to me, I can get it after mentioned documentation corrections d

[dpdk-dev] [PATCH v5] timer: allow timer reset on service cores

2017-09-06 Thread Pavan Nikhilesh
From: Pavan Bhagavatula API rte_timer_reset() should be able to register timers on service lcores as they are EAL threads. Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- This patch depends on http://dpdk.org/dev/patchwork/patch/27818/ lib/librte_timer/rte_timer.c | 3 ++- 1 fi

[dpdk-dev] [PATCH v2] timer: allow timer reset on service cores

2017-09-06 Thread Pavan Nikhilesh
From: Pavan Bhagavatula API rte_timer_reset() should be able to register timers on service lcores as they are EAL threads. Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- This patch depends on http://dpdk.org/dev/patchwork/patch/27818/ v2 changes: -modified the commit

Re: [dpdk-dev] [PATCH v3] crypto/openssl: add openssl path for cross compile

2017-09-06 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, September 6, 2017 10:27 AM > To: 'Akhil Goyal' ; dev@dpdk.org > Cc: hemant.agra...@nxp.com; Doherty, Declan > > Subject: RE: [PATCH v3] crypto/openssl: add openssl path for cross compile > > > > > -Original Mess

[dpdk-dev] new ethdev API proposal for port ownership

2017-09-06 Thread Thomas Monjalon
Hi all, A DPDK queue is designed to be polled by only one thread. And the port settings must be managed by only one entity/thread. These assumptions come from lockless design and management logic. - thank you Captain Obvious ;) That's why we can say that an ethdev port is owned by one enti

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix forward port ids setting

2017-09-06 Thread Thomas Monjalon
04/09/2017 11:52, Gaëtan Rivet: > On Mon, Sep 04, 2017 at 09:25:04AM +, Matan Azrad wrote: > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > > On Sun, Sep 03, 2017 at 04:19:07PM +0300, Matan Azrad wrote: > > > > Hi All > > > > I would like to bring up a discussion to complete this bug

[dpdk-dev] [PATCH v6 1/3] eal: introduce integer divide through reciprocal

2017-09-06 Thread Pavan Nikhilesh
From: Pavan Bhagavatula In some use cases of integer division, denominator remains constant and numerator varies. It is possible to optimize division for such specific scenarios. The librte_sched uses rte_reciprocal to optimize division so, moving it to eal/common would allow other libraries and

[dpdk-dev] [PATCH v6 3/3] test: add tests for reciprocal based division

2017-09-06 Thread Pavan Nikhilesh
From: Pavan Bhagavatula This commit provides a set of tests for verifying the correctness and performance of both unsigned 32 and 64bit reciprocal based division. Signed-off-by: Pavan Nikhilesh --- test/test/Makefile| 2 + test/test/test_reciprocal_division.c | 1

[dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal

2017-09-06 Thread Pavan Nikhilesh
From: Pavan Bhagavatula Currently, rte_reciprocal only supports unsigned 32bit divisors. This commit adds support for unsigned 64bit divisors. Rename unsigned 32bit specific functions appropriately and update librte_sched accordingly. Signed-off-by: Pavan Nikhilesh --- lib/librte_eal/bsdapp/e

Re: [dpdk-dev] [PATCH v3 2/2] crypto/openssl: key and algo updated during session init

2017-09-06 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Tuesday, September 5, 2017 6:58 AM > To: dev@dpdk.org; De Lara Guarch, Pablo > > Cc: hemant.agra...@nxp.com; Doherty, Declan > ; Akhil Goyal > Subject: [PATCH v3 2/2] crypto/openssl: key and algo updated durin

Re: [dpdk-dev] [PATCH] config: add openssl in arm64-dpaa2-linuxapp-gcc

2017-09-06 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Tuesday, September 5, 2017 6:59 AM > To: De Lara Guarch, Pablo ; > dev@dpdk.org; Doherty, Declan > Cc: hemant.agra...@nxp.com > Subject: Re: [PATCH] config: add openssl in arm64-dpaa2-linuxapp-gcc > > Hi Pablo

Re: [dpdk-dev] [PATCH] drivers/aesni_gcm: fix zero data operation

2017-09-06 Thread De Lara Guarch, Pablo
> -Original Message- > From: Rybalchenko, Kirill > Sent: Monday, September 4, 2017 2:14 PM > To: De Lara Guarch, Pablo ; Doherty, > Declan > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] drivers/aesni_gcm: fix zero data operation > > > > > -Original Message--

Re: [dpdk-dev] [PATCH v3] cryptodev: allocate driver structure statically

2017-09-06 Thread De Lara Guarch, Pablo
> -Original Message- > From: Rybalchenko, Kirill > Sent: Monday, September 4, 2017 11:39 AM > To: De Lara Guarch, Pablo ; Doherty, > Declan ; Trahe, Fiona ; > Jain, Deepak K ; Griffin, John > ; jerin.ja...@caviumnetworks.com; > akhil.go...@nxp.com; hemant.agra...@nxp.com > Cc: dev@dpdk.or

[dpdk-dev] [PATCH v4 0/5] flow classification library

2017-09-06 Thread Bernard Iremonger
DPDK works with packets, but some network administration tools works based on flow information. This library is suggested to provide a helper API to convert packet based information to the flow records. Basically the library consist of APIs to validate, create and destroy the rule and to query

[dpdk-dev] [PATCH v4 1/5] librte_table: fix acl entry add and delete functions

2017-09-06 Thread Bernard Iremonger
The rte_table_acl_entry_add() function was returning data from acl_memory instead of acl_rule_memory. It was also returning data from entry instead of entry_ptr. The rte_table_acl_entry_delete() function was returning data from acl_memory instead of acl_rule_memory. Fixes: 166923eb2f78 ("table: A

[dpdk-dev] [PATCH v4 2/5] librte_table: fix acl lookup function

2017-09-06 Thread Bernard Iremonger
The rte_table_acl_lookup() function was returning data from acl_memory instead of acl_rule_memory. Fixes: 166923eb2f78 ("table: ACL") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- lib/librte_table/rte_table_acl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib

[dpdk-dev] [PATCH v4 3/5] librte_flow_classify: add librte_flow_classify library

2017-09-06 Thread Bernard Iremonger
From: Ferruh Yigit The following library APIs's are implemented: rte_flow_classify_create rte_flow_classify_validate rte_flow_classify_destroy rte_flow_classify_query The following librte_table ACL API's are used: f_create to create a table ACL. f_add to add an ACL rule to the table. f_del to de

[dpdk-dev] [PATCH v4 4/5] examples/flow_classify: flow classify sample application

2017-09-06 Thread Bernard Iremonger
The flow_classify sample application exercises the following librte_flow_classify API's: rte_flow_classify_create rte_flow_classify_validate rte_flow_classify_destroy rte_flow_classify_query It sets up the IPv4 ACL field definitions. It creates table_acl and adds and deletes rules using the librt

[dpdk-dev] [PATCH v4 5/5] test: flow classify library unit tests

2017-09-06 Thread Bernard Iremonger
Add flow_classify_autotest program. Set up IPv4 ACL field definitions. Create table_acl for use by librte_flow_classify API's. Create an mbuf pool for use by rte_flow_classify_query. For each of the librte_flow_classify API's: add bad parameter tests add bad pattern tests add bad action tests add

Re: [dpdk-dev] [PATCH v2 16/18] doc: update NFP with PF support information

2017-09-06 Thread Alejandro Lucero
On Wed, Sep 6, 2017 at 10:53 AM, Ferruh Yigit wrote: > On 9/4/2017 5:03 PM, Alejandro Lucero wrote: > > Hi John, > > > > Thanks for your review. I will modify the doc in next patch set version. > > > > I'll wait until Ferruh give me the green light for sending the new > version. > > Patchset look

Re: [dpdk-dev] [PATCH v7 0/6] Reproducible build

2017-09-06 Thread Bruce Richardson
On Wed, Sep 06, 2017 at 10:10:34AM +0100, Luca Boccassi wrote: > On Wed, 2017-09-06 at 09:46 +0100, Bruce Richardson wrote: > > On Tue, Sep 05, 2017 at 10:15:29PM +0100, Luca Boccassi wrote: > > > On Tue, 2017-09-05 at 14:00 -0700, Stephen Hemminger wrote: > > > > On Tue,  5 Sep 2017 21:51:53 +0100

Re: [dpdk-dev] [PATCH v2] mbuf: use refcnt = 0 when debugging

2017-09-06 Thread Chas Williams
[Note: My former email address is going away eventually. I am moving the conversation to my other email address which is a bit more permanent.] On Mon, 2017-09-04 at 15:27 +0100, Radu Nicolau wrote: > > On 8/7/2017 5:11 PM, Charles (Chas) Williams wrote: > > After commit 8f094a9ac5d7 ("mbuf: set

Re: [dpdk-dev] [PATCH v2 3/3] net/mlx5: fix interrupt enable return value

2017-09-06 Thread Shachar Beiser
Hi , The problem was that the value ret was not set to 0. As a result we got a warning message: WARN("unable to arm interrupt on rx queue %d", rx_queue_id); The fix is ret =0; I was looking with Nelio for the right commits that this bug fixes I am pretty sur

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix forward port ids setting

2017-09-06 Thread Matan Azrad
Hi Jinging, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, September 6, 2017 1:21 PM > To: Gaëtan Rivet ; Matan Azrad > > Cc: Jingjing Wu ; dev@dpdk.org; Ori Kam > > Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix forward port ids setting

[dpdk-dev] [PATCH v5 0/8] Infrastructure to support octeontx HW mempool manager

2017-09-06 Thread Santosh Shukla
V5: Includes v4 review change, suggested by Olivier. v4: Include - mempool deprecation changes, refer [1], - patches are rebased against v17.11-rc0. v3: In order to support octeontx HW mempool manager, the common mempool layer must meet below condition. - Object start address should be block si

[dpdk-dev] [PATCH v5 1/8] mempool: remove unused flags argument

2017-09-06 Thread Santosh Shukla
* Remove redundant 'flags' API description from - __mempool_generic_put - __mempool_generic_get - rte_mempool_generic_put - rte_mempool_generic_get * Remove unused 'flags' argument from - rte_mempool_generic_put - rte_mempool_generic_get Signed-off-by: Santosh Shukla Signed-off-by: J

[dpdk-dev] [PATCH v5 2/8] mempool: change flags from int to unsigned int

2017-09-06 Thread Santosh Shukla
mp->flags is int and mempool API writes unsigned int value in 'flags', so fix the 'flags' data type. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- v4 --> v5: - Splitted v4 [01/07] to this as second patch. lib/librte_mempool/rte_mempool.c | 4 ++-- lib/librte_mempool/rte_mempool.

[dpdk-dev] [PATCH v5 3/8] mempool: add flags arg in xmem size and usage

2017-09-06 Thread Santosh Shukla
xmem_size and xmem_usage need to know the status of mempool flags, so add 'flags' arg in _xmem_size/usage() api. Following patch will make use of that. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- v4 --> v5: - Removed 'mp' param and replaced with 'flags' param for xmem_size/_u

[dpdk-dev] [PATCH v5 6/8] mempool: detect physical contiguous object in pool

2017-09-06 Thread Santosh Shukla
The memory area containing all the objects must be physically contiguous. Introducing MEMPOOL_F_CAPA_PHYS_CONTIG flag for such use-case. The flag useful to detect whether pool area has sufficient space to fit all objects. If not then return -ENOSPC. This way, we make sure that all object within a

[dpdk-dev] [PATCH v5 4/8] doc: remove mempool notice

2017-09-06 Thread Santosh Shukla
Removed mempool deprecation notice and updated change info in release_17.11. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- v4 --> v5: - Since mp param replaced by flags param in patch [03/08], incorporated same change in doc. doc/guides/rel_notes/deprecation.rst | 9 ---

[dpdk-dev] [PATCH v5 7/8] mempool: introduce block size align flag

2017-09-06 Thread Santosh Shukla
Some mempool hw like octeontx/fpa block, demands block size (/total_elem_sz) aligned object start address. Introducing an MEMPOOL_F_BLK_ALIGNED_OBJECTS flag. If this flag is set: - Align object start address(vaddr) to a multiple of total_elt_sz. - Allocate one additional object. Additional object

[dpdk-dev] [PATCH v5 5/8] mempool: get the mempool capability

2017-09-06 Thread Santosh Shukla
Allow mempool driver to advertise his pool capability. For that pupose, an api(rte_mempool_ops_get_capabilities) and ->get_capability() handler has been introduced. - Upon ->get_capabilities() call, mempool driver will advertise his capability by oring to mempool 'flags'. Signed-off-by: Santosh Sh

[dpdk-dev] [PATCH v5 8/8] mempool: update range info to pool

2017-09-06 Thread Santosh Shukla
HW pool manager e.g. Octeontx SoC demands s/w to program start and end address of pool. Currently, there is no such handle in external mempool. Introducing rte_mempool_update_range handle which will let HW(pool manager) to know when common layer selects hugepage: For each hugepage - update its star

Re: [dpdk-dev] [PATCH v2] mbuf: use refcnt = 0 when debugging

2017-09-06 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chas Williams > Sent: Wednesday, September 6, 2017 11:46 AM > To: Nicolau, Radu ; dev@dpdk.org > Cc: olivier.m...@6wind.com; cw8...@att.com > Subject: Re: [dpdk-dev] [PATCH v2] mbuf: use refcnt = 0 when debugging

Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal

2017-09-06 Thread Kevin Traynor
On 09/06/2017 11:21 AM, Pavan Nikhilesh wrote: > From: Pavan Bhagavatula > > Currently, rte_reciprocal only supports unsigned 32bit divisors. This > commit adds support for unsigned 64bit divisors. > > Rename unsigned 32bit specific functions appropriately and update > librte_sched accordingly.

Re: [dpdk-dev] new ethdev API proposal for port ownership

2017-09-06 Thread Adrien Mazarguil
On Wed, Sep 06, 2017 at 12:17:48PM +0200, Thomas Monjalon wrote: > Hi all, > > A DPDK queue is designed to be polled by only one thread. > And the port settings must be managed by only one entity/thread. > These assumptions come from lockless design and management logic. > - thank you Captai

Re: [dpdk-dev] [PATCH v2] mbuf: use refcnt = 0 when debugging

2017-09-06 Thread Chas Williams
On Wed, 2017-09-06 at 11:58 +, Ananyev, Konstantin wrote: > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chas Williams > > Sent: Wednesday, September 6, 2017 11:46 AM > > To: Nicolau, Radu ; dev@dpdk.org > > Cc: olivier.m...@6wind.com; cw8...@att.com

Re: [dpdk-dev] [PATCH 7/9] net/virtio: rationalize setting of Rx/Tx handlers

2017-09-06 Thread Olivier MATZ
On Fri, Sep 01, 2017 at 08:31:06PM +0800, Yuanhan Liu wrote: > On Fri, Sep 01, 2017 at 11:52:17AM +0200, Olivier MATZ wrote: > > > > @@ -1534,7 +1554,6 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev) > > > > RTE_BUILD_BUG_ON(RTE_PKTMBUF_HEADROOM < sizeof(struct > > > > virtio_net_hdr_m

Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal

2017-09-06 Thread Pavan Nikhilesh Bhagavatula
On Wed, Sep 06, 2017 at 01:28:24PM +0100, Kevin Traynor wrote: > On 09/06/2017 11:21 AM, Pavan Nikhilesh wrote: > > From: Pavan Bhagavatula > > > > Currently, rte_reciprocal only supports unsigned 32bit divisors. This > > commit adds support for unsigned 64bit divisors. > > > > Rename unsigned 32b

Re: [dpdk-dev] [PATCH] net/cxgbe: fix memory leak

2017-09-06 Thread Ferruh Yigit
On 9/6/2017 10:25 AM, Rahul Lakkireddy wrote: > On Tuesday, September 09/05/17, 2017 at 14:16:57 +0530, Congwen Zhang wrote: >> In function t4_wr_mbox_meat_timeout(), Dynamic memory stored >> in 'temp' not free when the functon return, It possible memory >> leak. Fixes: 3bd122eef2cc ("cxgbe/base:

Re: [dpdk-dev] [PATCH] eventdev: add dev id checks to config functions

2017-09-06 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, September 4, 2017 6:21 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: Re: [PATCH] eventdev: add dev id checks to config functions > > -Original Message- > > Date: Mon, 24 Jul 2017 13:48:20 +0100 > > From

[dpdk-dev] [PATCH v3] doc: update NFP with PF support information

2017-09-06 Thread Alejandro Lucero
From: root NFP PMD has now support for both, PF and VFs. This patch updates the guide and give some information about implications. Signed-off-by: root --- doc/guides/nics/nfp.rst | 78 + 1 file changed, 59 insertions(+), 19 deletions(-) diff --

[dpdk-dev] [PATCH v2] devtools: rework abi checker script

2017-09-06 Thread Olivier Matz
The intiatial version of the script had some limitations: - cannot work on a non-clean workspace - environment variables are not documented - no compilation log in case of failure - return success even it abi is incompatible This patch addresses these issues and rework the code. Signed-off-by: Ol

Re: [dpdk-dev] [PATCH v2] mbuf: use refcnt = 0 when debugging

2017-09-06 Thread Ananyev, Konstantin
> -Original Message- > From: Chas Williams [mailto:3ch...@gmail.com] > Sent: Wednesday, September 6, 2017 2:56 PM > To: Ananyev, Konstantin ; Nicolau, Radu > ; dev@dpdk.org > Cc: olivier.m...@6wind.com; cw8...@att.com > Subject: Re: [dpdk-dev] [PATCH v2] mbuf: use refcnt = 0 when debuggi

Re: [dpdk-dev] [PATCH v3] doc: update NFP with PF support information

2017-09-06 Thread Alejandro Lucero
It seems I did not commit with the right signature. I will send it again. Sorry about this. On Wed, Sep 6, 2017 at 3:47 PM, Alejandro Lucero < alejandro.luc...@netronome.com> wrote: > From: root > > NFP PMD has now support for both, PF and VFs. This patch updates > the guide and give some infor

Re: [dpdk-dev] [PATCH] eventdev: add dev id checks to config functions

2017-09-06 Thread Jerin Jacob
-Original Message- > Date: Wed, 6 Sep 2017 14:45:29 + > From: "Van Haaren, Harry" > To: Jerin Jacob > CC: "dev@dpdk.org" > Subject: RE: [PATCH] eventdev: add dev id checks to config functions > > > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > Sent: Monday, September

[dpdk-dev] [PATCH v4 1/2] net/mlx5: link status update separation

2017-09-06 Thread Matan Azrad
Link status is sometimes inconsistent during a LSC event. When it occurs, the PMD refrains from immediately notifying the application; instead, an alarm is scheduled to check link status later and notify the application once it has settled. In the previous code the alarm callback calls to the inte

[dpdk-dev] [PATCH v4 2/2] net/mlx5: support device removal event

2017-09-06 Thread Matan Azrad
Extend the LSC event handling to support the device removal as well. The mlx5 event handling has been made capable of receiving and signaling several event types at once. This support includes next: 1. Removal event detection according to the user configuration. 2. Calling to all registered mlx5

[dpdk-dev] [PATCH] net/i40e: fix mirror rule reset when port is stopped

2017-09-06 Thread Wei Dai
When an i40e PF port is stopped, all mirror rules should be removed. All rule related SW and HW resources should also be removed. All of them are should be removed by calling i40e_mirror_rule_reset( ). Fixes: a4def5edf0fc ("i40e: enable port mirroring") Cc: sta...@dpdk.org Signed-off-by: Wei Dai

Re: [dpdk-dev] Regarding changing RTE_RING_SZ_MASK to 0x7FFFFFFF

2017-09-06 Thread Olivier MATZ
Hi Venky, Sorry for the late reply. On Mon, Aug 14, 2017 at 11:01:38AM -0700, Venkatesh Nuthula wrote: > Hi all, > > I am a newbie to DPDK and in one of the applications I am building , I am > trying to capture more than 150M packets and save them to file. I noticed > that with packet count >

[dpdk-dev] [PATCH v3] doc: update NFP with PF support information

2017-09-06 Thread Alejandro Lucero
NFP PMD has now support for both, PF and VFs. This patch updates the guide and give some information about implications. Signed-off-by: Alejandro Lucero --- doc/guides/nics/nfp.rst | 78 + 1 file changed, 59 insertions(+), 19 deletions(-) diff --g

Re: [dpdk-dev] [PATCH v4 2/2] net/mlx5: support device removal event

2017-09-06 Thread Adrien Mazarguil
On Wed, Sep 06, 2017 at 06:03:58PM +0300, Matan Azrad wrote: > Extend the LSC event handling to support the device removal as well. > > The mlx5 event handling has been made capable of receiving and > signaling several event types at once. > > This support includes next: > 1. Removal event detect

Re: [dpdk-dev] [PATCH v4 1/2] net/mlx5: link status update separation

2017-09-06 Thread Adrien Mazarguil
On Wed, Sep 06, 2017 at 06:03:57PM +0300, Matan Azrad wrote: > Link status is sometimes inconsistent during a LSC event. > When it occurs, the PMD refrains from immediately notifying > the application; instead, an alarm is scheduled to check > link status later and notify the application once it ha

Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal

2017-09-06 Thread Kevin Traynor
On 09/06/2017 03:41 PM, Pavan Nikhilesh Bhagavatula wrote: > On Wed, Sep 06, 2017 at 01:28:24PM +0100, Kevin Traynor wrote: >> On 09/06/2017 11:21 AM, Pavan Nikhilesh wrote: >>> From: Pavan Bhagavatula >>> >>> Currently, rte_reciprocal only supports unsigned 32bit divisors. This >>> commit adds su

Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal

2017-09-06 Thread Stephen Hemminger
On Wed, 6 Sep 2017 20:11:34 +0530 Pavan Nikhilesh Bhagavatula wrote: > On Wed, Sep 06, 2017 at 01:28:24PM +0100, Kevin Traynor wrote: > > On 09/06/2017 11:21 AM, Pavan Nikhilesh wrote: > > > From: Pavan Bhagavatula > > > > > > Currently, rte_reciprocal only supports unsigned 32bit divisors. Th

Re: [dpdk-dev] [PATCH v7 1/9] eal/pci: export match function

2017-09-06 Thread Ferruh Yigit
On 8/31/2017 4:26 AM, Santosh Shukla wrote: > Export rte_pci_match() function as it needed in the followup patch. > > Signed-off-by: Santosh Shukla > Signed-off-by: Jerin Jacob > Acked-by: Maxime Coquelin > --- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 7 +++ > lib/librte_eal/co

[dpdk-dev] [PATCH v2] eventdev: clarify usage of forward and release ops

2017-09-06 Thread Tim McDaniel
Update doxygen to make it clear that RTE_EVENT_OP_FORWARD and RTE_EVENT_OP_RELEASE may only be enqueued to the same port that the original event was dequeued from. Signed-off-by: Tim McDaniel --- lib/librte_eventdev/rte_eventdev.h | 14 +- 1 file changed, 13 insertions(+), 1 deletion

Re: [dpdk-dev] [RFC PATCH 0/1] IPSec Inline and look aside crypto offload

2017-09-06 Thread Jerin Jacob
-Original Message- > Date: Thu, 31 Aug 2017 15:09:45 +0100 > From: Radu Nicolau > To: Thomas Monjalon , Akhil Goyal > CC: dev@dpdk.org, bor...@mellanox.com, declan.dohe...@intel.com, > avia...@mellanox.com, sandeep.ma...@nxp.com, hemant.agra...@nxp.com, > pablo.de.lara.gua...@intel.com

Re: [dpdk-dev] [PATCH 2/7] ethdev: add GTP item

2017-09-06 Thread Adrien Mazarguil
Hi Beilei, On Fri, Aug 25, 2017 at 03:50:25PM +0800, Beilei Xing wrote: > This patch adds GTP items to generic rte flow. > > Signed-off-by: Beilei Xing Thanks, several comments below. > --- > doc/guides/prog_guide/rte_flow.rst | 12 > lib/librte_ether/rte_flow.h| 31 +

Re: [dpdk-dev] [PATCH 3/7] app/testpmd: add GTP fields to flow command

2017-09-06 Thread Adrien Mazarguil
On Fri, Aug 25, 2017 at 03:50:26PM +0800, Beilei Xing wrote: > This patch exposes the following item fields through the flow command: > > - GTP TEID > > Signed-off-by: Beilei Xing Minor nits, see below. > --- > app/test-pmd/cmdline_flow.c | 22 ++ > app/tes

[dpdk-dev] [PATCH] doc: add arm64 to linux_gsg

2017-09-06 Thread Brian Brooks
Signed-off-by: Brian Brooks Reviewed-by: Song Zhu --- doc/guides/linux_gsg/build_dpdk.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/linux_gsg/build_dpdk.rst b/doc/guides/linux_gsg/build_dpdk.rst index e32afd5f8..5452041f3 100644 --- a/doc/guides/linux_gs

Re: [dpdk-dev] [PATCH v2 00/18] net/nfp: add PF support

2017-09-06 Thread Ferruh Yigit
On 9/1/2017 3:12 PM, Alejandro Lucero wrote: > NFP PMD has just had support for SRIOV VFs until now. This patch set adds > support for the PF, but just for being used as another DPDK port. No VF > management is added by now. > > NFP is a programmable device and it supports virtual NICs (vNICs) thr

Re: [dpdk-dev] [PATCH v3] doc: update NFP with PF support information

2017-09-06 Thread Ferruh Yigit
On 9/6/2017 4:14 PM, Alejandro Lucero wrote: > NFP PMD has now support for both, PF and VFs. This patch updates > the guide and give some information about implications. > > Signed-off-by: Alejandro Lucero Reviewed-by: John McNamara Applied to dpdk-next-net/master, thanks. (Carried Reviewed-by

Re: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure for meson & ninja builds

2017-09-06 Thread Bruce Richardson
On Mon, Sep 04, 2017 at 02:51:01PM +0100, Bruce Richardson wrote: > On Mon, Sep 04, 2017 at 02:36:42PM +0100, Van Haaren, Harry wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce > > > Richardson Sent: Friday, September 1, 2017 11:04 AM To: > > > dev@dpdk.org Cc: Richardson, Br

Re: [dpdk-dev] [PATCH 3/3] rte_flow: add new action for traffic metering and policing

2017-09-06 Thread Adrien Mazarguil
Hi Cristian, This commit should probably come first in the series since the rest relies on it, right? Subject line does not conform past commits, it should start with "ethdev:" and not mention "rte_flow" (use "flow API"). On Sat, Aug 26, 2017 at 01:06:13AM +0100, Cristian Dumitrescu wrote: > Sig

[dpdk-dev] [RFC] Include what you use

2017-09-06 Thread Stephen Hemminger
I tried running iwyu on DPDK source and discovered lots of extra includes (not surprising). https://github.com/include-what-you-use/include-what-you-use/blob/master/README.md Some example output: /home/shemminger/dpdk/base/lib/librte_eal/linuxapp/eal/eal.c should remove these lines: - #includ

Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal

2017-09-06 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, September 6, 2017 4:37 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Kevin Traynor ; Dumitrescu, Cristian > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant

Re: [dpdk-dev] [PATCH 03/21] vhost: protect virtio_net device struct

2017-09-06 Thread Maxime Coquelin
On 09/06/2017 09:30 AM, Tiwei Bie wrote: On Wed, Sep 06, 2017 at 09:15:47AM +0200, Maxime Coquelin wrote: Hi Tiwei, On 09/06/2017 03:15 AM, Tiwei Bie wrote: On Tue, Sep 05, 2017 at 01:00:42PM +0200, Maxime Coquelin wrote: On 09/05/2017 12:07 PM, Tiwei Bie wrote: On Tue, Sep 05, 2017 at 11:

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: increase port_id range

2017-09-06 Thread Yang, Zhiyong
Hi, Ed: Ok. Thanks a lot for your reminder. Thanks Zhiyong From: Ed Czeck [mailto:ed.cz...@atomicrules.com] Sent: Thursday, September 7, 2017 3:21 AM To: Yang, Zhiyong Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh ; Wiles, Keith ; Stephen Hemminger ; John Miller Subject:

Re: [dpdk-dev] [PATCH 03/21] vhost: protect virtio_net device struct

2017-09-06 Thread Tiwei Bie
On Wed, Sep 06, 2017 at 10:02:29PM +0200, Maxime Coquelin wrote: > On 09/06/2017 09:30 AM, Tiwei Bie wrote: > > On Wed, Sep 06, 2017 at 09:15:47AM +0200, Maxime Coquelin wrote: > > > Hi Tiwei, > > > > > > On 09/06/2017 03:15 AM, Tiwei Bie wrote: > > > > On Tue, Sep 05, 2017 at 01:00:42PM +0200, Ma

Re: [dpdk-dev] [PATCH 2/7] ethdev: add GTP item

2017-09-06 Thread Xing, Beilei
Hi Adrien, > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Thursday, September 7, 2017 12:03 AM > To: Xing, Beilei > Cc: Wu, Jingjing ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/7] ethdev: add GTP item > > Hi Beilei, > > On Fri, Aug 25, 20