[dpdk-dev] [PATCH v3] net/i40e: fix memory leak if VF init fails

2017-09-13 Thread Jingjing Wu
Cc: sta...@dpdk.org Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Jingjing Wu --- v3 change: - add new err branch to free aq_resp - fix indent v2 change: - free aq_resp at err_aq drivers/net/i40e/i40e_ethdev_vf.c | 13 - 1 file changed, 8 insertions(+), 5 de

Re: [dpdk-dev] [PATCH] net/mlx5: fix calculating TSO inline size

2017-09-13 Thread Nélio Laranjeiro
On Wed, Sep 13, 2017 at 05:05:14AM +, Shahaf Shuler wrote: > Tuesday, September 12, 2017 9:34 PM, Nélio Laranjeiro: > > > On Sep 12, 2017, at 12:24 AM, Nélio Laranjeiro > > >>> Is not it dangerous to assume inl will always be 4 bytes long? Why > > >>> not writing the real value instead? > > >>

Re: [dpdk-dev] [PATCH v2] net/i40e: fix mirror rule reset when port is stopped

2017-09-13 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Monday, September 11, 2017 10:46 AM > To: Dai, Wei ; Wu, Jingjing > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] net/i40e: fix mirror rule reset when port > is > stopped > > > > -Original Messag

[dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file

2017-09-13 Thread Yang, Qiming
Hi, Shijith VF init error will happen after apply your patch, error log as below. If revert your commit, all things work well. And this issue is not only occur in i40 VF but also ixgbe. Could you help to check it soon? [root@localhost app]# ./testpmd -c 7 -n 4 -- -i EAL: Detected 10 lcore(s) EA

Re: [dpdk-dev] git trees organization

2017-09-13 Thread Adrien Mazarguil
Hi, On Tue, Sep 12, 2017 at 09:32:07AM +0100, Bruce Richardson wrote: > On Tue, Sep 12, 2017 at 12:03:30AM +0200, Thomas Monjalon wrote: > > Hi all, > > > > As you know I am currently the only maintainer of the master tree. > > It is very convenient because I need to synchronize with others > > o

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-13 Thread Andrew Rybchenko
On 09/13/2017 09:37 AM, Shahaf Shuler wrote: Introduce a new API to configure Rx offloads. In the new API, offloads are divided into per-port and per-queue offloads. The PMD reports capability for each of them. Offloads are enabled using the existing DEV_RX_OFFLOAD_* flags. To enable per-port of

Re: [dpdk-dev] [PATCH v3 0/4] increase port_id range

2017-09-13 Thread Matej Vido
On 11.09.2017 12:23, Ferruh Yigit wrote: On 9/9/2017 3:47 PM, Zhiyong Yang wrote: port_id is currently defined as uint8_t, which is limited to the range 0 to 255. A larger range is required for vdev scalability. It is necessary for a redefinition of port_id to extend it from 1 bytes to 2 bytes.

Re: [dpdk-dev] [PATCH v3 0/4] increase port_id range

2017-09-13 Thread Yang, Zhiyong
Hi Matej, > -Original Message- > From: Matej Vido [mailto:v...@cesnet.cz] > Sent: Wednesday, September 13, 2017 4:14 PM > To: Yigit, Ferruh ; Yang, Zhiyong > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/4] increase port_id range > > On 11.09.2017 12:23, Ferruh Yigit wrote: > > On

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: introduce Tx queue offloads API

2017-09-13 Thread Andrew Rybchenko
On 09/13/2017 09:37 AM, Shahaf Shuler wrote: Introduce a new API to configure Tx offloads. In the new API, offloads are divided into per-port and per-queue offloads. The PMD reports capability for each of them. Offloads are enabled using the existing DEV_TX_OFFLOAD_* flags. To enable per-port of

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-13 Thread Andrew Rybchenko
On 09/13/2017 09:37 AM, Shahaf Shuler wrote: Introduce a new API to configure Rx offloads. In the new API, offloads are divided into per-port and per-queue offloads. The PMD reports capability for each of them. Offloads are enabled using the existing DEV_RX_OFFLOAD_* flags. To enable per-port of

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-13 Thread Eelco Chaudron
On 13/09/17 00:13, Thomas Monjalon wrote: 12/09/2017 22:29, Aaron Conole: Thomas Monjalon writes: 12/09/2017 16:50, Aaron Conole: Eelco Chaudron writes: Call the mlockall() function, to attempt to lock all of its process memory into physical RAM, and preventing the kernel from paging any

Re: [dpdk-dev] multi-process shared memory on PPC

2017-09-13 Thread Xueming(Steven) Li
HI Chao, Found a mmap MAP_SHARED issue in multi-process, the address returned seems to be a local malloc address, conflicts with other variable in secondary process, code: Mmap in primary process initiates a shared address: addr = mmap(NULL, page_size, PROT_WRITE, MAP_SHARED, cmd_fd, of

Re: [dpdk-dev] [PATCH v3 0/2] ethdev new offloads API

2017-09-13 Thread Andrew Rybchenko
On 09/13/2017 09:37 AM, Shahaf Shuler wrote: Tx offloads configuration is per queue. Tx offloads are enabled by default, and can be disabled using ETH_TXQ_FLAGS_NO* flags. This behaviour is not consistent with the Rx side where the Rx offloads configuration is per port. Rx offloads are disabled b

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-13 Thread Andrew Rybchenko
On 09/13/2017 11:49 AM, Andrew Rybchenko wrote: On 09/13/2017 09:37 AM, Shahaf Shuler wrote: Introduce a new API to configure Rx offloads. In the new API, offloads are divided into per-port and per-queue offloads. The PMD reports capability for each of them. Offloads are enabled using the exist

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-13 Thread Maxime Coquelin
On 09/12/2017 03:08 PM, Eelco Chaudron wrote: Call the mlockall() function, to attempt to lock all of its process memory into physical RAM, and preventing the kernel from paging any of its memory to disk. When using testpmd for performance testing, depending on the code path taken, we see a co

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-13 Thread Thomas Monjalon
I still think we must streamline ethdev API instead of complexifying. We should drop the big "configure everything" and configure offloads one by one, and per queue (the finer grain). More comments below 06/09/2017 11:33, Ananyev, Konstantin: > From: Shahaf Shuler [mailto:shah...@mellanox.com] >

Re: [dpdk-dev] [PATCH 1/2] net/sfc: free mbufs in bulks on EF10 native Tx datapath reap

2017-09-13 Thread Andrew Rybchenko
On 09/12/2017 09:26 PM, Ferruh Yigit wrote: On 9/8/2017 3:15 PM, Andrew Rybchenko wrote: From: Ivan Malov Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ef10_tx.c | 48 --- drivers/net/sfc/sfc_tweak.h | 3 +++

Re: [dpdk-dev] [PATCH 2/2] net/sfc: free mbufs in bulks on simple EF10 Tx datapath reap

2017-09-13 Thread Andrew Rybchenko
On 09/12/2017 09:28 PM, Ferruh Yigit wrote: On 9/8/2017 3:15 PM, Andrew Rybchenko wrote: From: Ivan Malov Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- doc/guides/nics/sfc_efx.rst | 4 +++- drivers/net/sfc/sfc_dp_tx.h | 2 ++ drivers/net/sfc/sfc_ef10_tx.c | 15 +

[dpdk-dev] [PATCH v2 1/2] net/sfc: free mbufs in bulks on EF10 native Tx datapath reap

2017-09-13 Thread Andrew Rybchenko
From: Ivan Malov Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/Makefile | 3 +++ drivers/net/sfc/sfc_ef10_tx.c | 48 --- drivers/net/sfc/sfc_tweak.h | 3 +++ 3 files changed, 47 insertions(+), 7 deletions(-) diff

[dpdk-dev] [PATCH v2 2/2] net/sfc: free mbufs in bulks on simple EF10 Tx datapath reap

2017-09-13 Thread Andrew Rybchenko
From: Ivan Malov Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- doc/guides/nics/sfc_efx.rst | 6 +- drivers/net/sfc/sfc_dp_tx.h | 2 ++ drivers/net/sfc/sfc_ef10_tx.c | 15 ++- drivers/net/sfc/sfc_ethdev.c | 6 ++ drivers/net/sfc/sfc_tx.c | 17 +++

Re: [dpdk-dev] [PATCH] Fix bash path in shebangs

2017-09-13 Thread Thomas Monjalon
27/07/2017 22:12, asom...@gmail.com: > From: Alan Somers > > "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. Why is it an issue? Can you run dpdk-setup.sh on a non-Linux system?

Re: [dpdk-dev] [PATCH v3 2/5] gso: add TCP/IPv4 GSO support

2017-09-13 Thread Ananyev, Konstantin
> > > + > > > +int > > > +gso_tcp4_segment(struct rte_mbuf *pkt, > > > + uint16_t gso_size, > > > + uint8_t ipid_delta, > > > + struct rte_mempool *direct_pool, > > > + struct rte_mempool *indirect_pool, > > > + struct rte_mbuf **pkts_out, > > > + u

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-13 Thread Thomas Monjalon
12/09/2017 15:08, Eelco Chaudron: > Call the mlockall() function, to attempt to lock all of its process > memory into physical RAM, and preventing the kernel from paging any > of its memory to disk. > > When using testpmd for performance testing, depending on the code path > taken, we see a couple

Re: [dpdk-dev] [PATCH v3 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-13 Thread Rao, Nikhil
On 9/12/2017 9:47 AM, Jerin Jacob wrote: -Original Message- --- a/lib/librte_eventdev/Makefile +++ b/lib/librte_eventdev/Makefile @@ -43,6 +43,7 @@ CFLAGS += $(WERROR_FLAGS) # library source files SRCS-y += rte_eventdev.c SRCS-y += rte_event_ring.c +SRCS-y += rte_event_eth_rx_adap

Re: [dpdk-dev] [PATCH v6 0/8] Infrastructure to support octeontx HW mempool manager

2017-09-13 Thread santosh
Hi Olivier, On Thursday 07 September 2017 09:00 PM, Santosh Shukla wrote: > v6: > Include v5 review change, suggested by Olivier. > Patches rebased on tip, commit:06791a4bcedf Are you ok with changeset in v6 series, as its blocking external mempool driver[1]. Thanks. [1] http://dpdk.org/ml/ar

Re: [dpdk-dev] [PATCH v4 0/2] Dynamically configure mempool handle

2017-09-13 Thread santosh
Hi Olivier, On Monday 11 September 2017 08:48 PM, Santosh Shukla wrote: > v4: > - Includes v3 review coment changes. > Patches rebased on 06791a4bce: ethdev: get the supported pools for a port are you fine with v4? Thanks.

[dpdk-dev] [PATCH 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-13 Thread Nikhil Rao
Add common APIs for configuring packet transfer from ethernet Rx queues to event devices across HW & SW packet transfer mechanisms. A detailed description of the adapter is contained in the header's comments. The adapter implementation uses eventdev PMDs to configure the packet transfer if HW supp

[dpdk-dev] [PATCH v2] sched: make RED scaling configurable

2017-09-13 Thread alangordondewar
From: Alan Dewar The RED code stores the maximum threshold is a 32-bit integer as a pseudo fixed-point floating number with 10 fractional bits. Twelve other bits are used to encode the filter weight, leaving just 10 bits for the queue length. This limits the maximum queue length supported by RE

Re: [dpdk-dev] [PATCH v3 2/5] gso: add TCP/IPv4 GSO support

2017-09-13 Thread Hu, Jiayu
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, September 13, 2017 5:38 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; Kavanagh, Mark B ; Tan, > Jianfeng > Subject: RE: [PATCH v3 2/5] gso: add TCP/IPv4 GSO support > > > > > > > + > > > > +int > > > > +gso_tc

Re: [dpdk-dev] [PATCH v3 2/5] gso: add TCP/IPv4 GSO support

2017-09-13 Thread Jiayu Hu
Hi Konstantin, On Tue, Sep 12, 2017 at 10:17:27PM +0800, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Ananyev, Konstantin > > Sent: Tuesday, September 12, 2017 12:18 PM > > To: Hu, Jiayu ; dev@dpdk.org > > Cc: Kavanagh, Mark B ; Tan, Jianfeng > > > > Subject: RE: [PA

[dpdk-dev] [PATCH v2 2/4] examples/vm_power_manager: add per-core turbo

2017-09-13 Thread David Hunt
Add extra commands to command line to allow enable/disable of per-core turbo. When a core has turbo enabled, calling for max frequency will allow it to go to a turbo frequency (P0n). When a core has turbo disabled, calling for max frequency will allow it to go to the maximum non-turbo frequency (

[dpdk-dev] [PATCH v2 0/4] add per-core Turbo Boost capability

2017-09-13 Thread David Hunt
Recent generations of the Intel® Xeon® family processors allow Turbo Boost to be enabled/disabled on a per-core basis. This patch set introduces additional API calls to the librte_power library to allow users to enable/disable Turbo Boost on particular cores. Changes in patchset v2: * Removed

[dpdk-dev] [PATCH v2 1/4] lib/librte_power: add turbo boost API

2017-09-13 Thread David Hunt
Adds a new set of APIs to allow per-core turbo enable-disable. Signed-off-by: David Hunt --- lib/librte_power/channel_commands.h | 2 + lib/librte_power/rte_power.c | 9 +++ lib/librte_power/rte_power.h | 41 +++ lib/librte_power/rte_power_acpi_cpufre

[dpdk-dev] [PATCH v2 3/4] examples/vm_power_cli_guest: add per-core turbo

2017-09-13 Thread David Hunt
Add extra commands to guest cli to allow enable/disable of per-core turbo. Includes messages to vm_power_mgr in host. Signed-off-by: David Hunt --- examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/vm_power_

[dpdk-dev] [PATCH 3/4] net/mlx5: fix Tx stats error counter logic

2017-09-13 Thread Shahaf Shuler
Tx error counter lacks the logic of incrementation, making it useless for applications. Fixes: 87011737b715 ("mlx5: add software counters") Cc: sta...@dpdk.org Cc: adrien.mazarg...@6wind.com Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_rxtx.c | 20 +++- 1 file changed,

[dpdk-dev] [PATCH 2/4] net/mlx5: fix Tx stats error counter definition

2017-09-13 Thread Shahaf Shuler
The current Tx error counter counts, according to its description, the total number of packets not sent when TX ring full. It is reported to application as part of oerrors field. The drop due to full ring is not the statistic that should be set on oerrors field. Such number can be counted by the a

[dpdk-dev] [PATCH v2 4/4] doc/power: add information on per-core turbo APIs

2017-09-13 Thread David Hunt
Signed-off-by: David Hunt --- doc/guides/prog_guide/power_man.rst | 12 1 file changed, 12 insertions(+) diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst index 114d0b1..c5d62a3 100644 --- a/doc/guides/prog_guide/power_man.rst +++ b/doc/guides/p

[dpdk-dev] [PATCH 1/4] net/mlx5: fix num seg assumption on vPMD

2017-09-13 Thread Shahaf Shuler
vPMD Tx function assumes that after the scatter of the multi-segment packets the next packet will be a single segment packet. This is not current as the function can return due to lack of resources without sending all of the multi-segment mbufs sequence. Fixes: 6cb559d67b83 ("net/mlx5: add vector

Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file

2017-09-13 Thread Shijith Thotton
On Wed, Sep 13, 2017 at 07:51:30AM +, Yang, Qiming wrote: >Hi, Shijith > > > >VF init error will happen after apply your patch, error log as below. If >revert your commit, all things work well. And this issue is not only occur >in i40 VF but also ixgbe. > >Could you

[dpdk-dev] [PATCH 4/4] net/mlx5: enforce Tx num of segments limitation

2017-09-13 Thread Shahaf Shuler
Mellanox NICs has a limitation on the number of mbuf segments a multi segment mbuf can have. The max number depends on the Tx offloads requested. The current code not enforce such limitation, which might cause malformed work requests to be written to the device. This commit adds verification for

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/4] net/mlx5: fix num seg assumption on vPMD

2017-09-13 Thread Shahaf Shuler
Wednesday, September 13, 2017 1:48 PM, Shahaf Shuler: > vPMD > > vPMD Tx function assumes that after the scatter of the multi-segment > packets the next packet will be a single segment packet. > > This is not current as the function can return due to lack of resources > without > sending all of

[dpdk-dev] [PATCH v4 2/4] net/mlx5: fix Tx stats error counter definition

2017-09-13 Thread Shahaf Shuler
The current Tx error counter counts, according to its description, the total number of packets not sent when TX ring full. It is reported to application as part of oerrors field. The drop due to full ring is not the statistic that should be set on oerrors field. Such number can be counted by the a

[dpdk-dev] [PATCH v4 1/4] net/mlx5: fix num seg assumption on vPMD

2017-09-13 Thread Shahaf Shuler
vPMD Tx function assumes that after the scatter of the multi-segment packets the next packet will be a single segment packet. This is not current as the function can return due to lack of resources without sending all of the multi-segment mbufs sequence. Fixes: 6cb559d67b83 ("net/mlx5: add vector

[dpdk-dev] [PATCH v4 3/4] net/mlx5: fix Tx stats error counter logic

2017-09-13 Thread Shahaf Shuler
Tx error counter lacks the logic of incrementation, making it useless for applications. Fixes: 87011737b715 ("mlx5: add software counters") Cc: sta...@dpdk.org Cc: adrien.mazarg...@6wind.com Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_rxtx.c | 20 +++- 1 file changed,

[dpdk-dev] [PATCH v4 4/4] net/mlx5: enforce Tx num of segments limitation

2017-09-13 Thread Shahaf Shuler
Mellanox NICs has a limitation on the number of mbuf segments a multi segment mbuf can have. The max number depends on the Tx offloads requested. The current code not enforce such limitation, which might cause malformed work requests to be written to the device. This commit adds verification for

Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file

2017-09-13 Thread Ferruh Yigit
On 9/13/2017 11:48 AM, Shijith Thotton wrote: > On Wed, Sep 13, 2017 at 07:51:30AM +, Yang, Qiming wrote: >>Hi, Shijith >> >> >> >>VF init error will happen after apply your patch, error log as below. If >>revert your commit, all things work well. And this issue is not only occ

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-13 Thread Shahaf Shuler
Wednesday, September 13, 2017 12:28 PM, Thomas Monjalon: > I still think we must streamline ethdev API instead of complexifying. > We should drop the big "configure everything" and configure offloads one by > one, and per queue (the finer grain). The issue is, that there is some functionality whic

[dpdk-dev] [PATCH] net/nfp: configure L2 broadcast and multicast

2017-09-13 Thread Alejandro Lucero
This is required in some NFP firmwares when working with VFs. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 09854a2..b014209 100

[dpdk-dev] [PATCH] net/nfp: configure capabilities by default

2017-09-13 Thread Alejandro Lucero
These capabilities are enabled in current NFP firmwares by default, but it could be they are not with NFP firmwares to come. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp

Re: [dpdk-dev] [PATCH v2 16/17] build: add option to version libs using DPDK version

2017-09-13 Thread Luca Boccassi
On Tue, 2017-09-12 at 11:38 +0100, Bruce Richardson wrote: > Normally, each library has it's own version number based on the ABI. > Add an option to have all libs just use the DPDK version number as > the > .so version. > > Signed-off-by: Bruce Richardson > Reviewed-by: Harry van Haaren > --- >

Re: [dpdk-dev] git trees organization

2017-09-13 Thread Ferruh Yigit
On 9/13/2017 8:58 AM, Adrien Mazarguil wrote: > Hi, > > On Tue, Sep 12, 2017 at 09:32:07AM +0100, Bruce Richardson wrote: >> On Tue, Sep 12, 2017 at 12:03:30AM +0200, Thomas Monjalon wrote: >>> Hi all, >>> >>> As you know I am currently the only maintainer of the master tree. >>> It is very conven

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: increase port_id range

2017-09-13 Thread Ferruh Yigit
On 9/13/2017 3:26 AM, Yang, Zhiyong wrote: > Hi Ferruh, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Monday, September 11, 2017 6:22 PM >> To: Yang, Zhiyong ; dev@dpdk.org; Doherty, Declan >> ; Lu, Wenzhuo >> Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Hunt, David >> >> S

Re: [dpdk-dev] [PATCH v3 2/2] eal/malloc: fix RTE malloc element free

2017-09-13 Thread Sergio Gonzalez Monroy
On 09/09/2017 08:33, Xueming Li wrote: malloc_elem_free() is clearing(setting to 0) the trailer cookie when RTE_MALLOC_DEBUG is enabled. In case of joining free neighbor element, part of joined memory is not getting cleared due to missing the length of trailer cookie in the middle. This patch fi

Re: [dpdk-dev] [PATCH v3 1/2] eal/malloc: fix RTE malloc debug macro

2017-09-13 Thread Sergio Gonzalez Monroy
On 09/09/2017 08:33, Xueming Li wrote: This patch replaces broken macro RTE_LIBRTE_MALLOC_DEBUG with RTE_MALLOC_DEBUG. Fixes: af75078fece3 ("first public release") Cc: Sergio Gonzalez Monroy Signed-off-by: Xueming Li --- Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: increase port_id range

2017-09-13 Thread Yang, Zhiyong
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, September 13, 2017 7:57 PM > To: Yang, Zhiyong ; dev@dpdk.org; Doherty, Declan > ; Lu, Wenzhuo > Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Hunt, David > ; Richardson, Bruce ; > Ananyev, Konstantin > Subject:

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: increase port_id range

2017-09-13 Thread Thomas Monjalon
13/09/2017 13:56, Ferruh Yigit: > On 9/13/2017 3:26 AM, Yang, Zhiyong wrote: > > From: Yigit, Ferruh > >> On 9/9/2017 3:47 PM, Zhiyong Yang wrote: > >>> Extend port_id definition from uint8_t to uint16_t in lib and drivers > >>> data structures, specifically rte_eth_dev_data. > >>> Modify the APIs,

Re: [dpdk-dev] git trees organization

2017-09-13 Thread Adrien Mazarguil
On Wed, Sep 13, 2017 at 12:38:37PM +0100, Ferruh Yigit wrote: > On 9/13/2017 8:58 AM, Adrien Mazarguil wrote: > > Hi, > > > > On Tue, Sep 12, 2017 at 09:32:07AM +0100, Bruce Richardson wrote: > >> On Tue, Sep 12, 2017 at 12:03:30AM +0200, Thomas Monjalon wrote: > >>> Hi all, > >>> > >>> As you kno

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-13 Thread Aaron Conole
Thomas Monjalon writes: > 12/09/2017 22:29, Aaron Conole: >> Thomas Monjalon writes: >> >> > 12/09/2017 16:50, Aaron Conole: >> >> Eelco Chaudron writes: >> >> >> >> > Call the mlockall() function, to attempt to lock all of its process >> >> > memory into physical RAM, and preventing the kern

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-13 Thread Shahaf Shuler
Wednesday, September 13, 2017 12:13 PM, Andrew Rybchenko: >>return -EBUSY; >> } >> +/* >>+ * Convert between the offloads API to enable PMDs to support >>+ * only one of them. >>+ */ >>+if ((dev_conf->rxmode.ignore_offload_bitfield == 0)) { >>+rte_eth_convert_rx_of

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-13 Thread Andrew Rybchenko
On 09/13/2017 03:33 PM, Shahaf Shuler wrote: Wednesday, September 13, 2017 12:13 PM, Andrew Rybchenko: >>return -EBUSY; >>  } >>  +    /* >>+ * Convert between the offloads API to enable PMDs to support >>+ * only one of them.

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-13 Thread Thomas Monjalon
13/09/2017 13:16, Shahaf Shuler: > Wednesday, September 13, 2017 12:28 PM, Thomas Monjalon: > > I still think we must streamline ethdev API instead of complexifying. > > We should drop the big "configure everything" and configure offloads one by > > one, and per queue (the finer grain). > > The is

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-13 Thread Shahaf Shuler
Wednesday, September 13, 2017 11:13 AM, Andrew Rybchenko: On 09/13/2017 09:37 AM, Shahaf Shuler wrote: >I think it would be useful to have the description in the documentation. >It is really important topic on how per-port and per-queue offloads coexist >and rules should be 100% clear for PMD main

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: introduce Tx queue offloads API

2017-09-13 Thread Shahaf Shuler
Wednesday, September 13, 2017 11:41 AM, Andrew Rybchenko: >>+Mbuf fast free >>+-- >>+ >>+Supports optimization for fast release of mbufs following successful Tx. >>+Requires all mbufs to come from the same mempool and has refcnt = 1. >It is ambiguous here in the case of fast free

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-13 Thread Shahaf Shuler
Wednesday, September 13, 2017 3:42 PM, Thomas MonjalonL > 13/09/2017 13:16, Shahaf Shuler: > > Wednesday, September 13, 2017 12:28 PM, Thomas Monjalon: > > > I still think we must streamline ethdev API instead of complexifying. > > > We should drop the big "configure everything" and configure offlo

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-13 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, September 13, 2017 1:42 PM > To: dev@dpdk.org; Shahaf Shuler > Cc: Ananyev, Konstantin ; > step...@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new

Re: [dpdk-dev] [PATCH v2 16/17] build: add option to version libs using DPDK version

2017-09-13 Thread Bruce Richardson
On Wed, Sep 13, 2017 at 12:32:24PM +0100, Luca Boccassi wrote: > On Tue, 2017-09-12 at 11:38 +0100, Bruce Richardson wrote: > > Normally, each library has it's own version number based on the ABI. > > Add an option to have all libs just use the DPDK version number as > > the > > .so version. > > >

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-13 Thread Thomas Monjalon
13/09/2017 14:56, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 13/09/2017 13:16, Shahaf Shuler: > > > Wednesday, September 13, 2017 12:28 PM, Thomas Monjalon: > > > > I still think we must streamline ethdev API instead of complexifying. > > > > We should drop the bi

Re: [dpdk-dev] git trees organization

2017-09-13 Thread Ferruh Yigit
On 9/13/2017 1:25 PM, Adrien Mazarguil wrote: > On Wed, Sep 13, 2017 at 12:38:37PM +0100, Ferruh Yigit wrote: >> On 9/13/2017 8:58 AM, Adrien Mazarguil wrote: >>> Hi, >>> >>> On Tue, Sep 12, 2017 at 09:32:07AM +0100, Bruce Richardson wrote: On Tue, Sep 12, 2017 at 12:03:30AM +0200, Thomas Monj

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: increase port_id range

2017-09-13 Thread Ferruh Yigit
On 9/13/2017 1:18 PM, Thomas Monjalon wrote: > 13/09/2017 13:56, Ferruh Yigit: >> On 9/13/2017 3:26 AM, Yang, Zhiyong wrote: >>> From: Yigit, Ferruh On 9/9/2017 3:47 PM, Zhiyong Yang wrote: > Extend port_id definition from uint8_t to uint16_t in lib and drivers > data structures, speci

Re: [dpdk-dev] [PATCH v3 2/4] eventdev: Add eth Rx adapter caps callback to SW evdev

2017-09-13 Thread Nipun Gupta
> -Original Message- > From: Nikhil Rao [mailto:nikhil@intel.com] > Sent: Tuesday, September 12, 2017 17:59 > To: jerin.ja...@caviumnetworks.com; bruce.richard...@intel.com > Cc: gage.e...@intel.com; dev@dpdk.org; tho...@monjalon.net; > harry.van.haa...@intel.com; Hemant Agrawal ; > N

Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file

2017-09-13 Thread Hu, Xuekun
I met the same issue too, only with i40e 2.1.26 PF kernel driver. -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit Sent: Wednesday, September 13, 2017 7:04 PM To: Shijith Thotton ; Yang, Qiming ; Gregory Etelson Cc: dev@dpdk.org; Tan, Jianfeng Subjec

Re: [dpdk-dev] [PATCH] Fix bash path in shebangs

2017-09-13 Thread alan somers
On Wed, Sep 13, 2017 at 3:37 AM, Thomas Monjalon wrote: > 27/07/2017 22:12, asom...@gmail.com: >> From: Alan Somers >> >> "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. > > Why is it an issue? > > Can you run dpdk-setup.sh on a non-Linux system? > Nope, because even dpdk-setup.sh a

Re: [dpdk-dev] [PATCH v3 2/5] gso: add TCP/IPv4 GSO support

2017-09-13 Thread Kavanagh, Mark B
>From: Ananyev, Konstantin >Sent: Wednesday, September 13, 2017 10:38 AM >To: Hu, Jiayu >Cc: dev@dpdk.org; Kavanagh, Mark B ; Tan, Jianfeng > >Subject: RE: [PATCH v3 2/5] gso: add TCP/IPv4 GSO support > > > >> > > + >> > > +int >> > > +gso_tcp4_segment(struct rte_mbuf *pkt, >> > > +

Re: [dpdk-dev] git trees organization

2017-09-13 Thread Adrien Mazarguil
On Wed, Sep 13, 2017 at 02:21:00PM +0100, Ferruh Yigit wrote: > On 9/13/2017 1:25 PM, Adrien Mazarguil wrote: > > On Wed, Sep 13, 2017 at 12:38:37PM +0100, Ferruh Yigit wrote: > >> On 9/13/2017 8:58 AM, Adrien Mazarguil wrote: > >>> Hi, > >>> > >>> On Tue, Sep 12, 2017 at 09:32:07AM +0100, Bruce Ri

Re: [dpdk-dev] [PATCH v3] devtools: rework abi checker script

2017-09-13 Thread Neil Horman
On Mon, Sep 11, 2017 at 10:46:35AM +0200, Olivier Matz wrote: > The initial version of the script had some limitations: > - cannot work on a non-clean workspace > - environment variables are not documented > - no compilation log in case of failure > - return success even it abi is incompatible > >

[dpdk-dev] [PATCH v3 00/17] build DPDK libs and some drivers with meson/ninja

2017-09-13 Thread Bruce Richardson
V3 changes: * used two-digit version numbers when globally versioning libs+drivers * removed symlinks with single-digit version numbers in same case * moved driver install location from $prefix/dpdk to $prefix/share/dpdk V2 changes: * fixed copyright notices, updated 2016 to 2017 * removed depende

[dpdk-dev] [PATCH v3 01/17] build: add initial infrastructure for meson & ninja builds

2017-09-13 Thread Bruce Richardson
To build with meson and ninja, we need some initial infrastructure in place. The build files for meson always need to be called "meson.build", and options get placed in meson_options.txt This commit adds a top-level meson.build file, which sets up the global variables for tracking drivers, librari

[dpdk-dev] [PATCH v3 03/17] igb_uio: add igb_uio kmod to meson build

2017-09-13 Thread Bruce Richardson
Support building igb_uio using meson and ninja. For this, we still use the kernel's kbuild system, by calling out to make, since it's safer and easier than trying to reproduce that in meson. A list of suitable file dependencies is given so that we have a reasonable chance of a rebuild when necessar

[dpdk-dev] [PATCH v3 02/17] eal: add eal library to meson build

2017-09-13 Thread Bruce Richardson
Support building the EAL with meson and ninja. This involves a number of different meson.build files for iterating through all the different subdirectories in the EAL. The library itself will be compiled on build but the header files are only copied from their initial location once "ninja install"

[dpdk-dev] [PATCH v3 05/17] build: add buildtools to meson build

2017-09-13 Thread Bruce Richardson
Add the buildtools folder, and more specifically the pmdinfogen binary to the meson and ninja build. This will be needed for building the PMDs in the driver folder later, as the pmd info output from the tool needs to be included in those libs. Signed-off-by: Bruce Richardson --- buildtools/gen-p

[dpdk-dev] [PATCH v3 04/17] build: add DPDK libraries to build

2017-09-13 Thread Bruce Richardson
Add non-EAL libraries to DPDK build. The compat lib is a special case, along with the previously-added EAL, but all other libs can be build using the same set of commands, where the individual meson.build files only need to specify their dependencies, source files, header files and ABI versions. S

[dpdk-dev] [PATCH v3 06/17] build: add infrastructure for building PMDs

2017-09-13 Thread Bruce Richardson
Add in the top-level drivers meson.build file to start adding in building of PMDs. Since all PMDs are built in pretty much the same way, the logic for building each PMD, including extracting the pmdinfo, is included in the top level build file. This means that each individual driver class only need

[dpdk-dev] [PATCH v3 08/17] drivers/crypto: add crypto drv class and null PMD to meson

2017-09-13 Thread Bruce Richardson
Add in a crypto driver class, and implement compiling the null crypto instance. Signed-off-by: Bruce Richardson --- drivers/crypto/meson.build | 35 +++ drivers/crypto/null/meson.build | 33 + drivers/meson.build |

[dpdk-dev] [PATCH v3 07/17] drivers/mempool: add SW mempool drivers to meson build

2017-09-13 Thread Bruce Richardson
With build infrastructure in place, add in mempool drivers to the build. Signed-off-by: Bruce Richardson --- drivers/mempool/meson.build | 35 +++ drivers/mempool/ring/meson.build | 32 drivers/mempool/stack/meson.build | 32

[dpdk-dev] [PATCH v3 10/17] crypto/qat: add driver to meson build

2017-09-13 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- config/rte_config.h| 8 drivers/crypto/meson.build | 2 +- drivers/crypto/qat/meson.build | 41 + 3 files changed, 50 insertions(+), 1 deletion(-) create mode 100644 drivers/crypto/qat/meson.bu

[dpdk-dev] [PATCH v3 09/17] crypto/openssl: add driver to meson build

2017-09-13 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- drivers/crypto/meson.build | 2 +- drivers/crypto/openssl/meson.build | 38 ++ 2 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 drivers/crypto/openssl/meson.build diff --git a/drivers/crypto/meso

[dpdk-dev] [PATCH v3 11/17] drivers/net: add net driver support to meson build

2017-09-13 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- drivers/meson.build | 2 +- drivers/net/meson.build | 35 +++ 2 files changed, 36 insertions(+), 1 deletion(-) create mode 100644 drivers/net/meson.build diff --git a/drivers/meson.build b/drivers/meson.build index be87918

[dpdk-dev] [PATCH v3 12/17] drivers/net: add set of vdev PMDs to build

2017-09-13 Thread Bruce Richardson
Add the af_packet, null, pcap and ring PMDs to the meson build. Signed-off-by: Bruce Richardson --- config/rte_config.h | 4 drivers/net/af_packet/meson.build | 35 + drivers/net/meson.build | 2 +- drivers/net/null/meson.build

[dpdk-dev] [PATCH v3 15/17] usertools: add usertools installation to meson build

2017-09-13 Thread Bruce Richardson
Have the "usertools" scripts installed when doing a DPDK install using ninja. They will be copies to $prefix/bin, generally /usr/local/bin, alongside testpmd. Signed-off-by: Bruce Richardson --- meson.build | 3 ++- usertools/meson.build | 32 2 files

[dpdk-dev] [PATCH v3 13/17] drivers/net: add drivers for Intel NICs to meson build

2017-09-13 Thread Bruce Richardson
Add the e1000, fm10k, i40e and ixgbe drivers to the meson & ninja build. Signed-off-by: Bruce Richardson --- config/rte_config.h| 12 +++ drivers/net/e1000/base/meson.build | 65 ++ drivers/net/e1000/meson.build | 44 ++

[dpdk-dev] [PATCH v3 16/17] build: add option to version libs using DPDK version

2017-09-13 Thread Bruce Richardson
Normally, each library has it's own version number based on the ABI. Add an option to have all libs just use the DPDK version number as the .so version. Signed-off-by: Bruce Richardson --- drivers/meson.build | 13 - lib/librte_eal/bsdapp/eal/meson.build | 12 ++

[dpdk-dev] [PATCH v3 14/17] app/test-pmd: add test-pmd to meson build

2017-09-13 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- app/meson.build | 32 + app/test-pmd/meson.build | 74 meson.build | 3 +- 3 files changed, 108 insertions(+), 1 deletion(-) create mode 100644 app/meson.build create

[dpdk-dev] [PATCH v3 17/17] doc: add documentation on how to add new components to DPDK

2017-09-13 Thread Bruce Richardson
Add to the contributors guide details on how to add libraries and drivers and integrate them with the DPDK build system(s). Signed-off-by: Bruce Richardson --- doc/guides/contributing/coding_style.rst | 214 +++ 1 file changed, 214 insertions(+) diff --git a/doc/guid

Re: [dpdk-dev] [PATCH v3 2/5] gso: add TCP/IPv4 GSO support

2017-09-13 Thread Ananyev, Konstantin
Hi Mark, > -Original Message- > From: Kavanagh, Mark B > Sent: Wednesday, September 13, 2017 3:52 PM > To: Ananyev, Konstantin ; Hu, Jiayu > > Cc: dev@dpdk.org; Tan, Jianfeng > Subject: RE: [PATCH v3 2/5] gso: add TCP/IPv4 GSO support > > >From: Ananyev, Konstantin > >Sent: Wednesday,

[dpdk-dev] [PATCH v2 0/7] Crypto-perf app improvements

2017-09-13 Thread Pablo de Lara
This patchset includes some improvements in the Crypto performance application, including app fixes and new parameter additions. The last patch, in particular, introduces performance improvements. Currently, crypto operations are allocated in a mempool and mbufs in a different one. Then mbufs are

[dpdk-dev] [PATCH v2 2/7] app/crypto-perf: parse AEAD data from vectors

2017-09-13 Thread Pablo de Lara
Since DPDK 17.08, there is specific parameters for AEAD algorithm, like AES-GCM. When verifying crypto operations with test vectors, the parser was not reading AEAD data (such as IV or key). Fixes: 8a5b494a7f99 ("app/test-crypto-perf: add AEAD parameters") Cc: sta...@dpdk.org Signed-off-by: Pablo

[dpdk-dev] [PATCH v2 1/7] app/crypto-perf: set AAD after the crypto operation

2017-09-13 Thread Pablo de Lara
Instead of prepending the AAD (Additional Authenticated Data) in the mbuf, it is easier to set after the crypto operation, as it is a read-only value, like the IV, and then it is not restricted to the size of the mbuf headroom. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_ops.c

[dpdk-dev] [PATCH v2 3/7] app/crypto-perf: parse segment size

2017-09-13 Thread Pablo de Lara
Instead of parsing number of segments, from the command line, parse segment size, as it is a more usual case to have the segment size fixed and then different packet sizes will require different number of segments. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_ops.c | 2

[dpdk-dev] [PATCH v2 4/7] app/crypto-perf: overwrite mbuf when verifying

2017-09-13 Thread Pablo de Lara
When running the verify test, mbufs in the pool were populated with the test vector loaded from a file. To avoid limiting the number of operations to the pool size, mbufs will be rewritten with the test vector, before linking them to the crypto operations. Signed-off-by: Pablo de Lara --- app/te

[dpdk-dev] [PATCH v2 5/7] app/crypto-perf: do not populate the mbufs at init

2017-09-13 Thread Pablo de Lara
For throughput and latency tests, it is not required to populate the mbufs with any test vector. For verify test, there is already a function that rewrites the mbufs every time they are going to be used with crypto operations. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_test_late

  1   2   >