Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-24 Thread Li, Xiaoyun
Hi > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Li, Xiaoyun > Sent: Friday, October 20, 2017 09:03 > To: Richardson, Bruce ; Thomas Monjalon > > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Lu, Wenzhuo ; Zhang, Helin > ; ophi...@mellanox.com > Subject: Re: [dpd

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix setting speed by argument

2017-10-24 Thread Pascal Mazon
On 25/10/2017 03:24, Ferruh Yigit wrote: > On 9/19/2017 5:45 AM, Pascal Mazon wrote: >> Hi, >> >> The patch looks mainly ok to me. >> >> I'll put some comments inline. >> >> On 18/09/2017 20:47, Ferruh Yigit wrote: >>> From: Vipin Varghese >>> >>> tap speed argument is not working without generati

Re: [dpdk-dev] Issue with MTU/max_rx_pkt_len handling by different NICs/PMD drivers

2017-10-24 Thread Nitin Katiyar
Thanks Stephen for reply. I agree that it is advisory for device driver. I am also reporting the issue with PMD dpdk drivers. We see different behavior with 2 NICs which we have tested with OVS-DPDK (i.e. Fortville and Niantic). And by looking at other PMD driver, there could be issue with other

Re: [dpdk-dev] [PATCH 2/3] cryptodev: break dependency on virtual device bus

2017-10-24 Thread Tomasz Duszynski
On Fri, Oct 20, 2017 at 10:21:12PM +0100, Declan Doherty wrote: > Removes any dependency of librte_cryptodev on the virtual device > infrastructure code and removes the functions which were virtual > device specific. > > Updates all virtual PMDs to remove dependencies on rte_cryptodev_vdev.h > and

Re: [dpdk-dev] [PATCH v5 01/11] lib/rte_security: add security library

2017-10-24 Thread Hemant Agrawal
Hi Akhil, Some minor comments. On 10/24/2017 7:45 PM, Akhil Goyal wrote: rte_security library provides APIs for security session create/free for protocol offload or offloaded crypto operation to ethernet device. Signed-off-by: Akhil Goyal Signed-off-by: Boris Pismenny Signed-off-by:

Re: [dpdk-dev] [PATCH v5 06/11] ethdev: support security APIs

2017-10-24 Thread Hemant Agrawal
On 10/24/2017 7:45 PM, Akhil Goyal wrote: From: Declan Doherty rte_flow_action type and ethdev updated to support rte_security sessions for crypto offload to ethernet device. Signed-off-by: Boris Pismenny Signed-off-by: Aviad Yehezkel Signed-off-by: Radu Nicolau Signed-off-by: Declan Dohert

Re: [dpdk-dev] [PATCH v5 08/11] mk: add rte security into build system

2017-10-24 Thread Hemant Agrawal
On 10/24/2017 7:45 PM, Akhil Goyal wrote: Signed-off-by: Akhil Goyal Signed-off-by: Radu Nicolau --- config/common_base | 5 + lib/Makefile | 5 + mk/rte.app.mk | 1 + 3 files changed, 11 insertions(+) diff --git a/config/common_base b/config/common_base index d9471e8..f5d0

[dpdk-dev] [PATCH v5] ethdev: allow returning error on VLAN offload ops

2017-10-24 Thread Ferruh Yigit
From: David Harton Some devices may not support or fail setting VLAN offload configuration based on dynamic circumstances so the vlan_offload_set_t vector is modified to return an int so the caller can determine success or not. rte_eth_dev_set_vlan_offload is updated to return the value provided

[dpdk-dev] [PATCH] doc: more clarification for i40e 16 bytes desc

2017-10-24 Thread Wenzhuo Lu
The description of i40e 16 bytes descriptor is not clear enough. Add more details. Signed-off-by: Wenzhuo Lu --- doc/guides/nics/i40e.rst | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index a0946e6..e0237a8 100

Re: [dpdk-dev] [PATCH] maintainers: update for fm10k

2017-10-24 Thread Zhang, Helin
> -Original Message- > From: Wang, Xiao W > Sent: Wednesday, October 25, 2017 7:23 PM > To: Zhang, Helin > Cc: Yigit, Ferruh; dev@dpdk.org; Wang, Xiao W > Subject: [PATCH] maintainers: update for fm10k > > Signed-off-by: Xiao Wang Acked-by: Helin Zhang > --- > MAINTAINERS | 3 ++- >

[dpdk-dev] [PATCH] maintainers: update for fm10k

2017-10-24 Thread Xiao Wang
Signed-off-by: Xiao Wang --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index c072d03..01a344e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -393,7 +393,8 @@ F: doc/guides/nics/intel_vf.rst F: doc/guides/nics/features/i40e*.ini

Re: [dpdk-dev] problem with Qlogic NIC QL45611H

2017-10-24 Thread Wu, Xiaoban
Dear Harish, Thanks very much for your reply and help. I have never enabled IOMMU. I have enabled those two flags and run the program again, now the error message is: EAL: PCI device :82:00.0 on NUMA socket 1 EAL: probe driver: 1077:1644 net_qede [qede_common_dev_init:2198(82:00.0:dpdk-

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix setting speed by argument

2017-10-24 Thread Ferruh Yigit
On 9/19/2017 5:45 AM, Pascal Mazon wrote: > Hi, > > The patch looks mainly ok to me. > > I'll put some comments inline. > > On 18/09/2017 20:47, Ferruh Yigit wrote: >> From: Vipin Varghese >> >> tap speed argument is not working without generating any error. > Can you describe the error, paste

Re: [dpdk-dev] [PATCH 0/3] RFC: implement VF reset for i40e, e1000 and ixgbe

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 6:16 AM, luca.bocca...@gmail.com wrote: > From: Luca Boccassi > > These patches were originally sent by Wenzhuo Lu: > > http://dpdk.org/dev/patchwork/patch/14009/ > http://dpdk.org/dev/patchwork/patch/14010/ > http://dpdk.org/dev/patchwork/patch/14011/ > > The current rte_eth_dev_

Re: [dpdk-dev] [PATCH] net/liquidio: add support for promiscuous mode

2017-10-24 Thread Ferruh Yigit
On 10/11/2017 12:47 AM, Shijith Thotton wrote: > From: Intiyaz Basha > > Signed-off-by: Intiyaz Basha > Signed-off-by: Shijith Thotton Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] problem with Qlogic NIC QL45611H

2017-10-24 Thread Patil, Harish
-Original Message- From: dev on behalf of "Wu, Xiaoban" Date: Tuesday, October 24, 2017 at 5:36 PM To: "us...@dpdk.org" , "dev@dpdk.org" Subject: [dpdk-dev] problem with Qlogic NIC QL45611H >Dear All, > > >I am trying to run some DPDK applications with the QL45611H NIC, however >I am fa

Re: [dpdk-dev] [PATCH 1/3] cryptodev: add new APIs to assist PMD initialisation

2017-10-24 Thread Gaëtan Rivet
On Tue, Oct 24, 2017 at 04:09:19PM +0200, Tomasz Duszynski wrote: > Hi Declan, > > Some comments inline. > > On Fri, Oct 20, 2017 at 10:21:11PM +0100, Declan Doherty wrote: > > Adds new PMD assist functions which are bus independent for driver to > > create and destroy new device instances. > > >

Re: [dpdk-dev] [PATCH 0/3] Break dependency on bus infrastructure*

2017-10-24 Thread Gaëtan Rivet
Hello Declan, On Fri, Oct 20, 2017 at 10:21:10PM +0100, Declan Doherty wrote: > This patch set breaks the dependency of the cryptodev library on both the > virtual and PCI device infrastructure. > > It introduces new bus independent crypto PMD driver assist functions for > parsing initialisatio

Re: [dpdk-dev] [PATCH] mbuf: rename deprecated VLAN flags

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 9:09 AM, Olivier MATZ wrote: > Hi Ferruh, > > On Mon, Oct 23, 2017 at 07:08:25PM -0700, Ferruh Yigit wrote: >> On 10/23/2017 5:16 AM, Olivier Matz wrote: >>> PKT_RX_VLAN_PKT and PKT_RX_QINQ_PKT are deprecated for a while. >>> As explained in [1], these flags were kept to let the appl

[dpdk-dev] problem with Qlogic NIC QL45611H

2017-10-24 Thread Wu, Xiaoban
Dear All, I am trying to run some DPDK applications with the QL45611H NIC, however I am facing a problem I don't know how to solve, could somebody please help me? I am using ubuntu 14.04 with kernel 3.16 on a Dell server. I downloaded the driver and firmware from http://driverdownloads.qlogi

[dpdk-dev] [PATCH v2] net/mlx5: fix Tx doorbell memory barrier

2017-10-24 Thread Yongseok Koh
Configuring UAR as IO-mapped makes maximum throughput decline by noticeable amount. If UAR is configured as write-combining register, a write memory barrier is needed on ringing a doorbell. rte_wmb() is mostly effective when the size of a burst is comparatively small. Revert the register back to wr

Re: [dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 3:35 AM, Gaetan Rivet wrote: > This flag was deprecated in the previous release, and this is its removal. This change was in wait list, but it would be much more better if not received just before rc2, but in early stages in the release, at worst before rc1. Although patch looks goo

Re: [dpdk-dev] [PATCH v2 01/15] net/bnxt: update HWRM to 1.8.2

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 2:19 PM, Ajit Khaparde wrote: > This patch updates the HWRM API to version 1.8.2 > > Signed-off-by: Ajit Khaparde > -- > v1->v2: Trim down the patch size to avoid unused structures > --- > drivers/net/bnxt/bnxt_ethdev.c |2 +- > drivers/net/bnxt/bnxt_hwrm.c |

Re: [dpdk-dev] [PATCH v2 00/15] bnxt patchset

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 2:19 PM, Ajit Khaparde wrote: > The first patch updates the HWRM API to version 1.8.2 > Some of the patches fix issues reported by Coverity. > > Please apply. > > Ajit Khaparde (15): > net/bnxt: update HWRM to 1.8.2 > net/bnxt: fix tx_offload capability > net/bnxt: fix rx_offl

Re: [dpdk-dev] [PATCH 1/2] examples/kni: check if pci_dev isn't NULL before using it

2017-10-24 Thread Thomas Monjalon
21/10/2017 02:26, Ferruh Yigit: > On 10/16/2017 4:45 AM, Tomasz Duszynski wrote: > > Since virtual devices, i.e mrvl net pmd, do not touch pci_dev > > dereferencing it will cause segmentation fault as by default > > it's set to NULL in rte_eth_dev_info_get(). > > > > Signed-off-by: Tomasz Duszynsk

Re: [dpdk-dev] [PATCH] examples/qos_sched: fix uninitialized scalar variable

2017-10-24 Thread Thomas Monjalon
24/10/2017 11:09, Jasvinder Singh: > Fix problem with uninitialized rx/tx deferred_start flags of the struct > rte_eth_rxconf/txconf by initializing with 0 value (deferred start of > the rx/tx queues is turned off). This setting allows device rx/tx > queues to start with rte_eth_dev_start(). > > C

Re: [dpdk-dev] [PATCH] examples/power: add turbo commands to help text

2017-10-24 Thread Thomas Monjalon
19/10/2017 14:27, Hunt, David: > Hi Marko, > > On 19/10/2017 10:34 AM, Marko Kovacevic wrote: > > From: David Hunt > > > > Fixes: d191f0853378 ("examples/vm_power_manager: add per-core turbo CLI") > > > > Signed-off-by: Marko Kovacevic > > --- > Thanks for the patch. Looks good to me. > > Acked

Re: [dpdk-dev] [PATCH] power: fix power example app response time

2017-10-24 Thread Thomas Monjalon
23/10/2017 17:21, David Hunt: > A delay in the loop waiting for the virtio-serial commands in the > vm_power_manager app was causing a lag in the response time. This was > set to 1 second, and has now been changed to 1ms. > > Fixes: f14791a8126e ("examples/vm_power_mgr: add policy to channels") >

Re: [dpdk-dev] [PATCH] app/testpmd: refine xstats show

2017-10-24 Thread Ferruh Yigit
On 10/23/2017 4:47 PM, Ferruh Yigit wrote: > On 10/20/2017 10:09 AM, Elza Mathew wrote: >> When using "show port xstats all" command to show xstats, the output >> is usually too long to obtain what you really want, especially when >> multi-queue is enabled. >> >> Added an option to set whether zero

Re: [dpdk-dev] [PATCH v3] examples/l3fwd: pass flow arguments when start app

2017-10-24 Thread Thomas Monjalon
24/10/2017 03:38, Wu, Jingjing: > From: Li, Xiaoyun > > To make the performance can be tuning on different NICs or platforms. We > > need to make the number of descriptors as arguments when starting l3fwd > > application. > > > > Signed-off-by: Xiaoyun Li > > Agree to this change. > > Reviewed-

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-10-24 Thread Ferruh Yigit
On 10/20/2017 9:55 AM, Ferruh Yigit wrote: > Remove device reset during application start, the reset for application > exit still there. > > Reset in open removed because of following comments: > 1- Device reset not completed when VF driver loaded, which cause VF PMD >initialization error. >

Re: [dpdk-dev] [PATCH] igb_uio: revert open and release operations

2017-10-24 Thread Ferruh Yigit
On 10/17/2017 1:14 PM, Ferruh Yigit wrote: > This reverts commit 6b9ed026a8704b9e5ee5da7997617ef7cc82e114. > This reverts commit 5f6ff30dc5075c49069d684bab229aef7ff0fdc3. > This reverts commit b58eedfc7dd57eef6d12e2c654a52c834f36084a. > > There were bug reports about terminated application may lea

[dpdk-dev] distributor crash with user assigned flow ids

2017-10-24 Thread Suryanathan P
Hi, We see a crash in the dpdk packet distributor library when the packets are assigned used defined flow ids. I was able to narrow down this issue to incorrect worker ids returned by the sse implementation of find_match_vec(). Debug: Non zero flow ids picked up from each mbuf in this burst (gdb

[dpdk-dev] [PATCH v2 15/15] net/bnxt: check VLANs from pool_map only for VMDQ

2017-10-24 Thread Ajit Khaparde
Fixes: 75cd6fb1d901 ("net/bnxt: fix the association of a MACVLAN per VNIC") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index c130ce884..6e0e40f82 10

[dpdk-dev] [PATCH v2 14/15] net/bnxt: fix an issue reported by Coverity

2017-10-24 Thread Ajit Khaparde
Coverity issue: 147216 Fixes: 7a5b0874440e ("net/bnxt: support to add a VF MAC address") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/rte_pmd_bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnxt.c index af

[dpdk-dev] [PATCH v2 11/15] net/bnxt: fix a potential null poiner dereference

2017-10-24 Thread Ajit Khaparde
Fixes: f7ecea911ec5 ("net/bnxt: fix interrupt handler") Coverity issue: 195046 Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_irq.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c index 79a119623..49436

[dpdk-dev] [PATCH v2 13/15] net/bnxt: fix a pointer deref before null check

2017-10-24 Thread Ajit Khaparde
Coverity issue: 158634 Fixes: daef48efe5e5 ("net/bnxt: support set MTU") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index d9621e593..d68d26f17 10064

[dpdk-dev] [PATCH v2 12/15] net/bnxt: fix a null pointer deref

2017-10-24 Thread Ajit Khaparde
Coverity issue: 158634 Fixes: daef48efe5e5 ("net/bnxt: support set MTU") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ring.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c index 9d0ae277e..583c82569 100

[dpdk-dev] [PATCH v2 10/15] net/bnxt: fix a potential null pointer dereference

2017-10-24 Thread Ajit Khaparde
Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops") Coverity issue: 195017 Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c index af9ed9a62..65d30fb38 100644

[dpdk-dev] [PATCH v2 09/15] net/bnxt: fix an issue reported by Coverity

2017-10-24 Thread Ajit Khaparde
Fixes: b7435d660a8c ("net/bnxt: add ntuple filtering support") Coverity issue: 195015 Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 9065a12df..c2d54efd

[dpdk-dev] [PATCH v2 07/15] net/bnxt: fix a bad bit shift operation

2017-10-24 Thread Ajit Khaparde
We are left shifting more bits than we should be doing. This patch fixes that. Coverity issue: 127546 Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_et

[dpdk-dev] [PATCH v2 08/15] net/bnxt: fix a null pointer dereference

2017-10-24 Thread Ajit Khaparde
Fix a potential null pointer reported by Coverity. Coverity issue: 195001 Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/ne

[dpdk-dev] [PATCH v2 06/15] net/bnxt: fix redirecting traffic to a VF

2017-10-24 Thread Ajit Khaparde
The case to handle redirect a flow to a VF is not handled. This patch fixes it. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filter.c | 92 +- drivers/net/bnxt/bnxt_filter.h | 2 + 2 files changed, 92 insertions(+), 2 deletions(-) diff --git a/

[dpdk-dev] [PATCH v2 05/15] net/bnxt: remove redundant code parsing pool_map

2017-10-24 Thread Ajit Khaparde
This patch removes some redundant code from bnxt_mq_rx_configure(). Fixes: 8056afdf97d7 ("net/bnxt: fix the association of a MACVLAN per VNIC) Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c

[dpdk-dev] [PATCH v2 00/15] bnxt patchset

2017-10-24 Thread Ajit Khaparde
The first patch updates the HWRM API to version 1.8.2 Some of the patches fix issues reported by Coverity. Please apply. Ajit Khaparde (15): net/bnxt: update HWRM to 1.8.2 net/bnxt: fix tx_offload capability net/bnxt: fix rx_offload capability net/bnxt: handle Rx multi queue creation prop

[dpdk-dev] [PATCH v2 01/15] net/bnxt: update HWRM to 1.8.2

2017-10-24 Thread Ajit Khaparde
This patch updates the HWRM API to version 1.8.2 Signed-off-by: Ajit Khaparde -- v1->v2: Trim down the patch size to avoid unused structures --- drivers/net/bnxt/bnxt_ethdev.c |2 +- drivers/net/bnxt/bnxt_hwrm.c |2 +- drivers/net/bnxt/bnxt_rxr.c|4 +- d

[dpdk-dev] [PATCH v2 03/15] net/bnxt: fix rx_offload capability

2017-10-24 Thread Ajit Khaparde
We are not setting the rx_offload capabilities. Fixing that. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 643879e4e..8419f8bfd 100644 -

[dpdk-dev] [PATCH v2 04/15] net/bnxt: handle Rx multi queue creation properly

2017-10-24 Thread Ajit Khaparde
This patch simplifies logic for RSS queue creation. 1) Do not hardcode number of VNIC pools in case of RSS 2) Log a message if Number of queues is > RTE_ETHDEV_QUEUE_STAT_CNTRS 3) Move the check for allocation of l2_filter inside the for loop. Fixes: 6133f207970c ("net/bnxt: add Rx queue create/de

[dpdk-dev] [PATCH v2 02/15] net/bnxt: fix tx_offload capability

2017-10-24 Thread Ajit Khaparde
We are not indicating VLAN insert capability of HW. Fixing it. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 78c4e1ddc..643879e4e 100644 -

Re: [dpdk-dev] [PATCH] net/i40e: fix queue number error in queue region

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 2:00 PM, Ferruh Yigit wrote: > On 10/24/2017 1:45 AM, Wei Zhao wrote: >> when VSI is enabled with smaller number of queues, >> for example, 1 or 6, it will cause error.64 is the >> max number of queues that can be used for RSS, >> but VSI might be created with only few queues. >> >> F

Re: [dpdk-dev] [PATCH v2] example: add new service cores sample application

2017-10-24 Thread Thomas Monjalon
19/10/2017 12:31, Harry van Haaren: > This commit adds a new sample app, which showcases the value > of running services. In particular it allows the application > to dynamically schedule services to service-cores. > > The sample app itself registers a number of dummy services, > and applies diffe

Re: [dpdk-dev] [PATCH] net/i40e: fix queue number error in queue region

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 1:45 AM, Wei Zhao wrote: > when VSI is enabled with smaller number of queues, > for example, 1 or 6, it will cause error.64 is the > max number of queues that can be used for RSS, > but VSI might be created with only few queues. > > Fixes: 7cbecc2f742 ("net/i40e: support queue region

Re: [dpdk-dev] [PATCH v5 08/11] mk: add rte security into build system

2017-10-24 Thread Thomas Monjalon
Can you squash this patch with the one bringing the lib? > +DEPDIRS-librte_cryptodev += librte_ether I don't like this dependency. Why is it needed? > +DIRS-$(CONFIG_RTE_LIBRTE_SECURITY) += librte_security > +DEPDIRS-librte_security := librte_eal librte_mempool librte_ring librte_mbuf > +DEPDIRS

Re: [dpdk-dev] [PATCH v5 01/11] lib/rte_security: add security library

2017-10-24 Thread Thomas Monjalon
Hi, I am waiting the crypto subtree to be ready before getting this series. Some last comments below, 24/10/2017 16:15, Akhil Goyal: > +Security API - EXPERIMENTAL > +M: Akhil Goyal > +M: Declan Doherty > +F: lib/librte_security/ > +F: doc/guides/prog_guide/rte_security.rst > > Networking D

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: document error codes of reset

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 6:19 AM, luca.bocca...@gmail.com wrote: > From: Luca Boccassi > > This new function returns 0 on success and various error codes on > different failures. Attempt to document them. > > Signed-off-by: Luca Boccassi > Acked-by: Thomas Monjalon Series applied to dpdk-next-net/master

Re: [dpdk-dev] [PATCH v2 4/7] net/mlx4: merge Tx path functions

2017-10-24 Thread Ophir Munk
Hi, On Tuesday, October 24, 2017 4:52 PM, Nélio Laranjeiro wrote: > > On Mon, Oct 23, 2017 at 02:21:57PM +, Ophir Munk wrote: > > From: Matan Azrad > > > > Merge tx_burst and mlx4_post_send functions to prevent double asking > > about WQ remain space. > > > > This should improve performance.

Re: [dpdk-dev] [PATCH v11 0/4] flow classification library

2017-10-24 Thread Thomas Monjalon
24/10/2017 19:27, Bernard Iremonger: > Bernard Iremonger (3): > examples/flow_classify: flow classify sample application > test: add packet burst generator functions > test: flow classify library unit tests > > Ferruh Yigit (1): > flow_classify: add flow classify library The deal was " If

Re: [dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify library

2017-10-24 Thread Thomas Monjalon
24/10/2017 19:28, Bernard Iremonger: > --- a/doc/guides/rel_notes/release_17_11.rst > +++ b/doc/guides/rel_notes/release_17_11.rst > +* **Added the Flow Classification Library.** > + > + Added the Flow Classification library, it provides an API for DPDK > + applications to classify an input packe

Re: [dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify library

2017-10-24 Thread Thomas Monjalon
24/10/2017 19:28, Bernard Iremonger: > --- a/doc/guides/rel_notes/release_17_11.rst > +++ b/doc/guides/rel_notes/release_17_11.rst > @@ -165,6 +165,11 @@ New Features >checksums, and doesn't update checksums for output packets. >Additionally, the GSO library doesn't process IP fragmented pa

Re: [dpdk-dev] [PATCH v11 2/4] examples/flow_classify: flow classify sample application

2017-10-24 Thread Thomas Monjalon
24/10/2017 19:28, Bernard Iremonger: > examples/flow_classify/Makefile| 57 ++ > examples/flow_classify/flow_classify.c | 848 > + > examples/flow_classify/ipv4_rules_file.txt | 14 + The example app is not added in examples/Makefile.

Re: [dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify library

2017-10-24 Thread Thomas Monjalon
24/10/2017 19:28, Bernard Iremonger: > +F: doc/guides/sample_app_ug/flow_classify.rst > +F: doc/guides/prog_guide/flow_classify_lib.rst These files are listed in MAINTAINERS but they are missing. They must be removed from the list.

Re: [dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify library

2017-10-24 Thread Thomas Monjalon
24/10/2017 19:28, Bernard Iremonger: > --- /dev/null > +++ b/lib/librte_flow_classify/rte_flow_classify_version.map > @@ -0,0 +1,13 @@ > +EXPERIMENTAL { > + global: > + > + rte_flow_classifier_create; > + rte_flow_classifier_free; > + rte_flow_classifier_query; > + rte

Re: [dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify library

2017-10-24 Thread Thomas Monjalon
24/10/2017 19:28, Bernard Iremonger: > +/** > + * @file > + * > + * RTE Flow Classify Library > + * > + * This library provides flow record information with some measured > properties. I would add the EXPERIMENTAL tag here: @b EXPERIMENTAL: this API may change without prior notice

Re: [dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify library

2017-10-24 Thread Thomas Monjalon
24/10/2017 19:28, Bernard Iremonger: > # > +# Compile librte_classify > +# > +CONFIG_RTE_LIBRTE_FLOW_CLASSIFY=y > +CONFIG_RTE_LIBRTE_CLASSIFY_DEBUG=n The debug option is still there but seems not used. I guess I can remove it?

Re: [dpdk-dev] [PATCH] lpm6: set errno on creation error

2017-10-24 Thread Thomas Monjalon
24/10/2017 16:20, Bruce Richardson: > On Tue, Oct 24, 2017 at 04:29:45PM +0300, Igor Ryzhov wrote: > > Signed-off-by: Igor Ryzhov > > --- > > lib/librte_lpm/rte_lpm6.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > Acked-by: Bruce Richardson Applied, thanks

Re: [dpdk-dev] [PATCH v2 0/4] net/fm10k: support switch restart

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 12:29 PM, Ferruh Yigit wrote: > On 10/24/2017 6:45 AM, Xiao Wang wrote: >> For fm10k multi host based design, DPDK app running in VM or host needs to >> get aware of the switch's state because switch may undergo a quit-restart. >> This patch series supports switch restart feature for

Re: [dpdk-dev] [PATCH] lpm: set errno on creation error

2017-10-24 Thread Thomas Monjalon
24/10/2017 16:20, Bruce Richardson: > On Tue, Oct 24, 2017 at 04:28:30PM +0300, Igor Ryzhov wrote: > > Signed-off-by: Igor Ryzhov > > --- > > lib/librte_lpm/rte_lpm.c | 6 ++ > > 1 file changed, 6 insertions(+) > > > Acked-by: Bruce Richardson Applied, thanks

Re: [dpdk-dev] [PATCH v2 0/4] net/fm10k: support switch restart

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 6:45 AM, Xiao Wang wrote: > For fm10k multi host based design, DPDK app running in VM or host needs to > get aware of the switch's state because switch may undergo a quit-restart. > This patch series supports switch restart feature for DPDK app to be able > to resume its packet proces

Re: [dpdk-dev] [PATCH v3 0/7] net/mlx5: fixes

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 8:18 AM, Nelio Laranjeiro wrote: > Changes in v3: > > * Avoid to duplicate bcast/multicast flows when multiple MAC addressed are >configured. > > Changes in v2: > > * Fix packets reception in allmulti mode and when VLAN are present. > * Fix a double flow insertion causing an

Re: [dpdk-dev] [PATCH v2] app/testpmd: compile without ixgbe and bnxt pmds

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 11:31 AM, Ferruh Yigit wrote: > On 10/24/2017 7:48 AM, avia...@dev.mellanox.co.il wrote: >> From: Aviad Yehezkel Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode") Fixes: 36735a932ca7 ("net/bnxt: support set VF QOS and MAC anti spoof") Cc: sta...@dpdk.org >> Signed-off-by:

Re: [dpdk-dev] [PATCH v2] app/testpmd: compile without ixgbe and bnxt pmds

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 7:48 AM, avia...@dev.mellanox.co.il wrote: > From: Aviad Yehezkel > > Signed-off-by: Aviad Yehezkel Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v1] net/mlx4: fix missing initializers for old GCC

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 7:35 AM, Adrien Mazarguil wrote: > Hi Nelio, > > On Tue, Oct 24, 2017 at 04:03:15PM +0200, Nélio Laranjeiro wrote: >> Hi Moti, >> >> On Tue, Oct 24, 2017 at 03:35:33PM +0300, Moti Haimovsky wrote: >>> This patch works around compilation issues seen on RHEL 7.2 >>> using GCC 4.8.5: >>

Re: [dpdk-dev] [PATCH v2] net/mlx4: fix targetless internal rule creation

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 3:05 AM, Matan Azrad wrote: > The corrupted code allowed to create internal rule with no any target queue > in case the rule creation occurred before queues creation. > > For example, when user calls rte_eth_dev_default_mac_addr_set after probe > and before dev_configure, mlx4 fails

Re: [dpdk-dev] [PATCH] net/i40e: fix unsecure usage of strncpy function

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 2:50 AM, Bruce Richardson wrote: > On Tue, Oct 24, 2017 at 10:22:38AM +0100, Kirill Rybalchenko wrote: >> Use more secure snprintf function instead of strncpy >> to prevent memory access violation. >> >> Fixes: 40d1324423a4 ("net/i40e: get ddp profile protocol info") >> >> Signed-off-

Re: [dpdk-dev] [PATCH v2] net/i40e: add support for packet template to flow director

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 11:02 AM, Ferruh Yigit wrote: > On 10/24/2017 7:08 AM, Kirill Rybalchenko wrote: >> For complex packets use raw flow type with pre-constructed packet buffer >> instead of creating a packet internally in PMD. >> >> v2: >> >> Fix documentation according to doxygen style comments. >> Fix

Re: [dpdk-dev] [PATCH v2] net/i40e: add support for packet template to flow director

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 7:08 AM, Kirill Rybalchenko wrote: > For complex packets use raw flow type with pre-constructed packet buffer > instead of creating a packet internally in PMD. > > v2: > > Fix documentation according to doxygen style comments. > Fix compilation warnings for clang target. > > Signed

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix packet type flags for Ethernet only frame

2017-10-24 Thread Ferruh Yigit
On 10/23/2017 11:53 PM, Nélio Laranjeiro wrote: > On Tue, Oct 24, 2017 at 09:16:09AM +0300, Shahaf Shuler wrote: >> Considering the PMD supports only Ethernet transport, packet which >> arrives without any packet type flags in the completion should be >> marked with L2_ETHER flag. >> >> Fixes: ea16

Re: [dpdk-dev] [PATCH] net/mlx5: fix adjust priority for drop queue

2017-10-24 Thread Yongseok Koh
On Tue, Oct 24, 2017 at 01:33:19PM +0200, Nelio Laranjeiro wrote: > Drop queue should also adjust their priority according the most specific > layer in the pattern they are matching to avoid dropping all the traffic. > > Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") >

Re: [dpdk-dev] [PATCH] app/testpmd: fix mapping of user priority to DCB TC

2017-10-24 Thread Ferruh Yigit
On 10/23/2017 7:48 PM, Wu, Jingjing wrote: > > >> -Original Message- >> From: Dai, Wei >> Sent: Monday, October 23, 2017 3:25 PM >> To: Wu, Jingjing >> Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org >> Subject: [PATCH] app/testpmd: fix mapping of user priority to DCB TC >> >> When number o

Re: [dpdk-dev] [PATCH] net/liquidio: add support for 10GBase-T cards

2017-10-24 Thread Ferruh Yigit
On 10/23/2017 9:42 PM, Srisivasubramanian S wrote: > Signed-off-by: Srisivasubramanian S > Signed-off-by: Shijith Thotton > --- > doc/guides/nics/liquidio.rst| 2 ++ > drivers/net/liquidio/base/lio_hw_defs.h | 12 > drivers/net/liquidio/lio_ethdev.c | 7 ++- >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix PF DCB info

2017-10-24 Thread Ferruh Yigit
On 10/23/2017 7:50 PM, Wu, Jingjing wrote: > > >> -Original Message- >> From: Dai, Wei >> Sent: Monday, October 23, 2017 2:44 PM >> To: Lu, Wenzhuo ; Ananyev, Konstantin >> ; Wu, Jingjing >> Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org >> Subject: [PATCH] net/ixgbe: fix PF DCB info >> >>

Re: [dpdk-dev] [PATCH v3 6/7] net/mlx5: fix reception when VLAN is added

2017-10-24 Thread Yongseok Koh
On Tue, Oct 24, 2017 at 05:18:17PM +0200, Nelio Laranjeiro wrote: > When VLAN is enabled in the Rx side, only packets matching this VLAN are > expected, this also includes the broadcast and all multicast packets. > > Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") > Fixes: 6a6

[dpdk-dev] [PATCH v11 4/4] test: flow classify library unit tests

2017-10-24 Thread Bernard Iremonger
Add flow_classify_autotest program. Set up IPv4 ACL field definitions. Create table_acl for use by librte_flow_classify API's. Create an mbuf pool for use by rte_flow_classify_query. For each of the librte_flow_classify API's: test with invalid parameters test with invalid patterns test with inva

[dpdk-dev] [PATCH v11 3/4] test: add packet burst generator functions

2017-10-24 Thread Bernard Iremonger
add initialize_tcp_header function add initialize_stcp_header function add initialize_ipv4_header_proto function add generate_packet_burst_proto function Signed-off-by: Bernard Iremonger Acked-by: Jasvinder Singh --- test/test/packet_burst_generator.c | 191 +

[dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify library

2017-10-24 Thread Bernard Iremonger
From: Ferruh Yigit The following APIs's are implemented in the librte_flow_classify library: rte_flow_classifier_create rte_flow_classifier_free rte_flow_classifier_query rte_flow_classify_table_create rte_flow_classify_table_entry_add rte_flow_classify_table_entry_delete The following librte_t

[dpdk-dev] [PATCH v11 0/4] flow classification library

2017-10-24 Thread Bernard Iremonger
DPDK works with packets, but some network administration tools work with flow information. This library is proposed to provide an API to classify received packets using flow patterns. Basically the library consists of APIs to create the classifier object, add a table to the classifer, add and

[dpdk-dev] [PATCH v11 2/4] examples/flow_classify: flow classify sample application

2017-10-24 Thread Bernard Iremonger
The flow_classify sample application exercises the following librte_flow_classify API's: rte_flow_classifier_create rte_flow_classifier_query rte_flow_classify_table_create rte_flow_classify_table_entry_add rte_flow_classify_table_entry_delete It sets up the IPv4 ACL field definitions. It creates

Re: [dpdk-dev] [PATCH 2/2] service: add runtime service core check disable

2017-10-24 Thread Pavan Nikhilesh Bhagavatula
On Mon, Oct 23, 2017 at 06:16:52PM +0100, Harry van Haaren wrote: > This commit adds a new function to disable the runtime mapped > service-cores check. This allows an application to take responsibility > of running unmapped services. > > This feature is useful in cases like unit tests, where the a

Re: [dpdk-dev] [PATCH v6 0/5] new mlx4 datapath bypassing ibverbs

2017-10-24 Thread Ferruh Yigit
On 10/12/2017 5:29 AM, Adrien Mazarguil wrote: > Hopefully the last iteration for this series. > > v6 (Adrien): > - Updated features documentation (mlx4.ini) in the relevant patches. > - Rebased on the latest changes brought by RSS support v2 series. > > v5 (Ophir & Adrien): > - Merged Rx scatter

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] examples/vhost_scsi: fix buffer not terminated

2017-10-24 Thread Thomas Monjalon
17/10/2017 15:26, Yuanhan Liu: > On Fri, Oct 13, 2017 at 09:12:33AM +0200, Maxime Coquelin wrote: > > On 10/12/2017 01:34 PM, Jacek Piasecki wrote: > > >--- a/examples/vhost_scsi/scsi.c > > >+++ b/examples/vhost_scsi/scsi.c > > >@@ -307,7 +307,9 @@ vhost_bdev_scsi_inquiry_command(struct vhost_block

Re: [dpdk-dev] [PATCH] mbuf: rename deprecated VLAN flags

2017-10-24 Thread Olivier MATZ
Hi Ferruh, On Mon, Oct 23, 2017 at 07:08:25PM -0700, Ferruh Yigit wrote: > On 10/23/2017 5:16 AM, Olivier Matz wrote: > > PKT_RX_VLAN_PKT and PKT_RX_QINQ_PKT are deprecated for a while. > > As explained in [1], these flags were kept to let the applications and > > PMDs move to the new flag. There

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: use crc32 in hash functions for arm64

2017-10-24 Thread Dumitrescu, Cristian
Hi Jianbo, ... > >> > As mentioned in one of our deprecation notices, I am actively working > >> > (not ready for 17.8 unfortunately) to add a key mask parameter to these > >> functions, so more work on these hash functions is likely to take place. > >> The above mentioned rework has finally hap

Re: [dpdk-dev] [PATCH v1] net/mlx4: fix missing initializers for old GCC

2017-10-24 Thread Nélio Laranjeiro
On Tue, Oct 24, 2017 at 04:35:05PM +0200, Adrien Mazarguil wrote: > Hi Nelio, > > On Tue, Oct 24, 2017 at 04:03:15PM +0200, Nélio Laranjeiro wrote: > > Hi Moti, > > > > On Tue, Oct 24, 2017 at 03:35:33PM +0300, Moti Haimovsky wrote: > > > This patch works around compilation issues seen on RHEL 7.

[dpdk-dev] [PATCH v3 7/7] net/mlx5: fix flow director flow add

2017-10-24 Thread Nelio Laranjeiro
Flows are added by priv_flow_create() in the associated list, adding them a second time corrupts the list causing an infinite loop when parsing it. Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c |

[dpdk-dev] [PATCH v3 6/7] net/mlx5: fix reception when VLAN is added

2017-10-24 Thread Nelio Laranjeiro
When VLAN is enabled in the Rx side, only packets matching this VLAN are expected, this also includes the broadcast and all multicast packets. Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") Fixes: 6a6b6828fe6a ("net/mlx5: use flow to enable all multi mode") Signed-off-by: Ne

[dpdk-dev] [PATCH v3 5/7] net/mlx5: fix mark action with drop action

2017-10-24 Thread Nelio Laranjeiro
Marking a packet which will not be received by the NIC is useless, even if this action remains possible, it blocks the creation of the flow counter which embed a mark action to a drop queue to be created. Fixes: 31ba9997f11a ("net/mlx5: fully convert a flow to verbs in validate") Signed-off-by: N

[dpdk-dev] [PATCH v3 4/7] net/mlx5: fix flow director drop action

2017-10-24 Thread Nelio Laranjeiro
Flow director drop action as not been brought back with the new implementation on top of rte flow. Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 25 - 1 file changed, 16

[dpdk-dev] [PATCH v3 3/7] net/mlx5: fix drop flows when port is stopped

2017-10-24 Thread Nelio Laranjeiro
Fix the drop queue rule creation when the port is stopped. Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[dpdk-dev] [PATCH v3 2/7] net/mlx5: fix work queue array size

2017-10-24 Thread Nelio Laranjeiro
Indirection table size must be in log to communicate with verbs when the number of queue is not a power of two, the maximum indirection table size is use, but not converted to log2. This makes a memory corruption. Fixes: 4c7a0f5ff876 ("net/mlx5: make indirection tables shareable") Signed-off-by:

[dpdk-dev] [PATCH v3 1/7] net/mlx5: fix segfault on flow creation

2017-10-24 Thread Nelio Laranjeiro
When ports are stopped, the hash Rx queue should not be created. Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net

  1   2   3   >