[dpdk-dev] [PATCH] remove useless memzone includes

2017-11-03 Thread Thomas Monjalon
The memzone header is often included without good reason. Signed-off-by: Thomas Monjalon --- app/test-pmd/csumonly.c | 1 - app/test-pmd/flowgen.c | 1 - app/test-pmd/iofwd.c | 1 - app/test-pm

Re: [dpdk-dev] [PATCH] igb_uio: prevent reset for a list of devices

2017-11-03 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, November 03, 2017 3:38 PM > > Some devices are having problem on device reset that happens during DPDK > application exit [1]. > > Create a static list of devices and exclude them from device reset. > > [1] > http://dpdk.org/ml

[dpdk-dev] [pull-request] next-net 17.11 RC3

2017-11-03 Thread Ferruh Yigit
The following changes since commit 6fb00f8baefa03b9cfd1b2dfc1787258b8459601: bus/pci: fix VFIO device reset (2017-10-31 19:23:36 +0100) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-net for you to fetch changes up to c531000113f5f111ac21d1a0b91073a34d0470b0:

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/failsafe: fix VLAN stripping configuration

2017-11-03 Thread Ferruh Yigit
On 11/3/2017 4:11 PM, Thomas Monjalon wrote: > 02/11/2017 18:27, Ophir Munk: >> failsafe device has vlan stripping configured at startup however once >> a sub device is found as non-capable of vlan-stripping failsafe >> updates it configuration and removes vlan stripping from it. >> This update occ

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix VLAN stripping configuration

2017-11-03 Thread Thomas Monjalon
02/11/2017 18:27, Ophir Munk: > failsafe device has vlan stripping configured at startup however once > a sub device is found as non-capable of vlan-stripping failsafe > updates it configuration and removes vlan stripping from it. > This update occurs only once at startup. Following a later plugin

Re: [dpdk-dev] [PATCH] net/mlx5: fix some typos

2017-11-03 Thread Ferruh Yigit
On 11/2/2017 12:31 PM, Thomas Monjalon wrote: > Signed-off-by: Thomas Monjalon Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] igb_uio: prevent reset for a list of devices

2017-11-03 Thread Thomas Monjalon
03/11/2017 23:38, Ferruh Yigit: > Some devices are having problem on device reset that happens during DPDK > application exit [1]. > > Create a static list of devices and exclude them from device reset. [...] > This is alternative approach to > http://dpdk.org/dev/patchwork/patch/31144/ It is bet

Re: [dpdk-dev] [PATCH] doc: add limitation of VF VLAN strip function

2017-11-03 Thread Ferruh Yigit
On 11/3/2017 8:36 AM, Mcnamara, John wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing >> Sent: Friday, November 3, 2017 3:41 AM >> To: Wu, Jingjing >> Cc: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH] doc: add limitation of VF VLAN strip

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-11-03 Thread Ferruh Yigit
On 11/3/2017 3:20 PM, Ferruh Yigit wrote: > On 11/3/2017 12:24 PM, Thomas Monjalon wrote: >> 03/11/2017 20:18, Mody, Rasesh: >>> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] On 11/2/2017 11:45 AM, Mody, Rasesh wrote: > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> On 11/2

[dpdk-dev] [PATCH] igb_uio: prevent reset for a list of devices

2017-11-03 Thread Ferruh Yigit
Some devices are having problem on device reset that happens during DPDK application exit [1]. Create a static list of devices and exclude them from device reset. [1] http://dpdk.org/ml/archives/dev/2017-November/080927.html Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of dev

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-11-03 Thread Ferruh Yigit
On 11/3/2017 12:24 PM, Thomas Monjalon wrote: > 03/11/2017 20:18, Mody, Rasesh: >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >>> On 11/2/2017 11:45 AM, Mody, Rasesh wrote: From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > On 11/2/2017 10:34 AM, Mody, Rasesh wrote: We are o

Re: [dpdk-dev] [PATCH v2] igb_uio: add config option to control reset

2017-11-03 Thread Ferruh Yigit
On 11/3/2017 12:42 PM, Roberts, Lee A. wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tan, Jianfeng >> Sent: Thursday, November 02, 2017 8:57 PM >> To: Ferruh Yigit ; Thomas Monjalon >> >> Cc: dev@dpdk.org; sta...@dpdk.org; Jingjing Wu ; >> Shi

[dpdk-dev] Valgrind with DPDK - Error in "EAL: Segment sanity check failed"

2017-11-03 Thread sreenaath vasudevan
Hi I am trying to run DPDK 2.2 example application "l2fwd" with valgrind and run in to the "Segment Sanity check failed" error. I tried with standard valgrind-3.10 and the modified one ( https://github.com/bisdn/valgrind-hugepages) and run in to the same issue Does anyone has any suggestions? Fol

[dpdk-dev] What's the point of RTE_MBUF_PREFETCH_TO_FREE()?

2017-11-03 Thread Mike Stolarchuk
It seems to be used to prefetch the mbuf in preparation for a free of an mbuf. But RTE_MBUF_PREFETCH_TO_FREE() currently does a prefetch for the ffirst cache line in the mbuf, but doesn't a free do a put to the mbuf's mempool? And isn't the mempool reference in the mbuf's second cache line? reg

Re: [dpdk-dev] [PATCH v2] igb_uio: add config option to control reset

2017-11-03 Thread Roberts, Lee A.
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tan, Jianfeng > Sent: Thursday, November 02, 2017 8:57 PM > To: Ferruh Yigit ; Thomas Monjalon > > Cc: dev@dpdk.org; sta...@dpdk.org; Jingjing Wu ; > Shijith Thotton > ; Gregory Etelson ; > Harish Patil > ; Ge

Re: [dpdk-dev] [PATCH v5 0/8] net/mlx4: Tx path improvements

2017-11-03 Thread Ferruh Yigit
On 11/2/2017 9:42 AM, Matan Azrad wrote: > v1: > This series is a follow-up of the new datapath implementation introduced in > RC1. > It is dedicated to Tx and improves the performance. > > v2: > Change uint32_t be_lkey to rte_be32_t lkey > > v3: > Rebase to 17.11-rc2. > Remove "net/mlx4: save l

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-11-03 Thread Thomas Monjalon
03/11/2017 20:18, Mody, Rasesh: > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > > On 11/2/2017 11:45 AM, Mody, Rasesh wrote: > > > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > > >> On 11/2/2017 10:34 AM, Mody, Rasesh wrote: > > > We are ok as we have at least some way to disable the

Re: [dpdk-dev] [PATCH v3 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power

2017-11-03 Thread Ferruh Yigit
On 11/3/2017 1:47 AM, Wei Dai wrote: > These 2 bugs can be observed from example/l3fwd-power run with i40e VF > bound to VFIO-PCI. The test steps are as follows: > 1. Disable LSC interrupt by clearing port_conf.intr_conf.lsc=0, as i40e >VF doesn't support LSC interrupt to avoid rte_eth_dev_conf

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-11-03 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, November 02, 2017 5:32 PM > > On 11/2/2017 11:45 AM, Mody, Rasesh wrote: > >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > >> Sent: Thursday, November 02, 2017 11:10 AM > >> > >> On 11/2/2017 10:34 AM, Mody, Rasesh wrot

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix filter parser error in L2 tunnel

2017-11-03 Thread Ferruh Yigit
On 11/3/2017 1:38 AM, Peng, Yuan wrote: > Tested-by: Peng Yuan Hi Yuan, Thanks for the testing. And related to the "Tested-by" tag, since it has also contains code patchwork thinks this is a new patch [1]. This both requires someone updating patchwork and mark that patch as invalid, and since

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix filter parser error in L2 tunnel

2017-11-03 Thread Ferruh Yigit
On 11/3/2017 12:38 AM, Wei Zhao wrote: > The action for L2 tunnel should be VF or PF, not QUEUE. > > Fixes: 99e7003831c ("net/ixgbe: parse L2 tunnel filter") > > Signed-off-by: Wei Zhao > Acked-by: Wei Dai Tested-by: Yuan Peng Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH] vhost: disable reply-ack protocol feature if iommu feature disabled

2017-11-03 Thread Maxime Coquelin
If the application has disabled VIRTIO_F_IOMMU_PLATFORM, disable VHOST_USER_PROTOCOL_F_REPLY_ACK protocol feature that is only mandatory with IOMMU for now. This is done to provide a way for the application to support multiqueue with old Qemu versions (v2.7.0 to v2.9.0) that have reply-ack feature

Re: [dpdk-dev] [PATCH v3 01/19] Revert "vhost: workaround MQ fails to startup"

2017-11-03 Thread Kavanagh, Mark B
>From: Thomas Monjalon [mailto:tho...@monjalon.net] >Sent: Friday, November 3, 2017 3:35 PM >To: Kavanagh, Mark B ; y...@fridaylinux.org >Cc: dev@dpdk.org; Maxime Coquelin ; Horton, Remy >; Bie, Tiwei ; m...@redhat.com; >jfrei...@redhat.com; vkapl...@redhat.com; jasow...@redhat.com; Mcnamara, John

Re: [dpdk-dev] [PATCH] vhost: postpone ring addresses translations at kick time only

2017-11-03 Thread Maxime Coquelin
Hi Lei, On 11/03/2017 04:52 PM, Maxime Coquelin wrote: If multiple queue pairs are created but all are not used, the device is never started, as unused queues aren't enabled and their ring addresses aren't translated. The device is changed to running state when all rings addresses are translated

Re: [dpdk-dev] [PATCH v3 17/19] vhost-user: iommu: postpone device creation until ring are mapped

2017-11-03 Thread Maxime Coquelin
On 11/03/2017 04:15 PM, Michael S. Tsirkin wrote: On Fri, Nov 03, 2017 at 09:25:58AM +0100, Maxime Coquelin wrote: On 11/02/2017 05:02 PM, Maxime Coquelin wrote: On 11/02/2017 09:21 AM, Maxime Coquelin wrote: Hi Lei, On 11/02/2017 08:21 AM, Yao, Lei A wrote: ... Hi, Maxime > I met o

[dpdk-dev] [PATCH] vhost: postpone ring addresses translations at kick time only

2017-11-03 Thread Maxime Coquelin
If multiple queue pairs are created but all are not used, the device is never started, as unused queues aren't enabled and their ring addresses aren't translated. The device is changed to running state when all rings addresses are translated. This patch fixes this by postponning rings addresses tr

Re: [dpdk-dev] [PATCH] doc: add limitation of VF VLAN strip function

2017-11-03 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Friday, November 3, 2017 3:41 AM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: add limitation of VF VLAN strip function > > This patch adds limitation of VF VLAN st

Re: [dpdk-dev] [PATCH v3 01/19] Revert "vhost: workaround MQ fails to startup"

2017-11-03 Thread Thomas Monjalon
02/11/2017 10:40, Maxime Coquelin: > Hi Mark, > > On 11/01/2017 06:11 PM, Kavanagh, Mark B wrote: > > Hi Maxime, > > > > First off, apologies for the lateness of this reply - I realize that this > > patch has already been upstreamed. > > No worries, great to see DPDK integration being tested be

Re: [dpdk-dev] [PATCH v2] doc: flow classify guides

2017-11-03 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Friday, November 3, 2017 11:14 AM > To: dev@dpdk.org; Mcnamara, John > Cc: Iremonger, Bernard > Subject: [PATCH v2] doc: flow classify guides > > The Flow Classify Library Programmers Guide documents > librte_flow_classify. > > T

Re: [dpdk-dev] [PATCH 1/2] doc: flow classify library prog guide

2017-11-03 Thread Iremonger, Bernard
Hi John, > > > > > > Subject: [PATCH 1/2] doc: flow classify library prog guide > > > > > > > > This file documents the Flow Classification library, > > librte_flow_classify. > > > > > > > > Updated MAINTAINERS file > > > > > > > > Signed-off-by: Bernard Iremonger > > > > > > Hi Bernard, > > >

[dpdk-dev] [PATCH v1] i40e: highlight change to flexible payload for RSS config

2017-11-03 Thread John McNamara
Add deprecation notice to highlight a future change in the default configuration behavior for flexible payload for RSS. Signed-off-by: John McNamara --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guid

Re: [dpdk-dev] [PATCH v3 4/6] eal/memory: rename memory API to iovatypes

2017-11-03 Thread Jonas Pfefferle1
"dev" wrote on 11/03/2017 02:58:43 PM: > From: Thomas Monjalon > To: santosh > Cc: dev@dpdk.org, olivier.m...@6wind.com, > jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com, > anatoly.bura...@intel.com > Date: 11/03/2017 02:59 PM > Subject: Re: [dpdk-dev] [PATCH v3 4/6] eal/memory: rename

Re: [dpdk-dev] [PATCH v3 17/19] vhost-user: iommu: postpone device creation until ring are mapped

2017-11-03 Thread Michael S. Tsirkin
On Fri, Nov 03, 2017 at 09:25:58AM +0100, Maxime Coquelin wrote: > > > On 11/02/2017 05:02 PM, Maxime Coquelin wrote: > > > > > > On 11/02/2017 09:21 AM, Maxime Coquelin wrote: > > > Hi Lei, > > > > > > On 11/02/2017 08:21 AM, Yao, Lei A wrote: > > > > > > > ... > > > > Hi, Maxime > I met one

Re: [dpdk-dev] [PATCH v3 01/19] Revert "vhost: workaround MQ fails to startup"

2017-11-03 Thread Maxime Coquelin
On 11/03/2017 02:05 PM, Yuanhan Liu wrote: On Thu, Nov 02, 2017 at 10:40:26AM +0100, Maxime Coquelin wrote: Moving from QEMU v2.7.0 to v2.10.0 resolves the issue. However, herein lies the issue: QEMU v2.10.0 was only released in August of this year; anecdotally, we know that many OvS-DPDK cu

Re: [dpdk-dev] [PATCH v2] net/mlx4: enhance Rx packet type offloads

2017-11-03 Thread Adrien Mazarguil
On Thu, Nov 02, 2017 at 02:14:34PM +0200, Moti Haimovsky wrote: > This patch enhances the Rx packet type offload to also report the L4 > protocol information in the hw ptype filled by the PMD for each received > packet. > > Signed-off-by: Moti Haimovsky > --- > V2: > * Modifications according to

Re: [dpdk-dev] [PATCH] examples: remove dependency on PCI

2017-11-03 Thread Bruce Richardson
On Fri, Nov 03, 2017 at 01:46:27PM +, Bruce Richardson wrote: > All PCI functionality should be hidden from apps via the PCI bus driver, > the EAL and individual device drivers. Therefore remove the inclusion of > rte_pci.h from sample apps. > > Signed-off-by: Bruce Richardson > --- Note, thi

Re: [dpdk-dev] [PATCH v3 4/6] eal/memory: rename memory API to iova types

2017-11-03 Thread Thomas Monjalon
03/11/2017 12:35, santosh: > On Friday 03 November 2017 04:41 PM, Thomas Monjalon wrote: > > 20/10/2017 14:31, Santosh Shukla: > >> Renamed memory translational api to _iova types. > >> The following api renamed from: > >> > >> rte_mempool_populate_phys() > >> rte_mempool_populate_phys_tab() > > Th

Re: [dpdk-dev] LINUX VF

2017-11-03 Thread Nishant Verma
Issue Resolved. This is because of NetworkManager service running on CentOs 7. After stopping that service everything works fine. On Mon, Oct 30, 2017 at 6:33 PM, Nishant Verma wrote: > Hi, > > I am trying to configure SRIOV on my SUPERMICRO BLADES. > I assigned 10G NIC to igb_uio. After that c

[dpdk-dev] [PATCH] examples: remove dependency on PCI

2017-11-03 Thread Bruce Richardson
All PCI functionality should be hidden from apps via the PCI bus driver, the EAL and individual device drivers. Therefore remove the inclusion of rte_pci.h from sample apps. Signed-off-by: Bruce Richardson --- examples/bond/main.c | 1 - examples/ethtool/lib

Re: [dpdk-dev] [PATCH] mem: remove old function from symbol list

2017-11-03 Thread Thomas Monjalon
03/11/2017 12:34, Gonzalez Monroy, Sergio: > Hi Thomas, > > I reckon you need to bump ABI version when you remove public symbol from > .map file. Yes, of course, unless it has already been dumped: http://dpdk.org/commit/f26ab687a74 > On 03/11/2017 11:24, Thomas Monjalon wrote: > > The

Re: [dpdk-dev] [PATCH 3/3] net/mlx5: adjust removal error

2017-11-03 Thread Adrien Mazarguil
On Thu, Nov 02, 2017 at 03:42:04PM +, Matan Azrad wrote: > Fail-safe PMD expects to get -ENODEV error value if sub PMD control > command fails because of device removal. > > Make control callbacks return with -ENODEV when the device has > disappeared. > > Signed-off-by: Matan Azrad In short

Re: [dpdk-dev] [PATCH 2/3] net/mlx4: adjust removal error

2017-11-03 Thread Adrien Mazarguil
On Thu, Nov 02, 2017 at 03:42:03PM +, Matan Azrad wrote: > Fail-safe PMD expects to get -ENODEV error value if sub PMD control > command fails because of device removal. > > Make control callbacks return with -ENODEV when the device has > disappeared. > > Signed-off-by: Matan Azrad I think

Re: [dpdk-dev] [PATCH v3 01/19] Revert "vhost: workaround MQ fails to startup"

2017-11-03 Thread Yuanhan Liu
On Thu, Nov 02, 2017 at 10:40:26AM +0100, Maxime Coquelin wrote: > >Moving from QEMU v2.7.0 to v2.10.0 resolves the issue. However, herein lies > >the issue: QEMU v2.10.0 was only released in August of this year; > >anecdotally, we know that many OvS-DPDK customers use older versions of QEMU > >

Re: [dpdk-dev] [PATCH v2] ring: guarantee ordering of cons/prod loading when doing

2017-11-03 Thread Jerin Jacob
-Original Message- > Date: Fri, 3 Nov 2017 09:46:40 +0800 > From: Jia He > To: Jerin Jacob > Cc: dev@dpdk.org, olivier.m...@6wind.com, konstantin.anan...@intel.com, > bruce.richard...@intel.com, jianbo@arm.com, hemant.agra...@nxp.com, > jie2@hxt-semitech.com, bing.z...@hxt-semit

[dpdk-dev] [PATCH] eal/x86: revert select optimized memcpy at run-time

2017-11-03 Thread Xiaoyun Li
This patch reverts the patchset run-time Linking support including the following 3 commits: commit 84cc318424d4 ("eal/x86: select optimized memcpy at run-time") commit c7fbc80fe60f ("test: select memcpy alignment unit at run-time") commit 5f180ae32962 ("efd: move AVX2 lookup in its own compilation

Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue

2017-11-03 Thread Jerin Jacob
-Original Message- > Date: Fri, 3 Nov 2017 10:55:40 +0800 > From: Jia He > To: Jerin Jacob > Cc: "Ananyev, Konstantin" , "Zhao, Bing" > , Olivier MATZ , > "dev@dpdk.org" , "jia...@hxt-semitech.com" > , "jie2@hxt-semitech.com" > , "bing.z...@hxt-semitech.com" > , "Richardson, Bruc

Re: [dpdk-dev] [PATCH] examples/flow_classify: fix fseek error handling

2017-11-03 Thread Singh, Jasvinder
> -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, November 1, 2017 12:10 PM > To: dev@dpdk.org; Singh, Jasvinder > Cc: Iremonger, Bernard > Subject: [PATCH] examples/flow_classify: fix fseek error handling > > Check return value of fseek and exit if non zero. > > Cove

[dpdk-dev] [PATCH] pci: get IOMMU class sPAPR iommu fix

2017-11-03 Thread Jonas Pfefferle
PPC64 sPAPR iommu does not support iova as va. Use pa mode instead. Signed-off-by: Jonas Pfefferle --- drivers/bus/pci/linux/pci.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c index cdf8106..6a58c5f 1006

Re: [dpdk-dev] [PATCH v3 4/6] eal/memory: rename memory API to iova types

2017-11-03 Thread santosh
On Friday 03 November 2017 04:41 PM, Thomas Monjalon wrote: > 20/10/2017 14:31, Santosh Shukla: >> Renamed memory translational api to _iova types. >> The following api renamed from: >> >> rte_mempool_populate_phys() >> rte_mempool_populate_phys_tab() > These functions still have "physical address

Re: [dpdk-dev] [PATCH] mem: remove old function from symbol list

2017-11-03 Thread Gonzalez Monroy, Sergio
Hi Thomas, I reckon you need to bump ABI version when you remove public symbol from .map file. Thanks, Sergio On 03/11/2017 11:24, Thomas Monjalon wrote: The function rte_mem_phy2mch() was removed with the support of Xen dom0. Fixes: a7cb2e20d23c ("mem: remove API to get physical address in

Re: [dpdk-dev] [PATCH v7 7/9] linuxapp/eal_vfio: honor iova mode before mapping

2017-11-03 Thread Jonas Pfefferle1
Thomas Monjalon wrote on 11/03/2017 11:54:45 AM: > From: Thomas Monjalon > To: Jonas Pfefferle1 > Cc: acon...@redhat.com, Alexey Kardashevskiy , > anatoly.bura...@intel.com, bruce.richard...@intel.com, dev@dpdk.org, > gaetan.ri...@6wind.com, hemant.agra...@nxp.com, > jerin.ja...@caviumnetworks.

[dpdk-dev] [PATCH] mem: remove old function from symbol list

2017-11-03 Thread Thomas Monjalon
The function rte_mem_phy2mch() was removed with the support of Xen dom0. Fixes: a7cb2e20d23c ("mem: remove API to get physical address in dom0") Signed-off-by: Thomas Monjalon --- lib/librte_eal/rte_eal_version.map | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_eal/rte_eal_versio

[dpdk-dev] [PATCH] net/e1000: fix cannot getting Rx interrupts issue

2017-11-03 Thread Xiaoyun Li
When using VFIO and MSIX interrupt mode, cannot get Rx interrupts. Because the interrupt vectors that are used by VFIO are not enabled. This patch fixes this issue. Fixes: c3cd3de0ab50 ("igb: enable Rx queue interrupts for PF") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun Li --- drivers/net/e1000

[dpdk-dev] [PATCH v2] doc: flow classify guides

2017-11-03 Thread Bernard Iremonger
The Flow Classify Library Programmers Guide documents librte_flow_classify. The Flow Classify Sample Application Guide documents the flow_classify sample application which is used to demonstate the use of the Flow Classify Library, librte_flow_classify. Updated MAINTAINERS file Signed-off-by: Be

[dpdk-dev] [PATCH v2] flow classify documentation

2017-11-03 Thread Bernard Iremonger
This patch set contains documention files for the Flow Classify library and the Flow Classify sample application and updates the MAINTAINERS file. Changes in v2: Squashed into 1 patch. Fixed typos. Replaced the compiling section in the Flow Classify sample app guide with a reference to the standar

Re: [dpdk-dev] [PATCH v3 4/6] eal/memory: rename memory API to iova types

2017-11-03 Thread Thomas Monjalon
20/10/2017 14:31, Santosh Shukla: > Renamed memory translational api to _iova types. > The following api renamed from: > > rte_mempool_populate_phys() > rte_mempool_populate_phys_tab() These functions still have "physical addresses" in their description. It is not consistent. Please provide ABI

Re: [dpdk-dev] [PATCH v7 7/9] linuxapp/eal_vfio: honor iova mode before mapping

2017-11-03 Thread Thomas Monjalon
03/11/2017 11:44, Jonas Pfefferle1: > Thomas Monjalon wrote on 11/03/2017 11:28:10 AM: > > 03/11/2017 10:56, Jonas Pfefferle1: > > > Thomas Monjalon wrote on 11/02/2017 11:17:10 AM: > > > > > 26/10/2017 14:57, Jonas Pfefferle1: > > > > > > > > > > > > Hi @all > > > > > > > > > > > > I just stumbl

Re: [dpdk-dev] [PATCH v7 7/9] linuxapp/eal_vfio: honor iova mode before mapping

2017-11-03 Thread Jonas Pfefferle1
Thomas Monjalon wrote on 11/03/2017 11:28:10 AM: > From: Thomas Monjalon > To: Jonas Pfefferle1 > Cc: acon...@redhat.com, anatoly.bura...@intel.com, > bruce.richard...@intel.com, dev@dpdk.org, gaetan.ri...@6wind.com, > hemant.agra...@nxp.com, jerin.ja...@caviumnetworks.com, > maxime.coque...@re

[dpdk-dev] [PATCH v2] examples/l3fwd: fix aliasing in port grouping

2017-11-03 Thread Guduri Prathyusha
With -f-strict-aliasing enabled by default from -O2, gcc > 5.x gives undefined behavior in port_groupx4 in ARM. 'pn' and 'pnum' are two different pointers pointing to same chunk of memory and with -f-strict-aliasing the pointers are assumed to be pointing to different memory and compiler reorders i

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: fix Rx queue interrupt mapping in VF

2017-11-03 Thread Wu, Jingjing
> -Original Message- > From: Dai, Wei > Sent: Friday, November 3, 2017 4:48 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: [PATCH v3 2/2] net/i40e: fix Rx queue interrupt mapping in VF > > When a VF port is bound to VFIO-PCI, miscellaneous

Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: fix VFIO interrupt mapping in VF

2017-11-03 Thread Wu, Jingjing
> -Original Message- > From: Dai, Wei > Sent: Friday, November 3, 2017 4:47 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: [PATCH v3 1/2] net/i40e: fix VFIO interrupt mapping in VF > > When a VF port is bound to VFIO-PIC, only miscellaneou

Re: [dpdk-dev] [PATCH v7 7/9] linuxapp/eal_vfio: honor iova mode before mapping

2017-11-03 Thread Thomas Monjalon
03/11/2017 10:56, Jonas Pfefferle1: > Thomas Monjalon wrote on 11/02/2017 11:17:10 AM: > > > 26/10/2017 14:57, Jonas Pfefferle1: > > > > > > > > Hi @all > > > > > > > > I just stumbled upon this patch while testing on POWER. RTE_IOVA_VA > > will > > > > not work for the sPAPR code since the dma wi

[dpdk-dev] [PATCH] maintainers: resign from mlx4 maintenance

2017-11-03 Thread Nelio Laranjeiro
I have been a little too busy these past months and could not follow all the re-work of this PMD. So the best thing for this PMD would be to move the mlx4 maintenance to more involved people. Cc: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-

Re: [dpdk-dev] [PATCH v7 7/9] linuxapp/eal_vfio: honor iova mode before mapping

2017-11-03 Thread Jonas Pfefferle1
"dev" wrote on 11/02/2017 11:26:57 AM: > From: "Jonas Pfefferle1" > To: Thomas Monjalon > Cc: acon...@redhat.com, anatoly.bura...@intel.com, > bruce.richard...@intel.com, dev@dpdk.org, gaetan.ri...@6wind.com, > hemant.agra...@nxp.com, jerin.ja...@caviumnetworks.com, > maxime.coque...@redhat.com

Re: [dpdk-dev] [PATCH 1/2] doc: flow classify library prog guide

2017-11-03 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Thursday, November 2, 2017 5:29 PM > To: Mcnamara, John ; dev@dpdk.org > Cc: Iremonger, Bernard > Subject: RE: [PATCH 1/2] doc: flow classify library prog guide > > Hi John, > > > > > > Subject: [PATCH 1/2] doc: flow classify li

Re: [dpdk-dev] [PATCH v1] net/failsafe: fix VLAN stripping configuration

2017-11-03 Thread Ophir Munk
Hi, Please see below > -Original Message- > From: Gaƫtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Thursday, November 02, 2017 4:16 PM > To: Ophir Munk > Cc: dev@dpdk.org; Thomas Monjalon ; Olga Shern > ; sta...@dpdk.org > Subject: Re: [PATCH v1] net/failsafe: fix VLAN stripping confi

Re: [dpdk-dev] [PATCH v5 0/8] net/mlx4: Tx path improvements

2017-11-03 Thread Adrien Mazarguil
On Thu, Nov 02, 2017 at 01:41:39PM -0700, Ferruh Yigit wrote: > On 11/2/2017 9:42 AM, Matan Azrad wrote: > > v1: > > This series is a follow-up of the new datapath implementation introduced in > > RC1. > > It is dedicated to Tx and improves the performance. > > > > v2: > > Change uint32_t be_lkey

[dpdk-dev] [PATCH v1] mk: allow use of toolchain cflags

2017-11-03 Thread David Hunt
From: Vipin Varghese with 'export TOOLCHAIN_CFLAGS' the values are not inherited throuhout make system. The change appends the user defined cflags. Signed-off-by: Vipin Varghese Signed-off-by: David Hunt --- mk/toolchain/clang/rte.vars.mk | 6 +++--- mk/toolchain/gcc/rte.vars.mk | 6 +++---

Re: [dpdk-dev] [PATCH v3 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power

2017-11-03 Thread Dai, Wei
> -Original Message- > From: Dai, Wei > Sent: Friday, November 3, 2017 4:47 PM > To: Wu, Jingjing ; Xing, Beilei > > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v3 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power > > These 2 bugs can be observed from example/l3fwd-power run w

[dpdk-dev] [PATCH v3 1/2] net/i40e: fix VFIO interrupt mapping in VF

2017-11-03 Thread Wei Dai
When a VF port is bound to VFIO-PIC, only miscellaneous interrupt is mapped to VFIO vector 0 in i40evf_dev_init( ). In i40evf_dev_interrupt_handle( ) and i40evf_dev_rx_queue_intr_enable( ), if previous VFIO interrupt mapping set in i40evf_dev_init( ) is not cleared, it will fail when PMD tries to m

[dpdk-dev] [PATCH v3 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power

2017-11-03 Thread Wei Dai
These 2 bugs can be observed from example/l3fwd-power run with i40e VF bound to VFIO-PCI. The test steps are as follows: 1. Disable LSC interrupt by clearing port_conf.intr_conf.lsc=0, as i40e VF doesn't support LSC interrupt to avoid rte_eth_dev_configure() failure. 2. Create a VF from i40e hos

[dpdk-dev] [PATCH v3 2/2] net/i40e: fix Rx queue interrupt mapping in VF

2017-11-03 Thread Wei Dai
When a VF port is bound to VFIO-PCI, miscellaneous interrupt is mapped to MSI-X vector 0 and Rx queues interrupt are mapped to other vectors in vfio_enable_msix( ). To simplify implementation, all VFIO-PCI bound i40e VF Rx queue interrupts can be mapped in vector 1. And as current igb_uio only supp

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix filter parser error in L2 tunnel

2017-11-03 Thread Peng, Yuan
Tested-by: Peng Yuan - Tested Branch: dpdk-master - Tested Commit: commit 6fb00f8baefa03b9cfd1b2dfc1787258b8459601 - OS: 4.8.6-300.fc25.x86_64 - GCC: gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1) - CPU: Intel(R) Xeon(R) CPU D-1541 @ 2.10GHz - NIC: X552/X557-AT 10GBASE-T [8086:15ad] - Default x86_64-

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix filter parser error in L2 tunnel

2017-11-03 Thread Peng, Yuan
Tested-by: Peng Yuan - Tested Branch: dpdk-master - Tested Commit: commit 6fb00f8baefa03b9cfd1b2dfc1787258b8459601 - OS: 4.8.6-300.fc25.x86_64 - GCC: gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1) - CPU: Intel(R) Xeon(R) CPU D-1541 @ 2.10GHz - NIC: X552/X557-AT 10GBASE-T [8086:15ad] - Default x86_64-

Re: [dpdk-dev] [PATCH v2 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power

2017-11-03 Thread Yao, Lei A
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Dai > Sent: Friday, November 3, 2017 3:14 PM > To: Wu, Jingjing ; Xing, Beilei > ; Liang, Cunming > Cc: dev@dpdk.org; Dai, Wei > Subject: [dpdk-dev] [PATCH v2 0/2] Fix 2 bugs of i40e VF interrupt found in >

Re: [dpdk-dev] [PATCH v3 17/19] vhost-user: iommu: postpone device creation until ring are mapped

2017-11-03 Thread Maxime Coquelin
On 11/02/2017 05:02 PM, Maxime Coquelin wrote: On 11/02/2017 09:21 AM, Maxime Coquelin wrote: Hi Lei, On 11/02/2017 08:21 AM, Yao, Lei A wrote: ... Hi, Maxime > I met one issue with your patch set during the v17.11 test. Is it with v17.11-rc2 or -rc1? The test scenario is following,

[dpdk-dev] [PATCH v4] net/ixgbe: fix filter parser error in L2 tunnel

2017-11-03 Thread Wei Zhao
The action for L2 tunnel should be VF or PF, not QUEUE. Fixes: 99e7003831c ("net/ixgbe: parse L2 tunnel filter") Signed-off-by: Wei Zhao Acked-by: Wei Dai --- v2: -add vf id check. v3: -add action support for PF. v4: -fix action type check error --- drivers/net/ixgbe/ixgbe_flow.c | 29

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-11-03 Thread Yao, Lei A
Hi, Thomas > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, November 2, 2017 6:45 PM > To: Wang, Zhihong ; Li, Xiaoyun > > Cc: dev@dpdk.org; Richardson, Bruce ; > Ananyev, Konstantin ; Lu, Wenzhuo > ; Zhang, Helin ; > ophi...@me

[dpdk-dev] [PATCH v2 2/2] net/i40e: fix Rx queue interrupt mapping in VF

2017-11-03 Thread Wei Dai
When a VF port is bound to VFIO-PCI, miscellaneous interrupt is mapped to MSI-X vector 0 and Rx queues interrupt are mapped to other vectors in vfio_enable_msix( ). To simplify implementation, all VFIO-PCI bound i40e VF Rx queue interrupts can be mapped in vector 1. And as current igb_uio only supp

[dpdk-dev] [PATCH v2 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power

2017-11-03 Thread Wei Dai
These 2 bugs can be observed from example/l3fwd-power run with i40e VF bound to VFIO-PCI. The test steps are as follows: 1. Disable LSC interrupt by clearing port_conf.intr_conf.lsc=0, as i40e VF doesn't support LSC interrupt to avoid rte_eth_dev_configure() failure. 2. Create a VF from i40e hos

[dpdk-dev] [PATCH v2 1/2] net/i40e: fix VFIO interrupt mapping in VF

2017-11-03 Thread Wei Dai
When a VF port is bound to VFIO-PIC, only miscellaneous interrupt is mapped to VFIO vector 0 in i40evf_dev_init( ). In i40evf_dev_interrupt_handle( ) and i40evf_dev_rx_queue_intr_enable( ), if previous VFIO interrupt mapping set in i40evf_dev_init( ) is not cleared, it will fail when PMD tries to m