Re: [dpdk-dev] [PATCH 2/3] ring: guarantee load ordering of cons/prod when doing enqueue/dequeue

2017-11-07 Thread Jerin Jacob
-Original Message- > Date: Wed, 8 Nov 2017 06:17:11 + > From: Jia He > To: jerin.ja...@caviumnetworks.com, dev@dpdk.org, olivier.m...@6wind.com > Cc: konstantin.anan...@intel.com, bruce.richard...@intel.com, > jianbo@arm.com, hemant.agra...@nxp.com, Jia He , > jie2@hxt-semit

Re: [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb()

2017-11-07 Thread Jerin Jacob
-Original Message- > Date: Wed, 8 Nov 2017 06:17:10 + > From: Jia He > To: jerin.ja...@caviumnetworks.com, dev@dpdk.org, olivier.m...@6wind.com > Cc: konstantin.anan...@intel.com, bruce.richard...@intel.com, > jianbo@arm.com, hemant.agra...@nxp.com, Jia He , > jia...@hxt-semitec

[dpdk-dev] [PATCH] eal/random: fix a wrong comment

2017-11-07 Thread Jerin Jacob
Fixes: af75078fece3 ("first public release") Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/rte_random.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_random.h b/lib/librte_eal/common/include/rte_random.h index 24ae83632..aef

[dpdk-dev] [PATCH 3/3] config: support C11 memory model for arm64

2017-11-07 Thread Jia He
by default, CONFIG_RTE_RING_USE_C11_MEM_MODEL is y on arm64 Signed-off-by: Jia He Signed-off-by: jia...@hxt-semitech.com --- config/common_armv8a_linuxapp | 1 + 1 file changed, 1 insertion(+) diff --git a/config/common_armv8a_linuxapp b/config/common_armv8a_linuxapp index 6732d1e..1bf6e4d 1006

[dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb()

2017-11-07 Thread Jia He
for the code as follows: if (condition) rte_smp_rmb(); else rte_smp_wmb(); Without this patch, compiler will report this error: error: 'else' without a previous 'if' Signed-off-by: Jia He Signed-off-by: jia...@hxt-semitech.com --- lib/librte_eal/common/include/arch/arm/rte_atomic

[dpdk-dev] [PATCH 2/3] ring: guarantee load ordering of cons/prod when doing enqueue/dequeue

2017-11-07 Thread Jia He
We watched a rte panic of mbuf_autotest in our qualcomm arm64 server. As for the possible race condition, please refer to [1]. Furthermore, to fix this race, there are 2 options as suggested by Jerin: 1. use rte_smp_rmb 2. use load_acquire/store_release(refer to [2]). CONFIG_RTE_RING_USE_C11_MEM_M

Re: [dpdk-dev] [PATCH v6 1/2] eal: add uevent monitor for hot plug

2017-11-07 Thread Guo, Jia
Thanks Stephen for your eye on review, would collect other comment and refine it better in next version. Best regards, Jeff Guo -Original Message- From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Thursday, November 2, 2017 5:42 AM To: Guo, Jia Cc: Richardson, Bruce ; Y

Re: [dpdk-dev] [PATCH v2] igb_uio: remove device reset in release

2017-11-07 Thread Wu, Jingjing
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, November 8, 2017 7:57 AM > To: Yigit, Ferruh > Cc: dev@dpdk.org; sta...@dpdk.org; Tan, Jianfeng ; > Wu, Jingjing ; Shijith Thotton > ; Gregory Etelson ; > Harish Patil ; George Prekas > ; Gonzale

Re: [dpdk-dev] [PATCH 1/8] net/qede: fix to disable per-VF Tx switching feature

2017-11-07 Thread Patil, Harish
-Original Message- From: Thomas Monjalon Date: Tuesday, November 7, 2017 at 6:44 PM To: Harish Patil Cc: "ferruh.yi...@intel.com" , "dev@dpdk.org" , Dept-Eng DPDK Dev , "Mody, Rasesh" Subject: Re: [dpdk-dev] [PATCH 1/8] net/qede: fix to disable per-VF Tx switching feature >08/11/2017 0

Re: [dpdk-dev] [PATCH v2] ring: guarantee ordering of cons/prod loading when doing

2017-11-07 Thread Jia He
Hi Jerin Thank you, I mistakenly think x86 doen't need rte_smp_rmb(). Since rte_smp_rmb() only impact x86's compiler optimization, I will simplify the codes as your suggestions Cheers, Jia On 11/7/2017 5:57 PM, Jerin Jacob Wrote: -Original Message- Date: Tue, 7 Nov 2017 16:34:30

[dpdk-dev] [dpdk-announce] release candidate 17.11-rc3

2017-11-07 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: http://dpdk.org/browse/dpdk/tag/?id=v17.11-rc3 What's new in RC3? - igb_uio reset fixed again - EAL VDEV moved to bus driver - EAL, mempool and mbuf adapted to IOVA wording - rte_memcpy optimization reverted

[dpdk-dev] compilation error in softnic PMD

2017-11-07 Thread Thomas Monjalon
Hi, There is an error when compiling on SUSE11SP2: drivers/net/softnic/rte_eth_softnic_tm.c:588:3: error: unknown field ‘nonleaf’ specified in initializer It is probably the same cause as in this recent ixgbe fix: http://dpdk.org/commit/a8c839a675b

Re: [dpdk-dev] [PATCH] maintainers: claim maintainership of VDEV bus

2017-11-07 Thread Yang, Zhiyong
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, November 8, 2017 9:12 AM > To: Tan, Jianfeng > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] maintainers: claim maintainership of VDEV bus > > 08/11/2017 02:07, Jianfeng T

Re: [dpdk-dev] [PATCH] doc: adjust column width of PMD overview tables

2017-11-07 Thread Thomas Monjalon
> > The net PMD overview table is big and required to be shrinked. > > The crypto PMD tables had variable column sizes: the latest columns were > > smaller. > > > > The minimum width is set to 0.9em without any forced padding. > > The maximum width is set to 2em. > > The width of the first column

Re: [dpdk-dev] [PATCH] doc: move dom0 removal notice in removed items

2017-11-07 Thread Thomas Monjalon
06/11/2017 15:45, Thomas Monjalon: > Since the release notes has a new section for removed items, > the dom0 removal notice can be moved there. > > Signed-off-by: Thomas Monjalon Applied

Re: [dpdk-dev] [PATCH 1/8] net/qede: fix to disable per-VF Tx switching feature

2017-11-07 Thread Thomas Monjalon
08/11/2017 02:34, Patil, Harish: > >> --- a/config/common_base > >> +++ b/config/common_base > >> +CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=n > > > >We should remove all compile-time options because they cannot be used > >when DPDK is pre-packaged. > >That's why the rule is "NO NEW COMPILE TIME OPTION".

Re: [dpdk-dev] [PATCH 1/8] net/qede: fix to disable per-VF Tx switching feature

2017-11-07 Thread Patil, Harish
-Original Message- From: Thomas Monjalon Date: Tuesday, November 7, 2017 at 5:53 PM To: "Mody, Rasesh" Cc: "dev@dpdk.org" , Harish Patil , "ferruh.yi...@intel.com" , Dept-Eng DPDK Dev Subject: Re: [dpdk-dev] [PATCH 1/8] net/qede: fix to disable per-VF Tx switching feature >Hi, > >07/11/

Re: [dpdk-dev] [PATCH] doc: update release note for DPAA2 Event PMD

2017-11-07 Thread Thomas Monjalon
> > Signed-off-by: Shreyansh Jain > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] maintainers: claim maintainership of VDEV bus

2017-11-07 Thread Thomas Monjalon
08/11/2017 02:07, Jianfeng Tan: > VDEV bus driver > +M: Jianfeng Tan > F: drivers/bus/vdev/ Acked-by: Thomas Monjalon Thanks for your work on vdev bus driver.

Re: [dpdk-dev] [PATCH] doc: update IPSec Multi-buffer lib versioning

2017-11-07 Thread Thomas Monjalon
07/11/2017 10:55, Pablo de Lara: > A new library of the IPSec Multi-buffer library has been > released (0.47), which is used by the AESNI GCM PMD. > > Signed-off-by: Pablo de Lara Applied, thanks

Re: [dpdk-dev] [PATCH v2] doc: update release notes for rte_security

2017-11-07 Thread Thomas Monjalon
07/11/2017 07:44, Akhil Goyal: > Removed the deprication notice for ABI breakage and updated > release notes for rte_security. > > Signed-off-by: Akhil Goyal Applied, thanks

[dpdk-dev] [PATCH] maintainers: claim maintainership of VDEV bus

2017-11-07 Thread Jianfeng Tan
Signed-off-by: Jianfeng Tan --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8d45ad0..6bd620d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -297,6 +297,7 @@ PCI bus driver F: drivers/bus/pci/ VDEV bus driver +M: Jianfeng Tan F: drivers/bus/

Re: [dpdk-dev] [PATCH] doc: fix a typo in DPDK programmer's guide

2017-11-07 Thread Thomas Monjalon
> > This patch fixes a trivial typo in DPDK programmer's guide: > > it should be rte_cpu_get_features() instead of rte_cpu_get_feature(). > > > > Signed-off-by: Rami Rosen > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH 1/8] net/qede: fix to disable per-VF Tx switching feature

2017-11-07 Thread Thomas Monjalon
Hi, 07/11/2017 09:34, Rasesh Mody: > From: Harish Patil > > Provide a knob to control per-VF Tx switching feature by adding a config > option, CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH. By default, it will be kept > in disabled state for better performance with small sized frames. > > Fixes: 2ea6f76a

[dpdk-dev] [PATCH] [18.02-rc2] net/qede: remove VF Tx switch option

2017-11-07 Thread Thomas Monjalon
The compile-time option CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH has been added just before the 17.11 release. Such new options are forbidden and must be replaced by a run-time option. If it is not replaced in 18.02-rc1, this removal will be applied. Signed-off-by: Thomas Monjalon --- config/common_b

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/qede: fix icc build

2017-11-07 Thread Thomas Monjalon
08/11/2017 00:38, Ferruh Yigit: > observed icc version "icc (ICC) 18.0.0 20170811" > > build error: > .../dpdk/drivers/net/qede/qede_ethdev.c(1475): > error #279: controlling expression is constant > assert(false && "Unable to start periodic timer"); > ^ > > Warning di

Re: [dpdk-dev] [PATCH v2] igb_uio: remove device reset in release

2017-11-07 Thread Thomas Monjalon
07/11/2017 23:29, Ferruh Yigit: > More error reported for device reset in release() [1], > when device pass-through to the guest, host kernel crash on guest exit. > > Removing the reset completely. > > This is close to reverting commit b58eedfc7dd5 [2], taking into account > previous fix to remov

Re: [dpdk-dev] [PATCH v2] devtools: add script to get maintainers from patch

2017-11-07 Thread Thomas Monjalon
08/11/2017 00:41, Ferruh Yigit: > On 11/7/2017 3:35 PM, Thomas Monjalon wrote: > > Have you tried to send a patch to Linux > > in order to avoid the workaround below? > > No, not tried, but that list looks like put intentionally so not sure if a > patch > helps. checkpatch has an option to be ru

Re: [dpdk-dev] [PATCH v2] devtools: add script to get maintainers from patch

2017-11-07 Thread Ferruh Yigit
On 11/7/2017 3:35 PM, Thomas Monjalon wrote: > 04/08/2017 16:01, Ferruh Yigit: >> This is a wrapper to Linux kernel get_maintainer.pl file and only >> supports parsing MAINTAINERS file (no git fallback etc..) >> >> Requires DPDK_GETMAINTAINER_PATH devel config option set, please check >> devtools/l

[dpdk-dev] [PATCH] net/qede: fix icc build

2017-11-07 Thread Ferruh Yigit
observed icc version "icc (ICC) 18.0.0 20170811" build error: .../dpdk/drivers/net/qede/qede_ethdev.c(1475): error #279: controlling expression is constant assert(false && "Unable to start periodic timer"); ^ Warning disabled in Makefile. Fixes: 2af14ca79c0a ("net

Re: [dpdk-dev] [PATCH v2] devtools: add script to get maintainers from patch

2017-11-07 Thread Thomas Monjalon
04/08/2017 16:01, Ferruh Yigit: > This is a wrapper to Linux kernel get_maintainer.pl file and only > supports parsing MAINTAINERS file (no git fallback etc..) > > Requires DPDK_GETMAINTAINER_PATH devel config option set, please check > devtools/load-devel-config. > > DPDK_GETMAINTAINER_PATH shou

Re: [dpdk-dev] [PATCH v5] devtools: rework abi checker script

2017-11-07 Thread Thomas Monjalon
05/10/2017 09:53, Olivier Matz: > The initial version of the script had some limitations: > - cannot work on a non-clean workspace > - environment variables are not documented > - no compilation log in case of failure > - return success even it abi is incompatible > > This patch addresses these is

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix tunneled TCP/UDP packet type

2017-11-07 Thread Ferruh Yigit
On 11/7/2017 11:04 AM, Yongseok Koh wrote: > If tunneled bit is set in the HW descriptor, the l4_hdr_type bits describe > the inner packet. > > Fixes: ea16068c0064 ("net/mlx5: fix L4 packet type support") > Cc: sta...@dpdk.org > > Reported-by: Li Xueming > Signed-off-by: Yongseok Koh > Acked-by

Re: [dpdk-dev] [PATCH 0/8] net/qede: coverity issue fixes and bug fixes

2017-11-07 Thread Ferruh Yigit
On 11/7/2017 12:34 AM, Rasesh Mody wrote: > Hi, > > This patch set contains fixes for issues reported by coverity and > other bug fixes. > > Please include in DPDK 17.11. > > Thanks! > -Rasesh > > Harish Patil (2): > net/qede: fix to disable per-VF Tx switching feature > net/qede: fix vxlan

Re: [dpdk-dev] [PATCH] devtools: rename build dependency of mlx drivers

2017-11-07 Thread Thomas Monjalon
11/10/2017 16:39, Nélio Laranjeiro: > On Wed, Oct 11, 2017 at 03:28:58PM +0200, Thomas Monjalon wrote: > > The Mellanox drivers were requiring MOFED at compilation time. > > It is now possible to use the upstream rdma-core package. > > So the dependency option is renamed in the build tool. > > > >

Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind.py: fix broken Python 3 support

2017-11-07 Thread Thomas Monjalon
06/10/2017 23:38, Omri Mor: > When using Python 3, dpdk-devbind.py fails to detect modules other than > igb_uio. > > Signed-off-by: Omri Mor Applied, thanks

[dpdk-dev] [PATCH v2] igb_uio: remove device reset in release

2017-11-07 Thread Ferruh Yigit
More error reported for device reset in release() [1], when device pass-through to the guest, host kernel crash on guest exit. Removing the reset completely. This is close to reverting commit b58eedfc7dd5 [2], taking into account previous fix to remove reset in open as well [3], but not exactly s

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] igb_uio: prevent reset for a list of devices

2017-11-07 Thread Ferruh Yigit
On 11/7/2017 12:47 PM, Chas Williams wrote: > I will confess I haven't looked into the issue too hard since I have a > workaround.  My first guess is that there is something going on with the IOMMU > and quiescing a PCI pass-through device/function from the guest (since I don't > think the IOMMU is

Re: [dpdk-dev] [PATCH] buildtools: add null point check for calloc

2017-11-07 Thread Thomas Monjalon
15/09/2017 13:33, Yong Wang: > In func locate_pmd_entries(), pointer 'new' returned from call to func > 'calloc' may be NULL. It is dereferenced without null point check. > > Signed-off-by: Yong Wang Applied, thanks

Re: [dpdk-dev] [PATCH] eventdev: remove experimental label

2017-11-07 Thread Thomas Monjalon
> Acked-by: Gage Eads Acked-by: Thomas Monjalon Applied, thanks

Re: [dpdk-dev] [PATCH v3] doc: add event eth Rx adapter programmer's guide

2017-11-07 Thread Thomas Monjalon
24/10/2017 11:13, Nikhil Rao: > Add programmer's guide doc to explain the use of the > Event Ethernet Rx Adapter library. > > Signed-off-by: Nikhil Rao > Acked-by: Jerin Jacob Applied, thanks

Re: [dpdk-dev] [PATCH v2] doc: flow classify guides

2017-11-07 Thread Thomas Monjalon
> > The Flow Classify Library Programmers Guide documents > > librte_flow_classify. > > > > The Flow Classify Sample Application Guide documents the flow_classify > > sample application which is used to demonstate the use of the Flow > > Classify Library, librte_flow_classify. > > > > Updated MAI

Re: [dpdk-dev] [PATCH v2] doc: add basic howto for flow API

2017-11-07 Thread Thomas Monjalon
> > As the rte flow is a new complex module in the DPDK. > > In order to ease developers in to using this feature it was suggested to > > supply a simple howto doc. > > > > Signed-off-by: Ori Kam > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH v3] examples/flow_filtering: demo of simple rte flow

2017-11-07 Thread Thomas Monjalon
01/11/2017 10:42, Ori Kam: > This application shows a simple usage of the > rte_flow API for hardware filtering offloading. > > In this demo we are filtering specific IP to > specific target queue, while sending all the > rest of the packets to other queue. > > Signed-off-by: Ori Kam Applied, t

[dpdk-dev] DPDK memory error check and offline bad pages

2017-11-07 Thread Jianjian Huo
Hi dpdk developers, I have a question regarding how DPDK memory module treats memory errors. In Linux kernel, it has mechanism (mcelog and EDAC) to monitor the memory controller and report correctable/uncorrectable memory errors. Using some configurations, if memory errors exceed threshold, sys

Re: [dpdk-dev] [PATCH] examples: remove dependency on PCI

2017-11-07 Thread Thomas Monjalon
03/11/2017 14:46, Bruce Richardson: > All PCI functionality should be hidden from apps via the PCI bus driver, > the EAL and individual device drivers. Therefore remove the inclusion of > rte_pci.h from sample apps. > > Signed-off-by: Bruce Richardson Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] igb_uio: prevent reset for a list of devices

2017-11-07 Thread Chas Williams
I will confess I haven't looked into the issue too hard since I have a workaround. My first guess is that there is something going on with the IOMMU and quiescing a PCI pass-through device/function from the guest (since I don't think the IOMMU is "visible" to the guest) seems iffy. Most devices h

Re: [dpdk-dev] [PATCH] app/testpmd: fix incomplete error message

2017-11-07 Thread Thomas Monjalon
07/11/2017 19:11, Pablo de Lara: > Fixes: 3e2006d6186c ("app/testpmd: add loopback topology") > Cc: sta...@dpdk.org > > Signed-off-by: Pablo de Lara Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix forwarding between non consecutive ports

2017-11-07 Thread Thomas Monjalon
07/11/2017 18:43, De Lara Guarch, Pablo: > From: Ophir Munk > > > > When defining two failsafe devices in testpmd the port numbers of the > > failsafe devices may not be consecutive. > > For example: if failsafe device includes a PCI device and a TAP device then > > failsafe port numbers would be

[dpdk-dev] [PATCH] igb_uio: remove device reset in release

2017-11-07 Thread Ferruh Yigit
More error reported for device reset in release() [1], when device pass-through to the guest, host kernel crash on guest exit. Removing the reset completely. [1] http://dpdk.org/ml/archives/dev/2017-November/081459.html Fixes: e3a64deae2d5 ("igb_uio: prevent reset for bnx2x devices") Fixes: b58e

[dpdk-dev] [PATCH] net/mlx5: fix tunneled TCP/UDP packet type

2017-11-07 Thread Yongseok Koh
If tunneled bit is set in the HW descriptor, the l4_hdr_type bits describe the inner packet. Fixes: ea16068c0064 ("net/mlx5: fix L4 packet type support") Cc: sta...@dpdk.org Reported-by: Li Xueming Signed-off-by: Yongseok Koh Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_rxtx.c | 16 +

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] igb_uio: prevent reset for a list of devices

2017-11-07 Thread Ferruh Yigit
On 11/7/2017 10:12 AM, Chas Williams wrote: > Environment: Dell PowerEdge R730, Intel Corporation 82599ES 10-Gigabit > SFI/SFP+ > Network Connection shared via PCI pass-through > Host: Debian 8 > Guest: Custom Debian 8 with DPDK application based on 17.11 > > When we shutdown the guest, the kerne

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] igb_uio: prevent reset for a list of devices

2017-11-07 Thread Chas Williams
Regardless if the issue is actually in the host kernel, I cannot fix all the hypervisors so I must attempt to be well behaved as a guest. On Tue, Nov 7, 2017 at 8:13 AM, Stephen Hemminger < step...@networkplumber.org> wrote: > > > On Nov 7, 2017 20:50, "Chas Williams" <3ch...@gmail.com> wrote: >

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] igb_uio: prevent reset for a list of devices

2017-11-07 Thread Chas Williams
Environment: Dell PowerEdge R730, Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection shared via PCI pass-through Host: Debian 8 Guest: Custom Debian 8 with DPDK application based on 17.11 When we shutdown the guest, the kernel panics with: [ 279.021818] Do you have a strange power

[dpdk-dev] [PATCH] app/testpmd: fix incomplete error message

2017-11-07 Thread Pablo de Lara
Fixes: 3e2006d6186c ("app/testpmd: add loopback topology") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- app/test-pmd/parameters.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index ca9fc58..84e7a63 100644 --- a/

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix forwarding between non consecutive ports

2017-11-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Ophir Munk > Sent: Tuesday, November 7, 2017 1:53 PM > To: Wu, Jingjing > Cc: Gaetan Rivet ; Ophir Munk > ; Olga Shern ; > sta...@dpdk.org; Raslan Darawsheh > Subject: [dpdk-stable] [PATCH v2] app/testpmd

Re: [dpdk-dev] [PATCH] test: provide performance difference ratio and test time

2017-11-07 Thread Thomas Monjalon
26/10/2017 08:23, Jianbo Liu: > The 10/25/2017 15:13, Herbert Guan wrote: > > The printed time values presented in TSC is not straight forward > > showing the performance difference. And if the high resolution > > counter is not enabled, time value is too small to show the actual > > performance (

Re: [dpdk-dev] [PATCH] app/crypto-perf: add help option

2017-11-07 Thread Thomas Monjalon
> > Signed-off-by: Pablo de Lara > > Acked-by: Fan Zhang Applied, thanks

Re: [dpdk-dev] [PATCH v2] test/pmd_perf: fix for segmentation fault

2017-11-07 Thread Thomas Monjalon
> > Error can be reproduce if we run pmd_perf_autotest with more then > > one device in such way: > > RTE>>set_rxtx_sc poll_before_xmit > > RTE>>pmd_perf_autotest > > > > if first burst was value less than MAX_PKT_BURST in the end we overwrite > > pkts_burst table for rx which was supposed for ano

Re: [dpdk-dev] [PATCH] bus/pci: fix use of wrong PPC define

2017-11-07 Thread Thomas Monjalon
07/11/2017 15:52, Jonas Pfefferle: > This fixes the use of an never defined PPC64 define in > ret_pci_get_iommu_class. > > Fixes: b48e0e2d9cb4 ("bus/pci: fix IOMMU class for sPAPR") > Signed-off-by: Jonas Pfefferle Applied, thanks

Re: [dpdk-dev] [PATCH v12 0/4] move vdev into drivers/bus

2017-11-07 Thread Thomas Monjalon
> Jianfeng Tan (4): > cryptodev: remove crypto vdev init API > eal: remove dependency on vdev > bus/vdev: move to vdev bus to drivers/bus > bus/vdev: change log type Applied with few small nitpick changes, thanks

[dpdk-dev] [PATCH] bus/pci: fix use of wrong PPC define

2017-11-07 Thread Jonas Pfefferle
This fixes the use of an never defined PPC64 define in ret_pci_get_iommu_class. Fixes: b48e0e2d9cb4 ("bus/pci: fix IOMMU class for sPAPR") Signed-off-by: Jonas Pfefferle --- drivers/bus/pci/linux/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/pci/linux/pci.

Re: [dpdk-dev] [PATCH] bus/fslmc: set the bus iova mode as physical

2017-11-07 Thread Thomas Monjalon
07/11/2017 13:15, Hemant Agrawal: > Setting the default iova mode as physical. > > Signed-off-by: Hemant Agrawal > --- > Though the DPAA2 can support virtual mode, but that require other changes in > the > code as well, so setting it as physical for time being. Series applied, thanks

Re: [dpdk-dev] [PATCH] pci: get IOMMU class sPAPR iommu fix

2017-11-07 Thread Thomas Monjalon
07/11/2017 15:31, Jonas Pfefferle1: > Thomas Monjalon wrote on 11/07/2017 12:38:11 AM: > > > From: Thomas Monjalon > > To: Jonas Pfefferle > > Cc: dev@dpdk.org, anatoly.bura...@intel.com > > Date: 11/07/2017 12:38 AM > > Subject: Re: [dpdk-dev] [PATCH] pci: get IOMMU class sPAPR iommu fix > > >

Re: [dpdk-dev] [PATCH] pci: get IOMMU class sPAPR iommu fix

2017-11-07 Thread Jonas Pfefferle1
Thomas Monjalon wrote on 11/07/2017 12:38:11 AM: > From: Thomas Monjalon > To: Jonas Pfefferle > Cc: dev@dpdk.org, anatoly.bura...@intel.com > Date: 11/07/2017 12:38 AM > Subject: Re: [dpdk-dev] [PATCH] pci: get IOMMU class sPAPR iommu fix > > 03/11/2017 13:05, Jonas Pfefferle: > > PPC64 sPAPR

Re: [dpdk-dev] [PATCH v1] mk: allow use of toolchain cflags

2017-11-07 Thread Varghese, Vipin
Hi Thomas, Please find my answers below Why do you want to use export from the shell environment? Answer> One scenario that generic scripts or makefiles are used to build DPDK and Customer components. While building for "make debug" mode; we require DPDK libraries to be built with compiler spe

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix forwarding between non consecutive ports

2017-11-07 Thread Thomas Monjalon
It is a really basic bug in testpmd. Someone to review it quickly please?

Re: [dpdk-dev] [PATCH] mem: warn if address hint is not respected

2017-11-07 Thread Burakov, Anatoly
On 06-Nov-17 8:26 PM, Thomas Monjalon wrote: 31/10/2017 10:08, Jonas Pfefferle: Print a warning if the --base-virtaddr hint is not respected since this might lead to problems when mapping memory in the secondary process. Signed-off-by: Jonas Pfefferle Anatoly, please review this patch. It do

[dpdk-dev] [PATCH v2] app/testpmd: fix forwarding between non consecutive ports

2017-11-07 Thread Ophir Munk
When defining two failsafe devices in testpmd the port numbers of the failsafe devices may not be consecutive. For example: if failsafe device includes a PCI device and a TAP device then failsafe port numbers would be 0 and 3. Port 0 - failsafe #1 device Port 1 - PCI #1 device Port 2 - TAP #1 devic

[dpdk-dev] [PATCH v2] app/testpmd: fix forwarding between non consecutive ports

2017-11-07 Thread Ophir Munk
When defining two failsafe devices in testpmd the port numbers of the failsafe devices may not be consecutive. For example: if failsafe device includes a PCI device and a TAP device then failsafe port numbers would be 0 and 3. Port 0 - failsafe #1 device Port 1 - PCI #1 device Port 2 - TAP #1 devic

[dpdk-dev] [PATCH v2] app/testpmd: fix forwarding between non consecutive ports

2017-11-07 Thread Ophir Munk
When defining two failsafe devices in testpmd the port numbers of the failsafe devices may not be consecutive. For example: if failsafe device includes a PCI device and a TAP device then failsafe port numbers would be 0 and 3. Port 0 - failsafe #1 device Port 1 - PCI #1 device Port 2 - TAP #1 devic

Re: [dpdk-dev] [PATCH v2 0/3] vhost: disable iommu support by default

2017-11-07 Thread Thomas Monjalon
07/11/2017 04:32, Yuanhan Liu: > On Mon, Nov 06, 2017 at 09:38:09PM +0100, Maxime Coquelin wrote: > > This series disables IOMMU feature by default, and introduce > > a new flag passed at vhost device registration time to enable > > it explicitly. > > > > When disabled, patch 1 also disables reply

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] igb_uio: prevent reset for a list of devices

2017-11-07 Thread Stephen Hemminger
On Nov 7, 2017 20:50, "Chas Williams" <3ch...@gmail.com> wrote: We still have an issue with this and PCI pass-through. If a guest is restarted while using PCI pass-through and igb_uio issues a pci_reset_function(), this causes the host to crash. On Mon, Nov 6, 2017 at 6:55 PM, Thomas Monjalon w

Re: [dpdk-dev] [PATCH] crypto/dpaa_sec: changing buf physaddr to buf iova

2017-11-07 Thread Thomas Monjalon
07/11/2017 13:15, Hemant Agrawal: > buf_physaddr is getting deprecated in mbuf. Seems two occurences were missing, thanks. Fixes: 455da5453987 ("mbuf: rename physical address to IOVA") > Signed-off-by: Hemant Agrawal

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] igb_uio: prevent reset for a list of devices

2017-11-07 Thread Thomas Monjalon
07/11/2017 12:50, Chas Williams: > We still have an issue with this and PCI pass-through. If a guest is > restarted while using PCI pass-through and igb_uio issues a > pci_reset_function(), this causes the host to crash. Please, could you better explain the exact scenario and the cause of the cra

Re: [dpdk-dev] [PATCH v2 0/3] vhost: disable iommu support by default

2017-11-07 Thread Maxime Coquelin
On 11/07/2017 12:08 PM, Kavanagh, Mark B wrote: From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Tuesday, November 7, 2017 11:05 AM To: Kavanagh, Mark B ; dev@dpdk.org; y...@fridaylinux.org; tho...@monjalon.net; ktray...@redhat.com Subject: Re: [PATCH v2 0/3] vhost: disable iommu

[dpdk-dev] [PATCH] crypto/dpaa_sec: changing buf physaddr to buf iova

2017-11-07 Thread Hemant Agrawal
buf_physaddr is getting deprecated in mbuf. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index d1ef241..16155b1 100644 --- a/dr

[dpdk-dev] [PATCH] bus/dpaa: setting the iova mode as physical

2017-11-07 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index dc58e17..1cc8c89 100644 --- a/drivers/bus/dpaa/dpaa_bus.c +++ b/drivers/bus/dpaa/dpaa_bus.c @@ -484,11 +484

[dpdk-dev] [PATCH] bus/fslmc: set the bus iova mode as physical

2017-11-07 Thread Hemant Agrawal
Setting the default iova mode as physical. Signed-off-by: Hemant Agrawal --- Though the DPAA2 can support virtual mode, but that require other changes in the code as well, so setting it as physical for time being. drivers/bus/fslmc/fslmc_bus.c | 10 ++ 1 file changed, 10 insertions(+)

Re: [dpdk-dev] [PATCH v2 0/3] vhost: disable iommu support by default

2017-11-07 Thread Kevin Traynor
On 11/07/2017 11:30 AM, Maxime Coquelin wrote: > > > On 11/07/2017 12:25 PM, Kevin Traynor wrote: >> On 11/07/2017 10:56 AM, Kavanagh, Mark B wrote: From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Monday, November 6, 2017 8:38 PM To: dev@dpdk.org; y...@fridaylinux.o

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] igb_uio: prevent reset for a list of devices

2017-11-07 Thread Chas Williams
We still have an issue with this and PCI pass-through. If a guest is restarted while using PCI pass-through and igb_uio issues a pci_reset_function(), this causes the host to crash. On Mon, Nov 6, 2017 at 6:55 PM, Thomas Monjalon wrote: > 06/11/2017 19:48, Ferruh Yigit: > > Some devices are hav

Re: [dpdk-dev] [PATCH] net/mlx5: fix socket field initialization

2017-11-07 Thread Thomas Monjalon
07/11/2017 11:08, Nélio Laranjeiro: > On Tue, Nov 07, 2017 at 10:59:37AM +0100, Olivier Gournet wrote: > > Fixes: a1366b1a2be (net/mlx5: add reference counter on DPDK Rx queues) > > > > Signed-off-by: Olivier Gournet > > Acked-by: Nelio Laranjeiro Applied, thanks

Re: [dpdk-dev] [pull-request] next-net 17.11 RC3

2017-11-07 Thread Thomas Monjalon
04/11/2017 00:56, Ferruh Yigit: > http://dpdk.org/git/next/dpdk-next-net Pulled, thanks

Re: [dpdk-dev] [PATCH v4] net/mlx4: enhance Rx packet type offloads

2017-11-07 Thread Thomas Monjalon
07/11/2017 09:43, Adrien Mazarguil: > On Sun, Nov 05, 2017 at 07:26:56PM +0200, Moti Haimovsky wrote: > > This patch enhances the Rx packet type offload to also report the L4 > > protocol information in the hw ptype filled by the PMD for each received > > packet. > > > > Signed-off-by: Moti Haimov

Re: [dpdk-dev] [PATCH v2 0/3] vhost: disable iommu support by default

2017-11-07 Thread Maxime Coquelin
On 11/07/2017 12:25 PM, Kevin Traynor wrote: On 11/07/2017 10:56 AM, Kavanagh, Mark B wrote: From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Monday, November 6, 2017 8:38 PM To: dev@dpdk.org; y...@fridaylinux.org; Kavanagh, Mark B ; tho...@monjalon.net; ktray...@redhat.com Cc:

Re: [dpdk-dev] [PATCH v2 0/3] vhost: disable iommu support by default

2017-11-07 Thread Kevin Traynor
On 11/07/2017 10:56 AM, Kavanagh, Mark B wrote: >> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] >> Sent: Monday, November 6, 2017 8:38 PM >> To: dev@dpdk.org; y...@fridaylinux.org; Kavanagh, Mark B >> ; tho...@monjalon.net; ktray...@redhat.com >> Cc: Maxime Coquelin >> Subject: [PATCH

Re: [dpdk-dev] [RFC] Compression API in DPDK

2017-11-07 Thread Trahe, Fiona
Hi Shally, ///snip/// > [Shally] Ok. Then, just to confirm my understanding here. You mean PMD can > figure out amount of > available space in dst mbuf by calling rte_pktmbuf_data_len() on each of its > segment? [Fiona] exactly. ///snip/// > > > > > > + * This indicates the buffer size and

Re: [dpdk-dev] [PATCH v2 0/3] vhost: disable iommu support by default

2017-11-07 Thread Kavanagh, Mark B
>From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] >Sent: Tuesday, November 7, 2017 11:05 AM >To: Kavanagh, Mark B ; dev@dpdk.org; >y...@fridaylinux.org; tho...@monjalon.net; ktray...@redhat.com >Subject: Re: [PATCH v2 0/3] vhost: disable iommu support by default > >Hi Mark, > >On 11/07/201

Re: [dpdk-dev] [PATCH v2 0/3] vhost: disable iommu support by default

2017-11-07 Thread Maxime Coquelin
Hi Mark, On 11/07/2017 11:56 AM, Kavanagh, Mark B wrote: From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Monday, November 6, 2017 8:38 PM To: dev@dpdk.org; y...@fridaylinux.org; Kavanagh, Mark B ; tho...@monjalon.net; ktray...@redhat.com Cc: Maxime Coquelin Subject: [PATCH v2 0/

Re: [dpdk-dev] [PATCH v2 0/3] vhost: disable iommu support by default

2017-11-07 Thread Kavanagh, Mark B
>From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] >Sent: Monday, November 6, 2017 8:38 PM >To: dev@dpdk.org; y...@fridaylinux.org; Kavanagh, Mark B >; tho...@monjalon.net; ktray...@redhat.com >Cc: Maxime Coquelin >Subject: [PATCH v2 0/3] vhost: disable iommu support by default > >This ser

Re: [dpdk-dev] Huge mapping secondary process linux

2017-11-07 Thread Jonas Pfefferle1
"Chao Zhu" wrote on 11/07/2017 09:25:26 AM: > From: "Chao Zhu" > To: "'Jonas Pfefferle1'" , "'Burakov, Anatoly'" > > Cc: , > Date: 11/07/2017 11:00 AM > Subject: RE: [dpdk-dev] Huge mapping secondary process linux > > > > From: Jonas Pfefferle1 [mailto:j...@zurich.ibm.com] > Sent: 2017年10月28日

Re: [dpdk-dev] [PATCH] net/mlx5: fix socket field initialization

2017-11-07 Thread Nélio Laranjeiro
On Tue, Nov 07, 2017 at 10:59:37AM +0100, Olivier Gournet wrote: > Fixes: a1366b1a2be (net/mlx5: add reference counter on DPDK Rx queues) > > Signed-off-by: Olivier Gournet > --- > drivers/net/mlx5/mlx5_rxq.c | 1 + > drivers/net/mlx5/mlx5_txq.c | 1 + > 2 files changed, 2 insertions(+) > > dif

[dpdk-dev] [PATCH] net/mlx5: fix socket field initialization

2017-11-07 Thread Olivier Gournet
Fixes: a1366b1a2be (net/mlx5: add reference counter on DPDK Rx queues) Signed-off-by: Olivier Gournet --- drivers/net/mlx5/mlx5_rxq.c | 1 + drivers/net/mlx5/mlx5_txq.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index a1f382b..

Re: [dpdk-dev] [PATCH v2] ring: guarantee ordering of cons/prod loading when doing

2017-11-07 Thread Jerin Jacob
-Original Message- > Date: Tue, 7 Nov 2017 16:34:30 +0800 > From: Jia He > To: Jerin Jacob > Cc: dev@dpdk.org, olivier.m...@6wind.com, konstantin.anan...@intel.com, > bruce.richard...@intel.com, jianbo@arm.com, hemant.agra...@nxp.com, > jie2@hxt-semitech.com, bing.z...@hxt-semit

[dpdk-dev] [PATCH] doc: update IPSec Multi-buffer lib versioning

2017-11-07 Thread Pablo de Lara
A new library of the IPSec Multi-buffer library has been released (0.47), which is used by the AESNI GCM PMD. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/aesni_gcm.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/cryptodevs/aesni_gcm.rst b/doc/gu

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2017-11-07 Thread Jonas Pfefferle1
Thomas Monjalon wrote on 11/07/2017 10:40:15 AM: > From: Thomas Monjalon > To: Jonas Pfefferle1 , anatoly.bura...@intel.com > Cc: dev@dpdk.org > Date: 11/07/2017 10:40 AM > Subject: Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling > > 07/11/2017 10:05, Jonas Pfefferle1: > > Thomas Mo

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2017-11-07 Thread Thomas Monjalon
07/11/2017 10:05, Jonas Pfefferle1: > Thomas Monjalon wrote on 11/06/2017 09:25:15 PM: > > > From: Thomas Monjalon > > To: Jonas Pfefferle , anatoly.bura...@intel.com > > Cc: dev@dpdk.org > > Date: 11/06/2017 09:55 PM > > Subject: Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling > >

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2017-11-07 Thread Jonas Pfefferle1
Thomas Monjalon wrote on 11/06/2017 09:25:15 PM: > From: Thomas Monjalon > To: Jonas Pfefferle , anatoly.bura...@intel.com > Cc: dev@dpdk.org > Date: 11/06/2017 09:55 PM > Subject: Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling > > 31/10/2017 16:59, Jonas Pfefferle: > > Check and r

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow director delete with drop action

2017-11-07 Thread Ferruh Yigit
On 11/6/2017 2:41 AM, Nelio Laranjeiro wrote: > Removing a flow director rule with a drop action ends by not removing it > due to a missing verbs drop specification in the conversion process between > the flow director and generic flow API. > > Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director

Re: [dpdk-dev] [PATCH] net/pcap: fix memory leak from missing pcap_close

2017-11-07 Thread Ferruh Yigit
On 11/6/2017 11:52 AM, Ferruh Yigit wrote: > On 11/5/2017 9:24 AM, Stefan Baranoff wrote: >> In open_single_tx_pcap there is a call to pcap_open_dead which calls >> malloc to create and return a pcap_t. That object is never freed in >> this case. Other places it is freed by passing it back similar

  1   2   >