Re: [dpdk-dev] [PATCH 00/11] net/vhostpci: A new vhostpci PMD supporting VM2VM scenario

2017-12-20 Thread Yang, Zhiyong
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yang, Zhiyong > Sent: Thursday, December 21, 2017 2:21 PM > To: Tan, Jianfeng ; Maxime Coquelin > ; dev@dpdk.org; y...@fridaylinux.org > Cc: Wang, Wei W > Subject: Re: [dpdk-dev] [PATCH 00/11] net/vhostpci: A new

Re: [dpdk-dev] [PATCH 00/11] net/vhostpci: A new vhostpci PMD supporting VM2VM scenario

2017-12-20 Thread Yang, Zhiyong
Hi Jianfeng, > -Original Message- > From: Tan, Jianfeng > Sent: Thursday, December 21, 2017 1:52 PM > To: Yang, Zhiyong ; Maxime Coquelin > ; dev@dpdk.org; y...@fridaylinux.org > Cc: Wang, Wei W > Subject: RE: [PATCH 00/11] net/vhostpci: A new vhostpci PMD supporting > VM2VM scenario > >

Re: [dpdk-dev] [PATCH 00/11] net/vhostpci: A new vhostpci PMD supporting VM2VM scenario

2017-12-20 Thread Tan, Jianfeng
Hi, > -Original Message- > From: Yang, Zhiyong > Sent: Wednesday, December 20, 2017 9:52 AM > To: Maxime Coquelin; dev@dpdk.org; y...@fridaylinux.org > Cc: Wang, Wei W; Tan, Jianfeng > Subject: RE: [PATCH 00/11] net/vhostpci: A new vhostpci PMD supporting > VM2VM scenario > > Hi Maxime, >

[dpdk-dev] [PATCH v4] arch/arm: optimization for memcpy on AArch64

2017-12-20 Thread Herbert Guan
This patch provides an option to do rte_memcpy() using 'restrict' qualifier, which can induce GCC to do optimizations by using more efficient instructions, providing some performance gain over memcpy() on some AArch64 platforms/enviroments. The memory copy performance differs between different AAr

[dpdk-dev] [RFC 5/5] ether: add packet modification aciton in rte_flow

2017-12-20 Thread Qi Zhang
Add new actions that be used to modify packet content with generic semantic: RTE_FLOW_ACTION_TYPE_FIELD_UPDATE: update specific field of packet RTE_FLWO_ACTION_TYPE_FIELD_INCREMENT: increament specific field of packet RTE_FLWO_ACTION_TYPE_FIELD_DECREMENT: decreament specific field of packet RTE_FL

[dpdk-dev] [RFC 4/5] ether: Add flow timeout support

2017-12-20 Thread Qi Zhang
Add new APIs to support flow timeout, application is able to 1. Setup the time duration of a flow, the flow is expected to be deleted automatically when timeout. 2. Ping a flow to check if it is active or not. 3. Register a callback function when a flow is deleted due to timeout. Signed-off-by: Qi

[dpdk-dev] [RFC 3/5] ether: add flow last hit query support

2017-12-20 Thread Qi Zhang
Enhanced the action RTE_FLOW_TYPE_ACTION_COUNT, number of milliseconds since last hit can be queried. Signed-off-by: Qi Zhang --- lib/librte_ether/rte_flow.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h index 91706e2..8e902f0 100

[dpdk-dev] [RFC 2/5] ether: add flow action to redirect packet in a switch domain

2017-12-20 Thread Qi Zhang
Add action RTE_FLOW_ACTION_TYPE_SWITCH_PORT, it can be used to redirect a packet to a network interface that connect to the same switch domain, rte_ethdev's port_id is used as an identification of the destination. A typical use case is: with a smart NIC for vSwitch acceleration, flow is defined to

[dpdk-dev] [RFC 1/5] version: 17.11.0

2017-12-20 Thread Qi Zhang
From: Thomas Monjalon Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/include/rte_version.h | 4 ++-- pkg/dpdk.spec | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/include/rte_version.h b/lib/librte_eal/common/

[dpdk-dev] [RFC 0/5] rte_flow extension for vSwitch acceleration

2017-12-20 Thread Qi Zhang
This patch extend rte_flow API. The purpose is to provide comfortable programming interface for virtual switch software (such as OVS) to take advantage of incoming device's vSwitch acceleration capability when using DPDK as data plane. Below is summary of changes: 1. Support to specify flow's de

[dpdk-dev] [PATCH] doc: add queue region feature info to release notes

2017-12-20 Thread Wei Zhao
This patch add inforation about i40e queue region realted to release notes, it has been missed before. Signed-off-by: Wei Zhao --- doc/guides/rel_notes/release_17_11.rst | 17 + 1 file changed, 17 insertions(+) diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/re

Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: add and export MDIO APIs

2017-12-20 Thread Zhang, Helin
In general, I'd suggest to add two things together with this patch set. 1. test cases in testpmd. 2. documentation in release notes, testpmd doc, and others if needed. Regards, Helin > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shweta Choudaha > Sent: Monday

Re: [dpdk-dev] [PATCH v2 2/2] net/ixgbe : backplane port MDIO support

2017-12-20 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shweta Choudaha > Sent: Monday, November 6, 2017 10:25 PM > To: dev@dpdk.org > Cc: Shweta Choudaha > Subject: [dpdk-dev] [PATCH v2 2/2] net/ixgbe : backplane port MDIO support > > From: Shweta Choudaha > > Init

Re: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API

2017-12-20 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Friday, November 24, 2017 4:43 PM > To: dev@dpdk.org > Cc: Zhao1, Wei > Subject: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API > > Rte_flow actually defined to include RSS, but till now, RSS

Re: [dpdk-dev] [PATCH v3 2/2] net/ixgbe: move RSS to flow API

2017-12-20 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhao1, Wei > Sent: Friday, December 8, 2017 10:28 AM > To: Dai, Wei; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/ixgbe: move RSS to flow API > > Hi, daiwei > I build the code with ICC for sec

Re: [dpdk-dev] [PATCH v3 1/2] net/e1000: move RSS to flow API

2017-12-20 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhao1, Wei > Sent: Friday, December 8, 2017 10:28 AM > To: Dai, Wei; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/e1000: move RSS to flow API > > Hi, daiwei > I build the code with ICC for sec

Re: [dpdk-dev] standardize device identification

2017-12-20 Thread Thomas Monjalon
Changing the title and adding more comments inline: 19/12/2017 00:05, Thomas Monjalon: > Let's summarize and resume this thread. > > We need a generic syntax to describe a device. > This syntax can be used > - before initializing the device (i.e. whitelist/blacklist) > - or after the

Re: [dpdk-dev] [PATCH v4] vhost_user: protect active rings from async ring changes

2017-12-20 Thread Stephen Hemminger
On Wed, 20 Dec 2017 15:06:30 -0500 (EST) Victor Kaplansky wrote: > > Wrapping locking inline's adds nothing and makes life harder > > for static analysis tools. > > Yep. In this case it inhibits the details of how the locking is > implemented (e.g. the name of the lock). It also facilitates >

Re: [dpdk-dev] [PATCH 00/11] Dynamic logging (just do it)

2017-12-20 Thread Stephen Hemminger
On Tue, 19 Dec 2017 17:51:22 -0800 Ferruh Yigit wrote: > On 12/18/2017 10:38 PM, Stephen Hemminger wrote: > > This patch set implements dynamic logging for 11 drivers. > > All these patches are compile tested only. I don't have > > access to most of this hardware. > > > > It makes more sense to

Re: [dpdk-dev] [PATCH v4] vhost_user: protect active rings from async ring changes

2017-12-20 Thread Victor Kaplansky
- Original Message - > From: "Stephen Hemminger" > To: "Victor Kaplansky" > Cc: dev@dpdk.org, sta...@dpdk.org, "Jens Freimann" , > "Maxime Coquelin" > , "Yuanhan Liu" , "Tiwei > Bie" , "Jianfeng > Tan" > Sent: Wednesday, December 20, 2017 9:06:16 PM > Subject: Re: [dpdk-dev] [PATCH v

Re: [dpdk-dev] [PATCH v4] vhost_user: protect active rings from async ring changes

2017-12-20 Thread Stephen Hemminger
On Wed, 20 Dec 2017 16:37:52 +0200 Victor Kaplansky wrote: > When performing live migration or memory hot-plugging, > the changes to the device and vrings made by message handler > done independently from vring usage by PMD threads. > > This causes for example segfaults during live-migration > w

Re: [dpdk-dev] [PATCH 02/11] bnx2x: implement dynamic logging

2017-12-20 Thread Stephen Hemminger
On Tue, 19 Dec 2017 17:51:46 -0800 Ferruh Yigit wrote: > On 12/18/2017 10:38 PM, Stephen Hemminger wrote: > > Replace compile time option for init and driver log with > > dynamic value. > > > > Signed-off-by: Stephen Hemminger > > --- > > config/common_base | 2 -- > > doc/guide

Re: [dpdk-dev] [PATCH 01/11] avp: implement dynamic logging

2017-12-20 Thread Stephen Hemminger
On Tue, 19 Dec 2017 17:53:50 -0800 Ferruh Yigit wrote: > On 12/18/2017 10:38 PM, Stephen Hemminger wrote: > > All PMD should be using dynamic log levels. > > > > Signed-off-by: Stephen Hemminger > > --- > > config/common_base | 1 - > > drivers/net/avp/avp_ethdev.c | 10 ++ >

Re: [dpdk-dev] [RFC PATCH 0/3] ethdev: few changes in rte_ethdev layer

2017-12-20 Thread Ananyev, Konstantin
Hi Jerin, > > Hi Konstantin, > > > > > > > > > > > > > 2. Make it safe to remove rx/tx callback at runtime. > > > > > > Right now it is not possible for the application to figure out > > > > > > when it is safe to free removed callback handle and > > > > > > associated with it resources(unless t

Re: [dpdk-dev] [PATCH v2] net/ixgbe: removed ipsec keys from private data

2017-12-20 Thread Radu Nicolau
On 12/20/2017 3:46 PM, Stephen Hemminger wrote: On Wed, 20 Dec 2017 11:32:51 + Radu Nicolau wrote: All ipsec related setting are being held in the driver private data to allow easy add and remove of SAs. There is no need to keep a record of the keys, and also storing the keys can be a se

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-20 Thread Boris Pismenny
Hi, > On Wed, Dec 13, 2017 at 07:14:19PM, Nelio Laranjeiro wrote: > > Hi, > > On Wed, Dec 13, 2017 at 07:23:19PM +0530, Anoob Joseph wrote: > > Hi Nelio, > > > > > > On 12/13/2017 06:23 PM, Nelio Laranjeiro wrote: > > > Hi Anoob, > > > > > > On Wed, Dec 13, 2017 at 05:08:19PM +0530, Anoob Joseph

Re: [dpdk-dev] [PATCH v2] net/ixgbe: removed ipsec keys from private data

2017-12-20 Thread Stephen Hemminger
On Wed, 20 Dec 2017 11:32:51 + Radu Nicolau wrote: > All ipsec related setting are being held in the driver > private data to allow easy add and remove of SAs. There > is no need to keep a record of the keys, and also > storing the keys can be a security issue. > > Signed-off-by: Radu Nicola

Re: [dpdk-dev] [RFC v1] doc compression API for DPDK

2017-12-20 Thread Trahe, Fiona
Hi Shally, I think we are almost in sync now - a few comments below with just one open question which I suspect was a typo. If this is ok then no need for a meeting I think. In this case will you issue a v2 of this doc ? > -Original Message- > From: Verma, Shally [mailto:shally.ve...@ca

Re: [dpdk-dev] [PATCH] doc: update IPSec Multi-buffer lib versioning

2017-12-20 Thread Kovacevic, Marko
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, December 19, 2017 9:28 AM > To: Mcnamara, John ; Doherty, Declan > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] doc: update IPSec Multi-buffer lib versio

[dpdk-dev] [PATCH v4] vhost_user: protect active rings from async ring changes

2017-12-20 Thread Victor Kaplansky
When performing live migration or memory hot-plugging, the changes to the device and vrings made by message handler done independently from vring usage by PMD threads. This causes for example segfaults during live-migration with MQ enable, but in general virtually any request sent by qemu changing

Re: [dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality

2017-12-20 Thread Thomas Monjalon
19/12/2017 21:44, Ferruh Yigit: > On 12/19/2017 7:06 AM, Adrien Mazarguil wrote: > > On Mon, Dec 18, 2017 at 05:54:45PM -0800, Ferruh Yigit wrote: > >> On 12/18/2017 8:46 AM, Adrien Mazarguil wrote: > >>> As described in more details in the attached documentation (see patch > >>> contents), this vi

Re: [dpdk-dev] [PATCH] pktgen-dpdk: fix low performance in VM virtio pmd mode

2017-12-20 Thread Wiles, Keith
> On Dec 20, 2017, at 2:04 AM, Bin Huang wrote: > > pktgen pre-allocated TX data in mbuf would be modified by virtio pmd driver > due to virtio pkt head extension. > it will caused mbuf data_len keep growing, packets size on wire growing, then > tx pps performance drop. > > set corresponding

Re: [dpdk-dev] [PATCH v2 1/4] net/dpaa: add null point check and fix mem leak

2017-12-20 Thread Shreyansh Jain
On Wednesday 20 December 2017 03:53 PM, Yong Wang wrote: Signed-off-by: Yong Wang --- drivers/net/dpaa/dpaa_ethdev.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index

Re: [dpdk-dev] [PATCH v2] net/i40e: support mac loopback

2017-12-20 Thread Peng, Yuan
Tested-by: Peng,Yuan - Tested Branch: dpdk master - Tested Commit: e976052a1106153c93c802e5ffd2f6c8a29f239f - OS: 4.4.0-62-generic - GCC: gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - NIC: Intel Corporation Ethernet Controller XL710 for 40GbE

Re: [dpdk-dev] [PATCH v2 4/4] crypto/qat: add null point check and fix mem leak

2017-12-20 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yong Wang > Sent: Wednesday, December 20, 2017 10:23 AM > To: hemant.agra...@nxp.com; Xing, Beilei ; Lu, Wenzhuo > ; Griffin, John > Cc: dev@dpdk.org; Yong Wang > Subject: [dpdk-dev] [PATCH v2 4/4] crypto/qat: a

Re: [dpdk-dev] [PATCH v2 0/2] next-build: add test app to build

2017-12-20 Thread Bruce Richardson
On Wed, Dec 20, 2017 at 11:16:30AM +, Harry van Haaren wrote: > This patchset adds the test/test/test app to the Meson build. > In doing so, the test app is improved to allow running a unit > test by setting an environment variable. This allows the meson > test infrastructure to integrate with

Re: [dpdk-dev] [PATCH v2 2/2] meson: add tests app to build

2017-12-20 Thread Bruce Richardson
On Wed, Dec 20, 2017 at 11:16:32AM +, Harry van Haaren wrote: > This patch enables the test/test app to be built. It also adds > the test binary to be a meson-test, which allows the meson test > infrastructure to be used to run tests. > > Tests are listed using the same test binary, however ea

[dpdk-dev] [PATCH v2] meson: add tests to build

2017-12-20 Thread Kevin Laatz
This commit adds most of the remaining tests to the meson build. They can be run using test binary as normal. Signed-off-by: Kevin Laatz --- v2: Added the test names for the added tests. --- test/test/meson.build | 37 + 1 file changed, 37 insertions(+)

Re: [dpdk-dev] [PATCH v2 2/2] meson: add tests app to build

2017-12-20 Thread Bruce Richardson
On Wed, Dec 20, 2017 at 11:57:59AM +, Laatz, Kevin wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Harry van Haaren > > Sent: Wednesday, December 20, 2017 11:17 AM > > To: dev@dpdk.org > > Cc: Richardson, Bruce ; Van Haaren, Harry > > > > Subject: [dpdk-dev] [PATCH v2 2/2] meso

Re: [dpdk-dev] [PATCH 1/2] mempool: indicate the usages of multi memzones

2017-12-20 Thread Hemant Agrawal
On 12/19/2017 6:38 PM, Hemant Agrawal wrote: That's true, I commented too fast :) And what about using mp->nb_mem_chunks instead? Would it do the job in your use-case? It should work. Let me check it out. There is a slight problem with nb_mem_chunks. It is getting incremented in the end o

Re: [dpdk-dev] [PATCH v2 2/2] meson: add tests app to build

2017-12-20 Thread Laatz, Kevin
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Harry van Haaren > Sent: Wednesday, December 20, 2017 11:17 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > > Subject: [dpdk-dev] [PATCH v2 2/2] meson: add tests app to build > +test_names = [ > + 'acl_autotest', > +

Re: [dpdk-dev] [PATCH v2 1/2] test: use env variable to run test if set

2017-12-20 Thread Bruce Richardson
On Wed, Dec 20, 2017 at 11:16:31AM +, Harry van Haaren wrote: > This commit paves the way for the meson tests in the next > patch. With this patch the test binary checks the DPDK_TEST > environment variable and if set, the contents of the var > are inserted on the test app command line, and run

[dpdk-dev] [PATCH v2] net/ixgbe: removed ipsec keys from private data

2017-12-20 Thread Radu Nicolau
All ipsec related setting are being held in the driver private data to allow easy add and remove of SAs. There is no need to keep a record of the keys, and also storing the keys can be a security issue. Signed-off-by: Radu Nicolau Acked-by: Declan Doherty --- drivers/net/ixgbe/ixgbe_ipsec.c | 7

[dpdk-dev] [PATCH v2 1/5] app: use SPDX tags for Intel copyright files

2017-12-20 Thread Bruce Richardson
Do a replacement of the full BSD License header with the SPDX reference for all .c/.h files with an Intel copyright only on them. Signed-off-by: Bruce Richardson --- V2: Changed header to remove the initial "/*-" on the first line, so that the license tag is on the first line, rather than sec

[dpdk-dev] [PATCH v2 0/5] Use SPDX tags on C files

2017-12-20 Thread Bruce Richardson
This contains the output of a script run to replace the BSD License with SPDX tags on Intel copyright files. The script should only have modified files with a single, Intel copyright on them, and ignored all files that had multiple copyright lines. Due to variance in the headers used, not all files

[dpdk-dev] [PATCH 2/2] service: fix service core launch

2017-12-20 Thread Harry van Haaren
This patch fixes a potential bug, which was not consistently showing up in the unit tests. The issue was that the service- lcore being started was not in a "WAIT" state, and hence EAL would return -EBUSY instead of launching the lcore. In order to ensure a core is in a launch-ready state, the appl

[dpdk-dev] [PATCH 1/2] service: fix del to reset lcore role to rte

2017-12-20 Thread Harry van Haaren
This patch fixes the reset of the service core, that when rte_service_lcore_del() is called, the lcore_role is restored to RTE. This issue was reported as when running the unit tests, an error was thrown that "failed to allocate lcore". Investigating revealed that the state of the service-cores af

Re: [dpdk-dev] [PATCH 0/5] Use SPDX tags on C files

2017-12-20 Thread Bruce Richardson
On Wed, Dec 20, 2017 at 10:06:55AM +, Bruce Richardson wrote: > On Wed, Dec 20, 2017 at 12:21:21PM +0530, Hemant Agrawal wrote: > > On 12/19/2017 8:03 PM, Bruce Richardson wrote: > > > This contains the output of a script run to replace the BSD License with > > > SPDX tags on Intel copyright fi

[dpdk-dev] [PATCH v2 2/2] meson: add tests app to build

2017-12-20 Thread Harry van Haaren
This patch enables the test/test app to be built. It also adds the test binary to be a meson-test, which allows the meson test infrastructure to be used to run tests. Tests are listed using the same test binary, however each test sets a different DPDK_TEST environment variable. The string contents

[dpdk-dev] [PATCH v2 1/2] test: use env variable to run test if set

2017-12-20 Thread Harry van Haaren
This commit paves the way for the meson tests in the next patch. With this patch the test binary checks the DPDK_TEST environment variable and if set, the contents of the var are inserted on the test app command line, and run. This allows testing of various different unit tests without manual inte

[dpdk-dev] [PATCH v2 0/2] next-build: add test app to build

2017-12-20 Thread Harry van Haaren
This patchset adds the test/test/test app to the Meson build. In doing so, the test app is improved to allow running a unit test by setting an environment variable. This allows the meson test infrastructure to integrate with the DPDK tests. Some nice improvements from the above integration, includi

Re: [dpdk-dev] [PATCH v2 10/11] test: register eventdev selftest

2017-12-20 Thread Van Haaren, Harry
> From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Tuesday, December 19, 2017 6:45 PM > To: Van Haaren, Harry ; > jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 10/11] test: register eventdev selftest > > Hi Harry, > > Thanks for the re

Re: [dpdk-dev] [PATCH v3 6/6] net/failsafe: fix removed device handling

2017-12-20 Thread Matan Azrad
Hi Gaetan > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Wednesday, December 20, 2017 12:22 AM > To: Matan Azrad > Cc: Adrien Mazarguil ; Thomas Monjalon > ; dev@dpdk.org > Subject: Re: [PATCH v3 6/6] net/failsafe: fix removed device handling > > Hi Mat

[dpdk-dev] [PATCH v2 2/4] net/i40e: add null point check and fix mem leak

2017-12-20 Thread Yong Wang
Signed-off-by: Yong Wang --- v2: * Fix code style warning. --- drivers/net/i40e/i40e_ethdev.c | 32 drivers/net/i40e/i40e_fdir.c | 7 +++ 2 files changed, 39 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 8

[dpdk-dev] [PATCH v2 3/4] net/e1000: add null point check for rte_zmalloc

2017-12-20 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/net/e1000/igb_flow.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c index 22bad26..057579b 100644 --- a/drivers/net/e1000/igb_flow.c +++ b/drivers/net/e1000/igb_flow.c @@ -1

[dpdk-dev] [PATCH v2 4/4] crypto/qat: add null point check and fix mem leak

2017-12-20 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 10 ++ drivers/crypto/qat/qat_qp.c | 8 +++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c b/drivers/crypto/qat/qat_

[dpdk-dev] [PATCH v2 1/4] net/dpaa: add null point check and fix mem leak

2017-12-20 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/net/dpaa/dpaa_ethdev.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index cf5a2ec..06d680c 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c

Re: [dpdk-dev] [PATCH 2/2] meson: add tests app to build

2017-12-20 Thread Bruce Richardson
On Mon, Dec 18, 2017 at 11:53:58AM +, Harry van Haaren wrote: > This patch enables the test/test app to be built. It also adds > the test binary to be a meson-test, which allows the meson test > infrastructure to be used to run tests. > > Tests are listed using the same test binary, however ea

Re: [dpdk-dev] [PATCH] meson: add tests to build

2017-12-20 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kevin Laatz > Sent: Tuesday, December 19, 2017 5:32 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Laatz, Kevin > > Subject: [dpdk-dev] [PATCH] meson: add tests to build > > This commit adds most of the remaining tests to the meson build. >

Re: [dpdk-dev] [PATCH 0/5] Use SPDX tags on C files

2017-12-20 Thread Bruce Richardson
On Wed, Dec 20, 2017 at 12:21:21PM +0530, Hemant Agrawal wrote: > On 12/19/2017 8:03 PM, Bruce Richardson wrote: > > This contains the output of a script run to replace the BSD License with > > SPDX tags on Intel copyright files. The script should only have modified > > files with a single, Intel c

Re: [dpdk-dev] [PATCH] ethdev: fix setting of MAC address

2017-12-20 Thread Andrew Rybchenko
On 12/19/2017 12:47 PM, Andrew Rybchenko wrote: On 12/19/2017 12:29 PM, Olivier MATZ wrote: Hi, On Mon, Dec 18, 2017 at 02:38:55PM +0300, Andrew Rybchenko wrote: On 12/18/2017 01:53 PM, Igor Ryzhov wrote: On Mon, Dec 18, 2017 at 1:35 PM, Andrew Rybchenko mailto:arybche...@solarflare.com>> wro

[dpdk-dev] [PATCH] net/sfc: fix main MAC address handling

2017-12-20 Thread Andrew Rybchenko
From: Ivan Malov There is a school of thought that rte_eth_dev_default_mac_addr_set() must call the PMD callback first and then save the new MAC address in dev->data->mac_addrs[0]. If this concept gets approved, it will break the current approach used in sfc driver as the latter relies on the ass

[dpdk-dev] [PATCH 1/4] net/dpaa: add null point check and fix mem leak

2017-12-20 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/net/dpaa/dpaa_ethdev.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index cf5a2ec..06d680c 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c

[dpdk-dev] [PATCH 2/4] net/i40e: add null point check and fix mem leak

2017-12-20 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/net/i40e/i40e_ethdev.c | 32 drivers/net/i40e/i40e_fdir.c | 7 +++ 2 files changed, 39 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 811cc9f..8101e10 100644 --- a/drive

[dpdk-dev] [PATCH 3/4] net/e1000: add null point check for rte_zmalloc

2017-12-20 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/net/e1000/igb_flow.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c index 22bad26..057579b 100644 --- a/drivers/net/e1000/igb_flow.c +++ b/drivers/net/e1000/igb_flow.c @@ -1

[dpdk-dev] [PATCH 4/4] crypto/qat: add null point check and fix mem leak

2017-12-20 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 10 ++ drivers/crypto/qat/qat_qp.c | 8 +++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c b/drivers/crypto/qat/qat_

Re: [dpdk-dev] [PATCH v3 1/6] ethdev: add devop to check removal status

2017-12-20 Thread Matan Azrad
Hi > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Wednesday, December 20, 2017 12:13 AM > To: Thomas Monjalon > Cc: Matan Azrad ; Stephen Hemminger > ; Adrien Mazarguil > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/6] ethdev: add devop to check

Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR input set conflict

2017-12-20 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Tuesday, December 19, 2017 9:21 PM > To: Xing, Beilei > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR input set conflict > > > > > -Original Message- > > From

[dpdk-dev] [PATCH v2 1/2] mbuf: add PPPoE and L2TP packet types

2017-12-20 Thread Beilei Xing
Add support of PPPoE and L2TP packet types. Signed-off-by: Beilei Xing --- lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++ lib/librte_mbuf/rte_mbuf_ptype.h | 26 ++ 2 files changed, 28 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf_ptype.c b/lib/librte_mbuf/rte_mbuf_ptype

[dpdk-dev] [PATCH v2 0/2] support PPPoE and L2TP packet types

2017-12-20 Thread Beilei Xing
v2 changes: - change patch title - rework ptype parser according to new profile meta data Beilei Xing (2): mbuf: add PPPoE and L2TP packet types net/i40e: support PPPoE and L2TP ptype parser drivers/net/i40e/i40e_ethdev.c | 83 +--- lib/librte_mbuf/rte

[dpdk-dev] [PATCH v2 2/2] net/i40e: support PPPoE and L2TP ptype parser

2017-12-20 Thread Beilei Xing
This patch adds support for PPPoE and L2TP packet types parser. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 83 ++ 1 file changed, 60 insertions(+), 23 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_et

Re: [dpdk-dev] [PATCH v2] net/i40e: support mac loopback

2017-12-20 Thread Zhang, Helin
Doc update is needed. /Helin > -Original Message- > From: Wu, Yanglong > Sent: Wednesday, December 20, 2017 3:29 PM > To: dev@dpdk.org > Cc: Xing, Beilei; Zhang, Helin; Peng, Yuan; Wu, Yanglong > Subject: [PATCH v2] net/i40e: support mac loopback > > According to loopback mode, setup loop

[dpdk-dev] [PATCH] pktgen-dpdk: fix low performance in VM virtio pmd mode

2017-12-20 Thread Bin Huang
pktgen pre-allocated TX data in mbuf would be modified by virtio pmd driver due to virtio pkt head extension. it will caused mbuf data_len keep growing, packets size on wire growing, then tx pps performance drop. set corresponding mbuf data_len in pktmbuf reset to fix it. Signed-off-by: Bin Hua