On 01/18/2018 10:16 AM, Andrew Rybchenko wrote:
On 01/17/2018 08:33 PM, Thomas Monjalon wrote:
Hi, 2 comments below
11/01/2018 09:12, Andrew Rybchenko:
From: Ivan Malov
+#define RTE_RX_OFFLOAD_BIT2STR(_name) \
+ { DEV_RX_OFFLOAD_##_name, #_name }
+
+static const struct {
+ uint64
On Wed, Jan 17, 2018 at 09:44:13AM -0800, Yongseok Koh wrote:
> Even though link of a port gets down, device still can receive traffic.
> That is the reason why mlx5_set_link_up/down() switches rx/tx_pkt_burst().
> However, if link gets down by an external command (e.g. ifconfig), it isn't
> effect
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Thursday, January 18, 2018 3:39 PM
> To: Yuanhan Liu
> Cc: dev@dpdk.org; Wang, Xiao W ; Yigit, Ferruh
> ; Olivier Matz
> Subject: Re: [PATCH 2/2] net: fix build error
>
> 18/01/2018 04:14, Yuanhan Liu:
>
18/01/2018 04:14, Yuanhan Liu:
> Fix build error when shared lib is enabled:
>
> LD librte_net.so.1.1
> rte_arp.o: In function `rte_net_make_rarp_packet':
> rte_arp.c:(.text+0x1f0): undefined reference to `rte_mempool_ops_table'
> rte_arp.c:(.text+0x21d): undefined reference to `rte_mempool_ops_
On Wed, Jan 17, 2018 at 12:34:08PM +, Ferruh Yigit wrote:
> On 1/16/2018 2:50 PM, Yuanhan Liu wrote:
> > This patch documents the new devargs syntax, which is going to be
> > implemented in DPDK v18.05.
> >
> > The new devargs proposal is introduced for having a consistent
> > interface for:
>
From: Roman Zhukov
The rte_flow is already filled in with zeros in the
case of create. So memset() with zeros is needed only
in validation.
Fixes: a9825ccf5bb8 ("net/sfc: support flow API filters")
Cc: sta...@dpdk.org
Signed-off-by: Roman Zhukov
Signed-off-by: Andrew Rybchenko
---
drivers/ne
From: Roman Zhukov
rss is a local variable with address which is never NULL.
Fixes: d77d07391d4d ("net/sfc: support flow API RSS action")
Cc: sta...@dpdk.org
Signed-off-by: Roman Zhukov
Signed-off-by: Andrew Rybchenko
---
drivers/net/sfc/sfc_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 d
You can probably work with Beilei who is trying to do the same thing
for other i40e features:
https://dpdk.org/dev/patchwork/patch/33953/
18/01/2018 03:00, Zhao1, Wei:
> Hi, Thomas
>I will update it in 17.11 release nots later as your comment.
> And it has been CC to John, but not
On 01/17/2018 08:33 PM, Thomas Monjalon wrote:
Hi, 2 comments below
11/01/2018 09:12, Andrew Rybchenko:
From: Ivan Malov
+#defineRTE_RX_OFFLOAD_BIT2STR(_name) \
+ { DEV_RX_OFFLOAD_##_name, #_name }
+
+static const struct {
+ uint64_t offload;
+ const char *name;
+}
The following changes since commit 5cbf8b4a0293d46649be06e7281be509531b5bc2:
test/flow_classify: remove port bound requirement (2018-01-18 01:09:12 +0100)
are available in the Git repository at:
http://dpdk.org/git/next/dpdk-next-eventdev
for you to fetch changes up to 6815f1359b0ca6c96cd9
From: Ivan Malov
Ethdev Tx offloads API has changed since:
commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")
This commit support the new Tx offloads API.
The code which fills in txq_flags in default_txconf is preserved
because rte_eth_dev_info_get() lacks conversion between offload
From: Ivan Malov
Ethdev Rx offloads API has changed since:
commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
This commit support the new Rx offloads API.
Signed-off-by: Ivan Malov
Signed-off-by: Andrew Rybchenko
Reviewed-by: Ferruh Yigit
---
drivers/net/sfc/sfc_ethdev.c | 27 +
From: Ivan Malov
The patch adds a separate function to report supported
Rx capabilities because this function will be required
in more places across the code in the upcoming patches.
Signed-off-by: Ivan Malov
Signed-off-by: Andrew Rybchenko
Reviewed-by: Ferruh Yigit
---
drivers/net/sfc/sfc_e
May be it is too late to suggest a new API functions to ethdev,
but hopefully if the idea is accepted, it could be applied in the
current release cycle since these functions are trivial.
I'm not sure that rte_ethdev_version.map is updated correctly
since EXPERIMENTAL tag is present and I don't und
From: Ivan Malov
The patch adds a separate function to report supported
Tx capabilities because this function will be required
in more places across the code in the upcoming patches.
Signed-off-by: Ivan Malov
Signed-off-by: Andrew Rybchenko
Reviewed-by: Ferruh Yigit
---
drivers/net/sfc/sfc_e
From: Ivan Malov
Commonly, drivers converted to the new offload API
may need to log unsupported offloads as a response
to wrong settings. From this perspective, it would
be convenient to have generic functions to look up
offload names. The patch adds such a helper for Tx.
Signed-off-by: Ivan Mal
From: Ivan Malov
Commonly, drivers converted to the new offload API
may need to log unsupported offloads as a response
to wrong settings. From this perspective, it would
be convenient to have generic functions to look up
offload names. The patch adds such a helper for Rx.
Signed-off-by: Ivan Mal
May be it is too late to suggest a new API functions to ethdev,
but hopefully if the idea is accepted, it could be applied in the
current release cycle since these functions are trivial.
I'm not sure that rte_ethdev_version.map is updated correctly
since EXPERIMENTAL tag is present and I don't und
From: Ivan Malov
Commonly, drivers converted to the new offload API
may need to log unsupported offloads as a response
to wrong settings. From this perspective, it would
be convenient to have generic functions to look up
offload names. The patch adds such a helper for Rx.
Signed-off-by: Ivan Mal
-Original Message-
> Date: Fri, 12 Jan 2018 20:12:27 +0530
> From: Hemant Agrawal
> To: Nipun Gupta , dev@dpdk.org
> CC: jerin.ja...@caviumnetworks.com
> Subject: Re: [PATCH] event/dpaa2: return correct number of event ports
> User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/
From: Ivan Malov
Ethdev Rx offloads API has changed since:
commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
This commit support the new Rx offloads API.
Signed-off-by: Ivan Malov
Signed-off-by: Andrew Rybchenko
---
drivers/net/sfc/sfc_ethdev.c | 27 +--
drivers/net/sfc
From: Ivan Malov
The patch adds a separate function to report supported
Tx capabilities because this function will be required
in more places across the code in the upcoming patches.
Signed-off-by: Ivan Malov
Signed-off-by: Andrew Rybchenko
---
drivers/net/sfc/sfc_ethdev.c | 13 +
From: Ivan Malov
Ethdev Tx offloads API has changed since:
commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")
This commit support the new Tx offloads API.
The code which fills in txq_flags in default_txconf is preserved
because rte_eth_dev_info_get() lacks conversion between offload
From: Ivan Malov
The patch adds a separate function to report supported
Rx capabilities because this function will be required
in more places across the code in the upcoming patches.
Signed-off-by: Ivan Malov
Signed-off-by: Andrew Rybchenko
---
drivers/net/sfc/sfc_ethdev.c | 9 +
dri
From: Ivan Malov
Commonly, drivers converted to the new offload API
may need to log unsupported offloads as a response
to wrong settings. From this perspective, it would
be convenient to have generic functions to look up
offload names. The patch adds such a helper for Tx.
Signed-off-by: Ivan Mal
-Original Message-
> Date: Wed, 17 Jan 2018 02:13:53 +0530
> From: Nipun Gupta
> To: jerin.ja...@caviumnetworks.com
> CC: dev@dpdk.org, sunil.k...@nxp.com, hemant.agra...@nxp.com, Nipun Gupta
>
> Subject: [PATCH 00/10 v4] event/dpaa: Support for eventdev
> X-Mailer: git-send-email 1.9.1
Hi Akhil,
> -Original Message-
> From: Akhil Goyal [mailto:akhil.go...@nxp.com]
> Sent: Wednesday, January 17, 2018 4:23 PM
> To: Gujjar, Abhinandan S ; De Lara Guarch, Pablo
> ; Doherty, Declan
> ; Jacob, Jerin
>
> Cc: dev@dpdk.org; Vangati, Narender ; Rao,
> Nikhil
> Subject: Re: [PATC
-Original Message-
> Date: Fri, 12 Jan 2018 20:59:05 +0530
> From: Hemant Agrawal
> To: Nipun Gupta , jerin.ja...@caviumnetworks.com
> CC: dev@dpdk.org
> Subject: Re: [PATCH 1/6 v2] event/dpaa2: replace static with dynamic logging
> User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0)
Wednesday, January 17, 2018 7:33 PM, Thomas Monjalon:
09:12, Andrew Rybchenko:
> > From: Ivan Malov
> >
> > +#defineRTE_RX_OFFLOAD_BIT2STR(_name) \
> > + { DEV_RX_OFFLOAD_##_name, #_name }
> > +
> > +static const struct {
> > + uint64_t offload;
> > + const char *name;
> > +} rte_rx_of
Wednesday, January 17, 2018 8:58 PM, Ferruh Yigit :
> > Here is it better to check also the ETH_TXQ_FLAGS_IGNORE.
> > If application has not yet moved to the new API, then it won't set any port
> Tx offloads. So for old applications, the
> ena_are_tx_queue_offloads_allowed is not necessary.
>
> Bu
Inform userspace app about promisc mode change
Signed-off-by: Hemant Agrawal
---
v3: fix checkpatch warning and compilation err
doc/guides/sample_app_ug/kernel_nic_interface.rst | 15 ---
.../linuxapp/eal/include/exec-env/rte_kni_common.h | 2 ++
lib/librte_eal/linuxapp/kni/kni_net.c
This patch adds following:
1. Option to configure the mac address during create. Generate random
address only if the user has not provided any valid address.
2. Inform usespace, if mac address is being changed in linux.
3. Implement default handling of mac address change in the corresponding
Configure initial application provided mtu on the KNI interface.
Signed-off-by: Hemant Agrawal
---
examples/kni/main.c | 2 ++
lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h | 1 +
lib/librte_eal/linuxapp/kni/kni_misc.c
On Wed, 10 Jan 2018, garwil...@gmail.com wrote:
> From: George Wilkie
>
> With bonding, after sending sufficient ipv4 packets,
> bond_ethdev_rx_burst_8023ad() no longer recognizes LACP packets
> because the packet_type is set to RTE_PTYPE_L3_IPV4.
> Ensure packet_type is reset for non-ipv4 pac
-Original Message-
> Date: Wed, 17 Jan 2018 22:55:09 +0530
> From: Pavan Nikhilesh
> To: jerin.ja...@caviumnetworks.com, marko.kovace...@intel.com,
> john.mcnam...@intel.com, liang.j...@intel.com
> Cc: dev@dpdk.org, Pavan Nikhilesh
> Subject: [dpdk-dev] [PATCH] doc: fix OPDL release note
> -Original Message-
> From: Olivier Matz [mailto:olivier.m...@6wind.com]
> Sent: Tuesday, January 16, 2018 8:46 PM
> To: Xueming(Steven) Li
> Cc: Adrien Mazarguil ; dev@dpdk.org
> Subject: Re: [PATCH v2] lib/cmdline: init CLI parsing memory
>
> Hi Xueming,
>
> Sorry for the late respo
On 1/18/2018 5:59 AM, Thomas Monjalon wrote:
15/01/2018 11:48, Jeff Guo:
+ * It registers the callback for the specific event. Multiple
+ * callbacks cal be registered at the same time.
+ *
+ * @param device_name
+ * The device name.
+ * @param cb_fn
+ * callback address.
+ * @param cb_arg
+
On 1/18/2018 6:00 AM, Thomas Monjalon wrote:
15/01/2018 11:48, Jeff Guo:
+enum rte_dev_event_subsystem {
+ RTE_DEV_EVENT_SUBSYSTEM_UIO,
+ RTE_DEV_EVENT_SUBSYSTEM_VFIO,
+ RTE_DEV_EVENT_SUBSYSTEM_PCI,
+ RTE_DEV_EVENT_SUBSYSTEM_MAX
+};
I still don't understand this classi
This patch aim to add a general uevent mechanism in eal device layer,
to enable all linux kernel object uevent monitoring, user could use these
APIs to monitor and read out the device status info that sent from the
kernel side, then corresponding to handle it, such as when detect hotplug
uevent typ
use testpmd for example, to show app how to request and use
uevent monitoring to handle the hot removal event and the
hot insertion event.
Signed-off-by: Jeff Guo
---
v12->v11:
no change
---
app/test-pmd/testpmd.c | 168 +
app/test-pmd/testpmd.h |
In order to handle the uevent which have been detected from the kernel
side, add uevent process function, let hot plug event to be example to
show uevent mechanism how to pass the uevent and process the uevent.
About uevent passing and processing, add below functions in linux eal
dev layer. FreeBS
This patch add inforation about i40e queue region
realted to release notes, it has been missed before
in v17.11 release notes. This feature has been
implemented in v17.11.
Signed-off-by: Wei Zhao
---
v2:
-change this information to v18.02 release notes.
v3:
-rework it on dpdk-next-net-intel su
Due to a mistake operation from me, older version (v10) was merged to
master branch. It's the v11 should be applied. However, the master branch
is not rebase-able. Thus, this patch is made, from the diff between v10
and v11.
Code is from Xiao Wang.
Signed-off-by: Yuanhan Liu
---
lib/librte_net/
Fix build error when shared lib is enabled:
LD librte_net.so.1.1
rte_arp.o: In function `rte_net_make_rarp_packet':
rte_arp.c:(.text+0x1f0): undefined reference to `rte_mempool_ops_table'
rte_arp.c:(.text+0x21d): undefined reference to `rte_mempool_ops_table'
rte_arp.c:(.text+0x2d5): undefined r
Xiao told me that this series (except the last patch) was already applied
to the Thomas master branch. I then realised it was my mistake.
I applied v10 last week locally for some basic testing. There is a conflict
in last patch, that's why the last patch is not merged. I forgot to do
a reset befor
-Original Message-
> Date: Thu, 18 Jan 2018 00:18:47 +0100
> From: Thomas Monjalon
> To: Jerin Jacob
> Cc: dev@dpdk.org, santosh ,
> olivier.m...@6wind.com
> Subject: Re: [dpdk-dev] [PATCH] test/mempool_perf: improve default mempool
> ops selection
>
> 12/12/2017 16:12, santosh:
> >
>
Update release note to declare MPLSoUDP/MPLSoGRE/
GTP-U/GTP-C/PPPoE/PPPoL2TP steering support in i40e
driver.
Signed-off-by: Beilei Xing
Cc: sta...@dpdk.org
---
doc/guides/rel_notes/release_17_05.rst | 6 ++
doc/guides/rel_notes/release_17_11.rst | 6 ++
doc/guides/rel_notes/release_18_0
Hi, Konstantin,
On Tue, Jan 16, 2018 at 12:38:35PM +, Ananyev, Konstantin wrote:
>
>
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of wei.guo.si...@gmail.com
> > Sent: Saturday, January 13, 2018 2:35 AM
> > To: Lu, Wenzhuo
> > Cc: dev@dpdk.org; Thomas M
Hi, Thomas
I will update it in 17.11 release nots later as your comment.
And it has been CC to John, but not get any feedback.
Thanks.
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Wednesday, January 17, 2018 5:53 AM
> To: Zhang, Helin ; Zhao1, We
Hi,
> -Original Message-
> From: Yongseok Koh [mailto:ys...@mellanox.com]
> Sent: Thursday, January 18, 2018 2:19 AM
> To: Lu, Wenzhuo ; Wu, Jingjing
>
> Cc: dev@dpdk.org; Yongseok Koh
> Subject: [PATCH v2] app/testpmd: make txonly mode generate multiple flows
>
> Testpmd can generate m
Hi Matan,
> -Original Message-
> From: Matan Azrad [mailto:ma...@mellanox.com]
> Sent: Wednesday, January 17, 2018 4:51 PM
> To: Lu, Wenzhuo ; Thomas Monjalon
> ; Gaetan Rivet ; Wu,
> Jingjing
> Cc: dev@dpdk.org; Neil Horman ; Richardson,
> Bruce ; Ananyev, Konstantin
>
> Subject: RE: [d
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin
> Sent: Thursday, January 18, 2018 6:48 AM
> To: Nicolau, Radu; dev@dpdk.org
> Cc: Yigit, Ferruh; Lu, Wenzhuo; Zhao, XinfengX; De Lara Guarch, Pablo
> Subject: Re: [dpdk-dev] [PATCH v2] net/ixg
Hi Chas,
Thanks for your info and the patch. I think we should have it.
Acked-by: Wenzhuo Lu mailto:wenzhuo...@intel.com>>
Best regards
Wenzhuo Lu
From: Chas Williams [mailto:3ch...@gmail.com]
Sent: Friday, January 12, 2018 1:57 AM
To: Lu, Wenzhuo
Cc: dev@dpdk.org; skh...@vmware.com; Charle
04/01/2018 11:39, Bernard Iremonger:
> Remove the requirement to have a port bound to igb_uio in
> order to run this test suite.
>
> Fixes: 9c9befea4f57 ("test: add flow classify unit tests")
Cc: sta...@dpdk.org
> Reported by: Anatoly Burakov
>
> Signed-off-by: Bernard Iremonger
Applied, tha
> Phil Yang (2):
> test/memzone: Fix test_memzone_basic issue
> test/memzone: Fix test_memzone_free issue
Applied with acks from v1, thanks.
Next time, please keep acks in new version, if nothing major changed.
03/01/2018 13:01, Radoslaw Biernacki:
> s///g effects ;)
> Thank you!
>
> Reviewed-by: Radoslaw Biernacki
>
> On 21 December 2017 at 19:19, Anatoly Burakov
> wrote:
>
> > Fixes: 71330483a193 ("test/memzone: fix memory leak")
> > Cc: radoslaw.bierna...@linaro.org
> > Cc: sta...@dpdk.org
> > Sig
> > delete_bulk() copies metadata to pointers provided by the entries
> > parameter, but in the unit test, they are uninitialized, leading
> > to rte_table attempting to memcpy into random garbage pointers.
> >
> > Memsetting pointer table to zero will prevent that from happening.
> >
> > Fixes:
22/12/2017 10:51, Anatoly Burakov:
> This can be useful for checking if an autotest leaks memory after
> its execution.
>
> Signed-off-by: Anatoly Burakov
Applied, thanks
12/12/2017 16:12, santosh:
>
> On Sunday 19 November 2017 10:25 AM, Jerin Jacob wrote:
> > Use of rte_eal_mbuf_default_mempool_ops() API will
> > allow to override pool handler through "--mbuf-pool-ops-name"
> > eal command line argument.
> >
> > Signed-off-by: Jerin Jacob
> > ---
>
> Acked-by:
10/01/2018 15:24, Doherty, Declan:
> On 22/12/2017 10:21 AM, Anatoly Burakov wrote:
> > If test set up couldn't be completed, the test was previously
> > shown as succeeding, even though setup failed. Fix this to report
> > test as failed, and count all tests that should've been executed,
> > as fa
11/01/2018 18:50, Harry van Haaren:
> With this patch the test binary checks the DPDK_TEST
> environment variable and if set, the contents of the var
> are inserted on the test app command line, and run.
>
> Signed-off-by: Bruce Richardson
> Signed-off-by: Harry van Haaren
> Reviewed-by: Pablo d
> On Jan 11, 2018, at 1:25 AM, Nelio Laranjeiro
> wrote:
>
> All multi code should not be handled in exit part of the code but in the
> mainline of the function.
>
> Fixes: 4241d84c0a32 ("net/mlx5: fix flow type for allmulti rules")
> Cc: rasl...@mellanox.com
>
> Signed-off-by: Nelio Laranjei
Hi,
Please could you rebase on master and keep the acked already given?
Please use --in-reply-to to keep v3 in the same thread as v2.
Titles are the same for every patches.
Are they all fixing a NULL pointer check and a mem leak?
More details in the commit message may help.
If they are fixes, a
Sending again with fixed recipient email.
17/01/2018 23:49, Thomas Monjalon:
> We need someone from Intel to check on the testing platform please.
> It can be decided to drop testing of Suse 11 SP2.
> Thanks
>
> 15/01/2018 18:08, Adrien Mazarguil:
> > On Mon, Jan 15, 2018 at 05:18:37PM +0100, Adr
We need someone from Intel to check on the testing platform please.
It can be decided to drop testing of Suse 11 SP2.
Thanks
15/01/2018 18:08, Adrien Mazarguil:
> On Mon, Jan 15, 2018 at 05:18:37PM +0100, Adrien Mazarguil wrote:
> > On Sat, Jan 13, 2018 at 08:14:06PM +0100, Thomas Monjalon wrote:
> -Original Message-
> From: Nicolau, Radu
> Sent: Wednesday, January 17, 2018 11:55 AM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh ; Lu, Wenzhuo
> ; Ananyev, Konstantin ;
> Zhao, XinfengX ; De Lara Guarch, Pablo
> ; Nicolau, Radu
>
> Subject: [PATCH v2] net/ixgbe: check if security capabil
17/01/2018 22:58, Ferruh Yigit:
> +/*-
> + * BSD LICENSE
> + *
> + * Copyright(c) 2017 Intel Corporation. All rights reserved.
> + * All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the foll
17/01/2018 23:09, Thomas Monjalon:
> 17/01/2018 22:57, Ferruh Yigit:
> > port_id is now 16bits, update function parameter according.
> >
> > Fixes: 4c270218aa26 ("ethdev: support security APIs")
> > Cc: sta...@dpdk.org
> > Cc: declan.dohe...@intel.com
> >
> > Signed-off-by: Ferruh Yigit
> > Acke
17/01/2018 22:57, Ferruh Yigit:
> "struct rte_eth_rxtx_callback" is defined as internal data structure and
> used as named opaque type.
>
> So the functions that are adding callbacks can return objects in this
> type instead of void pointer.
It is an API change.
Let's plan it for 18.05.
17/01/2018 22:57, Ferruh Yigit:
> port_id is now 16bits, update function parameter according.
>
> Fixes: 4c270218aa26 ("ethdev: support security APIs")
> Cc: sta...@dpdk.org
> Cc: declan.dohe...@intel.com
>
> Signed-off-by: Ferruh Yigit
> Acked-by: Hemant Agrawal
Obviously,
Acked-by: Thomas Mo
15/01/2018 11:48, Jeff Guo:
> +enum rte_dev_event_subsystem {
> + RTE_DEV_EVENT_SUBSYSTEM_UIO,
> + RTE_DEV_EVENT_SUBSYSTEM_VFIO,
> + RTE_DEV_EVENT_SUBSYSTEM_PCI,
> + RTE_DEV_EVENT_SUBSYSTEM_MAX
> +};
I still don't understand this classification, mixing PCI and VFIO
at the s
15/01/2018 11:48, Jeff Guo:
> + * It registers the callback for the specific event. Multiple
> + * callbacks cal be registered at the same time.
> + *
> + * @param device_name
> + * The device name.
> + * @param cb_fn
> + * callback address.
> + * @param cb_arg
> + * address of parameter for cal
Update "port" function argument variable to "port_id" in public
header to be consistent in all APIs.
No functional change.
Signed-off-by: Ferruh Yigit
---
lib/librte_ether/rte_ethdev.h | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/l
Move all inline function to the end of the ethdev.h header file and move
the ethdev_core.h just before inline functions.
Since inline functions need data structures in ethdev_core.h, this
reorder is to group them and make it clear where put further inline
functions.
Signed-off-by: Ferruh Yigit
-
rte_ethdev_core.h created. Internal data structures are moved here.
These structures are mostly intended to be used by drivers, but they
need to be in the public header file because of the inline functions
in the ethdev.h header, and those inline functions are preferred to
kept because of the perf
Create a rte_ethdev_driver.h file and move PMD specific APIs here.
Drivers updated to include this new header file.
There is no update in header content and since ethdev.h included by
ethdev_driver.h, nothing changed from driver point of view, only
logically grouping of APIs. From applications poi
"struct rte_eth_rxtx_callback" is defined as internal data structure and
used as named opaque type.
So the functions that are adding callbacks can return objects in this
type instead of void pointer.
Signed-off-by: Ferruh Yigit
Acked-by: Stephen Hemminger
---
v2:
* keep using struct * in parame
port_id is now 16bits, update function parameter according.
Fixes: 4c270218aa26 ("ethdev: support security APIs")
Cc: sta...@dpdk.org
Cc: declan.dohe...@intel.com
Signed-off-by: Ferruh Yigit
Acked-by: Hemant Agrawal
---
Cc: Boris Pismenny
Cc: Aviad Yehezkel
Cc: Radu Nicolau
Cc: Declan Dohert
PKT_RX_VLAN_PKT and PKT_RX_QINQ_PKT were renamed to PKT_RX_VLAN and PKT_RX_QINQ
somewhere between DPDK version 16.07 and version 17.11.
Shouldn’t PKT_TX_VLAN_PKT and PKT_TX_QINQ_PKT follow the same naming convention
and get rid of the _PKT postfix?
Med venlig hilsen / kind regards
In rte_mbuf.h, the description of the PKT_RX_VLAN flag (lines 93-94) says that
mbuf->vlan_tci contains the VLAN TCI if the flag is set; however, the
description of the vlan_tci field (line 513) says that the PKT_RX_VLAN_STRIPPED
flag must be set for it to be valid.
Which one is it? And will
08/12/2017 18:01, Thomas Monjalon:
> 08/12/2017 15:14, Olivier MATZ:
> > > +* ring: The alignment constraints on the ring structure will be relaxed
> > > + to one cache line instead of two, and an empty cache line padding will
> > > + be added between the producer and consumer structures. The siz
No config option changed, added or removed.
Only reshuffle PMD config options mostly to help new PMDs where to put
their new config option.
Ordered as physical, paravirtual and virtual groups. Alphabetical order
within a group.
Also tried to group vendor devices together which breaks alphabetical
Hi Yigit,
I was testing with 16.11.2 dpdk version did found that few data were
missing in the rte_eth_dev like the driver.name. Then tried to update my stream
and check the handling and found the same missing. So raised the below patch.
Now on double checking it looks like my pull from m
On 1/17/2018 8:19 PM, Matan Azrad wrote:
> There is time between the physical removal of the device until PMDs get
> a RMV interrupt. At this time DPDK PMDs and applications still don't
> know about the removal.
>
> Current removal detection is achieved only by registration to device RMV
> event a
From: Matan Azrad, Wednesday, January 17, 2018 8:02 PM
> Hi Konstantin
>
> From: Ananyev, Konstantin, Wednesday, January 17, 2018 6:53 PM
> > Hi Matan,
> >
> > >
> > > Hi Konstantin
> > > From: Ananyev, Konstantin, Wednesday, January 17, 2018 2:55 PM
> > > > >
> > > > >
> > > > > Hi Konstantin
>
There is time between the physical removal of the device until
sub-device PMDs get a RMV interrupt. At this time DPDK PMDs and
applications still don't know about the removal and may call sub-device
control operation which should return an error.
In previous code this error is reported to the appl
rte_eth_dev_is_removed API was added to detect a device removal
synchronously.
When a device removal occurs during flow command execution, many
different errors can be reported to the user.
Adjust all flow APIs error reports to return -EIO in case of device
removal using rte_eth_dev_is_removed AP
rte_eth_dev_is_removed API was added to detect a device removal
synchronously.
When a device removal occurs during control command execution, many
different errors can be reported to the user.
Adjust all ethdev APIs error reports to return -EIO in case of device
removal using rte_eth_dev_is_remov
Add support to get removal status of mlx4 device.
Signed-off-by: Matan Azrad
---
drivers/net/mlx4/mlx4.c| 1 +
drivers/net/mlx4/mlx4.h| 1 +
drivers/net/mlx4/mlx4_ethdev.c | 20
3 files changed, 22 insertions(+)
diff --git a/drivers/net/mlx4/mlx4.c b/drive
Add support to get removal status of mlx5 device.
It is not supported in secondary process.
Signed-off-by: Matan Azrad
---
drivers/net/mlx5/mlx5.c| 2 ++
drivers/net/mlx5/mlx5.h| 1 +
drivers/net/mlx5/mlx5_ethdev.c | 20
3 files changed, 23 insertions(+)
d
There is time between the physical removal of the device until PMDs get
a RMV interrupt. At this time DPDK PMDs and applications still don't
know about the removal.
Current removal detection is achieved only by registration to device RMV
event and the notification comes asynchronously. So, there i
There is time between the physical removal of the device until sub-device PMDs
get a RMV interrupt.
At this time DPDK PMDs and applications still don't know about the removal and
may call sub-device control operation which should return an error.
This series adds new ethdev operation to check d
On 1/17/2018 6:30 PM, Ferruh Yigit wrote:
> Add note about PMD expects the network interfaces provided to be up,
> documented behavior to set expectations right.
>
> Also added minor fix.
>
> Signed-off-by: Ferruh Yigit
> Acked-by: John McNamara
Applied to dpdk-next-net/master, thanks.
On 1/17/2018 5:30 PM, Gaëtan Rivet wrote:
> Hi Moti,
>
> On Wed, Jan 17, 2018 at 04:30:12PM +0200, Moti Haimovsky wrote:
>> Ethdev Tx offloads API has changed since:
>> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")
>> This commit adds support for the new Tx offloads API.
>>
>> Si
On 1/15/2018 11:38 AM, Hemant Agrawal wrote:
> This patch enhances the Rx function to support more than
> 16 burst size.
>
> Signed-off-by: Hemant Agrawal
Series applied to dpdk-next-net/master, thanks.
On 1/12/2018 9:50 PM, Rasesh Mody wrote:
> This patch adds support for handling run-time driver arguments.
> We have removed config option for per VF Tx switching and added
> a run-time argument vf_txswitch. By default, the VF Tx switching is
> enabled however it can be disabled using run-time argu
On 1/17/2018 6:56 AM, Shahaf Shuler wrote:
> Tuesday, January 16, 2018 1:53 PM, Rafal Kozik:
>> Subject: [dpdk-dev] [PATCH 1/2] net/ena: convert to new Tx offloads API
>>
>> Ethdev Tx offloads API has changed since:
>>
>> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")
>>
>> This co
On 1/17/2018 8:23 AM, Rafal Kozik wrote:
> Ethdev Tx offloads API has changed since:
>
> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")
>
> This commit support the new Tx offloads API. Queue configuration
> is stored in ena_ring.offloads. During preparing mbufs for tx, offloads a
12/01/2018 19:27, Anatoly Burakov:
> Unlike every other DPDK application's compilation, proc_info's
> compilation cannot be turned off on Linux. Fix it by adding a
> config option to base linuxapp config.
>
> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
> Cc: maryam.tah...@intel.com
> On Jan 17, 2018, at 5:46 AM, Thomas Monjalon wrote:
>
> 16/01/2018 10:10, Jianbo Liu:
>> The 01/16/2018 10:49, Andrew Rybchenko wrote:
>>> On 01/16/2018 04:10 AM, Yongseok Koh wrote:
This commit introduces rte_dma_wmb() and rte_dma_rmb(), in order to
guarantee the ordering of coheren
1 - 100 of 225 matches
Mail list logo
