On 4/17/2018 11:42 PM, Anatoly Burakov wrote:
Coverity issue: 272607
Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 7 +--
1 file changed, 5 insertions(+),
Hi Amr,
> -Original Message-
> From: Mokhtar, Amr
> Sent: Tuesday, April 24, 2018 7:53 PM
> To: De Lara Guarch, Pablo ; Chalupnik, KamilX
> ; dev@dpdk.org
> Cc: Chalupnik, KamilX
> Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: update Turbo Software
> driver
>
>
> > -Original
After add RSS hash offload check, default rss_hf will fail on
devices that not support all bits, the patch introduce RSS
negotiate flag, when it is set, RSS configuration will negotiate
with device capability. By default negotiate is turn on, so it
will not break exist PMD. It can be disabled by "-
> -Original Message-
> From: Mokhtar, Amr
> Sent: Tuesday, April 24, 2018 8:09 PM
> To: De Lara Guarch, Pablo ; Chalupnik, KamilX
> ; dev@dpdk.org
> Cc: Chalupnik, KamilX
> Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: offload cost
> measurement test
>
>
>
> > -Original Me
25/04/2018 07:33, Zhang, Qi Z:
> > 10/04/2018 15:59, Thomas Monjalon:
> > > > --- a/lib/librte_ether/rte_ethdev.h
> > > > +++ b/lib/librte_ether/rte_ethdev.h
> > > > +#define DEV_RUNTIME_RX_QUEUE_SETUP 0x0001 /**< Deferred
> > setup
> > > > +rx queue */ #define DEV_RUNTIME_TX_QUEUE_SETUP 0x
Rename all device capabilities to start with RTE_ETH_DEV_CAPA.
Fixes: 172364028db6 ("net/i40e: enable runtime queue setup")
Signed-off-by: Qi Zhang
---
doc/guides/nics/features.rst | 4 ++--
drivers/net/i40e/i40e_ethdev.c | 4 ++--
lib/librte_ether/rte_ethdev.c | 4 ++--
lib/librte_ether/rte
Hi Thomas,
> > +/**
> > + * Placeholder for accessing plugin module eeprom
> > + */
> > +struct rte_dev_module_info {
> > + uint32_t type; /**< Type of plugin module eeprom */
> > + uint32_t eeprom_len; /**< Length of plugin module eeprom */
> > +};
>
> I am not sure "plugin module" is descriptive
On Tue, Apr 24, 2018 at 02:53:41PM -0700, Yongseok Koh wrote:
> On Tue, Apr 24, 2018 at 10:22:45PM +0200, Thomas Monjalon wrote:
> > 24/04/2018 21:15, Olivier Matz:
> > > On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote:
> > > > On 04/24/2018 07:02 PM, Olivier Matz wrote:
> > > > >
On 4/17/2018 11:48 PM, Anatoly Burakov wrote:
Return value from rte_socket_id_by_idx() may be negative, which would
result in negative index access.
Additionally, return value was of mismatched type (function returns
signed int, socket id was unsigned).
Coverity issue: 272571
Coverity issue:
Hi Yongseok,
On Tue, Apr 24, 2018 at 06:02:44PM +0200, Olivier Matz wrote:
> > > @@ -688,14 +704,33 @@ rte_mbuf_to_baddr(struct rte_mbuf *md)
> > > }
> > > /**
> > > + * Returns TRUE if given mbuf is cloned by mbuf indirection, or FALSE
> > > + * otherwise.
> > > + *
> > > + * If a mbuf has it
25/04/2018 10:21, Zijie Pan:
> Hi Thomas,
>
> > > +/**
> > > + * Placeholder for accessing plugin module eeprom
> > > + */
> > > +struct rte_dev_module_info {
> > > + uint32_t type; /**< Type of plugin module eeprom */
> > > + uint32_t eeprom_len; /**< Length of plugin module eeprom */
> > > +};
>
25/04/2018 10:18, Qi Zhang:
> Rename all device capabilities to start with RTE_ETH_DEV_CAPA.
>
> Fixes: 172364028db6 ("net/i40e: enable runtime queue setup")
Are you sure about the Fixes line?
On 4/20/2018 4:52 PM, Aaron Conole wrote:
> Kevin Traynor writes:
>
>> On 04/18/2018 02:28 PM, Thomas Monjalon wrote:
>>> 18/04/2018 14:28, Ferruh Yigit:
On 4/18/2018 10:14 AM, Thomas Monjalon wrote:
> 18/04/2018 11:05, Ferruh Yigit:
>> On 4/11/2018 12:28 AM, Thomas Monjalon wrote:
>
On 4/25/2018 9:33 AM, Thomas Monjalon wrote:
> 25/04/2018 10:18, Qi Zhang:
>> Rename all device capabilities to start with RTE_ETH_DEV_CAPA.
>>
>> Fixes: 172364028db6 ("net/i40e: enable runtime queue setup")
>
> Are you sure about the Fixes line?
Original patch is still on next-net, I am for squa
> -Original Message-
> From: Yigit, Ferruh
> Sent: Wednesday, April 25, 2018 4:39 PM
> To: Thomas Monjalon ; Zhang, Qi Z
>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix naming for device capability
>
> On 4/25/2018 9:33 AM, Thomas Monjalon wrote:
> > 25/04/2018 10:18,
Rename all device capabilities to start with RTE_ETH_DEV_CAPA.
Fixes: 8719ad91e5772 ("ethdev: support runtime queue setup")
Signed-off-by: Qi Zhang
---
v2:
- fix fix line
doc/guides/nics/features.rst | 4 ++--
drivers/net/i40e/i40e_ethdev.c | 4 ++--
lib/librte_ether/rte_ethdev.c | 4 ++--
Hi,
On Wed, Apr 25, 2018 at 01:00:23AM +0200, Thomas Monjalon wrote:
> Can we have this patchset in 18.05-rc1?
> Or is it candidate to rc2?
I realized I made my comments on v1 instead of v2, sorry.
https://dpdk.org/dev/patchwork/patch/36538/
https://dpdk.org/dev/patchwork/patch/36535/
https://dp
On Mon, Apr 16, 2018 at 02:33:26PM +0100, Andrew Rybchenko wrote:
> From: "Artem V. Andreev"
>
> Primarily, it is intended as a way for the mempool driver to provide
> additional information on how it lays up objects inside the mempool.
>
> Signed-off-by: Artem V. Andreev
> Signed-off-by: Andre
On Mon, Apr 16, 2018 at 02:33:27PM +0100, Andrew Rybchenko wrote:
> From: "Artem V. Andreev"
>
> If mempool manager supports object blocks (physically and virtual
> contiguous set of objects), it is sufficient to get the first
> object only and the function allows to avoid filling in of
> informa
On 4/25/2018 9:39 AM, Qi Zhang wrote:
> Rename all device capabilities to start with RTE_ETH_DEV_CAPA.
>
> Fixes: 8719ad91e5772 ("ethdev: support runtime queue setup")
>
> Signed-off-by: Qi Zhang
Squashed into relevant commit in next-net, thanks.
On 25-Apr-18 9:24 AM, Tan, Jianfeng wrote:
On 4/17/2018 11:48 PM, Anatoly Burakov wrote:
Return value from rte_socket_id_by_idx() may be negative, which would
result in negative index access.
Additionally, return value was of mismatched type (function returns
signed int, socket id was unsigne
On 25-Apr-18 8:09 AM, Tan, Jianfeng wrote:
On 4/17/2018 11:42 PM, Anatoly Burakov wrote:
Coverity issue: 272607
Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c |
On 24-Apr-18 11:16 PM, Arnon Warshavsky wrote:
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
Acked-by: Anatoly Burakov
--
Thanks,
Anatoly
-Original Message-
> Date: Wed, 25 Apr 2018 04:02:21 +0530
> From: Nikhil Rao
> To: jerin.ja...@caviumnetworks.com
> CC: dev@dpdk.org, hemant.agra...@nxp.com, Nikhil Rao
> Subject: [PATCH] eventdev: convert eth Rx adapter files to SPDX license tag
> X-Mailer: git-send-email 1.8.3.1
>
> S
On 24-Apr-18 11:16 PM, Arnon Warshavsky wrote:
Change some local functions return type from void to int.
This change does not break ABI as the functions are internal.
Panic thrown from threads was not handled in this patch
Signed-off-by: Arnon Warshavsky
---
<...>
+ if (rte_config_init()
> On Apr 25, 2018, at 1:28 AM, Olivier Matz wrote:
>
> Hi Yongseok,
>
> On Tue, Apr 24, 2018 at 06:02:44PM +0200, Olivier Matz wrote:
@@ -688,14 +704,33 @@ rte_mbuf_to_baddr(struct rte_mbuf *md)
}
/**
+ * Returns TRUE if given mbuf is cloned by mbuf indirection, or FALSE
Add APIs to read information from the DPDK applictions.
It can be used to dump the EEPROM of plugin modules (SFP+, QSFP, etc.).
Two APIs are introduced to access eeprom:
- rte_eth_dev_get_module_info
- rte_eth_dev_get_module_eeprom
Applications based on DPDK can dump eeprom by calling those two A
Add a new command "module-eeprom" to get the data of plugin
module EEPROM.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: or...@mellanox.com
Cc: bruce.richard...@intel.com
Cc: pablo.de.lara.gua...@intel.com
Cc: radu.nico...@intel.com
Cc: akhil.go...@nxp.com
Cc:
On 24-Apr-18 11:16 PM, Arnon Warshavsky wrote:
replace panic calls with log and return value.
Thread function removes the noreturn attribute.
Signed-off-by: Arnon Warshavsky
---
Just a general comment - i'm not too familiar with this code, but it
looks like all of these failures will only ha
Add new callbacks for eth_dev_ops of ixgbe to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: wenzhuo...@intel.com
Cc: konstantin.anan...@intel.com
drivers/net/ixgbe/ixgbe_ethdev.c | 79 +++
add new APIs:
- rte_eth_dev_get_module_info
- rte_eth_dev_get_module_eeprom
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: john.mcnam...@intel.com
Cc: marko.kovace...@intel.com
Cc: tho...@monjalon.net
doc/guides/nics/features.rst| 11
li
Add new callbacks for eth_dev_ops of e1000 to get the information and
data of plugin module EEPROM.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: wenzhuo...@intel.com
drivers/net/e1000/base/e1000_phy.h |8
drivers/net/e1000/igb_ethdev.c | 86
Add new callbacks for eth_dev_ops of i40e to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: beilei.x...@intel.com
Cc: qi.z.zh...@intel.com
drivers/net/i40e/i40e_ethdev.c | 147
1 file change
Hi Ferruh,
I should have mentioned earlier that TAP does support queue specific
capabilities.
Please look in tap_queue_setup() and note that each TAP queue is created with a
distinct file descriptor (fd).
Then supporting an offload capability is just implementing it in SW (e.g.
calculating IP
> On Apr 25, 2018, at 2:08 AM, Yongseok Koh wrote:
>> On Apr 25, 2018, at 1:28 AM, Olivier Matz wrote:
>>
>> Hi Yongseok,
>>
>> On Tue, Apr 24, 2018 at 06:02:44PM +0200, Olivier Matz wrote:
> @@ -688,14 +704,33 @@ rte_mbuf_to_baddr(struct rte_mbuf *md)
> }
> /**
> + * Returns TR
25/04/2018 11:13, Zijie Pan:
> v5 changes:
> - insert the new APIs in alphabetical order in rte_ethdev_version.map.
I think there is a misunderstanding.
I was asking to rename rte_dev_module_info as rte_eth_dev_module_info.
Hi Nikhil,
On 4/25/2018 4:02 AM, Nikhil Rao wrote:
Signed-off-by: Nikhil Rao
---
lib/librte_eventdev/rte_event_eth_rx_adapter.h | 32 +++---
lib/librte_eventdev/rte_event_eth_rx_adapter.c | 4
2 files changed, 7 insertions(+), 29 deletions(-)
diff --git a/lib/lib
Hi Thomas,
> > v5 changes:
> > - insert the new APIs in alphabetical order in rte_ethdev_version.map.
>
> I think there is a misunderstanding.
> I was asking to rename rte_dev_module_info as rte_eth_dev_module_info.
I will update the patch right now.
Thanks & Regards,
Zijie
<...>
>
> + if (rte_config_init() != 0) {
>> + rte_eal_init_alert("Failed to init configuration");
>> + rte_errno = EFAULT;
>> + return -1;
>> + }
>> +
>> + if (rte_mp_channel_init() < 0) {
>> + rte_eal_init_alert("failed to
> Just a general comment - i'm not too familiar with this code, but it looks
> like all of these failures will only happen on thread init. Can we make
> sure it starts?
>
> You can use similar approach to Olivier's (recently merged) thread
> affinity patches, with pthread barriers etc. to ensure th
>
>
> You mixed dpaa2 with bonding in this set.
>
Indeed. Thanks
25/04/2018 05:17, Stephen Hemminger:
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -209,6 +209,13 @@ DPDK_18.02 {
>
> } DPDK_17.11;
>
> +DPDK_18.05 {
> + global:
> +
> + rte_log_set_level_pattern;
> +
> +} DPDK_18_02;
Must be DPDK_18.02 wi
On 24/04/2018 20:53, Thomas Monjalon wrote:
[..]
But I would like to review the devargs you are standardizing.
Unfortunately, I cannot find a documentation about it.
How users are supposed to use it?
Can you, at least, describe the syntax in the commit log, please?
The patch follows this pseud
On 4/25/2018 10:18 AM, Ophir Munk wrote:
> Hi Ferruh,
>
> I should have mentioned earlier that TAP does support queue specific
> capabilities.
> Please look in tap_queue_setup() and note that each TAP queue is created with
> a distinct file descriptor (fd).
> Then supporting an offload capabili
On 04/19/2018 07:41 PM, Olivier Matz wrote:
On Mon, Mar 26, 2018 at 05:12:56PM +0100, Andrew Rybchenko wrote:
[...]
@@ -1531,6 +1615,71 @@ rte_mempool_get(struct rte_mempool *mp, void **obj_p)
}
/**
+ * @internal Get contiguous blocks of objects from the pool. Used internally.
+ * @param
On 4/22/2018 9:59 PM, Rasesh Mody wrote:
> From: Shahed Shaikh
>
> This change adds a new option to "port config" command to
> add udp tunnel port for VXLAN and GENEVE tunneling protocols.
> This command can be extended for other tunneling protocols
> listed in "enum rte_eth_tunnel_type" as and w
On 4/25/2018 10:52 AM, Ferruh Yigit wrote:
> On 4/22/2018 9:59 PM, Rasesh Mody wrote:
>> From: Shahed Shaikh
>>
>> This change adds a new option to "port config" command to
>> add udp tunnel port for VXLAN and GENEVE tunneling protocols.
>> This command can be extended for other tunneling protocol
Signed-off-by: Anatoly Burakov
---
Notes:
One other instance of using snprintf is left alone as
it is expected to be addressed by another patch [1].
[1] http://dpdk.org/dev/patchwork/patch/38301/
lib/librte_eal/common/eal_common_memalloc.c | 5 +++--
1 file changed, 3 insertion
This patchset fixes a host of coverity issues in memory subsystem
introduced with recent DPDK memory hotplug patchset.
Coverity issues fixed:
- 272601 - leaking fd
- 272560 - double close fd
- 272568 - leaking fd
- 272570 - leaking fd
- 272589 - dereference before null check
- 272602 - freeing wro
Previously, if mmap failed to map page address at requested
address, we were attempting to unmap the wrong address. Fix it
by unmapping our actual mapped address, and jump further to
avoid unmapping memory that is not allocated.
Coverity issue: 272602
Fixes: 582bed1e1d1d ("mem: support mapping hu
Coverity issue: 272601
Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/linuxapp/eal/eal_memory.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c
b/lib/libr
Normally, tailq entry should have a valid fd by the time we attempt
to map the segment. However, in case it doesn't, we're leaking fd,
so fix it.
Coverity issue: 272570
Fixes: 2a04139f66b4 ("eal: add single file segments option")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov
---
Previous code had an old rebase leftover from the time when
oldpolicy was an actual int, instead of a pointer. Fix it to
do comparison with dereferencing the pointer.
Coverity issue: 272589
Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime")
Cc: anatoly.bura...@intel.com
Signed-off
We close fd if we managed to find it in the list of allocated
segment lists (which should always be the case under normal
conditions), but if we didn't, the fd was leaking. Close it if
we couldn't find it in the segment list. This is not an issue
as if the segment is zero length, we're getting rid
We were closing descriptor before checking if mapping has
failed, but if it did, we did a second close afterwards. Fix
it by moving closing descriptor to after we check if mmap has
succeeded.
Coverity issue: 272560
Fixes: 2a04139f66b4 ("eal: add single file segments option")
Cc: anatoly.bura...@i
Coverity reports these lines as having no effect. Technically, we do
want for those lines to have no effect, however they would've likely
been optimized out. Add volatile qualifiers to ensure the code has
effects.
Coverity issue: 272608
Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runt
If user has specified a flag to unmap the area right after mapping it,
we were passing an already-unmapped pointer to RTE_LOG. This is not an
issue since RTE_LOG doesn't actually dereference the pointer, but fix
it anyway by moving call to RTE_LOG to before unmap.
Coverity issue: 272584
Fixes: b7
On 04/19/2018 07:42 PM, Olivier Matz wrote:
On Mon, Mar 26, 2018 at 05:12:55PM +0100, Andrew Rybchenko wrote:
From: "Artem V. Andreev"
Primarily, it is intended as a way for the mempool driver to provide
additional information on how it lays up objects inside the mempool.
Signed-off-by: Artem
Hi,
> -Original Message-
> From: Chalupnik, KamilX
> Sent: Wednesday, April 25, 2018 10:41 AM
> To: De Lara Guarch, Pablo ; dev@dpdk.org
> Cc: Mokhtar, Amr
> Subject: RE: [dpdk-dev] [PATCH v2] baseband/turbo_sw: optimization of turbo
> software driver
>
>
>
> > -Original Message---
Add APIs to read information from the DPDK applictions.
It can be used to dump the EEPROM of plugin modules (SFP+, QSFP, etc.).
Two APIs are introduced to access eeprom:
- rte_eth_dev_get_module_info
- rte_eth_dev_get_module_eeprom
Applications based on DPDK can dump eeprom by calling those two A
add new APIs:
- rte_eth_dev_get_module_info
- rte_eth_dev_get_module_eeprom
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: john.mcnam...@intel.com
Cc: marko.kovace...@intel.com
Cc: tho...@monjalon.net
doc/guides/nics/features.rst| 11
li
Add a new command "module-eeprom" to get the data of plugin
module EEPROM.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: or...@mellanox.com
Cc: bruce.richard...@intel.com
Cc: pablo.de.lara.gua...@intel.com
Cc: radu.nico...@intel.com
Cc: akhil.go...@nxp.com
Cc:
Add new callbacks for eth_dev_ops of ixgbe to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: remy.hor...@intel.com
Cc: wenzhuo...@intel.com
Cc: konstantin.anan...@intel.com
drivers/net/ixgbe/ixgbe_ethdev.c | 79 +++
Add new callbacks for eth_dev_ops of i40e to get the information
and data of plugin module eeprom.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: beilei.x...@intel.com
Cc: qi.z.zh...@intel.com
drivers/net/i40e/i40e_ethdev.c | 147
1 file change
Add new callbacks for eth_dev_ops of e1000 to get the information and
data of plugin module EEPROM.
Signed-off-by: Zijie Pan
Acked-by: Remy Horton
---
Cc: wenzhuo...@intel.com
drivers/net/e1000/base/e1000_phy.h |8
drivers/net/e1000/igb_ethdev.c | 86
On Wed, 2018-04-25 at 09:33 +0100, Ferruh Yigit wrote:
> On 4/20/2018 4:52 PM, Aaron Conole wrote:
> > Kevin Traynor writes:
> >
> > > On 04/18/2018 02:28 PM, Thomas Monjalon wrote:
> > > > 18/04/2018 14:28, Ferruh Yigit:
> > > > > On 4/18/2018 10:14 AM, Thomas Monjalon wrote:
> > > > > > 18/04/2
On 4/20/2018 1:26 AM, Thomas Monjalon wrote:
> 20/04/2018 02:01, Ferruh Yigit:
>> These drivers never attempt link speed negotiation. Change link_autoneg
>> value to ETH_LINK_FIXED to be more accurate and consistent between PMDs.
>>
>> Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value")
25/04/2018 11:40, Remy Horton:
>
> On 24/04/2018 20:53, Thomas Monjalon wrote:
> [..]
> > But I would like to review the devargs you are standardizing.
> > Unfortunately, I cannot find a documentation about it.
> > How users are supposed to use it?
> > Can you, at least, describe the syntax in the
Coverity was complaining about not checking result of call to
fcntl() for unlocking the file. Disregarding the fact that error
value returned from fcntl() unlock call is highly unlikely in the
first place, we are subsequently calling close() on that same fd,
which will drop the lock, which makes ca
This patchset fixes a few Coverity fixes in EAL introduced
by recent DPDK memory hotplug patchset.
Coverity issues fixed:
- 272607 - error condition not handled
Coverity issues not fixed:
- 272600 - negative return not handled
- Proper usage of API guarantees no negative return
One of existing
This patchset fixes a few Coverity issues in malloc
introduced by recent DPDK memory hotplug patchset.
Coverity issues fixed:
- 272566 - possible null dereference
- 272574 - use value before verification
The following coverity issues were not fixed:
- 272573 - calling memset with size 0
- This
Previous code checked for both first/last elements being NULL,
but if they weren't, the expectation was that they're both
non-NULL, which will be the case under normal conditions, but
may not be the case due to heap structure corruption.
Coverity issue: 272566
Fixes: bb372060dad4 ("malloc: make h
Technically, while the pointer would've been invalid if msl_idx
were invalid, we wouldn't have actually attempted to access the
pointer until verifying the index. Fix it by moving array access
to after we've verified validity of the index.
Coverity issue: 272574
Fixes: 66cc45e293ed ("mem: replace
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/common/malloc_mp.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/lib/librte_eal/common/malloc_mp.c
b/lib/librte_eal/common/malloc_mp.c
index 72b1f4c..931c14b 100644
--- a/lib/librte_eal/common/mallo
> Stephen Hemminger (5):
> eal: make syslog facility table const
> eal: allow symbolic log levels
> eal: make eal_log_level save private
> log: add ability to match dynamic log based on shell pattern
> doc: update guides for current preferrred log level syntax
Applied (with small fix in
On 4/24/2018 3:15 AM, Thomas Monjalon wrote:
> The basic operations for ports enumeration should not be
> considered as experimental in DPDK 18.05.
>
> The iterator RTE_ETH_FOREACH_DEV was introduced in DPDK 17.05.
> It uses the function the rte_eth_find_next_owned_by() to get
> only ownerless por
From: Ferruh Yigit, Tuesday, April 24, 2018 5:20 PM
> On 4/10/2018 4:39 PM, Matan Azrad wrote:
> > It is OK for me.
>
> Converting this to explicit ack:
> Acked-by: Matan Azrad
>
Ok, don't forget to remove the fixes line.
> > Thanks.
> >
> > From: Ophir Munk, Tuesday, April 10, 2018 6:36 PM
Hi Andrew,
> > > + * @warning
> > > + * @b EXPERIMENTAL: this API may change without prior notice.
> > > + *
> > > + * Additional information about the mempool
> > > + */
> > > +struct rte_mempool_info;
> > > +
> > [...]
> >
> > > +/* wrapper to get additional mempool info */
> > > +int
> > > +rt
25/04/2018 12:01, Zijie Pan:
> add new APIs:
> - rte_eth_dev_get_module_info
> - rte_eth_dev_get_module_eeprom
>
> Signed-off-by: Zijie Pan
> Acked-by: Remy Horton
Acked-by: Thomas Monjalon
25/04/2018 12:21, Ferruh Yigit:
> On 4/24/2018 3:15 AM, Thomas Monjalon wrote:
> > The basic operations for ports enumeration should not be
> > considered as experimental in DPDK 18.05.
> >
> > The iterator RTE_ETH_FOREACH_DEV was introduced in DPDK 17.05.
> > It uses the function the rte_eth_find
On 4/25/2018 11:25 AM, Matan Azrad wrote:
>
>
> From: Ferruh Yigit, Tuesday, April 24, 2018 5:20 PM
>> On 4/10/2018 4:39 PM, Matan Azrad wrote:
>>> It is OK for me.
>>
>> Converting this to explicit ack:
>> Acked-by: Matan Azrad
>>
>
> Ok, don't forget to remove the fixes line.
Don't forget? S
Few things below.
> Signed-off-by: Abhinandan Gujjar
> ---
> MAINTAINERS| 7 +
> doc/api/doxy-api-index.md | 1 +
> doc/guides/prog_guide/event_crypto_adapter.rst | 236
> doc/guides/prog_guide/index.rst| 1 +
> doc/g
25/04/2018 12:08, Anatoly Burakov:
> Coverity was complaining about not checking result of call to
> fcntl() for unlocking the file. Disregarding the fact that error
> value returned from fcntl() unlock call is highly unlikely in the
> first place, we are subsequently calling close() on that same f
From: Ferruh Yigit, Wednesday, April 25, 2018 1:29 PM
> On 4/25/2018 11:25 AM, Matan Azrad wrote:
> >
> >
> > From: Ferruh Yigit, Tuesday, April 24, 2018 5:20 PM
> >> On 4/10/2018 4:39 PM, Matan Azrad wrote:
> >>> It is OK for me.
> >>
> >> Converting this to explicit ack:
> >> Acked-by: Matan Az
The original implementation used flock() locks, but was later
switched to using fcntl() locks for page locking, because
fcntl() locks allow locking parts of a file, which is useful
for single-file segments mode, where locking the entire file
isn't as useful because we still need to grow and shrink
This patchset replaces the fcntl()-based locking used in
the original DPDK memory hotplug patchset, to an flock()-
and lockfile-based implementation, due to numerous (well,
one, really) problems with how fcntl() locks work.
Long story short, fcntl() locks will be dropped if any
fd referring to loc
Currently, memseg lists for secondary process are allocated on
sync (triggered by init), when they are accessed for the first
time. Move this initialization to a separate init stage for
memalloc.
Signed-off-by: Anatoly Burakov
Acked-by: Bruce Richardson
---
lib/librte_eal/bsdapp/eal/eal_memallo
On 4/25/2018 11:01 AM, Zijie Pan wrote:
> add new APIs:
> - rte_eth_dev_get_module_info
> - rte_eth_dev_get_module_eeprom
>
> Signed-off-by: Zijie Pan
> Acked-by: Remy Horton
> ---
> Cc: remy.hor...@intel.com
> Cc: john.mcnam...@intel.com
> Cc: marko.kovace...@intel.com
> Cc: tho...@monjalon.net
On 4/25/2018 11:01 AM, Zijie Pan wrote:
> Add new callbacks for eth_dev_ops of ixgbe to get the information
> and data of plugin module eeprom.
>
> Signed-off-by: Zijie Pan
> Acked-by: Remy Horton
> ---
> Cc: remy.hor...@intel.com
> Cc: wenzhuo...@intel.com
> Cc: konstantin.anan...@intel.com
>
On 25/04/2018 11:06, Thomas Monjalon wrote:
25/04/2018 11:40, Remy Horton:
On 24/04/2018 20:53, Thomas Monjalon wrote:
[..]
OK
Please can you add it as a comment in the parsing code?
We will need one or two examples in the commit message too.
Docs are being updated, so it should be in the
On 4/25/2018 11:33 AM, Matan Azrad wrote:
>
>
> From: Ferruh Yigit, Wednesday, April 25, 2018 1:29 PM
>> On 4/25/2018 11:25 AM, Matan Azrad wrote:
>>>
>>>
>>> From: Ferruh Yigit, Tuesday, April 24, 2018 5:20 PM
On 4/10/2018 4:39 PM, Matan Azrad wrote:
> It is OK for me.
Convert
On 4/25/2018 11:29 AM, Thomas Monjalon wrote:
> 25/04/2018 12:21, Ferruh Yigit:
>> On 4/24/2018 3:15 AM, Thomas Monjalon wrote:
>>> The basic operations for ports enumeration should not be
>>> considered as experimental in DPDK 18.05.
>>>
>>> The iterator RTE_ETH_FOREACH_DEV was introduced in DPDK
On 4/24/2018 12:59 PM, David Marchand wrote:
> On Tue, Apr 24, 2018 at 4:15 AM, Thomas Monjalon wrote:
>> The basic operations for ports enumeration should not be
>> considered as experimental in DPDK 18.05.
>>
>> The iterator RTE_ETH_FOREACH_DEV was introduced in DPDK 17.05.
>> It uses the functi
This patch check if a requested offloading is supported
in the device capability.
Any offloading is disabled by default if it is not set
in rte_eth_dev_configure( ) and rte_eth_[rt]x_queue_setup().
A per port offloading can only be enabled in
rte_eth_dev_configure(). If a per port offloading is
sen
This patch check if a requested offloading is supported
in the device capability.
Any offloading is disabled by default if it is not set
in rte_eth_dev_configure( ) and rte_eth_[rt]x_queue_setup().
A per port offloading can only be enabled in
rte_eth_dev_configure(). If a per port offloading is
sen
Live migration feature will be based on future development on ifc driver,
including port representor implementation and potential change in QEMU
and vhost user lib.
This patch removes live migration in ifcvf driver, if possible we could
squash this patch into 7c9f28370437 ("net/ifcvf: add ifcvf vd
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Wednesday, April 25, 2018 12:48 PM
> To: Ophir Munk ; Pascal Mazon
>
> Cc: dev@dpdk.org; Mordechay Haimovsky ; Olga
> Shern ; Thomas Monjalon ;
> Raslan Darawsheh ; Shahaf Shuler
>
> Subject: Re: [PATCH v3
On 4/25/2018 8:43 AM, Qi Zhang wrote:
> After add RSS hash offload check, default rss_hf will fail on
> devices that not support all bits, the patch introduce RSS
> negotiate flag, when it is set, RSS configuration will negotiate
> with device capability. By default negotiate is turn on, so it
> wi
This patch check if a requested offloading is supported
in the device capability.
Any offloading is disabled by default if it is not set
in rte_eth_dev_configure( ) and rte_eth_[rt]x_queue_setup().
A per port offloading can only be enabled in
rte_eth_dev_configure(). If a per port offloading is
sen
This patch check if a requested offloading is supported
in the device capability.
Any offloading is disabled by default if it is not set
in rte_eth_dev_configure( ) and rte_eth_[rt]x_queue_setup().
A per port offloading can only be enabled in
rte_eth_dev_configure(). If a per port offloading is
sen
1 - 100 of 296 matches
Mail list logo
