Re: [dpdk-dev] [PATCH v2 4/8] net/virtio: free IN_ORDER descriptors before device start

2018-06-26 Thread Maxime Coquelin
On 06/25/2018 05:17 PM, Marvin Liu wrote: Add new function for freeing IN_ORDER descriptors. As descriptors will be allocated and freed sequentially when IN_ORDER feature was negotiated. There will be no need to utilize chain for freed descriptors management, only index update is enough. Sign

Re: [dpdk-dev] [PATCH v2 3/8] net/virtio-user: add mrg_rxbuf and in_order vdev parameters

2018-06-26 Thread Maxime Coquelin
On 06/25/2018 05:17 PM, Marvin Liu wrote: Add parameters for configuring VIRTIO_NET_F_MRG_RXBUF and VIRTIO_F_IN_ORDER feature bits. If feature is disabled, also update corresponding unsupported feature bit. Signed-off-by: Marvin Liu diff --git a/drivers/net/virtio/virtio_user/virtio_user_de

Re: [dpdk-dev] [PATCH] net/virtio-user: add unsupported features mask

2018-06-26 Thread Maxime Coquelin
On 06/26/2018 11:02 AM, Liu, Yong wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Tuesday, June 26, 2018 4:08 PM To: Liu, Yong ; Bie, Tiwei Cc: Wang, Zhihong ; dev@dpdk.org Subject: Re: [PATCH] net/virtio-user: add unsupported features mask

Re: [dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper

2018-06-26 Thread Sunil Kumar Kori
Regards Sunil Kumar > -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Friday, June 8, 2018 10:54 PM > To: Bruce Richardson ; Jerin Jacob > ; Pablo de Lara > > Cc: Anoob Joseph ; Hemant Agrawal > ; Narayana Prasad > ; Nikhil Rao > ; Pavan Nikhile

Re: [dpdk-dev] [PATCH V3 4/4] app/testpmd: show example to handle hot unplug

2018-06-26 Thread Matan Azrad
Hi Guo From: Guo, Jia > Sent: Wednesday, June 27, 2018 6:56 AM > To: Matan Azrad ; step...@networkplumber.org; > bruce.richard...@intel.com; ferruh.yi...@intel.com; > konstantin.anan...@intel.com; gaetan.ri...@6wind.com; > jingjing...@intel.com; Thomas Monjalon ; > Mordechay Haimovsky ; harry.van.

Re: [dpdk-dev] [PATCH v3 1/3] gso: support UDP/IPv4 fragmentation

2018-06-26 Thread Hu, Jiayu
> -Original Message- > From: Hu, Jiayu > Sent: Wednesday, June 27, 2018 10:29 AM > To: Ophir Munk ; dev@dpdk.org > Cc: Wang, Xiao W ; Ananyev, Konstantin > ; Zhang, Yuwei1 > ; Iremonger, Bernard > ; Thomas Monjalon > > Subject: RE: [dpdk-dev] [PATCH v3 1/3] gso: support UDP/IPv4 > fragm

Re: [dpdk-dev] [PATCH] net/i40e: remove VF interrupt handler

2018-06-26 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Wednesday, June 27, 2018 11:48 AM > To: Zhang, Qi Z > Cc: Wu, Jingjing ; Yu, De ; > dev@dpdk.org > Subject: RE: [PATCH] net/i40e: remove VF interrupt handler > > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Thursda

Re: [dpdk-dev] [PATCH V3 4/4] app/testpmd: show example to handle hot unplug

2018-06-26 Thread Guo, Jia
hi, mantan On 6/27/2018 1:07 AM, Matan Azrad wrote: Hi Jeff Continue session from last version + more comments\question. From: Jeff Guo Sent: Tuesday, June 26, 2018 6:36 PM To: step...@networkplumber.org; bruce.richard...@intel.com; ferruh.yi...@intel.com; konstantin.anan...@intel.com; gaeta

Re: [dpdk-dev] [PATCH] net/i40e: remove VF interrupt handler

2018-06-26 Thread Xing, Beilei
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, June 7, 2018 9:32 AM > To: Xing, Beilei > Cc: Wu, Jingjing ; Yu, De ; > dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH] net/i40e: remove VF interrupt handler > > For i40evf, internal rx interrupt and adminq interrupt share the sa

Re: [dpdk-dev] [PATCH v4 03/24] ethdev: add function to release port in local process

2018-06-26 Thread Zhang, Qi Z
> -Original Message- > From: Matan Azrad [mailto:ma...@mellanox.com] > Sent: Wednesday, June 27, 2018 12:55 AM > To: Zhang, Qi Z ; Thomas Monjalon > ; Burakov, Anatoly > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati, Nare

Re: [dpdk-dev] [PATCH v3 1/3] gso: support UDP/IPv4 fragmentation

2018-06-26 Thread Hu, Jiayu
Hi Ophir, Replies are inline. > -Original Message- > From: Ophir Munk [mailto:ophi...@mellanox.com] > Sent: Wednesday, June 27, 2018 7:59 AM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Wang, Xiao W ; Ananyev, Konstantin > ; Zhang, Yuwei1 > ; Iremonger, Bernard > ; Thomas Monjalon > > Subject: R

Re: [dpdk-dev] [RFC] net/ixgbe: fix Tx descriptor status api

2018-06-26 Thread Zhao1, Wei
Hi, Olivier Matz > -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Tuesday, June 26, 2018 4:46 PM > To: Zhao1, Wei > Cc: Zhang, Qi Z ; dev@dpdk.org; Lu, Wenzhuo > > Subject: Re: [RFC] net/ixgbe: fix Tx descriptor status api > > Hi Wei, > > On Tue, Jun 26

Re: [dpdk-dev] [PATCH 3/3] gso: add UDP/IPv4 GSO to the programmer guide

2018-06-26 Thread Zhang, Yuwei1
Tested-by: Yuwei Zhang -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jiayu Hu Sent: Tuesday, May 29, 2018 3:41 PM To: dev@dpdk.org Cc: Ananyev, Konstantin ; Hu, Jiayu Subject: [dpdk-dev] [PATCH 3/3] gso: add UDP/IPv4 GSO to the programmer guide Signed-off-by: J

[dpdk-dev] [PATCH] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

2018-06-26 Thread Cody Doucette
Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any other IPv6 extension headers when finding the fragment header. According to RFC 8200, there is no guarantee that the IPv6 Fragment extension header will come before any other extension header, even though it is recommended. Signed-o

Re: [dpdk-dev] [PATCH v4 06/24] ethdev: enable hotplug on multi-process

2018-06-26 Thread Zhang, Qi Z
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, June 26, 2018 11:12 PM > To: Zhang, Qi Z ; tho...@monjalon.net > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati, Narender > > Subject: Re: [PATCH v4 06/24] ethd

[dpdk-dev] Regarding support for C3xxx (Denverton) QAT compression in 18.08

2018-06-26 Thread Srinivasan J
Hi, As per DPDK roadmap, 18.08 is supposed to have a compression PMD for QAT chipsets. Please share information if C3xxx (denverton) chipset would be supported in 18.08 QAT compression PMD. Reference: http://core.dpdk.org/roadmap/ Thanks, Srini

Re: [dpdk-dev] [PATCH v3 1/3] gso: support UDP/IPv4 fragmentation

2018-06-26 Thread Ophir Munk
Hi, Please find some comments below. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jiayu Hu > Sent: Friday, June 22, 2018 8:54 AM > To: dev@dpdk.org > Cc: xiao.w.w...@intel.com; konstantin.anan...@intel.com; > yuwei1.zh...@intel.com; bernard.iremon...@intel.co

[dpdk-dev] [PATCH 6/6] net/nfp: set dma mask

2018-06-26 Thread Alejandro Lucero
NFP 4000/6000 devices can not use iova addresses requiring more than 40 bits. This patch sets a dma mask for avoiding hugepages with iova requiring more than those 40 bits. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers

[dpdk-dev] [PATCH 5/6] ethdev: add function for dma mask

2018-06-26 Thread Alejandro Lucero
This function calls a generic one for ethernet devices. Signed-off-by: Alejandro Lucero --- lib/librte_ether/rte_ethdev.h | 12 1 file changed, 12 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index eba11ca..e3979e4 100644 --- a/lib/librte

[dpdk-dev] [PATCH 4/6] mem: add function for setting internal dma mask

2018-06-26 Thread Alejandro Lucero
A device with addressing limitations will invoke this function for setting a dma mask. It has no effect if there is another dma mask already set and more restrictive than this one. Signed-off-by: Alejandro Lucero --- lib/librte_eal/common/eal_common_memory.c | 15 +++ lib/librte_eal

[dpdk-dev] [PATCH 2/6] mem: add hugepages check

2018-06-26 Thread Alejandro Lucero
Devices can have addressing limitations and a driver can set a dma mask. This patch adds a function for checking hugepages iovas are within the range supported by the dma mask. Signed-off-by: Alejandro Lucero --- lib/librte_eal/linuxapp/eal/eal_memory.c | 36 1 f

[dpdk-dev] [RFC] Add support for device dma mask

2018-06-26 Thread Alejandro Lucero
This RFC tries to handle devices with addressing limitations. NFP devices 4000/6000 can just handle addresses with 40 bits implying problems for handling physical address when machines have more than 1TB of memory. But because how iovas are configured, which can be equivalent to physical addresses

[dpdk-dev] [PATCH 3/6] eal: check hugepages within dma mask range

2018-06-26 Thread Alejandro Lucero
Hugepages get an iova address which could be out of range for devices with addressing limitations. This patch checks hugepages are withint the range if dma mask is set by a device. Signed-off-by: Alejandro Lucero --- lib/librte_eal/common/eal_private.h | 3 +++ lib/librte_eal/linuxapp/eal/eal.c

[dpdk-dev] [PATCH 1/6] eal: add internal dma mask

2018-06-26 Thread Alejandro Lucero
Devices can have addressing limitations and an internal dma mask will track the more restrictive dma mask set by a device. Signed-off-by: Alejandro Lucero --- lib/librte_eal/common/eal_common_options.c | 1 + lib/librte_eal/common/eal_internal_cfg.h | 1 + 2 files changed, 2 insertions(+) dif

Re: [dpdk-dev] [PATCH] net/thunderx: fix build with gcc optimization on

2018-06-26 Thread Ferruh Yigit
On 6/24/2018 1:17 PM, Jerin Jacob wrote: > -Original Message- >> Date: Thu, 21 Jun 2018 19:14:50 +0100 >> From: Ferruh Yigit >> To: Jerin Jacob , Maciej Czekaj >> >> CC: dev@dpdk.org, Ferruh Yigit , sta...@dpdk.org >> Subject: [PATCH] net/thunderx: fix build with gcc optimization on >> X

Re: [dpdk-dev] [PATCH V3 4/4] app/testpmd: show example to handle hot unplug

2018-06-26 Thread Matan Azrad
Hi Jeff Continue session from last version + more comments\question. From: Jeff Guo > Sent: Tuesday, June 26, 2018 6:36 PM > To: step...@networkplumber.org; bruce.richard...@intel.com; > ferruh.yi...@intel.com; konstantin.anan...@intel.com; > gaetan.ri...@6wind.com; jingjing...@intel.com; Thomas

[dpdk-dev] [PATCH v8 18/21] ethdev: add private generic device iterator

2018-06-26 Thread Gaetan Rivet
This iterator can be customized with a comparison function that will trigger a stopping condition. It can be leveraged to write several different iterators that have similar but non-identical purposes. It is private to librte_ethdev. Signed-off-by: Gaetan Rivet --- lib/librte_ethdev/Makefile

[dpdk-dev] [PATCH v8 21/21] app/testpmd: add show device command

2018-06-26 Thread Gaetan Rivet
A new interactive command is offered: show device This commands lists all rte_device element matching the device description. e.g.: show device bus=pci show device bus=vdev show device bus=vdev/class=eth show device bus=vdev,driver=net_ring/class=eth show device bus=vdev/class

[dpdk-dev] [PATCH v8 19/21] ethdev: register ether layer as a class

2018-06-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_ethdev/Makefile| 3 +- lib/librte_ethdev/rte_class_eth.c | 79 +++ 2 files changed, 81 insertions(+), 1 deletion(-) create mode 100644 lib/librte_ethdev/rte_class_eth.c diff --git a/lib/librte_ethdev/Makefil

[dpdk-dev] [PATCH v8 20/21] ethdev: add device matching field name

2018-06-26 Thread Gaetan Rivet
The eth device class can now parse a field name, matching the eth_dev name with one passed as "class=eth,name=xx" Signed-off-by: Gaetan Rivet --- lib/librte_ethdev/rte_class_eth.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/librte_ethdev/rte_class_eth.c b/lib/librte_e

[dpdk-dev] [PATCH v8 17/21] bus/vdev: add device matching field driver

2018-06-26 Thread Gaetan Rivet
The vdev bus parses a field "driver", matching a vdev driver name with one passed as follows: "bus=vdev,driver=" Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/vdev_params.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vdev/vdev_param

[dpdk-dev] [PATCH v8 16/21] bus/vdev: implement device iteration

2018-06-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/Makefile | 3 ++- drivers/bus/vdev/vdev.c | 10 drivers/bus/vdev/vdev_params.c | 51 + drivers/bus/vdev/vdev_private.h | 26 + 4 files changed, 85 insertions(+), 5

[dpdk-dev] [PATCH v8 13/21] kvargs: add generic string matching callback

2018-06-26 Thread Gaetan Rivet
This function can be used as a callback to rte_kvargs_process. This should reduce code duplication. Signed-off-by: Gaetan Rivet --- lib/librte_kvargs/rte_kvargs.c | 10 ++ lib/librte_kvargs/rte_kvargs.h | 28 lib/librte_kvargs/rte_kvargs_

[dpdk-dev] [PATCH v8 14/21] bus/pci: implement device iteration and comparison

2018-06-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/bus/pci/Makefile | 3 ++- drivers/bus/pci/pci_common.c | 3 +-- drivers/bus/pci/pci_params.c | 53 drivers/bus/pci/private.h| 25 + 4 files changed, 81 insertions(+), 3 deletions(-)

[dpdk-dev] [PATCH v8 15/21] bus/pci: add device matching field id

2018-06-26 Thread Gaetan Rivet
The PCI bus can now parse a matching field "id" as follows: "bus=pci,id=:00:00.0" or "bus=pci,id=00:00.0" Signed-off-by: Gaetan Rivet --- drivers/bus/pci/pci_params.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH v8 12/21] eal/dev: implement device iteration

2018-06-26 Thread Gaetan Rivet
Use the iteration hooks in the abstraction layers to perform the requested filtering on the internal device lists. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_dev.c | 168 lib/librte_eal/common/include/rte_dev.h | 26 + lib/librte_eal/r

[dpdk-dev] [PATCH v8 11/21] eal/dev: implement device iteration initialization

2018-06-26 Thread Gaetan Rivet
Parse a device description. Split this description in their relevant part for each layers. No dynamic allocation is performed. Signed-off-by: Gaetan Rivet --- lib/Makefile| 1 + lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/common/eal_common_dev.c |

[dpdk-dev] [PATCH v8 10/21] eal/bus: add device iteration

2018-06-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_bus.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h index eb9eded4e..747baf140 100644 --- a/lib/librte_eal/common/include/rte_bus.h +++ b/lib/

[dpdk-dev] [PATCH v8 08/21] eal/dev: add device iterator interface

2018-06-26 Thread Gaetan Rivet
A device iterator allows iterating over a set of devices. This set is defined by the two descriptions offered, * rte_bus * rte_class Only one description can be provided, or both. It is not allowed to provide no description at all. Each layer of abstraction then performs a filter based on th

[dpdk-dev] [PATCH v8 09/21] eal/class: add device iteration

2018-06-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_class.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/include/rte_class.h b/lib/librte_eal/common/include/rte_class.h index e8176f5e1..9d5b06807 100644 --- a/lib/librte_eal/common/include/rte_class.h ++

[dpdk-dev] [PATCH v8 06/21] eal/class: register destructor

2018-06-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_class.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/librte_eal/common/include/rte_class.h b/lib/librte_eal/common/include/rte_class.h index b5e550a34..e8176f5e1 100644 --- a/lib/librte_eal/common/include/rte_class

[dpdk-dev] [PATCH v8 07/21] devargs: add function to parse device layers

2018-06-26 Thread Gaetan Rivet
This function is private to the EAL. It is used to parse each layers in a device description string, and store the result in an rte_devargs structure. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 144 lib/librte_eal/common/eal_private

[dpdk-dev] [PATCH v8 05/21] eal: introduce device class abstraction

2018-06-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/common/Makefile | 2 +- lib/librte_eal/common/eal_common_class.c | 62 +++ lib/librte_eal/common/include/rte_class.h | 121 + lib/librte_eal

[dpdk-dev] [PATCH v8 04/21] eal: introduce dtor macros

2018-06-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_common.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h index 434adfd45..0dd832728 100644 --- a/lib/librte_eal/c

[dpdk-dev] [PATCH v8 03/21] kvargs: introduce a more flexible parsing function

2018-06-26 Thread Gaetan Rivet
This function permits defining additional terminating characters, ending the parsing to arbitrary delimiters. Signed-off-by: Gaetan Rivet --- lib/Makefile | 1 + lib/librte_kvargs/rte_kvargs.c | 25 + lib/librte_kvargs/rte_kvargs.h

[dpdk-dev] [PATCH v8 01/21] devargs: add non-variadic parsing function

2018-06-26 Thread Gaetan Rivet
rte_devargs_parse becomes non-variadic, rte_devargs_parsef becomes the variadic version, to be used to compose device strings. Signed-off-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_args.c| 2 +- drivers/net/failsafe/failsafe_eal.c | 2 +- lib/librte_eal/common/eal_commo

[dpdk-dev] [PATCH v8 02/21] kvargs: build before EAL

2018-06-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/Makefile | 3 +-- lib/librte_kvargs/Makefile | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/Makefile b/lib/Makefile index d82462ba2..e8e903c8f 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -4,6 +4,7 @@ include $(RTE_

[dpdk-dev] [PATCH v8 00/21] Device querying

2018-06-26 Thread Gaetan Rivet
This patchset introduces a new EAL API for querying devices, filtered by arbitrary properties. The following elements are introduced to this end: * A new object, "rte_class", is used to describe the device class abstraction layer (eth, crypto, ...). * Both rte_bus and rte_class now offer a

Re: [dpdk-dev] [PATCH v4 03/24] ethdev: add function to release port in local process

2018-06-26 Thread Matan Azrad
Hi Zhang From: Zhang, Qi Z > Sent: Tuesday, June 26, 2018 4:30 PM > To: Matan Azrad ; Thomas Monjalon > ; Burakov, Anatoly > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati, Narender > > Subject: RE: [dpdk-dev] [PATCH v4 03/24] et

Re: [dpdk-dev] [PATCH v2 1/1] ena: fix SIGFPE with 0 rx queues

2018-06-26 Thread Ferruh Yigit
On 6/26/2018 6:38 PM, Ferruh Yigit wrote: > From: Daria Kolistratova I re-send the Daria's patch, somehow it didn't appeared in mail list and patchwork. > > When the number of rx queues is 0 > (what can be when application does not receive) > failed with SIGFPE. It happens when the application

[dpdk-dev] [PATCH v2 1/1] ena: fix SIGFPE with 0 rx queues

2018-06-26 Thread Ferruh Yigit
From: Daria Kolistratova When the number of rx queues is 0 (what can be when application does not receive) failed with SIGFPE. It happens when the application is also requesting ETH_MQ_RX_RSS_FLAG in the rte_dev->data->dev_conf.rxmode.mq_mode. Fixed adding zero rx queues check. Signed-off-by: Da

Re: [dpdk-dev] [PATCH v4 01/24] eal: introduce one device scan

2018-06-26 Thread Gaëtan Rivet
On Tue, Jun 26, 2018 at 12:26:05PM +, Zhang, Qi Z wrote: > > > > -Original Message- > > From: Burakov, Anatoly > > Sent: Tuesday, June 26, 2018 7:48 PM > > To: Zhang, Qi Z ; tho...@monjalon.net > > Cc: Ananyev, Konstantin ; dev@dpdk.org; > > Richardson, Bruce ; Yigit, Ferruh > > ; She

[dpdk-dev] [PATCH v2] examples: fix RSS hash function configuration

2018-06-26 Thread Ferruh Yigit
ethdev layer introduced checks for application requested RSS hash functions and returns error for ones unsupported by hardware This check breaks some sample applications which blindly configures RSS hash functions without checking underlying hardware support. Updated examples to mask out unsuppor

[dpdk-dev] [PATCH v1 5/5] vhost: message handling implemented as a callback array

2018-06-26 Thread Nikolay Nikolaev
Introduce vhost_message_handlers, which maps the message request type to the message handler. Then replace the switch construct with a map and call. Signed-off-by: Nikolay Nikolaev --- lib/librte_vhost/vhost_user.c | 144 - 1 file changed, 55 insertions(+

[dpdk-dev] [PATCH v1 4/5] vhost: unify message handling function signature

2018-06-26 Thread Nikolay Nikolaev
Each vhost-user message handlign function will return an int result which is described in the new enum vh_result: error, OK and reply. All functions will now have two arguments, virtio_net double pointer and VhostUserMsg pointer. Signed-off-by: Nikolay Nikolaev --- lib/librte_vhost/vhost_user.c

[dpdk-dev] [PATCH v1 3/5] vhost: handle unsupported message types in functions

2018-06-26 Thread Nikolay Nikolaev
Add new functions to handle the unsupported vhost message types: - vhost_user_set_vring_err - vhost_user_set_log_fd Signed-off-by: Nikolay Nikolaev --- lib/librte_vhost/vhost_user.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/lib/librte_vhost/v

[dpdk-dev] [PATCH v1 2/5] vhost: make message handling functions prepare the reply

2018-06-26 Thread Nikolay Nikolaev
As VhostUserMsg structure is resued to generate the reply, move the relevant fields update into the respective message handling functions. Signed-off-by: Nikolay Nikolaev --- lib/librte_vhost/vhost_user.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff

[dpdk-dev] [PATCH v1 1/5] vhost: unify VhostUserMsg usage

2018-06-26 Thread Nikolay Nikolaev
Use the typedef version of struct VhostUserMsg. Also unify the related parameter name. Signed-off-by: Nikolay Nikolaev --- lib/librte_vhost/vhost_user.c | 50 + 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/lib/librte_vhost/vhost_user.c

[dpdk-dev] [PATCH v1 0/5] vhost_user.c code cleanup

2018-06-26 Thread Nikolay Nikolaev
vhost: vhost_user.c code cleanup This patchesries introduce a set of code redesigns in vhost_user.c. The goal is to unify and simplify vhost-user message handling. The patches do not intend to introduce any functional changes. --- Nikolay Nikolaev (5): vhost: unify VhostUserMsg usage

Re: [dpdk-dev] [PATCH v1 3/3] hash: add new API function to query the key count

2018-06-26 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Yipeng1 > Sent: Friday, June 8, 2018 11:51 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Mcnamara, > John ; Richardson, Bruce > ; honnappa.nagaraha...@arm.com; > vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com > Subject: [PATC

Re: [dpdk-dev] [PATCH v4] net/bonding: add add/remove mac addrs

2018-06-26 Thread Ferruh Yigit
On 6/20/2018 9:37 AM, Alex Kiselev wrote: > add functions to add/remove MAC addresses > Signed-off-by: Alex Kiselev Acked-by: Declan Doherty Acked-by: Chas Williams Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: move log macro to header

2018-06-26 Thread Ferruh Yigit
On 6/26/2018 1:25 PM, Thomas Monjalon wrote: > 26/06/2018 13:41, Shahaf Shuler: >> Tuesday, June 19, 2018 4:05 AM, Ferruh Yigit: >>> Subject: [dpdk-dev] [PATCH v4 1/3] ethdev: move log macro to header >>> >>> Macro moved to header to be able to convert logging usage in header. >>> And since it has

Re: [dpdk-dev] [PATCH v1 2/3] test: add test case for read write concurrency

2018-06-26 Thread De Lara Guarch, Pablo
Hi Yipeng, > -Original Message- > From: Wang, Yipeng1 > Sent: Friday, June 8, 2018 11:51 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Mcnamara, > John ; Richardson, Bruce > ; honnappa.nagaraha...@arm.com; > vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com > Subje

Re: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev args

2018-06-26 Thread Ferruh Yigit
On 6/26/2018 1:48 PM, Shahaf Shuler wrote: > Hi Pavan, > > Friday, June 15, 2018 7:44 AM, Pavan Nikhilesh: >> Subject: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev >> args >> >> Currently, the only way of supplying device argument to a pci device is to >> whitelist it i.e. -w 00

[dpdk-dev] [PATCH V3 4/4] app/testpmd: show example to handle hot unplug

2018-06-26 Thread Jeff Guo
Use testpmd for example, to show how an application smoothly handle failure when device being hot unplug. If app have enabled the device event monitor and register the hot plug event’s callback before running, once app detect the removal event, the callback would be called. It will first stop the p

[dpdk-dev] [PATCH V3 3/4] igb_uio: fix uio release issue when hot unplug

2018-06-26 Thread Jeff Guo
When hot unplug device, the kernel will release the device resource in the kernel side, such as the fd sys file will disappear, and the irq will be released. At this time, if igb uio driver still try to release this resource, it will cause kernel crash. On the other hand, something like interrupt d

[dpdk-dev] [PATCH V3 2/4] eal: add failure handle mechanism for hot plug

2018-06-26 Thread Jeff Guo
This patch introduces a failure handler mechanism to handle device hot unplug event. When device be hot plug out, the device resource become invalid, if this resource is still be unexpected read/write, system will crash. This patch let framework help application to handle this fault. When sigbus e

[dpdk-dev] [PATCH V3 1/4] bus/pci: handle device hot unplug

2018-06-26 Thread Jeff Guo
When a hardware device is removed physically or the software disables it, the hot unplug occur. App need to call ether dev API to detach the device, to unplug the device at the bus level and make access to the device invalid. But the problem is that, the removal of the device from the software list

Re: [dpdk-dev] [PATCH v2 4/4] app/testpmd: show example to handle hot unplug

2018-06-26 Thread Guo, Jia
hi, matan thanks for your review, see comment. On 6/26/2018 7:58 PM, Matan Azrad wrote: Hi Jeff Please see comments... From: Jeff Guo Sent: Friday, June 22, 2018 2:51 PM To: step...@networkplumber.org; bruce.richard...@intel.com; ferruh.yi...@intel.com; konstantin.anan...@intel.com; gaetan.r

Re: [dpdk-dev] [PATCH 28/31] net/bnxt: fix set MTU

2018-06-26 Thread Ferruh Yigit
On 6/19/2018 10:30 PM, Ajit Khaparde wrote: > There is no need to update hardware configuration if new MTU is > not greater than the max data the mbuf can accommodate. If app sets a smaller MTU won't it expect that HW will drop received packets bigger than provided size? Will this logic work if HW

Re: [dpdk-dev] [PATCH 27/31] net/bnxt: check filter type before clearing it

2018-06-26 Thread Ferruh Yigit
On 6/19/2018 10:30 PM, Ajit Khaparde wrote: > In bnxt_free_filter_mem(), check the filter type and call the > appropriate HWRM command to clear the filter from HW. Just to double check, is this check to fix an issue? If so do you want to backport the fix into stable trees? > > Signed-off-by: Aji

Re: [dpdk-dev] [PATCH v2 1/4] bus/pci: handle device hot unplug

2018-06-26 Thread Guo, Jia
hi, gaetan, thanks for your review, see comment as bellow On 6/22/2018 8:59 PM, Gaëtan Rivet wrote: Hi Jeff, Sorry, I followed this development from afar, I have a remark regarding this API, I think it can be made simpler. Details below. On Fri, Jun 22, 2018 at 07:51:05PM +0800, Jeff Guo wro

Re: [dpdk-dev] [PATCH 24/31] net/bnxt: update HWRM API to v1.9.2.9

2018-06-26 Thread Ferruh Yigit
On 6/19/2018 10:30 PM, Ajit Khaparde wrote: > From: Rob Miller > > update HWRM API to v1.9.2.9 Does it make sense to update release notes to document this update? > > Signed-off-by: Rob Miller > Reviewed-by: Scott Branden > Reviewed-by: Ajit Kumar Khaparde > Reviewed-by: Randy Schacher > S

Re: [dpdk-dev] [PATCH 23/31] net/bnxt: check for invalid vnic id

2018-06-26 Thread Ferruh Yigit
On 6/19/2018 10:30 PM, Ajit Khaparde wrote: > From: Jay Ding > > Add checking for VNIC id before sending message to firmware in > bnxt_hwrm_vnic_plcmode_cfg(). Can you please add more information, when fw_vnic_id == INVALID_HW_RING_ID, what does it mean to have fw_vnic_id == INVALID_HW_RING_ID,

Re: [dpdk-dev] [PATCH 22/31] net/bnxt: filter/flow refactoring

2018-06-26 Thread Ferruh Yigit
On 6/19/2018 10:30 PM, Ajit Khaparde wrote: > In preparation of more rte_flow support it has been decided to > separate out filter and flow into their own files. Functionally the > same. > > Signed-off-by: Michael Wildt > Signed-off-by: Scott Branden > Signed-off-by: Ajit Khaparde Preferred pa

Re: [dpdk-dev] [PATCH 11/31] net/bnxt: code cleanup style of bnxt rxr

2018-06-26 Thread Ferruh Yigit
On 6/19/2018 10:30 PM, Ajit Khaparde wrote: > From: Scott Branden > > Cleanup alignment, brackets, debug string style of bnxt_rxr > > Signed-off-by: Scott Branden > Reviewed-by: Randy Schacher > Reviewed-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_rxr.c | 58 > --

Re: [dpdk-dev] [PATCH 08/31] net/bnxt: add support for VF id 0xd800

2018-06-26 Thread Ferruh Yigit
On 6/19/2018 10:30 PM, Ajit Khaparde wrote: > Add support for StingRay VF device 0xd800 Can you please document new supported device on doc/guides/nics/bnxt.rst > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_ethdev.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > >

Re: [dpdk-dev] [PATCH 05/31] net/bnxt: fix dev close operation

2018-06-26 Thread Ferruh Yigit
On 6/19/2018 10:30 PM, Ajit Khaparde wrote: > We are not cleaning up all the memory and also not unregistering > the driver during device close operation. This patch fixes the issue. > > Fixes: 893074951314 (net/bnxt: free memory in close operation) > Cc: sta...@dpdk.org > > Signed-off-by: Ajit K

Re: [dpdk-dev] [PATCH 00/31] bnxt patchset

2018-06-26 Thread Ferruh Yigit
On 6/19/2018 10:30 PM, Ajit Khaparde wrote: > Patchset against dpdk-next-net contains bug fixes, > some code refactoring and style cleanup. > > Please apply. > > Ajit Khaparde (15): > net/bnxt: fix clear port stats > net/bnxt: add Tx batching support > net/bnxt: Rx processing optimization >

Re: [dpdk-dev] [PATCH v4 2/2] app/testpmd: add NVGRE encap/decap support

2018-06-26 Thread Nélio Laranjeiro
Hi, On Tue, Jun 26, 2018 at 12:48:42PM +, Iremonger, Bernard wrote: > Hi Nelio, > > > -Original Message- > > From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com] > > Sent: Thursday, June 21, 2018 8:14 AM > > To: dev@dpdk.org; Adrien Mazarguil ; Lu, > > Wenzhuo ; Wu, Jingjing ; >

Re: [dpdk-dev] [PATCH v4 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap

2018-06-26 Thread Nélio Laranjeiro
On Fri, Jun 22, 2018 at 11:19:14AM +0100, Mohammad Abdul Awal wrote: > On 22/06/2018 10:08, Nélio Laranjeiro wrote: > > On Fri, Jun 22, 2018 at 09:51:15AM +0100, Mohammad Abdul Awal wrote: > > > > > > On 22/06/2018 09:31, Nélio Laranjeiro wrote: > > > > On Fri, Jun 22, 2018 at 08:42:10AM +0100, Mo

Re: [dpdk-dev] [PATCH v4 06/24] ethdev: enable hotplug on multi-process

2018-06-26 Thread Burakov, Anatoly
On 26-Jun-18 3:24 PM, Zhang, Qi Z wrote: -Original Message- From: Burakov, Anatoly Sent: Tuesday, June 26, 2018 9:46 PM To: Zhang, Qi Z ; tho...@monjalon.net Cc: Ananyev, Konstantin ; dev@dpdk.org; Richardson, Bruce ; Yigit, Ferruh ; Shelton, Benjamin H ; Vangati, Narender Subject: Re

Re: [dpdk-dev] [PATCH v1 1/3] hash: add read and write concurrency support

2018-06-26 Thread De Lara Guarch, Pablo
Hi Yipeng, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yipeng Wang > Sent: Friday, June 8, 2018 11:51 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Mcnamara, > John ; Richardson, Bruce > ; honnappa.nagaraha...@arm.com; > vgu...@caviumne

Re: [dpdk-dev] [PATCH v4 06/24] ethdev: enable hotplug on multi-process

2018-06-26 Thread Zhang, Qi Z
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, June 26, 2018 9:46 PM > To: Zhang, Qi Z ; tho...@monjalon.net > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati, Narender > > Subject: Re: [PATCH v4 06/24] ethde

Re: [dpdk-dev] [PATCH v4 06/24] ethdev: enable hotplug on multi-process

2018-06-26 Thread Burakov, Anatoly
On 26-Jun-18 2:25 PM, Zhang, Qi Z wrote: -Original Message- From: Burakov, Anatoly Sent: Tuesday, June 26, 2018 9:21 PM To: Zhang, Qi Z ; tho...@monjalon.net Cc: Ananyev, Konstantin ; dev@dpdk.org; Richardson, Bruce ; Yigit, Ferruh ; Shelton, Benjamin H ; Vangati, Narender Subject: Re

Re: [dpdk-dev] [PATCH v3] kni: fix build with gcc 8.1

2018-06-26 Thread De Lara Guarch, Pablo
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, June 26, 2018 12:38 PM > To: Yigit, Ferruh > Cc: dev@dpdk.org; step...@networkplumber.org; De Lara Guarch, Pablo > ; sta...@dpdk.org > Subject: [PATCH v3] kni: fix build with gcc 8.1 > > Error observed when CONFIG_RTE_KNI_KMOD_

Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour

2018-06-26 Thread Ferruh Yigit
On 6/26/2018 1:17 PM, Shahaf Shuler wrote: > HI Maxime, Jens > > Saturday, June 23, 2018 11:09 AM, Maxime Coquelin: >> Subject: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to >> simulate a noisy neighbour >> >> From: Jens Freimann >> >> This adds a new forwarding mode to testpmd to sim

Re: [dpdk-dev] [Bug 60] rte_event_port_unlink() causes subsequent events to end up in wrong port

2018-06-26 Thread Maxim Uvarov
Hello, is there any progress on this? Thank you, Maxim. On 19.06.2018 12:20, Elo, Matias (Nokia - FI/Espoo) wrote: I think this should handle the unlink case you mention, however perhaps you have identified a genuine bug. If you have more info or a sample config / app that easily demonstrat

Re: [dpdk-dev] [PATCH v2] cmdline: rework as a wrapper to libedit

2018-06-26 Thread Olivier Matz
> I noticed a bad behavior change (in addition to many good ones): > ctrl-c now quits the application, and this was not the case before. > I often use ctrl-c to delete the line I'm currently editing. Please > see at the end a proposition to restore this feature. And now, ladies and gentlemen, the

Re: [dpdk-dev] [PATCH v4 03/24] ethdev: add function to release port in local process

2018-06-26 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, June 26, 2018 9:29 PM > To: 'Matan Azrad' ; Thomas Monjalon > ; Burakov, Anatoly > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati, Narender > > Subject: RE: [dpdk-

[dpdk-dev] [PATCH] net/nfp: avoid access to sysfs resource0 file

2018-06-26 Thread Alejandro Lucero
NFP CPP interface dinamically configures NFP CPP BARs for accessing any NFP chip component from user space. This requires to map PCI BAR regions specifically. However, this does not require to do such map over the usual map done by VFIO or UIO drivers with the device PCI BARs. This patch avoids th

Re: [dpdk-dev] [PATCH v4 03/24] ethdev: add function to release port in local process

2018-06-26 Thread Zhang, Qi Z
Hi Matan: > -Original Message- > From: Matan Azrad [mailto:ma...@mellanox.com] > Sent: Tuesday, June 26, 2018 7:50 PM > To: Zhang, Qi Z ; Thomas Monjalon > ; Burakov, Anatoly > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati,

Re: [dpdk-dev] [PATCH v4 06/24] ethdev: enable hotplug on multi-process

2018-06-26 Thread Zhang, Qi Z
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, June 26, 2018 9:21 PM > To: Zhang, Qi Z ; tho...@monjalon.net > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati, Narender > > Subject: Re: [PATCH v4 06/24] ethde

[dpdk-dev] [PATCH] net/nfp: avoid sysfs resource file access

2018-06-26 Thread Alejandro Lucero
Getting the bar size is required for NFP CPP interface configuration. However, this information can be obtained from the VFIO or UIO driver instead of accessing the sysfs resource file. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 27 +-

Re: [dpdk-dev] [PATCH v2] cmdline: rework as a wrapper to libedit

2018-06-26 Thread Olivier Matz
Hi Adrien, Better late than never, please find below some comments about your patch. On Thu, Apr 19, 2018 at 05:13:53PM +0200, Adrien Mazarguil wrote: > Disclaimer: this patch must not be confused with the CLI library [1] > (work in progress) that will eventually supersede librte_cmdline itself >

Re: [dpdk-dev] [PATCH v4 06/24] ethdev: enable hotplug on multi-process

2018-06-26 Thread Burakov, Anatoly
On 26-Jun-18 1:58 PM, Zhang, Qi Z wrote: my understand is peer is identified by a string (or filename) what I mean is clone the content of the buffer that peer point to , So I don't need to worry if the original peer be used to point to some other data As far as the application is concerned,

Re: [dpdk-dev] [PATCH v4 2/2] examples/l3fwd-power: simple app update to support new API

2018-06-26 Thread Hunt, David
On 26/6/2018 12:40 PM, Radu Nicolau wrote: From: Liang Ma Add the support for new traffic pattern aware power control power management API. Example: ./l3fwd-power -l xxx -n 4 -w :xx:00.0 -w :xx:00.1 -- -p 0x3 -P --config="(0,0,xx),(1,0,xx)" --empty-poll Please Reference l3fwd-p

Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_power: traffic pattern aware power control

2018-06-26 Thread Hunt, David
On 26/6/2018 12:40 PM, Radu Nicolau wrote: From: Liang Ma 1. Abstract For packet processing workloads such as DPDK polling is continuous. This means CPU cores always show 100% busy independent of how much work those cores are doing. It is critical to accurately determine how busy a core is

Re: [dpdk-dev] [PATCH v4 06/24] ethdev: enable hotplug on multi-process

2018-06-26 Thread Zhang, Qi Z
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, June 26, 2018 8:50 PM > To: Zhang, Qi Z ; tho...@monjalon.net > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati, Narender > > Subject: Re: [PATCH v4 06/24] ethde

Re: [dpdk-dev] [PATCH v4 06/24] ethdev: enable hotplug on multi-process

2018-06-26 Thread Burakov, Anatoly
On 26-Jun-18 1:19 PM, Zhang, Qi Z wrote: -Original Message- From: Burakov, Anatoly Sent: Tuesday, June 26, 2018 8:09 PM To: Zhang, Qi Z ; tho...@monjalon.net Cc: Ananyev, Konstantin ; dev@dpdk.org; Richardson, Bruce ; Yigit, Ferruh ; Shelton, Benjamin H ; Vangati, Narender Subject: Re

  1   2   3   >