Re: [dpdk-dev] [PATCH] net/e1000: correct queue number in RSS configuration

Acked-by: Wei Zhao > -Original Message- > From: Xing, Beilei > Sent: Thursday, September 13, 2018 3:06 PM > To: Zhao1, Wei ; Lu, Wenzhuo > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/e1000: correct queue number in RSS configuration > > RSS configuration works for all e100

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function to dump packets

-Original Message- > Date: Thu, 13 Sep 2018 18:43:02 +0200 > From: David Marchand > To: Raslan Darawsheh > Cc: "Wu, Jingjing" , Thomas Monjalon > , dev@dpdk.org, Shahaf Shuler , > xuemi...@mellanox.com > Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function > to dum

[dpdk-dev] [PATCH v2] net/mlx5: fix representor port xstats

This patch fixes the issue that representor port shows xstats of PF. Fixes: 5a4b8e2612c5 ("net/mlx5: probe all port representors") Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_stats.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_

[dpdk-dev] [PATCH v2] net/mlx5: fix wrong representor port link status

Current code uses PF links status for representor port, not the representor interface itself. This caused wrong representor port link status when toggling linterface up or down. Fixes: 5a4b8e2612c5 ("net/mlx5: probe all port representors") Cc: adrien.mazarg...@6wind.com Signed-off-by: Xueming Li

Re: [dpdk-dev] [PATCH v5 09/11] net/virtio: disable ctrl virtqueue for packed rings

On Thu, Sep 06, 2018 at 07:19:45PM +0100, Jens Freimann wrote: > Signed-off-by: Jens Freiman > --- > drivers/net/virtio/virtio_ethdev.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/drivers/net/virtio/virtio_ethdev.c > b/drivers/net/virtio/virtio_ethdev.c > index a2bb726ba..

Re: [dpdk-dev] [PATCH 3/4] ethdev: add Rx offload outer L4 checksum definitions

-Original Message- > Date: Thu, 13 Sep 2018 17:24:26 + > From: Shahaf Shuler > To: Jerin Jacob , Wenzhuo Lu > , Jingjing Wu , Bernard > Iremonger , John McNamara > , Marko Kovacevic , > Thomas Monjalon , Ferruh Yigit > , Andrew Rybchenko , > Olivier Matz > CC: "dev@dpdk.org" >

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

-Original Message- > Date: Thu, 13 Sep 2018 23:45:31 + > From: Honnappa Nagarahalli > To: Jerin Jacob > CC: Ola Liljedahl , "Kokkilagadda, Kiran" > , "Gavin Hu (Arm Technology China)" > , Ferruh Yigit , "Jacob, Jerin" > , "dev@dpdk.org" , nd > , Steve Capper , "Phil Yang (Arm >

Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready

Looks good to me. Reviewed-by: Ye Xiaolong Thanks, Xiaolong On 09/14, Xiao Wang wrote: >If the device is not clearly reset by the previous driver and holds >some invalid ring addr, and the relay thread kicks it before HW is >properly re-configured, a bad DMA request may happen. > >Besides, the

[dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready

If the device is not clearly reset by the previous driver and holds some invalid ring addr, and the relay thread kicks it before HW is properly re-configured, a bad DMA request may happen. Besides, the notify_addr which is used by the relay thread is set in the vdpa_ifcvf_start function, if a kick

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

-Original Message- > Date: Thu, 13 Sep 2018 17:40:53 + > From: Honnappa Nagarahalli > To: Jerin Jacob , Ola Liljedahl > > CC: "Kokkilagadda, Kiran" , "Gavin Hu > (Arm Technology China)" , Ferruh Yigit > , "Jacob, Jerin" > , "dev@dpdk.org" , > nd , Steve Capper , "Phil Yang

[dpdk-dev] [PATCH] kni: return failure for all ioctls

Modify kni_net_ioctl() to return -EOPNOTSUPP for all ioctls instead of 0. This is necessary because the Wicked (and possibly other) network interface managers will perform the SIOCGIWNAME ioctl to check if the interface is a wireless interface. If the KNI module returns success, Wicked will incor

Re: [dpdk-dev] [PATCH 14/15] net/vmxnet3: rename version map after library file name

-Original Message- From: Luca Boccassi Date: Monday, September 10, 2018 at 1:05 PM To: "dev@dpdk.org" Cc: "keith.wi...@intel.com" , "roy.fan.zh...@intel.com" , "jingjing...@intel.com" , "wenzhuo...@intel.com" , "rasesh.m...@cavium.com" , "harish.pa...@cavium.com" , "shahed.sha...@cavi

Re: [dpdk-dev] vmxnet3 TX TCP/UDP checksum not getting computed with L2_len > 14

-Original Message- From: Padam Jeet Singh Date: Sunday, June 17, 2018 at 12:00 PM To: Stephen Hemminger Cc: "dev@dpdk.org" , Yong Wang Subject: Re: [dpdk-dev] vmxnet3 TX TCP/UDP checksum not getting computed with L2_len > 14 >> On 17-Jun-2018, at 10:16 PM, Stephen Hemminger w

Re: [dpdk-dev] [PATCH] vmxnet3: stats_reset implementation

-Original Message- From: yogev ch Date: Wednesday, August 22, 2018 at 12:38 AM To: Yong Wang Cc: "dev@dpdk.org" , "yo...@cgstowernetworks.com" Subject: [PATCH] vmxnet3: stats_reset implementation Signed-off-by: yogev ch --- Yogev, The change looks fine to me. Can you add a

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

-Original Message- > Date: Thu, 13 Sep 2018 17:40:53 + > From: Honnappa Nagarahalli > To: Jerin Jacob , Ola Liljedahl > > CC: "Kokkilagadda, Kiran" , "Gavin Hu (Arm > Technology China)" , Ferruh Yigit > , "Jacob, Jerin" > , "dev@dpdk.org" , nd > , Steve Capper , "Phil Yang (Arm

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

Hi Jerin, Is there any reason for having 'RTE_RING_USE_C11_MEM_MODEL', which is specific to rte_ring? I do not see a need for choosing only some algorithms to work with C11 model. I suggest that we change this to 'RTE_USE_C11_MEM_MODEL' so that it can apply to all libraries/algorithms.

Re: [dpdk-dev] [PATCH 3/4] ethdev: add Rx offload outer L4 checksum definitions

Thursday, September 13, 2018 4:47 PM, Jerin Jacob: > Subject: [dpdk-dev] [PATCH 3/4] ethdev: add Rx offload outer L4 checksum > definitions > > Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM, > DEV_RX_OFFLOAD_OUTER_TCP_CKSUM and > DEV_RX_OFFLOAD_OUTER_SCTP_CKSUM offload flags and Out of curiosity, whi

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function to dump packets

On Wed, Sep 12, 2018 at 10:06 AM, Raslan Darawsheh wrote: > use the generic function to dump packets for several forwarding > engines. Rather than patching some engines, how about putting this in rx/tx callbacks ? A bit like something I sent earlier ? http://patches.dpdk.org/patch/44465/ -- D

Re: [dpdk-dev] [PATCH] net/avf: remove unused variables and label

On Thu, 2018-09-13 at 15:44 +0100, Bruce Richardson wrote: > Compiling with all warnings turned on causes errors about unused > variables > and an unused label. Remove these to allow building without having to > disable those warnings. > > Signed-off-by: Bruce Richardson > --- >  drivers/net/avf/

Re: [dpdk-dev] [PATCH v3 4/9] build: add Meson files for avf PMD

On Thu, 2018-09-13 at 15:49 +0100, Bruce Richardson wrote: > On Thu, Sep 13, 2018 at 02:41:35PM +0100, Luca Boccassi wrote: > > Signed-off-by: Luca Boccassi > > --- > >  drivers/net/avf/base/meson.build | 20 > >  drivers/net/avf/meson.build  | 15 +++ > >  drive

[dpdk-dev] [PATCH v4 9/9] build: add Meson file for vmxnet3_uio PMD

Signed-off-by: Luca Boccassi --- drivers/net/meson.build | 4 +++- drivers/net/vmxnet3/meson.build | 18 ++ 2 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 drivers/net/vmxnet3/meson.build diff --git a/drivers/net/meson.build b/drivers/net/meson.build

[dpdk-dev] [PATCH v4 8/9] build: add Meson file for opdl_event PMD

Signed-off-by: Luca Boccassi --- drivers/event/meson.build | 2 +- drivers/event/opdl/meson.build | 11 +++ 2 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 drivers/event/opdl/meson.build diff --git a/drivers/event/meson.build b/drivers/event/meson.build index e

[dpdk-dev] [PATCH v4 7/9] event/opdl: rename map file to match library name

So that it can be used from Meson as well Signed-off-by: Luca Boccassi --- drivers/event/opdl/Makefile | 2 +- ...md_evdev_opdl_version.map => rte_pmd_opdl_event_version.map} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename drivers/event/opdl/{rte_p

[dpdk-dev] [PATCH v4 5/9] build: add Meson files for qede PMD

Signed-off-by: Luca Boccassi Acked-by: Shahed Shaikh --- config/rte_config.h | 3 ++ drivers/net/meson.build | 2 +- drivers/net/qede/base/meson.build | 57 +++ drivers/net/qede/meson.build | 12 +++ 4 files changed, 73 insertions(+)

[dpdk-dev] [PATCH v4 6/9] build: add Meson file for bbdev_null PMD

Signed-off-by: Luca Boccassi --- drivers/baseband/meson.build | 7 +++ drivers/baseband/null/meson.build | 7 +++ drivers/meson.build | 1 + 3 files changed, 15 insertions(+) create mode 100644 drivers/baseband/meson.build create mode 100644 drivers/baseband/null/meso

[dpdk-dev] [PATCH v4 4/9] build: add Meson files for avf PMD

Signed-off-by: Luca Boccassi --- drivers/net/avf/base/meson.build | 20 drivers/net/avf/meson.build | 19 +++ drivers/net/meson.build | 1 + 3 files changed, 40 insertions(+) create mode 100644 drivers/net/avf/base/meson.build create mode 1006

[dpdk-dev] [PATCH v4 2/9] build: add Meson file for vdev_netvsc PMD

Signed-off-by: Luca Boccassi --- drivers/net/meson.build | 1 + drivers/net/vdev_netvsc/meson.build | 19 +++ 2 files changed, 20 insertions(+) create mode 100644 drivers/net/vdev_netvsc/meson.build diff --git a/drivers/net/meson.build b/drivers/net/meson.build inde

[dpdk-dev] [PATCH v4 1/9] build: add Meson file for TAP PMD

Use same autoconf generation mechanism as the MLX4/5 PMDs Signed-off-by: Luca Boccassi --- drivers/net/meson.build | 1 + drivers/net/tap/meson.build | 41 + 2 files changed, 42 insertions(+) create mode 100644 drivers/net/tap/meson.build diff --git a/d

[dpdk-dev] [PATCH v4 3/9] build: add Meson file for crypto scheduler PMD

Signed-off-by: Luca Boccassi --- drivers/crypto/meson.build | 2 +- drivers/crypto/scheduler/meson.build | 19 +++ 2 files changed, 20 insertions(+), 1 deletion(-) create mode 100644 drivers/crypto/scheduler/meson.build diff --git a/drivers/crypto/meson.build b/driver

Re: [dpdk-dev] [PATCH v3 5/9] memalloc: track page fd's in non-single file mode

On 09/04/2018 05:15 PM, Anatoly Burakov wrote: Previously, we were only tracking lock file fd's in single-file segments mode, but did not track fd's in non-single file mode because we didn't need to (mmap() call still kept the lock). Now that we are going to expose these fd's to the world, we

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

Hi Chas From: Chas Williams > On Wed, Sep 12, 2018 at 1:56 AM Matan Azrad > wrote: > > > > Hi Chas > > > > From: Chas Williams > > > On Mon, Aug 6, 2018 at 3:35 PM Matan Azrad > > > wrote: > > > > > > > > > > > > Hi Chas > > > > > > > > From: Chas Williams > > > > >On Mon, Aug 6, 2018 at 1:46

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: don't ignore RSS key on device configuration

On 9/4/2018 2:27 PM, Chas Williams wrote: > On Wed, Aug 29, 2018 at 3:51 AM Andrew Rybchenko > wrote: > >> From: Igor Romanov >> >> Bonding driver ignores the value of RSS key (that is set in the port RSS >> configuration) in bond_ethdev_configure(). So the only way to set >> non-default RSS key

Re: [dpdk-dev] [PATCH v3 4/9] memalloc: rename lock list to fd list

On 09/04/2018 05:15 PM, Anatoly Burakov wrote: Previously, we were only using lock lists to store per-page lock fd's because we cannot use modern fcntl() file description locks to lock parts of the page in single file segments mode. Now, we will be using this list to store either lock fd's (a

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

On Wed, Sep 12, 2018 at 1:56 AM Matan Azrad wrote: > > Hi Chas > > From: Chas Williams > > On Mon, Aug 6, 2018 at 3:35 PM Matan Azrad > > wrote: > > > > > > > > > Hi Chas > > > > > > From: Chas Williams > > > >On Mon, Aug 6, 2018 at 1:46 PM Matan Azrad > > wrote: > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: use evenly distributed default RSS RETA

On 9/4/2018 2:29 PM, Chas Williams wrote: > On Wed, Aug 29, 2018 at 3:48 AM Andrew Rybchenko > wrote: > >> From: Igor Romanov >> >> Default Redirection Table that is set in bonding driver is distributed >> evenly over all Rx queues only within every RETA group (the first RETA >> entries in every

Re: [dpdk-dev] [PATCH v3 4/9] build: add Meson files for avf PMD

On Thu, Sep 13, 2018 at 02:41:35PM +0100, Luca Boccassi wrote: > Signed-off-by: Luca Boccassi > --- > drivers/net/avf/base/meson.build | 20 > drivers/net/avf/meson.build | 15 +++ > drivers/net/meson.build | 1 + > 3 files changed, 36 insertions(+)

Re: [dpdk-dev] [PATCH v2 4/9] build: add Meson files for avf PMD

On Thu, Sep 13, 2018 at 02:27:54PM +0100, Luca Boccassi wrote: > On Thu, 2018-09-13 at 14:24 +0100, Bruce Richardson wrote: > > On Tue, Sep 11, 2018 at 05:08:58PM +0100, Luca Boccassi wrote: > > > Signed-off-by: Luca Boccassi > > > --- > > >  drivers/net/avf/base/meson.build | 20 +

Re: [dpdk-dev] [PATCH 1/3] event: add function for reading unlink in progress

-Original Message- > Date: Wed, 12 Sep 2018 17:16:14 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, matias@nokia.com, Harry van Haaren > > Subject: [PATCH 1/3] event: add function for reading unlink in progress > X-Mailer: git-send-email 2.17.

[dpdk-dev] [PATCH] net/avf: remove unused variables and label

Compiling with all warnings turned on causes errors about unused variables and an unused label. Remove these to allow building without having to disable those warnings. Signed-off-by: Bruce Richardson --- drivers/net/avf/avf_ethdev.c | 15 +-- drivers/net/avf/avf_rxtx.c | 17 +-

Re: [dpdk-dev] [PATCH 1/2] net/sfc: support runtime Rx queue setup

On 8/29/2018 8:35 AM, Andrew Rybchenko wrote: > From: Igor Romanov > > Signed-off-by: Igor Romanov > Signed-off-by: Andrew Rybchenko Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v7 1/4] lib/librte_power: traffic pattern aware power control

On 13/9/2018 2:37 PM, Liang, Ma wrote: Hi Kevin, Many thanks for your comments. I will send v8 patch soon. Please check comments below. On 13 Sep 11:54, Kevin Traynor wrote: On 09/04/2018 03:10 PM, Liang Ma wrote: --snip-- HIGH: the frequency is used to process busy traffic w

Re: [dpdk-dev] [PATCH 0/4] net/cxgbe: add destination MAC match and VLAN rewrite support for flow API

On 8/27/2018 1:52 PM, Rahul Lakkireddy wrote: > This series of patches add support to offload flows with destination MAC > match item and VLAN push/pop/rewrite actions. > > Patch 1 adds API to program and manage hardware Layer 2 Table (L2T). > L2T holds destination node information to be used for

Re: [dpdk-dev] [PATCH] net/ifc: add live migration support

Reviewed-and-Tested-by: Ye Xiaolong Thanks, Xiaolong On 09/10, Xiao Wang wrote: >IFCVF can help to log dirty page in live migration stage, >each queue's index can be read and configured to support >VHOST_USER_GET_VRING_BASE and VHOST_USER_SET_VRING_BASE. > >Signed-off-by: Xiao Wang >--- > drive

[dpdk-dev] [PATCH 4/4] ethdev: add Tx offload outer L4 checksum definitions

Introduced DEV_TX_OFFLOAD_OUTER_UDP_CKSUM, DEV_TX_OFFLOAD_OUTER_TCP_CKSUM and DEV_TX_OFFLOAD_OUTER_SCTP_CKSUM offload flags and PKT_TX_OUTER_L4_NO_CKSUM, PKT_TX_OUTER_TCP_CKSUM, PKT_TX_OUTER_SCTP_CKSUM and PKT_TX_OUTER_UDP_CKSUM mbuf ol_flags to enable Tx outer L4 checksum offload. To use hardwar

[dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask

Fixes missing PKT_TX_UDP_SEG value in PKT_TX_OFFLOAD_MASK. Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") Cc: sta...@dpdk.org Cc: jiayu...@intel.com Signed-off-by: Jerin Jacob --- lib/librte_mbuf/rte_mbuf.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/

[dpdk-dev] [PATCH 3/4] ethdev: add Rx offload outer L4 checksum definitions

Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM, DEV_RX_OFFLOAD_OUTER_TCP_CKSUM and DEV_RX_OFFLOAD_OUTER_SCTP_CKSUM offload flags and PKT_RX_EL4_CKSUM_BAD mbuf ol_flags to enable outer Rx L4 checksum offload. # To use hardware Rx outer L4 checksum offload, the user needs to configure DEV_RX_OFFLOAD_OUT

[dpdk-dev] [PATCH v3 9/9] build: add Meson file for vmxnet3_uio PMD

Signed-off-by: Luca Boccassi --- drivers/net/meson.build | 4 +++- drivers/net/vmxnet3/meson.build | 18 ++ 2 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 drivers/net/vmxnet3/meson.build diff --git a/drivers/net/meson.build b/drivers/net/meson.build

[dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload support

Signed-off-by: Jerin Jacob --- app/test-pmd/config.c | 9 + doc/guides/nics/features.rst | 4 ++-- lib/librte_ethdev/rte_ethdev.c | 1 + lib/librte_ethdev/rte_ethdev.h | 1 + 4 files changed, 13 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/co

Re: [dpdk-dev] [PATCH] doc/fix: add CCM to the QAT feature list

> Signed-off-by: Tomasz Cel > --- > doc/guides/cryptodevs/features/qat.ini | 3 +++ > doc/guides/cryptodevs/qat.rst | 1 + > 2 files changed, 4 insertions(+) Hi Tomasz, I think the patch is ok there is just a few things as this is a fix you need to add a fixes tag into the commit me

[dpdk-dev] [PATCH v3 8/9] build: add Meson file for opdl_event PMD

Signed-off-by: Luca Boccassi --- drivers/event/meson.build | 2 +- drivers/event/opdl/meson.build | 11 +++ 2 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 drivers/event/opdl/meson.build diff --git a/drivers/event/meson.build b/drivers/event/meson.build index e

[dpdk-dev] [PATCH v3 7/9] event/opdl: rename map file to match library name

So that it can be used from Meson as well Signed-off-by: Luca Boccassi --- drivers/event/opdl/Makefile | 2 +- ...md_evdev_opdl_version.map => rte_pmd_opdl_event_version.map} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename drivers/event/opdl/{rte_p

[dpdk-dev] [PATCH v3 5/9] build: add Meson files for qede PMD

Signed-off-by: Luca Boccassi Acked-by: Shahed Shaikh --- config/rte_config.h | 3 ++ drivers/net/meson.build | 2 +- drivers/net/qede/base/meson.build | 57 +++ drivers/net/qede/meson.build | 12 +++ 4 files changed, 73 insertions(+)

[dpdk-dev] [PATCH v3 6/9] build: add Meson file for bbdev_null PMD

Signed-off-by: Luca Boccassi --- drivers/baseband/meson.build | 7 +++ drivers/baseband/null/meson.build | 7 +++ drivers/meson.build | 1 + 3 files changed, 15 insertions(+) create mode 100644 drivers/baseband/meson.build create mode 100644 drivers/baseband/null/meso

[dpdk-dev] [PATCH v3 4/9] build: add Meson files for avf PMD

Signed-off-by: Luca Boccassi --- drivers/net/avf/base/meson.build | 20 drivers/net/avf/meson.build | 15 +++ drivers/net/meson.build | 1 + 3 files changed, 36 insertions(+) create mode 100644 drivers/net/avf/base/meson.build create mode 100644 d

[dpdk-dev] [PATCH v3 3/9] build: add Meson file for crypto scheduler PMD

Signed-off-by: Luca Boccassi --- drivers/crypto/meson.build | 2 +- drivers/crypto/scheduler/meson.build | 19 +++ 2 files changed, 20 insertions(+), 1 deletion(-) create mode 100644 drivers/crypto/scheduler/meson.build diff --git a/drivers/crypto/meson.build b/driver

[dpdk-dev] [PATCH v3 2/9] build: add Meson file for vdev_netvsc PMD

Signed-off-by: Luca Boccassi --- drivers/net/meson.build | 1 + drivers/net/vdev_netvsc/meson.build | 19 +++ 2 files changed, 20 insertions(+) create mode 100644 drivers/net/vdev_netvsc/meson.build diff --git a/drivers/net/meson.build b/drivers/net/meson.build inde

[dpdk-dev] [PATCH v3 1/9] build: add Meson file for TAP PMD

Use same autoconf generation mechanism as the MLX4/5 PMDs Signed-off-by: Luca Boccassi --- drivers/net/meson.build | 1 + drivers/net/tap/meson.build | 41 + 2 files changed, 42 insertions(+) create mode 100644 drivers/net/tap/meson.build diff --git a/d

Re: [dpdk-dev] [PATCH] net/ifc: do not notify before HW ready

On 09/13, Wang, Xiao W wrote: >Hi Xiaolong, > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Thursday, September 13, 2018 8:55 PM >> To: Wang, Xiao W >> Cc: Bie, Tiwei ; dev@dpdk.org >> Subject: Re: [PATCH] net/ifc: do not notify before HW ready >> >> Hi, Xiao >> >> On 09/10, Xiao

Re: [dpdk-dev] [PATCH v7 1/4] lib/librte_power: traffic pattern aware power control

Hi Kevin, Many thanks for your comments. I will send v8 patch soon. Please check comments below. On 13 Sep 11:54, Kevin Traynor wrote: > On 09/04/2018 03:10 PM, Liang Ma wrote: > > 1. Abstract > > > > Hi Liang, > > I didn't review the code, but some comments on API below, > > > For

Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_power: traffic pattern aware power control

Hi Kevin, Many thanks for your feedback. Please check my comments below. On 13 Sep 10:46, Kevin Traynor wrote: > > Thanks for following up. It's allowing it to run without a training > phase which is what I thought could be problematic from an application > view, so that's nice. I'm no

Re: [dpdk-dev] [PATCH v2 1/9] build: add Meson file for TAP PMD

On Thu, 2018-09-13 at 14:11 +0100, Bruce Richardson wrote: > On Tue, Sep 11, 2018 at 05:08:55PM +0100, Luca Boccassi wrote: > > Use same autoconf generation mechanism as the MLX4/5 PMDs > > > > Signed-off-by: Luca Boccassi > > --- > >  drivers/net/meson.build |  1 + > >  drivers/net/tap/meson

Re: [dpdk-dev] [PATCH v2 4/9] build: add Meson files for avf PMD

On Thu, 2018-09-13 at 14:24 +0100, Bruce Richardson wrote: > On Tue, Sep 11, 2018 at 05:08:58PM +0100, Luca Boccassi wrote: > > Signed-off-by: Luca Boccassi > > --- > >  drivers/net/avf/base/meson.build | 20 > >  drivers/net/avf/meson.build  | 15 +++ > >  drive

Re: [dpdk-dev] [PATCH v7] linuxapp, eal: Fix the memory leak issue of logid

On second thought - please just fold in the patch I proposed back in July that I was told would be merged: http://mails.dpdk.org/archives/dev/2018-July/108445.html http://mails.dpdk.org/archives/dev/2018-August/109177.html It doesn't include the issues calling rte_atomic32_clear (that I have

Re: [dpdk-dev] [PATCH v5] net/i40e: add interface to choose latest vector path

On 9/12/2018 11:12 AM, Xiaoyun Li wrote: > Right now, vector path is limited to only use on later platform. i40e supports vector instructions for intel, arm and powerpc, this behavior is only for Intel vector drivers, can be good to clarify, also it can better to explain a little more what "limite

Re: [dpdk-dev] [PATCH v2 4/9] build: add Meson files for avf PMD

On Tue, Sep 11, 2018 at 05:08:58PM +0100, Luca Boccassi wrote: > Signed-off-by: Luca Boccassi > --- > drivers/net/avf/base/meson.build | 20 > drivers/net/avf/meson.build | 15 +++ > drivers/net/meson.build | 1 + > 3 files changed, 36 insertions(+)

Re: [dpdk-dev] [PATCH v2 1/9] build: add Meson file for TAP PMD

On Tue, Sep 11, 2018 at 05:08:55PM +0100, Luca Boccassi wrote: > Use same autoconf generation mechanism as the MLX4/5 PMDs > > Signed-off-by: Luca Boccassi > --- > drivers/net/meson.build | 1 + > drivers/net/tap/meson.build | 41 + > 2 files changed, 42

Re: [dpdk-dev] [PATCH v3 3/9] mem: raise maximum fd limit unconditionally

On 09/04/2018 05:15 PM, Anatoly Burakov wrote: Previously, when we allocated hugepages, we closed the fd's corresponding to them after we've done our mappings. Since we did mmap(), we didn't actually lose the reference, but file descriptors used for mmap() do not count against the fd limit. Si

Re: [dpdk-dev] [PATCH v3 2/9] eal: don't allow legacy mode with in-memory mode

On 09/04/2018 05:15 PM, Anatoly Burakov wrote: In-memory mode was never meant to support legacy mode, because we cannot sort anonymous pages anyway. Fixes: 72b49ff623c4 ("mem: support --in-memory mode") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_commo

Re: [dpdk-dev] [PATCH v3 1/9] fbarray: fix detach in noshconf mode

On 09/04/2018 05:15 PM, Anatoly Burakov wrote: In noshconf mode, no shared files are created, but we're still trying to unlink them, resulting in detach/destroy failure even though it should have succeeded. Fix it by exiting early in noshconf mode. Fixes: 3ee2cde248a7 ("fbarray: support --no-

Re: [dpdk-dev] [PATCH] net/i40e: remove invalid comment

> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, September 13, 2018 7:21 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [PATCH] net/i40e: remove invalid comment > > Comments says "no csum error report support" but there is no check related

Re: [dpdk-dev] [PATCH v6 1/2] net/mlx5: support meson build

On Thu, Sep 13, 2018 at 03:11:05PM +0300, Shahaf Shuler wrote: > From: Nelio Laranjeiro > > Compile Mellanox driver when its external dependencies are met. A > glue version of the driver can still be requested by using the > -Denable_driver_mlx_glue=true > > To avoid modifying the whole sources

Re: [dpdk-dev] [PATCH v2] net/i40e: stop lldp before setting local lldp MIB

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chas Williams > Sent: Tuesday, August 7, 2018 4:06 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Charles (Chas) Williams > Subject: [dpdk-dev] [PATCH v2] net/i40e: stop lldp before setting local lldp

[dpdk-dev] [PATCH v2 00/21] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver

Hello DPDK community! Aquantia would like to contribute PMD for aQtion AQC10X NIC family: https://www.aquantia.com/products/aqtion/chips/ These are 10G ethernet NICs with various features. We do base this work on parts of the existing native linux kernel driver source (atlantic). Shared code is h

[dpdk-dev] [PATCH v6 2/2] net/mlx4: support meson build

From: Nelio Laranjeiro Compile Mellanox driver when their external dependencies are met. A glue version of the driver can still be requested by using the -Denable_driver_mlx_glue=true To avoid modifying the whole sources and keep the compatibility with current build systems (e.g. make), the mlx

[dpdk-dev] [PATCH v6 1/2] net/mlx5: support meson build

From: Nelio Laranjeiro Compile Mellanox driver when its external dependencies are met. A glue version of the driver can still be requested by using the -Denable_driver_mlx_glue=true To avoid modifying the whole sources and keep the compatibility with current build systems (e.g. make), the mlx5_

[dpdk-dev] [PATCH v2 18/21] net/atlantic: VLAN filters and offloads

From: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 159 +- 1 file changed, 157 insertions(+), 2 deletions(-) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c index 37f32c421..7ff1126d7 1

[dpdk-dev] [PATCH v2 21/21] net/atlantic: TX side structures and implementation

From: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 10 + drivers/net/atlantic/atl_rxtx.c | 578 ++ 2 files changed, 588 insertions(+) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c

[dpdk-dev] [PATCH v2 19/21] net/atlantic: device MTU and statuses

From: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 162 ++ 1 file changed, 162 insertions(+) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c index 7ff1126d7..01700b4ad 100644 --- a/driv

[dpdk-dev] [PATCH v2 05/21] net/atlantic: b0 hardware layer main logic

This is hw_atl logic layer derived from linux atlantic driver. It contains RX/TX hardware initialization sequences, various hw configuration. Signed-off-by: Igor Russkikh --- drivers/net/atlantic/hw_atl/hw_atl_b0.c | 537 +++ drivers/net/atlantic/hw_atl/hw_atl_b0.h

[dpdk-dev] [PATCH v2 20/21] net/atlantic: RX side structures and implementation

Signed-off-by: Igor Russkikh --- drivers/net/atlantic/Makefile | 6 + drivers/net/atlantic/atl_ethdev.c | 44 +++ drivers/net/atlantic/atl_ethdev.h | 82 drivers/net/atlantic/atl_rxtx.c | 787 ++ drivers/net/atlantic/meson.build | 6 + 5 files

[dpdk-dev] [PATCH v2 17/21] net/atlantic: device statistics, xstats

Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 136 ++ 1 file changed, 136 insertions(+) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c index 44bdbcbb3..37f32c421 100644 --- a/drivers/net/atlantic/atl_

[dpdk-dev] [PATCH v2 16/21] net/atlantic: promisc and allmulti configuration

From: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 46 +++ 1 file changed, 46 insertions(+) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c index 08f1a07c8..44bdbcbb3 100644 --- a/drive

[dpdk-dev] [PATCH v2 15/21] net/atlantic: LED control DPDK and private APIs

Signed-off-by: Igor Russkikh --- drivers/net/atlantic/Makefile | 4 +++ drivers/net/atlantic/atl_ethdev.c | 55 + drivers/net/atlantic/atl_ethdev.h | 2 ++ drivers/net/atlantic/meson.build| 3 ++ drivers/net/atlantic/rte_pmd_atlanti

[dpdk-dev] [PATCH v2 13/21] net/atlantic: MAC address manipulations

From: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 108 ++ 1 file changed, 108 insertions(+) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c index 72acb053d..940fd83d9 100644 --- a/driv

[dpdk-dev] [PATCH v2 14/21] net/atlantic: eeprom and register manipulation routines

From: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 79 +++ 1 file changed, 79 insertions(+) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c index 940fd83d9..c16d179fd 100644 --- a/drive

[dpdk-dev] [PATCH v2 10/21] net/atlantic: add hw adapter structures and defines

From: Pavel Belous These declare statistic structures, hw internal structures and variables. Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.h | 9 ++ drivers/net/atlantic/atl_types.h | 200 ++ 2 files changed, 209 insertions(+) diff --g

[dpdk-dev] [PATCH v2 11/21] net/atlantic: RSS and RETA manipulation API

Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 99 + drivers/net/atlantic/hw_atl/hw_atl_b0.c | 29 +- 2 files changed, 100 insertions(+), 28 deletions(-) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl

[dpdk-dev] [PATCH v2 12/21] net/atlantic: flow control configuration

From: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 50 +++ 1 file changed, 50 insertions(+) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c index b58f684f6..72acb053d 100644 --- a/drive

[dpdk-dev] [PATCH v2 09/21] net/atlantic: link status and interrupt management

From: Pavel Belous Implement link interrupt, link info, link polling Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 258 ++ drivers/net/atlantic/atl_ethdev.h | 10 ++ 2 files changed, 268 insertions(+) diff --git a/drivers/net/atlanti

[dpdk-dev] [PATCH v2 08/21] net/atlantic: rte device start, stop, initial configuration

Start, stop and reset are all done via hw_atl layer. Link interrupt configuration is also done here. Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 256 ++ drivers/net/atlantic/atl_ethdev.h | 2 + 2 files changed, 258 insertions(+) dif

[dpdk-dev] [PATCH v2 07/21] net/atlantic: hardware register access routines

Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_hw_regs.c | 52 + drivers/net/atlantic/atl_hw_regs.h | 53 ++ 2 files changed, 105 insertions(+) create mode 100644 drivers/net/atlantic/atl_hw_regs.c create mode 10

[dpdk-dev] [PATCH v2 06/21] net/atlantic: firmware operations layer

AQC NICs comes in fields with two major FW generations: 1x and 3x. This is part of linux atlantic driver shared code, responsible for internal NIC firmware interactions, including link management ops, FW initialization, various lifecycle features. Signed-off-by: Igor Russkikh --- drivers/net/at

[dpdk-dev] [PATCH v2 03/21] net/atlantic: logging macroes and some typedefs

Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 18 +-- drivers/net/atlantic/atl_logs.h | 68 +++ drivers/net/atlantic/atl_types.h | 35 3 files changed, 118 insertions(+), 3 deletions(-) create mode 100644

[dpdk-dev] [PATCH v2 02/21] net/atlantic: documentation and rel notes

Signed-off-by: Igor Russkikh --- doc/guides/nics/atlantic.rst | 59 ++ doc/guides/nics/features/atlantic.ini | 37 + doc/guides/nics/index.rst | 1 + doc/guides/rel_notes/release_18_11.rst | 5 +++ 4 files changed, 102

[dpdk-dev] [PATCH v2 01/21] net/atlantic: atlantic PMD driver skeleton

From: Pavel Belous Makefile/meson build infrastructure, atl_ethdev minimal skeleton, header with aquantia aQtion NIC device and vendor IDs. Signed-off-by: Igor Russkikh --- config/common_base| 9 + drivers/net/Makefile | 2 + dri

[dpdk-dev] [PATCH v2 2/2] examples/vdpa: introduce a new sample for vDPA

The vdpa sample application creates vhost-user sockets by using the vDPA backend. vDPA stands for vhost Data Path Acceleration which utilizes virtio ring compatible devices to serve virtio driver directly to enable datapath acceleration. As vDPA driver can help to set up vhost datapath, this applic

[dpdk-dev] [PATCH v2 1/2] vhost: introduce API to get vDPA device number

Signed-off-by: Xiaolong Ye --- lib/librte_vhost/rte_vdpa.h | 3 +++ lib/librte_vhost/vdpa.c | 6 ++ 2 files changed, 9 insertions(+) diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h index 90465ca26..b8223e337 100644 --- a/lib/librte_vhost/rte_vdpa.h +++ b/lib/librte

Re: [dpdk-dev] [PATCH v5] net/mlx: add meson build support

On Thu, Sep 13, 2018 at 10:12:18AM +, Shahaf Shuler wrote: > Hi Bruce, > > Sorry for the late reply. Holiday time in Israel. > No problem! Hope you had a good break. :-) > Thursday, September 13, 2018 12:22 PM, Bruce Richardson: > > Subject: Re: [dpdk-dev] [PATCH v5] net/mlx: add meson buil

Re: [dpdk-dev] [PATCH v7 1/4] lib/librte_power: traffic pattern aware power control

On 09/04/2018 03:10 PM, Liang Ma wrote: > 1. Abstract > Hi Liang, I didn't review the code, but some comments on API below, > For packet processing workloads such as DPDK polling is continuous. > This means CPU cores always show 100% busy independent of how much work > those cores are doing. It

[dpdk-dev] [PATCH] net/mlx5: support e-switch TCP-flags flow filter

This patch adds support for offloading flow rules with tcp-flags filter to mlx5 eswitch hardwrae. Today, it is possible to offload an interface flow rules to the hardware using DPDK flow commands. With mlx5 it is also possible to offload a limited set of flow rules to the mlxsw (or e-switch) using

  1   2   >