[dpdk-dev] [PATCH v2 1/2] event/dpaa: remove duplicate log macros

2018-09-25 Thread Hemant Agrawal
align and cleanup the debug log prints Signed-off-by: Hemant Agrawal --- Note: This patch has a dependency on following patch series: http://mails.dpdk.org/archives/dev/2018-September/112433.html which is now part of dpdk-next-net tree. drivers/event/dpaa/dpaa_eventdev.c | 58 ++

[dpdk-dev] [PATCH v2 2/2] event/dpaa: add select based event support

2018-09-25 Thread Hemant Agrawal
This patch add support to use select call with qman portal fd for timeout based dequeue request for eventdev. If there is a event available qman portal fd will be set and the function will be awakened. If no event is available, it will only wait till the given timeout value. In case of interrupt

[dpdk-dev] [PATCH v3 00/13] net/mvpp2: add new features

2018-09-25 Thread Andrzej Ostruszka
This patch series introduces fixes and adds support for traffic metering, traffic manager and Tx S/G. Additionally it aligns with for MUSDK 18.09. Changes in v3: * change the format of image referred in doc (png -> svg) * "cherry-pick" http://patches.dpdk.org/patch/44255/ to be part of this patc

[dpdk-dev] [PATCH v3 03/13] net/mvpp2: add metering support

2018-09-25 Thread Andrzej Ostruszka
From: Tomasz Duszynski Add support for configuring plcr via DPDK generic metering API. Signed-off-by: Tomasz Duszynski Signed-off-by: Natalie Samsonov Reviewed-by: Liron Himi --- drivers/net/mvpp2/Makefile | 1 + drivers/net/mvpp2/meson.build | 3 +- drivers/net/mvpp2/mrvl_ethdev.

[dpdk-dev] [PATCH v3 02/13] net/mvpp2: move common code

2018-09-25 Thread Andrzej Ostruszka
From: Tomasz Duszynski Cleanup sources by moving common code to the pmd header file. Signed-off-by: Tomasz Duszynski Signed-off-by: Natalie Samsonov Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 9 - drivers/net/mvpp2/mrvl_ethdev.h | 11 +++ drivers/net/mvpp2

[dpdk-dev] [PATCH v3 01/13] net/mvpp2: initialize ppio only once

2018-09-25 Thread Andrzej Ostruszka
From: Natalie Samsonov This changes stop/start/configure behavior due to issue in MUSDK library itself. From now on, ppio can be reconfigured only after interface is closed. Signed-off-by: Natalie Samsonov Reviewed-by: Yuval Caduri --- drivers/net/mvpp2/mrvl_ethdev.c | 53 +++

[dpdk-dev] [PATCH v3 04/13] net/mvpp2: change default policer configuration

2018-09-25 Thread Andrzej Ostruszka
From: Tomasz Duszynski Change QoS configuration file syntax for port's default policer setup. Since default policer configuration is performed before any other policer configuration we can pick a default id. This simplifies default policer configuration since user no longer has to choose ids fr

[dpdk-dev] [PATCH v3 07/13] net/mvpp2: detach Tx QoS from Rx cls/QoS config

2018-09-25 Thread Andrzej Ostruszka
From: Yuval Caduri Functional change: Open receive cls/qos related features, only if the config file contains an rx_related configuration entry. This allows to configure tx_related entries, w/o unintentionally opening rx cls/qos. Code: 'use_global_defaults' is by default set to '1'. Only if an r

[dpdk-dev] [PATCH v3 09/13] net/mvpp2: align with MUSDK 18.09

2018-09-25 Thread Andrzej Ostruszka
From: Tomasz Duszynski This patch introduces necessary changes required by MUSDK 18.09 library. * As of MUSDK 18.09, pp2_cookie_t is no longer available. Now RX descriptor cookie is defined as plain u64 so existing cast is no longer valid. * MUSDK 18.09 increased number of available bpools

[dpdk-dev] [PATCH v3 08/13] net/mvpp2: update MTU and MRU related calculations

2018-09-25 Thread Andrzej Ostruszka
From: Natalie Samsonov This commit updates MTU and MRU related calculations. Signed-off-by: Natalie Samsonov Reviewed-by: Yelena Krivosheev Reviewed-by: Dmitri Epshtein --- drivers/net/mvpp2/mrvl_ethdev.c | 70 +++-- drivers/net/mvpp2/mrvl_ethdev.h | 7 ++

[dpdk-dev] [PATCH v3 06/13] net/mvpp2: add traffic manager support

2018-09-25 Thread Andrzej Ostruszka
From: Tomasz Duszynski Add traffic manager support. Signed-off-by: Tomasz Duszynski Signed-off-by: Natalie Samsonov Reviewed-by: Liron Himi --- drivers/net/mvpp2/Makefile |1 + drivers/net/mvpp2/meson.build |3 +- drivers/net/mvpp2/mrvl_ethdev.c | 26 + drivers/net/mvpp2/mrv

[dpdk-dev] [PATCH v3 05/13] net/mvpp2: add init and deinit to flow

2018-09-25 Thread Andrzej Ostruszka
From: Tomasz Duszynski Add init and deinit functionality to flow implementation. Init puts structures used by flow in a sane sate. Deinit deallocates all resources used by flow. Signed-off-by: Tomasz Duszynski Signed-off-by: Natalie Samsonov Reviewed-by: Liron Himi Reviewed-by: Shlomi Gridis

[dpdk-dev] [PATCH v3 10/13] crypto/mvsam: get number of CIOs dynamically

2018-09-25 Thread Andrzej Ostruszka
From: Dmitri Epshtein MUSDK 18.09 introduced API for getting CIOs number dynamically. Use that instead of predefined constant. Signed-off-by: Dmitri Epshtein Reviewed-by: Natalie Samsonov Tested-by: Natalie Samsonov --- drivers/crypto/mvsam/rte_mrvl_pmd.c | 2 +- 1 file changed, 1 insertion(

[dpdk-dev] [PATCH v3 11/13] net/mvpp2: align documentation with MUSDK 18.09

2018-09-25 Thread Andrzej Ostruszka
From: Natalie Samsonov Update documentation to align with MUSDK 18.09. Signed-off-by: Natalie Samsonov --- doc/guides/nics/mvpp2.rst | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/doc/guides/nics/mvpp2.rst b/doc/guides/nics/mvpp2.rst index a452

[dpdk-dev] [PATCH v3 12/13] net/mvpp2: document MTR and TM usage

2018-09-25 Thread Andrzej Ostruszka
From: Natalie Samsonov Document MTR (metering) and TM (traffic management) usage plus do some small updates here and there. Signed-off-by: Natalie Samsonov --- doc/guides/nics/img/mvpp2_tm.svg | 71 +++ doc/guides/nics/mvpp2.rst| 386 +-- 2 file

[dpdk-dev] [PATCH v3 13/13] net/mvpp2: add Tx scatter/gather support

2018-09-25 Thread Andrzej Ostruszka
From: Zyta Szpak The patch introduces scatter/gather support on transmit path. A separate Tx callback is added and set if the application requests multisegment Tx offload. Multiple descriptors are sent per one packet. Signed-off-by: Zyta Szpak Signed-off-by: Natalie Samsonov Reviewed-by: Yelen

Re: [dpdk-dev] [PATCH v2 2/2] eal: force IOVA to particular mode

2018-09-25 Thread Santosh Shukla
Hi Eric, On Tuesday 25 September 2018 02:12 AM, Zhang, Qing Long (Eric) wrote: > External Email > > Hi Santosh/Anatoly, > Any comments on the v2 patch which uses EAL option to let user configure > iova mode as suggested? > > Thanks > Eric > > -Original Message- > From: dev [mailto:dev-bou

[dpdk-dev] [PATCH v3 2/2] test/event: fix Rx adapter intr autotest for skeleton PMD

2018-09-25 Thread Nikhil Rao
skeleton PMD does not support RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ so make the Rx queue_id = -1 and initialize the event port configuration to zero. Fixes: d65856999dd6 ("test/event: add Rx adapter tests for interrupt driven queues") Signed-off-by: Nikhil Rao --- test/test/test_event_eth_

[dpdk-dev] [PATCH v3 1/2] test/event: fix eth Rx adapter autotest for skeleton PMD

2018-09-25 Thread Nikhil Rao
skeleton PMD does not support RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ and implicit_release_disable so make the Rx queue_id = -1 and initialize the event port configuration to zero. Fixes: ec36d881f56d ("eventdev: add implicit release disable capability") Fixes: 2a9c83ae3b2e ("test/eventdev: add

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-09-25 Thread Akhil Goyal
Hi Konstantin, On 9/24/2018 4:21 PM, Ananyev, Konstantin wrote: Hi Akhil, Hi Konstantin, On 9/18/2018 6:12 PM, Ananyev, Konstantin wrote: I am not saying this should be the ONLY way to do as it does not work very well with non NPU/FPGA class of SoC. So how about making the proposed IPSec li

Re: [dpdk-dev] [PATCH 1/2] eal/vfio: check if we already have the group fd open

2018-09-25 Thread Wang, Xiao W
Hi, > -Original Message- > From: Stojaczyk, Dariusz > Sent: Monday, September 17, 2018 9:47 PM > To: dev@dpdk.org > Cc: Alejandro Lucero ; Burakov, Anatoly > ; sta...@dpdk.org; Stojaczyk, Dariusz > ; Wang, Xiao W > Subject: [PATCH 1/2] eal/vfio: check if we already have the group fd open

Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-09-25 Thread Ferruh Yigit
On 9/24/2018 5:59 PM, Thomas Monjalon wrote: > 24/09/2018 17:06, Ferruh Yigit: >> On 9/20/2018 1:18 AM, Thomas Monjalon wrote: >>> -#define false FALSE >>> -#define true TRUE >> >> TRUE and FALSE also defined in this patch, can we remove them too? >

[dpdk-dev] [PATCH] net/i40e: fix 25G AOC and ACC cable detection on XXV710

2018-09-25 Thread Damjan Marion
Fixes: 75d133dd3296 ("net/i40e: enable 25G device") Cc: sta...@dpdk.org Signed-off-by: Damjan Marion --- drivers/net/i40e/i40e_ethdev.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h index 3fffe5a55..b876933e

Re: [dpdk-dev] [PATCH v5 2/2] examples/vdpa: introduce a new sample for vDPA

2018-09-25 Thread Wang, Xiao W
Hi, > -Original Message- > From: Ye, Xiaolong > Sent: Tuesday, September 25, 2018 8:07 PM > To: dev@dpdk.org; Maxime Coquelin ; Bie, > Tiwei ; Wang, Zhihong > Cc: Wang, Xiao W ; Rami Rosen > ; Wang, Haiyue ; Ye, > Xiaolong > Subject: [PATCH v5 2/2] examples/vdpa: introduce a new sample f

Re: [dpdk-dev] [PATCH] netvsc: support multicast/promiscuous settings on VF

2018-09-25 Thread Stephen Hemminger
On Mon, 24 Sep 2018 16:49:24 +0100 Ferruh Yigit wrote: > On 9/21/2018 5:54 PM, Stephen Hemminger wrote: > > Provide API's to enable allmulticast and promiscuous in Netvsc PMD > > with VF. This keeps the VF and PV path in sync. > > VF and PF? > > > > > Signed-off-by: Stephen Hemminger > > --

[dpdk-dev] [PATCH v2] eventdev: fix port id argument in Rx adapter caps API

2018-09-25 Thread Nikhil Rao
Make the ethernet port id passed into rte_event_eth_rx_adapter_caps_get() 16 bit. Also, update the event rx adapter test to use 16 bit ethernet port ids. Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit") Cc: sta...@dpdk.org Signed-off-by: Nikhil Rao Acked-by: Jerin Jacob --

Re: [dpdk-dev] [PATCH 09/11] doc: add telemetry documentation

2018-09-25 Thread Kovacevic, Marko
> This patch adds all documentation for telemetry. > > A description on how to use the Telemetry API with a DPDK application is > given in this document. > > Signed-off-by: Ciara Power > Signed-off-by: Brian Archbold > --- > doc/guides/howto/index.rst | 1 + > doc/guides/howto/telemetry

[dpdk-dev] reviewathon is today!(?)

2018-09-25 Thread Ferruh Yigit
Hi, An reviewathon is happening in Intel, please feel free to join us. Indeed this was planned to be community review day, but we were late to communicate this, sorry. I hope we can do a better organized one next week. Please join to IRC [1], fell free to ask questions, communicate with other de

Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-09-25 Thread Thomas Monjalon
25/09/2018 10:03, Ferruh Yigit: > On 9/24/2018 5:59 PM, Thomas Monjalon wrote: > >>> --- a/drivers/net/ixgbe/ixgbe_rxtx.c > >>> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > >>> @@ -2025,7 +2025,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf > >>> **rx_pkts, uint16_t nb_pkts, > >>> st

Re: [dpdk-dev] [PATCH v3 1/3] lib/librte_table: add hash_func header files

2018-09-25 Thread Dumitrescu, Cristian
> ARM specific change and this patchset looks good. But, It has following > checkpatches.sh and check-git-log.sh errors. > Thanks, Jerin, this looks like a map file issue, we'll work to fix it. Regards, Cristian

Re: [dpdk-dev] [PATCH v2] eventdev: fix port id argument in Rx adapter caps API

2018-09-25 Thread Jerin Jacob
-Original Message- > Date: Tue, 25 Sep 2018 14:19:12 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org, Nikhil Rao , sta...@dpdk.org > Subject: [PATCH v2] eventdev: fix port id argument in Rx adapter caps API > X-Mailer: git-send-email 1.8.3.1 > > > Make th

Re: [dpdk-dev] [PATCH v3 1/8] examples/power: add checks around hypervisor

2018-09-25 Thread Burakov, Anatoly
On 14-Sep-18 2:53 PM, David Hunt wrote: Allow vm_power_manager to run without requiring qemu to be present on the machine. This will be required for instances where the JSON interface is used for commands and polices, without any VMs present. A use case for this is a container enviromnent. Signe

Re: [dpdk-dev] [PATCH v3 2/8] lib/power: add changes for host commands/policies

2018-09-25 Thread Burakov, Anatoly
On 14-Sep-18 2:54 PM, David Hunt wrote: Signed-off-by: David Hunt The commit message is not very descriptive as to what these chages are and why they are added. -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v3 3/8] examples/power: add necessary changes to guest app

2018-09-25 Thread Burakov, Anatoly
On 14-Sep-18 2:54 PM, David Hunt wrote: The changes here are minimal, as the guest app functionality is not changing at all, but there is a new element in the channel_packet struct that needs to have a default set (channel_packet->core_type). Signed-off-by: David Hunt --- Acked-by: Anatoly Bu

Re: [dpdk-dev] [PATCH v4 2/4] ring: read tail using atomic load

2018-09-25 Thread Gavin Hu (Arm Technology China)
+ Justin He as Jerin requested. > -Original Message- > From: Jerin Jacob > Sent: Thursday, September 20, 2018 2:41 PM > To: Gavin Hu (Arm Technology China) > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; Steve Capper > ; Ola Liljedahl ; nd > ; sta...@dpdk.org; jia...@hxt-semitech.com > Sub

[dpdk-dev] [PATCH v3] eventdev: fix port id argument in Rx adapter caps API

2018-09-25 Thread Nikhil Rao
Make the ethernet port id passed into rte_event_eth_rx_adapter_caps_get() 16 bit. Also, update the event rx adapter test to use 16 bit ethernet port ids. Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit") Cc: sta...@dpdk.org Signed-off-by: Nikhil Rao Acked-by: Jerin Jacob --

Re: [dpdk-dev] [PATCH v3 4/8] examples/power: add host channel to power manager

2018-09-25 Thread Burakov, Anatoly
On 14-Sep-18 2:54 PM, David Hunt wrote: This patch adds a fifo channel to the vm_power_manager app through which we can send commands and polices. Intended for sending JSON strings. The fifo is at /tmp/powermonitor/fifo.0 Signed-off-by: David Hunt --- A bunch of nitpick comments below :)

Re: [dpdk-dev] [PATCH v2] eventdev: fix port id argument in Rx adapter caps API

2018-09-25 Thread Thomas Monjalon
25/09/2018 11:15, Jerin Jacob: > -Original Message- > > Date: Tue, 25 Sep 2018 14:19:12 +0530 > > From: Nikhil Rao > > To: jerin.ja...@caviumnetworks.com > > CC: dev@dpdk.org, Nikhil Rao , sta...@dpdk.org > > Subject: [PATCH v2] eventdev: fix port id argument in Rx adapter caps API > > X-M

[dpdk-dev] [PATCH v2] eal: use correct data type for bitmap slab operations

2018-09-25 Thread Vivek Sharma
Currently, slab operations use unsigned long data type for 64-bit slab related operations. On target 'i686-native-linuxapp-gcc', unsigned long is 32-bit and thus, slab operations breaks on this target. Changing slab operations to use unsigned long long for correct functioning on all targets. Fixes

Re: [dpdk-dev] [PATCH v2] eventdev: fix port id argument in Rx adapter caps API

2018-09-25 Thread Jerin Jacob
-Original Message- > Date: Tue, 25 Sep 2018 11:50:06 +0200 > From: Thomas Monjalon > To: Jerin Jacob > Cc: Nikhil Rao , dev@dpdk.org, sta...@dpdk.org > Subject: Re: [PATCH v2] eventdev: fix port id argument in Rx adapter caps > API > > > 25/09/2018 11:15, Jerin Jacob: > > -Original

Re: [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command

2018-09-25 Thread Iremonger, Bernard
Hi Jasvinder, > -Original Message- > From: Singh, Jasvinder > Sent: Wednesday, September 12, 2018 10:02 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Subject: [PATCH] app/testpmd: fix metering and policing cli command > > Fixes bad arguments error for

[dpdk-dev] [PATCH v6] app/testpmd: add new command for show port info

2018-09-25 Thread Marko Kovacevic
From: Emma Finn existing testpmd command "show port info" is too verbose. Added a new summary command to print brief information on ports. console output: testpmd> show port summary all Number of available ports: 2 Port MAC Address Name Driver Status Link

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix wrong session size

2018-09-25 Thread Joseph, Anoob
Hi Akhil, Radu, Can you please review this patch and let me know your thoughts? Anoob On 07-09-2018 11:25, Anoob Joseph wrote: Crypto devices, which support lookaside protocol, exposes security session size in addition to the crypto private symmetric session data size. For applications using t

Re: [dpdk-dev] [PATCH v3 1/2] doc: create a platorm specific page for NXP DPAA platform

2018-09-25 Thread Kovacevic, Marko
> Signed-off-by: Hemant Agrawal > --- > v3: merge the patches > > doc/guides/cryptodevs/dpaa_sec.rst | 25 +- > doc/guides/eventdevs/dpaa.rst | 48 ++ > doc/guides/nics/dpaa.rst | 59 +- > doc/guides/platform/dpaa.rst | 100 Ack

Re: [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command

2018-09-25 Thread Singh, Jasvinder
> diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c > > index f908fb3..32a4730 100644 > > --- a/app/test-pmd/cmdline_mtr.c > > +++ b/app/test-pmd/cmdline_mtr.c > > @@ -414,9 +414,9 @@ cmdline_parse_inst_t > > cmd_add_port_meter_profile_srtcm = { > > (void *)&cmd_add_

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix wrong session size

2018-09-25 Thread Akhil Goyal
On 9/7/2018 11:25 AM, Anoob Joseph wrote: Crypto devices, which support lookaside protocol, exposes security session size in addition to the crypto private symmetric session data size. For applications using the security capabilities, both these sizes need to be considered. Fixes: ec17993a145

Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: increase the number of dev mappings

2018-09-25 Thread Akhil Goyal
On 9/6/2018 8:40 AM, Anoob Joseph wrote: Increasing the number of cdev mappings to accommodate usage of crypto devices with larger number of capabilities, with higher number of cores. Required mappings : ([no of ciphers] * [no of auth] + [aead algos]) * [no of cores] Sig

Re: [dpdk-dev] [PATCH v6] app/testpmd: add new command for show port info

2018-09-25 Thread Iremonger, Bernard
> -Original Message- > From: Kovacevic, Marko > Sent: Tuesday, September 25, 2018 11:33 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Iremonger, Bernard > ; Finn, Emma > Subject: [PATCH v6] app/testpmd: add new command for show port info > > From: Emma Finn > > existing testpmd command "s

Re: [dpdk-dev] [PATCH v3 2/2] doc: create a platorm specific page for NXP DPAA2 platform

2018-09-25 Thread Kovacevic, Marko
> NXP DPAA2 platform > > Signed-off-by: Hemant Agrawal > --- > v3: merge the patches > > doc/guides/cryptodevs/dpaa2_sec.rst | 28 +++ > doc/guides/eventdevs/dpaa2.rst | 50 ++- > doc/guides/nics/dpaa2.rst | 49 ++- > doc/guides/platform/dp

Re: [dpdk-dev] [PATCH 3/3] crypto/mvsam: get number of CIOs dynamically

2018-09-25 Thread Akhil Goyal
Hi, On 9/4/2018 7:29 PM, Tomasz Duszynski wrote: From: Dmitri Epshtein MUSDK 18.09 introduced API for getting CIOs number dynamically. Use that instead of predefined constant. Signed-off-by: Dmitri Epshtein Reviewed-by: Natalie Samsonov Tested-by: Natalie Samsonov --- drivers/crypto/mvsa

[dpdk-dev] [PATCH v2] app/testpmd: fix printf format specifiers

2018-09-25 Thread Herakliusz Lipiec
change PRIu8 -> PRIu16 for port_id in eth_event_callback (portid_t is uint16_t) Fixes: 76ad4a2d82d4 ("app/testpmd: add generic event handler") Cc: sta...@dpdk.org Signed-off-by: Herakliusz Lipiec --- app/test-pmd/testpmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

Re: [dpdk-dev] [PATCH v3 5/8] examples/power: add json string handling

2018-09-25 Thread Burakov, Anatoly
On 14-Sep-18 2:54 PM, David Hunt wrote: Add JSON string handling to vm_power_manager for JSON strings received through the fifo. The format of the JSON strings are detailed in the next patch, the vm_power_manager user guide documentation updates. This patch introduces a new dependency on Jansson

Re: [dpdk-dev] [PATCH v2 08/12] net/bnxt: use correct macro to register VF async event completion ring

2018-09-25 Thread Ferruh Yigit
On 9/22/2018 5:55 AM, Ajit Khaparde wrote: > From: yongping > > While registering vf's event completion ring to FW, use the wrong > macro, FW doesn't set up the event completion ring successfully, > VF can't receive any async event. Isn't this a fix that you would want to backport? If so can yo

Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support metadata as flow rule criteria

2018-09-25 Thread Dekel Peled
> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, September 18, 2018 11:22 AM > To: Dekel Peled ; wenzhuo...@intel.com; > jingjing...@intel.com; bernard.iremon...@intel.com; dev@dpdk.org; > olivier.m...@6wind.com; Adrien Mazarguil ; > Thomas Monjalon ; ferruh.yi...@intel.co

Re: [dpdk-dev] [PATCH v2 09/12] net/bnxt: set MAC filtering as outer for non tunnel frames

2018-09-25 Thread Ferruh Yigit
On 9/22/2018 5:55 AM, Ajit Khaparde wrote: > We need to set HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST bit in > L2_FILTER_ALLOC for filtering non-tunnel packets based on outermost MAC. What happens if that bit is not set, filtering is not working as expected? If so can you please convert this

Re: [dpdk-dev] [PATCH v2 11/12] net/bnxt: set VLAN strip mode before default vnic cfg

2018-09-25 Thread Ferruh Yigit
On 9/22/2018 5:55 AM, Ajit Khaparde wrote: > From: Bei Sun > > Firmware sets pf pair in default vnic cfg. If the VLAN strip > setting is not available at this time, it will not be > configured correctly in the CFA. > Set the desired VLAN strip mode before default vnic configuration. vnic used as

Re: [dpdk-dev] [PATCH v2 12/12] net/bnxt: remove excess log messages

2018-09-25 Thread Ferruh Yigit
On 9/22/2018 5:55 AM, Ajit Khaparde wrote: > When the firmware version and the driver HWRM version do not match, > we are logging some messages. These messages unnecessarily clutter > the logs and can add to the noise. We are logging the HWRM version > and the firmware version anyway. The differenc

Re: [dpdk-dev] [PATCH v2 00/12] bnxt patchset

2018-09-25 Thread Ferruh Yigit
On 9/22/2018 5:55 AM, Ajit Khaparde wrote: > Patchset against dpdk-next-net. > > v1->v2: > net/bnxt: get rid of ff pools array and use the vnic info array instead > - Fix access to uninitialized variable. > - Rectify the wrong 'Fixes' reference. > > net/bnxt: update HWRM version > - Update from 1

Re: [dpdk-dev] [PATCH v2 04/12] net/bnxt: update HWRM version

2018-09-25 Thread Ferruh Yigit
On 9/22/2018 5:55 AM, Ajit Khaparde wrote: > Update the HWRM API to version 1.9.2.53 > Signed-off-by: Ajit Khaparde > -- > v1->v2: > Update from 1.9.2.45 to version 1.9.2.53 > --- > drivers/net/bnxt/bnxt_stats.c |12 +- > drivers/net/bnxt/hsi_struct_def_dpdk.h | 24017 +++

[dpdk-dev] [PATCH] net/mlx5: eswitch-IP address UDP/TCP port rewrite

2018-09-25 Thread Xiaoyu Min
Offload the following rte_flow actions by inserting accordingly E-Switch rules via TC Flower driver - RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC - RTE_FLOW_ACTION_TYPE_SET_IPV4_DST - RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC - RTE_FLOW_ACTION_TYPE_SET_IPV6_DST - RTE_FLOW_ACTION_TYPE_SET_TP_SRC - RTE_FLOW_ACT

Re: [dpdk-dev] [PATCH] app/test-pmd: add and identify shaper profile parameters

2018-09-25 Thread Singh, Jasvinder
> -Original Message- > From: Xu, Rosen > Sent: Monday, August 13, 2018 11:35 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Lu, Wenzhuo > ; Singh, Jasvinder ; Xu, > Rosen ; Yigit, Ferruh > Subject: [PATCH] app/test-pmd: add and identify shaper profile parameters > > As struct rte_t

Re: [dpdk-dev] [PATCH] acl: fix invalid results for rule with zero priority

2018-09-25 Thread Luca Boccassi
On Sun, 2018-09-16 at 11:56 +0200, Thomas Monjalon wrote: > 24/08/2018 18:47, Konstantin Ananyev: > > If user specifies priority=0 for some of ACL rules > > that can cause rte_acl_classify to return wrong results. > > The reason is that priority zero is used internally for no-match > > nodes. > > S

[dpdk-dev] [PATCH v2] latencystats: fix timestamp marking and latency calculation

2018-09-25 Thread Reshma Pattan
Latency calculation logic is not correct for the case where packets gets dropped before TX. As for the dropped packets, the timestamp is not cleared, and such packets still gets counted for latency calculation in next runs, that will result in inaccurate latency measurement. So fix this issue as b

Re: [dpdk-dev] [PATCH v8 3/4] doc/guides/proguide/power-man: update the power API

2018-09-25 Thread Kovacevic, Marko
> Update the document for empty poll API. > > Signed-off-by: Liang Ma > --- > doc/guides/prog_guide/power_man.rst | 90 > + > 1 file changed, 90 insertions(+) > > diff --git a/doc/guides/prog_guide/power_man.rst > b/doc/guides/prog_guide/power_man.rst > index

Re: [dpdk-dev] [PATCH v8 3/4] doc/guides/proguide/power-man: update the power API

2018-09-25 Thread Kovacevic, Marko
> > Update the document for empty poll API. > > > > Signed-off-by: Liang Ma > > --- > > doc/guides/prog_guide/power_man.rst | 90 > > + > > 1 file changed, 90 insertions(+) > > > > diff --git a/doc/guides/prog_guide/power_man.rst > > b/doc/guides/prog_guide/pow

Re: [dpdk-dev] [PATCH v2] eventdev: fix port id argument in Rx adapter caps API

2018-09-25 Thread Thomas Monjalon
25/09/2018 11:56, Jerin Jacob: > From: Thomas Monjalon > > 25/09/2018 11:15, Jerin Jacob: > > > From: Nikhil Rao > > > > @@ -162,7 +164,7 @@ The libraries prepended with a plus sign were > > > > incremented in this version. > > > > librte_distributor.so.1 > > > > librte_eal.so.8 > >

[dpdk-dev] [PATCH 2/5] drivers: common as dependency for bus

2018-09-25 Thread Shreyansh Jain
It is possible that bus requires common library for compilation. Prior to this patch, bus and common compiled parallel. But, post this dependency is created. This is especially important for the DPAA/FSLMC buses which are going to use the common/dpaax library. Signed-off-by: Shreyansh Jain ---

[dpdk-dev] [PATCH 0/5] Add a PA-VA Translation table for DPAAx

2018-09-25 Thread Shreyansh Jain
::Background:: After the restructuring of memory in last release(s), one of the major impact on fslmc/dpaa bus (and its devices) was the performance drop when using physical addressing. Previously, it was assumed that physical range was contiguous for any given request for hugepage memory. That wa

[dpdk-dev] [PATCH 3/5] common/dpaax: add library for PA VA translation table

2018-09-25 Thread Shreyansh Jain
A common library, valid for dpaaX drivers, which is used to maintain a local copy of PA->VA translations. In case of physical addressing mode (one of the option for FSLMC, and only option for DPAA bus), the addresses of descriptors Rx'd are physical. These need to be converted into equivalent VA f

[dpdk-dev] [PATCH 1/5] bus/fslmc: fix physical addressing check

2018-09-25 Thread Shreyansh Jain
In case RTE_LIBRTE_DPAA2_USE_PHYS_IOVA is enabled, only supported class is RTE_IOVA_PA. Fixes: f7768afac101 ("bus/fslmc: support dynamic IOVA") Cc: hemant.agra...@nxp.com Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_bus.c | 4 1 file changed, 4 insertions(+) diff --git a/driv

[dpdk-dev] [PATCH 4/5] dpaa: enable dpaax library

2018-09-25 Thread Shreyansh Jain
With this patch, dpaa bus and ethernet devices on this bus would start using the physical-virtual library interfaces. This patch impacts mempool/dpaa, event/dpaa and net/dpaa as they are dependent on the bus/dpaa and thus impact linkage of libraries. Signed-off-by: Shreyansh Jain --- drivers/bu

[dpdk-dev] [PATCH 5/5] fslmc: enable dpaax library

2018-09-25 Thread Shreyansh Jain
With this patch, fslmc bus and ethernet devices on this bus would start using the physical-virtual library interfaces. This patch impacts mempool/dpaa2, event/dpaa2, net/dpaa2, raw/dpaa2_cmdif and raw/dpaa2_qdma as they are dependent on the bus/fslmc and thus impact linkage of libraries. Signed-o

Re: [dpdk-dev] [PATCH] acl: fix invalid results for rule with zero priority

2018-09-25 Thread Thomas Monjalon
25/09/2018 14:22, Luca Boccassi: > On Sun, 2018-09-16 at 11:56 +0200, Thomas Monjalon wrote: > > 24/08/2018 18:47, Konstantin Ananyev: > > > If user specifies priority=0 for some of ACL rules > > > that can cause rte_acl_classify to return wrong results. > > > The reason is that priority zero is us

[dpdk-dev] [PATCH] doc: fix eventdev shared library version

2018-09-25 Thread Jerin Jacob
The below change set suppose to bump the eventdev shared library version. It missed updating the version number so fixing it now. Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter") Cc: sta...@dpdk.org Signed-off-by: Jerin Jacob --- doc/guides/rel_notes/release_18_08.rst

Re: [dpdk-dev] [PATCH v8 4/4] doc/guides/sample_app_ug/l3_forward_power_man.rst: empty poll update

2018-09-25 Thread Kovacevic, Marko
> Add empty poll mode command line example > > Signed-off-by: Liang Ma > --- > doc/guides/sample_app_ug/l3_forward_power_man.rst | 29 > +++ > 1 file changed, 29 insertions(+) > > +Empty Poll Mode > +- > +There is a new Mode which is added recently. E

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: add sanity checks on received/sent packets

2018-09-25 Thread Iremonger, Bernard
Hi David, > -Original Message- > From: David Marchand [mailto:david.march...@6wind.com] > Sent: Monday, September 10, 2018 6:46 AM > To: dev@dpdk.org > Cc: olivier.m...@6wind.com; Lu, Wenzhuo ; Wu, > Jingjing ; Iremonger, Bernard > > Subject: [PATCH 3/3] app/testpmd: add sanity checks on

Re: [dpdk-dev] [PATCH 3/5] common/dpaax: add library for PA VA translation table

2018-09-25 Thread Burakov, Anatoly
On 25-Sep-18 1:54 PM, Shreyansh Jain wrote: A common library, valid for dpaaX drivers, which is used to maintain a local copy of PA->VA translations. In case of physical addressing mode (one of the option for FSLMC, and only option for DPAA bus), the addresses of descriptors Rx'd are physical. T

Re: [dpdk-dev] [PATCH 3/5] common/dpaax: add library for PA VA translation table

2018-09-25 Thread Shreyansh Jain
Hello Anatoly, On Tuesday 25 September 2018 06:58 PM, Burakov, Anatoly wrote: On 25-Sep-18 1:54 PM, Shreyansh Jain wrote: A common library, valid for dpaaX drivers, which is used to maintain a local copy of PA->VA translations. In case of physical addressing mode (one of the option for FSLMC,

[dpdk-dev] [PATCH] ethdev: fix doxygen comment to be with structure

2018-09-25 Thread Ferruh Yigit
From: Paul M Stillwell Jr The doxygen comment describing the rte_eth_dev_info structure was separated from the structure itself so move the comment back to be with the structure. Fixes: 7238e63bce52 ("ethdev: add support for device offload capabilities") Cc: ivan.bo...@6wind.com Cc: sta...@dpdk.

Re: [dpdk-dev] [PATCH] ethdev: fix doxygen comment to be with structure

2018-09-25 Thread Thomas Monjalon
25/09/2018 16:31, Ferruh Yigit: > From: Paul M Stillwell Jr > > The doxygen comment describing the rte_eth_dev_info structure > was separated from the structure itself so move the comment > back to be with the structure. > > Fixes: 7238e63bce52 ("ethdev: add support for device offload capabiliti

Re: [dpdk-dev] [PATCH v3 1/8] examples/power: add checks around hypervisor

2018-09-25 Thread Hunt, David
On 25/9/2018 10:20 AM, Burakov, Anatoly wrote: On 14-Sep-18 2:53 PM, David Hunt wrote: Allow vm_power_manager to run without requiring qemu to be present on the machine. This will be required for instances where the JSON interface is used for commands and polices, without any VMs present. A u

[dpdk-dev] [PATCH 0/3] ethdev: add generic TTL rewrite actions

2018-09-25 Thread Xiaoyu Min
This patch series is for RFC[1] Patch 1 adds generic TTL rewrite actions to flow API Patch 2 adds corresponding testpmd commands Patch 3 implements the offloading logic of E-Switch rules on Mellanox MLX5 [1]: https://patches.dpdk.org/patch/43617/ Xiaoyu Min (3): ethdev: add generic TTL rewrite

Re: [dpdk-dev] [PATCH v3 2/8] lib/power: add changes for host commands/policies

2018-09-25 Thread Hunt, David
On 25/9/2018 10:21 AM, Burakov, Anatoly wrote: On 14-Sep-18 2:54 PM, David Hunt wrote: Signed-off-by: David Hunt The commit message is not very descriptive as to what these chages are and why they are added. Sure, I'll add a more descriptive comment next version. Thanks, Dave.

[dpdk-dev] [PATCH 1/3] ethdev: add generic TTL rewrite actions

2018-09-25 Thread Xiaoyu Min
rewrite TTL by decrease or just set it directly it's not necessary to check if the final result is zero or not This is slightly different from the one defined by openflow and more generic Signed-off-by: Xiaoyu Min --- doc/guides/prog_guide/rte_flow.rst | 30 + lib/li

[dpdk-dev] [PATCH 3/3] net/mlx5: eswitch-modify TTL actions

2018-09-25 Thread Xiaoyu Min
Offload following modify TTL actions to E-Swtich via TC-Flower driver - RTE_FLOW_ACTION_TYPE_SET_TTL - RTE_FLOW_ACTION_TYPE_DEC_TTL The corresponding IP protocol rte_flow_item_ipv[4|6] must be present in rte_flow pattern otherwith PMD return error Signed-off-by: Xiaoyu Min --- drivers/net/mlx5

[dpdk-dev] [PATCH 2/3] app/testpmd: add commands of modify TTL

2018-09-25 Thread Xiaoyu Min
add commands which supports following TTL actions: - RTE_FLOW_ACTION_TYPE_DEC_TTL - RTE_FLOW_ACTION_TYPE_SET_TTL Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline_flow.c | 34 + app/test-pmd/config.c | 3 ++ doc/guides/testpmd_app_ug/te

Re: [dpdk-dev] [PATCH 3/5] common/dpaax: add library for PA VA translation table

2018-09-25 Thread Burakov, Anatoly
On 25-Sep-18 2:39 PM, Shreyansh Jain wrote: Hello Anatoly, On Tuesday 25 September 2018 06:58 PM, Burakov, Anatoly wrote: On 25-Sep-18 1:54 PM, Shreyansh Jain wrote: A common library, valid for dpaaX drivers, which is used to maintain a local copy of PA->VA translations. In case of physical a

Re: [dpdk-dev] [PATCH v3 4/8] examples/power: add host channel to power manager

2018-09-25 Thread Hunt, David
Hi Anatoly, On 25/9/2018 10:48 AM, Burakov, Anatoly wrote: On 14-Sep-18 2:54 PM, David Hunt wrote: This patch adds a fifo channel to the vm_power_manager app through which we can send commands and polices. Intended for sending JSON strings. The fifo is at /tmp/powermonitor/fifo.0 Signed-off-b

Re: [dpdk-dev] [PATCH 3/5] common/dpaax: add library for PA VA translation table

2018-09-25 Thread Shreyansh Jain
On Tuesday 25 September 2018 07:21 PM, Burakov, Anatoly wrote: On 25-Sep-18 2:39 PM, Shreyansh Jain wrote: Hello Anatoly, On Tuesday 25 September 2018 06:58 PM, Burakov, Anatoly wrote: On 25-Sep-18 1:54 PM, Shreyansh Jain wrote: A common library, valid for dpaaX drivers, which is used to main

Re: [dpdk-dev] [PATCH v3 5/8] examples/power: add json string handling

2018-09-25 Thread Hunt, David
Hi Anatoly, On 25/9/2018 12:27 PM, Burakov, Anatoly wrote: On 14-Sep-18 2:54 PM, David Hunt wrote: Add JSON string handling to vm_power_manager for JSON strings received through the fifo. The format of the JSON strings are detailed in the next patch, the vm_power_manager user guide documentati

Re: [dpdk-dev] [PATCH 3/5] common/dpaax: add library for PA VA translation table

2018-09-25 Thread Burakov, Anatoly
On 25-Sep-18 3:00 PM, Shreyansh Jain wrote: On Tuesday 25 September 2018 07:21 PM, Burakov, Anatoly wrote: On 25-Sep-18 2:39 PM, Shreyansh Jain wrote: Hello Anatoly, On Tuesday 25 September 2018 06:58 PM, Burakov, Anatoly wrote: On 25-Sep-18 1:54 PM, Shreyansh Jain wrote: A common library, v

[dpdk-dev] secondary processes and private data

2018-09-25 Thread Alejandro Lucero
I've a problem when part of device private data needs to be private per process. Current multiprocess support shares device private data between primary and secondaries but it is all dependent on a pointer initialized to the same memory address by the multiprocess support code. If there is a per-p

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix error handling logic

2018-09-25 Thread Ferruh Yigit
On 9/24/2018 3:10 PM, Andrew Rybchenko wrote: > On 9/24/18 4:43 PM, Alejandro Lucero wrote: >> This patch fixes how function exit is handled when errors inside >> rte_eth_dev_create. >> >> Fixes: e489007a411c ("ethdev: add generic create/destroy ethdev APIs") >> Cc: sta...@dpdk.org >> >> Signed-off

Re: [dpdk-dev] [PATCH v3 5/8] examples/power: add json string handling

2018-09-25 Thread Burakov, Anatoly
On 25-Sep-18 3:00 PM, Hunt, David wrote: Now you're removing those newlines you added in previous commit :) Fixed in previous patch in the next version.   if (pol->pkt.core_type == CORE_TYPE_VIRTUAL) {   /*    * If the cores in the policy are virtual, we need to map them

Re: [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command

2018-09-25 Thread Iremonger, Bernard
Hi Jasvinder, > -Original Message- > From: Singh, Jasvinder > Sent: Tuesday, September 25, 2018 12:02 PM > To: Iremonger, Bernard ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > > Subject: RE: [PATCH] app/testpmd: fix metering and policing cli command > > > diff --git a/app/test-pmd/c

Re: [dpdk-dev] secondary processes and private data

2018-09-25 Thread Burakov, Anatoly
On 25-Sep-18 3:10 PM, Alejandro Lucero wrote: I've a problem when part of device private data needs to be private per process. Current multiprocess support shares device private data between primary and secondaries but it is all dependent on a pointer initialized to the same memory address by

Re: [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command

2018-09-25 Thread Singh, Jasvinder
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, September 25, 2018 3:16 PM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > > Subject: RE: [PATCH] app/testpmd: fix metering and policing cli command > > Hi Jasvinder, > > > -Original Message-

Re: [dpdk-dev] [PATCH 0/3] fix test vector checks

2018-09-25 Thread Akhil Goyal
On 9/14/2018 2:54 PM, Anoob Joseph wrote: Multiple fixes to the test vector checks. Anoob Joseph (3): app/test-crypto-perf: add checks for AEAD key app/test-crypto-perf: fix check for auth key app/test-crypto-perf: fix check for cipher IV app/test-crypto-perf/main.c | 12 +

Re: [dpdk-dev] [PATCH v1] app/test-crypto-perf: fix double allocation of memory

2018-09-25 Thread Akhil Goyal
On 9/10/2018 12:10 PM, Anoob Joseph wrote: The field, 'cipher_iv.data' is allocated twice when cipher is not null. Ideally the allocation should depend only on the field 'cperf_options.cipher_iv_sz'. This will make sure this code path gets valid for ciphers which doesn't require IV. Fixes: 0f

Re: [dpdk-dev] [PATCH 00/11] net/sfc: update base driver to support 50G and 100G

2018-09-25 Thread Ferruh Yigit
On 9/24/2018 2:50 PM, Andrew Rybchenko wrote: > Add base driver patches to support 50G and 100G XtremeScale X2 > family adapters. > > In this particular case it looks better to have separate patch which > updates documentation (as a cut line which summarizes the result). > > There are few checkpa

  1   2   >