Re: [dpdk-dev] [RFC 1/3] log: add TQS log type

2018-11-27 Thread Honnappa Nagarahalli
> > On Wed, 21 Nov 2018 21:30:53 -0600 > Honnappa Nagarahalli wrote: > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Steve Capper > > Reviewed-by: Gavin Hu > > --- > > lib/librte_eal/common/include/rte_log.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/librte

Re: [dpdk-dev] [RFC 0/3] tqs: add thread quiescent state library

2018-11-27 Thread Honnappa Nagarahalli
> > > > On Wed, 21 Nov 2018 21:30:52 -0600 > > Honnappa Nagarahalli wrote: > > > > > Lock-less data structures provide scalability and determinism. > > > They enable use cases where locking may not be allowed (for ex: > > > real-time applications). > > > > > > > > > Dharmik Thakkar (1): > > >

Re: [dpdk-dev] [PATCH 19.02 2/2] mem: use memfd for no-huge mode

2018-11-27 Thread Tiwei Bie
On Tue, Nov 13, 2018 at 05:54:48PM +, Anatoly Burakov wrote: > When running in no-huge mode, we anonymously allocate our memory. > While this works for regular NICs and vdev's, it's not suitable > for memory sharing scenarios such as virtio with vhost_user > backend. > > To fix this, allocate

Re: [dpdk-dev] [RFC 0/3] tqs: add thread quiescent state library

2018-11-27 Thread Van Haaren, Harry
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, November 27, 2018 2:28 PM > To: Honnappa Nagarahalli > Cc: dev@dpdk.org; n...@arm.com; dharmik.thak...@arm.com; > malvika.gu...@arm.com; > gavin...@arm.com > Subject: Re: [dpdk-d

Re: [dpdk-dev] Application used for DSW event_dev performance testing

2018-11-27 Thread Venky Venkatesh
On 11/14/18, 9:46 PM, "Mattias Rönnblom" wrote: > > > On 11/14/18, 9:46 PM, "Mattias Rönnblom" > wrote: > > On 2018-11-14 22:56, Venky Venkatesh wrote: > > Mattias, > > Thanks for the prompt response. Appreciate your situation of not being > able to share the proprietary code. Mor

Re: [dpdk-dev] [RFC 0/3] tqs: add thread quiescent state library

2018-11-27 Thread Stephen Hemminger
On Wed, 21 Nov 2018 21:30:52 -0600 Honnappa Nagarahalli wrote: > Lock-less data structures provide scalability and determinism. > They enable use cases where locking may not be allowed > (for ex: real-time applications). > > In the following paras, the term 'memory' refers to memory allocated >

Re: [dpdk-dev] [RFC 1/3] log: add TQS log type

2018-11-27 Thread Stephen Hemminger
On Wed, 21 Nov 2018 21:30:53 -0600 Honnappa Nagarahalli wrote: > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Steve Capper > Reviewed-by: Gavin Hu > --- > lib/librte_eal/common/include/rte_log.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eal/common/include/rte_

Re: [dpdk-dev] [RFC 2/3] tqs: add thread quiescent state library

2018-11-27 Thread Honnappa Nagarahalli
> > Hi Honnappa, Thank you for reviewing the patch, appreciate your comments. > > > + > > +/* Allocate a new TQS variable with the name *name* in memory. */ > > +struct rte_tqs * __rte_experimental rte_tqs_alloc(const char *name, > > +int socket_id, uint64_t lcore_mask) { > > + char tqs_name[R

[dpdk-dev] [PATCH] mk: don't install meson.build in usertools

2018-11-27 Thread Timothy Redaelli
In commit 7dd34c71de2a ("usertools: install with meson") meson.build was added in usertools directory and so it's copied to $(datadir)/usertools with "make install". This patch avoids to copy meson.build when installing usertools with "make install". Signed-off-by: Timothy Redaelli --- mk/rte.s

Re: [dpdk-dev] [PATCH] examples/bond: wait for slaves to become active

2018-11-27 Thread Chas Williams
On 11/14/2018 07:19 AM, Radu Nicolau wrote: Do not start the packet processing threads until all configured slaves become active. Signed-off-by: Radu Nicolau Acked-by: Chas Williams --- examples/bond/main.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/examples

Re: [dpdk-dev] [PATCH] examples/bond: fix initialization error

2018-11-27 Thread Chas Williams
On 11/13/2018 11:46 AM, Radu Nicolau wrote: Queue setup will fail if called before adding slaves. Fixes: 7a0665940fa8 ("net/bonding: inherit descriptor limits from slaves") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau Acked-by: Chas Williams --- examples/bond/main.c | 14 +++--

Re: [dpdk-dev] [PATCH v2 3/3] net/af_packet: get 'framesz' from the iface's MTU

2018-11-27 Thread Ferruh Yigit
On 11/27/2018 5:43 PM, Ferruh Yigit wrote: > On 11/20/2018 10:26 AM, Tiago Lam wrote: >> Use the underlying MTU to calculate the framsize to be used for the mmap >> RINGs. This is to make it more flexible on deployments with different >> MTU requirements, instead of using a pre-defined value of 204

Re: [dpdk-dev] [PATCH v2 3/3] net/af_packet: get 'framesz' from the iface's MTU

2018-11-27 Thread Ferruh Yigit
On 11/20/2018 10:26 AM, Tiago Lam wrote: > Use the underlying MTU to calculate the framsize to be used for the mmap > RINGs. This is to make it more flexible on deployments with different > MTU requirements, instead of using a pre-defined value of 2048B. This behavior change should be documented i

Re: [dpdk-dev] [PATCH v2 1/3] net/af_packet: set_mtu() decrements sockaddr twice

2018-11-27 Thread Ferruh Yigit
On 11/20/2018 10:26 AM, Tiago Lam wrote: > When setting the MTU, eth_dev_mtu_set() is called to validate the > provided MTU. As part of that, it calculates the useful area to store > data and compares it against the MTU, to guarantee that there's enough > space to store the data. It calculates that

Re: [dpdk-dev] [PATCH v2 2/3] net/af_packet: move parse and validation of iface

2018-11-27 Thread Ferruh Yigit
On 11/20/2018 10:26 AM, Tiago Lam wrote: > Instead of re-iterating through kvlist just to parse the > ETH_AF_PACKET_IFACE_ARG argument in rte_pmd_init_internals(), we now use > the already existing iteration in rte_eth_from_packet() to parse and > validate the ETH_AF_PACKET_IFACE_ARG argument. +1

Re: [dpdk-dev] CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES: no difference in memory pool allocations, when enabling/disabling this configuration

2018-11-27 Thread Ilya Maximets
On 27.11.2018 13:33, Burakov, Anatoly wrote: > On 27-Nov-18 10:26 AM, Hemant Agrawal wrote: >> >> On 11/26/2018 8:55 PM, Asaf Sinai wrote: >>> +CC Ilia & Sasha. >>> >>> -Original Message- >>> From: Burakov, Anatoly >>> Sent: Monday, November 26, 2018 04:57 PM >>> To: Ilya Maximets ; Asaf S

Re: [dpdk-dev] [PATCH] app/testpmd: fix mpls bos bit default value

2018-11-27 Thread Ferruh Yigit
On 11/21/2018 2:55 PM, Ori Kam wrote: > >> -Original Message- >> From: Saleh Alsouqi >> Sent: Wednesday, November 21, 2018 4:47 PM >> To: wenzhuo...@intel.com; jingjing...@intel.com; >> bernard.iremon...@intel.com >> Cc: dev@dpdk.org; Ori Kam ; sta...@dpdk.org >> Subject: [PATCH] app/testp

Re: [dpdk-dev] [PATCH] net/vdev_netvsc: get rid of unnecessary debug log message

2018-11-27 Thread Ferruh Yigit
On 11/27/2018 4:18 PM, Matan Azrad wrote: > > > From: Stephen Hemminger >> If vdev_netvsc is run with debug logging enabled, then the log output will >> fill >> with: >> net_vdev_netvsc: interface lo is non-ethernet device >> >> Remove the message since it is not useful. >> >> Signed-off-b

Re: [dpdk-dev] [PATCH] net/vdev_netvsc: get rid of unnecessary debug log message

2018-11-27 Thread Matan Azrad
From: Stephen Hemminger > If vdev_netvsc is run with debug logging enabled, then the log output will > fill > with: > net_vdev_netvsc: interface lo is non-ethernet device > > Remove the message since it is not useful. > > Signed-off-by: Stephen Hemminger Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH v2 1/2] net/bnx2x: cleanup info logs

2018-11-27 Thread Ferruh Yigit
On 11/17/2018 9:37 AM, Mody, Rasesh wrote: > Reduced number of INFO logs in BNX2X PMD by converting some INFO > logs to DEBUG and few NOTICE logs to INFO, removing extra new lines, > printing banner bar once for the adapter and device specific info. > > Fixes: ba7eeb035a5f ("net/bnx2x: fix logging

[dpdk-dev] [PATCH 3/3] lib/librte_meter: update abi to include new rfc4115 function

2018-11-27 Thread Eelco Chaudron
Update the ABI to include the new RFC4115 meter functions --- lib/librte_meter/Makefile |2 +- lib/librte_meter/meson.build |2 +- lib/librte_meter/rte_meter_version.map |9 + 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/lib/librte_mete

[dpdk-dev] [PATCH 1/3] lib/librte_meter: add RFC4115 trTCM meter support

2018-11-27 Thread Eelco Chaudron
This patch adds support for RFC4115 trTCM meters. Signed-off-by: Eelco Chaudron --- lib/librte_meter/rte_meter.c | 40 + lib/librte_meter/rte_meter.h | 193 +++--- 2 files changed, 217 insertions(+), 16 deletions(-) diff --git a/lib/librte_meter/rt

[dpdk-dev] [PATCH 0/3] lib/librte_meter: add RFC4115 trTCM meter support

2018-11-27 Thread Eelco Chaudron
This patch adds support for RFC4115 trTCM meters. Signed-off-by: Eelco Chaudron Eelco Chaudron (3): lib/librte_meter: add RFC4115 trTCM meter support test/test_meter: update meter test to include RFC4115 meters lib/librte_meter: update abi to include new rfc4115 function li

[dpdk-dev] [PATCH 2/3] test/test_meter: update meter test to include RFC4115 meters

2018-11-27 Thread Eelco Chaudron
Add test cases for RFC4115 meters Signed-off-by: Eelco Chaudron --- test/test/test_meter.c | 212 1 file changed, 212 insertions(+) diff --git a/test/test/test_meter.c b/test/test/test_meter.c index 8bb47e75c..097da0143 100644 --- a/test/test/te

Re: [dpdk-dev] [PATCH] lib/compress: fix incorrect structure comment

2018-11-27 Thread Trahe, Fiona
> -Original Message- > From: Daly, Lee > Sent: Tuesday, November 27, 2018 8:10 AM > To: Trahe, Fiona > Cc: dev@dpdk.org; Daly, Lee ; sta...@dpdk.org > Subject: [PATCH] lib/compress: fix incorrect structure comment > > Fixes incorrect comment on compressdev rte_comp_op structure element

[dpdk-dev] [PATCH] lib/compress: fix incorrect structure comment

2018-11-27 Thread Lee Daly
Fixes incorrect comment on compressdev rte_comp_op structure element. Comment needed to be updated to be compliant with the use of chained mbufs. Fixes: f87bdc1ddcf4 ("compressdev: add compression specific data") Cc: sta...@dpdk.org Cc: fiona.tr...@intel.com Signed-off-by: Lee Daly --- lib/libr

Re: [dpdk-dev] [RFC] DFS (DPDK Filesystem)

2018-11-27 Thread Wiles, Keith
> On Oct 8, 2018, at 5:42 PM, Wiles, Keith wrote: > > Hi Everyone, > > I would like to request comments on DFS as I presented at the DPDK summit in > Ireland. > > As we know DPDK can be difficult to manage at run time and as DPDK becomes > more dynamic we need to address how to configure a

Re: [dpdk-dev] [PATCH] net/virtio: allocate vrings on device NUMA node

2018-11-27 Thread Maxime Coquelin
On 11/27/18 2:29 PM, David Marchand wrote: On Tue, Nov 27, 2018 at 11:54 AM Maxime Coquelin mailto:maxime.coque...@redhat.com>> wrote: When a guest is spanned on multiple NUMA nodes and multiple Virtio devices are spanned onto these nodes, we expect that their ring memory is allo

Re: [dpdk-dev] [PATCH v3 0/2] IOPL related fixes

2018-11-27 Thread David Marchand
On Sun, Nov 25, 2018 at 11:42 AM Thomas Monjalon wrote: > 23/11/2018 23:29, Thomas Monjalon: > > 23/11/2018 21:07, Kevin Traynor: > > > On 11/23/2018 04:25 PM, Maxime Coquelin wrote: > > > > On 11/23/18 4:53 PM, Ilya Maximets wrote: > > > >> On 23.11.2018 18:41, Maxime Coquelin wrote: > > > >>> O

Re: [dpdk-dev] [PATCH] kni: Fix build on RHEL 8

2018-11-27 Thread Ferruh Yigit
On 11/27/2018 11:13 AM, Mohammed Gamal wrote: > On Tue, 2018-11-27 at 10:55 +, Ferruh Yigit wrote: >> On 11/26/2018 8:45 PM, Mohammed Gamal wrote: >>> As RHEL8 beta has been released and is based on recent upstream >>> kernels >>> which don't use ndo_change_mtu_rh74 function. Fix the build so t

Re: [dpdk-dev] [PATCH] net/virtio: allocate vrings on device NUMA node

2018-11-27 Thread David Marchand
On Tue, Nov 27, 2018 at 11:54 AM Maxime Coquelin wrote: > When a guest is spanned on multiple NUMA nodes and > multiple Virtio devices are spanned onto these nodes, > we expect that their ring memory is allocated in the > right memory node. > > Signed-off-by: Maxime Coquelin > --- > drivers/net

Re: [dpdk-dev] [PATCH] test/compress: improve debug trace setup

2018-11-27 Thread Jozwiak, TomaszX
> -Original Message- > From: Daly, Lee > Sent: Monday, November 19, 2018 2:53 PM > To: Trahe, Fiona ; Jozwiak, TomaszX > > Cc: dev@dpdk.org; Daly, Lee > Subject: [PATCH] test/compress: improve debug trace setup > > This removes the magic number from the assignment of the engine variab

[dpdk-dev] [Bug 111] There maybe some risks to printf the addr of the map page

2018-11-27 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=111 Bug ID: 111 Summary: There maybe some risks to printf the addr of the map page Product: DPDK Version: 17.11 Hardware: All OS: All Status: UNCONFIRMED

Re: [dpdk-dev] [PATCH] kni: Fix build on RHEL 8

2018-11-27 Thread Mohammed Gamal
On Tue, 2018-11-27 at 10:55 +, Ferruh Yigit wrote: > On 11/26/2018 8:45 PM, Mohammed Gamal wrote: > > As RHEL8 beta has been released and is based on recent upstream > > kernels > > which don't use ndo_change_mtu_rh74 function. Fix the build so that > > it > > doesn't fail because the function

Re: [dpdk-dev] [PATCH] pkg: remove RPM recipe

2018-11-27 Thread Bruce Richardson
On Mon, Nov 26, 2018 at 09:26:59PM +0100, Thomas Monjalon wrote: > This RPM recipe is not well maintained and probably not used a lot. > Each distribution has its own constraints and recipes. > It may not be a good idea to try maintaining packaging recipes in > the project itself. > > Signed-off-b

Re: [dpdk-dev] [PATCH] kni: Fix build on RHEL 8

2018-11-27 Thread Ferruh Yigit
On 11/26/2018 8:45 PM, Mohammed Gamal wrote: > As RHEL8 beta has been released and is based on recent upstream kernels > which don't use ndo_change_mtu_rh74 function. Fix the build so that it > doesn't fail because the function is missing > > Signed-off-by: Mohammed Gamal > --- > kernel/linux/kn

[dpdk-dev] [PATCH] net/virtio: allocate vrings on device NUMA node

2018-11-27 Thread Maxime Coquelin
When a guest is spanned on multiple NUMA nodes and multiple Virtio devices are spanned onto these nodes, we expect that their ring memory is allocated in the right memory node. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 12 +++- 1 file changed, 7 insertions(+

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] mem: Fix anonymous mapping on Power9.

2018-11-27 Thread Kevin Traynor
On 11/18/2018 01:41 PM, Thomas Monjalon wrote: > 16/11/2018 18:35, David Wilder: >> Removed the use of MAP_HUGETLB for anonymous mapping on ppc64. The >> MAP_HUGETLB had previously been added to workaround issues on IBM Power8 >> systems when mapping /dev/zero (see: commit >> 284ae3e9ff9a92575c28c

Re: [dpdk-dev] struct malloc_elem overrun/corruption

2018-11-27 Thread Burakov, Anatoly
On 27-Nov-18 10:38 AM, Burakov, Anatoly wrote: On 26-Nov-18 11:44 PM, He Huang wrote: Hi, I’ve been troubleshooting a possible memory allocator corruption: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fffefdf0700 (LWP 1079)] 0x004794ee in malloc_elem_free

Re: [dpdk-dev] struct malloc_elem overrun/corruption

2018-11-27 Thread Burakov, Anatoly
On 26-Nov-18 11:44 PM, He Huang wrote: Hi, I’ve been troubleshooting a possible memory allocator corruption: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fffefdf0700 (LWP 1079)] 0x004794ee in malloc_elem_free_list_insert (elem=0x7ff82d265000) at dpdk/lib/

Re: [dpdk-dev] CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES: no difference in memory pool allocations, when enabling/disabling this configuration

2018-11-27 Thread Burakov, Anatoly
On 27-Nov-18 10:26 AM, Hemant Agrawal wrote: On 11/26/2018 8:55 PM, Asaf Sinai wrote: +CC Ilia & Sasha. -Original Message- From: Burakov, Anatoly Sent: Monday, November 26, 2018 04:57 PM To: Ilya Maximets ; Asaf Sinai ; dev@dpdk.org; Thomas Monjalon Subject: Re: [dpdk-dev] CONFIG_RT

[dpdk-dev] [PATCH v2] test/compress: add mbuf offset unit test

2018-11-27 Thread Lee Daly
added mbuf offset test to compressdev test suite, which tests compression/ decompression with a mbuf containing an offset spanning across mulitple segments Signed-off-by: Lee Daly --- test/test/test_compressdev.c | 241 ++- 1 file changed, 193 insertions(+

Re: [dpdk-dev] [PATCH v2] vhost: fix possible null pointer dereferencing

2018-11-27 Thread Jens Freimann
On Tue, Nov 27, 2018 at 10:54:51AM +0100, Maxime Coquelin wrote: If mmap() call fails in vhost_user_set_mem_table, dev->mem is set to NULL. If later, qva_to_vva() is called, a segfault occurs. Fixes: 8f972312b8f4 ("vhost: support vhost-user") Cc: sta...@dpdk.org Reviewed-by: Tiwei Bie Signed-o

Re: [dpdk-dev] CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES: no difference in memory pool allocations, when enabling/disabling this configuration

2018-11-27 Thread Hemant Agrawal
On 11/26/2018 8:55 PM, Asaf Sinai wrote: > +CC Ilia & Sasha. > > -Original Message- > From: Burakov, Anatoly > Sent: Monday, November 26, 2018 04:57 PM > To: Ilya Maximets ; Asaf Sinai ; > dev@dpdk.org; Thomas Monjalon > Subject: Re: [dpdk-dev] CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES: no di

[dpdk-dev] [PATCH v2] vhost: fix possible null pointer dereferencing

2018-11-27 Thread Maxime Coquelin
If mmap() call fails in vhost_user_set_mem_table, dev->mem is set to NULL. If later, qva_to_vva() is called, a segfault occurs. Fixes: 8f972312b8f4 ("vhost: support vhost-user") Cc: sta...@dpdk.org Reviewed-by: Tiwei Bie Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 6

Re: [dpdk-dev] [PATCH] vhost: fix possible null pointer dereferencing

2018-11-27 Thread Maxime Coquelin
On 11/27/18 10:44 AM, Tiwei Bie wrote: On Tue, Nov 27, 2018 at 10:23:25AM +0100, Maxime Coquelin wrote: If mmap() call fails in vhost_user_set_mem_table, dev->mem is set to NULL. If later, qva_to_vva() is called, a segfault occurs. Fixes: 8f972312b8f4 ("vhost: support vhost-user") Cc: sta...

Re: [dpdk-dev] [PATCH] vhost: fix possible null pointer dereferencing

2018-11-27 Thread Tiwei Bie
On Tue, Nov 27, 2018 at 10:23:25AM +0100, Maxime Coquelin wrote: > If mmap() call fails in vhost_user_set_mem_table, dev->mem > is set to NULL. If later, qva_to_vva() is called, a segfault > occurs. > > Fixes: 8f972312b8f4 ("vhost: support vhost-user") > Cc: sta...@dpdk.org > > Signed-off-by: Max

Re: [dpdk-dev] [PATCH v2] mlx5: Report imissed stat

2018-11-27 Thread Tom Barbette
> Tom - please have a second look and confirm. Looks good. I tried next-net-mlx and it works fine. My imissed increases as expected, rx_discards_phy also (sadly). Thanks, Tom

[dpdk-dev] [PATCH] vhost: fix possible null pointer dereferencing

2018-11-27 Thread Maxime Coquelin
If mmap() call fails in vhost_user_set_mem_table, dev->mem is set to NULL. If later, qva_to_vva() is called, a segfault occurs. Fixes: 8f972312b8f4 ("vhost: support vhost-user") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 3 +++ 1 file changed, 3 inser

Re: [dpdk-dev] [PATCH v2] mlx5: Report imissed stat

2018-11-27 Thread Shahaf Shuler
Friday, November 23, 2018 10:04 AM, Friday, November 23, 2018: > Subject: [PATCH v2] mlx5: Report imissed stat > > The imissed counters (number of packets dropped because the queues were > full) were actually reported through xstats as "rx_out_of_buffer" > but was not reported through stats. > >