Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of AndyPei
> Sent: Friday, December 14, 2018 2:33
> To: dev@dpdk.org
> Cc: Pei, Andy
> Subject: [dpdk-dev] [PATCH] Fix a memnory leak bug due to malloc
> unproperly.
Miss some descriptions about this patch.
> S
The framecnt option represents a counter (integer) that does not
reflect size. It is somewhat parallel in this sense to the framecount
member of pkt_rx_queue/pkt_tx_queue (or tp_frame_nr in tpacket_req).
This patch removes the size indicator of bytes ("B") from framecnt in
the af_packet guide.
On 12/14/2018 9:52 PM, Amr Mokhtar wrote:
> some application facing functions are missing from
> the map file. these are added by this patch.
>
> Signed-off-by: Amr Mokhtar
> ---
> lib/librte_bbdev/rte_bbdev_version.map | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/librte_b
On Mon, 17 Dec 2018 22:13:19 +
Ferruh Yigit wrote:
> On 12/14/2018 1:26 AM, Stephen Hemminger wrote:
> > Minor updates to netvsc driver.
> >
> > Stephen Hemminger (3):
> > net/netvsc: support receive without vlan strip
> > net/netvsc: cleanup transmit descriptor pool
> > net/netvsc: no
On Tue, 18 Dec 2018 04:30:39 +
Honnappa Nagarahalli wrote:
> >
> > On 11-Dec-18 6:40 AM, Honnappa Nagarahalli wrote:
> > >>
> > >
> > >>> +
> > >>> +/* Add a reader thread, running on an lcore, to the list of
> > >>> +threads
> > >>> + * reporting their quiescent st
On Tue, Dec 18, 2018 at 02:52:16PM +0900, Hideyuki Yamashita wrote:
> > On Tue, Dec 18, 2018 at 12:11:33PM +0900, Hideyuki Yamashita wrote:
> > >
> > > On Mon, Dec 17, 2018 at 11:21:01AM +, Burakov, Anatoly wrote:
> > > > > On 17-Dec-18 10:45 AM, Hideyuki Yamashita wrote:
> > > > > > > On 17-D
> On Tue, Dec 18, 2018 at 12:11:33PM +0900, Hideyuki Yamashita wrote:
> >
> > On Mon, Dec 17, 2018 at 11:21:01AM +, Burakov, Anatoly wrote:
> > > > On 17-Dec-18 10:45 AM, Hideyuki Yamashita wrote:
> > > > > > On 17-Dec-18 10:02 AM, Hideyuki Yamashita wrote:
> > > > > > > Dear Thomas and all,
>
On Tue, Dec 18, 2018 at 12:11:33PM +0900, Hideyuki Yamashita wrote:
>
> On Mon, Dec 17, 2018 at 11:21:01AM +, Burakov, Anatoly wrote:
> > > On 17-Dec-18 10:45 AM, Hideyuki Yamashita wrote:
> > > > > On 17-Dec-18 10:02 AM, Hideyuki Yamashita wrote:
> > > > > > Dear Thomas and all,
> > > > > >
>
> On 11-Dec-18 6:40 AM, Honnappa Nagarahalli wrote:
> >>
> >
> >>> +
> >>> +/* Add a reader thread, running on an lcore, to the list of
> >>> +threads
> >>> + * reporting their quiescent state on a TQS variable.
> >>> + */
> >>> +int __rte_experimental
> >>> +rte_
The GRO library requires that applications set correct values for
MBUF->l2_len/l3_len/l4_len/outer_l2_len/outer_l3_len/pkt_len/data_len.
This patch adds the requirement in prog_guide.
Signed-off-by: Jiayu Hu
---
doc/guides/prog_guide/generic_receive_offload_lib.rst | 6 ++
1 file changed, 6
Hi Ferruh,
> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, December 18, 2018 7:47 AM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Yang, Qiming ; Li, Xiaoyun
> ; Wu, Jingjing
> Subject: Re: [dpdk-dev] [PATCH v5 30/31] net/ice: support advance RX/TX
>
> On 12/17/2018 7:37 AM, Wenzhuo
> On Mon, Dec 17, 2018 at
11:21:01AM +, Burakov, Anatoly wrote:
> > On 17-Dec-18 10:45 AM, Hideyuki Yamashita wrote:
> > > > On 17-Dec-18 10:02 AM, Hideyuki Yamashita wrote:
> > > > > Dear Thomas and all,
> > > > >
> > > > > I took a look on d
Hi Ferruh,
> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, December 18, 2018 7:03 AM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Yang, Qiming ; Li, Xiaoyun
> ; Wu, Jingjing
> Subject: Re: [dpdk-dev] [PATCH v5 30/31] net/ice: support advance RX/TX
>
> On 12/17/2018 7:37 AM, Wenzhu
Hi Ferruh,
> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, December 18, 2018 6:59 AM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Yang, Qiming ; Li, Xiaoyun
> ; Wu, Jingjing
> Subject: Re: [dpdk-dev] [PATCH v5 29/31] net/ice: support basic RX/TX
>
> On 12/17/2018 7:37 AM, Wenzhuo
On Mon, Dec 17, 2018 at 11:21:01AM +, Burakov, Anatoly wrote:
> On 17-Dec-18 10:45 AM, Hideyuki Yamashita wrote:
> > > On 17-Dec-18 10:02 AM, Hideyuki Yamashita wrote:
> > > > Dear Thomas and all,
> > > >
> > > > I took a look on dpdk code.
> > > > I firstly write qustions and my analisys
> >
Hi,
We can not get your attachment at all.
VLAN STRIP is done by hardware NIC, not DPDK software.
BUT you can check the flag of packets output from rte_eth_rx_burst(),
Check bit of PKT_RX_VLAN in rxm->ol_flags. Only if this bit is set
rxm->vlan_tci is valid.
For IMCP packet, maybe it is n
On 4/29/2015 12:46 AM, rkerur at gmail.com (Ravi Kerur) wrote:
> Changes in v8
> None
>
> Changes in v7
> Rebase to latest code.
>
> Changes in v6
> Split changes due to complexity. v6 includes moving
> rte_eal_pci_probe_one_driver function and its associated
> utility functions only.
>
> Change
Hi,
I am relatively new to DPDK and am trying to use the eventdev library.
The sw_evdev runs on a single core (service core). And then there is
rte_event_eth_rx_adapter_ which links the sw_evdev to the ethdev. This adapter
is also service core based. The DSW runs on all cores – and thus doesn’t u
> -Original Message-
> From: Yigit, Ferruh
> Sent: Monday, December 17, 2018 10:28 PM
> To: Yan, Zhirun ; dev@dpdk.org; Zhang, Qi Z
>
> Cc: Wang, Haiyue
> Subject: Re: [dpdk-dev] [PATCH v5 1/2] net/i40e: support VF request more
> queues
>
> On 12/17/2018 11:10 AM, Zhirun Yan wrote:
> >
On 12/18/2018 1:42 AM, Ferruh Yigit wrote:
> On 4/29/2015 12:46 AM, rkerur at gmail.com (Ravi Kerur) wrote:
>> Changes in v8
>> Fix ABI warnings by reordering compilation of
>> eal_common_sysfs.c
>> eal_common_mem_cfg.c
>> eal_common_proc_type.c
>> eal_common_app_usage.c
>>
>> Changes in v7
>> Fix
On 4/29/2015 12:46 AM, rkerur at gmail.com (Ravi Kerur) wrote:
> Changes in v8
> Fix ABI warnings by reordering compilation of
> eal_common_sysfs.c
> eal_common_mem_cfg.c
> eal_common_proc_type.c
> eal_common_app_usage.c
>
> Changes in v7
> Fix compilation errors in clang.
>
> Changes in v6
> Spl
Hi Ferruh,
> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, December 18, 2018 7:16 AM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Yang, Qiming ; Li, Xiaoyun
> ; Wu, Jingjing
> Subject: Re: [dpdk-dev] [PATCH v5 15/31] net/ice: support device
> initialization
>
> > +static struct rt
Hi Ferruh,
> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, December 18, 2018 7:48 AM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Yang, Qiming ; Li, Xiaoyun
> ; Wu, Jingjing
> Subject: Re: [dpdk-dev] [PATCH v5 16/31] net/ice: support device and queue
> ops
>
> On 12/17/2018 7:37 A
Hi Ferruh,
> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, December 18, 2018 6:29 AM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Yang, Qiming ; Li, Xiaoyun
> ; Wu, Jingjing
> Subject: Re: [dpdk-dev] [PATCH v5 15/31] net/ice: support device
> initialization
>
> On 12/17/2018 7:37 A
On 12/18/2018 12:31 AM, Ferruh Yigit wrote:
> On 12/17/2018 9:14 AM, Tiago Lam wrote:
>> As of commit 364e08f2bbc0, DPDK allows an aplication to send and receive
>> raw packets using an AF_PACKET and PACKET_MMAP, when using a Linux
>> Kernel. This complements it by adding a simple guide with the fo
On 12/17/2018 9:14 AM, Tiago Lam wrote:
> As of commit 364e08f2bbc0, DPDK allows an aplication to send and receive
> raw packets using an AF_PACKET and PACKET_MMAP, when using a Linux
> Kernel. This complements it by adding a simple guide with the following
> information:
> - An introduction, where
On 12/16/2018 12:58 AM, Qi Zhang wrote:
> Improved testpmd macswap performance for x86 by take advantage of SSE
> instructions.
> On a broadwell 1.6GHz sever with a i40e 25G NIC.
> We abserve 17.7% performance improvement for testpmd's macswap test.
>
> v3:
> - fix wrong comment after #endif.
> -
On 12/17/2018 3:42 PM, Rami Rosen wrote:
> On Fri, 14 Dec 2018 at 18:43, Jeff Shaw wrote:
>>
>> Prior to this patch, the two affected .c files include
>> unnecessarily. This commit removes the include lines.
>>
>> Signed-off-by: Jeff Shaw
>
> Reviewed-by: Rami Rosen
>
Reviewed-by: Ferruh Yigi
On 12/17/2018 7:37 AM, Wenzhuo Lu wrote:
> Normally when starting/stopping the device the queue
> should be started and stopped. Support them both in
> this patch.
>
> Below ops are added,
> dev_configure
> dev_start
> dev_stop
> dev_close
> dev_reset
> rx_queue_start
> rx_queue_stop
> tx_queue_st
On 12/17/2018 7:37 AM, Wenzhuo Lu wrote:
> Add RX functions, scatter and bulk.
> Add TX function, simple.
>
> Signed-off-by: Wenzhuo Lu
> Signed-off-by: Qiming Yang
> Signed-off-by: Xiaoyun Li
> Signed-off-by: Jingjing Wu
<>
> + rxdp = &rxq->rx_ring[alloc_idx];
> + for (i = 0; i
On 12/17/2018 7:36 PM, Mattias Rönnblom wrote:
> On 2018-12-17 10:41, Dumitrescu, Cristian wrote:
>>
>>
>>> -Original Message-
>>> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
>>> Sent: Saturday, December 15, 2018 2:16 PM
>>> To: Ananyev, Konstantin ; Pattan, Reshma
>>> ; d
> +static struct rte_pci_driver rte_ice_pmd = {
> + .id_table = pci_id_ice_map,
> + .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,
Is "RTE_PCI_DRV_IOVA_AS_VA" not added intentionally?
17/12/2018 19:51, Dumitrescu, Cristian:
> From: Pattan, Reshma
> > From: Ananyev, Konstantin
> > > From: Dumitrescu, Cristian
> > > > From: Ananyev, Konstantin
> > > > > > --- /dev/null
> > > > > > +++ b/lib/librte_eal/common/include/rte_color.h
> > > > > > +enum rte_color {
> > > > > > + RTE_COL
On 12/17/2018 7:37 AM, Wenzhuo Lu wrote:
> Signed-off-by: Wenzhuo Lu
> Signed-off-by: Qiming Yang
> Signed-off-by: Xiaoyun Li
> Signed-off-by: Jingjing Wu
<...>
> +
> + /* Descriptor based VLAN insertion */
> + if (ol_flags & (PKT_TX_VLAN_PKT | PKT_TX_QINQ_PKT)) {
PKT
On 12/17/2018 7:37 AM, Wenzhuo Lu wrote:
> Add RX functions, scatter and bulk.
> Add TX function, simple.
>
> Signed-off-by: Wenzhuo Lu
> Signed-off-by: Qiming Yang
> Signed-off-by: Xiaoyun Li
> Signed-off-by: Jingjing Wu
<...>
> +ice_tx_free_bufs(struct ice_tx_queue *txq)
> +{
> + struc
On 12/17/2018 7:37 AM, Wenzhuo Lu wrote:
> Add below ops,
> reta_update
> reta_query
> rss_hash_update
> rss_hash_conf_get
>
> Signed-off-by: Wenzhuo Lu
> Signed-off-by: Qiming Yang
> Signed-off-by: Xiaoyun Li
> Signed-off-by: Jingjing Wu
> ---
> doc/guides/nics/features/ice.ini | 3 +
> dr
On 12/17/2018 7:37 AM, Wenzhuo Lu wrote:
> Add below ops,
> ice_vlan_filter_set
> ice_vlan_offload_set
> ice_vlan_tpid_set
> ice_vlan_pvid_set
>
> Signed-off-by: Wenzhuo Lu
> Signed-off-by: Qiming Yang
> Signed-off-by: Xiaoyun Li
> Signed-off-by: Jingjing Wu
> ---
> doc/guides/nics/features/i
On 12/17/2018 7:37 AM, Wenzhuo Lu wrote:
> Update the documents too.
>
> Signed-off-by: Wenzhuo Lu
> Signed-off-by: Qiming Yang
> Signed-off-by: Xiaoyun Li
> Signed-off-by: Jingjing Wu
> ---
> MAINTAINERS | 2 +
> config/common_base | 7 +
>
On 12/14/2018 1:26 AM, Stephen Hemminger wrote:
> Minor updates to netvsc driver.
>
> Stephen Hemminger (3):
> net/netvsc: support receive without vlan strip
> net/netvsc: cleanup transmit descriptor pool
> net/netvsc: not finding VF should not cause failure
Series applied to dpdk-next-net/
On 12/17/2018 10:11 PM, Ferruh Yigit wrote:
> On 12/17/2018 7:59 PM, Stephen Hemminger wrote:
>> This can go to 18.11 stable
>
> I will add fixes and stable tags while merging, please provide them with
> commit
> to ensure the backport of the patches to the stable trees.
Added:
Fixes: dc768
On 12/17/2018 10:46 AM, Ferruh Yigit wrote:
> On 12/14/2018 1:26 AM, Stephen Hemminger wrote:
>> On device close or startup errors, the transmit descriptor pool
>> was being left behind.
>
> So this is fixing possible memory leak, should this be an "fix" commit, so
> that
> it can be backported t
On 12/17/2018 7:59 PM, Stephen Hemminger wrote:
> This can go to 18.11 stable
I will add fixes and stable tags while merging, please provide them with commit
to ensure the backport of the patches to the stable trees.
>
> -Original Message-
> From: Ferruh Yigit
> Sent: Monday, December
Signed-off-by: Jens Freimann
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtio_ethdev.h | 1 +
drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_ethdev.h
b/drivers/net/virtio/v
Until we have support for control virtqueues let's disable it and
fail device initalization if specified as a parameter.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vi
From: Yuanhan Liu
Add option to enable packed queue support for virtio-user
devices.
Signed-off-by: Yuanhan Liu
Reviewed-by: Maxime Coquelin
---
.../net/virtio/virtio_user/virtio_user_dev.c | 18 ++
.../net/virtio/virtio_user/virtio_user_dev.h | 2 +-
drivers/net/virtio/v
This implements the transmit path for devices with
support for packed virtqueues.
Signed-off-by: Jens Freiman
Signed-off-by: Tiwei Bie
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtio_ethdev.c | 56 ---
drivers/net/virtio/virtio_ethdev.h | 2 +
drivers/net/virtio/virtio_rxtx.c
Add and initialize descriptor data structures.
Signed-off-by: Jens Freimann
Signed-off-by: Tiwei Bie
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtio_ethdev.c | 32 --
drivers/net/virtio/virtio_ring.h | 28 ++
drivers/net/virtio/v
Add helper functions to set/clear and check descriptor flags.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_pci.h | 6 +++
drivers/net/virtio/virtqueue.h | 72 -
2 files changed, 76 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio/virt
Signed-off-by: Jens Freimann
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtio_pci.h | 1 +
drivers/net/virtio/virtio_ring.h | 30 ++
drivers/net/virtio/virtqueue.h | 6 ++
3 files changed, 37 insertions(+)
diff --git a/drivers/net/virtio/virtio_pci
Implement the receive part.
Signed-off-by: Jens Freimann
Signed-off-by: Tiwei Bie
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtio_ethdev.c | 56 +++--
drivers/net/virtio/virtio_ethdev.h | 5 +
drivers/net/virtio/virtio_rxtx.c | 375 -
drivers/net/vir
Use packed virtqueue format when reading and writing descriptors
to/from the ring.
Signed-off-by: Jens Freimann
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtio_ethdev.c | 96 ++
1 file changed, 96 insertions(+)
diff --git a/drivers/net/virtio/virtio_ethde
Add support to dump packed virtqueue data to the
VIRTQUEUE_DUMP() macro.
Signed-off-by: Jens Freimann
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtqueue.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
inde
This is a basic implementation of packed virtqueues as specified in the
Virtio 1.1 draft. A compiled version of the current draft is available
at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at
https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd10.pdf
A packed
On Mon, 2018-12-17 at 10:09 +0530, Nikhil Rao wrote:
> rte_event_eth_tx_adapter_queue_add() - add a check
> that returns an error if the ethdev has zero Tx queues
> configured.
>
> rte_event_eth_tx_adapter_queue_del() - remove the
> checks for ethdev queue count, instead check for
> queues added t
13/12/2018 19:08, Reshma Pattan:
> Added new rte_color definition in eal to
> consolidate color definition which is currently replicated
> in various places such as rte_meter.h, rte_tm.h and rte_mtr.h
I don't think EAL is the right place for such definition.
Why ethdev would not rely on definition
Hi Fan,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang
> Sent: Tuesday, December 11, 2018 3:34 AM
> To: dev@dpdk.org
> Cc: akhil.go...@nxp.com; Ananyev, Konstantin
> Subject: [dpdk-dev] [PATCH v2 2/2] cryptodev: change symmetric session
> structure
On 2018-12-17 10:41, Dumitrescu, Cristian wrote:
-Original Message-
From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
Sent: Saturday, December 15, 2018 2:16 PM
To: Ananyev, Konstantin ; Pattan, Reshma
; dev@dpdk.org; Dumitrescu, Cristian
; jerin.ja...@caviumnetworks.com; Si
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang
> Sent: Tuesday, December 11, 2018 3:34 AM
> To: dev@dpdk.org
> Cc: akhil.go...@nxp.com; Ananyev, Konstantin
> Subject: [dpdk-dev] [PATCH v2 1/2] cryptodev: change queue pair configure
> structure
>
On Mon, Dec 17, 2018 at 05:52:08PM +0100, Maxime Coquelin wrote:
I think you meant control queue in the title?
On 12/14/18 4:59 PM, Jens Freimann wrote:
Until we have support for ctrl virtqueues let's disable it and
fail device initalization if specified as a parameter.
Signed-off-by: Jens Fre
On Mon, 2018-12-17 at 16:26 +, Wiles, Keith wrote:
> > On Dec 16, 2018, at 4:22 PM, Luca Boccassi
> > wrote:
> >
> > On Sun, 2018-12-16 at 11:46 -0600, Keith Wiles wrote:
> > > --- /dev/null
> > > +++ b/lib/librte_dfs/meson.build
> > > @@ -0,0 +1,47 @@
> > > +# SPDX-License-Identifier: BSD-3-
On 12/17/18 3:41 PM, Wang, Xiao W wrote:
Thanks for the confirmation.
Please note that CI reports a checkpatch issue:
http://patches.dpdk.org/patch/48935/
Thanks,
Maxime
BRs,
Xiao
-Original Message-
From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
Sent: Monday, December
> -Original Message-
> From: Pattan, Reshma
> Sent: Monday, December 17, 2018 5:15 PM
> To: Ananyev, Konstantin ; Dumitrescu,
> Cristian ; dev@dpdk.org;
> jerin.ja...@caviumnetworks.com; Singh, Jasvinder
>
> Subject: RE: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition
>
>
Hi Shally, Arek,
> -Original Message-
> From: Kusztal, ArkadiuszX
> Sent: Monday, December 17, 2018 7:25 AM
> To: Verma, Shally
> Cc: dev@dpdk.org; Trahe, Fiona ; Doherty, Declan
> ; Kanaka Durga Kotamarthy
> ; Sunila Sahu
> ; Kotamarthy, Kanaka ; Sahu,
> Sunila
> ; Cel, TomaszX ; Jozwi
27/11/2018 12:09, Bruce Richardson:
> On Mon, Nov 26, 2018 at 09:26:59PM +0100, Thomas Monjalon wrote:
> > This RPM recipe is not well maintained and probably not used a lot.
> > Each distribution has its own constraints and recipes.
> > It may not be a good idea to try maintaining packaging recipe
https://bugs.dpdk.org/show_bug.cgi?id=165
Bug ID: 165
Summary: checkpatches.sh doesn't detect rte_exit() /
rte_panic() instances
Product: DPDK
Version: 18.11
Hardware: All
OS: All
Status: CONFIRM
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Monday, December 17, 2018 11:21 AM
> To: Dumitrescu, Cristian ; Pattan, Reshma
> ; dev@dpdk.org;
> jerin.ja...@caviumnetworks.com; Singh, Jasvinder
>
> Cc: Pattan, Reshma
> Subject: RE: [dpdk-dev] [PATCH v2 2/3] eal: add new rte
On 12/14/18 4:59 PM, Jens Freimann wrote:
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.h | 1 +
drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
I think you meant control queue in the title?
On 12/14/18 4:59 PM, Jens Freimann wrote:
Until we have support for ctrl virtqueues let's disable it and
fail device initalization if specified as a parameter.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_user/virtio_user_dev.c | 10
On 12/14/18 4:59 PM, Jens Freimann wrote:
From: Yuanhan Liu
Add option to enable packed queue support for virtio-user
devices.
Signed-off-by: Yuanhan Liu
---
.../net/virtio/virtio_user/virtio_user_dev.c | 18 ++
.../net/virtio/virtio_user/virtio_user_dev.h | 2 +-
On 12/14/18 4:59 PM, Jens Freimann wrote:
Use packed virtqueue format when reading and writing descriptors
to/from the ring.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.c | 90 ++
1 file changed, 90 insertions(+)
Reviewed-by: Maxime Coque
On 12/14/18 4:59 PM, Jens Freimann wrote:
Implement the receive part.
Signed-off-by: Jens Freimann
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 58 +++--
drivers/net/virtio/virtio_ethdev.h | 5 +
drivers/net/virtio/virtio_rxtx.c | 375 ++
On 12/17/2018 10:57 AM, Ferruh Yigit wrote:
> On 12/14/2018 4:59 PM, Kevin Traynor wrote:
>> On 12/03/2018 08:07 AM, Zhang, Qi Z wrote:
>>>
>>>
-Original Message-
From: Li, Xiaoyun
Sent: Monday, December 3, 2018 3:08 PM
To: Zhang, Qi Z
Cc: dev@dpdk.org; Li, Xiaoyun
On 12/14/18 4:59 PM, Jens Freimann wrote:
This implements the transmit path for devices with
support for packed virtqueues.
Signed-off-by: Jens Freiman
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 57 ---
drivers/net/virtio/virtio_ethdev.h | 2 +
drivers/net/
On 12/14/18 4:59 PM, Jens Freimann wrote:
+static inline void
+_set_desc_avail(struct vring_packed_desc *desc, int wrap_counter)
+{
+ desc->flags |= VRING_DESC_F_AVAIL(wrap_counter) |
+ VRING_DESC_F_USED(!wrap_counter);
+}
+
+static inline void
+set_desc_avail(struct
> On Dec 16, 2018, at 4:22 PM, Luca Boccassi wrote:
>
> On Sun, 2018-12-16 at 11:46 -0600, Keith Wiles wrote:
>> --- /dev/null
>> +++ b/lib/librte_dfs/meson.build
>> @@ -0,0 +1,47 @@
>> +# SPDX-License-Identifier: BSD-3-Clause
>> +# Copyright(c) 2018 Intel Corporation
>> +
>> +version = 1
>
>
On 12/14/18 4:59 PM, Jens Freimann wrote:
Add and initialize descriptor data structures.
Signed-off-by: Jens Freimann
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 32 ++--
drivers/net/virtio/virtio_ring.h | 34 --
Thanks for your detailed answer Keith.
Honestly, I do not have much more to say,
except some implementation details that I may comment later.
I hope we will read more opinions from the community.
17/12/2018 16:01, Wiles, Keith:
> > On Dec 17, 2018, at 5:45 AM, Thomas Monjalon wrote:
> > 16/12/2
On 12/14/18 4:59 PM, Jens Freimann wrote:
Add helper functions to set/clear and check descriptor flags.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_pci.h | 6 +++
drivers/net/virtio/virtqueue.h | 91 -
2 files changed, 95 insertions(+), 2
The checksum calculation APIs take only the packet headers pointers as
parameters, so they assume that the lengths reported in those headers are
correct. However, a malicious packet could claim to be far larger than it
is, so we need to check the header lengths in the driver before calling
the chec
If we receive a packet with an invalid IP header, where the total packet
length is reported as less than the IP header length, we would end up
getting an underflow in the length subtraction. This could cause us to
checksum e.g. 4GB of data in the case where the result of the subtraction
was -1. We
The functions for checksumming the packet payload don't perform bounds
checks, and are used by the TAP driver which does not do any bounds checks
on the incoming packet either. This means a packet received with an
incorrect IP header can read beyond the end of the mbuf.
In the worst case, where th
More information: the i40e driver on host (ubuntu16.04) was 2.2.4, but I
tried the latest 2.7.26 i40e driver and it had the same problem. DPDK 17.05
was running in a linux VM, but I don't think the latest DPDK has solved
the problem. It's easy to reproduce.
On Fri, Dec 14, 2018 at 4:28 PM Min Tang
On 12/14/18 4:59 PM, Jens Freimann wrote:
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_pci.h | 1 +
drivers/net/virtio/virtio_ring.h | 30 ++
drivers/net/virtio/virtqueue.h | 6 ++
3 files changed, 37 insertions(+)
Reviewed-by: Maxime
Reviewed-by: Rami Rosen
On Fri, 14 Dec 2018 at 18:43, Jeff Shaw wrote:
>
> Prior to this patch, the two affected .c files include
> unnecessarily. This commit removes the include lines.
>
> Signed-off-by: Jeff Shaw
> ---
> lib/librte_eal/common/eal_common_lcore.c | 1 -
> lib/librte_eal/commo
> On Dec 17, 2018, at 5:45 AM, Thomas Monjalon wrote:
>
> Hi Keith,
>
> 16/12/2018 18:46, Keith Wiles:
>> DFS stands for DPDK Filesystem, which helps expose data
>> and control files in a FUSE based filesystem. The dfs requires
>> libfuse3 and libjansson to be present in the Linux system.
>
>
Thanks for the confirmation.
BRs,
Xiao
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
> Sent: Monday, December 17, 2018 7:03 PM
> To: Wang, Xiao W ; Bie, Tiwei
> Cc: alejandro.luc...@netronome.com; dev@dpdk.org; Wang, Zhihong
> ; Ye, Xiaolong
> Subject:
On 12/17/2018 11:10 AM, Zhirun Yan wrote:
> Before this patch, VF gets a default number of queues from the PF.
> This patch enables VF to request a different number. When VF configures
> more queues, it will send VIRTCHNL_OP_REQUEST_QUEUES to PF to request
> more queues, if success, PF will reset t
On 12/17/2018 11:10 AM, Zhirun Yan wrote:
> Before this patch, VF gets a default number of queues from the PF.
> This patch enables VF to request a different number. When VF configures
> more queues, it will send VIRTCHNL_OP_REQUEST_QUEUES to PF to request
> more queues, if success, PF will reset t
On 12/17/2018 11:10 AM, Zhirun Yan wrote:
> This patch respond the VIRTCHNL_OP_REQUEST_QUEUES msg from VF, and
> process to allocated more queues for the requested VF. If successful,
> PF will notify VF to reset. If unsuccessful, PF will send message to
> inform VF.
Hi Zhirun,
Is this request sup
Hi Shally,
Thanks for your answers :).
My answers in [AK-v2]
> -Original Message-
> From: Verma, Shally [mailto:shally.ve...@cavium.com]
> Sent: Monday, December 17, 2018 6:45 AM
> To: Kusztal, ArkadiuszX
> Cc: dev@dpdk.org; Trahe, Fiona ; Doherty, Declan
> ; Kanaka Durga Kotamarthy
> ;
Meeting notes for the DPDK technical board meeting held on 2018-12-05
=
Attendees:
- Bruce Richardson
- Ferruh Yigit
- Konstantin Ananyev
- Maxime Coquelin
- Olivier Matz
- Thomas Monjalon
1) Status of the Meson build system
---
> >
> > > > >
> > > > > > > +
> > > > > > > +/* Add a reader thread, running on an lcore, to the list of
> > > > > > > +threads
> > > > > > > + * reporting their quiescent state on a TQS variable.
> > > > > > > + */
> > > > > > > +int __rte_experimental
> > > > > > > +rte_tqs_register_lcore(stru
On 17-Dec-18 12:39 PM, Dobri Dobrev wrote:
Hello,
I’d like to know why KNI module is not being developed for FreeBSD.
Regards
D
Hi,
Most likely answer is because no one has bothered to do so. Patches are
always welcome :)
--
Thanks,
Anatoly
Currently register read/write of testpmd is only for PCI device,
but more and more IFPGA based AFU devices need this feature to
access registers, this patch will add support for it.
Signed-off-by: Rosen Xu
---
app/test-pmd/config.c | 116 -
app/te
Hello,
I’d like to know why KNI module is not being developed for FreeBSD.
Regards
D
Thanks for the update
> -Original Message-
> From: Daly, Lee
> Sent: Monday, December 17, 2018 2:50 PM
> To: Varghese, Vipin ; akhil.go...@nxp.com
> Cc: dev@dpdk.org; Trahe, Fiona
> Subject: RE: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum
> support in driver
>
> Hi Vipin, th
use case: if callback is used to receive message form socket,
and the message received is disconnect/error, this callback needs
to be unregistered, but cannot because it is still active.
With this patch it is possible to mark the callback to be
unregistered once the interrupt process is done with
Currently register read/write of testpmd is only for PCI device,
but more and more IFPGA based AFU devices need this feature to
access registers, this patch will add support for it.
Signed-off-by: Rosen Xu
---
app/test-pmd/config.c | 116 -
app/te
Hi Bernard,
> -Original Message-
> From: Iremonger, Bernard
> Sent: Friday, December 14, 2018 18:19
> To: Xu, Rosen ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; Wu, Jingjing
> ; Yigit, Ferruh
> Subject: RE: [PATCH v2] app/test-pmd: add IFPGA AFU register read/write
> access for testpmd
>
> Hi Rose
Tested-by: Marko Kovacevic
1 - 100 of 144 matches
Mail list logo
