Okay. Thanks.
-Original Message-
From: Akhil Goyal
Sent: Thursday, February 14, 2019 09:35
To: Liron Himi ; dev@dpdk.org;
pablo.de.lara.gua...@intel.com
Subject: [EXT] Re: [dpdk-dev] crypto/openssl: add openssl path for cross compile
External Email
Hi Liron,
On 2/14/2019 12:13 PM, Liron Himi wrote:
> Hi,
>
> The below patch is very important when working in cross-compile environment.
> Can someone point to the reasons it was not merged?
>
> http://mails.dpdk.org/archives/dev/2017-September/074503.html
>
Thomas dropped this patch while mergin
Hi,
The below patch is very important when working in cross-compile environment.
Can someone point to the reasons it was not merged?
http://mails.dpdk.org/archives/dev/2017-September/074503.html
Regards,
Liron
Hi,
I'm going to release 17.11.5 this week.
Per Intel's request, the following patch from 18.05 has been merged since
17.11.5-rc2
net/i40e: fix link status update [1]
Let me know if there's anything missing.
[1]
http://git.dpdk.org/dpdk-stable/commit/?h=17.11&id=321c1e8581993
Thanks, Maxime.
Your description is better, My real name is Wenjie Sun.
Signed-off-by: Wenjie Sun
Maxime Coquelin 于2019年2月8日周五 下午10:12写道：
>
>
> On 1/28/19 7:55 AM, sunwenjie wrote:
> > When rte_vhost_driver_unregister delete the connection fd,
> > fdset_try_del will always try and donot rele
+1
Reviewed-by: Rami Rosen
>
Hi Yipeng,
Thanks for your review and acknowledgement.
I did think about braces on separate lines. One concern is, in this way, extra
indent will be needed and
make it hard to keep code lines within 80 characters. So I made the style
compromise.
Regards,
/Ruifeng
> -Original Message-
> -Original Message-
> From: Rao, Nikhil
> Sent: Thursday, January 10, 2019 8:51 PM
> To: Lu, Wenzhuo ; Wu, Jingjing ;
> Iremonger, Bernard
> Cc: dev@dpdk.org; Dumitrescu, Cristian ; Singh,
> Jasvinder ; Rao, Nikhil ;
> sta...@dpdk.org
> Subject: [PATCH] app/testpmd: initialize WRED pro
Hi, qi
New v3 has been commit as your request, thanks.
> -Original Message-
> From: Zhang, Qi Z
> Sent: Wednesday, February 13, 2019 11:44 AM
> To: Zhao1, Wei ; dev@dpdk.org
> Cc: sta...@dpdk.org; Lu, Wenzhuo
> Subject: RE: [PATCH v2 3/3] net/ixgbe: update API version
>
> I think thi
Hi Andrew,
> rte_validate_tx_offload() is used in Tx prepare callbacks
> (RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency.
> Requirement that packet headers should not be fragmented is not
> documented and unclear where it comes from except
> rte_net_intel_cksum_prepare() functio
Hi, Ruifeng,
I don't have an ARM Platform at hand to test but I gone through the code
against a NEON instruction manual,
and the logic looks good to me. One small comment is the coding style for
switch case, I think it is more common
to leave the braces on their own lines.
Otherwise:
Acked-by:
On Wed, Feb 13, 2019 at 5:14 PM David Marchand
wrote:
> Spawning the ctrl threads on anything that is not part of the eal
> coremask is not that polite to the rest of the system.
>
> Rather than introduce yet another eal options for this, let's take
> the startup cpu affinity as a reference and r
-l and -c options are two ways to select the cores used by DPDK.
Their format differs, but the checks on the selected cores are the same.
Use an intermediate array to separate the specific parsing checks from
the common consistency checks.
The parsing functions now concentrate on validating the pas
We don't need to look for trailing spaces.
This is a copy/paste block from eal_parse_coremask().
Remove it and the associated comment.
Fixes: d888cb8b9613 ("eal: add core list input format")
Signed-off-by: David Marchand
---
lib/librte_eal/common/eal_common_options.c | 7 ++-
1 file changed,
Wednesday, February 13, 2019 11:59 AM, Gaëtan RiveT:
> Subject: Re: [PATCH 2/6] vfio: don't fail to DMA map if memory is already
> mapped
>
> On Wed, Feb 13, 2019 at 11:10:22AM +0200, Shahaf Shuler wrote:
> > Currently vfio DMA map function will fail in case the same memory
> > segment is mapped t
Wednesday, February 13, 2019 1:43 PM, Alejandro Lucero:
> Subject: Re: [dpdk-dev] [PATCH 0/6] introduce DMA memory mapping for
> external memory
>
> On Wed, Feb 13, 2019 at 9:11 AM Shahaf Shuler
> wrote:
>
> > This series is in continue to RFC[1].
> >
> > The DPDK APIs expose 3 different modes t
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michael Santana
> Sent: Wednesday, February 13, 2019 7:08 PM
> To: dev@dpdk.org
> Cc: Thomas Monjalon
> Subject: [dpdk-dev] [PATCH 1/2] Enable codespell from config file.
>
> Enable turning on codespell from any o
Wednesday, February 13, 2019 1:44 PM, Gaëtan Rivet:
> Subject: Re: [PATCH 5/6] net/mlx5: support PCI device DMA map and unmap
>
> On Wed, Feb 13, 2019 at 12:35:04PM +0100, Gaëtan Rivet wrote:
> > On Wed, Feb 13, 2019 at 11:10:25AM +0200, Shahaf Shuler wrote:
> > > The implementation reuses the ext
Fix trivial bug. In sh shell, 'foo = 1' is not the same as
'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo
as a command, rather than a simple variable assignment.
Signed-off-by: Michael Santana
Fixes: dafc04c15174 ("hash: fix out-of-bound write while freeing key slot")
---
dev
Enable turning on codespell from any of the config files for
checkpatches.sh. codespell is a feature by checkpatch.pl that
checks for common spelling mistakes in comments in patches.
This feature is disabled by default. To enable it one must add
the '--codespell' flag to the $options variable in
c
Fixed a minor bug with variable assignment, as well as added an
option for checkpatches
Michael Santana (2):
Enable codespell from config file.
Fix variable assignment.
devtools/checkpatches.sh | 6 +-
1 file changed, 5 insertions(+), 1 deletions(-)
--
2.20.1
Wednesday, February 13, 2019 1:17 PM, Gaëtan Rivet:
> Subject: Re: [PATCH 3/6] bus: introduce DMA memory mapping for external
> memory
>
> On Wed, Feb 13, 2019 at 11:10:23AM +0200, Shahaf Shuler wrote:
> > The DPDK APIs expose 3 different modes to work with memory used for
> DMA:
> >
> > 1. Use th
> There is need to enble CLEARPBA bit for ice NIC of A0/A1 version in order to
> enable admin queue interrupt in avf mode.
Minor nit: You misspelled enable above
Your patch description says we should be checking dev_conf.rxmode.offloads
should be checked to enable VLAN, but I don't see the patch checking for that.
What am I missing?
Paul
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao
Sent: Tuesday, February 12,
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Tuesday, February 12, 2019 11:05 PM
> Cc: dev@dpdk.org; Daly, Lee ; Trahe, Fiona
> ;
> sta...@dpdk.org
> Subject: [PATCH 4/4] devtools: fix test of some build options
>
> CONFIG_RTE_LIBRTE_PMD_ISAL was no
This patch fixes a regression introduced by
commit 49d3978d5723("net/qede: fix Tx tunnel offload support mask")
in which qede_xmit_prep_pkts() breaks the loop for successful
check of Tunneling offload flags instead of continuing, resulting
in tx_pkt_prepare return a failure.
Fixes: 49d3978d5723 ("
Thomas...
We now have the "helloworld" application with a minimal EAL building on Windows
using clang. We have also managed to generate the build files using meson.
There are some issues we still need to work through, but we are close to
submitting patches to a branch on the draft repo. We hope
Spawning the ctrl threads on anything that is not part of the eal
coremask is not that polite to the rest of the system.
Rather than introduce yet another eal options for this, let's take
the startup cpu affinity as a reference and remove the eal coremask
from it.
If no cpu is left, then we defaul
Any update about the progress, please?
Do you have started a new branch?
30/01/2019 17:32, Menon, Ranjit:
> Thank you for the direction, Thomas and Tech Board members.
>
> If clang-win64 has support for GCC extensions
> (__attribute(constructor/align/etc...)), then the changes to common DPDK co
On Wed, Feb 13, 2019 at 11:54:49AM +, Luca Boccassi wrote:
> Whenever possible (if the library ships a pkg-config file) use meson's
> dependency() function to look for it, as it will automatically add it
> to the Requires.private list if needed, to allow for static builds to
> succeed for rever
Wednesday, February 13, 2019 11:45 AM, Gaëtan Rivet:
> Subject: Re: [PATCH 1/6] vfio: allow DMA map of memory for the default vfio
> fd
>
> Hello Shahaf,
Hi Gaetan.
>
> On Wed, Feb 13, 2019 at 11:10:21AM +0200, Shahaf Shuler wrote:
> > Enable users the option to call rte_vfio_dma_map with reque
> On Feb 13, 2019, at 3:50 AM, Andrew Rybchenko
> wrote:
>
> Ping.
>
> Do 2 weeks without reply mean that it looks good and I should send non-RCF
> version?
Just send the non-RFC patch as it seems most do not even look at the RFC’s
anyway.
>
> Andrew.
>
> On 1/29/19 11:49 AM, Andrew Rybc
On 13-Feb-19 9:10 AM, Shahaf Shuler wrote:
Enable users the option to call rte_vfio_dma_map with request to map
to the default vfio fd.
Signed-off-by: Shahaf Shuler
---
lib/librte_eal/common/include/rte_vfio.h | 6 --
lib/librte_eal/linuxapp/eal/eal_vfio.c | 14 --
2 file
On Wed, 2019-02-13 at 12:10 +0100, Thomas Monjalon wrote:
> 13/02/2019 11:49, Luca Boccassi:
> > On Tue, 2019-02-12 at 17:21 +0100, Thomas Monjalon wrote:
> > > Luca, please could you test cross-compilation?
> >
> > Hi,
> >
> > I would, except downloading the toolchain from Linaro fails with
> >
On 2/12/2019 7:01 PM, Ajit Khaparde wrote:
> On Tue, Feb 12, 2019 at 10:30 AM Davide Caratti wrote:
>
>> Set RTE_PCI_DRV_IOVA_AS_VA in drv_flags: this allows initializing bnxt
>> PMD as non-root also on Linux v4.x, where /proc/self/pagemap can't be
>> acccessed without CAP_SYS_ADMIN privileges.
>
On 2/11/2019 4:34 PM, Chas Williams wrote:
> We can transmit if there is at least one distributing slave.
>
> Fixes: 09150784a776 ("net/bonding: burst mode hash calculation")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Chas Williams
Applied to dpdk-next-net/master, thanks.
Now that the minimum Meson version has been bumped past 0.45 we can use
integer as an option type directly.
Signed-off-by: Luca Boccassi
Acked-by: Bruce Richardson
---
v6: added following Bruce's suggestion
v7: add acked-by
meson_options.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletio
Move libbsd inclusion to librte_eal, so that all other libraries and
PMDs will inherit it.
Signed-off-by: Luca Boccassi
Acked-by: Bruce Richardson
---
v3: only add dependency to librte_eal and let it propagate from there
v4: add acked-by
config/meson.build | 10 +-
lib/librte_e
Whenever possible (if the library ships a pkg-config file) use meson's
dependency() function to look for it, as it will automatically add it
to the Requires.private list if needed, to allow for static builds to
succeed for reverse dependencies of DPDK. Otherwise the recursive
dependencies are not p
Most libraries and PMDs depend on eal, and eal depends only on kvargs,
so reorder the list in Meson to reflect this and take advantage of this
dependency chain.
Signed-off-by: Luca Boccassi
Acked-by: Bruce Richardson
---
v3: added this patch to let the next just update librte_eal instead of
Meson 0.47.1 fixed a bug that is difficult to work around, which causes
the linker flag of dependencies to be repeated dozens of times, which
causes issues especially when using the built-in dependency() API.
Bump the minimum version and remove obsolete version checks.
Signed-off-by: Luca Boccassi
On 2/7/2019 1:27 PM, Bruce Richardson wrote:
> On Thu, Feb 07, 2019 at 11:56:30AM +, Ferruh Yigit wrote:
>> On 1/21/2019 10:43 AM, Parthasarathy, JananeeX M wrote:
>>>
>>>
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chaitanya Babu Talluri
Sent:
On 12/27/2018 9:35 AM, Olivier Matz wrote:
> Hi,
>
> On Fri, Dec 21, 2018 at 03:14:29PM +, Ferruh Yigit wrote:
>> On 12/21/2018 2:38 PM, Wiles, Keith wrote:
>>>
>>>
On Dec 20, 2018, at 5:48 PM, Stephen Hemminger
wrote:
On Thu, 20 Dec 2018 21:59:37 +
Ferruh Yigit
On Wed, 2019-02-13 at 10:49 +, Luca Boccassi wrote:
> On Tue, 2019-02-12 at 17:21 +0100, Thomas Monjalon wrote:
> > 12/02/2019 16:03, Bruce Richardson:
> > > On Tue, Feb 12, 2019 at 03:47:56PM +0100, Thomas Monjalon wrote:
> > > > 12/02/2019 12:43, Bruce Richardson:
> > > > > On Tue, Feb 12, 20
On Wed, Feb 13, 2019 at 12:35:04PM +0100, Gaëtan Rivet wrote:
> On Wed, Feb 13, 2019 at 11:10:25AM +0200, Shahaf Shuler wrote:
> > The implementation reuses the external memory registration work done by
> > commit[1].
> >
> > Note about representors:
> >
> > The current representor design will no
On Wed, Feb 13, 2019 at 9:11 AM Shahaf Shuler wrote:
> This series is in continue to RFC[1].
>
> The DPDK APIs expose 3 different modes to work with memory used for DMA:
>
> 1. Use the DPDK owned memory (backed by the DPDK provided hugepages).
> This memory is allocated by the DPDK libraries, inc
On Wed, Feb 13, 2019 at 10:45:05AM +0100, Gaëtan Rivet wrote:
> Hello Shahaf,
>
> On Wed, Feb 13, 2019 at 11:10:21AM +0200, Shahaf Shuler wrote:
> > Enable users the option to call rte_vfio_dma_map with request to map
> > to the default vfio fd.
> >
> > Signed-off-by: Shahaf Shuler
> > ---
> >
On Wed, Feb 13, 2019 at 11:10:25AM +0200, Shahaf Shuler wrote:
> The implementation reuses the external memory registration work done by
> commit[1].
>
> Note about representors:
>
> The current representor design will not work
> with those map and unmap functions. The reason is that for represen
On Wed, Feb 13, 2019 at 11:10:23AM +0200, Shahaf Shuler wrote:
> The DPDK APIs expose 3 different modes to work with memory used for DMA:
>
> 1. Use the DPDK owned memory (backed by the DPDK provided hugepages).
> This memory is allocated by the DPDK libraries, included in the DPDK
> memory system
13/02/2019 11:49, Luca Boccassi:
> On Tue, 2019-02-12 at 17:21 +0100, Thomas Monjalon wrote:
> > Luca, please could you test cross-compilation?
>
> Hi,
>
> I would, except downloading the toolchain from Linaro fails with 403
> forbidden...
>
> https://releases.linaro.org/components/toolchain/bin
On Tue, 2019-02-12 at 17:21 +0100, Thomas Monjalon wrote:
> 12/02/2019 16:03, Bruce Richardson:
> > On Tue, Feb 12, 2019 at 03:47:56PM +0100, Thomas Monjalon wrote:
> > > 12/02/2019 12:43, Bruce Richardson:
> > > > On Tue, Feb 12, 2019 at 12:36:17PM +0100, Thomas Monjalon
> > > > wrote:
> > > > > 1
Add test case for encryption, dectryption for snow3g when digest
is encrypted
Signed-off-by: Lukasz Krakowiak
---
test/test/test_cryptodev.c| 91 ++--
.../test/test_cryptodev_snow3g_test_vectors.h | 132 +-
2 files changed, 210 insertions(+), 13 delet
On Wed, Feb 13, 2019 at 11:10:22AM +0200, Shahaf Shuler wrote:
> Currently vfio DMA map function will fail in case the same memory
> segment is mapped twice.
>
> This is too strict, as this is not an error to map the same memory
> twice.
>
> Instead, use the kernel return value to detect such sta
Ping.
Do 2 weeks without reply mean that it looks good and I should send
non-RCF version?
Andrew.
On 1/29/19 11:49 AM, Andrew Rybchenko wrote:
rte_validate_tx_offload() is used in Tx prepare callbacks
(RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency.
Requirement that packet he
Hello Shahaf,
On Wed, Feb 13, 2019 at 11:10:21AM +0200, Shahaf Shuler wrote:
> Enable users the option to call rte_vfio_dma_map with request to map
> to the default vfio fd.
>
> Signed-off-by: Shahaf Shuler
> ---
> lib/librte_eal/common/include/rte_vfio.h | 6 --
> lib/librte_eal/linuxapp/
Fixes: 351fbee21986 ("common/cpt: support hash")
Signed-off-by: Anoob Joseph
Signed-off-by: Tejasree Kondoj
---
drivers/common/cpt/cpt_ucode.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/common/cpt/cpt_ucode.h b/drivers/common/cpt/cpt_ucode.h
index 5933ea7..d408d
There is need to enble CLEARPBA bit for ice NIC of A0/A1 version
in order to enable admin queue interrupt in avf mode.
If not, avf will not work.
Signed-off-by: Wei Zhao
---
drivers/net/avf/avf_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/avf/avf_ethde
Currently vfio DMA map function will fail in case the same memory
segment is mapped twice.
This is too strict, as this is not an error to map the same memory
twice.
Instead, use the kernel return value to detect such state and have the
DMA function to return as successful.
For type1 mapping the
As those have been replaced by rte_bus_dma_map and rte_pci_dma_unmap
APIs.
Signed-off-by: Shahaf Shuler
---
doc/guides/prog_guide/env_abstraction_layer.rst | 2 +-
doc/guides/rel_notes/deprecation.rst| 4
lib/librte_eal/common/include/rte_vfio.h| 6 --
3 files change
Enable users the option to call rte_vfio_dma_map with request to map
to the default vfio fd.
Signed-off-by: Shahaf Shuler
---
lib/librte_eal/common/include/rte_vfio.h | 6 --
lib/librte_eal/linuxapp/eal/eal_vfio.c | 14 --
2 files changed, 16 insertions(+), 4 deletions(-)
dif
This series is in continue to RFC[1].
The DPDK APIs expose 3 different modes to work with memory used for DMA:
1. Use the DPDK owned memory (backed by the DPDK provided hugepages).
This memory is allocated by the DPDK libraries, included in the DPDK
memory system (memseg lists) and automa
The DPDK APIs expose 3 different modes to work with memory used for DMA:
1. Use the DPDK owned memory (backed by the DPDK provided hugepages).
This memory is allocated by the DPDK libraries, included in the DPDK
memory system (memseg lists) and automatically DMA mapped by the DPDK
layers.
2. Use
Move the memory region creation to a separate function to
prepare the ground for the reuse of it on the PCI driver map and unmap
functions.
Signed-off-by: Shahaf Shuler
---
drivers/net/mlx5/mlx5_mr.c | 86 +++--
1 file changed, 57 insertions(+), 29 deletions(-
The implementation reuses the external memory registration work done by
commit[1].
Note about representors:
The current representor design will not work
with those map and unmap functions. The reason is that for representors
we have multiple IB devices share the same PCI function, so mapping will
There is need to enble CLEARPBA bit for ice NIC of A0/A1 version
in order to enable admin queue interrupt in avf mode.
If not, avf will not work.
Signed-off-by: Wei Zhao
---
drivers/net/avf/avf_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/avf/avf_ethde
Add test case for encryption, dectryption for snow3g when digest
is encrypted
Change-Id: I75bb535fa46ae23104f17d9c51278eca2c76e021
Signed-off-by: Lukasz Krakowiak
---
test/test/test_cryptodev.c| 91 ++--
.../test/test_cryptodev_snow3g_test_vectors.h | 132 +++
66 matches
Mail list logo
