Re: [dpdk-dev] [PATCH] eal: remove redundant API description

2019-03-19 Thread Shahaf Shuler
Tuesday, March 19, 2019 11:16 PM, Thomas Monjalon: > Subject: [dpdk-dev] [PATCH] eal: remove redundant API description > > Atomic functions are described in doxygen of the file > lib/librte_eal/common/include/generic/rte_atomic.h > The copies in arch-specific files are redundant and confuse reader

[dpdk-dev] [PATCH v4 3/3] test/rwlock: amortize the cost of getting time

2019-03-19 Thread Joyce Kong
Instead of getting timestamp per iteration, amortize its overhead can help to get more precise benchmarking results. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu Reviewed-by: Ola Liljedahl Reviewed-by: Ruifeng Wang --- app/t

[dpdk-dev] [PATCH v4 2/3] test/rwlock: add perf test case on all available cores

2019-03-19 Thread Joyce Kong
Add performance test on all available cores to benchmark the scaling up performance of rwlock. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Suggested-by: Gavin Hu Signed-off-by: Joyce Kong --- app/test/test_rwlock.c | 75 ++ 1

[dpdk-dev] [PATCH v4 1/3] rwlock: reimplement with atomic builtins

2019-03-19 Thread Joyce Kong
The __sync builtin based implementation generates full memory barriers ('dmb ish') on Arm platforms. Using C11 atomic builtins to generate one way barriers. Here is the assembly code of __sync_compare_and_swap builtin. __sync_bool_compare_and_swap(dst, exp, src); 0x0090f1b0 <+16>:e0

[dpdk-dev] [PATCH v4 0/3] rwlock: reimplement rwlock with atomic and add relevant perf test case

2019-03-19 Thread Joyce Kong
v4: Change _try_ functions to use __atomic too (for consistency)(Suggested by Ananyev, Konstantin). v3: Fix headline format error. v2: Rebase and modify the rwlock test case to address the comments in v1. v1: Reimplement rwlock with atomic builtins, and add a rwlock perf test on all availab

[dpdk-dev] Usage: --vmware-tsc-map

2019-03-19 Thread M R, Chengappa (Network Function Virtualization)
Hello All, Can I have a reference to the usage /enabling --vmware-tsc-map parameter ? I am currently testing DPDK 18.11 on a VM spawned ESXI host managed by vcenter, and looking to make use of --vmware-tsc-map parameter. Appreciate if I can get some links / pointers on enabling this parameter

Re: [dpdk-dev] [PATCH v6 1/2] eal/ticketlock: ticket based to improve fairness

2019-03-19 Thread Gavin Hu (Arm Technology China)
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, March 19, 2019 6:15 PM > To: Gavin Hu (Arm Technology China) ; dev@dpdk.org > Cc: nd ; step...@networkplumber.org; > jerin.ja...@caviumnetworks.com; tho...@monjalon.net; Honnappa > Nagarahalli ; Joyce Kong (A

Re: [dpdk-dev] [PATCH v3] build: use generic march on arm64 when using 'default' machine

2019-03-19 Thread Pavan Nikhilesh Bhagavatula
On Mon, 2019-01-07 at 14:11 +, Luca Boccassi wrote: > When building for generic distribution we need a stable baseline > architecture, or depending on the build worker the result will vary. > > Force the default flags if the user explicitly sets machine=default > at configuration time. > > Fi

Re: [dpdk-dev] [PATCH v2] vhost: fix interrupt suppression for the split ring

2019-03-19 Thread Tiwei Bie
On Sun, Mar 17, 2019 at 02:38:32PM +0800, Jiayu Hu wrote: > The VIRTIO_RING_F_EVENT_IDX feature of split ring might > be broken, as the value of signalled_used is invalid > after live migration, start up and virtio driver reload. > This patch fixes it by using signalled_used_valid. > > In addition

Re: [dpdk-dev] [PATCH v3 2/2] vhost: support requests only handled by external backend

2019-03-19 Thread Tiwei Bie
On Tue, Mar 19, 2019 at 11:54:17AM +0100, Maxime Coquelin wrote: > External backends may have specific requests to handle, and so > we don't want the vhost-user lib to handle these requests as > errors. > > This patch also changes the experimental API by introducing > RTE_VHOST_MSG_RESULT_NOT_HAND

[dpdk-dev] [PATCH v2] app/testpmd: add mempool bulk get for txonly mode

2019-03-19 Thread Pavan Nikhilesh Bhagavatula
On Tue, 2019-03-19 at 16:48 +, Ferruh Yigit wrote: > On 3/1/2019 1:47 PM, Pavan Nikhilesh Bhagavatula wrote: > > From: Pavan Nikhilesh > > > > Use mempool bulk get ops to alloc burst of packets and process > > them. > > If bulk get fails fallback to rte_mbuf_raw_alloc. > > I assume the motiv

[dpdk-dev] [PATCH] ethdev: claim device reset as async

2019-03-19 Thread Qi Zhang
Device reset should be implemented in an async way since it is possible to be invoked in interrupt thread and sometimes to reset a device need to wait for some dependency, for example, a VF expects for PF ready or a NIC function as part of a SOC wait for the whole system reset complete, and all the

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Tiwei Bie
On Tue, Mar 19, 2019 at 02:59:38PM +, Kevin Traynor wrote: > On 19/03/2019 13:50, Maxime Coquelin wrote: > > > > > > On 3/19/19 2:47 PM, Jens Freimann wrote: > >> On Tue, Mar 19, 2019 at 02:28:30PM +0100, Maxime Coquelin wrote: > >>> > >>> > >>> On 3/19/19 11:09 AM, Tiwei Bie wrote: > On

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Tiwei Bie
On Tue, Mar 19, 2019 at 02:28:30PM +0100, Maxime Coquelin wrote: > On 3/19/19 11:09 AM, Tiwei Bie wrote: > > On Tue, Mar 19, 2019 at 10:44:32AM +0100, Jens Freimann wrote: > > > On Tue, Mar 19, 2019 at 02:43:07PM +0800, Tiwei Bie wrote: > > > > Put split ring and packed ring specific fields into se

[dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key

2019-03-19 Thread Wei Zhao
There need a warning info when no perfect RSS key is config, so i40e will use default key. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao --- drivers/net/i40e/i40e_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Ye Xiaolong
Hi, Stephen On 03/19, Stephen Hemminger wrote: >Lots of little review comments. This is what I saw in 30 minutes. >Expect more. Thanks for taking time to review my patch. They are all valuable inputs. > > >On Tue, 19 Mar 2019 15:12:51 +0800 >Xiaolong Ye wrote: > >> +nb_pkts = nb_pkts < ETH_

Re: [dpdk-dev] [PATCH v2 6/6] app/testpmd: add mempool flags parameter

2019-03-19 Thread Ye Xiaolong
Hi, On 03/19, Jerin Jacob Kollanukkaran wrote: >On Tue, 2019-03-19 at 15:12 +0800, Xiaolong Ye wrote: >> When create rte_mempool, flags can be parsed from command line. >> Now, it is possible for testpmd to create a af_xdp friendly >> mempool (which enable zero copy). >> >> Signed-off-by: Qi Zha

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Ye Xiaolong
On 03/19, Bruce Richardson wrote: >> This is bad. Configure your editor to always put newline at end of file. >> In .emacs >> >>(setq require-final-newline t) >> >Or use Vim which needs no extra configuration to do this. :-) I used to be a Vimer, just switch to emacs recently. :-) >

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Ye Xiaolong
On 03/19, Stephen Hemminger wrote: >> \ No newline at end of file > > >This is bad. Configure your editor to always put newline at end of file. >In .emacs > > (setq require-final-newline t) > I wasn't aware of it before, thanks for the info, will configure it for my emacs. Thanks, Xiaolong

Re: [dpdk-dev] [PATCH] net/ice: speed up to retrieve EEPROM

2019-03-19 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Leyi Rong > Sent: Monday, March 18, 2019 1:51 PM > To: Lu, Wenzhuo ; Yang, Qiming > > Cc: dev@dpdk.org; Rong, Leyi > Subject: [dpdk-dev] [PATCH] net/ice: speed up to retrieve EEPROM > > Replace ice_read_sr_wor

Re: [dpdk-dev] [PATCH v2] vhost: fix interrupt suppression for the split ring

2019-03-19 Thread Wang, Yinan
Test-by: Wang, Yinan Best Wishes, Yinan > -Original Message- > From: Hu, Jiayu > Sent: 2019年3月17日 14:39 > To: dev@dpdk.org > Cc: Bie, Tiwei ; maxime.coque...@redhat.com; Wang, > Yinan ; Hu, Jiayu ; > sta...@dpdk.org > Subject: [PATCH v2] vhost: fix interrupt suppression for the split rin

[dpdk-dev] [PATCH v3 4/8] eal: sys/queue.h implementation for windows

2019-03-19 Thread Anand Rawat
Adding sys/queue.h on windows for supporting common code. This is implementation has BSD-3-Clause licensing. Signed-off-by: Ranjit Menon Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw --- .../windows/eal/include/sys/queue.h | 320 ++ 1 file changed, 320 insertions(

[dpdk-dev] [PATCH v3 7/8] doc: add documention for windows

2019-03-19 Thread Anand Rawat
Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- MAINTAINERS |

[dpdk-dev] [PATCH v3 6/8] eal: add minimum viable code for eal on windows

2019-03-19 Thread Anand Rawat
Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Updated header files to contain suitable function declaractions. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/windows/eal/eal.c

[dpdk-dev] [PATCH v3 8/8] build: meson changes to build on windows

2019-03-19 Thread Anand Rawat
Added meson workarounds to build helloworld on windows. Windows currently only supports kvargs and eal libraries. This change restricts the build flow to supported libraries only. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- exam

[dpdk-dev] [PATCH v3 3/8] kvargs: adding a module definition file

2019-03-19 Thread Anand Rawat
adding a DEF file for kvargs to specify the exports for the creation of the shared library. Signed-off-by: Bruce Richardson Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_kvargs/rte_kvargs_exports.def | 7 +++ 1 file changed, 7 insertions(+)

[dpdk-dev] [PATCH v3 0/8] HelloWorld example for windows

2019-03-19 Thread Anand Rawat
Includes Windows-specific EAL changes and meson changes to build the code on windows. v2 Changes: Incorporated reviews from v1. Fixed license period for updated files. Renamed 'winapp' folder to 'windows'. Cleaned unneeded meson changes. Fixed code style warnings. Added maintainers information fo

[dpdk-dev] [PATCH v3 1/8] eal: eal stub to add windows support

2019-03-19 Thread Anand Rawat
Added initial stub source files for windows support and only the required meson changes for windows. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- config/meson.build | 23 -- config/x86/meson.b

[dpdk-dev] [PATCH v3 2/8] eal: add header files to support windows

2019-03-19 Thread Anand Rawat
Added header files to support windows on x86 platforms. Updated rte_common.h to include rte_windows.h for windows build. Updated lib/meson.build to create shared libraries on windows. Added def file to list the exports for the eal library. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam

[dpdk-dev] [PATCH v3 5/8] eal: add headers for compatibility with windows environment

2019-03-19 Thread Anand Rawat
Added headers to support windows environment for common source. These headers will have windows specific implementions of the system library apis provided in linux and freebsd. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/lib

Re: [dpdk-dev] [PATCH v2 6/6] app/testpmd: add mempool flags parameter

2019-03-19 Thread Jerin Jacob Kollanukkaran
On Tue, 2019-03-19 at 15:12 +0800, Xiaolong Ye wrote: > When create rte_mempool, flags can be parsed from command line. > Now, it is possible for testpmd to create a af_xdp friendly > mempool (which enable zero copy). > > Signed-off-by: Qi Zhang > Signed-off-by: Xiaolong Ye > --- > app/test-pmd

Re: [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name

2019-03-19 Thread Stephen Hemminger
On Tue, 19 Mar 2019 18:59:21 + Ferruh Yigit wrote: > On 3/14/2019 3:35 PM, Jerin Jacob Kollanukkaran wrote: > > On Wed, 2019-03-13 at 14:58 -0700, Stephen Hemminger wrote: > >> The octeontx driver is creating vdev with name "OCTEONTX_PMD" > >> which is an artifact from how RTE_PMD_REGISTER

[dpdk-dev] [PATCH] eal: remove redundant API description

2019-03-19 Thread Thomas Monjalon
Atomic functions are described in doxygen of the file lib/librte_eal/common/include/generic/rte_atomic.h The copies in arch-specific files are redundant and confuse readers about the genericity of the API. Signed-off-by: Thomas Monjalon --- .../common/include/arch/arm/rte_atomic_32.h| 18 ---

Re: [dpdk-dev] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER

2019-03-19 Thread Thomas Monjalon
19/03/2019 20:42, Shahaf Shuler: > Tuesday, March 19, 2019 1:15 PM, Thomas Monjalon: > > Subject: Re: [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER > > > > Guys, please let's avoid top-post. > > > > You are both not replying to each other: > > > > 1/ Dekel mentioned the IBM doc but

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-19 Thread Thomas Monjalon
19/03/2019 19:00, Ferruh Yigit: > On 3/19/2019 5:36 PM, Thomas Monjalon wrote: > > 19/03/2019 18:29, Ferruh Yigit: > >> On 3/14/2019 10:04 PM, Thomas Monjalon wrote: > >>> 14/03/2019 03:58, Hyong Youb Kim: > On Wed, Mar 13, 2019 at 10:29:53PM +0100, Thomas Monjalon wrote: > > 13/03/2019 22

Re: [dpdk-dev] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER

2019-03-19 Thread Shahaf Shuler
Tuesday, March 19, 2019 1:15 PM, Thomas Monjalon: > Subject: Re: [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER > > Guys, please let's avoid top-post. > > You are both not replying to each other: > > 1/ Dekel mentioned the IBM doc but Chao did not argue about the lack of IO > protec

Re: [dpdk-dev] checklist for DPDK on Windows

2019-03-19 Thread Ranjit Menon
Thomas... Status below: On 3/19/2019 2:52 AM, Thomas Monjalon wrote: Any feedback? Could we try to give a work estimation for these items? 15/03/2019 00:04, Thomas Monjalon: Hi, Below is a list of directories, files or functions which we need to check to make basic DPDK works on Windows. If

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/1] net/qede: fix receive packet drop

2019-03-19 Thread Ferruh Yigit
On 3/13/2019 5:55 PM, Rasesh Mody wrote: >> From: dev On Behalf Of Shahed Shaikh >> Sent: Tuesday, March 12, 2019 9:51 AM >> >> There is a corner case in which driver won't post receive buffers when driver >> has processed all received packets in single loop (i.e. hw_consumer == >> sw_consumer) an

Re: [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name

2019-03-19 Thread Ferruh Yigit
On 3/14/2019 3:35 PM, Jerin Jacob Kollanukkaran wrote: > On Wed, 2019-03-13 at 14:58 -0700, Stephen Hemminger wrote: >> The octeontx driver is creating vdev with name "OCTEONTX_PMD" >> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments >> work. >> >> Change to use the same convention as

Re: [dpdk-dev] [PATCH] ethdev: use correct method name in ethdev header file

2019-03-19 Thread Ferruh Yigit
On 3/12/2019 5:40 PM, Stephen Hemminger wrote: > On Tue, 12 Mar 2019 18:07:42 +0200 > Rami Rosen wrote: > >> This patch fixes rte_ethdev header file to use the correct method name, >> namely to use rte_eth_dev_info_get() instead of >> rte_eth_dev_infos_get(). >> >> Fixes: a4996bd89c42 ("ethdev:

Re: [dpdk-dev] [PATCH v2] kni: fix possible kernel crash with va2pa

2019-03-19 Thread Ferruh Yigit
On 3/12/2019 9:22 AM, Yangchao Zhou wrote: > va2pa depends on the physical address and virtual address offset of > current mbuf. It may get the wrong physical address of next mbuf which > allocated in another hugepage segment. > > In rte_mempool_populate_default(), trying to allocate whole block o

Re: [dpdk-dev] [PATCH] app/testpmd: fix a typo.

2019-03-19 Thread Ferruh Yigit
On 3/12/2019 5:48 AM, Rami Rosen wrote: > This patch fixes a typo in test-pmd/cmdline.c: > succcessfully->successfully > Two C's are good enough for success... > > Signed-off-by: Rami Rosen Fixes: a09f3e4c5046 ("app/testpmd: add hash configuration") Cc: sta...@dpdk.org (fixed check-git-

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] app/testpmd: remove unused fwd_ctx field

2019-03-19 Thread Ferruh Yigit
On 3/11/2019 3:35 PM, David Marchand wrote: > Remove some leftover from a previous rework. > > Fixes: c4bcc342c8ee ("app/testpmd: refactor ieee1588 forwarding") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > Reviewed-by: Rami Rosen This patch looks independent from rest the patchset

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-03-19 Thread Ferruh Yigit
On 3/19/2019 5:34 PM, Thomas Monjalon wrote: >>> +uint16_t __rte_experimental >> Do we need _rte_experimental on function definitions? I guess only in .h >> file, >> function declaration is enough. > Yes we need them both in .h and .c files. > Why we need them in .c file? I think the compiler is

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-19 Thread Ferruh Yigit
On 3/19/2019 5:36 PM, Thomas Monjalon wrote: > 19/03/2019 18:29, Ferruh Yigit: >> On 3/14/2019 10:04 PM, Thomas Monjalon wrote: >>> 14/03/2019 03:58, Hyong Youb Kim: On Wed, Mar 13, 2019 at 10:29:53PM +0100, Thomas Monjalon wrote: > 13/03/2019 22:11, John Daley (johndale): >> From: Tho

Re: [dpdk-dev] [PATCH] net/bonding: fix Segfault when eal thread executing nic‘s lsc event for mode 4

2019-03-19 Thread Chas Williams
On 3/19/19 1:37 PM, Ferruh Yigit wrote: On 3/6/2019 3:42 AM, Zhaohui (zhaohui, Polestar) wrote: When the number of slave slave devices exceeds 8, it will cause the array subscript to cross the boundary. --- drivers/net/bonding/rte_eth_bond_8023ad.c | 4 ++-- 1 file changed, 2 insertions(+), 2 de

Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API

2019-03-19 Thread Stephen Hemminger
On Tue, 19 Mar 2019 17:18:08 + Ferruh Yigit wrote: > On 3/14/2019 3:13 PM, David Marchand wrote: > > Introduce a new api to retrieve per queue statistics from the drivers. > > The api objectives: > > - easily add some common per queue statistics and have it exposed > > through the user xsta

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/nfp: fix possible buffer overflow

2019-03-19 Thread Ferruh Yigit
On 3/12/2019 9:56 AM, Alejandro Lucero wrote: > On Fri, Mar 8, 2019 at 10:28 AM Pallantla Poornima < > pallantlax.poorn...@intel.com> wrote: > >> sprintf function is not secure as it doesn't check the length of string. >> More secure function snprintf is used. >> >> Fixes: 896c265ef9 ("net/nfp: us

Re: [dpdk-dev] [PATCH] net/bonding: fix Segfault when eal thread executing nic‘s lsc event for mode 4

2019-03-19 Thread Ferruh Yigit
On 3/6/2019 3:42 AM, Zhaohui (zhaohui, Polestar) wrote: > When the number of slave slave devices exceeds 8, it will cause the array > subscript to cross the boundary. > > --- > drivers/net/bonding/rte_eth_bond_8023ad.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >   > diff --git a/d

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-19 Thread Thomas Monjalon
19/03/2019 18:29, Ferruh Yigit: > On 3/14/2019 10:04 PM, Thomas Monjalon wrote: > > 14/03/2019 03:58, Hyong Youb Kim: > >> On Wed, Mar 13, 2019 at 10:29:53PM +0100, Thomas Monjalon wrote: > >>> 13/03/2019 22:11, John Daley (johndale): > From: Thomas Monjalon > > 13/03/2019 19:32, Ferruh Y

Re: [dpdk-dev] [PATCH v2] meson: remove build warnings

2019-03-19 Thread Luca Boccassi
On Tue, 2019-03-19 at 17:22 +, Jerin Jacob Kollanukkaran wrote: > From: Jerin Jacob > > Remove the following warning by comparing string to string. > > config/arm/meson.build:153: WARNING: Trying to compare values of > different types (list, str) using ==. > > Fixes: c6e536e38437 ("build: a

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-03-19 Thread Thomas Monjalon
19/03/2019 16:47, Ferruh Yigit: > On 2/20/2019 10:10 PM, Thomas Monjalon wrote: > > If multiple ports share the same hardware device (rte_device), > > they are siblings and can be found thanks to the new functions > > and loop macros. > > One iterator takes a port id as reference, > > while the oth

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-19 Thread Ferruh Yigit
On 3/14/2019 10:04 PM, Thomas Monjalon wrote: > 14/03/2019 03:58, Hyong Youb Kim: >> On Wed, Mar 13, 2019 at 10:29:53PM +0100, Thomas Monjalon wrote: >>> 13/03/2019 22:11, John Daley (johndale): From: Thomas Monjalon > 13/03/2019 19:32, Ferruh Yigit: >> On 3/5/2019 7:11 AM, Hyong Youb

Re: [dpdk-dev] [PATCH v2 3/3] doc: update documentation

2019-03-19 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang > Sent: Thursday, February 28, 2019 11:36 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Zhang, Roy Fan ; De Lara > Guarch, Pablo > > Subject: [dpdk-dev] [PATCH v2 3/3] doc: update documentation >

Re: [dpdk-dev] [PATCH v2 2/3] test: add out of place test for AESNI-MB

2019-03-19 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang > Sent: Thursday, February 28, 2019 11:36 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Zhang, Roy Fan ; De Lara > Guarch, Pablo > > Subject: [dpdk-dev] [PATCH v2 2/3] test: add out of place test f

Re: [dpdk-dev] [PATCH] app/testpmd: fix a typo.

2019-03-19 Thread Iremonger, Bernard
Hi Rami, > -Original Message- > From: Rami Rosen [mailto:ramir...@gmail.com] > Sent: Tuesday, March 12, 2019 5:49 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Rami Rosen > Subject: [PATCH] app/testpmd: fix a typo. > > This patch fixes a typo in test-p

[dpdk-dev] [PATCH v2] meson: remove build warnings

2019-03-19 Thread Jerin Jacob Kollanukkaran
From: Jerin Jacob Remove the following warning by comparing string to string. config/arm/meson.build:153: WARNING: Trying to compare values of different types (list, str) using ==. Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for ARM") Cc: sta...@dpdk.org Signed-off-by: Jerin

Re: [dpdk-dev] [PATCH] doc: fix abi check script examples

2019-03-19 Thread Neil Horman
On Tue, Mar 19, 2019 at 03:05:18PM +0100, David Marchand wrote: > The doc examples are not aligned on the script following the > incriminated commit. > > Fixes: c4a5fe3bf832 ("devtools: rework ABI checker script") > Cc: sta...@dpdk.org > > Cc: Olivier Matz > Cc: Neil Horman > Signed-off-by: Dav

Re: [dpdk-dev] [PATCH v2 1/3] crypto/aesni_mb: enable out of place processing

2019-03-19 Thread Trahe, Fiona
> -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, February 28, 2019 11:36 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Zhang, Roy Fan ; De Lara > Guarch, Pablo > ; Trahe, Fiona ; Luse, > Paul E > > Subject: [PATCH v2 1/3] crypto/aesni_mb: enable out of place processing

Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API

2019-03-19 Thread Ferruh Yigit
On 3/14/2019 3:13 PM, David Marchand wrote: > Introduce a new api to retrieve per queue statistics from the drivers. > The api objectives: > - easily add some common per queue statistics and have it exposed > through the user xstats api while the user stats api is left untouched > - remove the li

Re: [dpdk-dev] [PATCH v2] app/testpmd: add mempool bulk get for txonly mode

2019-03-19 Thread Ferruh Yigit
On 3/1/2019 1:47 PM, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh > > Use mempool bulk get ops to alloc burst of packets and process them. > If bulk get fails fallback to rte_mbuf_raw_alloc. I assume the motivation is performance improvement, do you have the numbers before and afte

Re: [dpdk-dev] [RFC v3] ethdev: claim device reset as async

2019-03-19 Thread Ferruh Yigit
On 3/19/2019 1:40 PM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Tuesday, March 19, 2019 9:14 PM >> To: Zhang, Qi Z ; tho...@monjalon.net; Doherty, Declan >> >> Cc: ktray...@redhat.com; dev@dpdk.org; Shelton, Benjamin H >> ; Vangati, Narender >> >> Subj

[dpdk-dev] [PATCH] net/sfc: fix speed capabilities reported in device info

2019-03-19 Thread Andrew Rybchenko
Phy capabilities are bit offsets in libefx, but was used as bit masks. Fixes: d23f3a89ab54 ("net/sfc: support link speed and duplex settings") Fixes: f82e33afbbb9 ("net/sfc: support link speeds up to 100G") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 1

Re: [dpdk-dev] [PATCH v4 1/5] eal: add VXLAN-GPE macro

2019-03-19 Thread Ferruh Yigit
On 3/19/2019 1:50 PM, David Marchand wrote: > eal: in the title ? we are in ethdev. > > On Tue, Mar 19, 2019 at 10:14 AM Qiming Yang wrote: > >> This patch added VXLAN-GPE macro in rte_eth_tunnel_type. >> >> Signed-off-by: Qiming Yang >> --- >> lib/librte_ethdev/rte_eth_ctrl.h | 1 + >> 1 file

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Bruce Richardson
On Tue, Mar 19, 2019 at 09:16:27AM -0700, Stephen Hemminger wrote: > On Tue, 19 Mar 2019 15:12:51 +0800 > Xiaolong Ye wrote: > > > Add a new PMD driver for AF_XDP which is a proposed faster version of > > AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] > > [2]. > > > >

Re: [dpdk-dev] Ask help for mlx5 pmd driver

2019-03-19 Thread Rami Rosen
Hi Benli, Next time please send questions like this to dpdk-users mailing list, which suits more these type of question. Can you please share more info: which dpdk app do you run ? Is it something you developed by yourself ?; With Mellanox PMDs, you do not need to bind them to DPDK, as opposed to

Re: [dpdk-dev] [PATCH v1 0/6] ethdev: add min/max MTU to device info

2019-03-19 Thread Ferruh Yigit
On 2/27/2019 9:45 PM, Ian Stokes wrote: > Building upon the discussion around [1], this series introduces MTU min > and MTU max variables. It also provides updates to PMD implementations > for ixgbe, i40e and IGB devices so that these variables are populated > for use when retrieving device info. >

Re: [dpdk-dev] [PATCH v1 2/6] net/i40e: set min and max MTU for i40e devices

2019-03-19 Thread Ferruh Yigit
On 2/27/2019 9:45 PM, Ian Stokes wrote: > This commit sets the min and max supported MTU values for i40e devices > via the i40e_dev_info_get() function. Min MTU supported is set to > ETHER_MIN_MTU and max mtu is calculated as the max packet length > supported minus the transport overhead. > > Sign

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Stephen Hemminger
On Tue, 19 Mar 2019 15:12:51 +0800 Xiaolong Ye wrote: > Add a new PMD driver for AF_XDP which is a proposed faster version of > AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] > [2]. > > This is the vanilla version PMD which just uses a raw buffer registered as > the um

Re: [dpdk-dev] [PATCH v1 1/6] ethdev: add min/max MTU to device info

2019-03-19 Thread Ferruh Yigit
On 2/27/2019 9:45 PM, Ian Stokes wrote: > From: Stephen Hemminger > > This addresses the usability issue raised by OVS at DPDK Userspace > summit. It adds general min/max mtu into device info. For compatiablity, > and to save space, it fits in a hole in existing structure. > > The initial versio

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Stephen Hemminger
Lots of little review comments. This is what I saw in 30 minutes. Expect more. On Tue, 19 Mar 2019 15:12:51 +0800 Xiaolong Ye wrote: > + nb_pkts = nb_pkts < ETH_AF_XDP_RX_BATCH_SIZE ? > + nb_pkts : ETH_AF_XDP_RX_BATCH_SIZE; Maybe use RTE_MIN() ? > + mbuf = rte_pktm

Re: [dpdk-dev] [PATCH] bonding: fix lacp negotiation failed

2019-03-19 Thread Kevin Traynor
On 15/03/2019 09:06, Liang Zhang wrote: > When monitor(port-mirroring) traffic from other lacp port-channel, > rx_machine_update may recieving other lacp negotiation packets. > Thus bond mode 4 will negotiation failed. > Please add a 'Fixes:' tag, and if appropriate for backport to stable branche

Re: [dpdk-dev] [PATCH v7 0/6] Add lock-free ring and mempool handler

2019-03-19 Thread Stephen Hemminger
On Mon, 18 Mar 2019 21:49:44 + "Eads, Gage" wrote: > Hi all, > > Friendly reminder that in order to get this feature into 19.08 (assuming > folks also want that :)), the API deprecation notice needs to be merged into > 19.05. > > Thanks, > Gage Given the recent API/ABI stability discussi

Re: [dpdk-dev] [PATCH v7 3/6] ring: add a lock-free implementation

2019-03-19 Thread Stephen Hemminger
On Mon, 18 Mar 2019 16:35:52 -0500 Gage Eads wrote: > > +/* The actual enqueue of pointers on the lock-free ring, used by the > + * single-producer lock-free enqueue function. > + */ > +#define ENQUEUE_PTRS_LF(r, base, prod_head, obj_table, n) do { \ > + unsigned int i; \ > + const uint

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-03-19 Thread Ferruh Yigit
On 2/20/2019 10:10 PM, Thomas Monjalon wrote: > If multiple ports share the same hardware device (rte_device), > they are siblings and can be found thanks to the new functions > and loop macros. > One iterator takes a port id as reference, > while the other one directly refers to the parent device.

Re: [dpdk-dev] 8023ad bond tx crashed if one port has 2 more tx queues

2019-03-19 Thread Chas Williams
On 3/19/19 5:41 AM, h...@netitest.com wrote: Hi Guys, I found a bug in dpdk bond code, while one port has 2 more tx queues, 8023ad bond port will be crashed in tx burst. Just analyzed the code below, if 2 more CPU cores send packets on a port by different tx queue, the arrays like slave_po

Re: [dpdk-dev] [PATCH v2 2/4] power: extend guest channel api for reading

2019-03-19 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hajkowski > --- > diff --git a/lib/librte_power/channel_commands.h > +#define CPU_POWER_CMD_NAK 2 Instead of NAK , NACK would be better I guess. > + if (global_fds[lcore_id] == 0) { Is this now < 0

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Kevin Traynor
On 19/03/2019 13:50, Maxime Coquelin wrote: > > > On 3/19/19 2:47 PM, Jens Freimann wrote: >> On Tue, Mar 19, 2019 at 02:28:30PM +0100, Maxime Coquelin wrote: >>> >>> >>> On 3/19/19 11:09 AM, Tiwei Bie wrote: On Tue, Mar 19, 2019 at 10:44:32AM +0100, Jens Freimann wrote: > On Tue, Mar 19

Re: [dpdk-dev] [PATCH v2 3/4] ipsec: add 3DES-CBC algorithm support

2019-03-19 Thread Akhil Goyal
On 2/19/2019 9:02 PM, Fan Zhang wrote: > This patch adds triple-des CBC mode cipher algorithm to ipsec > library. > > Signed-off-by: Fan Zhang > --- > lib/librte_ipsec/sa.c | 10 ++ > lib/librte_ipsec/sa.h | 6 ++ > 2 files changed, 16 insertions(+) > > diff --git a/lib/librte_i

Re: [dpdk-dev] [PATCH v2 1/4] ipsec: add AES-CTR algorithm support

2019-03-19 Thread Akhil Goyal
Hi Fan, title should be ipsec: support aes-ctr On 2/19/2019 9:02 PM, Fan Zhang wrote: > This patch adds AES-CTR cipher algorithm support to ipsec > library. > > Signed-off-by: Fan Zhang > --- > lib/librte_ipsec/crypto.h | 17 ++ > lib/librte_ipsec/sa.c | 133 > ++

Re: [dpdk-dev] [PATCH 10/10] net/virtio: improve batching in standard Rx path

2019-03-19 Thread Maxime Coquelin
On 3/19/19 7:43 AM, Tiwei Bie wrote: This patch improves descriptors refill by using the same batching strategy as done in in-order and mergeable path. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_rxtx.c | 60 ++-- 1 file changed, 34 insertions(+), 26

Re: [dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison

2019-03-19 Thread Akhil Goyal
On 3/19/2019 7:12 PM, Akhil Goyal wrote: > > On 3/11/2019 11:25 AM, Anoob Joseph wrote: >> The string compare to the length of driver name might give false >> positives when there are drivers with similar names (one being the >> subset of another). >> >> Following is such a naming which could res

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix debug in ipsec-secgw app

2019-03-19 Thread Akhil Goyal
On 3/19/2019 7:13 PM, Akhil Goyal wrote: > > On 3/8/2019 9:05 PM, Ananyev, Konstantin wrote: >>> -Original Message- >>> From: Iremonger, Bernard >>> Sent: Thursday, March 7, 2019 10:35 AM >>> To: dev@dpdk.org; Ananyev, Konstantin ; >>> akhil.go...@nxp.com >>> Cc: Iremonger, Bernard ; sta

Re: [dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode

2019-03-19 Thread Akhil Goyal
On 3/19/2019 7:15 PM, Akhil Goyal wrote: > > On 3/5/2019 8:10 PM, Fan Zhang wrote: >> This patch fixes the incorrect block size for AES-CTR in >> legacy mode. Originally, wrong block size will cause >> esp_inbound() drop AES-CTR encrypted packets if the payload >> sizes not equal to multiple time

[dpdk-dev] [PATCH] doc: fix abi check script examples

2019-03-19 Thread David Marchand
The doc examples are not aligned on the script following the incriminated commit. Fixes: c4a5fe3bf832 ("devtools: rework ABI checker script") Cc: sta...@dpdk.org Cc: Olivier Matz Cc: Neil Horman Signed-off-by: David Marchand --- doc/guides/contributing/versioning.rst | 19 +++

Re: [dpdk-dev] [PATCH] compress/qat: add fallback to fixed compression

2019-03-19 Thread Akhil Goyal
On 2/15/2019 10:31 PM, Trahe, Fiona wrote: > >> -Original Message- >> From: Jozwiak, TomaszX >> Sent: Friday, February 15, 2019 9:45 AM >> To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX >> >> Subject: [PATCH] compress/qat: add fallback to fixed compression >> >> This patch adds fallba

Re: [dpdk-dev] [PATCH] compress/isal: add ISA-L lib version display

2019-03-19 Thread Akhil Goyal
On 2/11/2019 3:12 PM, Daly, Lee wrote: > Hi Tomasz, > Looks good to me. >> -Original Message- >> From: Cel, TomaszX >> Sent: Monday, February 11, 2019 9:19 AM >> To: dev@dpdk.org >> Cc: sta...@dpdk.org; Trahe, Fiona ; Daly, Lee >> ; De Lara Guarch, Pablo >> ; Jozwiak, TomaszX >> ; C

Re: [dpdk-dev] [PATCH] qat/compress: fix qat comp setup inter_buffers

2019-03-19 Thread Akhil Goyal
On 1/30/2019 5:44 PM, Trahe, Fiona wrote: > >> -Original Message- >> From: Kovacevic, Marko >> Sent: Thursday, January 24, 2019 3:03 PM >> To: dev@dpdk.org >> Cc: sta...@dpdk.org; Yigit, Ferruh ; >> ktray...@redhat.com; Kovacevic, Marko >> ; Trahe, Fiona >> Subject: [PATCH] qat/compress

Re: [dpdk-dev] [PATCH v2 0/3] crypotodev: add result field to modular operations

2019-03-19 Thread Akhil Goyal
On 2/8/2019 4:43 PM, Arek Kusztal wrote: > This patchset adds result field to modular exponentiation and modular > inverse operations > > This patchset depends on following patches: > > [1] - "[v3] cryptodev: rework mod exp and mod inv comments" > (http://patchwork.dpdk.org/patch/50139/) > [2] -

Re: [dpdk-dev] [PATCH] cryptodev: fix restore crypto op alignment and layout

2019-03-19 Thread Akhil Goyal
On 3/19/2019 7:03 PM, Akhil Goyal wrote: > Hi Konstantin, > > On 3/7/2019 7:43 PM, Konstantin Ananyev wrote: >> in 18.08 new cache-aligned structure rte_crypto_asym_op was introduced. >> As it also was included into rte_crypto_op, it caused implicit change >> in rte_crypto_op layout and alignment

Re: [dpdk-dev] [PATCH 09/10] net/virtio: add ctrl vq helper for split ring

2019-03-19 Thread Maxime Coquelin
On 3/19/19 7:43 AM, Tiwei Bie wrote: Add a helper for sending commands in split ring to make the code consistent with the corresponding code in packed ring. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 76 +- 1 file changed, 43 insertions(+

Re: [dpdk-dev] [PATCH] EAL: count nr_overcommit_hugepages as available

2019-03-19 Thread Burakov, Anatoly
On 25-Feb-19 8:57 PM, Michał Mirosław wrote: From: Michał Mirosław With nr_overcommit_hugepages > 0 application may be able to allocate hugepages even when free_hugepages == 0. Take this into account when counting available hugepages. Signed-off-by: Michał Mirosław --- Surplus pages go back

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Maxime Coquelin
On 3/19/19 2:47 PM, Jens Freimann wrote: On Tue, Mar 19, 2019 at 02:28:30PM +0100, Maxime Coquelin wrote: On 3/19/19 11:09 AM, Tiwei Bie wrote: On Tue, Mar 19, 2019 at 10:44:32AM +0100, Jens Freimann wrote: On Tue, Mar 19, 2019 at 02:43:07PM +0800, Tiwei Bie wrote: Put split ring and pac

Re: [dpdk-dev] [PATCH v4 1/5] eal: add VXLAN-GPE macro

2019-03-19 Thread David Marchand
eal: in the title ? we are in ethdev. On Tue, Mar 19, 2019 at 10:14 AM Qiming Yang wrote: > This patch added VXLAN-GPE macro in rte_eth_tunnel_type. > > Signed-off-by: Qiming Yang > --- > lib/librte_ethdev/rte_eth_ctrl.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_ethde

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Jens Freimann
On Tue, Mar 19, 2019 at 02:28:30PM +0100, Maxime Coquelin wrote: On 3/19/19 11:09 AM, Tiwei Bie wrote: On Tue, Mar 19, 2019 at 10:44:32AM +0100, Jens Freimann wrote: On Tue, Mar 19, 2019 at 02:43:07PM +0800, Tiwei Bie wrote: Put split ring and packed ring specific fields into separate sub-st

Re: [dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode

2019-03-19 Thread Akhil Goyal
On 3/5/2019 8:10 PM, Fan Zhang wrote: > This patch fixes the incorrect block size for AES-CTR in > legacy mode. Originally, wrong block size will cause > esp_inbound() drop AES-CTR encrypted packets if the payload > sizes not equal to multiple times of 16. > > Fixes: 4470c22de2e1 ("examples/ipsec

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix debug in ipsec-secgw app

2019-03-19 Thread Akhil Goyal
On 3/8/2019 9:05 PM, Ananyev, Konstantin wrote: > >> -Original Message- >> From: Iremonger, Bernard >> Sent: Thursday, March 7, 2019 10:35 AM >> To: dev@dpdk.org; Ananyev, Konstantin ; >> akhil.go...@nxp.com >> Cc: Iremonger, Bernard ; sta...@dpdk.org >> Subject: [PATCH] examples/ipsec-s

Re: [dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison

2019-03-19 Thread Akhil Goyal
On 3/11/2019 11:25 AM, Anoob Joseph wrote: > The string compare to the length of driver name might give false > positives when there are drivers with similar names (one being the > subset of another). > > Following is such a naming which could result in false positive. > 1. crypto_driver > 2. cry

Re: [dpdk-dev] [RFC v3] ethdev: claim device reset as async

2019-03-19 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, March 19, 2019 9:14 PM > To: Zhang, Qi Z ; tho...@monjalon.net; Doherty, Declan > > Cc: ktray...@redhat.com; dev@dpdk.org; Shelton, Benjamin H > ; Vangati, Narender > > Subject: Re: [RFC v3] ethdev: claim device reset as async

Re: [dpdk-dev] [PATCH 08/10] net/virtio: add interrupt helper for split ring

2019-03-19 Thread Maxime Coquelin
On 3/19/19 7:43 AM, Tiwei Bie wrote: Add a helper for disabling interrupts in split ring to make the code consistent with the corresponding code in packed ring. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtqueue.h | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-)

  1   2   >