[dpdk-dev] [PATCH v4] service: fix parameter type

2019-03-27 Thread Nikhil Rao
The type of value parameter to rte_service_attr_get should be uint64_t *, since the attributes are of type uint64_t. Fixes: 4d55194d76a4 ("service: add attribute get function") Reviewed-by: Gage Eads Signed-off-by: Nikhil Rao Acked-by: Harry van Haaren Reviewed-by: Rami Rosen --- lib/librte_

[dpdk-dev] [PATCH] app/pdump: enhance to support multi-core capture

2019-03-27 Thread Vipin Varghese
Enhance pdump application, to allow user to run on multiple cores. Signed-off-by: Vipin Varghese --- app/pdump/main.c | 73 -- doc/guides/tools/pdump.rst | 5 +++ 2 files changed, 67 insertions(+), 11 deletions(-) diff --git a/app/pdump/main.c b/ap

Re: [dpdk-dev] [PATCH v2] app/eventdev: add option to set global dequeue tmo

2019-03-27 Thread Jerin Jacob Kollanukkaran
On Wed, 2019-03-27 at 17:07 +, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh > > Add option to provide a global dequeue timeout that is used to create > the eventdev. > The dequeue timeout provided will be common across all the worker > ports. If the eventdev hardware supports po

Re: [dpdk-dev] [BUG] Maintainer for lib/librte_eal/common/rte_reciprocal.c?

2019-03-27 Thread Pavan Nikhilesh Bhagavatula
Hi Stefan, Thanks for the heads up, I am planning to use a modified version of https://github.com/hcs0/Hackers-Delight/blob/master/divluh.c.txt for simplicity as we don't require the remainder. Regards, Pavan. > -Original Message- > From: dev On Behalf Of Stefan Kanthak > Sent: Tuesday,

Re: [dpdk-dev] [PATCH v6 4/8] eal: sys/queue.h implementation for windows

2019-03-27 Thread Varghese, Vipin
Thanks Anand, > -Original Message- > From: Rawat, Anand > Sent: Thursday, March 28, 2019 8:10 AM > To: Varghese, Vipin ; dev@dpdk.org > Cc: Kadam, Pallavi ; Menon, Ranjit > ; Shaw, Jeffrey B ; > Richardson, Bruce ; tho...@monjalon.net > Subject: Re: [dpdk-dev] [PATCH v6 4/8] eal: sys/queu

Re: [dpdk-dev] [PATCH v6 4/8] eal: sys/queue.h implementation for windows

2019-03-27 Thread Anand Rawat
On 3/27/2019 7:30 PM, Varghese, Vipin wrote: Hi Anand, snipped Adding sys/queue.h on windows for supporting common code. This is implementation has BSD-3-Clause licensing. Signed-off-by: Ranjit Menon Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw --- .../windows/eal/include/sys/queue.

Re: [dpdk-dev] [PATCH v6 4/8] eal: sys/queue.h implementation for windows

2019-03-27 Thread Varghese, Vipin
Hi Anand, snipped > > Adding sys/queue.h on windows for supporting common code. > This is implementation has BSD-3-Clause licensing. > > Signed-off-by: Ranjit Menon > Signed-off-by: Anand Rawat > Reviewed-by: Jeff Shaw > --- > .../windows/eal/include/sys/queue.h | 320 +

[dpdk-dev] [PATCH v6 6/8] eal: add minimum viable code for eal on windows

2019-03-27 Thread Anand Rawat
Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Updated header files to contain suitable function declaractions. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/windows/eal/eal.c

[dpdk-dev] [PATCH v6 3/8] build: add module definition file for windows

2019-03-27 Thread Anand Rawat
Updated lib/meson.build to create shared libraries on windows. Added DEF files to list the exports for the eal and kvargs libraries. Signed-off-by: Bruce Richardson Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_eal/rte_eal_exports.def |

[dpdk-dev] [PATCH v6 4/8] eal: sys/queue.h implementation for windows

2019-03-27 Thread Anand Rawat
Adding sys/queue.h on windows for supporting common code. This is implementation has BSD-3-Clause licensing. Signed-off-by: Ranjit Menon Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw --- .../windows/eal/include/sys/queue.h | 320 ++ 1 file changed, 320 insertions(

[dpdk-dev] [PATCH v6 5/8] eal: add headers for compatibility with windows

2019-03-27 Thread Anand Rawat
Added headers to support windows environment for common source. These headers will have windows specific implementions of the system library apis provided in linux and freebsd. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- .../win

[dpdk-dev] [PATCH v6 8/8] build: meson changes to build on windows

2019-03-27 Thread Anand Rawat
Added meson workarounds to build helloworld on windows. Windows currently only supports kvargs and eal libraries. This change restricts the build flow to supported libraries only. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- app/

[dpdk-dev] [PATCH v6 7/8] doc: add documentation for windows

2019-03-27 Thread Anand Rawat
Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- MAINTAINERS |

[dpdk-dev] [PATCH v6 0/8] HelloWorld example for windows

2019-03-27 Thread Anand Rawat
Includes Windows-specific EAL changes and meson changes to build the code on windows. v6 Changes: 1. Introduced rte_os.h for esstential os specific macros and typedefs. 2. Fixed commit typos and 'new line required at eof' issues. v5 Changes: 1. Reduced meson workrounds for windows. 2. Updated doc

[dpdk-dev] [PATCH v6 2/8] eal: add header files to support os specifics

2019-03-27 Thread Anand Rawat
Added rte_os.h files to support os specific functionality. Updated rte_common.h to include rte_os.h. Updated lib/meson.build to inject rte_os.h in every library. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/common/

[dpdk-dev] [PATCH v6 1/8] eal: eal stub to add windows support

2019-03-27 Thread Anand Rawat
Added initial stub source files for windows support and only the required meson changes for windows. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- config/meson.build | 23 -- config/x86/meson.b

Re: [dpdk-dev] [PATCH] maintainers: Succeed Chao Zhu as maintainer of EAL for IBM POWER

2019-03-27 Thread Chao Zhu
Thanks David for taking over this job. > -Original Message- > From: David Christensen > Sent: Thursday, March 28, 2019 6:32 AM > To: chao...@linux.vnet.ibm.com > Cc: dev@dpdk.org; David Christensen > Subject: [PATCH] maintainers: Succeed Chao Zhu as maintainer of EAL for IBM > POWER > >

Re: [dpdk-dev] [PATCH v5 6/8] net/ice: support Rx AVX2 vector

2019-03-27 Thread Lu, Wenzhuo
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, March 27, 2019 3:50 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 6/8] net/ice: support Rx AVX2 vector > > > > On 3/27/19 1:56 AM, Lu, Wenzhuo wrote:

[dpdk-dev] [PATCH v3] app/testpmd: make txonly mode generate multiple flows

2019-03-27 Thread Yongseok Koh
Testpmd can generate multiple flows without taking much cost and this could be a simple traffic generator for developer's quick tests. If "--txonly-multi-flow" is specified in the command line, IP source address is varied to gnerate multiple flows. Signed-off-by: Yongseok Koh --- v3: * Add "--tx

Re: [dpdk-dev] [PATCH 2/2] net/virtio: fix lgtm static checker complaint

2019-03-27 Thread Rami Rosen
Acked-by: Rami Rosen

Re: [dpdk-dev] [PATCH 1/2] net/netvsc: fix lgtm static checker complaint

2019-03-27 Thread Rami Rosen
Acked-by: Rami Rosen

Re: [dpdk-dev] [PATCH v3 1/1] ring: enforce reading the tail before reading ring slots

2019-03-27 Thread Thomas Monjalon
> > In weak memory models, like arm64, reading the prod.tail may get > > reordered after reading the ring slots, which corrupts the ring and > > stale data is observed. > > > > This issue was reported by NXP on 8-A72 DPAA2 board. The problem is most > > likely caused by missing the acquire semanti

Re: [dpdk-dev] [PATCH v5 2/8] eal: add header files to support windows

2019-03-27 Thread Thomas Monjalon
28/03/2019 00:10, Anand Rawat: > On 3/27/2019 3:29 PM, Thomas Monjalon wrote: > > 27/03/2019 22:23, Ranjit Menon: > > > On 3/26/2019 3:20 AM, Jerin Jacob Kollanukkaran wrote: > > >> On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote: > > >>> Added header files to support windows on x86 platforms.

Re: [dpdk-dev] [PATCH v3 1/1] eal: add 128-bit compare exchange (x86-64 only)

2019-03-27 Thread Thomas Monjalon
04/03/2019 21:51, Gage Eads: > --- a/lib/librte_eal/common/include/generic/rte_atomic.h > +++ b/lib/librte_eal/common/include/generic/rte_atomic.h > +#if defined(RTE_ARCH_X86_64) > +/** > + * 128-bit integer structure. > + */ > +RTE_STD_C11 > +typedef struct { > + RTE_STD_C11 > + union

Re: [dpdk-dev] [PATCH v5 2/8] eal: add header files to support windows

2019-03-27 Thread Anand Rawat
On 3/27/2019 3:29 PM, Thomas Monjalon wrote: 27/03/2019 22:23, Ranjit Menon: > On 3/26/2019 3:20 AM, Jerin Jacob Kollanukkaran wrote: >> On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote: >>> Added header files to support windows on x86 platforms. >>> Updated rte_common.h to include rte_window

Re: [dpdk-dev] [PATCH v3 2/2] eal: roundup tsc frequency when estimating

2019-03-27 Thread Thomas Monjalon
16/03/2019 20:01, Pavan Nikhilesh Bhagavatula: > From: Pavan Nikhilesh > > When estimating tsc frequency using sleep/gettime round it up to the > nearest multiple of 10Mhz for more accuracy. > > Signed-off-by: Pavan Nikhilesh > Reviewed-by: Keith Wiles Series applied, thanks

Re: [dpdk-dev] [PATCH] eal: initialize alarms early

2019-03-27 Thread Thomas Monjalon
27/03/2019 21:33, Stojaczyk, Dariusz: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 26/03/2019 19:43, Darek Stojaczyk: > > > We currently initialize rte_alarms after starting > > > to listen for IPC hotplug requests, which gives > > > us a data race window. Upon receiving such hotplug >

[dpdk-dev] [PATCH] maintainers: Succeed Chao Zhu as maintainer of EAL for IBM POWER

2019-03-27 Thread David Christensen
Signed-off-by: David Christensen --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 21e164095..6eccbe480 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -237,7 +237,7 @@ F: drivers/net/i40e/i40e_rxtx_vec_neon.c F: drivers/net/virtio/

Re: [dpdk-dev] [PATCH v5 2/8] eal: add header files to support windows

2019-03-27 Thread Thomas Monjalon
27/03/2019 22:23, Ranjit Menon: > On 3/26/2019 3:20 AM, Jerin Jacob Kollanukkaran wrote: > > On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote: > >> Added header files to support windows on x86 platforms. > >> Updated rte_common.h to include rte_windows.h for windows > >> build. Updated lib/meso

Re: [dpdk-dev] [PATCH] net/mlx5: revert mbuf address calculation for x86

2019-03-27 Thread Yongseok Koh
> On Mar 27, 2019, at 4:51 AM, Kevin Traynor wrote: > > On 25/03/2019 19:13, Yongseok Koh wrote: >> When replenishing mbufs on Rx, buffer address (mbuf->buf_addr) should be >> loaded. non-x86 processors (mostly RISC such as ARM and Power) are more >> vulnerable to load stall. For x86, reducing

[dpdk-dev] 17.11.6-rc1 patches review and test

2019-03-27 Thread Yongseok Koh
Hi all, Here is a list of patches targeted for LTS release 17.11.6. Please help review and test. The planned date for the final release is April 8, Before that, please shout if anyone has objection with these patches being applied. For the companies committed to running regression tests, please r

Re: [dpdk-dev] [PATCH] eal: use eal abstraction for defining constructors

2019-03-27 Thread Thomas Monjalon
> > From: Jerin Jacob > > > > Use eal's RTE_INIT abstraction for defining constructors. > > > > Signed-off-by: Jerin Jacob > > > Reviewed-by: David Marchand Applied, thanks

Re: [dpdk-dev] [PATCH v5 2/8] eal: add header files to support windows

2019-03-27 Thread Ranjit Menon
On 3/26/2019 3:20 AM, Jerin Jacob Kollanukkaran wrote: On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote: Added header files to support windows on x86 platforms. Updated rte_common.h to include rte_windows.h for windows build. Updated lib/meson.build to create shared libraries on windows. Add

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-27 Thread Anand Rawat
On 3/26/2019 12:06 PM, Stephen Hemminger wrote: On Mon, 25 Mar 2019 23:02:34 -0700 Anand Rawat wrote: +/*- + * SPDX-License-Identifier: BSD-3-Clause + * + * Copyright (c) 1991, 1993 + * The Regents of the University of California. All rights reserved. + * + * Redistribution and use in sou

[dpdk-dev] [PATCH 1/2] net/netvsc: fix lgtm static checker complaint

2019-03-27 Thread Stephen Hemminger
Since previous test is for mtu < 1519 the next else if is always true. This causes the lgtm static tool to complain. Not a real issue, just cosmetic. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/

[dpdk-dev] [PATCH 0/2] minor lgtm warning fixes

2019-03-27 Thread Stephen Hemminger
Looks like the LGTM checker complains about condition checks that are always true. Stephen Hemminger (2): net/netvsc: fix lgtm static checker complaint net/virtio: fix lgtm static checker complaint drivers/net/netvsc/hn_rxtx.c | 2 +- drivers/net/virtio/virtio_rxtx.c | 2 +- 2 files chan

[dpdk-dev] [PATCH 2/2] net/virtio: fix lgtm static checker complaint

2019-03-27 Thread Stephen Hemminger
Since previous test is for mtu < 1519 the next else if is always true. This causes the lgtm static tool to complain. Not a real issue, just cosmetic. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

Re: [dpdk-dev] [PATCH] eal: initialize alarms early

2019-03-27 Thread Stojaczyk, Dariusz
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, March 27, 2019 7:12 PM > To: Stojaczyk, Dariusz > Cc: dev@dpdk.org; Zhang, Qi Z ; Burakov, Anatoly > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal: initialize alarms early > > 26/03/2

[dpdk-dev] [PATCH] event/sw: fix selftest enqueue return value checks

2019-03-27 Thread Harry van Haaren
This patch fixes a number of instances of the same return value mis-check, where previously we checked for a negative return value as error, however the API returns an unsigned integer, so these return value checks are invalid. The rte_event_enqueue_burst() API returns the number of events enqueue

Re: [dpdk-dev] [PATCH v4 2/4] crypto/qat: add asymmetric cryptography PMD

2019-03-27 Thread Trahe, Fiona
Hi Arek, > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, March 27, 2019 11:17 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX > > Subject: [PATCH v4 2/4] crypto/qat: add asymmetric cryptography PMD > > This patch adds Poll Mode D

Re: [dpdk-dev] [PATCH] eal: initialize alarms early

2019-03-27 Thread Thomas Monjalon
26/03/2019 19:43, Darek Stojaczyk: > We currently initialize rte_alarms after starting > to listen for IPC hotplug requests, which gives > us a data race window. Upon receiving such hotplug > request we always try to set an alarm and this > obviously doesn't work if the alarms weren't > initialized

Re: [dpdk-dev] [PATCH v12] eal_interrupts: add option for pending callback unregister

2019-03-27 Thread Thomas Monjalon
22/03/2019 12:52, Jakub Grajciar: > use case: if callback is used to receive message form socket, > and the message received is disconnect/error, this callback needs > to be unregistered, but cannot because it is still active. > > With this patch it is possible to mark the callback to be > unregis

[dpdk-dev] [PATCH v2] compress/isal: fix compression stream initialization

2019-03-27 Thread Tomasz Cel
This patch fixes ISAL internal state fields initialization. Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality") Cc: sta...@dpdk.org Signed-off-by: Tomasz Cel --- drivers/compress/isal/isal_compress_pmd.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --g

[dpdk-dev] [PATCH v2] This patch fix compression stream initialization

2019-03-27 Thread Tomasz Cel
v2: - removed isal_inflate_reset() function because is not neccesary, everything is cleared by the isal_inflate_init function at the begining Tomasz Cel (1): compress/isal: fix compression stream initialization drivers/compress/isal/isal_compress_pmd.c | 6 +- 1 file changed, 1 insertion

[dpdk-dev] [PATCH] compress/isal: add appropriate flag on overflow

2019-03-27 Thread Cel, TomaszX
Hi Lee, > This patch will change the operation status when ISA-L returns because of a > recoverable out of space error, rather than a just generic fail. > > Signed-off-by: Lee Daly > --- > drivers/compress/isal/isal_compress_pmd.c | 20 ++-- > 1 file changed, 14 insertions(+), 6

[dpdk-dev] LGTM static code analysis of DPDK

2019-03-27 Thread Mcnamara, John
Hi, While Coverity was down recently we looked at some other static code analysis tools available to open source communities. One of these is a new interesting tool called LGTM: https://lgtm.com/projects/g/DPDK/dpdk/overview/ I ran a crosscheck git-blame and identified the probable* author

Re: [dpdk-dev] [PATCH] app/test-crypto-perf: improve dequeue logic

2019-03-27 Thread Kevin Traynor
On 27/03/2019 11:47, Akhil Goyal wrote: > In case of hardware PMDs (which may take a longer duration > for processing the packets), there may be a case when the > number of enqueued packets are more than the dequeued. > > So if the difference is more than 8 times the burst size, > more dequeue ope

Re: [dpdk-dev] [PATCH v2] doc: note validation and timeline required for stables

2019-03-27 Thread Luca Boccassi
On Wed, 2019-03-27 at 17:22 +, Kevin Traynor wrote: > If a stable branch for a specific DPDK release is to proceed, > along with needing a maintainer, there should also be commitment > from major contributors for validation of the releases. > > Also, as decided in the March 27th techboard, to

[dpdk-dev] [PATCH v2] doc: note validation and timeline required for stables

2019-03-27 Thread Kevin Traynor
If a stable branch for a specific DPDK release is to proceed, along with needing a maintainer, there should also be commitment from major contributors for validation of the releases. Also, as decided in the March 27th techboard, to facilitate user planning, a release should be designated as a stab

Re: [dpdk-dev] [PATCH 1/1] net/nfp: add support for set link up/down

2019-03-27 Thread Ferruh Yigit
On 3/27/2019 10:27 AM, Pablo Cascón wrote: > Add functions to set the link state up or down. > > Signed-off-by: Pablo Cascón > Acked-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH v2] app/eventdev: add option to set global dequeue tmo

2019-03-27 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Add option to provide a global dequeue timeout that is used to create the eventdev. The dequeue timeout provided will be common across all the worker ports. If the eventdev hardware supports power management through dequeue timeout then this option can be used for verifying

Re: [dpdk-dev] 18.11.1 patches review and test

2019-03-27 Thread Kevin Traynor
On 27/03/2019 14:41, Ali Alnubani wrote: > Hi > >> -Original Message- >> From: dev On Behalf Of Kevin Traynor >> Sent: Friday, March 22, 2019 5:10 PM >> To: dpdk stable >> Cc: dev@dpdk.org >> Subject: [dpdk-dev] 18.11.1 patches review and test >> >> Hi all, >> >> Here is a list of patche

Re: [dpdk-dev] [PATCH v2 0/3] Add rte_eth_read_clock API

2019-03-27 Thread Tom Barbette
On 2019-03-27 15:54, Wiles, Keith wrote: I know the API rte_eht_read_clock() is attempting to read the NIC for this timestamp, but if the PMD does not support this request can we just default to the rte_rdtsc() as a return value? I would not advise that, because the goal of the function is to h

Re: [dpdk-dev] [PATCH] meson: remove build warnings

2019-03-27 Thread Luca Boccassi
On Wed, 2019-03-27 at 11:28 -0400, Aaron Conole wrote: > Bruce Richardson < > bruce.richard...@intel.com > > writes: > > > On Mon, Mar 18, 2019 at 05:15:25PM +, Luca Boccassi wrote: > > > On Mon, 2019-03-18 at 16:28 +, Jerin Jacob Kollanukkaran > > > wrote: > > > > From: Jerin Jacob < > >

[dpdk-dev] [PATCH] meter: replace color definitions with rte_color values

2019-03-27 Thread Jasvinder Singh
This patch implements the changes proposed in the deprecation note[1]. Replace mulitple color definitions in various places such as rte_meter.h, rte_tm.h and rte_mtr.h with single rte_color defined in rte_meter.h. [1] https://mails.dpdk.org/archives/dev/2019-January/123861.html Signed-off-by: Ja

Re: [dpdk-dev] [PATCH] net: fix rte_vlan_insert with shared mbuf

2019-03-27 Thread Chas Williams
On 3/27/19 11:18 AM, Stephen Hemminger wrote: On Tue, 26 Mar 2019 18:38:57 -0400 Chas Williams <3ch...@gmail.com> wrote: On 3/26/19 3:15 PM, Stephen Hemminger wrote: If mbuf refcnt was > 1 then rte_vlan_insert() would incorrectly modify the original copy. Original code was expecting clone t

Re: [dpdk-dev] [PATCH] meson: remove build warnings

2019-03-27 Thread Aaron Conole
Bruce Richardson writes: > On Mon, Mar 18, 2019 at 05:15:25PM +, Luca Boccassi wrote: >> On Mon, 2019-03-18 at 16:28 +, Jerin Jacob Kollanukkaran wrote: >> > From: Jerin Jacob >> > >> > Remove the following meson build warnings >> > >> > 1) WARNING: Project specifies a minimum meson_ve

[dpdk-dev] [Bug 234] dma remapping failed with errno 22 when use "--no-huge"

2019-03-27 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=234 Bug ID: 234 Summary: dma remapping failed with errno 22 when use "--no-huge" Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRMED

Re: [dpdk-dev] [PATCH] net/fm10k: fix VLAN strip offload flag

2019-03-27 Thread Ferruh Yigit
On 3/27/2019 5:09 AM, Xiao Wang wrote: > Since the VLAN header is stripped from mbuf data, PKT_RX_VLAN_STRIPPED > should be set in offload flag. > > Fixes: 6b59a3bc82b1 ("fm10k: fix VLAN in Rx mbuf") > Fixes: 7092be8437bd ("fm10k: add vector Rx") > > Cc: sta...@dpdk.org > > Signed-off-by: Xiao W

Re: [dpdk-dev] [PATCH] app/test-crypto-perf: improve dequeue logic

2019-03-27 Thread Zhang, Roy Fan
Hi Akhil, This patch seems introduced performance degradation on my server with QAT DH895XCC by more than 10% for big packets (>=256). Fiona/Pablo, could you have a try with it? Regards, Fan > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal > Sent:

Re: [dpdk-dev] [PATCH] net: fix rte_vlan_insert with shared mbuf

2019-03-27 Thread Stephen Hemminger
On Tue, 26 Mar 2019 18:38:57 -0400 Chas Williams <3ch...@gmail.com> wrote: > On 3/26/19 3:15 PM, Stephen Hemminger wrote: > > If mbuf refcnt was > 1 then rte_vlan_insert() would incorrectly > > modify the original copy. Original code was expecting clone to make > > a copy (it doesn't). Better to l

Re: [dpdk-dev] [PATCH 3/3] test: add UT for power turbo feature

2019-03-27 Thread Burakov, Anatoly
On 07-Mar-19 1:59 PM, Lukasz Krakowiak wrote: Add UT check_power_turbo. Signed-off-by: Lukasz Krakowiak --- app/test/test_power_cpufreq.c | 72 +++ 1 file changed, 72 insertions(+) diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c ind

Re: [dpdk-dev] [PATCH 2/3] test: remove prefix _acpi from UT power function/test names

2019-03-27 Thread Burakov, Anatoly
On 07-Mar-19 1:59 PM, Lukasz Krakowiak wrote: This patch remove prefix _acpi from power UT function/test names. Again, subject line is IMO too long. How about: "test/power: remove _acpi prefix from test names" ? Otherwise, Acked-by: Anatoly Burakov Signed-off-by: Lukasz Krakowiak ---

Re: [dpdk-dev] [PATCH 1/3] test: rename test_power_acpi_cpufreq.c -> app/test/test_power_cpufreq.c

2019-03-27 Thread Burakov, Anatoly
On 07-Mar-19 1:59 PM, Lukasz Krakowiak wrote: This patch rename file test_power_acpi_cpufreq.c -> app/test/test_power_cpufreq.c. Signed-off-by: Lukasz Krakowiak --- Subject line is too long. Perhaps just say "test/power: rename cpufreq autotest" ? Otherwise Acked-by: Anatoly Burakov -

Re: [dpdk-dev] [PATCH] examples: detect build directory rather than hardcoding

2019-03-27 Thread Ferruh Yigit
On 3/27/2019 1:58 PM, Bruce Richardson wrote: > Most examples have in their makefiles a default RTE_TARGET directory to be > used in case RTE_TARGET is not set. Rather than just using a hard-coded > default, we can instead detect what the build directory is relative to > RTE_SDK directory. > > Thi

Re: [dpdk-dev] [PATCH] compress/isal: fix getting information about CPU

2019-03-27 Thread Daly, Lee
Hi Tomasz, This patch makes sense to check does the CPU have the capability of certain instructions before Adding it to the dev_info flags. I think one more addition should be made in isal_compress_pmd.c When checking what compression level should be used , decided by the AVX instructi

Re: [dpdk-dev] [PATCH v3 4/4] power: send confirmation cmd to vm guest

2019-03-27 Thread Burakov, Anatoly
On 21-Mar-19 10:55 AM, Hajkowski wrote: From: Marcin Hajkowski Use new guest channel API to send confirmation message for received power command. Signed-off-by: Marcin Hajkowski --- examples/vm_power_manager/channel_monitor.c | 67 +++-- 1 file changed, 61 insertions(+), 6

Re: [dpdk-dev] [PATCH v2 0/3] Add rte_eth_read_clock API

2019-03-27 Thread Wiles, Keith
> On Mar 27, 2019, at 9:41 AM, Stephen Hemminger > wrote: > > On Wed, 27 Mar 2019 07:19:32 +0100 > Tom Barbette wrote: > >> Some NICs allow to timestamp packets, but do not support the full >> PTP synchronization process. Hence, the value set in the mbuf >> timestamp field is only the raw v

Re: [dpdk-dev] [PATCH v3 3/4] power: process incoming confirmation cmds

2019-03-27 Thread Burakov, Anatoly
On 21-Mar-19 10:55 AM, Hajkowski wrote: From: Marcin Hajkowski Extend vm_power_guest to check incoming confirmations of messages previously sent to host. Signed-off-by: Marcin Hajkowski --- examples/vm_power_manager/guest_cli/Makefile | 1 + .../guest_cli/vm_power_cli_guest.c

Re: [dpdk-dev] [PATCH v2 0/3] Add rte_eth_read_clock API

2019-03-27 Thread Thomas Monjalon
27/03/2019 15:41, Stephen Hemminger: > On Wed, 27 Mar 2019 07:19:32 +0100 > Tom Barbette wrote: > > > Some NICs allow to timestamp packets, but do not support the full > > PTP synchronization process. Hence, the value set in the mbuf > > timestamp field is only the raw value of an internal clock.

Re: [dpdk-dev] 18.11.1 patches review and test

2019-03-27 Thread Ali Alnubani
Hi > -Original Message- > From: dev On Behalf Of Kevin Traynor > Sent: Friday, March 22, 2019 5:10 PM > To: dpdk stable > Cc: dev@dpdk.org > Subject: [dpdk-dev] 18.11.1 patches review and test > > Hi all, > > Here is a list of patches targeted for LTS release 18.11.1. Please help revie

Re: [dpdk-dev] [PATCH v2 0/3] Add rte_eth_read_clock API

2019-03-27 Thread Stephen Hemminger
On Wed, 27 Mar 2019 07:19:32 +0100 Tom Barbette wrote: > Some NICs allow to timestamp packets, but do not support the full > PTP synchronization process. Hence, the value set in the mbuf > timestamp field is only the raw value of an internal clock. > > To make sense of this value, one at least n

Re: [dpdk-dev] [PATCH 2/3] examples/ipsec_secgw: fix possible NULL dereference

2019-03-27 Thread Akhil Goyal
On 3/27/2019 6:49 PM, Ananyev, Konstantin wrote: > Hi Akhil, > >>> Fixes: 3e5f4625dc17 ("examples/ipsec-secgw: make data-path to use IPsec >>> library") >>> Coverity issue: 336844 >>> >>> Signed-off-by: Konstantin Ananyev >>> --- >>>examples/ipsec-secgw/ipsec_process.c | 11 --- >>>

Re: [dpdk-dev] [PATCH v3 2/4] power: extend guest channel api for reading

2019-03-27 Thread Burakov, Anatoly
On 21-Mar-19 10:55 AM, Hajkowski wrote: From: Marcin Hajkowski Added new experimental API rte_power_guest_channel_receive_msg which gives possibility to receive messages send to guest. Signed-off-by: Marcin Hajkowski --- lib/librte_power/channel_commands.h| 5 ++ lib/librte_power/gues

Re: [dpdk-dev] [PATCH v3 0/4] support secondary process for failsafe

2019-03-27 Thread Ferruh Yigit
<...> > On Mon, Mar 18, 2019 at 04:05:24PM +, Raslan Darawsheh wrote: >> this set of patches are intended to support secondary process for failsafe. >> >> v3 integrates changes after review from Gaetan >> There is no functional change. >> >> Raslan Darawsheh (4): >> net/failsafe: replace loc

Re: [dpdk-dev] [PATCH] compress/isal: fix getting information about CPU

2019-03-27 Thread Akhil Goyal
Hi Fiona/Lee, Could you please review this patch. Thanks, Akhil On 3/7/2019 4:58 PM, Tomasz Cel wrote: > This patch adds query about CPU features > > Fixes: 53a9baa98c36 ("compress/isal: add basic PMD ops") > Cc: sta...@dpdk.org > > Signed-off-by: Tomasz Cel > --- > drivers/compress/isal/isal

[dpdk-dev] [PATCH] examples: detect build directory rather than hardcoding

2019-03-27 Thread Bruce Richardson
Most examples have in their makefiles a default RTE_TARGET directory to be used in case RTE_TARGET is not set. Rather than just using a hard-coded default, we can instead detect what the build directory is relative to RTE_SDK directory. This fixes a potential issue for anyone who continues to buil

Re: [dpdk-dev] [PATCH v4 1/2] timer: allow timer management in shared memory

2019-03-27 Thread Thomas Monjalon
21/03/2019 02:01, Carrillo, Erik G: > Hi Robert, > > Thanks for the review and suggestions. I’m out of the office on bonding > leave for the next few weeks, but I’ll update the patch to address your > points below when I return. This is unfortunate. This patch was waiting for reviews for month

Re: [dpdk-dev] [PATCH v3 1/4] power: fix invalid socket indicator value

2019-03-27 Thread Burakov, Anatoly
On 21-Mar-19 10:55 AM, Hajkowski wrote: From: Marcin Hajkowski Currently 0 is being used for not connected slot indication. This is not consistent with linux doc which identifies 0 as valid (connected) slot, thus modification was done to change it. Fixes: cd0d5547 ("power: vm communication cha

Re: [dpdk-dev] [PATCH] test/compress: add max mbuf size test case

2019-03-27 Thread Akhil Goyal
Hi Fiona, Could you please review this patch. Thanks, Akhil On 2/15/2019 3:14 PM, Tomasz Jozwiak wrote: > This patch adds new test case in which max. size of > chain mbufs has been used to compress random data dynamically. > > Signed-off-by: Tomasz Jozwiak > --- > test/test/test_compressdev.

Re: [dpdk-dev] [PATCH v1] examples/distributor: detect high frequency cores

2019-03-27 Thread Burakov, Anatoly
On 22-Feb-19 11:45 AM, David Hunt wrote: The distributor application is bottlenecked by the distributor core, so if we can give more frequency to this core, then the overall performance of the application may increase. This patch uses the rte_power_get_capabilities() API to query the cores provi

Re: [dpdk-dev] [PATCH] eal/linux: fix log levels for unable to read pagemap

2019-03-27 Thread Thomas Monjalon
14/02/2019 20:31, Aaron Conole: > Kevin Traynor writes: > > > Commit cdc242f260e7 says: > > For Linux kernel 4.0 and newer, the ability to obtain > > physical page frame numbers for unprivileged users from > > /proc/self/pagemap was removed. Instead, when an IOMMU > > is present,

Re: [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support

2019-03-27 Thread Thomas Monjalon
18/02/2019 13:30, Ferruh Yigit: > +* kni: remove KNI ethtool support. To clarify, this is not to remove the KNI, > + but only to remove ethtool support of it that is disabled by default and > + can be enabled via ``CONFIG_RTE_KNI_KMOD_ETHTOOL`` config option. > + Existing KNI ethtool implementat

[dpdk-dev] [PATCH v2] mem: warn user when running without NUMA support

2019-03-27 Thread Anatoly Burakov
Running in non-legacy mode on a NUMA-enabled system without libnuma is unsupported, so explicitly print out a warning when trying to do so. Running in legacy mode without libnuma is still supported whether or not we are running with libnuma support enabled, so also fix init to allow that scenario.

Re: [dpdk-dev] [PATCH v5 3/3] doc: add deprecation marker usage

2019-03-27 Thread Thomas Monjalon
01/03/2019 18:40, Kevin Traynor: > On 01/03/2019 17:32, Ferruh Yigit wrote: > > Define '__rte_deprecated' usage process. > > > > Suggests keeping old API with '__rte_deprecated' marker including > > next LTS, they will be removed just after the LTS release. > > > > Signed-off-by: Ferruh Yigit >

Re: [dpdk-dev] [PATCH 2/3] examples/ipsec_secgw: fix possible NULL dereference

2019-03-27 Thread Ananyev, Konstantin
Hi Akhil, > > Fixes: 3e5f4625dc17 ("examples/ipsec-secgw: make data-path to use IPsec > > library") > > Coverity issue: 336844 > > > > Signed-off-by: Konstantin Ananyev > > --- > > examples/ipsec-secgw/ipsec_process.c | 11 --- > > 1 file changed, 4 insertions(+), 7 deletions(-) > > >

[dpdk-dev] [PATCH v4 13/13] net/mlx5: add source vport match to the ingress rules

2019-03-27 Thread Viacheslav Ovsiienko
For E-Switch configurations over multiport Infiniband devices we should add source vport match to correctly distribute traffic between representors. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_flow_dv.c | 36 1 file

[dpdk-dev] [PATCH v4 11/13] net/mlx5: update install/uninstall int handler routines

2019-03-27 Thread Viacheslav Ovsiienko
We are implementing the support for multport Infiniband device withj representors attached to these multiple ports. Asynchronous device event notifications (link status change, removal event, etc.) should be shared between ports. We are going to implement shared event handler and this patch introdu

[dpdk-dev] [PATCH v4 10/13] net/mlx5: provide IB port for the object being created

2019-03-27 Thread Viacheslav Ovsiienko
The code is updated to provide IB port index for the Verbs objects being created - QPs and Verbs Flows. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_flow.c | 2 ++ drivers/net/mlx5/mlx5_flow_verbs.c | 1 + drivers/net/mlx5/mlx5_txq.c| 4 ++-

[dpdk-dev] [PATCH v4 06/13] net/mlx5: switch to the names in the shared IB context

2019-03-27 Thread Viacheslav Ovsiienko
The IB device names are moved from device private data to the shared context, code involving the names is updated. The IB port index treatment is added where it is relevant. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.h| 2 -- drivers/net/mlx5/

[dpdk-dev] [PATCH v4 12/13] net/mlx5: update event handler for multiport IB devices

2019-03-27 Thread Viacheslav Ovsiienko
This patch modifies asynchronous event handler to support multiport Infiniband devices. Handler queries the event parameters, including event source port index, and invokes the handler for specific devices with appropriate port_id. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler ---

[dpdk-dev] [PATCH v4 08/13] net/mlx5: switch to the shared context IB attributes

2019-03-27 Thread Viacheslav Ovsiienko
The code is updated to use the shared IB device attributes, located in the shared IB context. It saves some memory if there are representors created over the single Infiniband device with multuple ports. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH v4 09/13] net/mlx5: switch to the shared IB device context

2019-03-27 Thread Viacheslav Ovsiienko
The code is updated to use the shared IB device context and device handles. The IB device context is shared between reprentors created over the single multiport IB device. All Verbs and DevX objects will be created whithin this shared context. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf

[dpdk-dev] [PATCH v4 07/13] net/mlx5: switch to the shared Protection Domain

2019-03-27 Thread Viacheslav Ovsiienko
The PMD code is updated to use Protected Domain from the the shared IB device context. The Domain is shared between all devices belonging to the same multiport Infiniband device. If IB device has only one port, the PD is not shared, because there is only ethernet device created over IB one. Signed

[dpdk-dev] [PATCH v4 05/13] net/mlx5: add IB shared context alloc/free functions

2019-03-27 Thread Viacheslav Ovsiienko
The Mellanox NICs support SR-IOV and have E-Switch feature. When SR-IOV is set up in switchdev mode and E-Switch is enabled we have so called VF representors in the system. All representors belonging to the same E-Switch are created on the basis of the single PCI function and with current implement

[dpdk-dev] [PATCH v4 04/13] net/mlx5: add multiport IB device support to probing

2019-03-27 Thread Viacheslav Ovsiienko
mlx5_pci_probe() routine is refactored to probe the ports of found Infiniband devices. All active ports (with attached network interface), belonging to the same Infiniband device will use the signle shared Infiniband context of that device. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shu

[dpdk-dev] [PATCH v4 02/13] net/mlx5: modify get ifindex routine for multiport IB

2019-03-27 Thread Viacheslav Ovsiienko
There is the routine mlx5_nl_ifindex() returning the network interface index associated with Infiniband device. We are going to support multiport IB devices, now function takes the IB port as argument and returns ifindex associated with tuple Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf

[dpdk-dev] [PATCH v4 03/13] net/mlx5: add getting IB ports number for multiport IB

2019-03-27 Thread Viacheslav Ovsiienko
There is the routine mlx5_nl_portnum() added to get the number of ports of multiport Infiniband device. It is assumed the Uplink/VF representors are attached on these ports. Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.h| 1 + drivers/net/mlx5/mlx5_

[dpdk-dev] [PATCH v4 00/14] net/mlx5: add support for multiport IB devices

2019-03-27 Thread Viacheslav Ovsiienko
The Mellanox NICs support SR-IOV and have E-Switch feature. When SR-IOV is set up in switchdev mode and E-Switch is enabled we have so called VF representors in the system. All representors belonging to the same E-Switch are created on the basis of the single PCI function and with current implemen

[dpdk-dev] [PATCH v4 01/13] net/mlx5: add representor recognition on kernels 5.x

2019-03-27 Thread Viacheslav Ovsiienko
The master device and VF representors were distinguished by presence of port name, master device did not have one. The new Linux kernels starting from 5.0 provide the port name for master device and the implemented representor recognizing method does not work. The new recognizing method is based on

  1   2   >