Re: [dpdk-dev] [PATCH 1/3] rcu: add RCU library supporting QSBR mechanism

2019-03-28 Thread Honnappa Nagarahalli
> > > > > > > > +#define RTE_QSBR_CNT_THR_OFFLINE 0 #define RTE_QSBR_CNT_INIT > 1 > > > > + > > > > +/** > > > > + * RTE thread Quiescent State structure. > > > > + * Quiescent state counter array (array of 'struct > > > > +rte_rcu_qsbr_cnt'), > > > > + * whose size is dependent on the maximum num

Re: [dpdk-dev] [PATCH] fbarray: add internal tailq for mapped areas

2019-03-28 Thread Stojaczyk, Dariusz
This patch caused a regression. Any secondary process fails to initialize. Please see the quick fix here: http://patchwork.dpdk.org/patch/51882/ D. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, March 28, 2019 9:45 PM > To: Bu

[dpdk-dev] [PATCH] fbarray: fix attach deadlock

2019-03-28 Thread Darek Stojaczyk
rte_fbarray_attach() currently locks its internal spinlock, but never releases it. Secondary processes won't even start if there is more than one fbarray to be attached to - the second rte_fbarray_attach() would be just stuck. Fix it by releasing the lock at the end of rte_fbarray_attach(). I beli

Re: [dpdk-dev] [PATCH] net/ice: fixed speed capability error issue

2019-03-28 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Sun, Chenmin > Sent: Friday, March 29, 2019 5:54 PM > To: dev@dpdk.org > Cc: Sun, Chenmin ; Lu, Wenzhuo > > Subject: [PATCH] net/ice: fixed speed capability error issue > > From: Chenmin Sun > > Device speed capability should be specified based on diff

[dpdk-dev] [PATCH] net/ice: fixed speed capability error issue

2019-03-28 Thread chenmin . sun
From: Chenmin Sun Device speed capability should be specified based on different phy types instead of a fixed value, this patch fix the issue. Fixes: 690175ee51bf ("net/ice: support getting device information") Cc: wenzhuo...@intel.com Signed-off-by: Chenmin Sun --- drivers/net/ice/ice_ethdev

[dpdk-dev] DPDK Windows Community call - 28 March 2019

2019-03-28 Thread Ranjit Menon
Attendees:- - Raslan Darawsheh Thomas Monjalon Bruce Richardson Cathal O'Hare Anand Rawat Pallavi Kadam Ranjit Menon * NEW: Bi-weekly call will start 04-Apr-2019 - 4pm Paris, 3pm Shannon, 7am Oregon Invitee list at present: tho...@monjalon.net eil...@mellanox.com yoh...@mellanox.co

Re: [dpdk-dev] [PATCH v7 1/5] net/af_xdp: introduce AF XDP PMD driver

2019-03-28 Thread Ye Xiaolong
Hi, Ferruh Thanks for the comments. On 03/28, Ferruh Yigit wrote: >On 3/27/2019 9:00 AM, Xiaolong Ye wrote: >> Add a new PMD driver for AF_XDP which is a proposed faster version of >> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] >> [2]. >> >> This is the vanilla vers

Re: [dpdk-dev] [PATCH v7 5/5] net/af_xdp: enable zero copy

2019-03-28 Thread Ye Xiaolong
On 03/28, Ferruh Yigit wrote: >On 3/27/2019 9:00 AM, Xiaolong Ye wrote: >> Try to check if external mempool (from rx_queue_setup) is fit for >> af_xdp, if it is, it will be registered to af_xdp socket directly and >> there will be no packet data copy on Rx and Tx. >> >> Signed-off-by: Xiaolong Ye

Re: [dpdk-dev] [PATCH] packet_ordering: replace sync builtins with atomic builtins

2019-03-28 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: Thomas Monjalon > Sent: Friday, March 29, 2019 2:43 AM > To: Phil Yang (Arm Technology China) > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > > Subject: Re: [dpdk-dev] [PATCH] packet_ordering: replace sync builtins with > atomic builtins > > 03/01/2019 10:

[dpdk-dev] [PATCH] net/ice: send driver version to firmware

2019-03-28 Thread Qi Zhang
The driver must send its version information to the firmware, so the firmware knows the driver is up. Otherwise, it will cause unexpected OS package downloading when multiple driver instances running on the same device. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/

Re: [dpdk-dev] [PATCH v7 0/8] HelloWorld example for windows

2019-03-28 Thread Harini Ramakrishnan
Includes Windows-specific EAL changes and meson changes to build the code on windows. v7 Changes: 1. Fixed rte_os.h not found issue on linux and freebsd. 2. Fixed missing def issues on linux and freebsd. 3. Updated comments in header files to be more descriptive Acked-by: Harini Ramakrishnan

Re: [dpdk-dev] [PATCH v7 7/8] doc: add documentation for windows

2019-03-28 Thread Harini Ramakrishnan
Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon Verified build on Windows Tested-by: Harini

Re: [dpdk-dev] [PATCH v3 1/8] stack: introduce rte stack library

2019-03-28 Thread Honnappa Nagarahalli
Hi Gage, Apologies for the late comments. > -Original Message- > From: Gage Eads > Sent: Wednesday, March 6, 2019 8:46 AM > To: dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; > bruce.richard...@intel.com; konstantin.anan...@intel.com; Gavin Hu (Arm > Technol

Re: [dpdk-dev] [PATCH v3 6/8] stack: add C11 atomic implementation

2019-03-28 Thread Honnappa Nagarahalli
> > This commit adds an implementation of the lock-free stack push, pop, and > length functions that use __atomic builtins, for systems that benefit from the > finer-grained memory ordering control. > > Signed-off-by: Gage Eads > --- > lib/librte_stack/Makefile| 3 +- > lib/librte

Re: [dpdk-dev] [PATCH v3 5/8] stack: add lock-free stack implementation

2019-03-28 Thread Honnappa Nagarahalli
> diff --git a/lib/librte_stack/rte_stack.c b/lib/librte_stack/rte_stack.c index > 96dffdf44..8f0361ea1 100644 > --- a/lib/librte_stack/rte_stack.c > +++ b/lib/librte_stack/rte_stack.c > @@ -63,9 +81,16 @@ rte_stack_create(const char *name, unsigned int > count, int socket_id, > unsigned

[dpdk-dev] [PATCH v7 8/8] build: meson changes to build on windows

2019-03-28 Thread Anand Rawat
Added meson workarounds to build helloworld on windows. Windows currently only supports kvargs and eal libraries. This change restricts the build flow to supported libraries only. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- app/

[dpdk-dev] [PATCH v7 7/8] doc: add documentation for windows

2019-03-28 Thread Anand Rawat
Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- MAINTAINERS |

[dpdk-dev] [PATCH v7 5/8] eal: add headers for compatibility with windows

2019-03-28 Thread Anand Rawat
Added headers to support windows environment for common source. These headers will have windows specific implementions of the system library apis provided in linux and freebsd. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- .../win

[dpdk-dev] [PATCH v7 6/8] eal: add minimum viable code for eal on windows

2019-03-28 Thread Anand Rawat
Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Updated header files to contain suitable function declaractions. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/windows/eal/eal.c

[dpdk-dev] [PATCH v7 4/8] eal: sys/queue.h implementation for windows

2019-03-28 Thread Anand Rawat
Adding sys/queue.h on windows for supporting common code. This implementation has BSD-3-Clause licensing. Signed-off-by: Ranjit Menon Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw --- .../windows/eal/include/sys/queue.h | 320 ++ 1 file changed, 320 insertions(+)

[dpdk-dev] [PATCH v7 0/8] HelloWorld example for windows

2019-03-28 Thread Anand Rawat
Includes Windows-specific EAL changes and meson changes to build the code on windows. v7 Changes: 1. Fixed rte_os.h not found issue on linux and freebsd. 2. Fixed missing def issues on linux and freebsd. 3. Updated comments in header files to be more descriptive v6 Changes: 1. Introduced rte_os.

[dpdk-dev] [PATCH v7 3/8] build: add module definition file for windows

2019-03-28 Thread Anand Rawat
Updated lib/meson.build to create shared libraries on windows. Added DEF files to list the exports for the eal and kvargs libraries. Signed-off-by: Bruce Richardson Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_eal/rte_eal_exports.def |

[dpdk-dev] [PATCH v7 2/8] eal: add header files to support os specifics

2019-03-28 Thread Anand Rawat
Added rte_os.h files to support os specific functionality. Updated rte_common.h to include rte_os.h. Updated lib/meson.build to inject rte_os.h in every library. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/common/

[dpdk-dev] [PATCH v7 1/8] eal: eal stub to add windows support

2019-03-28 Thread Anand Rawat
Added initial stub source files for windows support and only the required meson changes for windows. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- config/meson.build | 23 -- config/x86/meson.b

Re: [dpdk-dev] [PATCH] drivers: SPDX license id consistency

2019-03-28 Thread Thomas Monjalon
06/02/2019 23:27, Stephen Hemminger: > All drivers should have SPDX on the first line of the source > files in the format > /* SPDX-License-Identifier: ... > > Several files used minor modifications which were inconsistent > with the pattern. Fix it to make scanning tools easier. > > Signed-off

Re: [dpdk-dev] [PATCH] vfio: document multiprocess limitation for container API

2019-03-28 Thread Thomas Monjalon
27/02/2019 16:41, Anatoly Burakov: > Currently, there is no support for sharing custom VFIO containers > between multiple processes, but it is not documented. > > Document this limitation. > > Cc: sta...@dpdk.org > > Signed-off-by: Anatoly Burakov Applied, thanks

Re: [dpdk-dev] [PATCH] eal: remove redundant API description

2019-03-28 Thread Thomas Monjalon
20/03/2019 07:46, Shahaf Shuler: > Tuesday, March 19, 2019 11:16 PM, Thomas Monjalon: > > Subject: [dpdk-dev] [PATCH] eal: remove redundant API description > > > > Atomic functions are described in doxygen of the file > > lib/librte_eal/common/include/generic/rte_atomic.h > > The copies in arch-sp

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER

2019-03-28 Thread Thomas Monjalon
18/03/2019 13:58, Dekel Peled: > From previous patch description: "to improve performance on PPC64, > use light weight sync instruction instead of sync instruction." > > Excerpt from IBM doc [1], section "Memory barrier instructions": > "The second form of the sync instruction is light-weight sync

Re: [dpdk-dev] [PATCH] EAL: count nr_overcommit_hugepages as available

2019-03-28 Thread Thomas Monjalon
19/03/2019 14:52, Burakov, Anatoly: > On 25-Feb-19 8:57 PM, Michał Mirosław wrote: > > From: Michał Mirosław > > > > With nr_overcommit_hugepages > 0 application may be able to allocate > > hugepages even when free_hugepages == 0. Take this into account when > > counting available hugepages. > >

Re: [dpdk-dev] [PATCH 3/3] eal: attempt multiple hugepage allocations at init

2019-03-28 Thread Thomas Monjalon
22/02/2019 17:14, Anatoly Burakov: > When requesting memory with ``-m`` or ``--socket-mem`` flags, > currently the init will fail if the requested memory amount was > bigger than any one memseg list, even if total amount of > available memory was sufficient. > > Fix this by making EAL to attempt t

[dpdk-dev] [RFC v2] net: fix rte_vlan_insert with shared mbuf

2019-03-28 Thread Stephen Hemminger
If mbuf is shared then rte_vlan_insert() would clobber the original Ethernet header. The changed version handles this by getting an mbuf that will hold the new Ethernet and VLAN header followed by another mbuf (cloned) for the data. Fixes: c974021a5949 ("ether: add soft vlan encap/decap") Signed-o

Re: [dpdk-dev] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER

2019-03-28 Thread Pradeep Satyanarayana
Pradeep Satyanarayana/Beaverton/IBM wrote on 03/27/2019 04:50:31 PM: > From: Pradeep Satyanarayana/Beaverton/IBM > To: Thomas Monjalon > Cc: "bruce.richard...@intel.com" , Chao > Zhu , Dekel Peled , > dev@dpdk.org, David Christensen , > "honnappa.nagaraha...@arm.com" , Idan > Werpoler , "konst

[dpdk-dev] rte_mempool_create_empty/rte_mempool_populate_virt question

2019-03-28 Thread Mihail Tarta
Hi, I am wondering if the following behavior is a bug or it is by design. My scenario is the following. Let’s say that I create a file of 8MB and then mmap and mlock that in my application. I call rte_mempool_create_empty with elt_size of 4096 (getpagesize) and correct element count. Then I cal

Re: [dpdk-dev] [PATCH] fbarray: add internal tailq for mapped areas

2019-03-28 Thread Thomas Monjalon
26/02/2019 18:13, Anatoly Burakov: > Currently, there are numerous reliability issues with fbarray, > such as: > - There is no way to prevent attaching to overlapping memory > areas > - There is no way to prevent double-detach > - Failed destroy leaves fbarray in an invalid state (fbarray > its

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] mem: warn user when running without NUMA support

2019-03-28 Thread Thomas Monjalon
27/03/2019 14:35, Anatoly Burakov: > Running in non-legacy mode on a NUMA-enabled system without libnuma > is unsupported, so explicitly print out a warning when trying to > do so. > > Running in legacy mode without libnuma is still supported whether or > not we are running with libnuma support en

Re: [dpdk-dev] [PATCH v4] service: fix parameter type

2019-03-28 Thread Thomas Monjalon
28/03/2019 07:29, Nikhil Rao: > The type of value parameter to rte_service_attr_get > should be uint64_t *, since the attributes > are of type uint64_t. > > Fixes: 4d55194d76a4 ("service: add attribute get function") > > Reviewed-by: Gage Eads > Signed-off-by: Nikhil Rao > Acked-by: Harry van H

Re: [dpdk-dev] [PATCH v7 3/5] lib/mempool: allow page size aligned mempool

2019-03-28 Thread Ferruh Yigit
On 3/27/2019 9:00 AM, Xiaolong Ye wrote: > Allow create a mempool with page size aligned base address. > > Signed-off-by: Qi Zhang > Signed-off-by: Xiaolong Ye Hi Andrew, Olivier, Can you please check this patch, It is adding a new mempool flag which is dependency for the pmd. Thanks, ferruh

Re: [dpdk-dev] [PATCH v6 6/8] eal: add minimum viable code for eal on windows

2019-03-28 Thread Harini Ramakrishnan
Acked-by: Harini Ramakrishnan -Original Message- From: dev On Behalf Of Anand Rawat Sent: Wednesday, March 27, 2019 7:21 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.

Re: [dpdk-dev] [PATCH v6 7/8] doc: add documentation for windows

2019-03-28 Thread Harini Ramakrishnan
Acked-by: Harini Ramakrishnan -Original Message- From: dev On Behalf Of Anand Rawat Sent: Wednesday, March 27, 2019 7:21 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.

Re: [dpdk-dev] [PATCH v7 2/5] lib/mbuf: introduce helper to create mempool with flags

2019-03-28 Thread Ferruh Yigit
On 3/27/2019 9:00 AM, Xiaolong Ye wrote: > This allows applications to create mbuf mempool with specific flags > such as MEMPOOL_F_NO_SPREAD if they want fixed size memory objects. > > Signed-off-by: Qi Zhang > Signed-off-by: Xiaolong Ye Hi Olivier, Can you please check this patch? I would lik

Re: [dpdk-dev] [PATCH v6 8/8] build: meson changes to build on windows

2019-03-28 Thread Harini Ramakrishnan
Acked-by: Harini Ramakrishnan -Original Message- From: dev On Behalf Of Anand Rawat Sent: Wednesday, March 27, 2019 7:21 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.

Re: [dpdk-dev] [PATCH v6 4/8] eal: sys/queue.h implementation for windows

2019-03-28 Thread Harini Ramakrishnan
Acked-by: Harini Ramakrishnan -Original Message- From: dev On Behalf Of Anand Rawat Sent: Wednesday, March 27, 2019 7:21 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.

Re: [dpdk-dev] [PATCH v6 3/8] build: add module definition file for windows

2019-03-28 Thread Harini Ramakrishnan
Acked-by: Harini Ramakrishnan -Original Message- From: dev On Behalf Of Anand Rawat Sent: Wednesday, March 27, 2019 7:21 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.

Re: [dpdk-dev] [PATCH v6 5/8] eal: add headers for compatibility with windows

2019-03-28 Thread Harini Ramakrishnan
Acked-by: Harini Ramakrishnan -Original Message- From: dev On Behalf Of Anand Rawat Sent: Wednesday, March 27, 2019 7:21 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.

Re: [dpdk-dev] [PATCH v6 0/8] HelloWorld example for windows

2019-03-28 Thread Harini Ramakrishnan
Acked-by: Harini Ramakrishnan -Original Message- From: dev On Behalf Of Anand Rawat Sent: Wednesday, March 27, 2019 7:21 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.

Re: [dpdk-dev] [PATCH v6 1/8] eal: eal stub to add windows support

2019-03-28 Thread Harini Ramakrishnan
Acked-by: Harini Ramakrishnan -Original Message- From: dev On Behalf Of Anand Rawat Sent: Wednesday, March 27, 2019 7:21 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.

Re: [dpdk-dev] [PATCH v6 2/8] eal: add header files to support os specifics

2019-03-28 Thread Harini Ramakrishnan
Acked-by: Harini Ramakrishnan -Original Message- From: dev On Behalf Of Anand Rawat Sent: Wednesday, March 27, 2019 7:21 PM To: dev@dpdk.org Cc: anand.ra...@intel.com; pallavi.ka...@intel.com; ranjit.me...@intel.com; jeffrey.b.s...@intel.com; bruce.richard...@intel.com; tho...@monjalon.

Re: [dpdk-dev] [PATCH v2 6/6] examples/ipsec-secgw: config ethernet MACs dynamically

2019-03-28 Thread Ferruh Yigit
On 10/20/2017 5:34 PM, radu.nicolau at intel.com (Nicolau, Radu) wrote: > Hi, > > I think this should be a separate patch, not bundled with a series of fixes. > The guide has to be updated as well. > And probably it's best to make the MAC configuration optional, keep a default > hardcoded table.

Re: [dpdk-dev] [PATCH] checkpatch: re-enable warnings about split long strings

2019-03-28 Thread Ferruh Yigit
On 3/28/2019 7:02 PM, Ferruh Yigit wrote: > On 10/3/2017 11:56 AM, adrien.mazarguil at 6wind.com (Adrien Mazarguil) wrote: >> On Tue, Oct 03, 2017 at 11:38:13AM +0100, Bruce Richardson wrote: >>> On Mon, Oct 02, 2017 at 06:21:06PM +0200, Adrien Mazarguil wrote: On Mon, Oct 02, 2017 at 02:46:24

Re: [dpdk-dev] [PATCH] checkpatch: re-enable warnings about split long strings

2019-03-28 Thread Ferruh Yigit
On 10/3/2017 11:56 AM, adrien.mazarguil at 6wind.com (Adrien Mazarguil) wrote: > On Tue, Oct 03, 2017 at 11:38:13AM +0100, Bruce Richardson wrote: >> On Mon, Oct 02, 2017 at 06:21:06PM +0200, Adrien Mazarguil wrote: >>> On Mon, Oct 02, 2017 at 02:46:24PM +0100, Bruce Richardson wrote: On Mon,

Re: [dpdk-dev] [PATCH v2 3/3] net/mlx4: add secondary process support

2019-03-28 Thread Yongseok Koh
> On Mar 26, 2019, at 12:33 PM, Shahaf Shuler wrote: > > Monday, March 25, 2019 9:18 PM, Yongseok Koh: >> To: Shahaf Shuler >> Cc: dev@dpdk.org >> Subject: [PATCH v2 3/3] net/mlx4: add secondary process support >> >> In order to support secondary process, a few features are required. >> >> a

Re: [dpdk-dev] [PATCH v7 1/5] net/af_xdp: introduce AF XDP PMD driver

2019-03-28 Thread Luca Boccassi
On Thu, 2019-03-28 at 17:51 +, Ferruh Yigit wrote: > > @@ -143,6 +143,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL) += > > -lrte_mempool_dpaa2 > > endif > > > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += > > -lrte_pmd_af_packet > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP) += -

Re: [dpdk-dev] [PATCH v2] hash: optimize signature compare by using neon intrinsic

2019-03-28 Thread Thomas Monjalon
25/02/2019 18:52, Jerin Jacob Kollanukkaran: > On Tue, 2019-02-12 at 15:01 +0800, Ruifeng Wang wrote: > > Implemented signature compare function based on neon intrinsic. > > Hash bulk lookup had 3% - 6% performance gain after optimization. > > > > Signed-off-by: Ruifeng Wang > > Reviewed-by: Gavi

[dpdk-dev] [PATCH v4] app/testpmd: make txonly mode generate multiple flows

2019-03-28 Thread Yongseok Koh
Testpmd can generate multiple flows without taking much cost and this could be a simple traffic generator for developer's quick tests. If "--txonly-multi-flow" is specified in the command line, IP source address is varied to gnerate multiple flows. Signed-off-by: Yongseok Koh --- v4: * use uint8

Re: [dpdk-dev] [PATCH v7 5/5] net/af_xdp: enable zero copy

2019-03-28 Thread Ferruh Yigit
On 3/27/2019 9:00 AM, Xiaolong Ye wrote: > Try to check if external mempool (from rx_queue_setup) is fit for > af_xdp, if it is, it will be registered to af_xdp socket directly and > there will be no packet data copy on Rx and Tx. > > Signed-off-by: Xiaolong Ye > --- > drivers/net/af_xdp/rte_eth

Re: [dpdk-dev] [PATCH] packet_ordering: replace sync builtins with atomic builtins

2019-03-28 Thread Thomas Monjalon
03/01/2019 10:49, Phil Yang: > '__sync' builtins are deprecated, use '__atomic' builtins instead for > packet_ordering. > > Fixes: 850f373 ("examples/packet_ordering: new sample app") > > Signed-off-by: Phil Yang > Reviewed-by: Gavin Hu > Reviewed-by: Ruifeng Wang Am I right there will be a n

Re: [dpdk-dev] [PATCH v4 0/3] Replace compilation time options with log level

2019-03-28 Thread Thomas Monjalon
28/03/2019 19:26, Thomas Monjalon: > > Dharmik Thakkar (3): > > test/hash: replace macro with log-level approach > > test/efd: enable unit test compilation always > > test/timer: enable unit test compilation always > > Applied, thanks PS: for 32-bit build, I had to replace "%lu" by "%"PRIuP

Re: [dpdk-dev] [PATCH] net/mlx5: add missing return value check

2019-03-28 Thread Ferruh Yigit
On 3/28/2019 10:29 AM, Ali Alnubani wrote: > Hi Ferruh, > >> -Original Message- >> From: Ferruh Yigit >> Sent: Wednesday, March 27, 2019 11:31 AM >> To: Shahaf Shuler ; Dekel Peled >> ; Ali Alnubani ; >> dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: add missing return value ch

Re: [dpdk-dev] [PATCH v4 0/3] Replace compilation time options with log level

2019-03-28 Thread Thomas Monjalon
> Dharmik Thakkar (3): > test/hash: replace macro with log-level approach > test/efd: enable unit test compilation always > test/timer: enable unit test compilation always Applied, thanks

[dpdk-dev] [PATCH v4 7/8] test/stack: add lock-free stack tests

2019-03-28 Thread Gage Eads
This commit adds lock-free stack variants of stack_autotest (stack_lf_autotest) and stack_perf_autotest (stack_lf_perf_autotest), which differ only in that the lock-free versions pass the RTE_STACK_F_LF flag to all rte_stack_create() calls. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz ---

[dpdk-dev] [PATCH v4 8/8] mempool/stack: add lock-free stack mempool handler

2019-03-28 Thread Gage Eads
This commit adds support for lock-free (linked list based) stack mempool handler. In mempool_perf_autotest the lock-based stack outperforms the lock-free handler for certain lcore/alloc count/free count combinations*, however: - For applications with preemptible pthreads, a standard (lock-based)

[dpdk-dev] [PATCH v4 6/8] stack: add C11 atomic implementation

2019-03-28 Thread Gage Eads
This commit adds an implementation of the lock-free stack push, pop, and length functions that use __atomic builtins, for systems that benefit from the finer-grained memory ordering control. Signed-off-by: Gage Eads --- lib/librte_stack/Makefile| 3 +- lib/librte_stack/meson.build

[dpdk-dev] [PATCH v4 5/8] stack: add lock-free stack implementation

2019-03-28 Thread Gage Eads
This commit adds support for a lock-free (linked list based) stack to the stack API. This behavior is selected through a new rte_stack_create() flag, RTE_STACK_F_LF. The stack consists of a linked list of elements, each containing a data pointer and a next pointer, and an atomic stack depth counte

[dpdk-dev] [PATCH v4 4/8] test/stack: add stack perf test

2019-03-28 Thread Gage Eads
stack_perf_autotest tests the following with one lcore: - Cycles to attempt to pop an empty stack - Cycles to push then pop a single object - Cycles to push then pop a burst of 32 objects It also tests the cycles to push then pop a burst of 8 and 32 objects with the following lcore combinations (i

[dpdk-dev] [PATCH v4 1/8] stack: introduce rte stack library

2019-03-28 Thread Gage Eads
The rte_stack library provides an API for configuration and use of a bounded stack of pointers. Push and pop operations are MT-safe, allowing concurrent access, and the interface supports pushing and popping multiple pointers at a time. The library's interface is modeled after another DPDK data st

[dpdk-dev] [PATCH v4 3/8] test/stack: add stack test

2019-03-28 Thread Gage Eads
stack_autotest performs positive and negative testing of the stack API, and exercises the push and pop datapath functions with all available lcores. Signed-off-by: Gage Eads --- MAINTAINERS | 1 + app/test/Makefile | 2 + app/test/meson.build | 3 + app/test/test_stack.c | 4

[dpdk-dev] [PATCH v4 2/8] mempool/stack: convert mempool to use rte stack

2019-03-28 Thread Gage Eads
The new rte_stack library is derived from the mempool handler, so this commit removes duplicated code and simplifies the handler by migrating it to this new API. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- MAINTAINERS | 2 +- drivers/mempool/stack/Makef

[dpdk-dev] [PATCH v4 0/8] Add stack library and new mempool handler

2019-03-28 Thread Gage Eads
This patchset introduces a stack library, supporting both lock-based and lock-free stacks, and a lock-free stack mempool handler. The lock-based stack code is derived from the existing stack mempool handler, and that handler is refactored to use the stack library. The lock-free stack mempool hand

Re: [dpdk-dev] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER

2019-03-28 Thread Thomas Monjalon
28/03/2019 18:51, Pradeep Satyanarayana: > From: Pradeep Satyanarayana/Beaverton/IBM > > From: Thomas Monjalon > > > Pradeep, Chao, > > > > > > Do we have more news? > > > We must merge this patch for DPDK 19.05-rc1. > > > > > > I understand you want to try improving performance > > > by using lig

Re: [dpdk-dev] [PATCH v7 1/5] net/af_xdp: introduce AF XDP PMD driver

2019-03-28 Thread Ferruh Yigit
On 3/27/2019 9:00 AM, Xiaolong Ye wrote: > Add a new PMD driver for AF_XDP which is a proposed faster version of > AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] > [2]. > > This is the vanilla version PMD which just uses a raw buffer registered as > the umem. > > [1] ht

Re: [dpdk-dev] [PATCH v3] app/testpmd: make txonly mode generate multiple flows

2019-03-28 Thread Iremonger, Bernard
Hi Yongseok, > >> Subject: [dpdk-dev] [PATCH v3] app/testpmd: make txonly mode generate > >> multiple flows > >> > >> Testpmd can generate multiple flows without taking much cost and this > >> could be a simple traffic generator for developer's quick tests. If > >> "--txonly-multi- flow" is spec

Re: [dpdk-dev] [PATCH v3] app/testpmd: make txonly mode generate multiple flows

2019-03-28 Thread Yongseok Koh
> On Mar 28, 2019, at 3:24 AM, Iremonger, Bernard > wrote: > > Hi Yongseok, > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yongseok Koh >> Sent: Thursday, March 28, 2019 1:51 AM >> To: Lu, Wenzhuo ; Wu, Jingjing >> >> Cc: dev@dpdk.org; jer...@marvell.

Re: [dpdk-dev] [PATCH 0/2] minor lgtm warning fixes

2019-03-28 Thread Ferruh Yigit
On 3/27/2019 9:08 PM, Stephen Hemminger wrote: > Looks like the LGTM checker complains about condition > checks that are always true. > > Stephen Hemminger (2): > net/netvsc: fix lgtm static checker complaint > net/virtio: fix lgtm static checker complaint Series applied to dpdk-next-net/mast

Re: [dpdk-dev] [PATCH] mbuf: move headers not fragmented check to checksum

2019-03-28 Thread Andrew Rybchenko
Ping? (I have a number of net/sfc patches which heavily depend on this one and must not be applied without this one) Andrew. On 2/19/19 9:30 AM, Andrew Rybchenko wrote: rte_validate_tx_offload() is used in Tx prepare callbacks (RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency. Req

Re: [dpdk-dev] [PATCH] power: update for error handling

2019-03-28 Thread Burakov, Anatoly
On 28-Mar-19 3:55 PM, Lukasz Krakowiak wrote: Update for handling negative returned status from functions call. Signed-off-by: Lukasz Krakowiak --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v2 0/7] ethdev: add min/max MTU to device info

2019-03-28 Thread Ferruh Yigit
On 3/22/2019 1:01 PM, Ian Stokes wrote: > Building upon the discussion around [1], this series introduces MTU min > and MTU max variables. It also provides updates to PMD implementations > for ixgbe, i40e and IGB devices so that these variables are populated > for use when retrieving device info. >

Re: [dpdk-dev] [PATCH v2 7/7] app/testpmd: verify mtu with rte_eth_dev_info_get()

2019-03-28 Thread Ferruh Yigit
On 3/25/2019 2:20 PM, Ferruh Yigit wrote: > On 3/22/2019 1:01 PM, Ian Stokes wrote: >> This commit uses the mtu fields populated in rte_eth_dev_info_get() >> to validate the mtu value being passed in port_mtu_set(). >> >> Signed-off-by: Ian Stokes > > For patch title, I think 'rte_eth_dev_info_ge

Re: [dpdk-dev] [PATCH v3 1/1] eal: add 128-bit compare exchange (x86-64 only)

2019-03-28 Thread Eads, Gage
> 04/03/2019 21:51, Gage Eads: > > --- a/lib/librte_eal/common/include/generic/rte_atomic.h > > +++ b/lib/librte_eal/common/include/generic/rte_atomic.h > > +#if defined(RTE_ARCH_X86_64) > > +/** > > + * 128-bit integer structure. > > + */ > > +RTE_STD_C11 > > +typedef struct { > > + RTE_STD_

[dpdk-dev] [PATCH v2 3/3] net/mlx5: add jump action support for NIC

2019-03-28 Thread Ori Kam
When using Direct Rules we can add actions to jump between tables. This is extra useful since rule insertion rate is much higher on other tables compared to table zero. if no group is selected the rule is added to group 0. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5.h | 6 + driv

Re: [dpdk-dev] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER

2019-03-28 Thread Pradeep Satyanarayana
Thomas Monjalon wrote on 03/27/2019 02:19:03 AM: > From: Thomas Monjalon > To: "prad...@us.ibm.com" , Chao Zhu > > Cc: dev@dpdk.org, Dekel Peled , Shahaf Shuler > , "bruce.richard...@intel.com" > , David Christensen , > "honnappa.nagaraha...@arm.com" , > "konstantin.anan...@intel.com" , > "o

[dpdk-dev] [PATCH v2 1/3] net/mlx5: prepare Direct Verbs for Direct Rule

2019-03-28 Thread Ori Kam
This is the first patch of a series that is designed to enable the Direct Rules API. The main difference between Direct Verbs and Direct Rules from API prespective, is that in Direct Rules each action has it's own create function and the object itself is of type void. In this patch I'm adding fun

[dpdk-dev] [PATCH v2 2/3] net/mlx5: add Direct Rules API

2019-03-28 Thread Ori Kam
Adds calls to the Direct Rules API inside the glue functions. Due to difference in parameters between the Direct Rules and Direct Verbs some of the glue functions API was updated. Signed-off-by: Ori Kam --- drivers/net/mlx5/Makefile | 5 ++ drivers/net/mlx5/mlx5.c | 16 dr

[dpdk-dev] [PATCH v2 0/3] net/mlx5: Add Direct Rule support

2019-03-28 Thread Ori Kam
This patch set adds support for Direct Rules API for MLX5 driver. As more and more applications like OVS are inserting and removing large number of flows, the flow insertion rate become more critical. In current MLX5 PMD rules are inserted to the device using the FW, this limits the max insertion

[dpdk-dev] [PATCH] power: extend debugs on power instruction requests

2019-03-28 Thread Lukasz Krakowiak
Extend debugs on power instruction and cmd police destroy requests. Signed-off-by: Lukasz Krakowiak --- examples/vm_power_manager/channel_monitor.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_powe

Re: [dpdk-dev] [PATCH v5] net/nfb: new netcope driver

2019-03-28 Thread Ferruh Yigit
On 3/22/2019 12:12 PM, Rastislav Cernay wrote: > From: Rastislav Cernay > > Added new net driver for Netcope nfb cards > > Signed-off-by: Rastislav Cernay > --- > v2: remove unnecessary cast > remove unnecessary zeroing > move declaration to not mix with code > restore skeleton exam

[dpdk-dev] [PATCH] power: update for error handling

2019-03-28 Thread Lukasz Krakowiak
Update for handling negative returned status from functions call. Signed-off-by: Lukasz Krakowiak --- examples/vm_power_manager/channel_manager.c | 4 ++-- examples/vm_power_manager/channel_monitor.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/vm_power_man

Re: [dpdk-dev] [PATCH v3] app/pdump: enhance to support multi-core capture

2019-03-28 Thread Wiles, Keith
> On Mar 28, 2019, at 10:04 AM, Varghese, Vipin > wrote: > > Enhance pdump application, to allow user to run on multiple cores. > > Signed-off-by: Vipin Varghese > --- > > Change Log: > > V3: > - correct the parse_usage - Vipin Varghese > - add change log - Vipin Varghese > > V2: > - Rep

[dpdk-dev] [PATCH] telemetry: fix incorrect stat name to id mapping

2019-03-28 Thread Bruce Richardson
If we have two NIC ports which have a different set of NIC stats we can end up having two different stats registered with xstats with the same name. [Since the stats are updated in bulk as a contiguous set, the second driver re-using the registration of the first is not possible.] This causes issu

Re: [dpdk-dev] [PATCH v2] examples/distributor: detect high frequency cores

2019-03-28 Thread Hunt, David
On 28/3/2019 3:10 PM, Burakov, Anatoly wrote: On 28-Mar-19 2:42 PM, Hunt, David wrote: On 28/3/2019 1:58 PM, Burakov, Anatoly wrote: On 28-Mar-19 1:13 PM, David Hunt wrote: The distributor application is bottlenecked by the distributor core, so if we can give more frequency to this core, th

Re: [dpdk-dev] [PATCH v2] examples/distributor: detect high frequency cores

2019-03-28 Thread Burakov, Anatoly
On 28-Mar-19 2:42 PM, Hunt, David wrote: On 28/3/2019 1:58 PM, Burakov, Anatoly wrote: On 28-Mar-19 1:13 PM, David Hunt wrote: The distributor application is bottlenecked by the distributor core, so if we can give more frequency to this core, then the overall performance of the application may

Re: [dpdk-dev] [PATCH v6 8/8] build: meson changes to build on windows

2019-03-28 Thread Thomas Monjalon
28/03/2019 03:21, Anand Rawat: > Added meson workarounds to build helloworld on windows. > Windows currently only supports kvargs and eal libraries. > This change restricts the build flow to supported libraries > only. It is OK to merge few limited workarounds in the master branch, in order to sta

Re: [dpdk-dev] [PATCH] app/compress-perf: add incompressible data handling

2019-03-28 Thread Trahe, Fiona
> -Original Message- > From: Jozwiak, TomaszX > Sent: Friday, March 1, 2019 8:45 AM > To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX > > Subject: [PATCH] app/compress-perf: add incompressible data handling > > Currently, compress-perf doesn't respect incompressible > data inside one

[dpdk-dev] [PATCH v3] app/pdump: enhance to support multi-core capture

2019-03-28 Thread Vipin Varghese
Enhance pdump application, to allow user to run on multiple cores. Signed-off-by: Vipin Varghese --- Change Log: V3: - correct the parse_usage - Vipin Varghese - add change log - Vipin Varghese V2: - Replace option '-c' to '-l' - Keith Wiles --- app/pdump/main.c | 75

Re: [dpdk-dev] [PATCH] drivers/qat: fix qp numa node

2019-03-28 Thread Trahe, Fiona
> -Original Message- > From: Jozwiak, TomaszX > Sent: Tuesday, March 26, 2019 2:21 PM > To: dev@dpdk.org; sta...@dpdk.org; Trahe, Fiona ; > Jozwiak, TomaszX > > Subject: [PATCH] drivers/qat: fix qp numa node > > This patch assigns QAT queue pair resources to the correct NUMA nodes. >

[dpdk-dev] [PATCH v2] app/pdump: enhance to support multi-core capture

2019-03-28 Thread Vipin Varghese
Enhance pdump application, to allow user to run on multiple cores. Signed-off-by: Vipin Varghese --- app/pdump/main.c | 75 -- doc/guides/tools/pdump.rst | 5 +++ 2 files changed, 69 insertions(+), 11 deletions(-) diff --git a/app/pdump/main.c b/ap

Re: [dpdk-dev] [PATCH v2] examples/distributor: detect high frequency cores

2019-03-28 Thread Hunt, David
On 28/3/2019 1:58 PM, Burakov, Anatoly wrote: On 28-Mar-19 1:13 PM, David Hunt wrote: The distributor application is bottlenecked by the distributor core, so if we can give more frequency to this core, then the overall performance of the application may increase. This patch uses the rte_power

Re: [dpdk-dev] [PATCH v5 1/1] compress/qat: add dynamic sgl allocation

2019-03-28 Thread Trahe, Fiona
> -Original Message- > From: Jozwiak, TomaszX > Sent: Tuesday, March 26, 2019 1:51 PM > To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX > > Subject: [PATCH v5 1/1] compress/qat: add dynamic sgl allocation > > This patch adds dynamic SGL allocation instead of static one. > The number

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga: modify log output

2019-03-28 Thread Ferruh Yigit
On 3/27/2019 1:32 AM, Andy Pei wrote: > print function name in ifpga log and a new line goes after every IFPGA log. > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Cc: rosen...@intel.com > Cc: andy@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Andy Pei (Carryi

Re: [dpdk-dev] [PATCH] net: fix rte_vlan_insert with shared mbuf

2019-03-28 Thread Ferruh Yigit
On 3/27/2019 3:31 PM, Chas Williams wrote: > > > On 3/27/19 11:18 AM, Stephen Hemminger wrote: >> On Tue, 26 Mar 2019 18:38:57 -0400 >> Chas Williams <3ch...@gmail.com> wrote: >> >>> On 3/26/19 3:15 PM, Stephen Hemminger wrote: If mbuf refcnt was > 1 then rte_vlan_insert() would incorrectly

Re: [dpdk-dev] [PATCH v8 0/3] ticketlock: implement ticketlock and add test case

2019-03-28 Thread Thomas Monjalon
> > Joyce Kong (3): > > eal/ticketlock: ticket based to improve fairness > > eal/ticketlock: enable generic ticketlock on all arch > > test/ticketlock: add ticket lock test case > > > > MAINTAINERS| 5 + > > app/test/Makefile

  1   2   >